Fixed building offscreen video driver without EGL support Also did miscellaneous style cleanup for consistency with other code
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549
diff --git a/src/video/offscreen/SDL_offscreenevents.c b/src/video/offscreen/SDL_offscreenevents.c
index a14e0b2..092f19b 100644
--- a/src/video/offscreen/SDL_offscreenevents.c
+++ b/src/video/offscreen/SDL_offscreenevents.c
@@ -18,7 +18,6 @@
misrepresented as being the original software.
3. This notice may not be removed or altered from any source distribution.
*/
-
#include "../../SDL_internal.h"
#if SDL_VIDEO_DRIVER_OFFSCREEN
diff --git a/src/video/offscreen/SDL_offscreenevents_c.h b/src/video/offscreen/SDL_offscreenevents_c.h
index 3d26149..6768d3d 100644
--- a/src/video/offscreen/SDL_offscreenevents_c.h
+++ b/src/video/offscreen/SDL_offscreenevents_c.h
@@ -18,11 +18,8 @@
misrepresented as being the original software.
3. This notice may not be removed or altered from any source distribution.
*/
-
#include "../../SDL_internal.h"
-#include "SDL_offscreenvideo.h"
-
extern void OFFSCREEN_PumpEvents(_THIS);
/* vi: set ts=4 sw=4 expandtab: */
diff --git a/src/video/offscreen/SDL_offscreenframebuffer.c b/src/video/offscreen/SDL_offscreenframebuffer.c
index 3ca57e8..c2d99e5 100644
--- a/src/video/offscreen/SDL_offscreenframebuffer.c
+++ b/src/video/offscreen/SDL_offscreenframebuffer.c
@@ -18,7 +18,6 @@
misrepresented as being the original software.
3. This notice may not be removed or altered from any source distribution.
*/
-
#include "../../SDL_internal.h"
#if SDL_VIDEO_DRIVER_OFFSCREEN
diff --git a/src/video/offscreen/SDL_offscreenframebuffer_c.h b/src/video/offscreen/SDL_offscreenframebuffer_c.h
index 82ae06c..ae1ad7b 100644
--- a/src/video/offscreen/SDL_offscreenframebuffer_c.h
+++ b/src/video/offscreen/SDL_offscreenframebuffer_c.h
@@ -18,7 +18,6 @@
misrepresented as being the original software.
3. This notice may not be removed or altered from any source distribution.
*/
-
#include "../../SDL_internal.h"
extern int SDL_OFFSCREEN_CreateWindowFramebuffer(_THIS, SDL_Window * window, Uint32 * format, void ** pixels, int *pitch);
diff --git a/src/video/offscreen/SDL_offscreenopengl.c b/src/video/offscreen/SDL_offscreenopengl.c
deleted file mode 100644
index 8764152..0000000
--- a/src/video/offscreen/SDL_offscreenopengl.c
+++ /dev/null
@@ -1,108 +0,0 @@
-/*
- Simple DirectMedia Layer
- Copyright (C) 1997-2022 Sam Lantinga <slouken@libsdl.org>
-
- This software is provided 'as-is', without any express or implied
- warranty. In no event will the authors be held liable for any damages
- arising from the use of this software.
-
- Permission is granted to anyone to use this software for any purpose,
- including commercial applications, and to alter it and redistribute it
- freely, subject to the following restrictions:
-
- 1. The origin of this software must not be misrepresented; you must not
- claim that you wrote the original software. If you use this software
- in a product, an acknowledgment in the product documentation would be
- appreciated but is not required.
- 2. Altered source versions must be plainly marked as such, and must not be
- misrepresented as being the original software.
- 3. This notice may not be removed or altered from any source distribution.
-*/
-
-#include "../../SDL_internal.h"
-
-#if SDL_VIDEO_DRIVER_OFFSCREEN
-
-#include "SDL_offscreenopengl.h"
-
-#include "SDL_opengl.h"
-
-int
-OFFSCREEN_GL_SwapWindow(_THIS, SDL_Window* window)
-{
- OFFSCREEN_Window* offscreen_wind = window->driverdata;
-
- SDL_EGL_SwapBuffers(_this, offscreen_wind->egl_surface);
- return 0;
-}
-
-int
-OFFSCREEN_GL_MakeCurrent(_THIS, SDL_Window* window, SDL_GLContext context)
-{
- if (window) {
- EGLSurface egl_surface = ((OFFSCREEN_Window*)window->driverdata)->egl_surface;
- return SDL_EGL_MakeCurrent(_this, egl_surface, context);
- }
-
- return SDL_EGL_MakeCurrent(_this, NULL, NULL);
-}
-
-SDL_GLContext
-OFFSCREEN_GL_CreateContext(_THIS, SDL_Window* window)
-{
- OFFSCREEN_Window* offscreen_window = window->driverdata;
-
- SDL_GLContext context;
- context = SDL_EGL_CreateContext(_this, offscreen_window->egl_surface);
-
- return context;
-}
-
-int
-OFFSCREEN_GL_LoadLibrary(_THIS, const char* path)
-{
- int ret = SDL_EGL_LoadLibraryOnly(_this, path);
- if (ret != 0) {
- return ret;
- }
-
- /* driver_loaded gets incremented by SDL_GL_LoadLibrary when we return,
- but SDL_EGL_InitializeOffscreen checks that we're loaded before then,
- so temporarily bump it since we know that LoadLibraryOnly succeeded. */
-
- _this->gl_config.driver_loaded++;
- ret = SDL_EGL_InitializeOffscreen(_this, 0);
- _this->gl_config.driver_loaded--;
- if (ret != 0) {
- return ret;
- }
-
- ret = SDL_EGL_ChooseConfig(_this);
- if (ret != 0) {
- return ret;
- }
-
- return 0;
-}
-
-void
-OFFSCREEN_GL_UnloadLibrary(_THIS)
-{
- SDL_EGL_UnloadLibrary(_this);
-}
-
-void*
-OFFSCREEN_GL_GetProcAddress(_THIS, const char* proc)
-{
- void* proc_addr = SDL_EGL_GetProcAddress(_this, proc);
-
- if (!proc_addr) {
- SDL_SetError("Failed to find proc address!");
- }
-
- return proc_addr;
-}
-
-#endif /* SDL_VIDEO_DRIVER_OFFSCREEN */
-
-/* vi: set ts=4 sw=4 expandtab: */
diff --git a/src/video/offscreen/SDL_offscreenopengl.h b/src/video/offscreen/SDL_offscreenopengl.h
deleted file mode 100644
index 1e2df69..0000000
--- a/src/video/offscreen/SDL_offscreenopengl.h
+++ /dev/null
@@ -1,54 +0,0 @@
-/*
- Simple DirectMedia Layer
- Copyright (C) 1997-2022 Sam Lantinga <slouken@libsdl.org>
-
- This software is provided 'as-is', without any express or implied
- warranty. In no event will the authors be held liable for any damages
- arising from the use of this software.
-
- Permission is granted to anyone to use this software for any purpose,
- including commercial applications, and to alter it and redistribute it
- freely, subject to the following restrictions:
-
- 1. The origin of this software must not be misrepresented; you must not
- claim that you wrote the original software. If you use this software
- in a product, an acknowledgment in the product documentation would be
- appreciated but is not required.
- 2. Altered source versions must be plainly marked as such, and must not be
- misrepresented as being the original software.
- 3. This notice may not be removed or altered from any source distribution.
-*/
-
-#ifndef _SDL_offscreenopengl_h
-#define _SDL_offscreenopengl_h
-
-#include "SDL_offscreenwindow.h"
-
-#include "../SDL_egl_c.h"
-
-#define OFFSCREEN_GL_DeleteContext SDL_EGL_DeleteContext
-#define OFFSCREEN_GL_GetSwapInterval SDL_EGL_GetSwapInterval
-#define OFFSCREEN_GL_SetSwapInterval SDL_EGL_SetSwapInterval
-
-extern int
-OFFSCREEN_GL_SwapWindow(_THIS, SDL_Window* window);
-
-extern int
-OFFSCREEN_GL_MakeCurrent(_THIS, SDL_Window* window, SDL_GLContext context);
-
-extern SDL_GLContext
-OFFSCREEN_GL_CreateContext(_THIS, SDL_Window* window);
-
-extern int
-OFFSCREEN_GL_LoadLibrary(_THIS, const char* path);
-
-extern void
-OFFSCREEN_GL_UnloadLibrary(_THIS);
-
-extern void*
-OFFSCREEN_GL_GetProcAddress(_THIS, const char* proc);
-
-#endif /* _SDL_offscreenopengl_h */
-
-/* vi: set ts=4 sw=4 expandtab: */
-
diff --git a/src/video/offscreen/SDL_offscreenopengles.c b/src/video/offscreen/SDL_offscreenopengles.c
new file mode 100644
index 0000000..a379ad7
--- /dev/null
+++ b/src/video/offscreen/SDL_offscreenopengles.c
@@ -0,0 +1,90 @@
+/*
+ Simple DirectMedia Layer
+ Copyright (C) 1997-2022 Sam Lantinga <slouken@libsdl.org>
+
+ This software is provided 'as-is', without any express or implied
+ warranty. In no event will the authors be held liable for any damages
+ arising from the use of this software.
+
+ Permission is granted to anyone to use this software for any purpose,
+ including commercial applications, and to alter it and redistribute it
+ freely, subject to the following restrictions:
+
+ 1. The origin of this software must not be misrepresented; you must not
+ claim that you wrote the original software. If you use this software
+ in a product, an acknowledgment in the product documentation would be
+ appreciated but is not required.
+ 2. Altered source versions must be plainly marked as such, and must not be
+ misrepresented as being the original software.
+ 3. This notice may not be removed or altered from any source distribution.
+*/
+#include "../../SDL_internal.h"
+
+#if SDL_VIDEO_DRIVER_OFFSCREEN && SDL_VIDEO_OPENGL_EGL
+
+#include "SDL_offscreenopengles.h"
+#include "SDL_offscreenvideo.h"
+#include "SDL_offscreenwindow.h"
+
+/* EGL implementation of SDL OpenGL support */
+
+int
+OFFSCREEN_GLES_LoadLibrary(_THIS, const char* path)
+{
+ int ret = SDL_EGL_LoadLibraryOnly(_this, path);
+ if (ret != 0) {
+ return ret;
+ }
+
+ /* driver_loaded gets incremented by SDL_GL_LoadLibrary when we return,
+ but SDL_EGL_InitializeOffscreen checks that we're loaded before then,
+ so temporarily bump it since we know that LoadLibraryOnly succeeded. */
+
+ _this->gl_config.driver_loaded++;
+ ret = SDL_EGL_InitializeOffscreen(_this, 0);
+ _this->gl_config.driver_loaded--;
+ if (ret != 0) {
+ return ret;
+ }
+
+ ret = SDL_EGL_ChooseConfig(_this);
+ if (ret != 0) {
+ return ret;
+ }
+
+ return 0;
+}
+
+SDL_GLContext
+OFFSCREEN_GLES_CreateContext(_THIS, SDL_Window* window)
+{
+ OFFSCREEN_Window* offscreen_window = window->driverdata;
+
+ SDL_GLContext context;
+ context = SDL_EGL_CreateContext(_this, offscreen_window->egl_surface);
+
+ return context;
+}
+
+int
+OFFSCREEN_GLES_MakeCurrent(_THIS, SDL_Window* window, SDL_GLContext context)
+{
+ if (window) {
+ EGLSurface egl_surface = ((OFFSCREEN_Window*)window->driverdata)->egl_surface;
+ return SDL_EGL_MakeCurrent(_this, egl_surface, context);
+ } else {
+ return SDL_EGL_MakeCurrent(_this, NULL, NULL);
+ }
+}
+
+int
+OFFSCREEN_GLES_SwapWindow(_THIS, SDL_Window* window)
+{
+ OFFSCREEN_Window* offscreen_wind = window->driverdata;
+
+ return SDL_EGL_SwapBuffers(_this, offscreen_wind->egl_surface);
+}
+
+#endif /* SDL_VIDEO_DRIVER_OFFSCREEN && SDL_VIDEO_OPENGL_EGL */
+
+/* vi: set ts=4 sw=4 expandtab: */
diff --git a/src/video/offscreen/SDL_offscreenopengles.h b/src/video/offscreen/SDL_offscreenopengles.h
new file mode 100644
index 0000000..6c9e518
--- /dev/null
+++ b/src/video/offscreen/SDL_offscreenopengles.h
@@ -0,0 +1,47 @@
+/*
+ Simple DirectMedia Layer
+ Copyright (C) 1997-2022 Sam Lantinga <slouken@libsdl.org>
+
+ This software is provided 'as-is', without any express or implied
+ warranty. In no event will the authors be held liable for any damages
+ arising from the use of this software.
+
+ Permission is granted to anyone to use this software for any purpose,
+ including commercial applications, and to alter it and redistribute it
+ freely, subject to the following restrictions:
+
+ 1. The origin of this software must not be misrepresented; you must not
+ claim that you wrote the original software. If you use this software
+ in a product, an acknowledgment in the product documentation would be
+ appreciated but is not required.
+ 2. Altered source versions must be plainly marked as such, and must not be
+ misrepresented as being the original software.
+ 3. This notice may not be removed or altered from any source distribution.
+*/
+#include "../../SDL_internal.h"
+
+#ifndef _SDL_offscreenopengles_h
+#define _SDL_offscreenopengles_h
+
+#if SDL_VIDEO_DRIVER_OFFSCREEN && SDL_VIDEO_OPENGL_EGL
+
+#include "../SDL_sysvideo.h"
+#include "../SDL_egl_c.h"
+
+#define OFFSCREEN_GLES_GetProcAddress SDL_EGL_GetProcAddress
+#define OFFSCREEN_GLES_UnloadLibrary SDL_EGL_UnloadLibrary
+#define OFFSCREEN_GLES_GetSwapInterval SDL_EGL_GetSwapInterval
+#define OFFSCREEN_GLES_SetSwapInterval SDL_EGL_SetSwapInterval
+#define OFFSCREEN_GLES_DeleteContext SDL_EGL_DeleteContext
+
+extern int OFFSCREEN_GLES_LoadLibrary(_THIS, const char *path);
+extern SDL_GLContext OFFSCREEN_GLES_CreateContext(_THIS, SDL_Window *window);
+extern int OFFSCREEN_GLES_MakeCurrent(_THIS, SDL_Window *window, SDL_GLContext context);
+extern int OFFSCREEN_GLES_SwapWindow(_THIS, SDL_Window *window);
+
+#endif /* SDL_VIDEO_DRIVER_OFFSCREEN && SDL_VIDEO_OPENGL_EGL */
+
+#endif /* _SDL_offscreenopengles_h */
+
+/* vi: set ts=4 sw=4 expandtab: */
+
diff --git a/src/video/offscreen/SDL_offscreenvideo.c b/src/video/offscreen/SDL_offscreenvideo.c
index 3e1aafe..8e62e88 100644
--- a/src/video/offscreen/SDL_offscreenvideo.c
+++ b/src/video/offscreen/SDL_offscreenvideo.c
@@ -18,7 +18,6 @@
misrepresented as being the original software.
3. This notice may not be removed or altered from any source distribution.
*/
-
#include "../../SDL_internal.h"
#if SDL_VIDEO_DRIVER_OFFSCREEN
@@ -32,15 +31,12 @@
*/
#include "SDL_video.h"
-#include "SDL_mouse.h"
-#include "../SDL_sysvideo.h"
-#include "../SDL_pixels_c.h"
-#include "../../events/SDL_events_c.h"
#include "SDL_offscreenvideo.h"
#include "SDL_offscreenevents_c.h"
#include "SDL_offscreenframebuffer_c.h"
-#include "SDL_offscreenopengl.h"
+#include "SDL_offscreenopengles.h"
+#include "SDL_offscreenwindow.h"
#define OFFSCREENVID_DRIVER_NAME "offscreen"
@@ -79,16 +75,18 @@ OFFSCREEN_CreateDevice(void)
device->DestroyWindowFramebuffer = SDL_OFFSCREEN_DestroyWindowFramebuffer;
device->free = OFFSCREEN_DeleteDevice;
+#if SDL_VIDEO_OPENGL_EGL
/* GL context */
- device->GL_SwapWindow = OFFSCREEN_GL_SwapWindow;
- device->GL_MakeCurrent = OFFSCREEN_GL_MakeCurrent;
- device->GL_CreateContext = OFFSCREEN_GL_CreateContext;
- device->GL_DeleteContext = OFFSCREEN_GL_DeleteContext;
- device->GL_LoadLibrary = OFFSCREEN_GL_LoadLibrary;
- device->GL_UnloadLibrary = OFFSCREEN_GL_UnloadLibrary;
- device->GL_GetProcAddress = OFFSCREEN_GL_GetProcAddress;
- device->GL_GetSwapInterval = OFFSCREEN_GL_GetSwapInterval;
- device->GL_SetSwapInterval = OFFSCREEN_GL_SetSwapInterval;
+ device->GL_SwapWindow = OFFSCREEN_GLES_SwapWindow;
+ device->GL_MakeCurrent = OFFSCREEN_GLES_MakeCurrent;
+ device->GL_CreateContext = OFFSCREEN_GLES_CreateContext;
+ device->GL_DeleteContext = OFFSCREEN_GLES_DeleteContext;
+ device->GL_LoadLibrary = OFFSCREEN_GLES_LoadLibrary;
+ device->GL_UnloadLibrary = OFFSCREEN_GLES_UnloadLibrary;
+ device->GL_GetProcAddress = OFFSCREEN_GLES_GetProcAddress;
+ device->GL_GetSwapInterval = OFFSCREEN_GLES_GetSwapInterval;
+ device->GL_SetSwapInterval = OFFSCREEN_GLES_SetSwapInterval;
+#endif
/* "Window" */
device->CreateSDLWindow = OFFSCREEN_CreateWindow;
@@ -106,7 +104,6 @@ int
OFFSCREEN_VideoInit(_THIS)
{
SDL_DisplayMode mode;
- SDL_Mouse *mouse = NULL;
/* Use a fake 32-bpp desktop mode */
mode.format = SDL_PIXELFORMAT_RGB888;
diff --git a/src/video/offscreen/SDL_offscreenvideo.h b/src/video/offscreen/SDL_offscreenvideo.h
index eae512b..b943a82 100644
--- a/src/video/offscreen/SDL_offscreenvideo.h
+++ b/src/video/offscreen/SDL_offscreenvideo.h
@@ -18,14 +18,12 @@
misrepresented as being the original software.
3. This notice may not be removed or altered from any source distribution.
*/
-
#include "../../SDL_internal.h"
#ifndef _SDL_offscreenvideo_h
#define _SDL_offscreenvideo_h
#include "../SDL_sysvideo.h"
-#include "../SDL_egl_c.h"
#endif /* _SDL_offscreenvideo_h */
diff --git a/src/video/offscreen/SDL_offscreenwindow.c b/src/video/offscreen/SDL_offscreenwindow.c
index 6697b01..1730308 100644
--- a/src/video/offscreen/SDL_offscreenwindow.c
+++ b/src/video/offscreen/SDL_offscreenwindow.c
@@ -18,7 +18,6 @@
misrepresented as being the original software.
3. This notice may not be removed or altered from any source distribution.
*/
-
#include "../../SDL_internal.h"
#if SDL_VIDEO_DRIVER_OFFSCREEN
@@ -31,7 +30,7 @@
int
OFFSCREEN_CreateWindow(_THIS, SDL_Window* window)
{
- OFFSCREEN_Window* offscreen_window = SDL_calloc(1, sizeof(OFFSCREEN_Window));
+ OFFSCREEN_Window *offscreen_window = SDL_calloc(1, sizeof(OFFSCREEN_Window));
if (!offscreen_window) {
return SDL_OutOfMemory();
@@ -49,6 +48,7 @@ OFFSCREEN_CreateWindow(_THIS, SDL_Window* window)
offscreen_window->sdl_window = window;
+#if SDL_VIDEO_OPENGL_EGL
if (window->flags & SDL_WINDOW_OPENGL) {
if (!_this->egl_data) {
@@ -61,10 +61,10 @@ OFFSCREEN_CreateWindow(_THIS, SDL_Window* window)
return SDL_SetError("Failed to created an offscreen surface (EGL display: %p)",
_this->egl_data->egl_display);
}
- }
- else {
+ } else {
offscreen_window->egl_surface = EGL_NO_SURFACE;
}
+#endif /* SDL_VIDEO_OPENGL_EGL */
return 0;
}
@@ -75,7 +75,9 @@ OFFSCREEN_DestroyWindow(_THIS, SDL_Window* window)
OFFSCREEN_Window* offscreen_window = window->driverdata;
if (offscreen_window) {
+#if SDL_VIDEO_OPENGL_EGL
SDL_EGL_DestroySurface(_this, offscreen_window->egl_surface);
+#endif
SDL_free(offscreen_window);
}
diff --git a/src/video/offscreen/SDL_offscreenwindow.h b/src/video/offscreen/SDL_offscreenwindow.h
index 74c85d2..5540794 100644
--- a/src/video/offscreen/SDL_offscreenwindow.h
+++ b/src/video/offscreen/SDL_offscreenwindow.h
@@ -18,27 +18,24 @@
misrepresented as being the original software.
3. This notice may not be removed or altered from any source distribution.
*/
+#include "../../SDL_internal.h"
#ifndef _SDL_offscreenwindow_h
#define _SDL_offscreenwindow_h
-#include "../SDL_sysvideo.h"
-#include "SDL_syswm.h"
-
#include "SDL_offscreenvideo.h"
typedef struct {
SDL_Window* sdl_window;
+#if SDL_VIDEO_OPENGL_EGL
EGLSurface egl_surface;
+#endif
} OFFSCREEN_Window;
-extern int
-OFFSCREEN_CreateWindow(_THIS, SDL_Window* window);
-
-extern void
-OFFSCREEN_DestroyWindow(_THIS, SDL_Window* window);
+extern int OFFSCREEN_CreateWindow(_THIS, SDL_Window *window);
+extern void OFFSCREEN_DestroyWindow(_THIS, SDL_Window *window);
#endif /* _SDL_offscreenwindow */