opengl: Backed out hg changeset 94f9f40a957f This is the OpenGL line drawing fix for Bugzilla #3182, but there's some disagreement about what the renderers should do here, so I'm backing this out until after 2.0.12 ships, and then we'll reevaluate all the renderer backends to decide what's correct, and make them all work the same.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327
diff --git a/src/render/opengl/SDL_render_gl.c b/src/render/opengl/SDL_render_gl.c
index 41b26df..133a20b 100644
--- a/src/render/opengl/SDL_render_gl.c
+++ b/src/render/opengl/SDL_render_gl.c
@@ -866,60 +866,6 @@ GL_QueueDrawPoints(SDL_Renderer * renderer, SDL_RenderCommand *cmd, const SDL_FP
}
static int
-GL_QueueDrawLines(SDL_Renderer * renderer, SDL_RenderCommand *cmd, const SDL_FPoint * points, int count)
-{
- GLfloat *verts;
- int i;
-
- SDL_assert(count >= 2); /* should have been checked at the higher level. */
-
- verts = (GLfloat *) SDL_AllocateRenderVertices(renderer, (count-1) * 4 * sizeof (GLfloat), 0, &cmd->data.draw.first);
- if (!verts) {
- return -1;
- }
-
- cmd->data.draw.count = count;
-
- /* GL_LINE_STRIP seems to be unreliable on various drivers, so try
- to build out our own GL_LINES. :(
- If the line segment is completely horizontal or vertical,
- make it one pixel longer, to satisfy the diamond-exit rule.
- We should probably do this for diagonal lines too, but we'd have to
- do some trigonometry to figure out the correct pixel and generally
- when we have problems with pixel perfection, it's for straight lines
- that are missing a pixel that frames something and not arbitrary
- angles. Maybe !!! FIXME for later, though. */
-
- for (i = 0; i < count-1; i++, points++) {
- GLfloat xstart = 0.5f + points[0].x; /* 0.5f to get to the center of the pixel. */
- GLfloat ystart = 0.5f + points[0].y;
- GLfloat xend = 0.5f + points[1].x;
- GLfloat yend = 0.5f + points[1].y;
-
- if (xstart == xend) { /* vertical line */
- if (yend > ystart) {
- yend += 1.0f;
- } else {
- ystart += 1.0f;
- }
- } else if (ystart == yend) { /* horizontal line */
- if (xend > xstart) {
- xend += 1.0f;
- } else {
- xstart += 1.0f;
- }
- }
-
- *(verts++) = xstart;
- *(verts++) = ystart;
- *(verts++) = xend;
- *(verts++) = yend;
- }
-
- return 0;
-}
-
-static int
GL_QueueFillRects(SDL_Renderer * renderer, SDL_RenderCommand *cmd, const SDL_FRect * rects, int count)
{
GLfloat *verts = (GLfloat *) SDL_AllocateRenderVertices(renderer, count * 4 * sizeof (GLfloat), 0, &cmd->data.draw.first);
@@ -1282,14 +1228,59 @@ GL_RunCommandQueue(SDL_Renderer * renderer, SDL_RenderCommand *cmd, void *vertic
case SDL_RENDERCMD_DRAW_LINES: {
const GLfloat *verts = (GLfloat *) (((Uint8 *) vertices) + cmd->data.draw.first);
const size_t count = cmd->data.draw.count;
- SDL_assert(count >= 2);
SetDrawState(data, cmd, SHADER_SOLID);
- data->glBegin(GL_LINES);
- for (i = 0; i < count-1; ++i, verts += 4) {
- data->glVertex2f(verts[0], verts[1]);
- data->glVertex2f(verts[2], verts[3]);
+ if (count > 2 && (verts[0] == verts[(count-1)*2]) && (verts[1] == verts[(count*2)-1])) {
+ data->glBegin(GL_LINE_LOOP);
+ /* GL_LINE_LOOP takes care of the final segment */
+ for (i = 1; i < count; ++i, verts += 2) {
+ data->glVertex2f(verts[0], verts[1]);
+ }
+ data->glEnd();
+ } else {
+ #if defined(__MACOSX__) || defined(__WIN32__)
+ #else
+ int x1, y1, x2, y2;
+ #endif
+
+ data->glBegin(GL_LINE_STRIP);
+ for (i = 0; i < count; ++i, verts += 2) {
+ data->glVertex2f(verts[0], verts[1]);
+ }
+ data->glEnd();
+ verts -= 2 * count;
+
+ /* The line is half open, so we need one more point to complete it.
+ * http://www.opengl.org/documentation/specs/version1.1/glspec1.1/node47.html
+ * If we have to, we can use vertical line and horizontal line textures
+ * for vertical and horizontal lines, and then create custom textures
+ * for diagonal lines and software render those. It's terrible, but at
+ * least it would be pixel perfect.
+ */
+
+ data->glBegin(GL_POINTS);
+ #if defined(__MACOSX__) || defined(__WIN32__)
+ /* Mac OS X and Windows seem to always leave the last point open */
+ data->glVertex2f(verts[(count-1)*2], verts[(count*2)-1]);
+ #else
+ /* Linux seems to leave the right-most or bottom-most point open */
+ x1 = verts[0];
+ y1 = verts[1];
+ x2 = verts[(count-1)*2];
+ y2 = verts[(count*2)-1];
+
+ if (x1 > x2) {
+ data->glVertex2f(x1, y1);
+ } else if (x2 > x1) {
+ data->glVertex2f(x2, y2);
+ }
+ if (y1 > y2) {
+ data->glVertex2f(x1, y1);
+ } else if (y2 > y1) {
+ data->glVertex2f(x2, y2);
+ }
+ #endif
+ data->glEnd();
}
- data->glEnd();
break;
}
@@ -1628,7 +1619,7 @@ GL_CreateRenderer(SDL_Window * window, Uint32 flags)
renderer->QueueSetViewport = GL_QueueSetViewport;
renderer->QueueSetDrawColor = GL_QueueSetViewport; /* SetViewport and SetDrawColor are (currently) no-ops. */
renderer->QueueDrawPoints = GL_QueueDrawPoints;
- renderer->QueueDrawLines = GL_QueueDrawLines;
+ renderer->QueueDrawLines = GL_QueueDrawPoints; /* lines and points queue vertices the same way. */
renderer->QueueFillRects = GL_QueueFillRects;
renderer->QueueCopy = GL_QueueCopy;
renderer->QueueCopyEx = GL_QueueCopyEx;
diff --git a/src/render/opengles/SDL_render_gles.c b/src/render/opengles/SDL_render_gles.c
index 387acf3..044a1be 100644
--- a/src/render/opengles/SDL_render_gles.c
+++ b/src/render/opengles/SDL_render_gles.c
@@ -562,60 +562,6 @@ GLES_QueueDrawPoints(SDL_Renderer * renderer, SDL_RenderCommand *cmd, const SDL_
}
static int
-GLES_QueueDrawLines(SDL_Renderer * renderer, SDL_RenderCommand *cmd, const SDL_FPoint * points, int count)
-{
- GLfloat *verts;
- int i;
-
- SDL_assert(count >= 2); /* should have been checked at the higher level. */
-
- verts = (GLfloat *) SDL_AllocateRenderVertices(renderer, (count-1) * 4 * sizeof (GLfloat), 0, &cmd->data.draw.first);
- if (!verts) {
- return -1;
- }
-
- cmd->data.draw.count = count;
-
- /* GL_LINE_STRIP seems to be unreliable on various drivers, so try
- to build out our own GL_LINES. :(
- If the line segment is completely horizontal or vertical,
- make it one pixel longer, to satisfy the diamond-exit rule.
- We should probably do this for diagonal lines too, but we'd have to
- do some trigonometry to figure out the correct pixel and generally
- when we have problems with pixel perfection, it's for straight lines
- that are missing a pixel that frames something and not arbitrary
- angles. Maybe !!! FIXME for later, though. */
-
- for (i = 0; i < count-1; i++, points++) {
- GLfloat xstart = 0.5f + points[0].x; /* 0.5f to get to the center of the pixel. */
- GLfloat ystart = 0.5f + points[0].y;
- GLfloat xend = 0.5f + points[1].x;
- GLfloat yend = 0.5f + points[1].y;
-
- if (xstart == xend) { /* vertical line */
- if (yend > ystart) {
- yend += 1.0f;
- } else {
- ystart += 1.0f;
- }
- } else if (ystart == yend) { /* horizontal line */
- if (xend > xstart) {
- xend += 1.0f;
- } else {
- xstart += 1.0f;
- }
- }
-
- *(verts++) = xstart;
- *(verts++) = ystart;
- *(verts++) = xend;
- *(verts++) = yend;
- }
-
- return 0;
-}
-
-static int
GLES_QueueFillRects(SDL_Renderer * renderer, SDL_RenderCommand *cmd, const SDL_FRect * rects, int count)
{
GLfloat *verts = (GLfloat *) SDL_AllocateRenderVertices(renderer, count * 8 * sizeof (GLfloat), 0, &cmd->data.draw.first);
@@ -955,10 +901,16 @@ GLES_RunCommandQueue(SDL_Renderer * renderer, SDL_RenderCommand *cmd, void *vert
case SDL_RENDERCMD_DRAW_LINES: {
const GLfloat *verts = (GLfloat *) (((Uint8 *) vertices) + cmd->data.draw.first);
const size_t count = cmd->data.draw.count;
- SDL_assert(count >= 2);
SetDrawState(data, cmd);
data->glVertexPointer(2, GL_FLOAT, 0, verts);
- data->glDrawArrays(GL_LINES, 0, (GLsizei) ((count-1) * 2));
+ if (count > 2 && (verts[0] == verts[(count-1)*2]) && (verts[1] == verts[(count*2)-1])) {
+ /* GL_LINE_LOOP takes care of the final segment */
+ data->glDrawArrays(GL_LINE_LOOP, 0, (GLsizei) (count - 1));
+ } else {
+ data->glDrawArrays(GL_LINE_STRIP, 0, (GLsizei) count);
+ /* We need to close the endpoint of the line */
+ data->glDrawArrays(GL_POINTS, (GLsizei) (count - 1), 1);
+ }
break;
}
@@ -1207,7 +1159,7 @@ GLES_CreateRenderer(SDL_Window * window, Uint32 flags)
renderer->QueueSetViewport = GLES_QueueSetViewport;
renderer->QueueSetDrawColor = GLES_QueueSetViewport; /* SetViewport and SetDrawColor are (currently) no-ops. */
renderer->QueueDrawPoints = GLES_QueueDrawPoints;
- renderer->QueueDrawLines = GLES_QueueDrawLines;
+ renderer->QueueDrawLines = GLES_QueueDrawPoints; /* lines and points queue vertices the same way. */
renderer->QueueFillRects = GLES_QueueFillRects;
renderer->QueueCopy = GLES_QueueCopy;
renderer->QueueCopyEx = GLES_QueueCopyEx;
diff --git a/src/render/opengles2/SDL_render_gles2.c b/src/render/opengles2/SDL_render_gles2.c
index 0a432e0..fb83c87 100644
--- a/src/render/opengles2/SDL_render_gles2.c
+++ b/src/render/opengles2/SDL_render_gles2.c
@@ -784,60 +784,6 @@ GLES2_QueueDrawPoints(SDL_Renderer * renderer, SDL_RenderCommand *cmd, const SDL
}
static int
-GLES2_QueueDrawLines(SDL_Renderer * renderer, SDL_RenderCommand *cmd, const SDL_FPoint * points, int count)
-{
- GLfloat *verts;
- int i;
-
- SDL_assert(count >= 2); /* should have been checked at the higher level. */
-
- verts = (GLfloat *) SDL_AllocateRenderVertices(renderer, (count-1) * 4 * sizeof (GLfloat), 0, &cmd->data.draw.first);
- if (!verts) {
- return -1;
- }
-
- cmd->data.draw.count = count;
-
- /* GL_LINE_STRIP seems to be unreliable on various drivers, so try
- to build out our own GL_LINES. :(
- If the line segment is completely horizontal or vertical,
- make it one pixel longer, to satisfy the diamond-exit rule.
- We should probably do this for diagonal lines too, but we'd have to
- do some trigonometry to figure out the correct pixel and generally
- when we have problems with pixel perfection, it's for straight lines
- that are missing a pixel that frames something and not arbitrary
- angles. Maybe !!! FIXME for later, though. */
-
- for (i = 0; i < count-1; i++, points++) {
- GLfloat xstart = 0.5f + points[0].x; /* 0.5f to get to the center of the pixel. */
- GLfloat ystart = 0.5f + points[0].y;
- GLfloat xend = 0.5f + points[1].x;
- GLfloat yend = 0.5f + points[1].y;
-
- if (xstart == xend) { /* vertical line */
- if (yend > ystart) {
- yend += 1.0f;
- } else {
- ystart += 1.0f;
- }
- } else if (ystart == yend) { /* horizontal line */
- if (xend > xstart) {
- xend += 1.0f;
- } else {
- xstart += 1.0f;
- }
- }
-
- *(verts++) = xstart;
- *(verts++) = ystart;
- *(verts++) = xend;
- *(verts++) = yend;
- }
-
- return 0;
-}
-
-static int
GLES2_QueueFillRects(SDL_Renderer * renderer, SDL_RenderCommand *cmd, const SDL_FRect * rects, int count)
{
GLfloat *verts = (GLfloat *) SDL_AllocateRenderVertices(renderer, count * 8 * sizeof (GLfloat), 0, &cmd->data.draw.first);
@@ -1348,10 +1294,17 @@ GLES2_RunCommandQueue(SDL_Renderer * renderer, SDL_RenderCommand *cmd, void *ver
}
case SDL_RENDERCMD_DRAW_LINES: {
+ const GLfloat *verts = (GLfloat *) (((Uint8 *) vertices) + cmd->data.draw.first);
const size_t count = cmd->data.draw.count;
- SDL_assert(count >= 2);
if (SetDrawState(data, cmd, GLES2_IMAGESOURCE_SOLID) == 0) {
- data->glDrawArrays(GL_LINES, 0, (GLsizei) ((count-1) * 2));
+ if (count > 2 && (verts[0] == verts[(count-1)*2]) && (verts[1] == verts[(count*2)-1])) {
+ /* GL_LINE_LOOP takes care of the final segment */
+ data->glDrawArrays(GL_LINE_LOOP, 0, (GLsizei) (count - 1));
+ } else {
+ data->glDrawArrays(GL_LINE_STRIP, 0, (GLsizei) count);
+ /* We need to close the endpoint of the line */
+ data->glDrawArrays(GL_POINTS, (GLsizei) (count - 1), 1);
+ }
}
break;
}
@@ -2146,7 +2099,7 @@ GLES2_CreateRenderer(SDL_Window *window, Uint32 flags)
renderer->QueueSetViewport = GLES2_QueueSetViewport;
renderer->QueueSetDrawColor = GLES2_QueueSetViewport; /* SetViewport and SetDrawColor are (currently) no-ops. */
renderer->QueueDrawPoints = GLES2_QueueDrawPoints;
- renderer->QueueDrawLines = GLES2_QueueDrawLines;
+ renderer->QueueDrawLines = GLES2_QueueDrawPoints; /* lines and points queue vertices the same way. */
renderer->QueueFillRects = GLES2_QueueFillRects;
renderer->QueueCopy = GLES2_QueueCopy;
renderer->QueueCopyEx = GLES2_QueueCopyEx;