Commit a4eb0dea863e4ae182c7bcd0562c161d6dfc25ad

Sam Lantinga 2015-06-14T19:10:51

Fixed bug 2908 - Fix clang warnings Simon Deschenes My build system still shows warning as errors. The first warning says that the member named instances can never be false (or NULL) as it is a static array, and we should check for instances[index] which we do anyway.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
diff --git a/src/render/opengles2/SDL_render_gles2.c b/src/render/opengles2/SDL_render_gles2.c
index 1e539ae..7254cb7 100644
--- a/src/render/opengles2/SDL_render_gles2.c
+++ b/src/render/opengles2/SDL_render_gles2.c
@@ -1030,9 +1030,6 @@ GLES2_CacheShader(SDL_Renderer *renderer, GLES2_ShaderType type, SDL_BlendMode b
     /* Find a matching shader instance that's supported on this hardware */
     for (i = 0; i < shader->instance_count && !instance; ++i) {
         for (j = 0; j < data->shader_format_count && !instance; ++j) {
-            if (!shader->instances) {
-                continue;
-            }
             if (!shader->instances[i]) {
                 continue;
             }