Commit d5a578531bdf29f4bd062c2c6dcfee57ecca507e

Ryan C. Gordon 2015-05-26T16:42:36

Drop out of SDL_UpdateTexture() early if the rectangle is zero pixels. Hopefully makes static analysis happy about a zero-byte malloc elsewhere.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
diff --git a/src/render/SDL_render.c b/src/render/SDL_render.c
index d6a986d..e7f823c 100644
--- a/src/render/SDL_render.c
+++ b/src/render/SDL_render.c
@@ -820,7 +820,9 @@ SDL_UpdateTexture(SDL_Texture * texture, const SDL_Rect * rect,
         rect = &full_rect;
     }
 
-    if (texture->yuv) {
+    if ((rect->w == 0) || (rect->h == 0)) {
+        return 0;  /* nothing to do. */
+    } else if (texture->yuv) {
         return SDL_UpdateTextureYUV(texture, rect, pixels, pitch);
     } else if (texture->native) {
         return SDL_UpdateTextureNative(texture, rect, pixels, pitch);