Commit e43ff8fb59cdce46b79842a7edd47603b8ccad44

Ryan C. Gordon 2013-08-20T12:43:06

Added some FIXMEs for later.

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
diff --git a/src/core/windows/SDL_windows.h b/src/core/windows/SDL_windows.h
index 440c387..91a7f46 100644
--- a/src/core/windows/SDL_windows.h
+++ b/src/core/windows/SDL_windows.h
@@ -35,10 +35,13 @@
 #include <windows.h>
 
 /* Routines to convert from UTF8 to native Windows text */
+/* !!! FIXME: should we force Unicode at this point? */
 #if UNICODE
+/* !!! FIXME: UCS-2 should be UTF-16 on Windows. */
 #define WIN_StringToUTF8(S) SDL_iconv_string("UTF-8", "UCS-2-INTERNAL", (char *)(S), (SDL_wcslen(S)+1)*sizeof(WCHAR))
 #define WIN_UTF8ToString(S) (WCHAR *)SDL_iconv_string("UCS-2-INTERNAL", "UTF-8", (char *)(S), SDL_strlen(S)+1)
 #else
+/* !!! FIXME: UTF8ToString() can just be a SDL_strdup() here. */
 #define WIN_StringToUTF8(S) SDL_iconv_string("UTF-8", "ASCII", (char *)(S), (SDL_strlen(S)+1))
 #define WIN_UTF8ToString(S) SDL_iconv_string("ASCII", "UTF-8", (char *)(S), SDL_strlen(S)+1)
 #endif