Commit e49321cec5806c05b6b67404052f953f3e0f2987

Sam Lantinga 2022-08-10T08:20:54

Fixed double-free in combined HIDAPI controller code

1
2
3
4
5
6
7
8
9
10
11
12
diff --git a/src/joystick/hidapi/SDL_hidapi_combined.c b/src/joystick/hidapi/SDL_hidapi_combined.c
index 27da8dd..06f3d55 100644
--- a/src/joystick/hidapi/SDL_hidapi_combined.c
+++ b/src/joystick/hidapi/SDL_hidapi_combined.c
@@ -90,7 +90,6 @@ HIDAPI_DriverCombined_OpenJoystick(SDL_HIDAPI_Device *device, SDL_Joystick *joys
                 } else {
                     SDL_strlcpy(new_serial, joystick->serial, new_length);
                 }
-                SDL_free(serial);
                 serial = new_serial;
                 serial_length = new_length;
             }