Cache the fact that a device didn't look like a joystick Fixes https://github.com/libsdl-org/SDL/issues/5211
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38
diff --git a/src/joystick/linux/SDL_sysjoystick.c b/src/joystick/linux/SDL_sysjoystick.c
index 851448a..39bd991 100644
--- a/src/joystick/linux/SDL_sysjoystick.c
+++ b/src/joystick/linux/SDL_sysjoystick.c
@@ -109,6 +109,7 @@ typedef struct SDL_joylist_item
/* Steam Controller support */
SDL_bool m_bSteamController;
+ SDL_bool checked_mapping;
SDL_GamepadMapping *mapping;
} SDL_joylist_item;
@@ -1573,9 +1574,13 @@ LINUX_JoystickGetGamepadMapping(int device_index, SDL_GamepadMapping *out)
SDL_Joystick *joystick;
SDL_joylist_item *item = JoystickByDevIndex(device_index);
- if (item->mapping) {
- SDL_memcpy(out, item->mapping, sizeof(*out));
- return SDL_TRUE;
+ if (item->checked_mapping) {
+ if (item->mapping) {
+ SDL_memcpy(out, item->mapping, sizeof(*out));
+ return SDL_TRUE;
+ } else {
+ return SDL_FALSE;
+ }
}
/* We temporarily open the device to check how it's configured. Make
@@ -1595,6 +1600,8 @@ LINUX_JoystickGetGamepadMapping(int device_index, SDL_GamepadMapping *out)
return SDL_FALSE;
}
+ item->checked_mapping = SDL_TRUE;
+
if (PrepareJoystickHwdata(joystick, item) == -1) {
SDL_free(joystick->hwdata);
SDL_free(joystick);