kc3-lang/SDL

• Show log

  Commit

• Hash : 38549a7b
  Author :
  Date : 2015-06-04T00:56:11
  

  Fixed bug 2625 - Direct3D9 with SDL_TEXTUREACCESS_TARGET textures causes an application crash
  
  Roberto
  
  I have debugged the code checking the function calls when Direct3D is the renderer, remember that with software and OpenGL renderers, this issue is not happening.
  
  - Create the texture:
  SDL_Texture *pTex = SDL_CreateTexture(pRenderer, iFormat, SDL_TEXTUREACCESS_TARGET, pSurf->w, pSurf->h);
  
  - Update the texture:
  SDL_UpdateTexture(pTex, NULL, pSurf->pixels, pSurf->pitch);
    SDL_render.c, SDL_UpdateTexture(): return renderer->UpdateTexture(renderer, texture, rect, pixels, pitch);
      SDL_render_d3d.c, D3D_UpdateTexture(): if (D3D_UpdateTextureRep(data->device, &texturedata->texture, texture->format, rect->x, rect->y, rect->w, rect->h, pixels, pitch) < 0) {
        SDL_render_d3d.c, D3D_UpdateTextureRep(): if (D3D_CreateStagingTexture(device, texture) < 0) {
          SDL_render_d3d.c, D3D_CreateStagingTexture(): result = IDirect3DDevice9_CreateTexture(..., D3DPOOL_SYSTEMMEM, ...) --> FAIL! with INVALIDCALL code
  
  After checking a bit the Microsoft documentation, I found this:
  
  D3DUSAGE_RENDERTARGET can only be used with D3DPOOL_DEFAULT. (https://msdn.microsoft.com/en-us/library/windows/desktop/bb172625%28v=vs.85%29.aspx)
  
  The call that fails, is using D3DUSAGE_RENDERTARGET with D3DPOOL_SYSTEMMEM which is unsupported, hence the INVALIDCALL return code.
  

• Files

• .hgignore
• Android.mk
• BUGS.txt
• CMakeLists.txt
• COPYING.txt
• CREDITS.txt
• INSTALL.txt
• Makefile.in
• Makefile.minimal
• Makefile.pandora
• Makefile.psp
• Makefile.wiz
• README-SDL.txt
• README.txt
• SDL2.spec.in
• TODO.txt
• VisualC-WinRT/
• VisualC.html
• VisualC/
• WhatsNew.txt
• Xcode-iOS/
• Xcode/
• acinclude/
• android-project/
• autogen.sh
• build-scripts/
• cmake/
• cmake_uninstall.cmake.in
• configure
• configure.in
• debian/
• docs/
• include/
• premake/
• sdl2-config.in
• sdl2.m4
• sdl2.pc.in
• src/
• test/
• visualtest/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/SDL.git
  Git SSH	git@git.kmx.io:kc3-lang/SDL.git
  Public access ?	public
  Description	Fork of https://github.com/libsdl-org/SDL
  Users
  Tags