-
Show log
Commit
-
Hash : 990e166a
Author :
Date : 2019-06-08T19:02:42
Fixed bug 3894 - Fuzzing crashes for SDL_LoadWAV Simon Hug I had a look at this and made some additions to SDL_wave.c. The attached patch adds many checks and error messages. For some reason I also added A-law and ?-law decoders. Forgot exactly why... but hey, they're small. The WAVE format is seriously underspecified (at least by the documents that are publicly available on the internet) and it's a shame Microsoft never put something better out there. The language used in them is so loose at times, it's not surprising the encoders and decoders behave very differently. The Windows Media Player doesn't even support MS ADPCM correctly. The patch also adds some hints to make the decoder more strict at the cost of compatibility with weird WAVE files. I still think it needs a bit of cleaning up (Not happy with the MultiplySize function. Don't like the name and other SDL code may want to use something like this too.) and some duplicated code may be folded together. It does work in this state and I have thrown all kinds of WAVE files at it. The AFL files also pass with it and some even play (obviously just noise). Crafty little fuzzer. Any critique would be welcome. I have a fork of SDL with a audio-loadwav branch over here if someone wants to use the commenting feature of Bitbucket: https://bitbucket.org/ChliHug/SDL I also cobbled some Lua scripts together to create WAVE test files: https://bitbucket.org/ChliHug/gendat
-
Files
- SDL.h
- SDL_assert.h
- SDL_atomic.h
- SDL_audio.h
- SDL_bits.h
- SDL_blendmode.h
- SDL_clipboard.h
- SDL_config.h
- SDL_config.h.cmake
- SDL_config.h.in
- SDL_config_android.h
- SDL_config_iphoneos.h
- SDL_config_macosx.h
- SDL_config_minimal.h
- SDL_config_os2.h
- SDL_config_pandora.h
- SDL_config_psp.h
- SDL_config_windows.h
- SDL_config_winrt.h
- SDL_config_wiz.h
- SDL_copying.h
- SDL_cpuinfo.h
- SDL_egl.h
- SDL_endian.h
- SDL_error.h
- SDL_events.h
- SDL_filesystem.h
- SDL_gamecontroller.h
- SDL_gesture.h
- SDL_haptic.h
- SDL_hints.h
- SDL_joystick.h
- SDL_keyboard.h
- SDL_keycode.h
- SDL_loadso.h
- SDL_log.h
- SDL_main.h
- SDL_messagebox.h
- SDL_mouse.h
- SDL_mutex.h
- SDL_name.h
- SDL_opengl.h
- SDL_opengl_glext.h
- SDL_opengles.h
- SDL_opengles2.h
- SDL_opengles2_gl2.h
- SDL_opengles2_gl2ext.h
- SDL_opengles2_gl2platform.h
- SDL_opengles2_khrplatform.h
- SDL_pixels.h
- SDL_platform.h
- SDL_power.h
- SDL_quit.h
- SDL_rect.h
- SDL_render.h
- SDL_revision.h
- SDL_rwops.h
- SDL_scancode.h
- SDL_sensor.h
- SDL_shape.h
- SDL_stdinc.h
- SDL_surface.h
- SDL_system.h
- SDL_syswm.h
- SDL_test.h
- SDL_test_assert.h
- SDL_test_common.h
- SDL_test_compare.h
- SDL_test_crc32.h
- SDL_test_font.h
- SDL_test_fuzzer.h
- SDL_test_harness.h
- SDL_test_images.h
- SDL_test_log.h
- SDL_test_md5.h
- SDL_test_memory.h
- SDL_test_random.h
- SDL_thread.h
- SDL_timer.h
- SDL_touch.h
- SDL_types.h
- SDL_version.h
- SDL_video.h
- SDL_vulkan.h
- begin_code.h
- close_code.h
-
Properties
-
Git HTTP https://git.kmx.io/kc3-lang/SDL.git Git SSH git@git.kmx.io:kc3-lang/SDL.git Public access ? public Description Users
Tags
