-
Show log
Commit
-
Hash : a1a2f9b9
Author :
Date : 2019-06-12T10:32:36
Fixed bug 4486 - Segfault when pressing a trigger on the Steam Controller (Linux) Matteo Beniamino Pressing a trigger button on a Steam Controller causes a segmentation fault both with stable version and latest mercurial head on Linux. I'm using the recent hid_steam kernel module with lizard_mode disabled (that is no keyboard/mouse emulation). I suspect this is what's happening: the driver exposes two hats. The two hats have indices 0 and 2. Inside linux/SDL_sysjoystick.c two hats are allocated in allocate_hatdata for joystick->hwdata->hats. In HandleHat function the hat parameter (that can be 2) is directly used as the index of the array that only has two elements, causing an out of bounds access. SDL is not expecting to have "holes" between hats indices. The index 2 is calculated in HandleInputEvents() as (ABS_HAT2X - ABS_HAT0X) / 2 where ABS_HAT2X is the value associated to the hat inside the hid_steam module.
-
Files
- .hgignore
- Android.mk
- BUGS.txt
- CMakeLists.txt
- COPYING.txt
- CREDITS.txt
- INSTALL.txt
- Makefile.in
- Makefile.minimal
- Makefile.os2
- Makefile.pandora
- Makefile.psp
- Makefile.wiz
- README-SDL.txt
- README.txt
- SDL2.spec.in
- SDL2Config.cmake
- TODO.txt
- VisualC-WinRT/
- VisualC.html
- VisualC/
- WhatsNew.txt
- Xcode-iOS/
- Xcode/
- acinclude/
- android-project-ant/
- android-project/
- autogen.sh
- build-scripts/
- cmake/
- cmake_uninstall.cmake.in
- configure
- configure.ac
- debian/
- docs/
- include/
- sdl2-config.cmake.in
- sdl2-config.in
- sdl2.m4
- sdl2.pc.in
- src/
- test/
- visualtest/
- wayland-protocols/
-
Properties
-
Git HTTP https://git.kmx.io/kc3-lang/SDL.git Git SSH git@git.kmx.io:kc3-lang/SDL.git Public access ? public Description Users
Tags
-
README.txt
-
Simple DirectMedia Layer (SDL) Version 2.0 --- https://www.libsdl.org/ Simple DirectMedia Layer is a cross-platform development library designed to provide low level access to audio, keyboard, mouse, joystick, and graphics hardware via OpenGL and Direct3D. It is used by video playback software, emulators, and popular games including Valve's award winning catalog and many Humble Bundle games. More extensive documentation is available in the docs directory, starting with README.md Enjoy! Sam Lantinga (slouken@libsdl.org)