kc3-lang/SDL/src

Diff

• Show log

  Commit

• Hash : b5ea3c6d
  Author :
  Date : 2017-08-11T21:30:06
  

  Fixed bug 3284 - minor correction for SDL_setenv on _WIN32__ platform
  
  Coriiander
  
  Here is a minor correction for a non-breaking mistake in SDL_setenv for __WIN32__ platform. See below for details.
  
  FILE:
  "SDL/src/stdlib/SDL_getenv.c"
  
  FUNCTION: (__WIN32__ platform)
  int SDL_setenv(const char *name, const char *value, int overwrite)
  
  CODE:
      if (!overwrite) {
          char ch = 0;
          const size_t len = GetEnvironmentVariableA(name, &ch, sizeof (ch));
          if (len > 0) {
              return 0;  /* asked not to overwrite existing value. */
          }
      }
  
  
  WHAT'S WRONG:
  The 3th argument to GetEnvironmentVariable (being DWORD nSize) must be the number of characters, not the number of bytes. SDL currently passes "the size of 1 char", rather "1". While it is non-breaking (1=1 after all), it is incorrect. Furthermore there is no need to specify the 2nd and 3th arguments at all.
  
  CORRECTION 1: (corrected argument_
      if (!overwrite) {
          char ch = 0;
          const size_t len = GetEnvironmentVariableA(name, &ch, 1);
          if (len > 0) {
              return 0;  /* asked not to overwrite existing value. */
          }
      }
  
  CORRECTION 2: (stripped of unneeded code)
      if (!overwrite) {
          if (GetEnvironmentVariableA(name, NULL, 0) > 0) {
              return 0;  /* asked not to overwrite existing value. */
          }
      }
  

• Files

• SDL.c
• SDL_assert.c
• SDL_assert_c.h
• SDL_dataqueue.c
• SDL_dataqueue.h
• SDL_error.c
• SDL_error_c.h
• SDL_hints.c
• SDL_internal.h
• SDL_log.c
• atomic/
• audio/
• core/
• cpuinfo/
• dynapi/
• events/
• file/
• filesystem/
• haptic/
• joystick/
• libm/
• loadso/
• main/
• power/
• render/
• stdlib/
• test/
• thread/
• timer/
• video/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/SDL.git
  Git SSH	git@git.kmx.io:kc3-lang/SDL.git
  Public access ?	public
  Description	Fork of https://github.com/libsdl-org/SDL
  Users
  Tags