-
Show log
Commit
-
Hash : 7c0986fb
Author :
Date : 2020-06-12T10:30:46
Fixed bug 4938 - Suggestion: rename SDL_PIXELFORMAT_BGR888 to SDL_PIXELFORMAT_XBGR8888 Ellie I just tripped over this: stb_image when requesting 3 channels with 8-bit actually returns them as 3 bytes per pixel with no alignment, so basically 4 pixels are 12 bytes with no padding (0...2, 3...5, 6...8, and 9...11). This I would have naively expected to be called RGB888 or BGR888, since there is no "dead" unused byte as I would expect for something called e.g. RGBX8888. However, SDL2's SDL_PIXELFORMAT_BGR888 uses 4 bytes, same as SDL_PIXELFORMAT_BGRX8888, even though the latter appears to be a longer storage format - which it isn't, internally. It's just swapped, in byte order X, B, G, R (instead of BGRX). So why isn't the macro name also swapped, as "XBGR888" instead of just "BGR888"? I find the formats therefore named inconsistently, and unless there is a reason for this I suggest these changes: 1. deprecate SDL_PIXELFORMAT_BGR888 in favor of a new SDL_PIXELFORMAT_XBGR8888 and 2. deprecate SDL_PIXELFORMAT_RGB888 in favor of a new SDL_PIXELFORMAT_XRGB8888
-
Files
- SDL.h
- SDL_assert.h
- SDL_atomic.h
- SDL_audio.h
- SDL_bits.h
- SDL_blendmode.h
- SDL_clipboard.h
- SDL_config.h
- SDL_config.h.cmake
- SDL_config.h.in
- SDL_config_android.h
- SDL_config_iphoneos.h
- SDL_config_macosx.h
- SDL_config_minimal.h
- SDL_config_os2.h
- SDL_config_pandora.h
- SDL_config_psp.h
- SDL_config_windows.h
- SDL_config_winrt.h
- SDL_config_wiz.h
- SDL_copying.h
- SDL_cpuinfo.h
- SDL_egl.h
- SDL_endian.h
- SDL_error.h
- SDL_events.h
- SDL_filesystem.h
- SDL_gamecontroller.h
- SDL_gesture.h
- SDL_haptic.h
- SDL_hints.h
- SDL_joystick.h
- SDL_keyboard.h
- SDL_keycode.h
- SDL_loadso.h
- SDL_locale.h
- SDL_log.h
- SDL_main.h
- SDL_messagebox.h
- SDL_metal.h
- SDL_mouse.h
- SDL_mutex.h
- SDL_name.h
- SDL_opengl.h
- SDL_opengl_glext.h
- SDL_opengles.h
- SDL_opengles2.h
- SDL_opengles2_gl2.h
- SDL_opengles2_gl2ext.h
- SDL_opengles2_gl2platform.h
- SDL_opengles2_khrplatform.h
- SDL_pixels.h
- SDL_platform.h
- SDL_power.h
- SDL_quit.h
- SDL_rect.h
- SDL_render.h
- SDL_revision.h
- SDL_rwops.h
- SDL_scancode.h
- SDL_sensor.h
- SDL_shape.h
- SDL_stdinc.h
- SDL_surface.h
- SDL_system.h
- SDL_syswm.h
- SDL_test.h
- SDL_test_assert.h
- SDL_test_common.h
- SDL_test_compare.h
- SDL_test_crc32.h
- SDL_test_font.h
- SDL_test_fuzzer.h
- SDL_test_harness.h
- SDL_test_images.h
- SDL_test_log.h
- SDL_test_md5.h
- SDL_test_memory.h
- SDL_test_random.h
- SDL_thread.h
- SDL_timer.h
- SDL_touch.h
- SDL_types.h
- SDL_version.h
- SDL_video.h
- SDL_vulkan.h
- begin_code.h
- close_code.h
-
Properties
-
Git HTTP https://git.kmx.io/kc3-lang/SDL.git Git SSH git@git.kmx.io:kc3-lang/SDL.git Public access ? public Description Users
Tags
