kc3-lang/SDL/src

Diff

• Show log

  Commit

• Hash : f0a4fea8
  Author :
  Date : 2019-04-25T14:17:07
  

  Fixed bug 4608 - Android: not getting SDL_WINDOWEVENT_FOCUS_GAINED on start of our app
  
  Dan Ginsburg
  
  I've seen this on several devices including Moto Z running Android 7 and a Snapdragon 845 running Android 9.
  
  What happens is as follows:
  
  SDLActivity.onWindowFocusChanged(true) happens pretty early on, but it's before we've done SDL_CreateWindow and so Android_Window is 0x0 thus this message does not get sent:
  
  JNIEXPORT void JNICALL SDL_JAVA_INTERFACE(nativeFocusChanged)(
                                      JNIEnv *env, jclass cls, jboolean hasFocus)
  {
      SDL_LockMutex(Android_ActivityMutex);
  
      if (Android_Window) {
          __android_log_print(ANDROID_LOG_VERBOSE, "SDL", "nativeFocusChanged()");
          SDL_SendWindowEvent(Android_Window, (hasFocus ? SDL_WINDOWEVENT_FOCUS_GAINED : SDL_WINDOWEVENT_FOCUS_LOST), 0, 0);
      }
  
      SDL_UnlockMutex(Android_ActivityMutex);
  }
  
  When the window does get created, in Android_CreateWindow it does this:
  
   window->flags &= ~SDL_WINDOW_RESIZABLE;     /* window is NEVER resizeable */
      window->flags &= ~SDL_WINDOW_HIDDEN;
      window->flags |= SDL_WINDOW_SHOWN;          /* only one window on Android */
      window->flags |= SDL_WINDOW_INPUT_FOCUS;    /* always has input focus */
  
      /* One window, it always has focus */
      SDL_SetMouseFocus(window);
      SDL_SetKeyboardFocus(window);
  
  The SDL_SetKeyboardFocus does send an SDL_WINDOWEVENT_FOCUS_GAINED message, but it gets eaten in SDL_SendWindowEvent because we've forced SDL_WINDOW_INPUT_FOCUS beforehand:
  
   case SDL_WINDOWEVENT_FOCUS_GAINED:
          if (window->flags & SDL_WINDOW_INPUT_FOCUS) {
              return 0;
          }
          window->flags |= SDL_WINDOW_INPUT_FOCUS;
          SDL_OnWindowFocusGained(window);
          break;
  
  I can fix the problem if I comment out this line from Android_CreateWindow:
  
      window->flags |= SDL_WINDOW_INPUT_FOCUS;    /* always has input focus */
  
  I would propose that as a fix unless there is a reason not to.
  

• Files

• SDL.c
• SDL_assert.c
• SDL_assert_c.h
• SDL_dataqueue.c
• SDL_dataqueue.h
• SDL_error.c
• SDL_error_c.h
• SDL_hints.c
• SDL_internal.h
• SDL_log.c
• atomic/
• audio/
• core/
• cpuinfo/
• dynapi/
• events/
• file/
• filesystem/
• haptic/
• hidapi/
• joystick/
• libm/
• loadso/
• main/
• power/
• render/
• sensor/
• stdlib/
• test/
• thread/
• timer/
• video/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/SDL.git
  Git SSH	git@git.kmx.io:kc3-lang/SDL.git
  Public access ?	public
  Description	Fork of https://github.com/libsdl-org/SDL
  Users
  Tags