kc3-lang/SDL/src

Diff

• Show log

  Commit

• Hash : f6fdbc1e
  Author :
  Date : 2021-11-29T21:16:15
  

  video: x11: Fix an invalid SDL_LogError() call
  
  This fixes a compile warning — and possible invalid memory read —
  introduced in 9c03d255 ("Add back X11 legacy WM_NAME encodings"), which
  was part of PR #5029, fixing Bug #4924.
  
  The issue is with one of the added warnings in X11_GetWindowTitle().
  Basically, the "title" variable passed to SDL_LogError() hasn't been
  initialised yet: we could pass propdata in directly, but it's better to
  move the SDL_LogError() call until after title is set, IMHO.
  
  This fixes the following warning from gcc (SUSE Linux) 11.2.1:
  In file included from /home/david/Development/SDL/src/video/x11/../../SDL_internal.h:45,
                   from /home/david/Development/SDL/src/video/x11/SDL_x11window.c:21:
  /home/david/Development/SDL/src/video/x11/SDL_x11window.c: In function 'X11_GetWindowTitle':
  /home/david/Development/SDL/src/video/x11/../../dynapi/SDL_dynapi_overrides.h:33:22: warning: '%s' directive argument is null [-Wformat-overflow=]
     33 | #define SDL_LogDebug SDL_LogDebug_REAL
  /home/david/Development/SDL/src/video/x11/SDL_x11window.c:720:13: note: in expansion of macro 'SDL_LogDebug'
    720 |             SDL_LogDebug(SDL_LOG_CATEGORY_VIDEO, "Failed to convert WM_NAME title expecting UTF8! Title: %s", title);
        |             ^~~~~~~~~~~~
  

• Files

• SDL.c
• SDL_assert.c
• SDL_assert_c.h
• SDL_dataqueue.c
• SDL_dataqueue.h
• SDL_error.c
• SDL_error_c.h
• SDL_hints.c
• SDL_hints_c.h
• SDL_internal.h
• SDL_log.c
• atomic/
• audio/
• core/
• cpuinfo/
• dynapi/
• events/
• file/
• filesystem/
• haptic/
• hidapi/
• joystick/
• libm/
• loadso/
• locale/
• main/
• misc/
• power/
• render/
• sensor/
• stdlib/
• test/
• thread/
• timer/
• video/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/SDL.git
  Git SSH	git@git.kmx.io:kc3-lang/SDL.git
  Public access ?	public
  Description	Fork of https://github.com/libsdl-org/SDL
  Users
  Tags