kc3-lang/angle

2024-03-28T10:15:42

Remove test suppression of dEQP-EGL*robustness on Pixel 6 Previoustly the tests dEQP-EGL*robustness*out_of_bounds_non_robust* were skipped on Pixel 6, because the test is intentionally testing in GLES, shader write out of bounds access results in undefined behavior. In ANGLE vulkan backend, shader write out-of-bounds access results in vulkan device lost on Pixel 6, which is a valid undefined vulkan behavior according to spec. However, VVL is reporting errors when ANGLE cleans up vulkan resources, because they haven't finished execution on GPU. With below VVL changes landed: https://github.com/KhronosGroup/Vulkan-ValidationLayers/commit/9452b82820276eb3eb2102bf49b72e59916d3ea7 https://github.com/KhronosGroup/Vulkan-ValidationLayers/commit/af257b1c55f312b550addeca091265c249c09cf3 VVL now checks if there is a vulkan device lost upon resource clean-up. If the vulkan device is lost, even if the resource has not finished execution, treat resource clean up as a safe vulkan operation and do not report VVL error. Bug: b/289544394 Change-Id: I9d3532d4d6b0c3a1cdfd8837e13b4527d0dfbd7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5403212 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>