Commit 2f0b6429b41c9024f6eb9d7938e7de5e42ad61bb
2022-05-23T21:20:13
Revert "util/X11Window: Set PMinSize and PMaxSize hints." This reverts commit a78eca2cab5f7826c1719e47fca229086ec06947. Reason for revert: We suspect this CL is causing rendering issues on Linux swiftshader bots: https://bugs.chromium.org/p/angleproject/issues/detail?id=7336. Some trace test only has part of the screen rendered: https://angle-gold.skia.org/detail?test=raid_shadow_legends&digest=a4eb4b3f306f31798c5e86dcf34d0f35. Revert it to check if it helps the resolving the render issues on bots. Original change's description: > util/X11Window: Set PMinSize and PMaxSize hints. > > Before this patch replay windows were down-sized to match the default > screen size in case their extent was greater than the screen size. > > Setting a PMinSize on XSizeHints resolves the issue on modern window > managers. Tested with GNOME Shell 41.3 with both native X11 and Wayland > (over XWayland) backends. > Setting PMaxSize was also requried to pass the > BlitFramebufferANGLETest tests. > > This fixes retracing with correct extents and resolves a VVL performance > warning. > > Bug: angleproject:6808 > Bug: angleproject:7083 > Change-Id: I00ee149ec02efe08c5801e4231913049d31e262b > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3507514 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Bug: angleproject:6808 Bug: angleproject:7083 Bug: angleproject:7336 Change-Id: Ibe15e549d1f1965f0c3832190f02144bb63da16a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3661210 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>