Commit 317870f9c0eef628ec30af0abaac2a1fdd5531cf
2022-03-08T14:47:14
Reland "util/X11Window: Set PMinSize and PMaxSize hints." This is a reland of commit a78eca2cab5f7826c1719e47fca229086ec06947 Revert https://crrev.com/c/3661210 refers to cropping on SwS bots which might be due to another X11 related issue I recently fixed (https://crrev.com/c/3979168) Lack of min width/height is triggering a swapchain recreation with smaller extents due to window being resized by the WM: https://anglebug.com/7840#c2 Also, capturing screenshots past the first frame (--screenshot-frame=2) results in partial screenshots. Original change's description: > util/X11Window: Set PMinSize and PMaxSize hints. > > Before this patch replay windows were down-sized to match the default > screen size in case their extent was greater than the screen size. > > Setting a PMinSize on XSizeHints resolves the issue on modern window > managers. Tested with GNOME Shell 41.3 with both native X11 and Wayland > (over XWayland) backends. > Setting PMaxSize was also requried to pass the > BlitFramebufferANGLETest tests. > > This fixes retracing with correct extents and resolves a VVL performance > warning. > > Bug: angleproject:6808 > Bug: angleproject:7083 > Change-Id: I00ee149ec02efe08c5801e4231913049d31e262b > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3507514 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Bug: angleproject:6808 Bug: angleproject:7083 Bug: angleproject:7840 Change-Id: Ide540ecf55c2c0f39635f2b6b0688d7c2ddffc0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4048025 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>