kc3-lang/angle

2024-03-14T16:00:20

Vulkan: Add test that destroys view after the image A depth/stencil blit path can create temp views. Temp objects are added to ContextVk::mCurrentGarbage, which is **appended** to the Renderer's garbage list. If the image from which the view was created is released before the next submission (i.e. it's appended to the garbage list before ContextVk::mCurrentGarbage), the image can be destroyed before its dependent view is. This is not triggering any validation error however, so there doesn't seem to be a need for a fix. For posterity, if this ordering needs to be fixed in the future, we can simply remove `ContextVk::mCurrentGarbage` and add garbage to the renderer directly. This was made possible a while back when the context was able to allocate its submission serial right away. (Previously, the serial had to be determined after submission, which is why temp objects were kept in ContextVk until that serial is known) Bug: chromium:40942995 Change-Id: I8a1270e635193dd7aff5b63cbf63c0c6a1fc061f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5370782 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>