Commit a0f54ac04c520dab8089bed6b325fe3582a92edb
2025-03-26T21:44:38
Remove DIRTY_BIT_READ_FRAMEBUFFER_BINDING sync during draw Remove `state::DIRTY_BIT_READ_FRAMEBUFFER_BINDING` synchronization from `prepareForDraw()`, since it does not synchronize the `DIRTY_OBJECT_READ_FRAMEBUFFER`. This is to avoid synchronizing with invalid read framebuffer state. It seems that in the current code this bug does not cause any real problems and it is not possible to write test that will fail. On Vulkan back-end, this is because `DIRTY_BIT_READ_FRAMEBUFFER_BINDING` is always reset after new swapchain is created (`SubjectMessage::SurfaceChanged`). Therefore, each time `DIRTY_OBJECT_READ_FRAMEBUFFER` is synchronized, `DIRTY_BIT_READ_FRAMEBUFFER_BINDING` will be also set. However, in the follow up CL the problem becomes possible. Without this change some gold trace tests will fail. Bug: angleproject:400711938 Change-Id: I375578a848a7cee044ca4d768266f3d3efa97e44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6396863 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>