kc3-lang/angle

2023-02-13T21:30:38

Vulkan: Rename "RendererVk::waitFor*ToBeSubmitted()" methods. Following "RendererVk" methods are a little bit confusing: - submitCommands() - hasResourceUseSubmitted() - hasQueueSerialSubmitted() - waitForResourceUseToBeSubmitted() - waitForQueueSerialToBeSubmitted() Because after "RendererVk::submitCommands(..., submitQueueSerial)" call "hasQueueSerialSubmitted(submitQueueSerial)" will always return "true". And it is not clear why need to call "waitForResourceUseToBeSubmitted()" method, if it already "Submitted". It is even more: it is technically illegal to call "waitFor*ToBeSubmitted()" if "has*Submitted" is "false". This refactoring suggests adding "ToDevice" to the methods names: - waitForResourceUseToBeSubmittedToDevice() - waitForQueueSerialToBeSubmittedToDevice() So that: - "Submitted" - will mean to the RendererVk (and maybe Device) - "SubmittedToDevice" - definitely submitted to the Device. Bug: b/267348918 Change-Id: I12323be3ddc0cbcff4667e52a37089b187b63fe8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4245423 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>