Commit cdb822e7ebe9064bd13b45fa70ce85b004a45a72
2023-07-13T09:45:00
Revert "Android: Assert that CFI is disabled" This reverts commit 43ef50f389e97131dc487081d6c8c02373e4a22c Reason for revert: LLVM bug is fixed upstream. Fix: https://reviews.llvm.org/rG92fbb602f3b635110417e40e2f774b31798b0b1d LLVM Roll: https://chromium.googlesource.com/chromium/src/tools/clang/+/243d4473a3739d43cab35eeb0b4934bf5f7a7d05 CLs in the roll: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/7586aeab..0c545a44 Original change's description: > Android: Assert that CFI is disabled > > There appears to be a bug in the interaction of CFI and > relative vtables. On armv9 it results in a crash with SIGILL > when loading traces. > > Since we can't overwrite the flags used to control this > just assert that it is correct in GN args. > > To avoid the assert, add the following to your GN args: > > arm_control_flow_integrity = "none" > > Test: Build and run traces on armv9 devices > Bug: b/278955379 > Bug: chromium:1441148 Test: angle_trace_tests on ARM v9 device with flag removed from GN Bug: b/278955379 Bug: chromium:1441148 Change-Id: Ib90405a143503896041c2522f484c234a943a6fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4684008 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>