Commit f0465cac79eee446f102340702ba54f621369659
2024-08-12T15:46:14
Revert "Remove the linkage-specification on `main`" This reverts commit b60dc9d59aad03e641b86431c277c877d4ca9d7a. Reason for revert: Fails to roll into Chromium https://chromium-review.googlesource.com/c/chromium/src/+/5782182 https://cr-buildbucket.appspot.com/build/8739800008401884241 Original change's description: > Remove the linkage-specification on `main` > > According to the standard, the main function should have no > linkage-specification [1]. New version of clang will enforce > this via a warning [2] which causes build failure if building > with `-Werror` which treats warnings as error. > > Remove the superfluous linkage-specification to fix the error. > > [1]: https://eel.is/c++draft/basic.start#main-3 > [2]: https://github.com/llvm/llvm-project/pull/101853 > > Fixed: chromium:358427300 > Change-Id: I541166cbd122c7e296ecdd2b5a9f9a107fe82872 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782349 > Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Change-Id: Id9f99c21480e7f72617b2907c35356e5033a3ce4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5782859 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>