Commit f45b9951708f2588ee2edc239b878167c30cc5ca
2025-01-16T10:05:06
Inline ValidateUniformCommonBase Same way as driver_overhead_2 based PGO does it. It makes sense as the function is small and only has a few callers. This happens to reduce .so size by ~10KB due to ValidateProgramUniform* (ES31) changes: clang no longer inlines ValidateProgramUniformBase into those and it becomes a function call - but a call in the same translation unit instead of a call into ValidateUniformCommonBase in another unit. Seems like we get the same number of calls but better locality. Perf imact difficult to estimate due to effects of section layout changes but I do see an improvement when comparing PGO builds, disabling this optimization for an affected function then re-enabling it with this CL. Bug: b/383305597 Change-Id: Ib76d33d01b165049335e61c007ee79bec53219c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6175711 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>