kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi 0042de5f 2025-09-08T12:04:33 Vulkan: Rename ImageAccess to ImageFormatSupport `ImageAccess` to be used for other purposes. Variable name `access` was also identical to variables of `CommandBufferAccess`. Bug: angleproject:422982681 Change-Id: I69b4d2bd773f1c5ff0fb15c7b611efd1f736061d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923330 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 46671aea 2025-09-08T10:18:51 Tests: Add Disney Solitaire trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*disney_solitaire Bug: b/443737949 Change-Id: I0fee2e6a24682d2803e470832e910e2aca912616 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6923296 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Rafael Cintron 2207a0a2 2025-09-04T17:32:12 Remove multisampledRenderToTextureEXT from D3D Partial implemented was never completed, nor utilized for XR scenarios. CL removes the implementation Bug: chromium:443111620 Bug: angleproject:433462527 Bug: angleproject:42261786 Bug: angleproject:42263509 Bug: angleproject:42263677 Change-Id: If95581d5f9b0e43be96ef6913fe73f547e0b5501 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6915970 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
angle-autoroll 31824ae0 2025-09-08T09:51:08 Roll Chromium from ea026e74b018 to 036558884dbf (932 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ea026e74b018..036558884dbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7bea1d158c..396bde5914 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/076678f3fb..10b037a661 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/41ee4209e8..b8aba99a05 * third_party/android_build_tools/error_prone/cipd: 47nFaUKq3UemCr0EHmMYPJ63Y9hRnNII7iNn5zYK9qsC.._xvKMGMJix5ysOYKkNTfSBd8CHQlf-DqEmAYYoEP3wgC * third_party/android_build_tools/lint/cipd: _v7pAuSk9urtP9QU6HH2OCUTGys9gUV74h8gJu1csI8C..d6CQ9eCLBIOopQEbwq-Sax2LJTcnhF8kso6FeFopbkgC * third_party/android_build_tools/manifest_merger/cipd: lKMwtNMqvRbDnUel3vBQLv-Of-xpdg_Rc54QKgdOCx0C..MFlelAeq9AjbPFiLMR9nSNIXDKTdmo99j3cyOZk_MPkC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/469f778020..6d1d8024dd * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e46459f0d3..9c3171ffea * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c6b0f02491..954086abf1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/f1a53902f8..3601008ab2 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/64187100b2..0e03294673 * third_party/siso/cipd: git_revision:8863265a67843154872be2be1fc0c37339691405..git_revision:39f570f121d63078bca79de500f4f2a50cb37456 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d548013fc1..e34b8ce2ad * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/82d621482b..887b4e835a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2cf9c5e3a5..a90208e570 * tools/win: https://chromium.googlesource.com/chromium/src/tools/win/+log/89d58ebe78..2cbfc8d2e5 No update to Clang. Bug: angleproject:431097618 Tbr: yuxinhu@google.com Change-Id: I9c86af95ac39ef40c882c137ada99707291f30eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6920545 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 75f4a89a 2025-09-08T08:01:32 Roll VK-GL-CTS from 15469c3d0039 to 12633f4f5972 (12 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/15469c3d0039..12633f4f5972 2025-09-05 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-09-04 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.6 into vk-gl-cts/main 2025-09-04 lorenzo@khronosgroup.org Sort generated code so that following changes are consistent 2025-09-04 javed@igalia.com Add tests for maint4 early resource destruction 2025-09-04 zzoon@igalia.com Add more video encoding tests using layered src image for H264/5 2025-09-04 ziga@lunarg.com Test descriptor set layout and immutable sampler compatibility 2025-09-04 piotr.byszewski@mobica.com Fix layout transition errors in remaining_array_layers tests 2025-09-04 scerveau@igalia.com video: fix some data conversion issues 2025-09-04 marcin.zajac@cognizant.com Fix validation errors in wsi tests 2025-09-04 mateusz.bahyrycz@mobica.com Remove CopyCompressedImageToBufferTestCase duplications 2025-09-01 lorenzo@khronosgroup.org Update headers to Vulkan 1.4.326 2025-09-01 rgarcia@igalia.com Mix indexed and normal draws with primitive restart If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ife7046e9ef118af8457754d3f9dea2032b83616c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6921893 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
hoonee.cho acb59de1 2024-10-26T13:13:34 Vulkan: Add VK_KHR_buffer_device_address feature Add to check VK_KHR_buffer_device_address is supported to query a 64-bit buffer device address value for a buffer, which can be used to access the buffer memory via the PhysicalStorageBuffer Bug: angleproject:442950569 Change-Id: Ic86f448c1cb5cef40757406d0ce6259838f77fdb Signed-off-by: hoonee.cho <hoonee.cho@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916339 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Matt Stark e2f7d0e1 2025-09-05T00:26:50 Fix a type error on 32-bit platforms. FileStreamSeek was incorrectly typed to always take a 64-bit integer, but fseeko takes off_t, which is 32 bits on 32 bit platforms. This results in the following error: error: implicit conversion loses integer precision: 'long long' to 'off_t' (aka 'long') [-Werror,-Wshorten-64-to-32] 580 | return fseeko(stream, offset, whence); | ~~~~~~ ^~~~~~ Bug: chromium:425527533 Change-Id: I2fe2596accd33bf41db2dbed2df9a23c3fcd3871 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6918314 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Matt Stark <msta@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi dbbae298 2025-09-05T12:39:01 Vulkan: Remove debug name from ImageMemoryBarrierData It was always there, but never became useful. Bug: angleproject:422982681 Change-Id: I409c061b07840a1cc9b85220fcbe792944358dba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6919463 Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi fee5826f 2025-09-05T11:23:23 Vulkan: Enable VK_KHR_unified_image_layouts Functionality of the extension is not used by this change. Bug: angleproject:422982681 Change-Id: I68c8b93e69eb47b1d4287edad105514edd36dfcd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6918517 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu cb6b73d2 2025-09-05T10:37:28 Temporarily disable FP16 float uniform transform feature Some webgl_conformance_vulkan_passthrough_tests are failing with the shaders generating 16-bit for lower precision uniforms. Temporarily disable the feature while investigating the root cause. Bug: chromium:443182226 Bug: chromium:443182234 Bug: angleproject:405795981 Change-Id: I62850f5dc979912a0605edb1aea5b74774b4421d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6918101 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Charlie Lao fecb02db 2025-08-28T12:08:34 Vulkan: Reduce onVertexBufferChange/onVertexAttributeChange When we loop each attribute we end up calling onVertexBufferChange or onVertexAttributeChange. For most drivers supportsVertexInputDynamicState is enabled. This means we are repeatedly check feature bit and set DIRTY_BIT_VERTEX_BUFFERS repeatedly for each dirty attributes. This CL moves these calls out of attribIndex for loop. ContextVk::onVertexArrayChange() now get called directly from VertexArrayVk::syncState() so that we only go through most logic only once if supportsVertexInputDynamicState is enabled. Bug: b/439073246 Change-Id: Ib1316560ef686222e72b4d7ad32c63b043dfbaa5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896934 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Cody Northrop 62b5ab9f 2025-09-05T10:46:20 Tests: Add Talking Tom Gold Run trace Test: angle_trace_tests --gtest_filter=*talking_tom_gold_run Bug: b/443278466 Change-Id: I3109c3d03f8315fd30f5dbd259b08b160396c5d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6918099 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll fe30cd1a 2025-09-05T07:48:55 Roll Chromium from da9738e79ab6 to ea026e74b018 (625 revisions) https://chromium.googlesource.com/chromium/src.git/+log/da9738e79ab6..ea026e74b018 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fe95e9197e..7bea1d158c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d091c4baaf..076678f3fb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/68d991c4a2..41ee4209e8 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/04fe3ac35a..7962db2867 * third_party/android_build_tools/lint/cipd: KBlDDgCi2ePqd60Cg-MkB6N_YRqkgcJ0ldkVj8OW_I4C.._v7pAuSk9urtP9QU6HH2OCUTGys9gUV74h8gJu1csI8C * third_party/android_build_tools/manifest_merger/cipd: 2_K2OBymmRtILwt6cbPOen-vkq5OsCMu8tfxOUnkOfMC..lKMwtNMqvRbDnUel3vBQLv-Of-xpdg_Rc54QKgdOCx0C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0b4498fa66..469f778020 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f916887e12..e46459f0d3 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0527c18b4b..c6b0f02491 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/91a16614cd..f1a53902f8 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f4094ebd68..d548013fc1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/802fa91acf..82d621482b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/06a8699d88..2cf9c5e3a5 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/0cba351989..7ae3c976eb No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ic2fd11077d68d4a90af610cf482eb6b673676967 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6919064 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop e893313c 2025-09-04T17:52:21 Tests: Add Snake.io trace Test: angle_trace_tests --gtest_filter=*snake_io Bug: b/442438127 Change-Id: I86f40347d0111dfc35d813f41611691a4f71cb56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6918149 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 8bae2565 2025-08-22T14:38:23 Vulkan: Improve VertexArrayVk::syncState VertexArrayVk::syncState often time shows up the biggest single API in simpleperf. For example, in tower_of_fantasy it is 7.9% of all CPU time in libANGLE. This function also uses macros which made it hard to debug. This CL removes the usage of macros which makes code much easier to handle. The other real problem is that we are repeatedly calling syncDirtyAttrib() function for disabled attributes. This CL breaks the dirty bits into bindingDirtyBits and bufferDataDiryBits and attribDirtyBits. Only attribDirtyBits will end up doing the actual state sync. All other dirty bits will just turn them into attribDirtyBits. Also disabled attributes will be looped separately. This simplification makes it impossible to have duplicate state syncs since we only call sync*Attrib at the end of function. By splitting syncDirtyAttrib into syncDirtyEnabledAttrib/syncDirtyDIsabledAttrib/syncNeedsConversionAttrib, we also moved the if check from syncDirtyAttrib (which is called within for loop) to syncState. With this CL, simpleperf shows this function has reduced from 7.9% to 5.9%. Bug: b/439073246 Change-Id: I99b5ff0b34a5992e31541d2e9cd81ff5c9dda716 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6876527 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Jordan 9d656f68 2025-09-04T07:31:39 Fix README.chromium for skeletons Setting Revision based on the provided version, and setting version to the git tag so that the vuln scanner will identify it Bug: b/442971025 Change-Id: I2bdc8d07a1c4f51586a632830d11db29560ec5ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6914179 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Solti Ho <solti@google.com> Auto-Submit: Jordan Brown <rop@google.com>
Cody Northrop 49366cae 2025-09-04T16:41:51 Tests: Add My Talking Tom trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*my_talking_tom Bug: b/443137624 Change-Id: I29c0b5ab0c895df7412155731d06ede897aafe0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6915966 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Matthew Denton cfe2c8fe 2025-06-25T13:25:01 WGSL: RewriteMultielementSwizzle WGSL doesn't support assignments to multi-element swizzles. This is used in a lot of shader tests, so temporarily work around this with an AST traverser that splits these assignments into multiple assignments that only assign to single element swizzles. One special case is multiplication-by-a-matrix assignment: vec.xy *= mat; is converted to vec.x = (vec.xy * mat).x; vec.y = (vec.xy * mat).y; Bug: angleproject:392542001 Change-Id: I3f393039aae13eb3f2c5dc5e553f68eb03b6316d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6847280 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org>
Amirali Abdolrashidi 56868bd5 2025-09-04T12:21:40 Skip uniform bool in array test for Mac * Skipped the following test on AMD Macs using Metal: SimpleUniformUsageTestES3.BoolInArray Bug: angleproject:443101808 Change-Id: Ic58b1678a99632a42e351225525f8669f70a9d8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916348 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cody Northrop 5b6084ce 2025-09-04T07:45:09 Tests: Add Matching Story trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*matching_story Bug: b/443039333 Change-Id: I4e09c05f2e21d6dcbdfb67b4631adc9b1ef69691 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916335 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 1c275402 2025-09-04T12:38:29 Roll vulkan-deps from 8415cc875465 to 5107e9eef1bc (8 revisions) * Skipped some WRITE-AFTER-READ hazards related to the following: * vkCmdDraw() -> vkCmdCopyImageToBuffer() * vkCmdDrawIndexed() -> vkCmdCopyImageToBuffer() https://chromium.googlesource.com/vulkan-deps.git/+log/8415cc875465..5107e9eef1bc Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3289b1d61b69a6c66c4b7cd2c6d3ab2a6df031e5..9d764997360b202d2ba7aaad9a401e57d8df56b3 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/345804025b4cd32ff6e1959cc6c0280927c2e9dd..055b25c02fa80cdcca77fcf94ab64a02f02d9199 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/44cf554790020ee44355dde75f0aff79141cab3c..f6940d2b8a9dc6de805c48eb3e8bafd65118b25c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/a528f95dc2f92bdd83c0c32efe2d13c806428c9d..34edde1191548c51cf4958f2dc6772bf7f76c8cd https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/54e4c34d401b5b4c5abc5dd04804f7b02a8bc0c0..dc22b23433ab3a390b4c75710836691fdb6f11f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:443095908 Tbr: abdolrashidi@google.com Change-Id: I305b9dc0089ac58be610b99cbf61112c33a03d7d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6916334 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxin Hu c1cdc2b5 2025-08-22T15:23:58 Transform SPIRV to use 16-bit float for lower precision uniforms This change adds a ShCompileOption flag transformFloatUniformTo16Bits. The flag is turned on in vulkan backends where VK_KHR_16bit_storage extension is supported, and uniformAndStorageBuffer16BitAccess feature is supported. When the compiler flag is turned on, in the generated SPIRV, float data types in mediump and lowp uniforms are transformed from 32-bit to 16-bit. The 16-bit float uniform data is converted to 32-bit with OpFConvert instruction upon loading in SPIRV, this is to minimize the changes in OutputSPIRV.cpp. The converted variable is decorated with RelaxedPrecision, so that SPIRV compiler should be able to treat the converted variable as 16 bits, and the hardware can still benefit from reduced precision floats. The frontend is also notified such SPIRV shader changes by setting the isFloat16 bit in CollectVariables() step, and the frontend will transform float uniform data from 32-bit to 16-bit before storing the data into memory. That way, the uniform data that SPIRV shader reads matches with the uniform data type transformed in the SPIRV shader. This change also updates some test code to allow relative 2^-10 precision wiggle room for mediump uniform floats. This is valid according to spec: https://developer.arm.com/documentation/102502/0101/Shader-precision Bug: angleproject:405795981 Bug: angleproject:440941211 Change-Id: I05db7f5ef744df513fbad87cfed8aa173890ec26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6851560 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
angle-autoroll d78eb52c 2025-09-04T07:03:07 Roll Chromium from 4c2df5b9a719 to da9738e79ab6 (630 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4c2df5b9a719..da9738e79ab6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e89cc079bc..fe95e9197e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4d04ea36c0..d091c4baaf * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a0f222c87e..68d991c4a2 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5141e83267..04fe3ac35a * third_party/android_build_tools/manifest_merger/cipd: K-0K2jznbc6LGEnKhT8NliSShwC43TBuVFZ6gRjOuxgC..2_K2OBymmRtILwt6cbPOen-vkq5OsCMu8tfxOUnkOfMC * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/f1c6b36cde..c347f4a5a5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fa63ec7437..f916887e12 * third_party/flatbuffers/src: https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/8db59321d9..1c514626e8 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/23b5bc9386..0527c18b4b * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/03855c3d7e..91a16614cd * third_party/r8/cipd: nvFK5h1qU6auImeboro5vB72VxCbNz29K9X4kQ94q44C..c5uRiviKwnpvuwxnd72Fas1gLwjrwA-_OsYLcIA1EWUC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/f058a25008..64187100b2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/49737a61bc..802fa91acf * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8b7266478d..06a8699d88 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/339022b502..0cba351989 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I6d47375c741ce0de1789c1824d1c9d3623f0594e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6915196 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 397b39fe 2025-09-03T14:08:59 Tests: Add ColorBlock: Combo Blast trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*color_block_combo_blast Bug: b/442878479 Change-Id: I7a8f0ea63040f84c31d7cb96028bf2749c8644be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6913669 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 6888dfb1 2025-09-03T13:40:33 Vulkan: Fix missing vkGetImageSubresourceLayout2EXT ... with angle_shared_libvulkan=false Bug: angleproject:352364583 Change-Id: I6c81aefc6b074d45103a514ddd6d55192c2f660b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6912583 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Victor Hugo Vianna Silva 0eb8d8c9 2025-09-03T15:13:02 [angle] Bump vpython from 3.8 to 3.11 Also requires upgrading some packages. Bug: chromium:40249958 Change-Id: I9ba078a41235cf8b293a49155740f58b14dd392b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6909333 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuxin Hu 8280ca37 2025-09-02T13:27:38 Add a test for uniform reorder bug on Mac This change adds a test to cover the bug fixed in https://chromium-review.googlesource.com/c/angle/angle/+/6847281. Bug: chromium:442521269 Change-Id: I78c1b9691f7bf04b6e046d04328a42cc9eae0fcd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6907558 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 69c23c86 2025-09-03T10:02:11 Roll vulkan-deps from 6c674c819618 to 8415cc875465 (33 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6c674c819618..8415cc875465 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/a906345b8a7bccc416b006b2048e13f40d9b2327..345804025b4cd32ff6e1959cc6c0280927c2e9dd https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/3397e1e4fe0a9964e1837c2934b81835093494b8..54ae32bce772b29a253b18583b86ab813ed1887c https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/a7be3a75340b32f51a28eb506280eea7b543f293..44cf554790020ee44355dde75f0aff79141cab3c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/be73614e1dafe7dc4f4867305d4d1b91fe9d1649..d1cd37e925510a167d4abef39340dbdea47d8989 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/8b7e618308605235f61d78fa47a3785190440467..3af548220a6a256fdb7e03443ce92d26b2fc3b84 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/8ce6f121d1fcbdf60f0f4264e23fbcd247b9101d..32deb15853e1a3c442fc2820066995758821546a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/4f4c0b6c61223b703f1c753a404578d7d63932ad..a528f95dc2f92bdd83c0c32efe2d13c806428c9d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/1d766aef703babe4f91e51f64a60f7baa61bbe91..54e4c34d401b5b4c5abc5dd04804f7b02a8bc0c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I487d0a926f6b7793d672680507767693bdc1ab9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6910624 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 079ef007 2025-09-03T03:01:30 Roll SwiftShader from 0390a544a952 to 14f87286123a (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/0390a544a952..14f87286123a 2025-09-02 swiftshader.regress@gmail.com Regres: Update test lists @ 0390a544 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ie1c5ae23fa3d17d16a3f0dd8d04665eb0c95bcbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6911096 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9f62c102 2025-09-03T09:14:09 Roll Chromium from 0f06b1619cb7 to 4c2df5b9a719 (718 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0f06b1619cb7..4c2df5b9a719 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d1d2393da5..e89cc079bc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/33de7fd438..4d04ea36c0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/10f4b7f436..a0f222c87e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f01b22f782..fa63ec7437 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/65a5746fb4..23b5bc9386 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/92fb77dfd4..cf32009cc6 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/46f8689c0b..03855c3d7e * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/e354a43e42..fef7a765bb * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/13fd72a058..f4094ebd68 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3895bad8d8..49737a61bc * tools/luci-go: git_revision:75f092b40e0df438e12c879c8cfff14f6de4d39c..git_revision:f58a984f19eeed333afe8ec2e167cb7197dca7f5 * tools/luci-go: git_revision:75f092b40e0df438e12c879c8cfff14f6de4d39c..git_revision:f58a984f19eeed333afe8ec2e167cb7197dca7f5 * tools/luci-go: git_revision:75f092b40e0df438e12c879c8cfff14f6de4d39c..git_revision:f58a984f19eeed333afe8ec2e167cb7197dca7f5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/483c32167e..8b7266478d * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/f71995f8f9..339022b502 * tools/skia_goldctl/linux: 5k_mdgNr88ruhw8wR37n57qA6iEdot7tPc-lc_hippYC..0reqJkEekQRnJ-rFL80hFTkXvC0uuptBZeiraNZj2NUC * tools/skia_goldctl/mac_amd64: OPaFxDMuZtsVtE_YE0CI33iBL9EwIHEbrWClWR7GFfUC..DBaYppt36tqyLb4_UgQ681mSTT8PKBAB6xmsdcGpytUC * tools/skia_goldctl/mac_arm64: QwyopvKkY3CS1MZnwWWGLPcVUBIuOyF4315gzWxJXY4C..Eqcsof-0qbc-C7HqbVjjTmBIx7JiwRPOIj0lQCA-fn0C * tools/skia_goldctl/win: z8NkbEwyFuhb1CUZyDwlOhnv9peom12VGWmOaUj8N_gC..GcCLRtRDIafGi3F6e48loAb3FeWZVPE6iAb04xL5QpAC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I72918834ca7c04a8630857213934b9e58ebd7422 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6910623 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 875b7400 2025-09-02T13:42:57 Tests: Add Merge Mansion trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*merge_mansion Bug: b/442622825 Change-Id: I19bec8238c3e4fd4d7f8dc9a83256a2551247998 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6907469 Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Tom Sepez f8ce4a01 2025-08-26T18:18:54 Add src/common/unsafe_buffers.h Allow for line-by-line control of unsafe buffers warnings. Bug: b/436880895 Change-Id: I609d60c83611037f39d541d5b8c9aba98a6656a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6886308 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org>
Liza Burakova 778969f2 2025-08-28T15:54:35 [WebGPU] Fix ImageHelper::flushSingleLevelUpdates This change modifies ImageHelper:flushSingleLevelUpdates to only send a flush command to the context once, instead of in each iteration of the loop if there are multiple texture uploads. This also means that the last texture upload is guaranteed to be flushed, as otherwise that texture could be staged in the queue, but a different command could redefine texture levels which would delete the underlying texture handle but not the command queued for that texture. Bug: angleproject:438268609 Change-Id: I2d49b15fc921829175e99bdb550dddbd81179061 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6885223 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
angle-autoroll d66d3bf2 2025-09-02T18:30:27 Manual roll vulkan-deps from 3c8902583f3c to 6c674c819618 (5 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/3c8902583f3c..6c674c819618 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/0c1acc220abd1a5791601d907b6bb49b640a62d2..a7be3a75340b32f51a28eb506280eea7b543f293 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/037423da2b2a84f330cb037699ef604ba0d0c94f..8ce6f121d1fcbdf60f0f4264e23fbcd247b9101d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/bfe590945ebdc9c40639b6b73698bd10990f4568..1d766aef703babe4f91e51f64a60f7baa61bbe91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I37268e05d0edf5473e94217e5080aad0145da2e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6907554 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 84e4054f 2025-09-02T10:43:24 Tests: Add Super Bear Adventure trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*super_bear_adventure Bug: b/442585566 Change-Id: Id04ababe0f5e28363fc615ed36db5da78c67c619 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6907164 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Geoff Lang b449a24a 2025-08-28T14:23:00 GL: Disable BaseVertex and BaseInstance extensions on Linux This is a speculative fix for some rendering issues seen on Linux. Client data also appears to be broken when using BaseVertex functions, this will disable the functions until those issues are fixed. Re-add the check for GL_ARB_base_instance, this was likely not the culprit. Bug: chromium:427956856, angleproject:431097618 Change-Id: If48121d3c4819a46091de4360a2159b9bf14313e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6897307 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yang Gu a3505ae6 2025-08-28T13:47:05 Prefer non-WARP device for angle_end2end_tests When we have both WARP and a real GPU, but WARP comes first, angle_end2end_tests always shows the active GPU is 0, and always uses WARP for tests. This CL prefer the non-WARP device instead. Bug: angleproject:441816895 Change-Id: I787b25f9ff6ad0a98e5fbc445b580b897bd52033 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896220 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Tom Sepez 2d28e33f 2025-08-28T23:50:51 Avoid some large copies in range-based for-loops Avoid copies as detected some time ago by a clang compiler plugin, typically this indicates a missing & in the range-based for-loop. -- For the vector initialize code, see https://godbolt.org/z/4PWseve5P as to why I think a copy-assign is more efficient than a copy- construct followed by a move-assign. Bug: b/415953694 Change-Id: I2cf9f713277d811127834235507ee075c4a72956 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6898417 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org>
Cody Northrop 9e3a8f83 2025-09-01T19:17:57 Tests: Add Travel Town trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*travel_town Bug: b/442449877 Change-Id: Ia3c79ae74655fd9d917452998cba9de205ba6b83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6905176 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
angle-autoroll d82a5821 2025-09-02T07:27:19 Roll Chromium from ddfbb7d832f0 to 0f06b1619cb7 (322 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ddfbb7d832f0..0f06b1619cb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/71f8022b66..d1d2393da5 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2ca9a5b96f..33de7fd438 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1c01106921..10f4b7f436 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a54a6c133b..f01b22f782 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/70c21e34ea..65a5746fb4 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/11725050a2..46f8689c0b * tools/luci-go: git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0..git_revision:75f092b40e0df438e12c879c8cfff14f6de4d39c * tools/luci-go: git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0..git_revision:75f092b40e0df438e12c879c8cfff14f6de4d39c * tools/luci-go: git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0..git_revision:75f092b40e0df438e12c879c8cfff14f6de4d39c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/67dbacceca..483c32167e * tools/skia_goldctl/linux: 9ByI3GXvRWtecAXo0R39pN9Jak7EvEeKnHr7AvwPTusC..5k_mdgNr88ruhw8wR37n57qA6iEdot7tPc-lc_hippYC * tools/skia_goldctl/mac_amd64: oSdrLMI0x9PkfobCI5WwpFuT5jYD2pnE3CsLIwkpT7AC..OPaFxDMuZtsVtE_YE0CI33iBL9EwIHEbrWClWR7GFfUC * tools/skia_goldctl/mac_arm64: YY51Byb3DdEAuCLgXvJ3TUzQRIAFSYMFGbHt18sHXlEC..QwyopvKkY3CS1MZnwWWGLPcVUBIuOyF4315gzWxJXY4C * tools/skia_goldctl/win: 3KmIxwEvH3rb0U2exjD0rxJpqdpKe1ceUGvnoKcS_w4C..z8NkbEwyFuhb1CUZyDwlOhnv9peom12VGWmOaUj8N_gC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia462de2495877758cfe7966f0c30b13dc09d27bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6906832 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop bb55ea10 2025-08-31T17:59:49 Tests: Add Minecraft Vibrant Visuals trace Test: angle_trace_tests --gtest_filter=*minecraft_vibrant_visuals Bug: b/442154222 Change-Id: Iba7619720ad8dd26b0dfeaf4f8b150549189a7e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6904388 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
angle-autoroll 2d419eb1 2025-09-01T09:28:19 Roll Chromium from 659c6d688f03 to ddfbb7d832f0 (842 revisions) https://chromium.googlesource.com/chromium/src.git/+log/659c6d688f03..ddfbb7d832f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/800bdadb6c..71f8022b66 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b0b6f725c2..2ca9a5b96f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fc00cc4343..1c01106921 * third_party/android_build_tools/aapt2/cipd: 2Tff49a5dYTM5YvxxqyOsTQ9k8nOqM4ayydbCuKoxIwC..vtRNH1sTb9tAlXaPkdqGIH_MDSnuH2GrlWFtT1MhadUC * third_party/android_build_tools/error_prone/cipd: R8e42R2txro2We-fzwv-mCywXVgBpacnAx2ln84t9ZkC..47nFaUKq3UemCr0EHmMYPJ63Y9hRnNII7iNn5zYK9qsC * third_party/android_build_tools/lint/cipd: -JcaCbcpT3Q0in-E0Q-DQ8raNBQTA0mTz6N_smsM-YwC..KBlDDgCi2ePqd60Cg-MkB6N_YRqkgcJ0ldkVj8OW_I4C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e7fd5cc71d..0b4498fa66 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6b19831e3c..a54a6c133b * third_party/fuchsia-sdk/sdk: version:29.20250824.3.1..version:29.20250901.2.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/3fbbed1e6e..70c21e34ea * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c948b3c916..92fb77dfd4 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/be4d290e46..11725050a2 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/6bcedec5a3..e354a43e42 * third_party/siso/cipd: git_revision:15568691576f74b11a3c73c85a3c8dd5efb72f05..git_revision:8863265a67843154872be2be1fc0c37339691405 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/77d4c8dd8a..13fd72a058 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2fa0b7d4c3..3895bad8d8 * tools/luci-go: git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6..git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0 * tools/luci-go: git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6..git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0 * tools/luci-go: git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6..git_revision:5482078f7d5948dab82fc4d4ab8e19a31536e6b0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a8cc349622..67dbacceca * tools/skia_goldctl/linux: Crs4pLO-tMSzA5ldZyYRfd6l8DlBceR6NUDI0K8aI4kC..9ByI3GXvRWtecAXo0R39pN9Jak7EvEeKnHr7AvwPTusC * tools/skia_goldctl/mac_amd64: HN1hkS7vu_wjGf_OP2V6--4DC6awi7V-ozpJRMt7OyEC..oSdrLMI0x9PkfobCI5WwpFuT5jYD2pnE3CsLIwkpT7AC * tools/skia_goldctl/mac_arm64: F2BnxcR4yVPrD2Aaw9X9JNQkeTvxrhCW5CZ8sSXxLR8C..YY51Byb3DdEAuCLgXvJ3TUzQRIAFSYMFGbHt18sHXlEC * tools/skia_goldctl/win: z5U3w9onZdvjd2_mryXXs_1V_APeMYuzeSAB4nGW26cC..3KmIxwEvH3rb0U2exjD0rxJpqdpKe1ceUGvnoKcS_w4C No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I236d038a9b94011d23ebd730461b229506f31602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6905488 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b59b287e 2025-09-01T08:01:13 Roll VK-GL-CTS from 3718ed21d713 to 15469c3d0039 (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/3718ed21d713..15469c3d0039 2025-08-29 piotr.byszewski@mobica.com Descriptor buffer tests to verify set invalidation rules 2025-08-29 mateusz.bahyrycz@mobica.com Add buffer to image copy tests for color formats 2025-08-29 lorenzo@khronosgroup.org Split vk-main-2023-03-01 into 3 parts to avoid large files 2025-08-29 javed@igalia.com Add coverage for non-resident sparse buffer 2025-08-29 nunes.erico@gmail.com Fix egl_fence_persistent_buffer deinit on GLES 2.0 2025-08-29 rgarcia@igalia.com Add tests to verify terminateInvocation works as expected 2025-08-29 scerveau@igalia.com video: use larger content for h265 encode 2025-08-29 zzoon@igalia.com Add CTS options to dump output of Vulkan video tests for both decoding and encoding. 2025-08-29 javed@igalia.com Refactor render pass test groups 2025-08-29 marcin.zajac@cognizant.com Separated E5B9G9R9 blend color write mask coverage 2025-08-29 zzoon@igalia.com Fix to detect video codecs for AV1 and VP9 2025-08-29 scerveau@igalia.com VideoEncodeTestsAV1: Fix options according to test names 2025-08-29 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.3 into vk-gl-cts/main 2025-08-28 lorenzo@khronosgroup.org Merge vk-gl-cts/github-main into vk-gl-cts/main 2025-08-26 scerveau@igalia.com video: do not create yuv folder if it exists If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I3bcba7f041598f4f1dd3d0f6fbad0792024dc1a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6904519 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 1e3e4eb7 2025-08-30T17:25:20 FrameCapture: Don't issue Begin/End for Timestamp queries Timestamp queries are issued with glQueryCounterEXT rather than glBeginQuery/glEndQuery. This CL updates how we generate timestamp queries in MEC. Before this, we were getting the following errors: API, Error, High: Error:glBeginQuery::<target> is not an accepted value API, Error, High: Error:glEndQuery::<target> is not an accepted value Test: Minecraft Vibrant Visuals trace Bug: b/442154222 Change-Id: Ib6dc01c3b57afcbebfdefa38e6abc883564ea6bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6903038 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Tom Sepez 3d08d885 2025-08-27T23:27:51 Log sanitized message in InfoLog::appendSanitized(). Currently, after producing a sanitized version, the unsanitized string is logged. -- convert away from char* arguments while at it. Bug: b/441583909 Change-Id: I9ee91d303df6c5b874fd1971347b9db3ba03f51c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6893268 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Amirali Abdolrashidi ded3e754 2025-08-18T14:42:59 Add more tests for RGB565 * Added more tests regarding RGB565 rendering, texture copy, blit, and border color clamp. Bug: b/409867243 Change-Id: Ic9d30aee89bda3e8f6c9147fffd99d8d2d8fac64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6872406 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Tom Sepez eefcdafd 2025-08-29T00:13:27 Fix some old clang-tidy warnings about move constructors -- Remove move of copy-only ImmutableString -- Fix rule-of-five issues with StringPart. Bug: b/364788123 Change-Id: Ief9c2a83df15d2e8856e8f729c1908df65004bfc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896659 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org>
Tom Sepez 6f0337a0 2025-08-28T23:13:22 Avoid some needless c_str() calls. Remove conversions from string -> char* -> string, as detected some time ago by a clang compiler plugin. Typically, this occurs when passing a c_str() result to a function that expects a string argument. Bug: b/412730353 Change-Id: I1d9c83e9ed5c4900eec266e71f534661f0f3d4d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896657 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuxin Hu 28682948 2025-08-14T15:20:16 Update setFloat and getFloat APIs to handle 16-32 bit transformations This change checks that if linkedUniform.isFloat16() is true, then transform 32-bit float to 16-bit half float before writing the data to memory, and transform 16-bit half float to 32-bit float after reading the data from memory. Given that we did not change buffer layout, and the spirv requirement with matrix component alignment, we have to copy transformed data row by row / col by col, or element by element. This change is no op, as none of the linkedUniform.isFloat() bit is set to true. The change will take effect in the future change when we add the compiler code that set linkedUniform.isFloat() to true. Bug: angleproject:405795981 Change-Id: I72b74eb340dae723501038875c3706ad2c1cc3f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6851558 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 24d3f6a4 2025-08-29T09:43:58 Tests: Add Vita Mahjong trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*vita_mahjong Bug: b/441948358 Change-Id: Idde12aebb12bf3a1230de1e2f132f0a6ed586595 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6897504 Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Igor Nazarov e64b1e54 2025-08-29T15:51:30 FrameCapture: Restore end of trace capture log The log was accidentally removed by: Add long ANGLE traces feature https://crrev.com/c/angle/angle/+/6476924 That was originally added in: FrameCapture: log end of trace capture https://crrev.com/c/angle/angle/+/5557966 Bug: angleproject:343190307 Bug: angleproject:425728227 Change-Id: I68125981a3841c3d5e25aeaab3d792b8b047182a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6898285 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 6ca17fba 2025-08-28T17:12:51 Tests: Add Indian Bikes Driving 3D trace Test: angle_trace_tests --gtest_filter=*indian_bikes_driving_3d Bug: b/441808359 Change-Id: I0a4f526fee4b3b3d0e46f30735a8fe48fe4f4d03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6898414 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Tom Sepez 3d8dff0a 2025-08-26T20:23:21 Suppress unsafe buffers on a file-by-file basis in util/ Bug: b/436880895 Change-Id: I299247e38853bb16afd466e3f6521342c0a2b0f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891980 Auto-Submit: Tom Sepez <tsepez@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll ee512a88 2025-08-29T10:01:45 Roll vulkan-deps from d004638a44e4 to 3c8902583f3c (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d004638a44e4..3c8902583f3c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/c32bbc601dff6a0cacf6f2b65608742af1d57d26..bfe590945ebdc9c40639b6b73698bd10990f4568 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I41bbcc08313498b714a07bea0504b049eb753d09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6898745 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9ed1572e 2025-08-29T08:14:37 Roll Chromium from a8c806abc633 to 659c6d688f03 (1279 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a8c806abc633..659c6d688f03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6920476cbc..800bdadb6c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4cb1372f8a..b0b6f725c2 * buildtools/linux64: git_revision:037970ef8d8e5b1d9d3d6defc9aa3886dbfea29a..git_revision:5d0a4153b0bcc86c5a23310d5b648a587be3c56d * buildtools/mac: git_revision:037970ef8d8e5b1d9d3d6defc9aa3886dbfea29a..git_revision:5d0a4153b0bcc86c5a23310d5b648a587be3c56d * buildtools/win: git_revision:037970ef8d8e5b1d9d3d6defc9aa3886dbfea29a..git_revision:5d0a4153b0bcc86c5a23310d5b648a587be3c56d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5d0a173278..fc00cc4343 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/4862f4f12d..5141e83267 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0bbf370291..e7fd5cc71d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c3749b59b3..6b19831e3c * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/4b641086e0..94af60a05b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a5fc4c8ab6..3fbbed1e6e * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/a8a291787d..be4d290e46 * third_party/r8/cipd: iGVAmwvi7lXeH5SCnaZ0PpcrSL_X8-fC6JbEKfYst-wC..nvFK5h1qU6auImeboro5vB72VxCbNz29K9X4kQ94q44C * third_party/r8/d8/cipd: pBaBgtFdvclLMBwz1H7s88bhc3ioF8iEyFh6rZ81054C..iGVAmwvi7lXeH5SCnaZ0PpcrSL_X8-fC6JbEKfYst-wC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/9f2bf232b7..77d4c8dd8a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d9f910bd0f..2fa0b7d4c3 * tools/luci-go: git_revision:d404c33558d672701abed8ca167cfe06f36fa59e..git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6 * tools/luci-go: git_revision:d404c33558d672701abed8ca167cfe06f36fa59e..git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6 * tools/luci-go: git_revision:d404c33558d672701abed8ca167cfe06f36fa59e..git_revision:129260cb7597c1601e1fea08f0d2d672ae2330a6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1e73800b34..a8cc349622 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/4b83b80356..f71995f8f9 * tools/skia_goldctl/linux: _0gFCSj5cqOmXXe-Atkb0kcFChMiI0RIeaA-mAYHxUIC..Crs4pLO-tMSzA5ldZyYRfd6l8DlBceR6NUDI0K8aI4kC * tools/skia_goldctl/mac_amd64: b-j1EfuXxMKGgGvSsu998B3Py6Im2cjyVMMFGXVabJYC..HN1hkS7vu_wjGf_OP2V6--4DC6awi7V-ozpJRMt7OyEC * tools/skia_goldctl/mac_arm64: 5lVrW5FJxzBE4lA0U1My-WYSBvHmTH2hooKWml9VnKYC..F2BnxcR4yVPrD2Aaw9X9JNQkeTvxrhCW5CZ8sSXxLR8C * tools/skia_goldctl/win: LdKqwqTVZ9jhO6opMlduYqa3AuEfV6Pt-cs1Bjgi3fwC..z5U3w9onZdvjd2_mryXXs_1V_APeMYuzeSAB4nGW26cC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ifd42e9c3053eedafc2be4bfdd719865e847e33d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6898422 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop a1fa1ddc 2025-08-28T13:16:57 Tests: Add Total Battle trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*total_battle Bug: b/441768019 Change-Id: I432a14aff611e84527521bb065fe447557ce72e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896936 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Gowtham Tammana 4983b4c9 2025-05-14T13:54:47 CL/VK: Track both read/write usages of mem objects Track both the read and write usages when determining the need for barrier insertion. Bug: angleproject:441240590 Change-Id: I2a70905dbadd9bdba6fe6b83dd980963b6380a79 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6885851 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Gowtham Tammana ce158355 2025-05-06T17:11:33 CL/VK: Add isReadOnly() query for CLKernelArgument A new helper function `isReadOnly()` is added to CLKernelArgument. This makes the determination of memory dependencies more flexible. As a result, updated the `addMemoryDependencies` function to take in the write usage boolean. Bug: angleproject:441240590 Change-Id: I8826f88b7ff84ee7c689a68df4c5121ee9f12619 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6885850 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Gowtham Tammana 2a44be85 2025-05-28T15:17:33 CL/VK: Update the HostTransferConfig to supported configs Setup HostTransferConfig constructors to enable only supported configurations. Bug: angleproject:441471275 Tests-Passing: - ocl_cts.test_mem_host_flags - ocl_cts.test_basic readwritebufferrect - ocl_cts.test_buffers - ocl_cts.test_allocations Change-Id: I19afab8f66d2b025b532b42de161557b9dfbf563 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6892626 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Gowtham Tammana 0efe1a44 2025-05-16T16:23:10 CL/VK: Use UHP buffers for host transfer config We setup staging copy command for host side enqueue commands - eg. enqueueWriteBuffer. Setting CL_MEM_USE_HOST_POINTER (UHP) buffers as defaults for these staging ops so that zero-copy can be leveraged if supported. Bug: angleproject:441471275 Tests-Passing: - ocl_cts.test_buffers - ocl_cts.test_allocations - ocl_cts.test_mem_host_flags - ocl_cts.test_basic bufferreadwriterect Change-Id: Ifc584652b513f0ed0633a8d0383b244f53d57363 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6892625 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tom Sepez cf28f60d 2025-08-26T19:25:22 Avoid c-style string arguments to writeFile(). Demonstrate how std::string_views can be used to make code simpler and safer, since all the callers already have std::strings. Bug: b/436880895 Change-Id: I0f9d4d95925e684c83eb10c2a1fbab22df55c2d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6886033 Auto-Submit: Tom Sepez <tsepez@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shyam Manohar e842b5f8 2025-05-06T14:38:27 CL/Vulkan: Zero-copy support added for CL Buffers - Used VK_EXT_external_memory_host and VK_KHR_external_memory extensions - Added interfaces to CLBufferVk class for validating zero-copy ability - Added logic in CLBufferVk::create to use zero-copy if eligible - Added new HostExternalMemory class to provide utility functions - Added VkPhysicalDeviceExternalMemoryHostPropertiesEXT for querying Tests-Passing (having usage of CL_MEM_USE_HOST_PTR): - ocl_cts.test_api - ocl_cts.test_basic - ocl_cts.test_buffers - ocl_cts.test_mem_host_flags Bug: angleproject:441471275 Change-Id: I296e709a4f67911dcd6d0ae89750e8e0262625f4 Signed-off-by: Shyam Manohar <s.manohar@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6892624 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Tom Sepez a4e0bacc 2025-08-28T16:41:09 Avoid dangling pointer in Context11::popGroupMarker(). Fortunately, the pointee is unused, but move the string from the marker stack before destroying it during a pop() of the stack, so that its c_str() may live through a call to endEvent(). -- Do the same for Context9::popGroupMarker(). Bug: b/441729484 Change-Id: Id05aa92529ecc8938282273e68d95ac51966d229 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896927 Auto-Submit: Tom Sepez <tsepez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 1ae273ee 2025-08-27T10:47:59 Translator: Output struct members in OutputTree Bug: chromium:438038775 Change-Id: I2a1bed5207b1b2c26f20ee9ebd80fb00ec803bc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891072 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi af0386cb 2025-08-27T10:44:53 Reorder structs entirely made of samplers to the end of struct An earlier change [1] moved samplers to the end of structs so that extracting them does not disturb the indices to the non-sampler fields. This change does the same for structs that only contain samplers, because they too get removed from the parent struct, disturbing indices. [1]:https://chromium-review.googlesource.com/c/angle/angle/+/5748789 Bug: chromium:438038775 Change-Id: I7ac2ea13723bf06b4b172b6e70f0dbe85bc45ce3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891071 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop 08ee8585 2025-08-28T09:27:51 Tests: Add Soccer Superstar trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*soccer_superstar Bug: b/441721624 Change-Id: I8b954ace7ea96eff0dd7cc2edff19a87d6a8b437 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6897006 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Shahbaz Youssefi 1ed999ea 2025-08-25T16:02:01 Vulkan: Move sampler cache to share group The sampler cache (and the adjacent yuv-conversion-info cache) were in vk::Renderer, but they were not thread safe. Bug: angleproject:440364873 Change-Id: I2dc034f2db400f680ca91a9fde509d90f90c957e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6870736 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 9dc36791 2025-08-28T07:24:21 WGSL: Fix unused variable in translator Test: Build with is_debug = false Bug: angleproject:441701631 Change-Id: Ifa44bb5388788602e76c2ae2005bdd41d2c22dd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6896036 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 63ba3783 2025-08-28T10:56:03 Roll vulkan-deps from 4055d497de6c to d004638a44e4 (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4055d497de6c..d004638a44e4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7a5308f4bb40860cccee31d3037feb81bb35a66a..3289b1d61b69a6c66c4b7cd2c6d3ab2a6df031e5 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/1d8f536946281ca95a9a03255aaaa73696d96f90..0c1acc220abd1a5791601d907b6bb49b640a62d2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/35a62d3181eb9c238299a62618b49e521f3fe7b2..8b7e618308605235f61d78fa47a3785190440467 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3f13668946a3075216275b35b4b9aad2e9b69406..c32bbc601dff6a0cacf6f2b65608742af1d57d26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I8b2ebe0999cae1db5e40417a2a992ea6fd012eb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6893279 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 9a5eea61 2025-08-27T12:01:26 Tests: Add Football League 2025 trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*football_league_2025 Bug: b/441524270 Change-Id: I2fcb0d8fa61a5c9a8f7dcb142d79b25eda3d9d44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891990 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Cody Northrop 87347355 2025-08-27T10:14:46 Tests: Add School Party Craft trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*school_party_craft Bug: b/441504808 Change-Id: I777bccb132acc4fb1d5891ce0793e262a89af59d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891912 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jonghyuk Eun cdf428a2 2025-04-01T10:24:08 CL/VK: Update Samsung preferred/native vec widths Update CL_DEVICE_PREFERRED_VECTOR_WIDTH_* and CL_DEVICE_NATIVE_VECTOR_WIDTH_* for Samsung. The values may vary depending on the vendor. Updating only the values for SAMSUNG here. Bug: angleproject:406022413 Change-Id: Iad575298a11cfb41e620ab9cfd5f970eb6ea0b55 Signed-off-by: jh.eun <jh.eun@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6386421 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop bb27274f 2025-08-27T09:04:05 Tests: Add Offline Games trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*offline_games Bug: b/441489135 Change-Id: I0bfbfab40c525bc87c8b077748e09171e501567a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6891371 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Amirali Abdolrashidi e9214c63 2025-08-26T13:53:52 Update trace event header to allow unsafe buffers * Updated the following file to allow unsafe buffers: trace_event.h * This is to prevent errors when the following GN flag is enabled: angle_enable_platform_trace_events Bug: b/436880895 Change-Id: Iefb5ab6ab07259580b569760816fe9ad1a833161 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6885893 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 117cddc8 2025-08-27T07:48:01 Tests: Add Tile Club trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*tile_club Bug: b/440580308 Change-Id: Idb8f18402de702a434e16c9c9835fdb20c73db69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6890511 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Austin Annestrand 86a76e49 2025-08-24T12:33:16 third_party/clspv: Update clspv Rolls clspv and llvm: clspv: 0e20b2895e4b58e62311f5c311bfec4599f517e0 llvm: 7baa7edc00c5c92e2d17bae760db2e6df97dcec6 Bug: angleproject:440837006 Change-Id: I908e406e6daf7dd428a4057e2d204e3d23342f56 Signed-off-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6877795 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop be2fc5c3 2025-08-27T07:43:13 Tests: Add Royal Kingdom trace This trace was contributed by Samsung. Test: angle_trace_tests --gtest_filter=*royal_kingdom Bug: b/440579756 Change-Id: Ie30f37e58f2b422aa9bd8d5fd9acf3d8409fd7e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6890419 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Tom Sepez a02670d6 2025-08-26T20:41:16 Move unsafe buffers inside header guard macros While this is exactly opposite of what Chromium has chosen to do, there is an issue with clang-format trying to indent preprocessor directives four spaces relative to include guard. This is because Angle's .clang-format file specifies IndentPPDirectives: AfterHash but Chromium's does not. The current placement is sufficient to throw off clang-format's guard detection since the guard macro no longer covers the entire file. Bug: b/436880895 Change-Id: Ic6b99c8cef6213939cdf9b42af8730e1eb423065 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6885892 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Takuto Ikuta 6c8df3b1 2025-08-27T17:12:16 infra/config: Remove luci.recipes.use_python3 experiment Python3 is used by default in recipes now and this config is not necessary anymore. Bug: chromium:440235171 Change-Id: I3a4f120f7c824fad7bbe3e45de31b52005bfd0fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6888195 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
angle-autoroll 96643b13 2025-08-27T11:09:07 Roll vulkan-deps from edbec6047c6c to 4055d497de6c (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/edbec6047c6c..4055d497de6c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/09d803cf217f1128b3111d58bf9853ae9be52bf1..7a5308f4bb40860cccee31d3037feb81bb35a66a https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/a8637796c28386c3cf3b4e8107020fbb52c46f3f..3397e1e4fe0a9964e1837c2934b81835093494b8 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/eb500be643aa8f8eb23dc0e11fe4069ec09a5c88..1d8f536946281ca95a9a03255aaaa73696d96f90 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/2efaa559ff41655ece68b2e904e2bb7e7d55d265..be73614e1dafe7dc4f4867305d4d1b91fe9d1649 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/ade310ac6b62af86e6c7bdbe08a2fab189ed76b6..35a62d3181eb9c238299a62618b49e521f3fe7b2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/f70655e25a677bb88ad6b50d14414091abf0d33d..3f13668946a3075216275b35b4b9aad2e9b69406 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I7fa07a7e0825ea50278a12f218bf0bded686ab9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6889161 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3959b4db 2025-08-27T07:37:58 Roll Chromium from 458ba2f24871 to a8c806abc633 (606 revisions) https://chromium.googlesource.com/chromium/src.git/+log/458ba2f24871..a8c806abc633 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0d2ae4e988..6920476cbc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b9a6526750..4cb1372f8a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6e7d7ced39..5d0a173278 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bf3673451d..c3749b59b3 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0a23f5d9b8..a5fc4c8ab6 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/25f97cc0f1..a8a291787d * third_party/r8/cipd: Xyh7Kdh-M2Dj5lwFGH2QRe7TFErRgYCvMFMkPiYnIwsC..iGVAmwvi7lXeH5SCnaZ0PpcrSL_X8-fC6JbEKfYst-wC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/eb1877244c..f058a25008 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/622f070e80..9f2bf232b7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/567370dc60..1e73800b34 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/563051616f..4b83b80356 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I86437e94acd101e180f5cb7e50b9db08cae66548 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6888853 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tom Sepez 60607c8e 2025-08-25T19:48:41 Activate unsafe buffer enforcement for Angle src/ Single-file patch for easy revert in case we have missed any files needing unsafe buffer suppressions. Bug: b/436880895 Change-Id: I67572c9441e084448ff40443c069db31455484a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6880744 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Matthew Denton b9cec916 2025-08-12T19:44:18 WGSL: default uniforms gathered in interface block The default uniform struct was being manually output by OutputUniformBlocksAndSamplers(), which did not add the appropriate @align(16) annotations to lay the struct out according to WGSL's uniform address space layout requirements. This CL uses Vulkan's method of gathering the default uniforms into an interface block. The interface block will be output normally by the traverser, including @align() annotations. The variable declaring an instance of the interface block is still output by OutputUniformBlocksAndSamplers() because it needs special @group() and @binding() annotations. Bug: angleproject:376553328 Change-Id: Ib3be7d51ffedefe5ec579a1c9aaf0a535146c694 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6795028 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 17e99163 2025-08-25T21:19:08 Tests: Add Ace Racer trace Test: angle_trace_tests --gtest_filter="*ace_racer*" Bug: b/441170882 Change-Id: I8a244b2db1c9e62bd401e40ac911e868088c7dba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6882667 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tom Sepez 25390156 2025-08-21T00:13:19 Suppress unsafe buffers on a file-by-file basis in src/ [1 of N] In this CL, we suppress many files but stop short of actually enabling the warning by not removing the line from the unsafe_buffers_paths.txt file. That will happen in a follow-on CL, along with resolving any stragglers missed here. This is mostly a manual change so as to familiarize myself with the kinds of issues faced by the Angle codebase when applying buffer safety warnings. -- Re-generate affected hashes. -- Clang-format applied to all changed files. -- Add a few missing .reserve() calls to vectors as noticed. -- Fix some mismatches between file names and header comments. -- Be more consistent with header comment format (blank lines and trailing //-only lines when a filename comment adjoins license boilerplate). Bug: b/436880895 Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sungyong Choi 616a341b 2025-08-26T13:56:40 Vulkan: Set EGL_NATIVE_VISUAL_ID for EGL_KHR_platform_gbm Spec requires EGLConfig on GBM platform to report a GBM color format in EGL_NATIVE_VISUAL_ID. Previously this field was left unset. This change ensures compliance by assigning the appropriate GBM color format. Bug: angleproject:7829 Change-Id: I6c5a23374824c444e0de0b6592ea31eb855722e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6882716 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuxiang Qian 611f9ac0 2025-08-20T16:10:13 Lower the cap of max element index Currently, ANGLE follows vulkan spec and returns UINT_MAX -1 for GL_MAX_ELEMENT_INDEX. However, ANGLE stores vertex index in int, so even if we use index a little less than the limit, ANGLE would still catch the overflow error. Modify the cap to 2^30 - 1 to make it safer. An end2end test is also added. Bug: angleproject:440227026 Change-Id: Ie089c9847f3908f0e8a1b7c4b83c8fea1cde262e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6870270 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll c6cab933 2025-08-26T10:01:21 Roll vulkan-deps from 36fbc53c546c to edbec6047c6c (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/36fbc53c546c..edbec6047c6c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7899f3c1bebd55594e405e0736abf43f700c2c8b..09d803cf217f1128b3111d58bf9853ae9be52bf1 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/8a8bb6c89174ed753eb18a438092ee59356efc3c..eb500be643aa8f8eb23dc0e11fe4069ec09a5c88 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/484f3cd7dfb13f63a8b8930cb0397e9b849ab076..ade310ac6b62af86e6c7bdbe08a2fab189ed76b6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/0eb12b4ea70b15be6a10f6212c1633e5c9ce0cca..037423da2b2a84f330cb037699ef604ba0d0c94f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/f45d804fb84c4744667a298e85741161aa98c5d6..f70655e25a677bb88ad6b50d14414091abf0d33d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Iec8e41443e60cd05ba7ff7f954ed8d49a746405d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6883327 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fb1836c7 2025-08-26T07:22:03 Roll Chromium from 5910372d7545 to 458ba2f24871 (533 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5910372d7545..458ba2f24871 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/77e3784d77..0d2ae4e988 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e10f12d548..b9a6526750 * buildtools/linux64: git_revision:ee5b7e32b961a9da1933e9f46a018ba6cac8ef60..git_revision:037970ef8d8e5b1d9d3d6defc9aa3886dbfea29a * buildtools/mac: git_revision:ee5b7e32b961a9da1933e9f46a018ba6cac8ef60..git_revision:037970ef8d8e5b1d9d3d6defc9aa3886dbfea29a * buildtools/win: git_revision:ee5b7e32b961a9da1933e9f46a018ba6cac8ef60..git_revision:037970ef8d8e5b1d9d3d6defc9aa3886dbfea29a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/affbdb9289..6e7d7ced39 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8f103008c5..0bbf370291 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/cc1b6334b8..3c5077921d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5b7fcc4bb7..bf3673451d * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/aad3b3bddf..0a23f5d9b8 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/0b06c2f825..6bcedec5a3 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/46631abac7..eb1877244c * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/044b44e6de..caf4afa1af * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/18a43d530a..622f070e80 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/438a542cbc..567370dc60 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/44e180c753..563051616f No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I451e2c6adafa754c76ef8b0d5c2952bfa9054d54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6883326 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 19483cc6 2025-08-25T19:27:26 Tests: Add Bingo Blitz ANGLE trace Test: angle_trace_tests --gtest_filter=*bingo_blitz Bug: b/441137178 Change-Id: Ia463fbc93090d2c55a3f35f7cd34ca6267273c7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6882619 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 677d8281 2025-08-25T15:59:46 Vulkan: Pass ContextVk to view-creation functions In preparation for moving the ycbcr conversion cache to the share group. This change is a no-op. Bug: angleproject:440364873 Change-Id: I0c18062259b07813dd04ec02650bb6fab48947ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6879204 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
kyongjoo.oh 2b45ec65 2025-08-24T12:26:12 CL/VK: Fix default LWS when GWS is less than 64 In the case where LWS is NULL and GWS is smaller than 64, the runtime produces a useless uniform region info. Thus, this change clamps LWS to the GWS to avoid this edge-case. Bug: angleproject:42267067 Change-Id: I418c7d503918f4f082825924b463c266bfd862dc Signed-off-by: kyongjoo.oh <kyongjoo.oh@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6877794 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Shahbaz Youssefi fee2bf73 2025-08-25T15:54:50 Vulkan: Limit EGL_NV_context_priority_realtime to Android Device creation fails on Linux when a REALTIME queue is requested, likely due to permission issues. Bug: angleproject:397474813 Change-Id: I0451db1dac9cbf2795439b251274f1a8057cbd6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6880530 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
hoonee.cho 5fed937e 2025-08-24T12:21:53 CL/VK: Add a compile option "-inline-entry-points" When processing the -cl-std=CL2.0 option, ensure that the processed options string includes both "-cl-std=CL2.0" and "-inline-entry-points". This change addresses a CLSPV's compiler option check failure where the -inline-entry-points flag was not being added when the -cl-std=CL2.0 (using generic address space) was specified. Bug: angleproject:440814992 Change-Id: Ie3e8907e367f21830e58cd5c405de06ba2cbd1da Signed-off-by: hoonee.cho <hoonee.cho@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6877793 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yang Gu 943aed8c 2025-08-25T17:37:34 Skip fake device with remote desktop on Windows When connecting with remote desktop on Windows, a fake device with same vendorId, deviceId, and driverVersion may be reported. This commit adds logic to skip such device to fix end2end tests. Bug: angleproject:440892567 Change-Id: Ie3b602385424bf4a77a302793b34eb06b610bbc9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6878724 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Panfeng Hou d65058be 2025-08-18T11:01:11 Vulkan: Add support for GL_EXT_fragment_shading_rate_primitive Add support for built-in GL_EXT_fragment_shading_rate_primitive and tests. Bug: angleproject:397255625 Change-Id: I0f37a87a73e869a91e39402f01e53166b359ec3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6850353 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Panfeng Hou <panfeng.hou@arm.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Sungyong Choi 7d6aa630 2025-08-13T15:50:24 Reland: Rename enums to fix GCC -Wchanges-meaning error This is a reland of commit dc24ecca9ed920c0269e9d62dfcac4b3f3e5a4d4 Original change's description: > Renamed enums Key and MouseButton to enum class KeyType and > MouseButtonType to avoid name conflicts with union members in > Event.h on GCC, and to follow the ANGLE style guide preference > for scoped enums. > > BUG: angleproject:438226513 > Change-Id: I8892b438b3b05a3ce4e14f8c0769b81722688da8 > Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845484 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> BUG: angleproject:438226513 Change-Id: Ifc1a7bad661881a1a71bd5380fe431270bc68686 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6874206 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu f63751db 2025-08-22T10:34:45 Fix the UniformSortComparator not following strict weak order If one uniform is lowp and the other uniform is mediump, then the compare(a, b) and compare (b, a) both return true. This violates the strict weak order rule where: If comp(a, b) == true then comp(b, a) == false This change fixes the bug. Bug: angleproject:405795981 Change-Id: I47e2668fc0fa87ecea9d3f9bce511c9823a39929 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6876519 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Jisun Lee 0af6e4ee 2025-08-13T06:16:01 Vulkan: Check format compatibility to enable mip levels If redefining the texture level is needed while respecifying the image storage, the base level could be incompatible with the max level count. Enabling the whole level count can cause a null pointer dereference when copying an image that does not support `pixelReadFunction`. To handle the problem, this CL checks the format compatibility and enables only the effective base level. Bug: b/435727832 Test: angle_end2end_tests --gtest_filter=DXT1CompressedTextureTest.* Test: angle_end2end_tests --gtest_filter=Texture2DTestES3.* Change-Id: I01060332f282ef9b2856390d0d7296811a464795 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6813835 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 9eecd3a3 2025-08-25T07:50:36 Revert "Skip clang modules in Android.bp" This reverts commit dddb8a6f815780227f31c982e1f5c7f9e41f40a9. Reason for revert: not needed after https://chromium-review.googlesource.com/c/chromium/src/+/6862663 Bug: chromium:439827607 Original change's description: > Skip clang modules in Android.bp > > These aren't used in Android build, but still listed as dependencies in > GN output and generate_android_bp.py tries to generate rules for them. > > Bug: chromium:439827607 > Change-Id: I01c5c38e15fb4b674f63a6be8ab060e84c381454 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6876280 > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: chromium:439827607 Change-Id: Ic0406ec99a4fad35cf7009c1bb80b081d318d35a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6875545 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0