kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 0679b3eb 2024-07-09T18:55:35 Manual roll vulkan-deps from 17d345a0f23d to 1d4b1061b004 (24 revisions) Suppressing a new sync hazard warning Manual roll requested by romanl@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/17d345a0f23d..1d4b1061b004 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5939e32b87487fa9c72ab336ebfcc5ae26d9ab6d..42d9adf50b4ad7db2a7212318068ec614b36414f https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/00c49e3b56cc9748228d2e5b0d1e8e9c4409a02f..88194ef2d87683f963e735793f20ad1ebce70bc5 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/216574bedb80d439c2533d161e7ea7897504bbb6..9f2ccaef5f70c32bcd6c911a2b09dbb26106b437 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/190d2cb24e90e5bf2bec0a75604a9b3586485b6d..6c539b2ed2dba2997cdedeac0b376ff2fe382595 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/df78ee39d2ff6c10b4f7f2ae06c7ca64524f9e25..d13c1ee715c4674237aca1c775479e1edde87d3c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/96fb5396040477fbbffdc1b4439dea9447f59d80..d03e2bca31b298fc911f7c89cfaf24d28904492d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:352094384 Tbr: romanl@google.com Change-Id: If9da3b32eb405aba8472a020be0c3fd732656f27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5689521 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Igor Nazarov 6052d0f4 2024-07-03T15:17:23 Vulkan: Fix EGL_EXT_buffer_age with single buffered surface The specification: 4) What is the buffer age of a single buffered surface? RESOLVED: 0. This falls out implicitly from the buffer age calculations, which dictate that a buffer's age starts at 0, and is only incremented by frame boundaries. Since frame boundary functions do not affect single buffered surfaces, their age will always be 0. Test: angle_end2end_tests --gtest_filter=EGLBufferAgeTest.SingleBuffer* Bug: angleproject:3529 Change-Id: Iab5da26d1bce56d928398cc250d900465fc5d261 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5675986 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 21fc5e87 2024-07-09T09:30:23 Move loadimage SSE includes/defines out of common headers Including x86intrin.h from common headers appears to be making the "include analysis" tool unhappy. Doesn't look like we actually need it, the only possibly relevant place I could find is the loadimage SSE implementation - but even that wasn't enabled outside of Windows anyways. It is not clear there is a need for the ANGLE_USE_SSE define in other places, at least not at this point. The current implementation also appears to be only for Windows. Move all related code to where it is used - loadimage implementation. Bug: angleproject:42266508 Change-Id: I1eac1510e7515cb6cc85c0332f5de91e0494d3da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5688790 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll c68c7dca 2024-07-09T07:02:27 Roll Chromium from b1148c13c7a9 to f0fb088cc7f4 (639 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b1148c13c7a9..f0fb088cc7f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/52f862e694..b7fc49975c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2054b2e6d5..e73bcd11d1 * buildtools/reclient: re_client_version:0.148.0.41b09b51-gomaip..re_client_version:0.150.0.c8b9fcfa-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/601765ed01..e6ad538b4a * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b11653d13e..48452b983b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1ec7890183..9b20ae8642 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9e9fc99280..01e29c8b5d * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/ed9284c473..da2fe725b8 * third_party/turbine: xWEBZuFKl1Dvw_zOpabeMkGVYlEllIxK06D-RoC6wUsC..trOc8ouN-n-XhBQXk58CGsBa_7JlsOD6mv__HNEiiVEC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/3b67584e7f..98c4117f74 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d7d3f62bf4..c38db6bd79 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: If27fa369068ff5e110696fd7969b4e45f89deaf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5685521 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi c379ff48 2024-06-10T22:01:57 Vulkan: Use VK_KHR_dynamic_rendering[_local_read] Bug: angleproject:42267038 Change-Id: I1f4eb0f309992a9c1c287a69520dadf5eff23b26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5637155 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Alexey Knyazev 2763d520 2024-07-04T00:00:00 Do not rely on 16-bit color read conversions in tests, Part 2 These conversions are not specified. ImageClearTestMetal should assert that all bits are cleared. Bug: angleproject:351644552 Change-Id: I362e244078ad44b777cf926e9512c6af9fe48106 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5684692 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 8c546d35 2024-06-25T12:49:40 Vulkan: Limit VkEvent for usage matters for Manhattan31 only If we use VkEvent to track all image operations causes performance regression on some app traces, including manhattan10 trace. This mainly because of CPU overhead comes with VkCmdSetEvent, mostly inside vulkan driver. These app traces likely not benefit from VkEvent because the specific bubble (false dependency) does not manifest on these app traces, but the CPU overhead takes a performance toll on it. In order to strike a balance between benefit and overhead, this CL removes most of VkEvent usage and only leaves the ones that matters for manhattan31. The only we still keeps are generateMipmap, dispatchCompute, texture sampling. We can always add more if more beneficial usage cases comes up and no regression in other traces. Bug: b/336844257 Change-Id: I346fe70bc33e57edf04e933a2db0f79738c4481d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5654737 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Hailin Zhang a68351cb 2024-07-02T15:57:02 vulkan: add workround for speical shadowmap at intel device. this is a dirty quick patch for game TOA at intel device. at game TOA, we saw a special combination could cause the device lost for intel device. the draw call have 2d shadow map texture. if this draw call followed any other drawcall it will cause device lost, the underhood root cause still unknown. it may be related to combined depth stencil layout or any other case. will try to use separate depth stencil image layout to try. Bug: b/349489248 Change-Id: I4f63fff389b8059d68d27aad387a2fd5888d4ce3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5672966 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Hailin Zhang <hailinzhang@google.com>
Yuly Novikov bc38b7ad 2024-07-08T11:39:43 Start ANGLE Intel macOS 14.5 experiment Bug: chromium:350362798 Change-Id: I504318306eb96d6983a366595bbde6cb77c0bb67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5682424 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Roman Lavrov 0a7e1daf 2024-07-05T16:05:20 Tests: fix MultithreadFenceDraw, MultithreadFenceTexImage Before this CL, pixels _after_ swapBuffers() were checked and in a way that was causing a data race on mDrawGreen access. It seems to have passed in certain special-case scenarios but was mostly broken, which might explain the numerous issues that it caused. After this CL, pixels are checked on each of 5 iterations _before_ swapBuffers() and mDrawGreen race is eliminated by ensuring read happens before the background thread is unblocked. Bug: b/338429767 Bug: b/42265212 Bug: b/42264513 Bug: b/267953710 Bug: b/42266622 Bug: b/328156792 Bug: b/42266649 Bug: b/40096752 Bug: b/42263977 Change-Id: Id0fa72ea69e29c6fd5abdb225ff1dbadb18b221b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5675283 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Alexey Knyazev 640e3716 2024-07-04T00:00:00 Do not rely on 16-bit color read conversions in tests These conversions are not specified. D3DTextureClearTest should assert that all bits are cleared. Texture2DNorm16TestES3.TextureNorm16*TextureTest should not use 16-bit framebuffer attachments as they are tested separately. Bug: angleproject:40096653 Bug: angleproject:351644552 Change-Id: Ib22e9fcc3b643725f25f6ed880569888107928ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5683107 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Roman Lavrov 3c8a8f7a 2024-07-08T09:56:49 Temporarily angle_enable_vulkan_api_dump_layer default false Causing flaky build failures. There is a fix upstream but it caused another issue so we can't roll yet. Bug: b/350816748 Change-Id: I10da65a50988b91fe52f8545bf96a635a43ab438 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5683562 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 2a87db69 2024-07-06T22:20:40 Vulkan: Remove unused render pass closure reason Bug: angleproject:42266019 Change-Id: I1c516b88677d7c9d3e97e9fd7525cf727be50cc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5678940 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6c6975af 2024-07-05T12:28:54 Manual roll vulkan-deps from 5fdd3da87369 to 17d345a0f23d (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5fdd3da87369..17d345a0f23d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/704107fda3827377f00e57dff0c21da019bff4ae..5939e32b87487fa9c72ab336ebfcc5ae26d9ab6d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/2acb319af38d43be3ea76bfabf3998e5281d8d12..41a8eb27f1a7554dadfcdd45819954eaa94935e6 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/973e791a9ac122f903c2796349a538b278cbe29b..216574bedb80d439c2533d161e7ea7897504bbb6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/afeb91d6d2110717b8c842081eff410617aed1ef..96fb5396040477fbbffdc1b4439dea9447f59d80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2e1c6204e675eb8e70ed68dbe13b912bd6ffce6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5678939 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll 66f4b76c 2024-07-08T07:01:23 Roll Chromium from a98f22a2505a to b1148c13c7a9 (354 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a98f22a2505a..b1148c13c7a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f0d4b73cd3..52f862e694 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a092d8b8e3..2054b2e6d5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ca782dd95b..601765ed01 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/812e1c5aa6..1ec7890183 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/452fe3be37..9e9fc99280 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/ebabc6deb7..3bd143299e * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/002bae033a..604bb086b1 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e5b130d5dc..a3c7d3e2f3 * third_party/r8: N31NPLsO2NWciwYQ3-i1_ApNlwHV1lv74XrrQY4KfVQC..FkhioB3uZmGFZXh9T_oVHXWyTi8UHB_7BDlrkn8IPpIC * third_party/siso/cipd: git_revision:98713f62d1efa5181177bc506b0941e439f7d6cb..git_revision:2771ced2186c49911899699f831f96ceea4812f6 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/303336503e..210eabb02a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2e46e64ec6..d7d3f62bf4 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Ia163ae1f646b5484b2530bf909a13dd6139c1cac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5681862 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi db00dee5 2024-07-05T21:11:53 Vulkan: Fix SPIR-V gen for literally indexed swizzles Translation did not take into account the fact that a swizzled vector can be indexed by a literal (like `vec.zzxy[2]`, which should translate to `vec.x`). Since this issue affects MSL generation too, such expressions are folded before they reach the output generators. Bug: b/351102615 Change-Id: I048aca165cdf22ef8cd7ccd9a8e503ccf636a55f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5680354 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev 58dc069c 2024-07-04T00:00:00 Rename 16-bit EXPECT_PIXEL test helpers Do not use UI suffix as the format is normalized. Bug: None Change-Id: Ib635397f2cdec02806c2c31484820b9b6964a066 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5680605 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 1dd3a4c4 2024-07-04T00:00:00 D3D11: Use built-in position for gl_FragCoord.z on SM 4.0+ If supported, used built-in pixel position input for the gl_FragCoord.z value. Exposed GL_EXT_clip_control only on feature level 10_0 or higher. Fixed: angleproject:347737886 Change-Id: I272ccce04cf6ad7921aa6cd5dc13f0de2f9ae561 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5679787 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Yuly Novikov f22189ec 2024-07-05T15:07:03 Roll chromium_revision c174259bf6..a98f22a250 (1323232:1323712) Manual roll updating android_sdk to 35. Change log: https://chromium.googlesource.com/chromium/src/+log/c174259bf6..a98f22a250 Full diff: https://chromium.googlesource.com/chromium/src/+/c174259bf6..a98f22a250 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c5d8ec8cab..f0d4b73cd3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9cac81256b..a092d8b8e3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/26d2c6829f..ca782dd95b * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/7083198328..dc4679d47e * third_party/android_sdk/public: YK9Rzw3fDzMHVzatNN6VlyoD_81amLZpN1AbmkdOd6AC..DxwAZ3hD551Neu6ycuW5CPnXFrdleRBd93oX1eB_m9YC * third_party/android_sdk/public: HWVsGs2HCKgSVv41FsOcsfJbNcB0UFiNrF6Tc4yRArYC..WihaseZR6cojZbkzIqwGhpTp92ztaGfqq8njBU8eTXYC * third_party/android_sdk/public: u-bhWbTME6u-DjypTgr3ZikCyeAeU6txkR9ET6Uudc8C..kIXA-9XuCfOESodXEdOBkW5f1ytrGWdbp3HFp1I8A_0C * third_party/android_system_sdk: 4QeolYaSKWBtVTgzJU4tHUfzA9OJTDM8YUcD426IctwC..XzzECzCzGLrccJS1U-HdmM5VMh9BotgQ_mWhFQ464PwC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e190315d54..812e1c5aa6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c117716649..452fe3be37 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/450ae0d297..002bae033a * third_party/r8: ghhdiXdRlQvak1W9wGUqI07tD2WFwdgJPVc8guIKXSsC..N31NPLsO2NWciwYQ3-i1_ApNlwHV1lv74XrrQY4KfVQC * tools/luci-go: git_revision:6fb4d5d26773ebddeac2c57506324493e4220007..git_revision:c9c95dda5f310610a3fc574af44faeed298b3938 * tools/luci-go: git_revision:6fb4d5d26773ebddeac2c57506324493e4220007..git_revision:c9c95dda5f310610a3fc574af44faeed298b3938 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6b98f1443e..062978f309 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7395a9f72e..2e46e64ec6 * tools/skia_goldctl/linux: LDPByLYqasHSy5ZxdGy0llSDaUnwdxFfx6L2NvZjxhwC..Tmr9c1O-W7mu7zgVbAgDIpLiDFfiWA2nnWa7FYu0pjgC * tools/skia_goldctl/mac_amd64: Ri84uKWwD6OsP-lJpo7z2X68GibM6ynfZZaSXer2GoYC.._7hIgAZisiST_h_sDMLpXETbV5CzGfmG4Oxm38v4rlEC * tools/skia_goldctl/mac_arm64: 8Yalv78nDvaIEFLlX-HbY-a-QueK4PQzFMEEhzt0bZQC..JFa9d9Q6qO_diHbU_E8cW9EMTEBkDXLlZz8-USH6YLAC * tools/skia_goldctl/win: KhS-PwKl3anmwJCxKIGQYybgN0loA5nw8vVRglJNhngC..VoFA8h7UVLHiMG1OJitx6oYOOdQYwTVztBFAMdPaqywC DEPS diff: https://chromium.googlesource.com/chromium/src/+/c174259bf6..a98f22a250/DEPS No update to Clang. Bug: None Change-Id: I613eb40b3455d11525659d0f0b83f10202dfc55d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5680348 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 7489c5f0 2024-07-05T10:01:00 Roll SwiftShader from a0ec371d8331 to f23c77132e0b (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/a0ec371d8331..f23c77132e0b 2024-07-04 swiftshader.regress@gmail.com Regres: Update test lists @ a0ec371d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I5476042f5c4913c685aeae2a058247d1237953d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5679678 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jordan Brown c46d94d1 2024-07-04T05:45:53 Updating ceval's README.chromium to include Revision Change-Id: Ieca214504cb28daaf944c2dcac7044f413b0bfdc bug: b/350851535 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5677899 Auto-Submit: Jordan Brown <rop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Alexey Knyazev fe02de25 2024-07-04T00:00:00 Metal: Remove MTLGetMSL dependency on context Bug: angleproject:351165323 Change-Id: Idf56665cce67dcf51ac4d6148212786bcc398b67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5678417 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jordan Brown dfec7f4c 2024-07-04T05:50:05 Updating clspv's README.chromium to include Revision Change-Id: Id4204aebbbd9eb61f25982a6acbd783987944016 bug: b/350851535 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5678093 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jordan Brown <rop@google.com>
Shahbaz Youssefi cb0b851f 2024-06-27T11:34:57 Add Revision: field to third party Bug: chromium:349528337 Change-Id: Ieb7f1ee7c2911c932cc874a1909a7ba4a53f1f42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5658807 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang fcf3a1c0 2024-07-02T16:33:28 GL: Allow shader compilation with cached translated source Write the translated shader source when serializing shaders. This does not increase the size of the shader cache because Vulkan only uses the compiledBinary field. Spawn a ShaderTranslateTask for loading shaders so the GL backend can compile the shader on the native driver. Bug: angleproject:350779978 Change-Id: I14413a7ca2a0d99653a1082f2c8b4a94cf58626a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5672740 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Igor Nazarov 7d61980e 2024-06-26T18:39:53 Vulkan: Rename DescriptorSetLayoutDesc update() to addBinding() The `update()` method is never actually used to update the exiting bindings (but rather to add new ones), this change renames the method to `addBinding()` and adds few ASSERTs for clarity. Also, after recent changes in `DescriptorSetLayoutDesc` class, some changes made by `update()` method are irreversible. It is possible to have different descriptions that will produce same layout if use `update()` to rewrite the existing structure. Bug: angleproject:8677 Change-Id: If85eb2b271bc06843ee9326c024d73801d3da091 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5676345 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang a4f3f6bf 2024-07-02T16:25:05 GL: Simplify members of ShaderGL. It does not need to store anything except the shader ID. Everything else can be queried from the context. Bug: angleproject:350779978 Change-Id: I202ae8e59e8c5b10ffb24f5454151b17818d400c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5672739 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev b7d4c5d1 2024-07-04T00:00:00 Metal: Disable fast math if isinf or isnan are used Fixed: angleproject:42266714 Fixed: angleproject:42267063 Change-Id: Ibf6508ffc7d458a6b91b9218b2b488b6aa5b1001 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5678416 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi 397eb7c8 2024-06-29T00:22:42 Vulkan: Easier to read SPIR-V disassembly Bug: angleproject:349994211 Change-Id: I9d8da4a9fa336e1f5ecdfa39c33959ecebb2c6ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5667081 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll d66ac358 2024-07-04T08:23:45 Roll Chromium from 34f452e68b67 to c174259bf610 (620 revisions) https://chromium.googlesource.com/chromium/src.git/+log/34f452e68b67..c174259bf610 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/229704c27a..c5d8ec8cab * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/819c7ae6e8..9cac81256b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/bf1591ad6e..26d2c6829f * third_party/android_build_tools/lint: _oR7ebBg7HOz8losirWwVBzIiJ9AtS3Xv34pUNKrkNQC..e_WxdIopgECi7lR7hSDoHgOVaSHP0TtgcfjFowfwUkgC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ca091f0d16..c117716649 * third_party/fuchsia-sdk/sdk: version:22.20240627.2.1..version:22.20240703.0.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0312683647..450ae0d297 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/48659aac13..8f49d6467f * third_party/r8: LTSDrGmBi20GhRBdECo0D_7MWCBSYjL1iDNPzxLmeLIC..ghhdiXdRlQvak1W9wGUqI07tD2WFwdgJPVc8guIKXSsC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/a05e27145f..3b67584e7f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/04455f259c..6b98f1443e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/04ec6d97b6..7395a9f72e No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I2412561a8eac60af7484f6d15b51bc77da9962e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5675394 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f2ee319d 2024-07-03T07:02:13 Roll Chromium from 51d79108bbb3 to 34f452e68b67 (970 revisions) Due to http://crrev.com/c/5651996: 1. Don't use Xvfb for angle_unittests. 2. Force --use-xvfb in restricted_trace_gold_tests. https://chromium.googlesource.com/chromium/src.git/+log/51d79108bbb3..34f452e68b67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/feff4a53b0..229704c27a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2984b8fcc4..819c7ae6e8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/106f24b1e1..bf1591ad6e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/36641ab0e3..e190315d54 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6a00e594c9..ca091f0d16 * third_party/flatbuffers/src: https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/6ede1ccc9e..fb9afbafc7 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/144e2174e9..0312683647 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8b7eff801b..68e57e619c * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/66f8276b4e..a05e27145f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7e2aebd75d..303336503e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7c0882a310..04455f259c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/aaadc0d4ed..04ec6d97b6 No update to Clang. Bug: chromium:40257169 Change-Id: Ibe9a6bd3906df8cedb42f56adfe5085046b68bd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5673851 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Alexey Knyazev b954755f 2024-07-02T00:00:00 Release all memory allocated in TCompiler::compile Ensured that single-page allocations from compile jobs are released to OS. Fixed: angleproject:350528355 Change-Id: I5a0d9fd7dbc065f4b4127ceecb3fd6538eb8948d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5673352 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Geoff Lang b6456334 2024-04-02T15:03:17 Reland: GL: Support KHR_blend_equation_advanced Combine blend equation setting when they are equal. It is invalid to set advanced blend equations for color/alpha separately. Emit blend equation layout qualifiers. This is an unchanged reland of https://chromium-review.googlesource.com/c/angle/angle/+/5415033 and depends on a GL dispatch table fix in https://chromium-review.googlesource.com/c/angle/angle/+/5670963 Bug: angleproject:42267098 Change-Id: Id669cf98ec2b7d46eab174717964f8d6daf88b29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5659200 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll d3987e50 2024-07-03T10:01:47 Roll vulkan-deps from 5faad80a00af to 5fdd3da87369 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5faad80a00af..5fdd3da87369 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8a5086efb01ce204a0060ae8fbe112aba935d44f..704107fda3827377f00e57dff0c21da019bff4ae https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/c91d9ec1580dce89b10b0ca6a368800e2deaf1cb..973e791a9ac122f903c2796349a538b278cbe29b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/35eb0bf879cf10dd7bd5835ba8399682f741a0c0..7e13360e42364fdd1f07fe00f19d0432b12db055 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/803ef169856697d93f69b5d01489763a114e81cb..afeb91d6d2110717b8c842081eff410617aed1ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: If720679783a080a524763809ac462f8840618528 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5675287 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 2efce9ba 2024-07-01T13:15:57 Roll chromium_revision 40020cda88..51d79108bb (1320198:1321642) Manual roll to define non_git_source used in updated android_deps. Change log: https://chromium.googlesource.com/chromium/src/+log/40020cda88..51d79108bb Full diff: https://chromium.googlesource.com/chromium/src/+/40020cda88..51d79108bb Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d6f058677a..feff4a53b0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/94d7b86a83..2984b8fcc4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ab63c08c0e..106f24b1e1 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3736ae744b..5b83c679ba * third_party/android_build_tools/bundletool: CaAT7TJbLQC0LVo1i2TXtaMjK4SZBQ33n-s6DcBbZfgC..X5yajoh75x5lwpY1-eO4tey50eTX4XkB5JE1WXVal_MC * third_party/android_build_tools/manifest_merger: dqr3Fhw6TQYW7lV6aRiySbcHsEuAiFeTuoUZHdkdK08C..UZ47yEDJAQYl7Uj6uUofbCrmnK8Bycu18fSFQAMO2agC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/41e22814bc..b11653d13e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/022cd349fe..36641ab0e3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f4e8e13e8b..6a00e594c9 * third_party/fuchsia-sdk/sdk: version:21.20240620.2.1..version:22.20240627.2.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/09b99fd8ab..144e2174e9 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/6171cc7fb1..e5b130d5dc * third_party/r8: M8rc1oybTkWXWpoImSQ8gAwv6mdEyvAPnQNs6Dus_28C..LTSDrGmBi20GhRBdECo0D_7MWCBSYjL1iDNPzxLmeLIC * third_party/siso/cipd: git_revision:b45592fde7d08bdee282d3d2d0cf4faa55588885..git_revision:98713f62d1efa5181177bc506b0941e439f7d6cb * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e5f2479d0d..7e2aebd75d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cd747a5520..aaadc0d4ed DEPS diff: https://chromium.googlesource.com/chromium/src/+/40020cda88..51d79108bb/DEPS No update to Clang. Bug: b/320564950 Change-Id: I59785e937633ce4651c07304291a8219fff492cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5667367 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Geoff Lang ef2c9665 2024-07-02T11:25:17 GL: Fix dispatch table for desktop-only entry points In gl.xml, each extension and entry point within the extension can express which API it is supported in. The dispatch table generator was ignoring the per-entry point support information and assuming deferring to the extension-level support. Extensions like EXT_blend_minmax which only adds glBlendEquationEXT on desktop GL would overwrite the blendEquation entry point with a non-existant (null) glBlendEquationEXT on GLES. This also simplified the lack of KHR suffixes on desktop GL since they are listed with the proper desktop-only api requirements in gl.xml. Bug: angleproject:42267098 Change-Id: I906969335d5b82831dd82699d910f444afa68cd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5670963 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 78ee33e4 2024-07-01T15:42:55 Roll third_party/dawn/ 6cdf3a1a1..eb249b37e (310 commits; 3 trivial rolls) We need to roll in https://dawn-review.googlesource.com/c/dawn/+/196054 to ublock rolling libc++ into ANGLE. Add special handling of Undefined WGPU formats due to also rolling https://dawn-review.googlesource.com/c/dawn/+/193360 https://dawn.googlesource.com/dawn.git/+log/6cdf3a1a195f..eb249b37e3e8 $ git log 6cdf3a1a1..eb249b37e --date=short --no-merges --format='%ad %ae %s' 2024-07-01 blundell [Vulkan] Set the Vk descriptor type correctly for YCbCr samplers 2024-07-01 blundell [Vulkan] Map FilterMode to Vulkan filter correctly for YCbCr info 2024-07-01 dawn-autoroll Roll vulkan-deps from 773555d3bd22 to 4a2ff9e87700 (1 revision) 2024-06-30 dsinclair [hlsl] Handle compute builtins for ShaderIO transform. 2024-06-30 dsinclair [hlsl] Add some existing transforms 2024-06-29 jrprice [msl] Regenerate test expectations 2024-06-29 dsinclair [hlsl] Split module var structs and arrays. 2024-06-29 dawn-autoroll Roll vulkan-deps from 2796aaff7eef to 773555d3bd22 (9 revisions) 2024-06-29 cwallez opengl: Add support for EGL_EXT_pixel_format_float. 2024-06-29 kainino Summarize CTS failures as first line of first max-severity log 2024-06-29 jaswant.panchumarti Do not turn off CMAKE_CXX_EXTENSIONS 2024-06-28 rafael.cintron Disable render passes on Windows until support can be detected 2024-06-28 enga [headers] Remove the Flags enums and make them 64-bit 2024-06-28 dsinclair [hlsl] Stub out the DecomposeMemoryAccess IR transform. 2024-06-28 cwallez opengl: Add support for EGL_KHR_no_config_context. 2024-06-28 jaswant.panchumarti Disable GLFW_INSTALL 2024-06-28 jaswant.panchumarti Add third_party/google_benchmark/src in fetch_dawn_dependencies.py 2024-06-28 jaswant.panchumarti Always build glslang as static library 2024-06-28 dawn-autoroll Roll vulkan-deps from 7ff358e64e2b to 2796aaff7eef (10 revisions) 2024-06-28 enga Fix Wayland build 2024-06-28 dawn-autoroll Roll ANGLE from 46dd6457f4bf to a674dc1dae8f (3 revisions) 2024-06-28 dawn-autoroll Roll DirectX Shader Compiler from 206133c9e7e1 to 49d1ae9a029c (1 revision) 2024-06-27 bsheedy Mark problematic expectation block as KEEP 2024-06-27 rharrison [tint][fuzz][ir] Implement test case disassembler 2024-06-27 dsinclair [hlsl] Add transform to remove struct and array initializers to lets. 2024-06-27 enga Re-number enum values part 2 2024-06-27 rharrison [tint][fuzz][ir] Batch process files when generating corpus 2024-06-27 cwallez GL: Add support for wgpu::Surface. 2024-06-27 jrprice [tint] Fix UB in FileContent copy constructor 2024-06-27 dsinclair [hlsl] Add ValueToLet transform. 2024-06-27 dsinclair [hlsl] Add ShaderIO transform. 2024-06-27 jaswant.panchumarti Use dawn_add_library function to create the dawn_glfw library 2024-06-27 jaswant.panchumarti Use dawn_add_library function to create the dawn_utils library 2024-06-27 jaswant.panchumarti Use dawn_add_library function to create the dawn_wire library 2024-06-27 jaswant.panchumarti Use dawn_add_library function to create the dawn_native library 2024-06-27 dsinclair [glsl] Extract textureBuiltinFromUniformData 2024-06-27 dawn-autoroll Roll vulkan-deps from 1c484942880c to 7ff358e64e2b (4 revisions) 2024-06-27 hans Fix std::vector<const T> 2024-06-27 dawn-autoroll Roll ANGLE from 0bf157f12bb8 to 46dd6457f4bf (5 revisions) 2024-06-27 dsinclair [glsl] Extract combinedSamplerInfo 2024-06-27 jrprice [fuzz] Skip PixelLocal with multiple entry points 2024-06-27 jrprice [tint] Pre-clone symbols in IR->AST pass 2024-06-27 jrprice [fuzz] Add TextureBuiltinsFromUniform precondition 2024-06-27 jrprice [tint] Fix collision check in multiplanar fuzzer 2024-06-27 jaswant.panchumarti Use dawn_add_library function to create the dawn_platform library 2024-06-27 jiawei.shao Fix crash when using constant expression as `@blend_src` 2024-06-26 rharrison [tint][ir][fuzz] Convert assembler to generating test case protos 2024-06-26 jaswant.panchumarti Use dawn_add_library function to create the dawn_proc library 2024-06-26 dawn-autoroll Roll ANGLE from 046327343595 to 0bf157f12bb8 (5 revisions) 2024-06-26 dawn-autoroll Roll DirectX Shader Compiler from e5183a06b913 to 206133c9e7e1 (1 revision) (...) 2024-06-17 dawn-autoroll Roll SwiftShader from 085997ddb08b to cea33ab2d5ad (1 revision) 2024-06-17 jimblackler Integration test in the library. 2024-06-17 dawn-autoroll Roll vulkan-deps from 897d900fc1b1 to 7f05a36fb6d9 (1 revision) 2024-06-17 dawn-autoroll Roll DirectX Shader Compiler from 206b7c2e537a to 8c3f40c0ae12 (1 revision) 2024-06-17 dawn-autoroll Roll ANGLE from d521dd08bef4 to 7f70cd0da27c (1 revision) 2024-06-16 dawn-autoroll Roll vulkan-deps from 1bd6201121db to 897d900fc1b1 (1 revision) 2024-06-15 jimblackler Alternate way of generating the bindings inside Gradle. 2024-06-15 jimblackler Fix for incorrect import path for webgpu.h. 2024-06-15 jimblackler Move 'Util' to a new location, and convert to Kotlin. 2024-06-15 dawn-autoroll Roll vulkan-deps from dd296c842e50 to 1bd6201121db (7 revisions) 2024-06-15 dawn-autoroll Roll ANGLE from bcb567a7f8e4 to d521dd08bef4 (7 revisions) 2024-06-14 hitawala [YCbCr Samplers] Get supported SampleTypeBit for external format 2024-06-14 senorblanco OpenGLES: more end2end test cleanup. 2024-06-14 enga Fix wgpu::Status return value for wgpuSurfaceGetCapabilities 2024-06-14 kainino Use ityp::array for sVertexFormatTable 2024-06-14 dawn-autoroll Roll vulkan-deps from 42ee85cf2154 to dd296c842e50 (2 revisions) 2024-06-14 dawn-autoroll Roll Depot Tools from 88a72320ed30 to 1d1f17af898b (4 revisions) 2024-06-14 dawn-autoroll Roll DirectX Shader Compiler from 56f3c4038159 to 206b7c2e537a (1 revision) 2024-06-14 enga Remove 0-value enums that aren't ever valid 2024-06-14 dawn-autoroll Roll ANGLE from 973e5261a0fd to bcb567a7f8e4 (7 revisions) 2024-06-14 senorblanco Revert "Make a convenience cpp method for WaitAny with one future" 2024-06-14 dawn-autoroll Roll vulkan-deps from 7db4057407f4 to 42ee85cf2154 (8 revisions) 2024-06-14 enga Make a convenience cpp method for WaitAny with one future 2024-06-14 dawn-autoroll Roll Depot Tools from 43c6415bced9 to 88a72320ed30 (3 revisions) 2024-06-14 beaufort.francois Make GPUAdapter GetInfo() a suitable replacement for GetProperties 2024-06-14 rharrison [tint][ir][fuzz] Disable building IR fuzzer when ASAN is enabled 2024-06-14 enga AHB: Don't add storage binding unless AHARDWAREBUFFER_USAGE_GPU_DATA_BUFFER 2024-06-14 dsinclair [hlsl] Fix incorrect HLSL test output 2024-06-14 rharrison [tint][ir][fuzz] Fix breakage of fuzz_cmd target for CMake 2024-06-13 dsinclair [hlsl] Add HLSL IR printer var/let tests 2024-06-13 dsinclair [ir] Add a templated `zero` helper. 2024-06-13 dawn-autoroll Roll ANGLE from 65f8dc8e3ad8 to 973e5261a0fd (5 revisions) 2024-06-13 dsinclair [hlsl] Add generated IR expectations. 2024-06-13 jrprice [msl] Regenerate E2E expectations 2024-06-13 lehoangquyen D3D11: split Buffer class into GPUOnlyBuffer and StagingBuffer 2024-06-13 senorblanco OpenGLES: enable/triage misc end2end tests. 2024-06-13 chouinard Remove storage textures from vertex tests 2024-06-13 chouinard Disallow textureStore in vertex shader tests 2024-06-13 chouinard Replace textureStore test with frag shader 2024-06-13 jrprice [msl] Add polyfill for textureNumSamples 2024-06-13 jrprice [msl] Add polyfill for textureNumLayers 2024-06-13 jrprice [msl] Add polyfill for textureSampleCompare 2024-06-13 jrprice [ir] Strip all IO attributes in ShaderIO transform 2024-06-13 fdurso SampleUtils: Add missing newline in output message 2024-06-13 wong.kl.matthew dawn/node: Update documentation for ASan CMake builds. 2024-06-13 dawn-autoroll Roll DirectX Shader Compiler from 4353db3983e2 to 56f3c4038159 (2 revisions) 2024-06-13 ynovikov Revert "d3d: Change D3D references to PhysicalDevice to WeakRef instead of Ref" 2024-06-13 dsinclair [hlsl] Add HLSL IR printer constant tests 2024-06-13 dawn-autoroll Roll vulkan-deps from 7d45b6d174eb to 7db4057407f4 (13 revisions) 2024-06-13 dawn-autoroll Roll Depot Tools from c0883c509ea3 to 43c6415bced9 (3 revisions) Created with: roll-dep third_party/dawn Bug: chromium:323708866, chromium:349411322, dawn:42241166 Change-Id: Iad65ef83c0ec47a6aba3fdc7de511ff22f586d4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5667168 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll d6bd2c70 2024-07-02T10:01:18 Roll vulkan-deps from 4a2ff9e87700 to 5faad80a00af (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4a2ff9e87700..5faad80a00af Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/33c7e30860928bab3819c3abae8297b109a02f73..8a5086efb01ce204a0060ae8fbe112aba935d44f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/36bf8bb4aa7220254385de704775fe982eea5ecf..38691803018cb2d85194b235faf43119d64c0a66 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/a3b0dae2528425de20965ca7a11a2e3086575956..35eb0bf879cf10dd7bd5835ba8399682f741a0c0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2d13d34909e375e1850e6eaf8860052b9764656b..803ef169856697d93f69b5d01489763a114e81cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I88ee3bc79f77010b5aa95826be4c576920740e5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5670436 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski d8700dc9 2024-06-28T15:04:20 Avoid ANGLE vulkantools dependency in Dawn build !build_with_chromium was too broad and didn't cover the Dawn builds. Bug: angleproject:350042736 Change-Id: Ibee1adfceaa1d5888167bcc442723e612ccfe232 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5666597 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 8667fb3e 2024-07-01T10:01:44 Roll vulkan-deps from 2796aaff7eef to 4a2ff9e87700 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2796aaff7eef..4a2ff9e87700 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ea087ff90d03947307cfe52500b74551aa35d34d..33c7e30860928bab3819c3abae8297b109a02f73 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/05f36c032ef20676eff121a8c8d5e6e33796ec8b..36bf8bb4aa7220254385de704775fe982eea5ecf https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/345af476e583366352e014ee8e43fc5ddf421ab9..a3b0dae2528425de20965ca7a11a2e3086575956 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/144ce1b3c19caf29a69fca192fb168f3aa7ab9aa..df78ee39d2ff6c10b4f7f2ae06c7ca64524f9e25 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a190959aa0992dafda40ef67822dfbebb6d5ab3f..2d13d34909e375e1850e6eaf8860052b9764656b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Id888de0f1c62d5f3ff9b9feb32582ab4289e85fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5669888 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2a2b5cbd 2024-07-01T08:01:48 Roll VK-GL-CTS from 25d8c0099575 to 43432bf265e3 (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/25d8c0099575..43432bf265e3 2024-06-28 cturner@igalia.com hevc decode: add scaling list tests 2024-06-28 michal.jakubek@mobica.com Tests for dedicated device memory overallocation. 2024-06-28 jbolz@nvidia.com SPV_EXT_replicated_composites 2024-06-28 piotr.byszewski@mobica.com Test setting pColorAttachmentInputIndices to NULL 2024-06-28 gleese@broadcom.com Check for ES3.1 support in EGL Sync test 2024-06-28 piotr.byszewski@mobica.com Test mismatched dimensionality 2024-06-28 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-06-27 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia88ba0e9b36d6fdcc2f9cee0f94a2fb5d1886e4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5669887 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Steven Noonan 4f23429a 2024-06-28T14:20:26 egl_angle_ext: fix incorrect EGL_ANGLE_device_d3d11 name Bug: angleproject:349972038 Change-Id: I11d8442d3f88bc6767b9e184179f88a984162e08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5668322 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net>
angle-autoroll 1062271d 2024-06-28T10:01:47 Roll vulkan-deps from 7ff358e64e2b to 2796aaff7eef (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7ff358e64e2b..2796aaff7eef Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/ca004da9f9c7fa7ed536709823bd604fab3cd7da..c91d9ec1580dce89b10b0ca6a368800e2deaf1cb https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/e3c37e6e184a232e10b01dff5a065ce48c047f88..190d2cb24e90e5bf2bec0a75604a9b3586485b6d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/60fe7d0c153dc07325a8fb45310723a1767db811..144ce1b3c19caf29a69fca192fb168f3aa7ab9aa https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/df3e018436e38c2536d5b79e1e662e6323b6fbe2..a190959aa0992dafda40ef67822dfbebb6d5ab3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I0c877374590e2ab35c0f0fc46b5c4388944647e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5665715 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi e86ba9ab 2024-06-26T13:38:18 Vulkan: Fix querying support of prim restart patch * Added a cap to reflect support for primitive restart for patches. * primitiveRestartForPatchesSupported * In Vulkan, it is determined through the following component from the existing related device feature: * primitiveTopologyPatchListRestart * Updated querying PRIMITIVE_RESTART_FOR_PATCHES_SUPPORTED via glGet(). * Now it is only available on ES 3.2 or if tessellation shaders are supported. Otherwise, there will be a validation error. * It returns primitiveRestartForPatchesSupported. * Added a unit test that queries this value and ensures that it remains the same regardless of whether primitive restart is enabled. Bug: angleproject:349610458 Change-Id: If43a5326f0886cf10e38b4e73a868f46b1052533 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5661108 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Mark Lobodzinski 3813e805 2024-06-21T14:29:55 Add env var/property control of API dump layer Layer is now included with all debug/assert builds or when specified through GN arg. VK_VULKAN_API_DUMP_LAYER on desktop, or for android set debug.angle.enable_vulkan_api_dump_layer to 1. Also included some renaming since layers other than validation are supported. Bug: angleproject:8623 Change-Id: I2bb976dede53712f781a531d0c4f3ce4d33f052c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5649937 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi a674dc1d 2024-06-21T14:48:06 Unify updating cached color/read render targets Currently in updateColorRenderTarget(), there are two calls to update cached render target if the read RT is the same as the color RT, which means getting the same attachment RT twice. In case it is the same attachment, there can be one call to update both. * Updated updateColorRenderTarget() so if the read attachment and the color attachment are the same, it will only get the attachment RT once. Otherwise, it will update the read RT separately. Bug: angleproject:348704287 Change-Id: I9ff9fb2a4edbd4420feece0ee6edd40f1f7efdca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5647497 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll d9394447 2024-06-27T10:01:24 Roll vulkan-deps from d2e24d980359 to 7ff358e64e2b (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d2e24d980359..7ff358e64e2b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/fa9c3deb49e035a8abcabe366f26aac010f6cbfb..ea087ff90d03947307cfe52500b74551aa35d34d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/64d37e2811a794f614bc569338afa47dbdfefa0e..ca004da9f9c7fa7ed536709823bd604fab3cd7da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I1547b02520f0c93a13117801de7a1eef00f94e2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5662958 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 48ebe740 2024-06-27T07:01:09 Roll Chromium from 44cf5c690e8b to 40020cda886f (613 revisions) https://chromium.googlesource.com/chromium/src.git/+log/44cf5c690e8b..40020cda886f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/31c1a4bbff..d6f058677a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b4630be7ae..ab63c08c0e * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d88164a565..3736ae744b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d470211d6..f4e8e13e8b * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/bac941ca44..6171cc7fb1 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/dcc1ffafb5..48659aac13 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/754a06d129..66f8276b4e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fa08dd50e4..e5f2479d0d * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/4ac80c5c63..a0eeba1c75 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c25f77b1e4..cd747a5520 No update to Clang. Bug: angleproject:42267082 Tbr: cnorthrop@google.com Change-Id: Ia4bdea114e7c6867a5d32e8a00ad612099139615 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5662335 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 46dd6457 2024-06-25T15:56:15 Vulkan: Use DONT_CARE ops for missing D/S aspects Simplifies op tracking with dynamic rendering. Bug: angleproject:42267038 Change-Id: I394c154d94458c470190fea66d82c408e6f33725 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5655873 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Matthew Denton 35f01e7f 2024-06-26T14:30:27 ESSL -> WGSL: Support basic control flow If/else, while, do/while, for. Return, break, continue, discard Bug: angleproject:42267100 Change-Id: I0c8ef30b45aec639a07323e333db970d4c42dec0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5661103 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Matthew Denton 89ef2812 2024-06-26T11:19:54 ESSL -> WGSL: unary and binary exprs, operators, array access Array indexing is always checked to be within bounds. For runtime-sized arrays, this requires emitting a clamp(). For now this includes a bug the left-side-expression (the array itself) has any side effects, which shouldn't actually be possible but may be in future versions of WGSL. Implementing unary, binary, and remaining aggregate expressions requires implementing operators, many of which do not have exact corresponding versions between GLSL and WGSL. This implements many operators but for simplicity leaves some unimplemented and some half-implemented. See WGSLOutput_test.cpp for some code examples. Bug: angleproject:42267100 Change-Id: I3737abb5dffd156deba0429fa86570270d711d3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5651994 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4f8c42de 2024-06-26T14:37:12 Manual roll VK-GL-CTS from c201252e6fbe to 25d8c0099575 (13 revisions) Manual roll requested by cnorthrop@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c201252e6fbe..25d8c0099575 2024-06-21 ziga@lunarg.com Modify pipeline state tests to only set necessary states 2024-06-21 benjamin.cheng@amd.com Add missing dependencies for decode h265 + maintenance1 tests 2024-06-21 gleese@broadcom.com Fix spirv error in fp16 tests 2024-06-21 kamil.goras@mobica.com Split KHR-GLES32.core.tessellation_shader.tessellation_control_to_tessellation_evaluation.gl_MaxPatchVertices_Position_PointSize 2024-06-21 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-06-20 syoussefi@google.com Remove DE_NULL from generated files 2024-06-20 syoussefi@google.com Avoid spamming logs on infra errors 2024-06-17 syoussefi@google.com Use VK_NULL_HANDLE instead of DE_NULL in var decl 2024-06-15 syoussefi@google.com Use VK_NULL_HANDLE instead of DE_NULL when creating images 2024-06-15 syoussefi@google.com Use VK_NULL_HANDLE instead of DE_NULL when creating pipelines 2024-06-14 syoussefi@google.com Use VK_NULL_HANDLE instead of DE_NULL for non-dispatch handles 2024-06-14 syoussefi@google.com Use VK_NULL_HANDLE instead of DE_NULL for pipelines 2024-06-14 syoussefi@google.com Use VK_NULL_HANDLE instead of DE_NULL for shader modules If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ic0003b401a111632c37842ed6aada442b6681a91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5659496 Commit-Queue: Cody Northrop <cnorthrop@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Liza Burakova 3e997419 2024-06-25T18:41:03 Add format conversions for WebGPU formats. This CL adds a Format class, as well as a generator script to generate methods to map between WebGPU and ANGLE formats. Fallback mappings are listed but this CL only implements support for required webgpu formats. Bug: angleproject:344814096 Change-Id: I2588a57353eafc4e87f40df3bbe3f9375e5ed8c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5598178 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 0bf157f1 2024-06-26T07:44:43 Tests: Update expectations for new deqp test name Test was split into a bunch of subtests, have to stop checking for exact string match. Added wildcard to compensate. Bug: angleproject:349569335 Change-Id: I0787208db0823d7ac1547cc03e04cd6bfed944ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5659336 Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Geoff Lang 85e2e6a9 2024-05-08T12:31:37 WebGPU: Add Window and Pbuffer surfaces. Bug: angleproject:342213844 Change-Id: I58465bdf895b4bab63ec3c74e326c6be4827bf60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5525974 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll cd9f457f 2024-06-26T11:42:02 Roll vulkan-deps from 2e4ed1cfe73c to d2e24d980359 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2e4ed1cfe73c..d2e24d980359 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0c15a28c94bf83a6814b31d15551437f5fc5fd42..fa9c3deb49e035a8abcabe366f26aac010f6cbfb https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/413b7630fa6005667c83133ee7475e14309d1d93..00c49e3b56cc9748228d2e5b0d1e8e9c4409a02f https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/b9d8114695de81ae3ea6f93e391156a2f5c13f4c..64d37e2811a794f614bc569338afa47dbdfefa0e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/db0d129d43bda308328f91b15a5409161fbd50b7..05f36c032ef20676eff121a8c8d5e6e33796ec8b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3f71525a25c48d6df1fc3478393a3c36c3ad3704..df3e018436e38c2536d5b79e1e662e6323b6fbe2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:349326004 Tbr: cnorthrop@google.com Change-Id: Ibb59d8088c76629c89431fa11cfa71309bee1e3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5656361 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7d45aac9 2024-06-26T10:01:30 Roll SwiftShader from f65e518550a8 to a0ec371d8331 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/f65e518550a8..a0ec371d8331 2024-06-25 dloehr@google.com Change enum values in to avoid implicit bitfield conversion If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I2f2e90581488f5892c7532b9a8a3796bc9f77cb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5657423 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bdce308b 2024-06-26T07:00:35 Roll Chromium from 9df67ea3cc71 to 44cf5c690e8b (618 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9df67ea3cc71..44cf5c690e8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7c265ec08d..31c1a4bbff * testing: https://chromium.googlesource.com/chromium/src/testing/+log/97cc34952f..b4630be7ae * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/ca4cddf94a..5fff3e91aa * third_party/android_build_tools/manifest_merger: 8yUA9fKPOvtc2p3lVEA3l885a1V4-CXZuKt6xAbdR4AC..dqr3Fhw6TQYW7lV6aRiySbcHsEuAiFeTuoUZHdkdK08C * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/334a3acddb..0d470211d6 * third_party/kotlin_stdlib: _4e0lDaCjMgaNeq2v2olJs_15Ax3PxGfCU9fMt0FTKcC..L8N8abd00VyqdzTL4hXOWqSHvY0R7i7ti3TLrfbPZ8gC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e432200a79..8b7eff801b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/c0781f84b8..754a06d129 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a4d21c3cc1..fa08dd50e4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/72cbb0874b..c25f77b1e4 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ic0a2eeb220638d0a64bb5963f61e75d15ab89af7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5656358 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 04632734 2024-06-20T17:23:27 Add EGL query option for minor version * Added the following: * EGL_CONTEXT_MINOR_VERSION * Added since EGL 1.5 * EGL_CONTEXT_MAJOR_VERSION * Another alias for EGL_CONTEXT_CLIENT_VERSION. * Added unit tests to query major and minor versions. Bug: angleproject:349179609 Change-Id: I99989c0f9f6659995caf9d7987551b97d477f22f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5648675 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi df7bda5c 2024-06-21T13:27:08 Disable MSRTSS if not supported for RGBA * Support for MSRTSS is checked for RGBA8 and RGBA8_SRGB during renderer initialization. * In the case of lack of support, this feature is disabled. * preferMSRTSSFlagByDefault is disabled if MSRTSS is not supported at all. Bug: angleproject:348181798 Change-Id: If1bf27f53a61f4fd67576c426ab07f4e2304fbe9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5647495 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 8b1daa18 2024-06-24T14:22:22 Vulkan: Fix MSRTT failure from undef addnl format In TextureVk::initImage(), for formats that do not have an SRGB equivalent, such as some D/S formats, additionalViewFormat becomes VK_FORMAT_UNDEFINED. For those textures, FormatSupportsUsage() returns false for MSRTSS, which leads to an error in some test cases. * Added the condition that, to determine MSRTSS support, additional format is ignored if it is undefined. * Unsuppressed affected tests that should now be fixed. Bug: angleproject:348181798 Change-Id: I739b630ac7d0230e2506f6f13b8cb9b3b50d175f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5651860 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Amirali Abdolrashidi 0c5b327a 2024-06-18T13:48:06 Extend advanced blend tests to cover core and KHR * Added AdvancedBlendTestES32. * (AdvancedBlendTest will now use ES 3.1 with the KHR extension.) * Currently disabled on Intel (Windows and Linux) * (ES 3.2 is expected to include advanced blend equations.) Bug: angleproject:42262258 Change-Id: I691786c2b54ae6c1efa02299667978ddbc526819 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5640674 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Geoff Lang 0ccc018e 2024-06-20T10:20:08 Reland GL: Avoid calling glBindFragDatalocationIndexed on Qualcomm Track if the output location and index came from a layout qualifier or from a call to glBindFragDataLocation[Indexed] and only call glBindFragDataLocationIndexed in the latter case. Re-binding a location that was already specified in the shader is not allowed. Qualcomm can fail when trying to bind locations using the API when the output variable is an array or uses a non-zero index. Only call glBindFragDataLocationIndexed when the user specifically uses it to avoid failed links when all outputs should be implcitly assigned. Assign the ProgramOutput::pod::index field when doing output assignment to mirror how the location is assigned. Bug: angleproject:42267082 Change-Id: I72cdb73dd4c5edea4ad1229ca75c0c7926344d1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5645123 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Matthew Denton 7ca9f46a 2024-06-21T13:09:24 ESSL -> WGSL: Emit func calls, struct access, constants Also includes constructor calls, swizzles, and a slightly incorrect version of the ternary operator. The ternary operator doesn't exist in WGSL, only a non-short-circuiting select() builtin. For now the ternary is implemented with select() but that isn't correct if any of the true/false expressions have side effects, and may have perf implications by computing both true/false expressions. Constants are mostly done after this, however NaN and infinity are not valid constants in WGSL and it's unclear what we can do about this as WGPU implementations are allowed to assume NaNs and infinities are never operated on. Bug: angleproject:42267100 Change-Id: Ie6190091a7b95d3d372736ab7cea45868846e7be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5648990 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
ericali 016ef60d 2024-06-24T17:41:30 ValidateAST asserts when refers to builtIn struct type name Refers to build in type name looks allowed by GL but currently VK and Metal backends do not support, i.e.: refers to gl_DepthRangeParameters, this change is to add temporary check to make using reserved type name an error during parsing. Bug: angleproject:348313398 Change-Id: I6522566b1f590fe2b24534fb065625c4ac3b06c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5645265 Auto-Submit: Erica Li <lerica@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll 228f56b8 2024-06-25T10:56:14 Roll SwiftShader from de870ac7518f to f65e518550a8 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/de870ac7518f..f65e518550a8 2024-06-25 swiftshader.regress@gmail.com Regres: Update test lists @ de870ac7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I4ae8b43c8f8857b1a06165311da44c01ef3683ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5653203 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 84f88f00 2024-06-25T10:01:28 Roll vulkan-deps from bf2b4e8ba30e to 2e4ed1cfe73c (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bf2b4e8ba30e..2e4ed1cfe73c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2d8b71fc63578a93726c05e0565c3ef064bdc1ba..0c15a28c94bf83a6814b31d15551437f5fc5fd42 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/0cfe9e7219148716dfd30b37f4d21753f098707a..b9d8114695de81ae3ea6f93e391156a2f5c13f4c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/1b07de9a3a174b853833f7f87a824f20604266b9..60fe7d0c153dc07325a8fb45310723a1767db811 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/31118feba2ff2b941732447782b593921e9feae8..3f71525a25c48d6df1fc3478393a3c36c3ad3704 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I538913900f5ace4d2d05a1f62c0c3fd637fa6c0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5651530 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d9af2423 2024-06-25T07:00:09 Roll Chromium from dd0b2a0bee86 to 9df67ea3cc71 (513 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dd0b2a0bee86..9df67ea3cc71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1694f9d0a6..7c265ec08d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/18953942fc..94d7b86a83 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b1cced90c3..97cc34952f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/10a44f1971..022cd349fe * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6daca50597..334a3acddb * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/cf5c38d48a..09b99fd8ab * third_party/r8: Ys8FrDOeYEWWIfFn2jZG265nllx9kg5M3EfMKsEWNMgC..M8rc1oybTkWXWpoImSQ8gAwv6mdEyvAPnQNs6Dus_28C * third_party/turbine: s6-zuFNzLDZOl_FmPkk2_LENOqUKjkYmpqR9l0SDo94C..xWEBZuFKl1Dvw_zOpabeMkGVYlEllIxK06D-RoC6wUsC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e511a81f53..c0781f84b8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cfc973827f..a4d21c3cc1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c54f05d036..7c0882a310 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7c2f8255f4..72cbb0874b No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I117bacbbeb7943b4aefdb20ed3dec4a146b6aa4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5651486 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu dd25e193 2024-06-14T12:14:52 Add a texture copy test that does multiple layer copies Add a test that does multi-layer copy between a 2D array texture and a 3D texture of different formats. Bug: b/347306270 Change-Id: I972ae83f568450c27295a565af13f8e6d2332f66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5634376 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya beb75984 2024-06-21T17:33:51 Fix incorrect verification for SimultaneousUploadAndDraw MultithreadingTestES3.SimultaneousUploadAndDraw was verifying its results incorrectly, resulting in incorrect failures. Bug: angleproject:8341 Change-Id: Ie9268391c7b65a904a05c428c13be1041e8a7383 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5647496 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov e095c06f 2024-06-24T17:51:54 Suppress end2end MultisampledRenderToTexture* failures Started on Pixel 6 AP1A.240405.002 after https://chromium-review.googlesource.com/c/angle/angle/+/5644215 MultisampledRenderToTextureES31Test.DrawCopyThenBlendAllAttachmentsMixed MultisampledRenderToTextureES3Test.DepthStencilAttachment MultisampledRenderToTextureES3Test.DepthStencilClearThenDraw MultisampledRenderToTextureES3Test.DrawCopyDrawAttachDepthStencilClearThenDraw Bug: angleproject:348181798 Change-Id: I4290e7ea0ba2352feed538c02d798e612d7fd616 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5651062 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 6bfd7d13 2024-06-24T17:41:48 Manual roll vulkan-deps from c0c0899c3614 to bf2b4e8ba30e (5 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/c0c0899c3614..bf2b4e8ba30e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/23f9647de9282dd330e7df6dc025261ccaec1712..31118feba2ff2b941732447782b593921e9feae8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: Iba6f7f13e7239eca92e059d7219675664a35075f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5650184 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 15b95b4a 2024-06-24T13:21:50 Skip WebGL2UniformBufferTest.LargeArrayOfStructs Times out on Mac NVIDIA GL. Bug: chromium:346561003 Change-Id: If2eb106024a2c693c57f0ea351f981fc73d0af82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5646492 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 5e64ccf9 2024-06-24T10:01:51 Roll SwiftShader from cea33ab2d5ad to de870ac7518f (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/cea33ab2d5ad..de870ac7518f 2024-06-21 syoussefi@google.com Fix dynamic_rendering_local_read vs graphics_pipeline_library If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:42267038 Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ie9277eac3757c663d7161cf39406889adc940197 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5649376 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 45b67e05 2024-06-24T10:01:46 Roll vulkan-deps from 30f8ac1a3f18 to c0c0899c3614 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/30f8ac1a3f18..c0c0899c3614 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a8a23d26337016c57834f11bfc6a9a2d9448cd76..23f9647de9282dd330e7df6dc025261ccaec1712 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I5b319f5c239d838a423953dfc380d5d44caddd9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5650208 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0c7331df 2024-06-24T07:27:16 Roll Chromium from 998b94d44e82 to dd0b2a0bee86 (601 revisions) https://chromium.googlesource.com/chromium/src.git/+log/998b94d44e82..dd0b2a0bee86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ea08c530e2..1694f9d0a6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9cbb06d35a..18953942fc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b2b3b6279a..b1cced90c3 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1edbffbd91..41e22814bc * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/f80bca53c2..7083198328 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2ec885f2d7..10a44f1971 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/06673958a3..6daca50597 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0b65ee742f..cf5c38d48a * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/100fb18f5d..bac941ca44 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c8f1d81998..dcc1ffafb5 * third_party/r8: b6LOeoejVVl33nNxOZkFmGfefs7kz9TiV017cm-2h-UC..Ys8FrDOeYEWWIfFn2jZG265nllx9kg5M3EfMKsEWNMgC * third_party/siso/cipd: git_revision:5da337f40aeac8d9f65b89e335b519291356d3d5..git_revision:b45592fde7d08bdee282d3d2d0cf4faa55588885 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d7c8d9867e..cfc973827f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/20e5aa2909..c54f05d036 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a7c5eb1791..7c2f8255f4 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ia56776c59c844922f11fc32a366ea143fee28a87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5650349 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 3c472b45 2024-06-20T13:17:32 Vulkan: Fail if texture bound to MSRTT w/o support * If a texture is already bound to an MSRTT framebuffer, but MSRTSS is not supported by the driver for that format, it leads to failure. Bug: angleproject:348181798 Change-Id: I685ca552b9c53b06f33065ba594d81cfa7b25b4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5644215 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Mohan Maiya 6f33eddc 2024-06-20T18:05:49 Vulkan: Bugfix in FindSupportedFormat Account for vendors that do not support any image fallback formats Bug: angleproject:42261363 Change-Id: I2a6b1a724e52d9fa75444ff154986b49de612d32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5646126 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 48969c95 2024-05-31T16:34:07 GL: Implement QCOM_tiled_rendering Bug: angleproject:343900918 Change-Id: I01612e11795d7aa8ee20f6e9bd5ef62fe40e2910 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588630 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 3be15cb0 2024-06-21T13:52:20 GL: Limit uniform block size to 64KB This change works around an inefficiency in ANGLE when the uniform block has a large size. That will be fixed in a follow up, but in the meantime this clamping makes ANGLE more uniform on different vendors (most of which expose this limit as 64KB already). This also aligns with the strategy adopted by the Vulkan backend. Bug: angleproject:346561003 Change-Id: Id23a1f1bbbc1c7224c432d5bee1c4989ff2c92b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5645627 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 12028222 2024-06-20T00:00:00 Metal: Clear visibility result buffer before use Ensured that the current visibility pool buffer does not contain previous results if it was used before. Fixed: angleproject:348206830 Change-Id: I8dbc36626ef8267d5466c96405dac0da2754cb6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5643453 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang e3c8d57b 2024-06-21T11:55:21 GL: Fix glClearTexImage for LUMA textures We need to transform the format and type before handing it off to the driver for emulated texture formats. Bug: angleproject:347047859 Change-Id: Ifa2c92179a49fbd8ae152a365c2915091102e4e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5645626 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 3f572905 2024-06-19T17:46:38 Add basic begin/end support for perf counters The AMD_performance_monitor extension has explicit begin/end calls to capture counters. This was not implemented in ANGLE and the tests were relying on ANGLE always capturing counters (incurring a small overhead). This change does not complete the implementation of that extension, but does add basic support for starting and stopping perf counter measurements. While inactive, most counters are not updated. Bug: angleproject:42267038 Change-Id: I3ff6448b22ca247c217401cb2d76ef4142c9d759 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5639343 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 29f9a8c6 2024-06-21T09:55:58 Roll Chromium from e9b6b20cee41 to 998b94d44e82 (1373 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e9b6b20cee41..998b94d44e82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/00b3ce0aad..ea08c530e2 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/7817c353d0..9cbb06d35a * buildtools/reclient: re_client_version:0.143.0.518e369-gomaip..re_client_version:0.148.0.41b09b51-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7521f3b99c..b2b3b6279a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/06aa1dc684..d88164a565 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1a0040059f..2ec885f2d7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/66df2a3ec7..06673958a3 * third_party/fuchsia-sdk/sdk: version:21.20240613.1.1..version:21.20240620.2.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/3be02c8f02..0b65ee742f * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/472d9aad97..100fb18f5d * third_party/ninja: version:2@1.11.1.chromium.1..version:2@1.11.1.chromium.2 * third_party/r8: 2QksVhXOjZcs9S9ykH1cjssi-oJvf0xS8-t299KukjwC..b6LOeoejVVl33nNxOZkFmGfefs7kz9TiV017cm-2h-UC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/887bb57a1b..e432200a79 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/3f6a5d2414..e511a81f53 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4336d0b16d..d7c8d9867e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/553093afa4..20e5aa2909 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b835a09cd9..a7c5eb1791 Clang version changed llvmorg-19-init-10646-g084e2b53:llvmorg-19-init-14561-gecea8371 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/4336d0b16d1bd1bfa26fac1a679c3872fa109d7e..d7c8d9867e74840d13ce47106a16607f1863ec09/scripts/update.py Bug: angleproject:5038 Tbr: ynovikov@google.com Change-Id: I223265063dc4a906104acb65c3356c26da74de2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5647489 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 95d6e347 2024-06-21T10:01:42 Roll vulkan-deps from 83e9eca04a1b to 30f8ac1a3f18 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/83e9eca04a1b..30f8ac1a3f18 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/68a17eb72182d3dcfac834eed3512ea205eac9d1..2d8b71fc63578a93726c05e0565c3ef064bdc1ba https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/581279dedd59d8353322fc2d61be07ccdcad0f13..0cfe9e7219148716dfd30b37f4d21753f098707a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3fb31803aa89b9f2df2f9dee9f36a7d0f7ab54bc..a8a23d26337016c57834f11bfc6a9a2d9448cd76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I4ad1baecda278d1bacc702c2f2c1b8239eec7642 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5647490 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi e53b3ad7 2024-06-17T15:23:55 Vulkan: Extend coherent adv blend to emulated path * blendEquationAdvancedCoherentKHR is now also enabled if the following features are enabled to emulate ABE: * emulateAdvancedBlendEquations * supportsShaderFramebufferFetch * Relevant tests: *GLES31.functional.blend_equation_advanced.coherent* * On some Android devices: From "Not supported" to "Passed" Bug: angleproject:42262258 Change-Id: I4d97438df774f0752b9f30c5807cb3cc20ede076 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5631144 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi a1dea207 2024-06-13T11:40:39 Implement KHR_blend_equation_advanced_coherent * Updated the validation for glBlendBarrier() and ~KHR(). * GL state now includes mBlendAdvancedCoherent. * Updated glEnable() to accept GL_BLEND_ADVANCED_COHERENT_KHR. * It can be queried via glGetIntegerv(), etc. * EXTENDED_DIRTY_BIT_BLEND_ADVANCED_COHERENT added. * Added a corresponding bit to ExternalContextState. * If coherence is supported, there should be no need to use blend barriers, as, based on the spec, the advanced blend ops should then follow order like the basic blend ops. * Relevant tests: *GLES31.functional.blend_equation_advanced.coherent* * On Linux/NVIDIA: From "Not supported" to "Passed" Bug: angleproject:42262258 Change-Id: I7e0e43bdc71524eec111c2d3b024fe73c9795e55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5634381 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Amirali Abdolrashidi 05801537 2024-06-13T13:35:05 Vulkan: Add feature for coherent blend advanced op This change will add features that will be used in the follow-up CL. * Added the following feature to the Vulkan backend: * supports_blend_operation_advanced_coherent * Added the following feature to the renderer: * mBlendOperationAdvancedFeatures * It will be used to query advancedBlendCoherentOperations from the physical device. Bug: angleproject:42262258 Change-Id: I2949002d053700e89d92358d6e7c80c714ea36ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5634380 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 0b888d50 2024-06-13T11:32:53 Add KHR_blend_equation_advanced_coherent * Added this extension to registry_xml.py. Bug: angleproject:42262258 Change-Id: I2d69982b9ec876e3c21346039ed78aa21b1a1896 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5634379 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi e3087128 2024-06-19T17:44:52 Tighten FixedVector access asserts FixedVector has a size(), the out-of-bounds check is made tighter to make sure elements beyond size() (but still within the static array) are not accessed. Bug: angleproject:42267038 Change-Id: I46decb4262207bd7f1446e257e7196768345a4fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5639342 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
donghwan.yu 54c48177 2023-04-29T23:12:30 GCC: Define MemoryAllocInfoMapKey's hash before using in unordered_map GCC complains that std::hash specialization for MemoryAllocInfoMapKey type should be positioned before it is used in std::unordered_map. Bug: chromium:40565911 Change-Id: Ia3dd2a699431720b030839d94ea796894ba8b822 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5642294 Auto-Submit: DongHwan Yu <donghwan.yu@lge.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 0d6869c2 2024-06-20T10:01:49 Roll vulkan-deps from 37a9cc2d9a06 to 83e9eca04a1b (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/37a9cc2d9a06..83e9eca04a1b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/80a1aed219af368c348d27a8084c7e58867c80c5..581279dedd59d8353322fc2d61be07ccdcad0f13 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/66a8c4ededc03a83bce8f733feb72755f980b408..3fb31803aa89b9f2df2f9dee9f36a7d0f7ab54bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I3345817014e8b0686f5fb92699dab4d8f8c9aaa6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5644089 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 800ca8d3 2024-06-19T21:04:11 Revert "GL: Avoid calling glBindFragDatalocationIndexed on Qualcomm" This reverts commit e768aed37e77dfcba0fe8ec7027348ade2069c85. Reason for revert: Breaks WebGL tests. Original change's description: > GL: Avoid calling glBindFragDatalocationIndexed on Qualcomm > > Track if the output location and index came from a layout qualifier > or from a call to glBindFragDataLocation[Indexed] and only call > glBindFragDataLocationIndexed in the latter case. Re-binding a > location that was already specified in the shader is not allowed. > > Qualcomm fails to bind any location that is not specified with a > layout qualifier. Skip tests that do this behaviour and log warnings > that the driver is unable to handle this case. > > Assign the ProgramOutput::pod::index field when doing output assignment > to mirror how the location is assigned. > > Bug: angleproject:42267082 > Change-Id: Icdf83bb93f63a6375b5a6062690e53905c9ffe71 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5415796 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Bug: angleproject:42267082 Change-Id: Ifb866878aa6489b809ba6db4152ea5942274dc45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5641895 Commit-Queue: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 92148c2c 2024-06-17T11:13:46 GL: Implement GL_EXT_clear_texture. This extension is useful because it allows clearing textures without changing the framebuffer. Chrome uses this on Android when it's available. Bug: angleproject:347047859 Change-Id: I765d9991c4549b3655446d9f51847d1095792dbd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5631810 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 1160fda7 2024-06-17T15:27:28 GL: Re-enable sRGB and BGRA8 extensions GL_EXT_sRGB_write_control and GL_EXT_texture_format_BGRA8888 were disabled on all of Android as a workaround for Nexus5X driver bugs. Scope the disablement to Qualcomm only. Bug: angleproject:347724909 Change-Id: I99d55ee12a98c1b46613be4aa92e92a0e576a82b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5637249 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll b9916688 2024-06-19T10:01:07 Roll vulkan-deps from f2b13f01a465 to 37a9cc2d9a06 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f2b13f01a465..37a9cc2d9a06 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/7bf2d0275e480852abfccc5ff9a4cabd388286b2..80a1aed219af368c348d27a8084c7e58867c80c5 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/8f034f6b48fd2d30f711396a021e1dc050c8941c..e3c37e6e184a232e10b01dff5a065ce48c047f88 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/cc5924774ed906518a65e5e2d3fcb4a527032cb2..66a8c4ededc03a83bce8f733feb72755f980b408 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I042361e74fc233bc3a6dfb1dff3630816c0a4eb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5642224 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 37b2487b 2024-05-03T09:55:04 Add LunarG api dump layer to ANGLE vulkan back-end Bug: angleproject:8623 Change-Id: Ia4dbd5915c5fe918cd65e09b468e0b8d094522f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5601070 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 1917377f 2024-06-07T17:02:33 Capture/Replay: Write comments to the capture Useful for tracking why things are happening in the frame, from the perspective of the tracer. Allows for entries like this: // DEBUG: AttachShader called, checking for IDs; glAttachShader(gShaderProgramMap2[6943], gShaderProgramMap2[1531]); // DEBUG: AttachShader called, checking for IDs; glAttachShader(gShaderProgramMap2[6943], gShaderProgramMap2[1511]); Good for debugging or knowing we've skipped invalid/unsupported calls. This CL includes one use of comments to mark calls we've skipped, meaning the app or ANGLE submitted them, but omitted from capture. Bug: angleproject:345851268 Change-Id: Ied917c7480704afc3fdfb8cbb617b323eb7403a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233876 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Roman Lavrov aeff80f1 2024-06-17T18:42:43 Android perf tests: add ATrace counters for trace loops TraceLoopFrameTimeAvgUs: frame time averaged over last loop, in us. Traced after each full loop is finished. TraceStage: tracking trace stage 0 (implicit) - before app and warmup starts 1 - initial warmup 2 - extended warmup for short traces 3 - running a trial 0 - trial finished (exit if single trial, or back to 3 if another trial) Intended for use with perfetto tracing, needs this in ftrace_config: atrace_apps: "com.android.angle.test:test_process" Useful for looking for correlations with other events, such as gpu frequency changes. Bug: b/319871513 Change-Id: I4bc273b7c7b3a6ee4d3a137b39a3b54fa7dd723e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5637158 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Matthew Denton a04239d8 2024-06-18T11:38:52 ESSL -> WGSL: Emit most types and function params This emits struct declarations, as well as array/matrix/vec types. As a result this also emits function parameters. Bug: angleproject:42267100 Change-Id: Ib9c7e543fd38f7c1dfa64d8e63b054fc5111b336 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5598298 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0