kc3-lang/angle/PRESUBMIT.py
Branch :
Log
| Author | Commit | Date | CI | Message |
|---|---|---|---|---|
 |
4210e49b | 2019-10-10 14:22:03 | Correct presubmit error for missing Bug ID Having a Bug ID is not enough to silence this error, the Bug ID must be on the line directly above the Change ID line to prevent getting this error. Bug: angleproject:3992 Change-Id: I90ec1169efb77c1be6a1004e579f16e89115be50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1853604 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> | |
 |
cc4d8331 | 2019-09-11 17:26:00 | Reland "Add export_targets.py to presubmit" This is a reland of c40a21f353a2d0a37e83f3dce3a1c3096574be64 Changes: Fixed presubmit failing on Windows due to being unable to find gn, fixed export_targets.py failing on Windows for Googlers due to being unable to find Visual Studio files. Original change's description: > Add export_targets.py to presubmit > > Adds export_targets.py to run as part of presubmit in order to help > prevent breaking Firefox with BUILD.gn changes. > > Bug: chromium:1003151 > Change-Id: I5a7ab00891cd7c094c797e6150f642f803a726b6 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1802038 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1003151 Change-Id: I321ade86f2d969601afb8e1ed61c36bf166887b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1842127 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
 |
a4242146 | 2019-10-04 18:57:25 | Revert "Add export_targets.py to presubmit" This reverts commit c40a21f353a2d0a37e83f3dce3a1c3096574be64. Reason for revert: Seems to be failing locally on Windows. See bug for more info. Original change's description: > Add export_targets.py to presubmit > > Adds export_targets.py to run as part of presubmit in order to help > prevent breaking Firefox with BUILD.gn changes. > > Bug: chromium:1003151 > Change-Id: I5a7ab00891cd7c094c797e6150f642f803a726b6 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1802038 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> TBR=ynovikov@chromium.org,bsheedy@chromium.org,jgilbert@mozilla.com,jmadill@chromium.org Change-Id: Ic9a2eb58d847a40349e64b931c369f07c24b799c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1003151 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1841877 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
c40a21f3 | 2019-09-11 17:26:00 | Add export_targets.py to presubmit Adds export_targets.py to run as part of presubmit in order to help prevent breaking Firefox with BUILD.gn changes. Bug: chromium:1003151 Change-Id: I5a7ab00891cd7c094c797e6150f642f803a726b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1802038 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> | |
|
2538f6b4 | 2019-07-12 14:23:11 | Revert "PRESUBMIT.py: Don't require "Bug:" for autoroller CLs." This reverts commit 9be098b52fbb59322ee83fd77b3c64442d742822. Reason for revert: Fixed in the auto-rollers. They should now include Bug: tags. Original change's description: > PRESUBMIT.py: Don't require "Bug:" for autoroller CLs. > > BUG=angleproject:3659 > > Change-Id: I29d77939953e3661ea979f8f7a9f44566079e567 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1692881 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=geofflang@chromium.org,cwallez@chromium.org,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:3659 Change-Id: I01a2e82c24918c831a6c444360620d261ec892dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1700141 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
 |
9be098b5 | 2019-07-09 12:00:48 | PRESUBMIT.py: Don't require "Bug:" for autoroller CLs. BUG=angleproject:3659 Change-Id: I29d77939953e3661ea979f8f7a9f44566079e567 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1692881 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
9e438eeb | 2019-07-05 08:44:23 | Update presubmit checks. - clarifies error for run_code_generation hashes. - makes missing format or bug tag an error. - check for spaces in bug tags. Bug: angleproject:3659 Change-Id: I069e60d8acdf070961bdf342acf976ddd1138b1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1689019 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
 |
d7d42395 | 2019-05-06 13:15:35 | Format all of ANGLE's python code. BUG=angleproject:3421 Change-Id: I1d7282ac513c046de5d8ed87f7789290780d30a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1595440 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> | |
|
04e9e559 | 2019-04-01 14:40:21 | Use revision.h for glslang dirty checks. This file changes a lot less than git HEAD. And it should guard against the same changes. Should reduce the instances of developer confusion regarding run_code_generation being out of data. Also update the presubmit check to print a more helpful message in the case where the code does need to be regenerated. Bug: angleproject:3333 Change-Id: I190dab5be50fc42512bdfc11c2d200f34f3b2092 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545123 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> | |
|
73397e8e | 2019-01-09 10:33:16 | Add presubmit check for GN headers and code formatting. These two checks are lifted directly from the Chromium code base. Also adds a presubmit check for a patch description. Also adds some checks to the "on commit" function so "git cl presubmit" can work. Also reformats the style of the presubmit script a bit to match the patterns in the Chromium presubmit. Bug: angleproject:2626 Bug: angleproject:3054 Change-Id: Iff29b8856cf9eb9531e893cd0b0d80c0834b7676 Reviewed-on: https://chromium-review.googlesource.com/c/1403255 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
 |
98a3550b | 2019-01-08 22:09:39 | Add a presubmit step to make sure autogenerated code is up-to-date While here, added a presubmit test for the Bug: tag too. Bug: angleproject:3046 Change-Id: I7030685230b4ce4bfc435c14ef85324e16b76274 Reviewed-on: https://chromium-review.googlesource.com/c/1402061 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> |