kc3-lang/angle

Log

Author Commit Date CI Message
Roman Lavrov 0951686d 2022-08-17T14:28:01 Add .vpython .vpython3 to trigger all tests on changes there. Bug: chromium:1346781 Bug: angleproject:7576 Change-Id: Ic238a95c68cefb5f83b6a8db2ab009ef94ea80c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835165 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Brian Sheedy 24012abc 2022-08-17T18:06:13 Revert "Copy .vpython3 from chromium/src/+/main:.vpython3" This reverts commit 3b91270fbbf40ad49dca56d440962149da03750c. Reason for revert: Seems to break things. Original change's description: > Copy .vpython3 from chromium/src/+/main:.vpython3 > > (except for verify_pep425_tag which doesn't look like something we > want) > > As Jamie noted on https://crrev.com/c/2408717 it can't be easily > auto-rolled from the Chromium src/ repo > > Swarming switched to vpython3 and can't be hacked back easily > (https://crbug.com/1346781#c24) so it's probably a good time to just > go for this and figure out what is missing or broken (if anything) > > Bug: chromium:1346781 > Bug: angleproject:7576 > Change-Id: Icf574084b036570412e5c6df2b1f9d19ae35d079 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835164 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1346781 Bug: angleproject:7576 Change-Id: Ie5ba7090f4bcbc8f9fd8ec2d80057b371810c403 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835334 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Roman Lavrov 3b91270f 2022-08-17T12:37:09 Copy .vpython3 from chromium/src/+/main:.vpython3 (except for verify_pep425_tag which doesn't look like something we want) As Jamie noted on https://crrev.com/c/2408717 it can't be easily auto-rolled from the Chromium src/ repo Swarming switched to vpython3 and can't be hacked back easily (https://crbug.com/1346781#c24) so it's probably a good time to just go for this and figure out what is missing or broken (if anything) Bug: chromium:1346781 Bug: angleproject:7576 Change-Id: Icf574084b036570412e5c6df2b1f9d19ae35d079 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835164 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 6a8bd801 2022-08-17T11:18:31 Add process_angle_perf_results.py to perf tests data. analyze step doesn't currently trigger angle_perftests on changes to process_angle_perf_results.py Example: https://crrev.com/c/3835162/2 https://ci.chromium.org/ui/p/angle/builders/try/linux-test/7791/overview (so I had to https://crrev.com/c/3835162/3) Bug: chromium:1346781 Change-Id: Id991facedd48036a5c072d910aeb8488712516f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835163 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 92e4cd75 2022-08-17T10:01:27 Roll SwiftShader from c61fc9aec162 to 5ac9bd16c803 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/c61fc9aec162..5ac9bd16c803 2022-08-17 swiftshader.regress@gmail.com Regres: Update test lists @ a6c3e363 2022-08-16 sugoi@google.com Update Marl to 2f129cf1b 2022-08-16 sugoi@google.com update-marl: run Gerrit hook on generated CLs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If8613966bb3c427e29898cfda4fb315ac9eea5cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3834831 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 213a1ee6 2022-08-16T12:44:35 Vulkan: Enable VK_EXT_primitives_generated_query Added a test to make sure PGQ works with indirect draws too. Bug: angleproject:5430 Change-Id: Ic91e11906ca34c4f9a50f3442709e544f7f6744c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3826165 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Solti a216cfe8 2022-08-08T21:05:00 Adding angle_perftests test case names in logcat Overview: In logcat, we want to know which test is being executed. The CL 1. makes *ANGLEPerfTest* print the test name 2. wire the trace names in *TracePerfTest* as test names to *ANGLEPerfTest* Local Test: ==== Test 1 ==== - use this build args: http://go/paste/5111738277036032 - ```autoninja -C out/Android && ./out/Android/angle_perftests --gtest_filter="*angry_birds*" --verbose``` - Wait for the test to complete, then run ```adb logcat -d | grep running``` - 4 tests were executed: ``` solti@solti:~/angle$ adb logcat -d | grep running 08-11 18:13:49.757 7690 7721 I ANGLE : running test: TracePerf_Run/vulkan_angry_birds_2_1500 08-11 18:13:59.914 7690 7721 I ANGLE : running test: TracePerf_Run/native_angry_birds_2_1500 08-11 18:14:21.265 7690 7721 I ANGLE : running test: TracePerf_Run/vulkan_angry_birds_2_launch 08-11 18:14:48.030 7690 7721 I ANGLE : running test: TracePerf_Run/native_angry_birds_2_launch 08-11 18:14:58.296 1525 1525 E JobScheduler.Quota: <0>com.google.android.apps.docs has 0 EJ quota without running anything 08-11 18:14:58.296 1525 1525 E JobScheduler.Quota: <0>com.google.android.apps.docs has 0 EJ quota without running anything 08-11 18:14:58.297 1525 1635 E JobScheduler.Quota: <0>com.google.android.apps.docs has 0 EJ quota without running anything solti@solti:~/angle$ ``` ==== Test 2 ==== - follow http://docs/document/d/1W3E7e-YcR5noim_poM0f7Dc0W8AdQDbJ2tFSPXgjpH0? resourcekey=0-VmGDLI3x0q4-sdpQ0n8GSA - setup out/AndroidPerformance - run cmd: ./out/AndroidPerformance/angle_perftests --gtest_filter="*angry_birds*" --verbose --local-output --verbose-output --shard-timeout 100000 --max-steps-performed 1 - then, run cmd: ```adb logcat -d | grep running``` - confirmed the test names are printed ``` solti@solti:~/angle$ adb logcat -d | grep running 08-11 18:22:50.698 8496 8525 I ANGLE : running test: TracePerf_Run/vulkan_angry_birds_2_1500 08-11 18:22:51.599 8496 8525 I ANGLE : running test: TracePerf_Run/native_angry_birds_2_1500 08-11 18:22:51.917 8496 8525 I ANGLE : running test: TracePerf_Run/vulkan_angry_birds_2_launch 08-11 18:22:52.362 8496 8525 I ANGLE : running test: TracePerf_Run/native_angry_birds_2_launch solti@solti:~/angle$ ``` ==== Test 3 ==== - build a Linux build, using the args: http://go/paste/5953043785842688 - run the same test with cmd: xvfb-run ./out/Debug/angle_perftests --gtest_filter="*angry_birds*" --verbose | grep "running test" - confirmed the message is printed: http://go/paste/5800151735074816 Bug: angleproject:6353 Change-Id: I6118a75f54b1648923cb5fe541633d7dd52b20bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3817409 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov 7c66d77d 2022-08-16T15:06:29 Avoid logging None introduced in https://crrev.com/c/3831885 Currently prints: Test 5/97: DrawCallPerfBenchmark.Run/gles_null_uniform: None Wasn't printing anything before, so this CL goes back to that. Bug: angleproject:7299 Change-Id: I8270129958a93e5c3fbb6cac321fe7e2396a6376 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3834068 Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
Roman Lavrov c5efd2b5 2022-08-15T16:20:25 Improve Ctrl-c handling. 1. Restore original handlers after subprocess terminates. Otherwise the installed handlers persist and will swallow sigint outside of subprocess invocations. 2. Raise KeyboardInterrupt when subprocesses terminate to interrupt the script itself. run_perf_tests.py allows for some subprocess failures (--max-errors, with non-zero default). This results in ctrl-c interrupting subprocesses but the script just marks the test as FAIL and keeps running. Bug: angleproject:7299 Change-Id: I2917008baa389491c7591596fc14ee139fa6417e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3831887 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi e79c9cd6 2022-03-30T23:06:54 Vulkan: Use VK_EXT_primitive_topology_list_restart From ANGLE's point of view, there is nothing to do with this extension other than enable a feature that silences a validation error. Bug: angleproject:3832 Change-Id: I094343d09c322e2848a65a5bc775d0f21388fb46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3562380 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com>
Solti 428b6788 2022-08-15T17:54:27 Update CHROMIUM_copy_texture.txt to match the code [Overview] The internal format list in the code mismatches the one in the spec txt. see the link below for the missing formats in the spec txt: - http://screen/vDkHo3MFXpE3eQF.png Therefore the CL is matching the spec txt to the code. [Test] CQ DRY RUN completed and passed Bug: angleproject:4228 Change-Id: Ib66fb00b65ce2164779ca7649ec0652910a8e467 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3830892 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6ee6fac9 2022-08-16T15:02:26 Roll SwiftShader from a6c3e363b7a9 to c61fc9aec162 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/a6c3e363b7a9..c61fc9aec162 2022-08-16 syoussefi@google.com Implement VK_EXT_primitive_topology_list_restart If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I474d18909df96de1936c77411f9d33d237b0f74a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3834265 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 8878366f 2022-08-15T11:51:00 Refactor to reduce main loop complexity. Bug: angleproject:7299 Change-Id: I157e84b7a6718d59eecb00471d4ec7ae5b3317cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3831885 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Nicolas Capens ad6513fe 2022-08-16T16:06:19 Unconditionally enable EGL_ANGLE_iosurface_client_buffer on macOS EGL_ANGLE_iosurface_client_buffer does not depend on VK_EXT_external_memory_host. Locked IOSurface memory gets copied to/from staging images instead of being imported as device visible host memory. Bug: chromium:1352481 Change-Id: I904e6af53e169ef04446181de91db6f3cdc31530 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3826164 Auto-Submit: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 19eb658f 2022-08-09T10:56:15 Reland "Infra: Enable Skia Gold tests on Pixel 6" Reverted due to timeouts https://crrev.com/c/3594112 which shouldn't be happening now. Bug: angleproject:7216 Change-Id: I9a4b0f9d8e315a103dbdbe3f5e3e7219ae4815d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3819844 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0f5770de 2022-08-16T07:01:26 Roll Chromium from 16d8164e92a5 to 754ede9fc072 (380 revisions) https://chromium.googlesource.com/chromium/src.git/+log/16d8164e92a5..754ede9fc072 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/89cc6c63d9..8bf02cb228 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/98014eb61a..431d9c2d82 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6cc58d640c..5df82514bc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/95324abbb0..dbe2ab9dc9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b3421074fa * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/647cfe6bf1..268d645853 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d2890e490f..752991ad1e No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ib8adeb3e811f7aa7a937973fcae3a4aac9d9388c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3833276 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 2089943b 2022-08-13T21:48:33 Tests: Add Lumino City trace Test: angle_perftests --gtest_filter="*lumino_city*" Bug: angleproject:7571 Change-Id: I206b965712b8f833874069bbcec0c93fc7ee5087 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3829135 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Peng Huang b9fd47b8 2022-08-12T10:55:49 Not use Android TLS slot for chromium In the profile, GetGlobalContext() & GetValidGlobalContext() have extra overhead for checking angle::gUseAndroidOpenGLTlsSlot. Since angle::gUseAndroidOpenGLTlsSlot is always false for now, so add a build flag to disable it for chromium build. In the profile, with angle_use_android_tls_slot = false, GetValidGlobalContext() is reduced from 0.153% to 0.044%. Bug: chromium:1336126 Change-Id: Id5e1752b0a03289fb299e8de2ed6e962e35291c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827955 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 64c652d7 2022-08-12T18:14:39 Use stdout instead of (default) stderr in logging.StreamHandler Currently logging output appears before stdout on bots, makes logs so confusing as subprocess logs get out of order with logs from python. Using StreamHandler(stdout) seems to be the common practice in other python scripts in code search. Note: subprocess's stderr is redirected to stdout: https://crsrc.org/c/third_party/angle/src/tests/py_utils/angle_test_util.py;drc=2de8bb42a9ef93dfafe476e7dc81643285fa7ef1;l=92 Bug: angleproject:7299 Change-Id: I825f16d9c479f33a280d8fdbafb8297cda0c18b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827957 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 72f03f79 2022-08-15T10:01:27 Roll SwiftShader from 2438c1b18a5e to a6c3e363b7a9 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/2438c1b18a5e..a6c3e363b7a9 2022-08-12 capn@google.com Regres: Roll dEQP to main revision eaf78cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I928855b305f0ad58652c4890aeac0cfb4db3f456 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827679 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 042fda3c 2022-08-15T09:19:13 Roll Chromium from f904dc881cb8 to 16d8164e92a5 (630 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f904dc881cb8..16d8164e92a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/36b3854b7e..89cc6c63d9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/47ec3a84c6..98014eb61a * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9f503bebdb..6cc58d640c * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/a097a1ada6..030b4ebf32 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4802c02064..95324abbb0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6dbdca4bea * third_party/fuchsia-sdk/sdk: version:9.20220811.2.1..version:9.20220812.1.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/37eadcf61d..cca1e66cd5 * third_party/r8: DZRgtLW0NflugdN9UMc7OsJqux69vI-6BxCNcTJaRTwC..lAcTGSK3VDSH4DI3H3q0XIg8y0wBVz7IS1Fk_Zbd3iYC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7fbcd9170e..d2890e490f No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I402f97b2e23a8ae6390358676cd7dcf3255dd5ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3831161 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Faye Zhang 4c941149 2022-08-12T11:42:07 External Texture Support In MEC Bug: angleproject:4964 Change-Id: I5cfbadf515a30fb20d75b2d745fdecdafa12268f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812378 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Faye Zhang <ffz@google.com> Commit-Queue: Faye Zhang <ffz@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi 02d79c32 2022-08-12T11:21:04 Skip kotor trace on Swiftshader due to flakiness After changing the driver uniforms to push constants, the kotor trace became flaky on Linux/Swiftshader. In this CL, the flaky test is skipped. Bug: angleproject:7565 Change-Id: Ia3deb1344ce2dfb8cec443d197b0f95788a12599 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3829907 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Peng Huang 44791792 2022-08-12T00:13:45 Use angle::FlatUnorderedSet for ImageSibling::mSourcesOf As my test with Chromium on Android, ImageSibling::mSourcesOf only contains one item, so change it to angle::FlatUnorderedSet with default size 2. Bug: chromium:1336126 Change-Id: Ie1ba3ebb195170ad5c9f4713b599a91de5052702 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3828444 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4cdabfb1 2022-08-12T17:15:39 Roll VK-GL-CTS from eaf78cbfdaed to 5a93cd60f33b (4 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/eaf78cbfdaed..5a93cd60f33b 2022-08-12 ziga@lunarg.com Add tests making sure dynamic states are not overwritten 2022-08-12 rgarcia@igalia.com Test interaction of image_view_min_lod, robustness2 and gather 2022-08-12 piotr.byszewski@mobica.com Interaction between FDM and imageless framebuffer 2022-08-11 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,geofflang@google.com Change-Id: I58dcd6e603d2ea8cbd1e6fff9eb39f7d41fabba0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3829728 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peng Huang a9fac249 2022-08-12T07:01:42 Use FixedVector for Framebuffer::mDirtyColorAttachmentBindings Bug: chromium:1336126 Change-Id: Ie997af106de09468c8520187190a857db099dff9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3829144 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org>
Shahbaz Youssefi 67e0c6fc 2022-08-11T22:10:36 PRESUBMIT: Remove unnecessary escape of forward slash Bug: angleproject:7279 Change-Id: Icf9482fb83c60640d5af6380674b9d857aa9ff0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3828443 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 1ca94448 2022-08-12T10:01:03 Roll SwiftShader from 708ca9579181 to 2438c1b18a5e (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/708ca9579181..2438c1b18a5e 2022-08-11 capn@google.com Ignore feature structs of partially promoted extensions 2022-08-11 capn@google.com Don't expose VK_EXT_external_memory_host on macOS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7538 Tbr: geofflang@google.com Change-Id: I0939eca4928df293c655a8e56808266f0d97312b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827648 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 002b9544 2022-08-12T07:54:47 Roll Chromium from e4653aba963d to f904dc881cb8 (487 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e4653aba963d..f904dc881cb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9497cae3d0..36b3854b7e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/11459ac227..47ec3a84c6 * buildtools/linux64: git_revision:c8c63300ac8ecb66d8126af5407257209ae59044..git_revision:0bcd37bd2b83f1a9ee17088037ebdfe6eab6d31a * buildtools/mac: git_revision:c8c63300ac8ecb66d8126af5407257209ae59044..git_revision:0bcd37bd2b83f1a9ee17088037ebdfe6eab6d31a * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/55e0c49d14..9f503bebdb * buildtools/win: git_revision:c8c63300ac8ecb66d8126af5407257209ae59044..git_revision:0bcd37bd2b83f1a9ee17088037ebdfe6eab6d31a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6250261533..4802c02064 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b2cd6477b9 * third_party/fuchsia-sdk/sdk: version:9.20220810.1.1..version:9.20220811.2.1 * third_party/r8: YywdNQUrAK_HHH829t_MPLvTyjmQW-dWAsB7k-8gpNkC..DZRgtLW0NflugdN9UMc7OsJqux69vI-6BxCNcTJaRTwC * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/7d9556cfda..e5f1a8a766 * tools/skia_goldctl/linux: 9fyLI7UE2vwgyQweLyqyh193CzDMxbUr0xRuqtcCLAgC..ebDbf3X2jdAICDlXMXUr7yp4muhSvYoREDLdZZoJzuAC * tools/skia_goldctl/mac_amd64: Gd1BbosIHwOaX5zOlcEpL3_dE4fNnH3ZavJaYPSbIaEC..yE_XL6pbQ8M0WuI236ObRlkSxu0XMdWs_AnUeo21wa8C * tools/skia_goldctl/mac_arm64: xjfviFgm_MjrBG13x_JywIF9-wkn8wCyBm7yZVx-V10C..l46gUmkc-2-OsEMo-oEbpXiBAYg48KtXbtF1lyBh0u8C * tools/skia_goldctl/win: rV5hj2Xykfze-wY9ozIelEOoVLxjUV7rPUMxnRrlh80C..58nNno6pNLLSJaZknYmuijuo5gy2tfRBKNI1iCldDlcC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ia3761305f18225d92685073e031fabf127a59829 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3828537 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peng Huang afdd5106 2022-08-11T21:14:23 Use angle::FlatUnorderedMap in Display.cpp Bug: chromium:1336126 Change-Id: I57d97d37749de2abbba88b6558bde31fa8346764 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3828442 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Eddie Hatfield 2ebd5100 2022-08-11T10:43:32 Add gl::Context as a parameter to Shader::resolveCompile This prepares us to access the Context's shader cache in resolveCompile in the next commit. Bug: angleproject:7036 Change-Id: I7995c54b290a5a48f0c8985cb56ea0048598ab2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827642 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang 61a17ba9 2022-08-11T11:23:10 Use angle::FlatUnorderedSet for ImageState::targets In mose cases, chrome only needs 1 or 2 targets for an EGLImage, so using angle::FlatUnorderedSet with 2 default size instead of the std::set for targets. Bug: chromium:1336126 Change-Id: Ieff3cfbd5d020fda3aaecb162ddb354def14d962 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827681 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kyle Piddington 58392791 2022-04-07T16:14:12 Translator: Fix crashes with monomorphizing loops Monomorphize functions crashes when trying to deep-copy a while loop, and a continue statement. Null check these values before performing a copy, as this is still valid AST syntax. Bug: angleproject:7190 Change-Id: I822c0aa062ed844f86aa2b603899d73cbd48255e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3573079 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Charlie Lao 4c6f7d8e 2022-08-10T15:21:57 Vulkan: Never stage update for EGLImage EGLImage could be shared between contexts in different share groups. If we stage any update in the ImageHelper for such EGLImage, then you may run into threading bugs when two textures are trying to flush out the staged update at the same time. There is no evidence showing we are running into this issue, but this CL forces this requirement. Bug: b/169868803 Change-Id: Ie26542225705ee4638ca1b3cf3cc5af499685137 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824159 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Rafael Cintron c9360ccb 2022-08-10T16:05:49 Reflect TextureD3D label updates with storage object When developers change a label with the KHR_debug extension, TextureD3D calls TextureStorage::onLabelUpdate. However, onLableUpdate was still using the out of date member variable (mTextureLabel) that was set in the constructor. This change adds a setLabel method to the TextureStorage class which properly updates the texture label member variable. Calls to onLabelUpdate now retrieve the most up-to-date label. This change also renames TextureStorage::mTextureLabel to mKHRDebugLabel to make it more clear which label was being stored. Bug: angleproject:7569 Change-Id: I6bc65c35dfb2237b5da88a6ed0e2d872a14857ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3825357 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Chris Dalton 4a636cdd 2022-07-20T22:44:30 Require all PLS formats to consume exactly 4 bytes of storage D3D 11.0 UAVs only support R32_FLOAT, R32_UINT, R32_SINT formats. EXT_shader_pixel_local_storage explicitly states that all PLS variables consume exactly 4 bytes. ESSL images can only have both read and write access if their format is r32f, r32i, r32ui. (We were able to circumvent this via aliasing, but it was a huge source of bugs.) There is a large precedent for only supporting 4 bytes of storage in the capabilities we use for PLS, so this CL removes support for all PLS storage formats that are not 4 bytes. It also implements an "R32" mode for PLS, that does manual packing and unpacking of r32* image formats. If the application wants larger formats, it can always define multiple PLS planes and piece them together. Next up we ought to be able to support rg16* types with more packing/unpacking. With aliasing gone, and with a bit of tweaking, the PLS tests now pass on the Pixel 4 GLES bot. Bug: angleproject:7279 Bug: angleproject:7388 Bug: angleproject:7524 Bug: angleproject:7527 Change-Id: I6b8f62c2428ade6cb5413e33360d734e55dda0eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782579 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Charlie Lao badfeecd 2022-08-10T14:38:43 Vulkan: Destroy fb1 should not affect fb2 with same attachments If two FBOs has the same attachments. they will share the same VkFramebuffers. Destroy one fbo should not cause trouble for the other fbo. Bug: chromium:1351170 Change-Id: I032da8cc12eb8556c3e325c8fd7a3de9974ae909 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824302 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Chris Dalton fa3d7d5c 2022-08-05T00:57:40 Make PLS coherent on Vulkan Uses the VK_EXT_fragment_shader_interlock extension to make the shader image implementation of PLS coherent on Vulkan. This extension is supported on AMD, Apple, NVIDIA, and Intel. Bug: angleproject:7279 Change-Id: Ic0253eb20932eb6be0b1f433ba454e48b57be2f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3813816 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kyle Piddington aef9603f 2022-08-02T18:30:08 Separate Struct declarations earlier Metal translator backend asserts with compound struct definitions. Move SeparateCompoundStructDeclarations before SeparateCompoundExpressions. This change does revert some changes for angleproject:6386, but the tests fixed there continue to pass. Bug: angleproject:6489 Change-Id: I6adc606ac0b14453eb5e3e90f6501bf02c2d2768 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3806616 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Gregg Tavares <gman@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Shahbaz Youssefi 47d2df0e 2022-08-10T15:15:18 Presubmit: Verify ANGLE_SH_VERSION update ... when ShaderLang.h or ShaderVars.h change. Bug: angleproject:7279 Change-Id: I01f6035ad41a4d92cc9e5d1e509731bb2ff29047 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3823619 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang 4cab7f38 2022-08-10T20:33:07 Fix EGL_ANGLE_program_cache_control for eglCreateContext EGL_CONTEXT_PROGRAM_BINARY_CACHE_ENABLED_ANGLE is an attribute for creating EGL context, but ANGLE reads it from mAttributeMap which is not the attribs passed to eglCreateContext(). Bug: chromium:1336126 Change-Id: Id3ea1955f927a7e051285c79b590dcf1f11f22ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3823621 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 87ed2c9d 2022-08-11T11:19:17 TestSuiteTest: Generate more unique result file names. Speculative fix for flaky runs of TestSuiteTest. Flakes appear to read the results of other tests suggesting rand is not unique enough to protect against tests generating the same results file. Bug: chromium:1352134 Change-Id: Icadf64c557e23e6d87fd18aa60aa48373ecec9fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827144 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 26bb1d6e 2022-08-11T10:01:49 Roll vulkan-deps from c728ed48ce2f to d53c356ad7d9 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c728ed48ce2f..d53c356ad7d9 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0ebcdc4d19..0a43a84e02 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6ace8025bb..529a4320d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Id58daaaf51e79b6c3e43618ce4bd13961f56f19d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824173 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 58b4dbd8 2022-08-11T10:01:45 Roll SwiftShader from aafa10869568 to 708ca9579181 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/aafa10869568..708ca9579181 2022-08-11 capn@google.com Eliminate unscale constants 2022-08-11 nicolas.capens@gmail.com Make maskAny() SIMD width agnostic. 2022-08-11 capn@google.com Support constructing a SIMD constant from a lambda expression 2022-08-10 capn@google.com Fix printing SIMD::Pointer offsets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia6527a5f182e3d46322bc7e6872d885bcebdb10e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3825163 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6c953069 2022-08-11T08:49:49 Roll Chromium from d830698e47ae to e4653aba963d (476 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d830698e47ae..e4653aba963d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/93068bfb00..9497cae3d0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b11e87a879..11459ac227 * buildtools/linux64: git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044 * buildtools/mac: git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/fe1bc75a46..55e0c49d14 * buildtools/win: git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2988eb6ecf..6250261533 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f35edd63ba..d22f28635a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..268569634e * third_party/fuchsia-sdk/sdk: version:9.20220809.1.1..version:9.20220810.1.1 * third_party/r8: ncOWcGcIDVi8ufTgdNYbCX5-V_uiCMJ1doSNFemyu1wC..YywdNQUrAK_HHH829t_MPLvTyjmQW-dWAsB7k-8gpNkC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d42a2d064a..7fbcd9170e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0d9f47b867..ca2df581e4 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I15f973628babf7efc3fbc2aaec8b2db522ccde2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824172 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 3d0faa02 2022-08-09T16:48:06 Remove workaround affecting --list-tests --gtest_filter=X. One of the multiple workarounds added in https://crrev.com/c/3062240. It makes `--list-tests --gtest_filter=X` behave as if it was just `--list-tests`. Not sure why this was necessary, bots appear to work without it?.. Could be something that changed since that CL? Bug: angleproject:7508 Change-Id: I9988add40ddf3168e00cea2739e5a9209f633161 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3821374 Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 876da4ae 2022-08-09T22:30:24 Vulkan: Query support for VK_KHR_imageless_framebuffer In preparation for using it. Bug: angleproject:7553 Change-Id: I579af8ce2c0dd1d58bf750ee494e06a071b798fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3823620 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi f7d4c614 2022-03-30T23:33:27 Vulkan: Use VK_EXT_primitives_generated_query This Vulkan extension implements OpenGL's primitives generated query. The heavy lifting in ANGLE's implementation was done when this query was emulated with pipeline statistics query. This change simply switches pipeline statistics query usage to this dedicated query when available. Bug: angleproject:5430 Change-Id: I5d2c7d64e4627bcbd33d428d6a7c836b1129e5fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3813815 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov 6d0452b7 2022-08-10T13:34:29 Fix ANGLE_HAS_HISTOGRAMS following crrev.com/c/3817602 Bug: angleproject:7299 Change-Id: I1d6f97e61dfdbea04009cc08a17344a59e438e51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3823618 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Chris Dalton 7c6a5459 2022-08-10T10:09:18 Rename ShFragmentSynchronizationType::None -> NoSynchronization Use a less generic name. X11.h contains: #define None 0L /* universal null resource or null atom */ Bug: angleproject:7279 Change-Id: I7d245b9f771211dea151bfc12363a03374264ac4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824717 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 493b5aff 2022-08-09T14:57:24 Vulkan: Workaround ARM bug with stencil write mask Bug: angleproject:7556 Change-Id: I0aa17c178071cc15d8ee15f700b0c4932819c72a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3821367 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov dc82ff15 2022-08-08T16:06:13 Add config angle_maybe_has_histograms to angle_perftests_common. ANGLE_HAS_HISTOGRAMS wasn't consistently defined in compilation targets. I was working on a prototype and ran into crashes due to an inline function in TestSuite (where this class is used) getting invalid offsets in some cases due to this :-O Shabi: """ angle_source_set makes something the equivalent of a temporary .a, so objects are not recompiled for every target that links to it """ Also change ANGLE_HAS_HISTOGRAMS to =1 or =0 as Yuly suggested so that we can check if it's defined in the header to avoid inconsistency. Bug: angleproject:7299 Change-Id: I907184a6ca2bc673f5bffc473b584d78625a11c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3817602 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 17df2fd3 2022-08-10T10:01:49 Roll vulkan-deps from fe14e7954b25 to c728ed48ce2f (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/fe14e7954b25..c728ed48ce2f Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/a725d8fad1..61c603f3ba * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f20e8d05f5..0ebcdc4d19 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/becf07286e..6ace8025bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia63b311a356cbfdebe330da7b7e6e69b55e889b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3821648 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 408c5a56 2022-08-09T09:07:41 Mark FormatPrintTest as potentially uninstantiated. Vulkan is not an available backend on iOS. Bug: angleproject:5417 Change-Id: I92afff13bc10a1b6a3faa51a1620fd250972cab0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3819902 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org>
angle-autoroll ee093838 2022-08-10T09:09:49 Roll Chromium from 6306836d087b to d830698e47ae (506 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6306836d087b..d830698e47ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/91cf468257..93068bfb00 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c38cbd4028..a097a1ada6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3da59a3d51..2988eb6ecf * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..743fa6c597 * third_party/fuchsia-sdk/sdk: version:9.20220808.3.1..version:9.20220809.1.1 * third_party/r8: zwDsb_S9yBEwDeg6obeP11vhi8U_Hg82v-Fsv-90ifMC..ncOWcGcIDVi8ufTgdNYbCX5-V_uiCMJ1doSNFemyu1wC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7995d10b85..d42a2d064a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4819558a6e..0d9f47b867 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I331747dc891d29acdacbe0296c2f6173767b4ffd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3821647 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 2c351351 2022-08-07T22:31:40 Vulkan: Don't break render pass on read-only buffer updates When uploading to a buffer that is in use by the GPU, we either acquire a new buffer and copy the contents over, or stage the update and do a GPU copy. Ignoring all other conditions, this decision was made based on whether a small or large part of the buffer is being updated; small updates where staged. However, if the current render pass uses the buffer in read-only mode, the staged update would break it (to apply the update). In this change, this situation is detected and the acquire-and-update path is chosen even for small updates. Bug: angleproject:7534 Change-Id: Ie2c0989449dcc7d03695a003cf6f353920f8fb65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812566 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1bb3685d 2022-08-10T00:35:43 Roll SwiftShader from 678ffefb1b3b to aafa10869568 (9 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/678ffefb1b3b..aafa10869568 2022-08-09 capn@google.com Disable AddressSanitizer JIT instrumentation support on Windows 2022-08-05 sugoi@google.com Temporarily allow unsupported structures in PhysicalDevice::getFeatures2() 2022-08-05 sugoi@google.com Workaround for dEQP-VK.info.device_mandatory_features failure 2022-08-05 sugoi@google.com Workaround vkGetPhysicalDeviceProperties2() issue 2022-08-04 sugoi@google.com Update Vulkan headers to version 1.3.224 2022-08-04 sugoi@google.com Fix VulkanWrapper compilation 2022-08-02 capn@google.com Support AddressSanitizer instrumentation of LLVM JIT routines 2022-08-02 capn@google.com Strip only the leading underscore from Mach-O symbols 2022-08-02 swiftshader.regress@gmail.com Regres: Update test lists @ 678ffefb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com,nicolascapens@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,nicolascapens@google.com Change-Id: Ia6d4f981a19988bd9dbc390075ed673751013171 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3821356 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 8050079c 2022-08-08T16:35:10 Vulkan: Remove basicGLLineRasterization * Removed basicGLLineRasterization from the ANGLE features. * Removed "viewport" from the extended driver uniform classes. Bug: angleproject:2830 Bug: angleproject:7558 Change-Id: I289b1e2b536a6bd0c1ab24844835221e617a296d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3818165 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Greg Thompson 52719c9f 2022-08-05T14:23:24 [fuchsia] Migrate angle_end2end_tests to component framework v2. Bug: chromium:1256503 Change-Id: I28d76dfa721fd6a65e029833050140c487e8006d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812043 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Juan Muraira <jpmuraira@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org>
angle-autoroll d8c6a235 2022-08-09T10:51:49 Roll vulkan-deps from 4b211a6a98e6 to fe14e7954b25 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4b211a6a98e6..fe14e7954b25 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/0cccd0a65a..a725d8fad1 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b362d2b7d4..f20e8d05f5 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/eb7156a963..becf07286e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I376fd01e4a96c7a97f061a71474744a5b369008c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3818496 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 97b16799 2022-08-09T07:44:49 Roll Chromium from 199441d23d93 to 6306836d087b (461 revisions) https://chromium.googlesource.com/chromium/src.git/+log/199441d23d93..6306836d087b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b1868b3db9..91cf468257 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/416d16f002..b11e87a879 * buildtools/linux64: git_revision:c8c63300ac8ecb66d8126af5407257209ae59044..git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee * buildtools/mac: git_revision:c8c63300ac8ecb66d8126af5407257209ae59044..git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/75bbec9f6d..fe1bc75a46 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/47974e9376..c38cbd4028 * buildtools/win: git_revision:c8c63300ac8ecb66d8126af5407257209ae59044..git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9598217953..3da59a3d51 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4755386202 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2cd48234f1..647cfe6bf1 * third_party/fuchsia-sdk/sdk: version:9.20220806.1.1..version:9.20220808.3.1 * third_party/r8: IBW3UYermEa3GRA8TK8U8l7zQEPKBCQOt8d4K4QAHtsC..zwDsb_S9yBEwDeg6obeP11vhi8U_Hg82v-Fsv-90ifMC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/27842bf472..4819558a6e No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ia87f9cfcd941b0016c2299cc4a6681f64d3cd878 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3819073 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 6f80f0f0 2022-08-06T02:29:19 Translator: Clean up the compile flag passing interface Historically, compile flags were sent to the translator as a bitmask. Recently, we were getting close to running out of bits. Additionally, direct-to-metal work had started to introduce constants to be passed to the translator, which were misplaced in ShBuiltInResources and Caps. Recent work on Pixel Local Storage adds even more constants, aggravating the situation. In this change, the interface to passing compile flags is reworked. A struct is passed (instead of a bitmask) that has one bit for each flag. This can be indefinitely extended. Additionally, the constants needed by metal and PLS are also placed in this struct. In turn, the backends can set these options directly, and don't have to hack them into Caps to further get hacked into ShBuiltInResources. Bug: angleproject:7559 Change-Id: If93f1e1b8818ad3a0ac708ab04ab93b4b397d114 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812562 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 8474a95e 2022-08-05T22:15:04 Translator: Don't validate structs on non-root nodes Struct validation needs to know about structs that may have been defined outside the scope of the node, so this validation (similar to variable and function call validation) is disabled when validation a subtree of the AST. Bug: angleproject:7531 Bug: b/239207278 Change-Id: Id6dcee041a40f09f0c36a9ef3bfc238433b69c58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812047 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Amirali Abdolrashidi 7fe0694c 2022-07-14T16:42:30 Vulkan: Use push constants for driver uniforms * Updated the driver uniforms so they would be defined as push constants in SPIR-V. Their data would be updated via pushConstants() when handling the driver uniform dirty bits. * Updated TOutputVulkanGLSL to be able to generate the push constants as required. * When handling the driver uniform dirty bits, we no longer allocate a buffer. * Removed the driver uniform descriptor set from the pipeline layout. * Removed the binding-related functions and flags for the driver uniforms. * In invalidateGraphicsDescriptorSet(), DIRTY_BIT_DESCRIPTOR_SETS is used instead of DIRTY_BIT_DRIVER_UNIFORMS_BINDING. (Same for invalidateComputeDescriptorSet()) * DIRTY_BIT_DRIVER_UNIFORMS_BINDING is replaced with DIRTY_BIT_DRIVER_UNIFORMS in other places. * Removed mDriverUniform and DriverUniformsDescriptorSet from ContextVk. * Added mSupportedVulkanShaderStageMask to RendererVk, which is used in creating the pipeline layout and updating the push constants. * Added a TODO note for driverUniformsDescriptorSetIndex. Bug: angleproject:6858 Change-Id: I91037d378528962a816b12ff3f21249ee17b7652 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782570 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Chris Dalton c554b92b 2022-08-08T10:08:33 Apply memory qualifier decorations in SPIR-V Bug: angleproject:7279 Change-Id: I9390261aa572fe4b39152a6f7bdd2b100b34f616 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3818162 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 2cf9b1d6 2022-08-05T10:25:27 Encapsulate prevTexture pointer in a class * Encapsulated mPrevUploadedMutableTexture from ShareGroupVk into the new TextureUpload class. Bug: chromium:1346808 Change-Id: Ied52071d4e7f624fc2c497c4086b2589b840561d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3813032 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Peng Huang 52b18311 2022-08-08T07:51:21 Use angle::HashSet to replace std::set in Display.h The std::set uses heap allocation for each item, so change it to angle::HashSet for ContextSet, SurfaceSet, ThreadSet, ImageSet, StreamSet, SyncSet and EglDisplaySet. angle::HashSet is a flat set, all items are in one memory allocation. It should has better performance for small size set container. Ideally, it is better to use angle::FlatUnorderedSet which doesn't need heap allocation at all in most cases. However FlatUnorderedSet doesn't support common std container methods. So we can only use angle::HashSet for now. Maybe improve angle::FlatUnorderedSet in follow CLs. Bug: chromium:1336126 Change-Id: I18b3afd8722d222183c88f876b792c1af23bc195 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3816401 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi f5de8e01 2022-08-05T10:23:37 Vulkan: Disable texture upload if texture sharing * Disabled mutable texture upload in cases of display-level texture sharing. Bug: chromium:1346808 Change-Id: Ia54496521d151ca7f273845fb40c56b5322470af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812386 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott 5b7b7f9b 2022-08-04T12:18:12 Document how to roll VMA for ANGLE This CL contains learnings from a recent roll of which Chromium-local version of VMA is used for ANGLE, and how it rolls into Android. Bug: b/238213234 Change-Id: I50b98e984e68ee0f2ff06fc24847d4a4a2c8fb1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3811861 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
angle-autoroll aaf293c8 2022-08-08T15:15:25 Roll VK-GL-CTS from 0170b4a25e36 to eaf78cbfdaed (4 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/0170b4a25e36..eaf78cbfdaed 2022-08-05 ziga@lunarg.com Test dynamic rendering with no framebuffer attachments 2022-08-05 Piotr.Sobczak@amd.com Add another alternative to reflect() precision tests 2022-08-04 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main 2022-07-29 ari.suonpaa@siru.fi Add tests for non-uniform interpolant indexing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,geofflang@google.com Change-Id: I400bb037e3c715fa8e170152aa3b06531f219b34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3817282 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 2de8bb42 2022-08-03T18:15:52 Converge run wrappers into angle_test_util.RunTestSuite Bug: angleproject:7299 Change-Id: Ifa882028a6f49579b4a9c6893053cb3bee8d83fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3808302 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Peng Huang a2ad517f 2022-08-06T07:54:16 Replace std::vector with angle::FixedVector in FramebufferState. Using std::vector causes heap allocation for all new framebuffers, so change it to angle::FixedVector. Bug: chromium:1336126 Change-Id: I2e059324d14d59ba2a42b2bb4cd5c569a439a87a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812563 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org>
angle-autoroll 22b90986 2022-08-08T10:01:49 Roll vulkan-deps from fa6a3bcb6169 to 4b211a6a98e6 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/fa6a3bcb6169..4b211a6a98e6 Changed dependencies: * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/2b55157592..c896e2f920 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/07851b8a0c..eb7156a963 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ibc453754ab6d223be4c3c3521712cdb8b6f7606e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3816125 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bf395582 2022-08-08T07:01:49 Roll Chromium from 5dde4351e359 to 199441d23d93 (45 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5dde4351e359..199441d23d93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/792b1bcdcb..416d16f002 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a5da9d82f5..75bbec9f6d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6194595a2d..9598217953 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1c7fc8f4bd * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5b099b5d2e..7995d10b85 No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I36d10ae99826ab21bdc2e4c75e9cd264b5e08882 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3815505 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peng Huang 6491396c 2022-08-06T19:49:37 Use angle::FlatUnorderedMap as storage for AttributMap AttributeMap was using std::map which allocates storage from heap it is not ideal for small map like attribute map. So replace it with angle::FlatUnorderedMap with 2 default size (Chromium creates a lot of gl fence with 2 attributes on Android). Bug: chromium:1336126 Change-Id: I129fe603df2fd475ae1b0e35b63d4d0171bbae09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812565 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ae0bb741 2022-08-08T02:49:55 Roll Chromium from 2bf3e35d7a4c to 5dde4351e359 (604 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2bf3e35d7a4c..5dde4351e359 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/664331e40d..b1868b3db9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/56cc5bc223..792b1bcdcb * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e3598c2dc0..a5da9d82f5 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c5d3129a8b..47974e9376 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/230a11a4ba..6194595a2d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/00e6aabbe3..f35edd63ba * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/fabdc7fefb..0a09f6037a * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/de32b18623..04b33506bf * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1c7fc8f4bd * third_party/fuchsia-sdk/sdk: version:9.20220804.2.1..version:9.20220806.1.1 * third_party/r8: MQolCMavu5-KSAcEH_GUHAmKTQ1g5ydGaNBmKfh7czkC..IBW3UYermEa3GRA8TK8U8l7zQEPKBCQOt8d4K4QAHtsC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5a9c565608..22963c3e1f * tools/skia_goldctl/linux: 0NA1CyaNhIxt00SqtGFZVHJ-K7ioB4L6a5rT4MzyQ48C..9fyLI7UE2vwgyQweLyqyh193CzDMxbUr0xRuqtcCLAgC * tools/skia_goldctl/mac_amd64: FWI4Q_ogCO1xBJ0xpOqci1On1AsY-RHqGDYlvqf3AiQC..Gd1BbosIHwOaX5zOlcEpL3_dE4fNnH3ZavJaYPSbIaEC * tools/skia_goldctl/mac_arm64: 3dJEBjpviigMA6es0-th0SJsyrnw5_4wTMyBddvEByUC..xjfviFgm_MjrBG13x_JywIF9-wkn8wCyBm7yZVx-V10C * tools/skia_goldctl/win: TwW8GVww_8ATYlTEN2pHq5xuXkLqTN5mrqFZjRWD2GgC..rV5hj2Xykfze-wY9ozIelEOoVLxjUV7rPUMxnRrlh80C Clang version changed llvmorg-16-init-572-gdde41c6c:llvmorg-16-init-907-g8b740747 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/5a9c56560805e8c5b47d3db88a2233a38fb04c05..22963c3e1fef533ed62e382ebd41318248b7de34/scripts/update.py Bug: angleproject:7559 Tbr: jmadill@google.com,syoussefi@google.com Change-Id: Ibb6383b160d47c65fbe2919de4baa7ca2e28d7ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3814907 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peng Huang 6b248a68 2022-08-06T10:20:41 Use angle::FastVector in ImageEGL::initialize to avoid heap allocation Bug: chromium:1336126 Change-Id: I40349c618b648f3a96c19b2f2b032275af90086b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812564 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang 0c8c4ca0 2022-08-02T19:53:55 Remove not used mImageLastUseFences in ImageVk Bug: chromium:1349118 Change-Id: I6db245198ae2ebdbb73add47f522583f0a50e217 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3806559 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang 0d5ba4dc 2022-08-05T19:43:54 Minor performance improvement Use angle::FixedVector to replace std::vector in SyncEGL::initialize() Use std::move() to avoid copy in Display::destroyInvalidEglObjects Bug: chromium:1336126 Change-Id: If4c13babb14ed9995caf3c3dd3cfc362124b24cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812561 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 928c5016 2022-08-04T12:28:12 Vulkan: Fix garbage collection vs outside-RP-only flush In https://chromium-review.googlesource.com/c/angle/angle/+/3379231, an optimization was implemented such that the excessive recorded texture uploads would get flushed early and submitted. This caused a use-after-free bug in the following situation: * Draw with pipeline A * Delete A <--- this puts A in the Context garbage list * Upload a lot of data At this point, the flush threshold could pass and the commands recorded outside of the render pass up to this point would be submitted. Associated with this submission was the current garbage, including pipeline A. However, the render pass that uses pipeline A is still not submitted. Now if after some time the render pass is still open, but the "completed commands" are checked (another set of uploads causing another submission, a query status check, etc), the garbage can be cleaned up. When the render pass closes next and is submitted, the implementation attempts to use the pipeline, which is already deleted. In this change, outside-render-pass-only submissions no longer reference the current garbage. This has the side effect that the temporary buffers used for uploading texture data won't be released early. A future optimization may want to separate the garbage list in ContextVk to render pass and outside render pass garbage. Bug: chromium:1337538 Change-Id: I4d31edc53916785d44420f4d6b4b2578ca3996e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812555 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi d5308602 2022-08-05T15:46:29 Test for ARM bug with dynamic stencil write mask Bug: b/240755039 Change-Id: If7025f3b2450735a099da3cc11524f778f2ac654 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812559 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 146329b8 2022-08-05T15:51:18 run_perf_tests: Allow passing flags to the test. Bug: None Change-Id: I0260bafd91d371d653248ea278b80bd579a12a5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812560 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov 9e3e2032 2022-08-05T15:22:09 Add a note about "internal swarming failure" Bug: chromium:1350556 Change-Id: I5967c51f6dc3bf03736a41dfd29135eb5d5973c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812558 Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Faye Zhang 123bd542 2022-08-04T12:56:28 Add Variable Initialization in Base Instance Tests Bug: angleproject:7547 Change-Id: Ic01b933fb1e0291b42c48a6b5bf2ed3bd9267c0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3811873 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Faye Zhang <ffz@google.com>
angle-autoroll a46fdafd 2022-08-05T10:01:06 Roll vulkan-deps from 3a443029375b to fa6a3bcb6169 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3a443029375b..fa6a3bcb6169 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/08c542d344..b362d2b7d4 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/d4801c93c5..a0ab2f162e * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8ac3b50e9d..497f232680 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3a10ae8223..07851b8a0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I9dc6a9a4e238c57790296c9a606f0f212049bcb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3813019 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll dbfab159 2022-08-05T07:01:13 Roll Chromium from d7560fcbdf63 to 2bf3e35d7a4c (416 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d7560fcbdf63..2bf3e35d7a4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0ad6539347..664331e40d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/915a8eb0cc..230a11a4ba * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..dcdf418945 * third_party/fuchsia-sdk/sdk: version:9.20220803.3.1..version:9.20220804.2.1 * third_party/r8: 8RiUzjctgueOdfuqGNeXwdR_7AGlMwPM9A01M3uKD88C..MQolCMavu5-KSAcEH_GUHAmKTQ1g5ydGaNBmKfh7czkC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ba74bc78cc..5a9c565608 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/41d69d665a..7d9556cfda No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I5dd7397aa3b7c21ef7a28142340cc32781939b06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3813017 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jonah Ryan-Davis de5c6c79 2022-08-03T13:56:11 Remove unused ANGLE histograms This CL removes the following histograms: GPU.ANGLE.D3DCompileMS GPU.ANGLE.DisplayInitializeMS GPU.ANGLE.ProgramCache.CacheResult GPU.ANGLE.ProgramCache.LoadBinarySuccess GPU.ANGLE.ProgramCache.ProgramBinarySizeBytes Bug: chromium:1317194 Change-Id: Iad01cff591df83c015bc79fe4e7b7c094357f02a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3807767 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 6f158ca0 2022-08-04T10:01:06 Roll vulkan-deps from 3ee9789f25ed to 3a443029375b (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3ee9789f25ed..3a443029375b Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/fb64704060..adf7bf0113 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/54cd5e1963..08c542d344 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/ff92049ebd..2b55157592 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/aa7ee26f15..3a10ae8223 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ifbdf940f660ad5363810dee490ddb49b67b790c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3810052 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 861149c7 2022-08-03T15:43:29 Make PLS coherent on desktop OpenGL Implements ANGLE_shader_pixel_local_storage_coherent using fragment shader synchronization extensions: NV_fragment_shader_interlock INTEL_fragment_shader_ordering ARB_fragment_shader_interlock With these extensions combined, we get coherency all 3 big desktop vendors: NVIDIA, Intel, and AMD. Bug: angleproject:7279 Change-Id: Ie20b251fb772898e89994b799640f1f2806581eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3773990 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll e6fcb2a9 2022-08-04T07:00:47 Roll Chromium from 54b1e2bc5d71 to d7560fcbdf63 (301 revisions) https://chromium.googlesource.com/chromium/src.git/+log/54b1e2bc5d71..d7560fcbdf63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/be199c7243..0ad6539347 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e1d2a33b49..915a8eb0cc * third_party/android_build_tools/aapt2: hf9C5IyJUUGaBnzqu60xiFJSyfAmjqjc_PiNXNVc9l0C..nSnWUNu6ssPA-kPMvFQj4JjDXRWj2iubvvjfT1F6HCMC * third_party/android_build_tools/lint: INnGGTfg5gGJutJiBtWI6-QwusHDDnKvZzI53Q3UiecC..nklp_LHwFqk9tuQm1yHGBy2W16YMz_R7Q7vcnZZnF78C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..048d42b412 * third_party/fuchsia-sdk/sdk: version:9.20220803.1.1..version:9.20220803.3.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3eef3c55dc..ba74bc78cc * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d7b966b45a..5b099b5d2e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/aba87cc71e..27842bf472 No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I229057dc673d9182cc654a39c2dfff7c33bc2ddf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3810051 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peng Huang c0818a18 2022-08-02T16:20:21 Protect ImageState::targets with a std::mutex The ImageState::targets could be accessed cross shared groups, so it is not protected by share context lock, so we have to protect it with this std::mutex. Bug: chromium:1349118 Change-Id: I886eed7a7405d01f01f1806b4d71db79d449e421 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3804750 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org>
Jamie Madill 9f0cec14 2022-08-03T15:59:45 dEQP: Fix X11 display config name. The name is "x11", not "window", which is a surface type. Bug: angleproject:7396 Change-Id: Ic2ad1f215729bd28d29e921c1712121b9b86e4af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3808294 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Eddie Hatfield c54ed790 2022-07-21T10:38:47 Get desktop GL conformance tests to build The target for these tests is angle_deqp_gl_tests. Bug: angleproject:7533 Change-Id: I290822671d99da020f9a6a1f02bee43987644bf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3766435 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Eddie Hatfield <eddiehatfield@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kenneth Russell 448e2275 2022-07-21T16:40:59 (Reland) [Metal] Disable ANGLE's Metal backend on older GPUs. Disable creation of EGL_PLATFORM_ANGLE_TYPE_METAL_ANGLE displays on: iOS: MTLGPUFamilyApple2 and older (A8 and older GPUs) macOS and Mac Catalyst: MTLGPUFamilyMac1 and older This is a partial integration of this recent WebKit fix: https://bugs.webkit.org/show_bug.cgi?id=242764 Refactored to eliminate duplicate copies of this code between libANGLE and the test suites. Changes since initial landing: - Explicitly link the angle_common static library against Metal.framework for the definition of MTLCreateSystemDefaultDevice, which was missing on the iOS Simulator. Fixed: angleproject:7514 Change-Id: I25028a298f1235db5b717ac6a1999552121d60c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3806252 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Bo Liu 57ccd974 2022-06-30T16:47:52 Make limit_max_texture_size_to_4096 webgl only Bug: chromium:1319451 Change-Id: I7dedeb8d738c1070e650650e893d57984a9e7956 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3739439 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 88b05d3c 2022-08-03T15:21:00 Use globals in android_helper to simplify flow. Explicit .Initialize(suite_name) call to detect Android Track suite (apk) that was installed. We use the same package com.android.angle.test in multiple apks (eg system info and perftests) so keeping track of which one is currently installed avoids the need to take care of it manually (with PrepareTestSuite). Bug: angleproject:7299 Change-Id: I4b96f0fb24e38fc42d3814fb0eeda5aae527de5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3808292 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Hailin Zhang 553b1334 2022-07-28T23:33:28 Vulkan: fix default msaa framebuffer resolve issue. Bug: b/239217726 Change-Id: I826aad7495814e0a178a586c4cfd5943278cddac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3793304 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 00a9787e 2022-08-03T16:37:50 Roll Chromium from fe6c14e1fc75 to 54b1e2bc5d71 (162 revisions) https://chromium.googlesource.com/chromium/src.git/+log/fe6c14e1fc75..54b1e2bc5d71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c8168ef10e..be199c7243 * buildtools/linux64: git_revision:9ef321772ecc161937db69acb346397e0ccc484d..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044 * buildtools/mac: git_revision:9ef321772ecc161937db69acb346397e0ccc484d..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/012c3438e0..c5d3129a8b * buildtools/win: git_revision:9ef321772ecc161937db69acb346397e0ccc484d..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3787411136..e1d2a33b49 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ee25a7fdb8..00e6aabbe3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7f8536d0bb * third_party/fuchsia-sdk/sdk: version:9.20220802.3.1..version:9.20220803.1.1 * third_party/r8: fyrZX7YFSdaFh8Uqs1iTtsYtS8351A4ndoz7WiIIrDgC..8RiUzjctgueOdfuqGNeXwdR_7AGlMwPM9A01M3uKD88C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b59b9a6691..3eef3c55dc No update to Clang. Bug: None Tbr: jmadill@google.com,ynovikov@google.com Change-Id: I62afb1f5fe2afda626b5f5e4d03ec0a131234304 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3807277 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott 8f14296c 2022-08-02T14:46:31 Roll VMA to version 3.0.1 + Google patches Bug: b/238213234 Change-Id: I3d0764746f452b011eecc65f52f99aa171016c73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3806603 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 6bc106f7 2022-08-03T11:31:25 Ignore all .gclient* files. `gclient sync` seems to now be writing .gclient_previous_custom_vars Bug: None Change-Id: Ie7614bf0b7dc582eb79778f47481139cfcc5f342 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3807760 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
kmx.io     mail     discord kmxgit v0.4.0