|
134d6eed
|
2019-04-09T14:50:23
|
|
Vulkan: pipeline cache not populated as blob cache is not set
1. Use vkMergePipelineCaches in eglSetBlobCacheFuncsANDROID as
blob cache callbacks are set after eglInititalize.
2. Use a more proper way to save the cache data to disk.
Bug: angleproject:3318
Change-Id: Ieb5d10ab93e7afb2aab4446b387d7f36c878a686
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1559671
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
625f5b2f
|
2019-06-26T16:19:35
|
|
Cleanup angle_libs_suffix in BUILD.gn.
We can use output_name instead of repeating the libs suffix in the GN
files.
Bug: angleproject:3611
Change-Id: Ic87c1378aac8be8e1aec695ddbe5c8ec2ed3187b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1678403
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
923c30fb
|
2019-06-27T15:16:01
|
|
Update test expectations for vulkan gles31 bots.
Before enabling gles31 vulkan tests on the bots, there are some test
expectations that must be updated.
Bug: 3521
Change-Id: If48cad3d7405cc331e133bf80f62b34d33504c66
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1680066
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
0bfa5504
|
2019-06-03T10:40:10
|
|
Vulkan: Emulate Transform Feedback with vertex shader output
In ES 3.0 and 3.1, only non-indexed GL_POINTS, GL_LINES and GL_TRIANGLES
is supported for transform feedback. Without tessellation and geometry
shaders, we can calculate the exact location where each vertex transform
output should be written on the CPU, and have each vertex shader
invocation write its data separately to the appropriate location in the
buffer.
This depends on the vertexPipelineStoresAndAtomics Vulkan feature.
Bug: angleproject:3205
Change-Id: I68ccbb80aece597cf20c557a0aee842360fea593
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1645678
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
235e56fb
|
2019-06-27T11:28:31
|
|
BlitGL: Support CL readback from non-renderable textures.
External textures are often not renderable for the CPU readback path.
Instead, copy them into a renderable texture and then read them back.
BUG=906724
Change-Id: I61bd0a9d51c4b24e1d285b5f1883e01ccb53ebea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1680053
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
c5da7997
|
2019-06-27T12:57:13
|
|
Fix skip Texture3DTestES3.DrawWithLevelsOutsideRangeWithInconsistentDimensions
on Linux Intel GL.
Wrongly skipped
Texture2DTestES3.DrawWithLevelsOutsideRangeWithInconsistentDimensions
in previous CL.
Bug: angleproject:2782
Change-Id: Ifb54f394f7c7b953365bd04b93231a6880f709f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1680844
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
5a542996
|
2019-06-26T10:55:57
|
|
Test RGB32F texture format on Intel Linux
Bug: angleproject:1958
Change-Id: I52787100fbc9a24b025393eafdede34750c4ca7e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1678732
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
4783e454
|
2019-06-27T11:23:15
|
|
Vulkan: Remove flaky test suppression.
This test might not specifically be flaky. The crash we saw might have
been related to underlying flakiness in the NVIDIA config. We can try
removing the flaky suppression and watching the bots for any failures.
Bug: angleproject:3328
Change-Id: I73f7c104c87759fc17db7e97bd9e0e299cf1fe7b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1680052
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
485cdd8b
|
2019-06-26T16:19:34
|
|
Add std::ostream output for packed enums.
This can be used to convert them to strings for debugging. It can also
be helpful for frame capture and replay. Currently the enums are output
as GLenum values.
Bug: angleproject:3611
Change-Id: Ifcd04449e0ef61e125e0db65aa0dcc2bf48b38ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1678399
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
db990834
|
2019-06-26T16:05:02
|
|
Support NaN conversion in Float32ToFloat16
Add NaN support to Float32ToFloat16.
This follows Dawn's implementation:
https://dawn-review.googlesource.com/c/dawn/+/8361
Bug: 3612
Test: angle_unittests
Change-Id: I624bee2fc48c46b8a69cd38654679ac3cbd7c09f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1678407
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
f0ea83a4
|
2019-06-26T10:17:26
|
|
Vulkan: Initial support for ES3.1
Bug: angleproject:3520
Bug: angleproject:3521
Change-Id: I49d67cae0bba3e147c7a83c10e09fe1ee5ff0824
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1678400
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
a9dfb3ba
|
2019-06-26T18:36:10
|
|
Allow "GL_INVERT" nvpr fill mode to pass validation
Bug: angleproject:3617
Bug: skia:9214
Change-Id: I11f4e845095cc1ebcbc2717682e945bcf2bb67e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1679631
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
68e09a14
|
2019-06-27T07:01:40
|
|
Roll ./third_party/spirv-tools/src dfcb5a1e1042..6ccb52b86492 (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dfcb5a1e1042..6ccb52b86492
Created with:
gclient setdep -r ./third_party/spirv-tools/src@6ccb52b86492
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=syoussefi@google.com
Change-Id: I791443a678703c6876b7e27131869e5b25b7385f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1680290
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
f857b501
|
2019-06-26T20:15:46
|
|
Skip end2end tests failing on Intel Ubuntu 19.04 Mesa 19.0.2
Failing:
MaskedScissoredClearTest.Test/ES2_OpenGL_clear_cd
MaskedScissoredClearTest.Test/ES2_OpenGL_clear_cd_mask_c
MaskedScissoredClearTest.Test/ES2_OpenGL_clear_cds
MaskedScissoredClearTest.Test/ES2_OpenGL_clear_cds_mask_c
MaskedScissoredClearTest.Test/ES2_OpenGL_clear_cds_mask_cs
MaskedScissoredClearTest.Test/ES2_OpenGL_clear_cds_mask_s
MaskedScissoredClearTest.Test/ES2_OpenGL_clear_d
MaskedScissoredClearTest.Test/ES2_OpenGL_clear_ds
MaskedScissoredClearTest.Test/ES2_OpenGL_clear_ds_mask_s
MaskedScissoredClearTest.Test/ES3_OpenGL_clear_cd
MaskedScissoredClearTest.Test/ES3_OpenGL_clear_cd_mask_c
MaskedScissoredClearTest.Test/ES3_OpenGL_clear_cds
MaskedScissoredClearTest.Test/ES3_OpenGL_clear_cds_mask_c
MaskedScissoredClearTest.Test/ES3_OpenGL_clear_cds_mask_cs
MaskedScissoredClearTest.Test/ES3_OpenGL_clear_cds_mask_s
MaskedScissoredClearTest.Test/ES3_OpenGL_clear_d
MaskedScissoredClearTest.Test/ES3_OpenGL_clear_ds
MaskedScissoredClearTest.Test/ES3_OpenGL_clear_ds_mask_s
BlitFramebufferTest.MultisampleDepthClear/ES3_OpenGL
DrawBuffersTest.FirstHalfNULL/ES2_Vulkan
DrawBuffersTest.Gaps/ES2_Vulkan
WebGLCompatibilityTest.DrawBuffers/ES2_Vulkan
Crashing:
Texture3DTestES3.DrawWithLevelsOutsideRangeWithInconsistentDimensions/ES3_OpenGL
Bug: angleproject:2782, angleproject:3614, angleproject:3616
Change-Id: Ib9bc72d8fd050ba1db1269d5fb3b38e80636211e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1679630
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
d43eee64
|
2019-06-14T11:12:51
|
|
Vulkan: Increase size of driver uniforms buffer.
This should prevent applications that use a lot of updates from getting
bottlenecked on buffer and descriptor set updates.
Bug: angleproject:3504
Change-Id: I8fc88b5f13858b8858d88f7e6f43af022c3f6a75
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1647030
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
1042250f
|
2019-06-25T17:06:46
|
|
Allow wildcards freely in deqp expectations files
Bug: angleproject:3520
Change-Id: I1f34717e6efaf4a6371c345d892922e598e871bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1676552
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c773ab98
|
2019-06-25T17:11:58
|
|
Vulkan: Recycle dynamic buffer storage.
This adds a free list to the dynamic buffer storage. Buffers are added
to the free list when the retained buffers are released. They are taken
from the free list when we allocate a new buffer. We only allocate
a new buffer in the ring when we run out of free buffers. This reduces
the amount of time we spend in allocation for frequent updates.
Now that we're recycling buffers inside of DynamicBuffer we also need
to be a bit more careful about when we allow ourselves to reuse them.
If they're still in use by the GPU we should not try to modify them.
Bug: angleproject:3082
Change-Id: Ibee5a7e2fe4a17f4a2f7af6bc6bcce54bdc413c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1646548
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
|
|
|
cc82c3f0
|
2019-06-21T16:04:24
|
|
Vulkan: Enable VertexAttributeTest* for ES3_Vulkan
VAO support is present, so this is just enabling the necessary testing.
The tests being skipped are being worked on with issue 3193, which is
adding support for integer values.
Bug: angleproject:3207
Test: VertexAttributeTest end2end tests
Change-Id: Ic0bbcc0e05673aece203e93d8765ac8e90dc6a59
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1672445
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
7f2520f1
|
2019-06-26T11:18:33
|
|
Vulkan: Refactor DynamicBuffer::init.
This will allow us to more easily create a white box test that sets a
very small initial size for a dynamic buffer.
Bug: angleproject:3082
Change-Id: Ic02bbee83ee8e0f4bfe182e9448c2ce60dea66d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1667645
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
|
|
|
8929b9c5
|
2019-06-18T16:21:38
|
|
Vulkan: Output buffer memory barrier in graph dump
Bug: angleproject:3205
Change-Id: Id8c1de49d2201ea331e5f5223c88144db5fadbb3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665354
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
1245f078
|
2019-06-25T13:51:29
|
|
Use D3D11 GetDimensions driver workaround for dynamic images
Some NVIDIA D3D11 drivers are buggy and interprets the level passed to
GetDimensions as being relative to 0, rather than the SRV's MostDetailedMip.
This affects the implementation of the imageSize function in the D3D11 backend.
Bug: angleproject:3100
Change-Id: I1e48f5df5e40caf49a4d07662aec587e98cf8388
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1677206
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
615ae1a7
|
2019-06-21T12:10:14
|
|
Vulkan: Improve copy buffer self-dependency
The check in addReadDependency to avoid setting self-dependencies was
causing the barrier set in `copySubData` to be potentially set earlier
than the buffer's previous usage. This change allows buffer
self-dependencies to be handled especially.
Bug: angleproject:3194
Change-Id: I08f2c39f420f020ad5faa9735193e6b7142fa756
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1670952
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
f20daf0b
|
2019-06-26T07:01:17
|
|
Roll ./third_party/glslang/src f9d08a25fbe1..4162de4bbfc5 (4 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f9d08a25fbe1..4162de4bbfc5
Created with:
gclient setdep -r ./third_party/glslang/src@4162de4bbfc5
The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=syoussefi@google.com
Change-Id: I03bb4c5cf03e37db4109f5fe7c7412e27c4fad53
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1677697
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
166f0ab3
|
2019-06-26T07:01:39
|
|
Roll ./third_party/spirv-tools/src df86bb44fe47..dfcb5a1e1042 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/df86bb44fe47..dfcb5a1e1042
Created with:
gclient setdep -r ./third_party/spirv-tools/src@dfcb5a1e1042
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=syoussefi@google.com
Change-Id: I4a01fff43331aa2d3bafbc4aa428e3e8ef684266
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1677698
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
6d58266e
|
2019-06-25T09:34:46
|
|
Vulkan: Update deqp GLES 3.0 texture expectations
Sub-divide one of the big SKIP lines into more-fine-grain SKIP and FAIL lines, based on current top-of-tree status.
Bug: angleproject:3190
Change-Id: I50ac559a5b44c06b8e525d10efe3ff1b24350d6d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1676406
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
a9bbf6df
|
2019-06-25T10:58:45
|
|
Fix warnings in standalone linux build.
BUG=angleproject:3559
Change-Id: Ib57b40d6f6b488549c5746a4e2d40e6fba6bcd4f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1676306
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
0fd917a2
|
2019-06-23T00:50:44
|
|
Vulkan: Remove unnecessary same-layout transitions
Previously, only read-only layouts skipped same-layout transition. This
is extended to color attachment and depth/stencil attachment layouts as
well. On Nvidia+Linux, this does reduce the number of barriers in the
Draw* benchmarks, though there's no visible CPU-side performance
difference. GPU time is not measured in these tests, but it's possible
that the driver already skips such transitions (i.e. this only saves us
from recording an ineffective transition).
Additionally, transfer dst and shader write same-layout transitions are
turned into an execution barrier instead of a memory barrier to avoid an
unnecessary flush. Currently, this particularly affects texture upload,
and shows a 10% improvement in TextureUploadSubImageBenchmark. Note
that this optimization is temporarily disabled due to a bug in the
windows AMD driver.
Bug: angleproject:3347
Change-Id: I7dc9d0b5dd2ad87ec19ae13277b330438038519f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1659149
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
b937093e
|
2019-06-21T11:02:17
|
|
HLSL tests with regex
HLSL adds a unique id suffix to user defined variable and these numbers
are currently hardcoded in tests. It could easily fail if new tokens are
added to angle builtin variables.
Introduce C++11 regex feature into the foundInHLSLCode to avoid over
strict tests.
Bug: angleproject:3551
Change-Id: Ia3052afec667a7ac11198be31b5c1d03c856a723
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1670581
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
|
|
|
5ff8cae9
|
2019-06-21T11:09:25
|
|
GL/D3D: Use texture uploads instead of clearing for robust init.
Chrome uses regular texture uploads on all platforms except OpenGL on
Mac to do robust resource init for textures because multiple bugs have
been observed with texture corruption.
BUG=883276
BUG=882580
BUG=941620
Change-Id: I5fcd6862147822a08c7533e6a6a9277223034ebd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1669104
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
4c0a2361
|
2019-06-25T10:56:29
|
|
Update ValidateSamplerParameterBase to use const parameters.
ValidateSamplerParameterBase is called with both const and non-const
parameter pointers which caused our explicit template instantiations to
not cover all cases resulting in link errors. Force the parameters to
always be const so that our instantiations cover everything.
BUG=angleproject:3555
Change-Id: Ibf92572ba80a689c75dcdc70e5153d9941da76f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1676305
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
74e98f6c
|
2019-06-19T17:09:56
|
|
Use highestUsed() instead of size()
Bug: angleproject:3548
Change-Id: Idd273cdfff5f175399dcc46bd40db52d6f4163b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666909
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
|
|
|
3b225597
|
2019-06-17T14:18:06
|
|
Fix the DispatchCompute error
The error happens when a RWTexture is used in shader. However, there is
no resource binding to it. We should clear the corresponding UAV in case
the previous view type is a bufer not a texture.
Meanwhile, this patch removes clearSRVs/clearUAVs since we use
unsetConflictingSRVs/unsetConflictingUAVs to do the similar thing.
Bug: angleproject:3512, angleproject:3548
Change-Id: I01752bb9bc6aca5b767599639c4dc613b4e2e2d2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1662017
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
|
|
eb66fe4e
|
2019-06-24T14:37:44
|
|
Move uses-sdk to GN.
Bug: 891996
Change-Id: I64381bea1bcbddb76748dd03c7caaf2f5360e1ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1674258
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
dd3ef1e7
|
2019-06-24T07:01:52
|
|
Roll ./third_party/spirv-tools/src 7c294608ca19..df86bb44fe47 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7c294608ca19..df86bb44fe47
Created with:
gclient setdep -r ./third_party/spirv-tools/src@df86bb44fe47
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: I04e0b7ee52f1c981eb42d20dcd045eff4812c1f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1673826
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
dfd76005
|
2019-06-14T11:15:52
|
|
Vulkan: Don't update pipeline when only textures change.
We could expand this functionality in the future to only update the
pipeline when a signficiant bit of pipeline state changes. For now this
is mostly a proof of concept.
Significantly improves performance in the textures microbenchmark.
Bug: angleproject:3117
Change-Id: I3957dd2f08d7d89694f94ddbe45eeeeb620bac0a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1650790
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
351e8098
|
2019-06-21T10:35:06
|
|
Increase demangled array size
The call to abi::__cxa_demangle() with too small of a char[] can cause
segfaults or hangs. This change increases the array from 256 to 4096.
Bug: angleproject:3553
Test: Verify validation layers don't segfault/hang
Change-Id: I6704ff00bfab62c99eb288f803ccda35a037dd9d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1670580
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
87748543
|
2019-06-18T18:45:42
|
|
GL/Vulkan: handle depth texture discrepancy
In GLES 3.0, depth textures where changed to behave like RED textures,
but in GLES 2.0 with ARB/OES_depth_texture, they were treated as
luminance textures.
This change produces the expected behavior on GLES 2.0 for the GL
backend and on GLES 3.0 for the Vulkan backend.
Bug: angleproject:3540
Change-Id: Iad6b4e03cf947b27eb97dbb10419bc8bcdb11024
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666363
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: James Dong <dongja@google.com>
|
|
|
647f2000
|
2019-06-19T16:18:28
|
|
Limit max texture size and max MSAA samples on Android.
Android devices will often fail to allocate textures this large and it is
prefereable to return an error from ANGLE instead of losing the context
due to an out of memory error.
This mirrors the limits Chrome applies with the max_texture_size_limit_4096
and max_msaa_sample_count_4 workarounds that are broadly applied to Android.
BUG=882580
Change-Id: I63890baa8712f13b37c607fa475432e67e9384a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1351357
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
bce4b9f8
|
2019-06-19T16:20:09
|
|
Always scalarize mat and vec constructor arguments.
This workaround is always enabled in Chrome, do the same in ANGLE.
BUG=882580
Change-Id: I2c01f34a589b07bd0035d7408be884f7a51b1706
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666699
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
762f180a
|
2019-06-20T16:12:38
|
|
Print perf results to stdout on Android
Bug: chromium:977330
Change-Id: I25b2ac11b8ee9b5c084bd828a4d0ddf2b8c1b3eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1670092
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
371d95b8
|
2019-06-18T15:39:20
|
|
Vulkan: Handle 0-sized viewports
Issue exposed by a transform feedback test. Since we already create a
scissor to match the viewport (be it 0-sized or not), we can create the
Vulkan viewport with a small width/height if they are 0, as that's not
allowed by Vulkan.
Bug: angleproject:3205
Change-Id: Ib23d8b9f5e84447be2c4b7e8aff805e7d9e57323
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665352
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
067687f4
|
2019-05-29T12:48:49
|
|
Removal global locks from GL entry points. Always lock in EGL.
The ANGLE Vulkan backend is now thread safe for non-share group contexts. This
means that a global GL lock only adds overhead for most use cases.
Remove the angle_force_thread_safety gn argument.
BUG=angleproject:2464
Change-Id: Ic6ba89e18b46e5dd72aa83d0f409097441fcca3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1635749
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
|
|
|
9d275db4
|
2019-06-18T15:37:22
|
|
Vulkan: Add vkCmdFillBuffer support
Implemented as part of an experiment. Allows easier buffer-related
testing by providing a quick way of filling the buffer with dummy data.
Bug: angleproject:3205
Change-Id: Ice8cfd0c2566c91a5fb10aaea57985d671d0e7b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665351
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
|
|
|
53c4495a
|
2019-06-21T07:01:52
|
|
Roll ./third_party/spirv-tools/src 2090d7a2d26c..7c294608ca19 (8 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2090d7a2d26c..7c294608ca19
Created with:
gclient setdep -r ./third_party/spirv-tools/src@7c294608ca19
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: I92f99e50eaa01782b74f311b1f0d77d4580ab9fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1670005
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
bf4cfa77
|
2019-06-20T15:59:18
|
|
Switch ANGLE Win and Linux try bots to builderless.
Bug: chromium:973992
Change-Id: Iee5cf6a4b6b0469b81cd0c1a7cd0ebea05060580
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1670009
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
b867bc6f
|
2019-06-19T12:11:13
|
|
Vulkan: Fix dirty element array buffer updates.
The issue occurs that binds the same buffer and calls glDrawElements
with the same indices. The offset has been reset in the
VertexArrayVk::syncState(), but it doesn't check the actual value
in the ContextVk::setupIndexedDraw().
Also corrected case where update via BufferSubData wasn't being
sent to the HW.
Bug: angleproject:3362
Change-Id: I0f7d2fc162bc8f1c36cb09ba689fd27b482b9035
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666345
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
661ed419
|
2019-06-20T11:11:41
|
|
Debug: suppress INFO level messages by default
They can be re-enabled with the angle_enable_trace option.
Prevents validation errors from being output in NoFixture tests,
as the default platform methods aren't overridden.
Bug: angleproject:3525
Change-Id: I77342230b6c7cd167cfc3169f09d4e74b4579244
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1669848
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
cd946a03
|
2019-06-10T18:11:57
|
|
Vulkan: Fix out of bounds access of pWaitDstStageMask
Since a6242e4d4 ("Vulkan: Support submitting multiple semaphores"),
we can submit up to 2 semaphores at a time, but pWaitDstStageMask
is still a single value. Change it to an array of two elements to
prevent an out of bounds access.
Bug: angleproject:3289
Change-Id: I5147802ce350af7b78dbf54cfa4a9519dd495f01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666347
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9420fa06
|
2019-06-07T17:09:22
|
|
Vulkan: Implement copyBufferSubData
Implement BufferVk::copySubData().
Bug: angleproject:3194
Test: dEQP-GLES3.functional.buffer.copy.*
Test: dEQP-GLES3.functional.negative_api.buffer.copy_buffer_sub_data
Test: angle_end2end_tests BufferDataTestES3
Change-Id: I220cd490eb1eb799604e217b3e377af3fd431d97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1648669
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
d5cef305
|
2019-06-19T14:21:33
|
|
Vulkan: Add more trace events.
This captures a bit more information about where the call time goes
during a flush. It can show at least on desktop NVIDIA that we spend a
fair amount of time in vkQueuePresentKHR.
Bug: angleproject:3117
Change-Id: I2d0195b9338bcac80e8dd8cfb550402271f286f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1650787
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
44168468
|
2019-06-20T09:50:23
|
|
Vulkan: Sync image in TextureVk::syncState.
We can use the DIRTY_BIT_IMPLEMENTATION internal dirty bit in the
gl::Texture class to force calls to ContextVk::syncState. In syncState
we can ensure we call ensureImageInitialized before we get to the
ContextVk. This in turn means we can remove some of the command graph
breaks from TextureVk.
We need to make sure the dirty bits are propagated to EGL Image
siblings with this method. This fixes a potential implementation issue
with EGL images with the GL back-end.
Also makes a state change test a little better by removing some of the
VAO and program init calls before the draw.
Improves perf on the texture change microbenchmark by 12.5%.
Bug: angleproject:3539
Bug: angleproject:3117
Change-Id: I2b5481690801fa98f859a6c02e3f4b974590cd3d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1663839
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3ea463bf
|
2019-06-19T14:21:33
|
|
Move event tracer back into common.
Requires that we update the TRACE_EVENT macros to accept a platform as
an argument. The refactor isn't complete. In order to finish we'd need
to ensure we have the Display's PlatformMethods available at all sites.
Unblocks adding trace events directly in the perf tests.
Bug: angleproject:1892
Bug: angleproject:3117
Change-Id: Iee0ca086ccfe23acab3fc186fb042f018711a94c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1664794
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e4780c51
|
2019-06-19T17:25:43
|
|
Fix dEQp test results path on Android
Bug: angleproject:3547
Change-Id: I83e491fb0121f0a8473630ead6e48b062ae06da5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1668234
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
c5c937e1
|
2019-06-19T16:20:57
|
|
Vulkan: Support R11G11B10_FLOAT and R9G9B9E5_SHAREDEXP
The keys in vk_format_map.json were incorrect. The format table
generation script is enhanced to give an error in such a case. This
revealed a number of entries with no corresponding angle format, which
are also removed.
Bug: angleproject:2898
Bug: angleproject:3190
Change-Id: I32caf2d2a8abb6f76b25436725670a8e84d576fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666700
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
8af6c6f5
|
2019-06-18T15:43:44
|
|
Vulkan: Minor cleanup of Transform Feedback validation
By using the helper isTransformFeedbackActive* functions.
Bug: angleproject:3205
Change-Id: I50b3e9db427da9f65c3e2b50d7847464e8c28202
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665353
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
8b227a3b
|
2019-06-19T14:22:26
|
|
Documentation: Update support matrix.
BUG=angleproject:1944
Change-Id: I123bb4f97f947272364c765b18d11dba476eee01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666696
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
c6601ec8
|
2019-06-14T11:07:23
|
|
Vulkan: fix texture swizzle
Corrects texture swizzle in Vulkan backend. Previously user-supplied
swizzle was applied before internal swizzle; this change applies the
internal swizzle first, causing the correct behavior.
Also recreates image views when swizzle is dirty.
Test: ./angle_deqp_gles3_no_gtest --deqp-egl-display-type=angle-vulkan -n 'dEQP-GLES3.functional.texture.swizzle.*'
Test: ./angle_end2end_tests --gtest_filter='SwizzleTest.*/ES3_Vulkan'
Bug: angleproject:3212
Change-Id: Ie2c44b479da5c19ba744ace7562a73c944f97a49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1660909
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
f157aba5
|
2019-06-19T07:01:52
|
|
Roll ./third_party/glslang/src 11805e41d992..f9d08a25fbe1 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/11805e41d992..f9d08a25fbe1
Created with:
gclient setdep -r ./third_party/glslang/src@f9d08a25fbe1
The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: Iaa82e2e9fadbbd02b8dae865d61c7f1217746a8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666931
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
88e03221
|
2019-05-31T12:06:28
|
|
Unset conflicting SRVs and UAVs
D3D11 cannot allow the same (sub)-resource bound as both
a SRV and an UAV at the same time. Unset conflicting SRVs
and UVAs between render pipeline and compute pipeline.
Bug: angleproject:3152
TEST=angle_end2end_tests.ComputeShaderTest.*
Change-Id: I9cb8b902edbf987166a57af314af6b21a6874998
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1576504
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>
|
|
|
6c824a1b
|
2019-06-18T15:43:33
|
|
Vulkan: Add missing layout for VK_IMAGE_LAYOUT_UNDEFINED
This this was missed because it doesn't add its own enum value and
instead reuses GL_NONE.
Bug: chromium:976374
Test: chrome --enable-features=UseSkiaRenderer,UiGpuRasterization \
--enable-gpu-rasterization \
--enable-oop-rasterization \
--use-vulkan=native \
--use-gl=angle \
--use-angle=vulkan
Change-Id: I73437211fef3253801e899cb6e50a8e18865cc65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665329
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
9a4bd48d
|
2019-03-14T14:40:57
|
|
Allow overwriting angle_root in non-Chromium GN configurations
This patch adds the support of overwriting angle_root to the one
defined outside ANGLE, which is useful for other projects which
intend to configure ANGLE in their GN builds.
Bug: angleproject:3263
Change-Id: I70a56a3d0afdca2eb66fb9619f0dd4d3efc58dee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1522912
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
71ad2a73
|
2019-06-18T21:10:28
|
|
Revert "Vulkan: Add missing command pool reset."
This reverts commit 9aa865a6f9885fce602e9b637a18fb124ce9d372.
Reason for revert: Seems to be causing crashes on Android in glmark2.
Might also be responsible for a perf regression.
Bug: angleproject:3542
Original change's description:
> Vulkan: Add missing command pool reset.
>
> We were still calling destroy in checkCompletedCommands. We can
> instead call reset.
>
> May not significantly impact performance.
>
> Bug: angleproject:3489
> Change-Id: I61a2cb154faac56dc78a49678dd822d81ce16ad2
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1647029
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Tobin Ehlis <tobine@google.com>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
TBR=tobine@google.com,jmadill@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: angleproject:3489
Change-Id: Icb0e99f18ecab09798654605973958bd2b263002
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665748
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
11b9dc59
|
2019-06-18T15:28:44
|
|
Switch ANGLE Win and Linux CI bots to builderless.
Also update doc.
Bug: chromium:973992
Change-Id: I59a27935d2bcd438df025945b885384b1d5b0792
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665328
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
857880e5
|
2019-05-27T13:39:15
|
|
GL: Add extensions to enable hardware video decode on Android.
The Android SurfaceTexture API has to be initialized with a texture id
which Chrome has to query from an ANGLE external texture. It also
rebinds and sets the texture dimensions on calls to
SurfaceTexture.updateTexImage so ANGLE must be notified about these
changes so that state tracking and validation continue to function.
BUG=967410
Change-Id: I92e9077f75835b088da3a8caffb3ff40e9ad0361
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1630293
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
32d718f3
|
2019-06-18T11:25:23
|
|
NVIDIA Shield workaround for IsNVIDIA() detection
NVIDIA Shield do not implement Vulkan, which is used to populate
vendor IDs in SystemInfo. The vendorIDs are used to check IsNVIDIA().
This CL adds a workaround so IsNVIDIA() returns true for NVIDIA
Shield.
Bug: angleproject:3541
Change-Id: Ib36dd376207163acfc8d3a0e341f07a7d6aa3122
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1663080
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
f9686af0
|
2019-06-04T17:49:43
|
|
Add support for D3D11 texture backed EGLImages
Implement EGL_ANGLE_image_d3d11_texture extension. Images created with
this extension might not be renderable based on bind flags and resource
usage of the client provided texture in which case attaching them to a
framebuffer won't succeed.
The intended use case is to bind the front and back buffers of a swap
chain to GL textures that can be used for rendering in the case of the
back buffer and as a shader input for the front buffer.
Bug: chromium:939655
Change-Id: Ic3328e831880292217b88be84740740df6031fa6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1646732
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
eee67c6e
|
2019-06-18T13:00:43
|
|
Fix Platform.h integration with ANGLE
A function was renamed which broke the platformMethods table strings.
This CL reverts the rename (originally from crrev/c/1660952)
Bug: angleproject:1621
Change-Id: I8121a4956ba1d3e3c5036f72f6f1fdf5509dc491
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1664792
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
124f78c2
|
2019-06-18T11:48:24
|
|
Remove gl::Context parameter from Observer functions.
It was only used in exactly one instance in VertexArray. Instead we can
cache a bool and avoid needing to pass it around.
Will make signaling dirty easier in the Vulkan back-end.
Bug: angleproject:3539
Change-Id: Ia570aec051a24a5280df49edc4345c54022b46ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1663838
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
81b6acfb
|
2019-06-18T10:10:42
|
|
Roll SPIRV Tools and Headers into ANGLE
SPIRV-Tools roller did not roll the correct headers version.
Change-Id: Ifa1c9e2ee92e11a5e84ba78249e422884f5b6582
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1663840
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
b8252fdb
|
2019-06-18T12:13:49
|
|
Remove unused WidenString function
The removed function had incorrect Windows implementation,
the return value was checked incorrectly.
Last use was removed in commit 573f76b3eebf38cefb144781bfd90418e2c7df37
https://chromium-review.googlesource.com/c/1042785
Bug: angleproject:2532
Change-Id: I66907fcb33041b097062208d53ca88752c05f9cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1664153
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Kimmo Kinnunen FI <kkinnunen@nvidia.com>
|
|
141a23f6
|
2019-06-17T17:56:59
|
|
Add support for OES_depth24
Allow 24-bit depth as a valid Renderbuffer format.
Bug: angleproject:3229
Test: angle_end2end_tests --gtest_filter=DepthStencilFormatsTest.DepthBuffer/*
Change-Id: I166639ec0e000595dc55848e4b8b7bef627b6471
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1661050
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a4c639c4
|
2019-06-03T14:04:01
|
|
D3D: Add a wrapper to Image11 that enables ASAN/MSAN to catch the errors on map operations
The wrapper should be a no-op on builds with assertions disabled.
The wrapper should be useful on ASAN and MSAN builds.
gn args out/release-asan --args="is_debug=false is_asan=true"
ninja -C out/release-asan angle_end2end_tests ^
out\release-asan\angle_end2end_tests ^
--gtest_filter=Texture2DArrayCopy.SnormFormats* --gtest_catch_exceptions=0 ^
--gtest_repeat=-1
Output when the fix payload of angleproject:2865 is removed:
...
Repeating all tests (iteration 1) . . .
Note: Google Test filter = Texture2DArrayCopy.SnormFormats*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from Texture2DArrayCopy
[ RUN ] Texture2DArrayCopy.SnormFormats/ES3_D3D11
=================================================================
==500==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x12b2c4777040 at pc 0x7fff9602216b bp 0x00c0eaafd090 sp 0x00c0eaafd0d8
READ of size 1 at 0x12b2c4777040 thread T0
#0 0x7fff9602216a in angle::R8G8B8A8::readColor c:\Users\kkinnunen\angle\src\image_util\imageformats.cpp:333
#1 0x7fff9618dbf0 in rx::CopyImageCHROMIUM c:\Users\kkinnunen\angle\src\libANGLE\renderer\renderer_utils.cpp:377
#2 0x7fff96186bb2 in rx::Image11::CopyImage c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Image11.cpp:113
#3 0x7fff95e90410 in rx::Renderer11::copyImage c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Renderer11.cpp:3009
#4 0x7fff9617b447 in rx::TextureD3D_2DArray::copyTexture c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\TextureD3D.cpp:3293
#5 0x7fff95afd7e1 in gl::Texture::copyTexture c:\Users\kkinnunen\angle\src\libANGLE\Texture.cpp:1196
#6 0x7fff95977f19 in gl::Context::copyTexture3D c:\Users\kkinnunen\angle\src\libANGLE\Context.cpp:4347
#7 0x7fff9568b04a in gl::CopyTexture3DANGLE c:\Users\kkinnunen\angle\src\libGLESv2\entry_points_gles_ext_autogen.cpp:57
#8 0x7ff7d1d8fc97 in angle::CopyTexture3DTest::testCopy c:\Users\kkinnunen\angle\src\tests\gl_tests\CopyTexture3DTest.cpp:90
#9 0x7ff7d1dadd10 in angle::Texture2DArrayCopy_SnormFormats_Test::TestBody c:\Users\kkinnunen\angle\src\tests\gl_tests\CopyTexture3DTest.cpp:1272
#10 0x7ff7d2c22891 in testing::Test::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2522
#11 0x7ff7d2c243c0 in testing::TestInfo::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2698
#12 0x7ff7d2c253e8 in testing::TestSuite::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2828
#13 0x7ff7d2c3f33e in testing::internal::UnitTestImpl::RunAllTests c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:5285
#14 0x7ff7d2c3e72d in testing::UnitTest::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:4873
#15 0x7ff7d2bf10a2 in main c:\Users\kkinnunen\angle\src\tests\angle_end2end_tests_main.cpp:15
#16 0x7ff7d2d27897 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283
#17 0x7ff801ec7973 in BaseThreadInitThunk+0x13 (C:\WINDOWS\System32\KERNEL32.DLL+0x180017973)
#18 0x7ff804cea270 in RtlUserThreadStart+0x20 (C:\WINDOWS\SYSTEM32\ntdll.dll+0x18006a270)
0x12b2c4777040 is located 0 bytes to the right of 256-byte region [0x12b2c4776f40,0x12b2c4777040)
allocated by thread T0 here:
#0 0x7ff7d2c6d574 in malloc C:\b\s\w\ir\k\src\third_party\llvm\projects\compiler-rt\lib\asan\asan_malloc_win.cc:68
#1 0x7fff95af47b2 in angle::MemoryBuffer::resize c:\Users\kkinnunen\angle\src\common\MemoryBuffer.cpp:40
#2 0x7fff9648c9a6 in rx::MappedSubresourceVerifier11::wrap c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\MappedSubresourceVerifier11.cpp:51
#3 0x7fff961864b5 in rx::Image11::map c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Image11.cpp:648
#4 0x7fff9618676c in rx::Image11::CopyImage c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Image11.cpp:93
#5 0x7fff95e90410 in rx::Renderer11::copyImage c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Renderer11.cpp:3009
#6 0x7fff9617b447 in rx::TextureD3D_2DArray::copyTexture c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\TextureD3D.cpp:3293
#7 0x7fff95afd7e1 in gl::Texture::copyTexture c:\Users\kkinnunen\angle\src\libANGLE\Texture.cpp:1196
#8 0x7fff95977f19 in gl::Context::copyTexture3D c:\Users\kkinnunen\angle\src\libANGLE\Context.cpp:4347
#9 0x7fff9568b04a in gl::CopyTexture3DANGLE c:\Users\kkinnunen\angle\src\libGLESv2\entry_points_gles_ext_autogen.cpp:57
#10 0x7ff7d1d8fc97 in angle::CopyTexture3DTest::testCopy c:\Users\kkinnunen\angle\src\tests\gl_tests\CopyTexture3DTest.cpp:90
#11 0x7ff7d1dadd10 in angle::Texture2DArrayCopy_SnormFormats_Test::TestBody c:\Users\kkinnunen\angle\src\tests\gl_tests\CopyTexture3DTest.cpp:1272
#12 0x7ff7d2c22891 in testing::Test::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2522
#13 0x7ff7d2c243c0 in testing::TestInfo::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2698
#14 0x7ff7d2c253e8 in testing::TestSuite::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2828
#15 0x7ff7d2c3f33e in testing::internal::UnitTestImpl::RunAllTests c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:5285
#16 0x7ff7d2c3e72d in testing::UnitTest::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:4873
#17 0x7ff7d2bf10a2 in main c:\Users\kkinnunen\angle\src\tests\angle_end2end_tests_main.cpp:15
#18 0x7ff7d2d27897 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283
#19 0x7ff801ec7973 in BaseThreadInitThunk+0x13 (C:\WINDOWS\System32\KERNEL32.DLL+0x180017973)
#20 0x7ff804cea270 in RtlUserThreadStart+0x20 (C:\WINDOWS\SYSTEM32\ntdll.dll+0x18006a270)
Bug: angleproject:2865
Change-Id: I6c8fc203d075014ba8ce31c728982eed73812d04
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1640212
Commit-Queue: Kimmo Kinnunen FI <kkinnunen@nvidia.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
2d223552
|
2019-06-18T07:01:52
|
|
Roll ./third_party/glslang/src def9662348b0..11805e41d992 (5 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/def9662348b0..11805e41d992
Created with:
gclient setdep -r ./third_party/glslang/src@11805e41d992
The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: Idf29d79ea4e9f65e239604225af391de7640f313
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1662959
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
b1c8dbf3
|
2019-06-14T23:57:26
|
|
Vulkan: Correct synchronization for buffer readback
When mapping buffer memory, a flush is performed if the buffer has
pending operations followed by a finishToSerial to make sure the buffer
is no longer in use by the GPU.
This also implements GLES 3.0 buffer mapping flags:
GL_MAP_INVALIDATE_RANGE_BIT: No-op. Vulkan's vkMapMemory doesn't have
such a feature.
GL_MAP_INVALIDATE_BUFFER_BIT: Same
GL_MAP_FLUSH_EXPLICIT_BIT: Vulkan automatically flushes host memory
writes on vkQueueSubmit, so this is no-op as well.
GL_MAP_UNSYNCHRONIZED_BIT: The flush+finishToSerial call is skipped in
this case.
Bug: angleproject:3213
Change-Id: I6bdb460dffbb57170649f4c9678afbfae331926c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1661252
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
c211c2f5
|
2019-06-14T16:02:17
|
|
Make proc table autogen use gl.xml data
Instead having the proc table be generated from proc_table_data.json
which needed to be manually updated with changes, the proc table is now
generated from data in gl.xml and egl.xml
Bug: angleproject:3533
Change-Id: I773ea7615cc4ec1c9901def629b089d8d17328eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1660645
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
3f8975e1
|
2019-06-12T13:11:57
|
|
Debug: suppress INFO log level in tests
Disables INFO level log messages in tests, including GL errors.
Bug: angleproject:3525
Change-Id: Ib16871b9faaff54964dd2770e1791372b1b79361
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1656293
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: James Dong <dongja@google.com>
|
|
|
875509e9
|
2019-06-17T13:44:21
|
|
Vulkan: Minor cleanup to ContextVk::setupIndexedDraw.
This removes VertexArrayVk::updateIndexTranslation. Turns out this
helper function wasn't that helpful.
Bug: angleproject:3539
Change-Id: Ia4573219073261767e9d215ed4227233c23cbfaa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1660639
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
beb0eb2d
|
2019-06-14T15:10:33
|
|
Clean up workarounds/features to single location.
Rename all workarounds structs to features, and move the lists to a
shared location in include/platform (to help with documentation,
see:
https://cs.chromium.org/chromium/src/ui/gl/gl_switches.cc?sq=package:chromium&g=0&l=69)
Bug: angleproject:1621
Change-Id: I4069f08131db5e886047a007efb5d7764dfee5f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1660952
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
d7013c03
|
2019-06-17T09:27:18
|
|
Merge ESSL pre-processsor token errors
In both the ESSL 1.00 & 3.00 specifications having an extension directive
after a pre-processor token is an error. Merging those two enum cases to
be a single case. WebGL is handled as a separate warning case for any
shader version before 3.00.
Also this change now correctly marks 1.00 shaders that break this rule
to be invalid so the ExtensionAfterNonPreProcessorTokenESSL1 test no
longer expects handleExtension() to be called.
BUG=chromium:971660
Change-Id: I37b10cc0fb3a0efd6200a478171e005a96478255
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1661395
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
|
e962b6a6
|
2019-06-17T10:12:26
|
|
Vulkan: Enable previously failing clear tests
These tests crashed in FramebufferVk::clearWithAttachment, which no
longer exists.
Bug: angleproject:3081
Change-Id: I6b01c311c4caed21a920e5d5db1195c2dbfb905a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1661554
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
08b56293
|
2019-06-10T12:55:36
|
|
Vulkan: add LINE_LOOP with primitive restart
Adds support for GL_LINE_LOOP with primitive restart.
Bug: angleproject:3215
Change-Id: Ief1bdf15ef9b108dba025eaf4ce580bba54af623
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1649351
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
2c49d0b0
|
2019-06-14T15:17:37
|
|
Suppress Bindings perf test on Win/Intel/GL.
BindingsBenchmark.Run/gl_100_objects_allocated_every_iteration
This test was timing out on the bots. Conservatively skip the benchmark
on Intel/GL/Windows.
Bug: chromium:974083
Change-Id: I4a254bff8b43e5a47b5905ee6b9bc1a659129684
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1660951
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
e1849ee1
|
2019-06-16T23:06:28
|
|
Remove obsolete WinRT files.
These were no longer used in the build.
Bug: angleproject:3162
Change-Id: I715bb3e6f14ed8c97523dec5b0b58bf9a89be0f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1660716
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
67d8b6f6
|
2019-06-17T07:02:00
|
|
Roll ./third_party/spirv-tools/src 42830e5a68c3..59983a601091 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/42830e5a68c3..59983a601091
Created with:
gclient setdep -r ./third_party/spirv-tools/src@59983a601091
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jmadill@google.com
Change-Id: Iaa7e68def85004ca1ec5275d048d26495825faeb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1661577
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
5262bc70
|
2019-06-17T07:02:00
|
|
Roll ./third_party/glslang/src 96ee92f09b7c..def9662348b0 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/96ee92f09b7c..def9662348b0
Created with:
gclient setdep -r ./third_party/glslang/src@def9662348b0
The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jmadill@google.com
Change-Id: Ibe9c223bc7043607929ed1164b56ecdb9b0ec2d9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1661576
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
95ac7b7c
|
2019-06-13T11:29:06
|
|
Autogen gles2+ declarations
Added autogeneration of method declarations for GLES2+ and extensions
Bug: angleproject:3526
Change-Id: I9c7263452146098512d9584deae8ea3f15f62c46
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1660949
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
bf826481
|
2019-06-13T13:20:06
|
|
Update glslang_validator binary for Windows.
This binary was updated using update_glslang_binary.py.
Please see instructions in tools/glslang/README.md.
Bug: angleproject:3432
Change-Id: Iefed7d2ab1a0a7f7118b83037329fe608c85ba1e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1658848
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
a7271d35
|
2019-06-13T11:26:26
|
|
Update glslang_validator binary for Linux.
This binary was updated using update_glslang_binary.py.
Please see instructions in tools/glslang/README.md.
Bug: angleproject:3432
Change-Id: Idc02086cf0e1985efd7bf194adf311c85b21e33e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1657712
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
8118265a
|
2019-06-14T11:03:14
|
|
Add more DrawCallPerf offscreen configs.
I thought these might have different performance characteristics when
compared to the main configs. It's possible they would also need to
forego using SwapBuffers to get different profiles. Right now perf is
pretty similar to with the default FBO.
Bug: angleproject:3117
Change-Id: Ic03b4ebd8c606af5121854565525e37e66f91435
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1650785
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
12f38c49
|
2019-06-13T11:38:59
|
|
Vulkan: Use dynamic buffer for driver uniform updates.
This should reduce the number of descriptor sets we need to allocate.
We only allocate a new descriptor set when the underlying buffer is
reallocated. We pass in the buffer offset via the dynamic offsets
parameter.
Bug: angleproject:3504
Change-Id: I40d031cd7295a8d002caff4f331f4a311f07505c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1646757
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
|
|
|
9520a246
|
2019-06-14T07:01:52
|
|
Roll ./third_party/glslang/src 9866ad9195ce..96ee92f09b7c (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9866ad9195ce..96ee92f09b7c
Created with:
gclient setdep -r ./third_party/glslang/src@96ee92f09b7c
The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jmadill@google.com
Change-Id: I6d4817a07bb789d4973baf13b60c80bff4c18a0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1660056
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
853ebacf
|
2019-06-13T18:35:25
|
|
Suppress Mac 10.13.6 Intel OpenGL dEQP failures
Bug: angleproject:3531
Change-Id: I246144beb9c12b2df74612831262c7d263698db4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1658718
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
2806a898
|
2019-06-07T12:10:46
|
|
Vulkan: implement primitive restart
Implements ES 3.0 feature GL_PRIMITIVE_RESTART_FIXED_INDEX,
which allows the application to use a fixed "restart" index
to restart the primitive during a single draw call.
This change does't handle GL_LINE_LOOP primitives,
which requires a bit of special handling.
Bug: angleproject:3215
Change-Id: I2388852683fd17328a6a76c48d70a24d67ce8b67
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1650301
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
4316e064
|
2019-06-13T00:32:09
|
|
Vulkan: Output render pass loadOp in graph dump
Bug: angleproject:3205
Change-Id: I7ad99bd2f8ddeb899c5fa86fd39296e5fc96d2c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1657708
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
88596bea
|
2019-06-13T14:17:48
|
|
Vulkan: Implement a texture descriptor cache.
We noticed a significant hotspot in vkAllocateDesctiptorSets. The app
was repeatedly cycling through a few combinations of active textures.
For each state change in ANGLE we were allocating a new desctiptor set.
This in turn would trigger internal driver memory allocation and cause
jank. Using a cache avoids allocations entirely since the application
is rotating through a stable set of textures.
The descriptor cache is stored in each program. It is indexed by a set
of 32-bit serials. Each texture generates a unique serial for every
combination of VkImage and VkSampler that the texture owns. The texture
descriptor is refreshed every time a texture changes or is rebound.
The descriptor cache is accessed via an unoredered map with the texture
serial sets as the hash key. We also store the maximum active texture
index in the cache key so we don't need to hash and memcmp on all 64
active textures.
This will currently fail if more than MAX_UINT serials are generated.
But that number is high enough that it shouldn't be possible to hit
in practice in a practical amount of time.
Requires shifting the texture sync to ContextVk so we can get the new
serial after the textures are updated. And to make sure to update the
image layouts even if the descriptors are not dirty.
Improves performance of the T-Rex demo. Also improves the score of the
texture state change microbenchmark by about 40%.
Bug: angleproject:3117
Change-Id: Ieb9bec1e8c1a7619814afab767a1980b959a8241
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1642226
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
95428331
|
2019-06-10T18:03:03
|
|
Enable floatBlend for D3D9
Although according to
https://docs.microsoft.com/en-us/windows/desktop/direct3ddxgi/format-support-for-direct3d-feature-level-9-1-hardware
D3D9 doesn't have full blending capability for RGBA32F. But turns out it could provide
correct blending result in reality. As a result of some regression reports by client app, we
decided to turn floatBlend on for D3D9.
I tried to make a native D3D9 program to detect float blending capability.
But turns out it needs quite some effort on Win10 for a D3D newbie.
Considering the fact that D3D9 backend is not fully passing conformance test anyway.
I don't think it worth the effort. Seems to be okay to just turn it on.
Bug: chromium:970532
Change-Id: I66bec120be6eaaa62a5472b8521a97b4d23e924a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1652731
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
|
|
|
0d3cf708
|
2019-06-12T10:07:02
|
|
Vulkan: fix array size for internal shaders
Previously array sizes were calculated as the OR of all flag and enum
masks, equal to 2^(number of bits used for flags and enums) - 1, which
could be less than the actual needed array size.
This fix moves array size calculation to the autogen script and changes
the size to one more than the maximum potential value.
Bug: angleproject:3524
Change-Id: Ia4eb2a83fc7deea84e18958efcda8b57632035f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1655954
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
05ba83a0
|
2019-06-13T13:26:58
|
|
Refactor DrawCallPerfParams.
Makes it a bit easier to work with. In prep for adding offscreen
configs.
Bug: angleproject:3117
Change-Id: Ie2497574b2687592b7b3df2f7b933a19e83b6d16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1650784
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
b08d53d3
|
2019-06-13T16:01:20
|
|
Reland "Vulkan: Build validation layers with asserts only"
This reverts commit d187d45ede29369025595c53c7fe3ffed0688870.
Reason for revert: The correct thing to revert was https://chromium-review.googlesource.com/c/chromium/src/+/1657512
Original change's description:
> Revert "Vulkan: Build validation layers with asserts only"
>
> This reverts commit 85fef1bc62f851a4de91408cfafa570dbacf544f.
>
> Reason for revert: This actually seems to break the fucshia_x64 bot:
>
> Exception: Some files were excluded with --exclude-file, but not found in the deps list: lib/libVkLayer_parameter_validation.so, lib/libVkLayer_core_validation.so
>
> See https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzk0ODYyNWNjNDE2NmE3NjRkYWM2NTRlNjlmZDA3MGFjMDE3MzNkNTMM
>
> Original change's description:
> > Vulkan: Build validation layers with asserts only
> >
> > Adding ANGLE to the build includes the validation layers, which are only
> > for development. We don't want any development or debugging code to be
> > included by default in release builds, so tie building the validation
> > layers to enablement of asserts.
> >
> > Bug: angleproject:2475
> > Test: gn gen out/fuchsia_rel --args='target_os="fuchsia" is_debug=false use_goma=true'
> > gn desc out/fuchsia_rel //fuchsia/engine:web_engine runtime_deps
> >
> > Change-Id: I6d195c680255dcbc81e95f8e6f80e1e8ace169a2
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1656306
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Michael Spang <spang@chromium.org>
>
> TBR=spang@chromium.org,geofflang@chromium.org,jmadill@chromium.org
>
> Change-Id: Ia74efcce2b3dda02dc0c0d292bdeb5ea7c5c3530
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: angleproject:2475
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1657711
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
TBR=spang@chromium.org,geofflang@chromium.org,jmadill@chromium.org
Change-Id: Iab669210c23823b403e3fff7f5199a7aadd032bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:2475
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1658411
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
|
|
|
78a51911
|
2019-06-12T14:28:14
|
|
Clean up and expose frontend features to egl.
gl::Workarounds was used to hold frontend features. Change ownership of
this struct from Context to Display, so it can be exposed to egl. Also
rename to features and clean up for consistency.
Bug: angleproject:1621
Change-Id: I82e98e53873abb7a402c93e60f8a662a7263e0d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1655772
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|