kc3-lang/angle

Branch :

Log

Author Commit Date CI Message
1d1c4518 2021-05-11 12:00:05 Tests: Add Dr. Driving trace. Test: angle_perftests --gtest_filter="*dr_driving*" Bug: b/181871119 Bug: angleproject:5944 Change-Id: I0a95f91d68957840da7c99580db60472e44467a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2887286 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
51d02ca0 2021-05-06 15:16:16 FrameCapture: Use gl*Separate functions only when required. Use non-separate stencil and blend functions that do not distinguish between front and back buffers or color and alpha, if they apply. This prevents capturing GLES2 functions on GLES1 contexts. Bug: angleproject:5893 Change-Id: I8303ee5b279268ea9c21e2c6465e1b155d1cc54d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877238 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
57bc7ce1 2021-05-12 10:01:16 Roll SwiftShader from dcb33711bd4b to be169ef35238 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/dcb33711bd4b..be169ef35238 2021-05-11 swiftshader.regress@gmail.com Regres: Update test lists @ dcb33711 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ic3cd3631682b2cace3a6eed4ae0fe938766365fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891641 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
8af704bd 2021-05-11 11:27:17 Tests: Add Summoners War trace. Skip the trace on Windows/Intel since it produces GL_INVALID_ENUM. Test: angle_perftests --gtest_filter="*summoners_war*" Bug: b/181870341 Bug: angleproject:5943 Change-Id: I99b551294eeb267311728fd6f566cd549f97e90d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2887285 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
cf1064e6 2021-05-12 07:01:02 Roll Chromium from fff9d6fb8ddf to 3fb708290557 (495 revisions) https://chromium.googlesource.com/chromium/src.git/+log/fff9d6fb8ddf..3fb708290557 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4ff4105cd8..129bd6c0c0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/504fae9f10..43828a290e * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/93eae7d9dc..371f2bea4f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..302ca09b2d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb17bc6028..6e5b0a5c45 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/5243354177..66e0a5d62b * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/618ddecd59..c3edbeed8a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e76c8f17cf..53a9334ffe * tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1 * tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1 * tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df10bb0bf8..ac77520e0e * tools/skia_goldctl/mac: 5o7ziB6qRrSdtYJwKop8-5OFmvVQcxuNkGY1DRYggMsC..qwctaMZfXlU0u7OsbxWgOY_sBjsUYhlqwjJRbAXX3oYC Clang version changed llvmorg-13-init-7296-ga749bd76:llvmorg-13-init-9302-g897d7bce Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/e76c8f17cf2833813d671674cd89f01f3a21e851..53a9334ffea6aa748ff6c1ce8a46e71a90e7bc9f/scripts/update.py Bug: None Tbr: timvp@google.com Change-Id: Iff9b5446b67a948eeb60e1aa7aaacf0725714c05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891629 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
14365e1d 2021-05-11 21:08:16 Roll VK-GL-CTS from dab93ea8f88c to 6498f4042d9f (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/dab93ea8f88c..6498f4042d9f 2021-05-07 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master 2021-05-06 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master 2021-05-06 juha.heiskanen@siru.fi Add TexSubImage2D format compatibility tests 2021-05-06 piotr.byszewski@mobica.com Rename all OperationId enum values 2021-05-06 juha.heiskanen@siru.fi Fix validation error 'InputNotProduced' in Amber tests 2021-05-06 rgarcia@igalia.com Decrease 3D image size in image atomic op tests 2021-05-06 venni.ihanakangas@siru.fi Fix interfaceTypeMismatch validation errors in Amber tests 2021-05-06 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2021-05-06 jari.komppa@siru.fi Cover array input to interpolateAtCentroid If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC timvp@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:5952 Change-Id: Ic3a29ba2ae65ef1660c02b765a8fd767c6a5e133 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2890549 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
859ed396 2021-05-11 16:58:55 Follow up on Vulkan headers update to 1.2.177 Removing duplicate definitions in ANGLE. Bug: angleproject:5905 Change-Id: Ie62ad39a1ebc0d8b0d2c005723f461bc7309eade Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2889831 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
93aff937 2021-05-08 16:46:22 Refactor CL platform object Move GetPlatformInfo implementation from stubs to cl::Platform, because stubs are meant to be small. Also move CLPlatformImpl::Info instance to cl::Platform as it is more efficient to be accessed from there, and more consistent with cl::Device. Bug: angleproject:5904 Change-Id: I4c0ba6390467d6ef357e38a5ef08f54b0a88d423 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880663 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
e369a282 2021-05-08 14:08:28 Implement CL device object for front end and passthrough Bug: angleproject:5904 Change-Id: I17f6d10ed59c62fe9126d29b7de2c127c5d0039a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880662 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
d52ed4bd 2021-03-25 14:31:03 EGL: setup extension EGL_EXT_protected_content Add extension to registry Update hashes Bug: angleproject:3965 Change-Id: Ie2808b8a599ae4adbf6f2f1d24db046799f594df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2800412 Commit-Queue: Brandon Schade <b.schade@samsung.com> Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
cd535d2c 2021-05-11 13:13:55 infra: Switch Android ARM64 bots to compile-and-test. This will start to trigger tests on the Pixel 4 64-bit bots. Patch Series: 1. http://crrev.com/c/2885381 2. http://crrev.com/c/2885346 3. This CL 4. http://crrev.com/c/2885384 Bug: angleproject:5941 Change-Id: Ib76fd27d0814896522aad84443f52b7f47566e85 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885383 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
4901ac64 2021-05-06 15:15:57 FrameCapture: Capture GLES1 specific states. Implement capturing GLES1 specific state by checking the difference to the default state using getEnableFeature. When getEnableFeature is called from a context version higher than 1 and a GLES1 state is requested, an assertion is hit. Therefore the context version needs to be determined before calling getEnableFeature. Use the available isTextureTargetEnabled function to determine GL_TEXTURE_2D and GL_TEXTURE_CUBE_MAP states in getEnableFeature. Return false in isTextureTargetEnabled when mTextUnitEnables is empty, so the vector is not accessed when not initialized, which was the case for a default state. Bug: angleproject:5893 Change-Id: I66ee41c3bf7a8e1f04a8a4ce0461fddc16f9a013 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877237 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
46a139ad 2021-05-06 11:20:51 Vulkan: set DS layout before using it in the endRenderPass In CommandBufferHelper::endRenderPass(), we are checking depth stencil's initialLayout to change storeOp to None if the layout is read only. But the layout was set after that check, which essentially voids the optimization. This CL moves the finalizeDepthStencilImageLayout() call before the layout is used. This CL also moves the depth stencil loadOp/storeOp to a new function finalizeDepthStencilLoadStoreOp(). When depthImage gets deleted before renderpass ends, we could also apply the same load/store optimization just like we did at endRenderPass() time. Bug: b/187425444 Change-Id: I89814274352f09cbf1f7b58a91bbaf131b983fb1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877933 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
6e3c5321 2021-05-11 12:17:17 infra: Remove old TODO. Bug: angleproject:5114 Change-Id: I3b7255cc06bffd177f0b5ee8cad12bf2aad3089e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885382 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
e19182ce 2021-05-11 09:53:47 Suppress MultithreadingTest.MultiContextClear on Linux+Nvidia MultithreadingTest.MultiContextClear/ES3_Vulkan_NoVirtual is flaky on linux-clang-rel NVIDIA, so it's being suppressed for now. Bug: angleproject:5945 Change-Id: I9ef142c57b3fcf5224732edcea1650634ecc18ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2887905 Commit-Queue: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
3b10dda6 2021-05-05 11:51:00 Change to module directory when loading swiftshader ICD. When loading vulkan, we can be running from any directory. We need to change to the module directory to ensure the swiftshader ICD is loaded properly. For example, in some Chrome releases, libGLESv2.dll and libvk_swiftshader.dll are in a subdirectory relative to chrome.exe Bug: chromium:1198567 Change-Id: I9e68927e512b239728fb2903d1a04702508a4948 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873452 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
930db294 2021-05-10 19:19:31 infra: Add Android swarming spec placeholder. These will trigger tests on the Pixel 4 in standalone. For now we do not specify any tests. Patch Series: 1. This CL 2. http://crrev.com/c/2885346 3. http://crrev.com/c/2885383 4. http://crrev.com/c/2885384 Bug: angleproject:5941 Change-Id: Iad1bc27c316724b244fbfbf694f6e83fdf5c0507 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885381 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
83e5bb97 2021-05-06 15:15:42 FrameCapture: Don't capture shader functions on GLES1. Since an internal default shader is created and captured here in the GLES1 case, we need to check for the context version to skip capturing glUseProgram and emit an update call in GLES1 traces. Bug: angleproject:5893 Change-Id: Iac9bc05234fbc87c1f64264b5c12b9b117522bad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877236 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
125f128e 2021-05-11 10:01:18 Roll vulkan-deps from d3354ebca460 to 055e71b2a367 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/d3354ebca460..055e71b2a367 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5ef1ec1b87..0aca21bce7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I75ea4a8ae6a21e51b274f6a1dcff80c1aa924ab7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885449 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
07eaa8ee 2021-05-11 10:01:16 Roll SwiftShader from e260190edbd2 to dcb33711bd4b (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/e260190edbd2..dcb33711bd4b 2021-05-10 srisser@google.com Allow unrestricted depth bounds 2021-05-10 srisser@google.com Make clang-format-all.sh git aware 2021-05-10 sugoi@google.com Reduce size of SampledImageDescriptor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I3e0bdad486c078fa765c7a4ba980c89257cdbb11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2886667 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
078ebbcf 2021-05-06 17:07:14 FrameCatpure: Move capturing default vertex attribs to function. Don't capture these on GLES1, due to the unavailability of glVertexAtrrib4fv. Bug: angleproject:5893 Change-Id: Iafbc9219cfc0a0c1d0a55e112ee88d7180ed94f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877235 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
e40edf92 2021-05-06 17:06:58 FrameCapture: Add GLES1 support to CaptureVertexArrayData. Implement CaptureVertexPointerES1 that captures specific GLES1 vertex pointer functions depending on the attribute index. Use GLES1 capture functions in CaptureVertexArrayData by detecting the current context version. Implement VertexArrayType function in GLES1Renderer to get a ClientVertexArrayType enum from a vertex attrib index. Bug: angleproject:5893 Change-Id: I442b2e29475ca817860388cafc120db90a0fb9c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846838 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
eb91ebc9 2021-05-07 16:31:52 DEPS: Add Android tombstone resolution dependencies. Add third_party/android_platform and tools/python from the Chromium git to satisfy dependencies for the build/android/tombstones.py script. Bug: angleproject:5933 Change-Id: Ie19eec46c8cab208cde5064118ae655303e12fa7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878848 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
e72fa36e 2021-05-11 07:02:10 Roll Chromium from 518c3462c0a9 to fff9d6fb8ddf (568 revisions) https://chromium.googlesource.com/chromium/src.git/+log/518c3462c0a9..fff9d6fb8ddf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9afdbde777..4ff4105cd8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/af6ff0bdef..504fae9f10 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1fbada9f29 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1039f6ca14..cb17bc6028 * third_party/r8: 9JovxpDv8ZqFl60_eHo4hT-Ez0CelcMCoM9Cv5UJMz4C..gXyBDv_fM87KnLcxvF5AGV5lwnm-JXIALYH8zrzdoaMC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/eb9ce8c993..618ddecd59 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dbcffda598..e76c8f17cf * tools/luci-go: git_revision:91769f0e2541d15de294dfc780205e98b49f7431..git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2 * tools/luci-go: git_revision:91769f0e2541d15de294dfc780205e98b49f7431..git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2 * tools/luci-go: git_revision:91769f0e2541d15de294dfc780205e98b49f7431..git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d9766067a3..df10bb0bf8 * tools/skia_goldctl/linux: UV02xIZDvNaCcrummY2Hd5zNO4S7F3pl_ZatqFmeRboC..EWfIod1MP71b48GlHnS5Rv9JpBzeTRQ6viIPDfFUSFEC * tools/skia_goldctl/mac: aG3drSoyskf8FOxdSDXo_p3ub85yK9mX_DmXJa605cUC..5o7ziB6qRrSdtYJwKop8-5OFmvVQcxuNkGY1DRYggMsC * tools/skia_goldctl/win: OB_O_MOYSLYScAVrzlIsc9a0JIf54AiYzG1WNNSCtyIC..O2WsBEJgyjTsib6LvzoNqqXwfSylJFfTRxEKYr-IsocC No update to Clang. Bug: None Tbr: timvp@google.com Change-Id: I70f2c157f5165905a9d3aca98dfccb7768b87d0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885448 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2ba3763e 2021-05-10 10:08:27 Capture/Replay: reset CWD after the test ends As suggested by Jamie Bug: angleproject:5849 Change-Id: I3e548935a9119b7ca7ca392c50bcb0f58ae3e974 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2882578 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
2e84e59a 2021-05-10 17:37:28 Skip EndWithDifferentProgram() on Vulkan+Pixel 2 Skip the the test TransformFeedbackTest::EndWithDifferentProgram() on Vulkan + Pixel 2 since it appears to be flaky. Test: TransformFeedbackTest::EndWithDifferentProgram() Bug: chromium:1207380 Change-Id: Iedfe1e96a204eca5954097be9e61820b775eb0b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2886358 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
caf9742d 2021-05-10 11:45:58 samples: Use rpath on Linux/ChromeOS. This will allow us to load ANGLE libraries without needing LD_LIBRARY_PATH. Bug: None Change-Id: Iaa389b3a42fed37216e175bee080a9f8fde3eb0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2884418 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
0639f7a9 2021-05-10 13:24:41 Check angle_has_build before including runtime_deps. This target doesn't exist in Skia. Bug: angleproject:5940 Change-Id: I0095b771c0d57ec45bfd9294962c540d70679e6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2884700 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
913bc473 2021-05-07 11:37:01 Tests: Add --fixed-test-time option Similar to --max-steps-performed, don't do any calibration and just run flat out for a fixed amount of time. Also rename --test-time to --max-trial-time to reflect what the parameter actually does, limiting each trial to a ceiling. Also remove a redundant check in doRunLoop. Test: angle_perftests --fixed-test-time 20 Test: angle_perftests --max-trial-time 2 Bug: angleproject:5935 Change-Id: I854799a734cd6c019399f5a1444b4ef5f659ddf4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878937 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
74177f31 2021-05-09 21:15:09 Tests: Run Android tests fullscreen In order to hide the status bar and hopefully prevent any layers from rendering on top of our traces, make all Android tests run fullscreen. Test: angle_perftests Bug: angleproject:5937 Change-Id: I649104a7d95b7f056b411e180632524a85b7c4f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880335 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
daeac238 2021-05-08 22:09:38 Translator: Ensure structs and blocks are uniquely defined A new AST validation is added to ensure that the same TStructure or TInterfaceBlock is not redundantly defined. This helps with SPIR-V generation by allowing the id to be used as key in a hash map that looks up the corresponding SPIR-V type id. A bug is fixed where the Vulkan driver uniform declaration created two identical declarations for ANGLEDepthRangeParams. A number of other bugs are also fixed in this change, where if a variable declaration is eliminated (for example due to constant folding, or inactive interface variable removal) and it contained a struct specifier, the struct declaration was also removed. OutputGLSLBase had a hack where structs were declared on first encounter, which was incorrect as the scope of the declaration could change. Those bugs are fixed and this hack is removed. Bug: angleproject:2733 Bug: angleproject:4889 Bug: angleproject:5936 Change-Id: I8e13748c0bf552ae8b052249282769a1f0775603 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2881942 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
84d22197 2021-04-26 17:11:27 Vulkan: Add device local fallback in findCompatibleMemoryIndex(...) When finding a compatible memory index for an external buffer, we need to have a fallback path that requires just the VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT property. Bug: angleproject:5909 Change-Id: Id3faffb3e357be2e5e6f5fce9e64f0f2889d199a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862561 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
417d912a 2021-05-05 18:20:27 Remove Settings GUI from AOSP Builds and make product-specific The Settings GUI is being removed from the AOSP build to turn the ANGLE APK into essentially a container APK containing the necessary libraries. This reduces the APK size and reduces the risk of users enabling ANGLE by accident. Additionally, ANGLE is being marked product-specific to remove it from all AOSP builds. Bug: b/187345862 Change-Id: I6e1acb9c6e07b419d40aee43d7260060027999ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876213 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
91429bb1 2021-05-04 18:13:39 infra: Remove duplicated trybots from the CQ. Removes duplicate Linux, Win and Mac testing. These are superceded by the standalone bots now. Android is still entirely Chromium-based. Bug: angleproject:5114 Change-Id: I745758547b2eaa5f82779b11e7f3a8512c3cdd94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2872072 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
d6fc7cb0 2021-05-10 10:01:15 Roll SwiftShader from e839645bb9a6 to e260190edbd2 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/e839645bb9a6..e260190edbd2 2021-05-07 sugoi@google.com Obtain all sampler parameters through SamplingRoutineCache::Key 2021-05-06 swiftshader.regress@gmail.com Regres: Update test lists @ 04c037ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I4d1a116358713f00ebd92d78ddb62e0a7b47baf6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2883237 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
16337b86 2021-05-10 10:43:18 Roll vulkan-deps from 13d25088cdc6 to d3354ebca460 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/13d25088cdc6..d3354ebca460 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/41e39c615b..9431c53c84 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/72a2ec4c1b..418542eaef * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/3f437c4a94..9af411e83f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/157c4bfe15..5ef1ec1b87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I1d9cf668527a0d1e7f31ab2e212bebcd42fbcbeb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2883081 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
8707d240 2021-05-10 07:01:05 Roll Chromium from 5f1f8ce65c68 to 518c3462c0a9 (330 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5f1f8ce65c68..518c3462c0a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7ca66f4b1c..9afdbde777 * buildtools/linux64: git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5..git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810 * buildtools/mac: git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5..git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/5f51521620..767de317f9 * buildtools/win: git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5..git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ce51767483..af6ff0bdef * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..98fd7ff368 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/360f981956..1039f6ca14 * tools/luci-go: git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d..git_revision:91769f0e2541d15de294dfc780205e98b49f7431 * tools/luci-go: git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d..git_revision:91769f0e2541d15de294dfc780205e98b49f7431 * tools/luci-go: git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d..git_revision:91769f0e2541d15de294dfc780205e98b49f7431 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I3d7b01d99898b9a087e62d4ec65a21837a7cb9cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2882480 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
c0d42fd9 2021-05-06 14:44:24 TracePerfTest: Delete offscreen objects only when initialized. Delete Textures, Renderbuffers and Framebuffers that were created in the SurfaceType::Offscreen case, when they were initialized. This caused a crash when replaying traces using GLES 1 contexts on native GLES Android implementations. Bug: angleproject:5932 Change-Id: Ice4bcec620a6c3530044986ce39230b030a901ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877234 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
a83fe36d 2021-03-09 12:51:27 Capture/Replay: Add GLES1 test expectations. Add failing OpenGL ES 1.0 capture / replay tests to expectations list. The remainging 65 test pass on ES1 SwiftShader. Test: python3 src/tests/capture_replay_tests.py --gtest_filter="*/ES1_Vulkan_SwiftShader" Bug: angleproject:5751 Change-Id: If5157a3ac0ccebc904316ae08c54e670119384e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877233 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
d1da88ee 2021-04-28 14:23:48 samples: Add TorusLighting sample. Add a vertex buffer example for GLES1 and 2. Bug: angleproject:5751 Change-Id: If039451ff85dfffd8915497e9aaaab6e4ff71181 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859827 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
bca7c408 2021-05-09 15:09:45 Update entry points for GL_EXT_texture_sRGB_RG8 Bug: angleproject:4932 Change-Id: Ie210a9dd342581adb71af4782383be2bb3ffd6a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880667 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
78fb9314 2021-04-29 18:05:12 FrameCapture: Capture GLES1 vertex buffer pointers. CaptureVertexPointerGLES1 was expecting only client-side vertex arrays and not checking whether a vertex buffer was bound. This patch fixes offsets in vertex buffers for GLES1, which can be seen in apps like Dr. Driving. The mClientVertexArrayMap index is now retrieved by entrypoint name, as the arrayClientPointerIndex is unset in the vertex buffer case. Bug: angleproject:5751 Change-Id: If40cae56bcdbed57885e83c49291cb000a884b0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859826 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
d469dcb1 2021-05-06 15:13:42 Translator: remove image2DRect There is no such thing as image2DRect in GLSL. imageRect (the right type) is present, but the code was mistakenly using image2DRect. Bug: angleproject:4889 Change-Id: I42bacd2ad8866c715af0d9711bebc95897607354 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878095 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
7828506a 2021-04-06 23:42:16 Vulkan: Cleanup buffer format fallbacks - Fallbacks for formats that have required vertex attribute support are removed. - Fallbacks are changed to ones with smaller sizes - A bug is fixed where CopyNativeVertexData wasn't initializing the alpha channel appropriately, which was not exercised due to fallback to 32-bit float formats. Bug: b/184163871 Change-Id: Icd9afa49d94c65545d1f3fcf521881726d64529d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809441 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
730bbcbb 2021-05-06 11:36:14 Use ANGLE GL for Lacros Chrome Currently, no ANGLE platform flag is enabled for Lacros Chrome. GL is selected as default by this change for ChromeOS in general. Based on change by Eriko Kurimoto <elkurin@chromium.org> Bug: chromium:1203176 Change-Id: I539a459b6d3db60da191570e933afd8d06d3c3eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877010 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
b33a8279 2021-05-07 20:31:47 Roll Chromium from f4228a4b663d to 5f1f8ce65c68 (809 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f4228a4b663d..5f1f8ce65c68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a5d4757ed0..7ca66f4b1c * buildtools/linux64: git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e..git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5 * buildtools/mac: git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e..git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5 * buildtools/win: git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e..git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7359f2c06d..ce51767483 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c92267a4b7 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5009fd68ac..360f981956 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/24e310554f..b7bef8c05b * tools/luci-go: git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273..git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d * tools/luci-go: git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273..git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d * tools/luci-go: git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273..git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9c6e20569c..d9766067a3 * tools/skia_goldctl/linux: qFSgTPN6Qn1vdxIOe4gDnS7rsfvJpQ63e0fEOHdwwK8C..UV02xIZDvNaCcrummY2Hd5zNO4S7F3pl_ZatqFmeRboC * tools/skia_goldctl/mac: wEpZZg5Ap8EImS0KyVLAaILjjArMqHjI4T4y2MKKd5MC..aG3drSoyskf8FOxdSDXo_p3ub85yK9mX_DmXJa605cUC * tools/skia_goldctl/win: kT3OqAqb0i8bSfls2rf77GfIiw0YSfqm97knAwMxkCcC..OB_O_MOYSLYScAVrzlIsc9a0JIf54AiYzG1WNNSCtyIC No update to Clang. Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: I0ec0452805b7872f52ca997bb83f4ca8adcbc739 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878570 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
2d5df9d9 2021-05-01 12:50:55 Vulkan: Don't assume host visibility for external buffers When importing external buffers, Vulkan ICDs could choose to import the memory into a memoryType that doesn't support the VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT property. Account for this possibility. Bug: angleproject:5073 Bug: angleproject:5909 Change-Id: Ied063b38fa48d0c8508c4aaca9214cc526f393ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2783669 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
e61909f6 2021-05-06 15:12:08 infra: Re-enable swarming tests. Changes since the revert: - Include runtime_deps: http://crrev.com/c/2878093 - Add missing perf scripts: http://crrev.com/c/2877011 - Include build_properties: http://crrev.com/c/2878373 Bug: angleproject:5114 Change-Id: If7d1e5693c4ade72d3f45f5d60635cb27de7599e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877012 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
39ba247d 2021-05-06 18:06:01 Remove redundant OpenCL ICD library Removed redundant OpenCL ICD library, using regular OpenCL library instead. Bug: angleproject:5908 Change-Id: I1ecf5347557106511aed3c5c4a4bfa35590a559a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877240 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: John Plate <jplate@google.com>
abab4739 2021-04-28 12:30:12 capture_gles_1_0: Implement ES1 capture functions. Capture glLight, glLightModel and glMaterial and adjust size by enum. Bug: angleproject:5751 Change-Id: I2fcf35575e344703033bf426c3ed0046dfe93337 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859825 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
cc3e7b5d 2021-04-26 14:26:29 Vulkan: Handle GL_MAP_PERSISTENT_BIT_EXT for external buffer When user specifies GL_MAP_PERSISTENT_BIT_EXT bit for an external buffer but we are unable to import it into a memoryType that supports host visibility, error out with GL_INVALID_OPERATION error. Bug: angleproject:5073 Bug: angleproject:5909 Change-Id: I03e5477266dfb705bfb0a1bce5ca003049ef4c7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862560 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
eb6548bb 2021-05-06 15:12:07 Add missing perf results merger scripts. While waiting for the git mirror to become available we need to clone these scripts into ANGLE. These scripts are required for the merge step to work properly. Bug: angleproject:5114 Change-Id: Ie917149972c8339419b1e3a6d0cf6712fb9888d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877011 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
81f03cc0 2021-04-07 15:23:32 Allow translator to use headers from common/spirv Bug: angleproject:4889 Change-Id: Ia297888a97c0ba9cec1283db7f94f2e5b362c27e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815179 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
08805e35 2021-05-06 15:12:37 Explicitly include "runtime_deps" on Windows. For applications and tests, we need the runtime deps for component builds. It still like this omission was causing test failures on Intel in standalone. Bug: angleproject:5114 Change-Id: Ifd9e90b28f985e4d2d1392a97ecb75907290f5ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878093 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
fc0c8d18 2021-04-27 16:58:50 Vulkan: Honor mapRangeImpl and unmapImpl abstraction All BufferVk methods need to honor the abstraction provided by mapRangeImpl and unmapImpl. Do not map BufferVk::mBuffer directly, this is needed for when we support device local buffers that cannot be CPU mapped. Bug: angleproject:5909 Change-Id: I520e5cc0994560a3784b8978e349550211dc2cde Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862559 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
cffd5d87 2021-05-06 16:14:15 Roll VK-GL-CTS from 9698f0db4cd5 to dab93ea8f88c (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9698f0db4cd5..dab93ea8f88c 2021-05-06 alexander.galazin@arm.com Merge pull request #261 from Joshua-Ashton/mingw-support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ianelliott@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com,angle-bots+autoroll-info@google.com Change-Id: I51fd5c99bf9ae6e0c4542543137c020b8c6cef2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876681 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
c59b9a33 2021-05-05 16:05:06 [Fuchsia] Disable Vulkan validation Vulkan is being updated on Fuchsia. Disable validation to unblock it. Bug: fuchsia:73208 Change-Id: I8a6eecc16ef021d379cfcca8795896a6e6dae11c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876070 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
dc92d881 2021-05-04 09:56:50 Add warning messages for not (yet) supported CL commands Bug: angleproject:5904 Change-Id: I24e6a4d5cf4cc824751ff45e962bee16489fdbdd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2871450 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1572c372 2021-05-06 09:55:30 infra: Temporarily disable all swarming tests. There seem to be some unusal failures on CI. Maybe Try as well. Bug: angleproject:5114 Change-Id: Ia681d6fdb8575b851dd526c1ab9463ad047735c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875767 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
c75969e1 2021-05-06 13:37:54 Revert "Temporarily remove standalone tester bots from CQ." This reverts commit 8f26346b53d9f818996af8da1421af89cf69caaa. Reason for revert: Should be fixed by updated exclusion spec. Original change's description: > Temporarily remove standalone tester bots from CQ. > > Due to RECIPE CRASH, e.g. > https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/21245/overview > > No-try: true > Bug: angleproject:5114 > Change-Id: I42f76fb370ee5423430955643bffb8c2204fa25f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875717 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:5114 Change-Id: I781a5a409a9ede005feaf0f3d7bcedac31eaa036 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876986 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
aa19de17 2021-05-06 09:32:07 infra: Fix exclusion spec JSON. The extra comma caused the CQ to fail reading the file. Bug: angleproject:5114 Change-Id: I5d36f1ae7c4dc5ebcb5599d5cd37471ee4085990 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876985 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
dfe208f1 2021-04-28 18:26:00 Add loader for CL pass-through back end Bug: angleproject:5904 Change-Id: If4960f3150f6bbc85a30f0f6ac5c9e668e6ff756 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2864022 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
1f8ba8d3 2021-05-06 09:15:15 Roll VK-GL-CTS from 476acb91ebc2 to 9698f0db4cd5 (14 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/476acb91ebc2..9698f0db4cd5 2021-05-05 alexander.galazin@arm.com Re-apply CL 7106 2021-05-05 siglesias@igalia.com Fix fallthrough compiler warning 2021-05-05 mika.vainola@siru.fi GCC 11 build fixes 2021-04-23 boris.zanin@mobica.com Augment binding tests to test acceleration structure descriptors 2021-04-23 tapani.palli@intel.com Fix to GL 4.5 geometry shading point size tests 2021-04-23 ari.suonpaa@siru.fi Added tests for OES_EGL_image_external 2021-04-23 ari.suonpaa@siru.fi Fix EGL AHB util build issue 2021-04-23 tapani.palli@intel.com Choose linear tiling when dmabuf is used in synchronization tests. 2021-04-23 venni.ihanakangas@siru.fi Update a batch of graphicsfuzz tests to include SPIR-V TARGET_ENV 2021-04-23 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-glk-cts/master 2021-04-22 michal.jakubek@mobica.com Tests for image OpImageWrite on mismatched signedness and type 2021-04-22 piotr.byszewski@mobica.com Fix linking on MacOS 2021-04-21 alexander.galazin@arm.com Update glslang, SPIR-V Tools/Headers 2021-04-19 alexander.galazin@arm.com Update Vulkan headers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ianelliott@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com,angle-bots+autoroll-info@google.com Change-Id: I2d0d8c43add5c8a9bf593353a4a1c9a341fcbbec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876733 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
3ae848ec 2021-05-06 10:01:16 Roll SwiftShader from 484a3e15893c to e839645bb9a6 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/484a3e15893c..e839645bb9a6 2021-05-06 sugoi@google.com Revert "Obtain all sampler parameters through SamplingRoutineCache::Key" 2021-05-05 srisser@google.com Implement depthClamp 2021-05-05 srisser@google.com Implement VK_EXT_depth_clip_enable 2021-05-05 sugoi@google.com Obtain all sampler parameters through SamplingRoutineCache::Key 2021-05-05 sugoi@google.com Obtain ImageView state uniquely from its identifier If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I8d185e83749524e9d2710fc6ecd7a3db9524ea30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875860 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
01b05333 2021-05-04 18:12:25 queryutils: Handle AmbientAndDiffuse param count. Add AmbientAndDiffuse cases for determining light and material parameter count. Define default cases as UNREACHABLE for GetLightModelParameterCount, GetLightParameterCount and GetMaterialParameterCount. Bug: angleproject:5751 Change-Id: I58acb62e66cea71277654313800dafa57c42b17e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2871794 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
c034d045 2021-05-06 10:01:18 Roll vulkan-deps from bc5a26253bb7 to 13d25088cdc6 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bc5a26253bb7..13d25088cdc6 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5dcea8a449..039cea5353 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0e7f7a9e10..157c4bfe15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I6f8ee92822ad794f23b922acd71dc83d6462a8e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876737 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
66585b82 2021-05-06 07:40:54 Roll Chromium from 2270e13321c2 to f4228a4b663d (543 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2270e13321c2..f4228a4b663d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/85859d61bc..a5d4757ed0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/069528e565..7359f2c06d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/adc89c7364..93eae7d9dc * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5185110bf9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6b022d1efb..5009fd68ac * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ae0aa94845..9c6e20569c No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: If77a49b5830c9346369e9e179b8a1c20ea6791a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876602 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
69d593b5 2021-05-05 14:21:22 Docs: Update RenderDoc for Android launch command Bug: angleproject:1944 Change-Id: I72535c45ea2a67f2fe6953d4b9fa5e60deaa050b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875164 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
8f26346b 2021-05-05 22:15:34 Temporarily remove standalone tester bots from CQ. Due to RECIPE CRASH, e.g. https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/21245/overview No-try: true Bug: angleproject:5114 Change-Id: I42f76fb370ee5423430955643bffb8c2204fa25f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875717 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
bcf9ffa5 2021-05-05 19:11:04 Revert "Use ANGLE GL for Lacros Chrome" This reverts commit b62f8dd1164a7486646ad9281ffd6f02aa926e1c. Reason for revert: Breaks skia roll. See https://ci.chromium.org/raw/build/logs.chromium.org/skia/535503ce58f24311/+/annotations Original change's description: > Use ANGLE GL for Lacros Chrome > > Currently, no ANGLE platform flag is enabled for Lacros Chrome. > GL is selected as default by this change. > > Bug: chromium:1203176 > Change-Id: I7f810c496dc1806c030e7292a319624d45c33fa1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851829 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: chromium:1203176 Change-Id: I82b50a9fb57ffb9a6d9112d1a07f3b03775c5bcc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875350 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
0fb204bd 2021-05-05 17:55:37 infra: Exclude infra/specs from analyze. This will force any changes to the infra/specs folder to trigger a full set of tests on a builder. Bug: angleproject:5114 Change-Id: Ie640b52dd7f12163d0c91843d80dbab7f33209d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875356 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
db670c82 2021-05-05 17:12:58 infra: Enable dcheck_always_on in Release. This will assure that ANGLE ASSERT macros work in Release. Bug: angleproject:5114 Change-Id: I0fe6b83592ac3ff3462e55b8a73a11c8f114a4a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875355 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
167480cc 2021-05-05 17:05:55 infra: Switch CI to use component builds everywhere. This makes the build the same as the Chromium-based configuration. This also works around a problem with the Mac bots where the shader cache workaround isn't operational in non-component builds. Bug: angleproject:5114 Bug: angleproject:5928 Change-Id: Ib466942f4a69e1ba3e61e078c84d74d0b54bb396 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875354 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
18c9aa0d 2021-04-29 15:25:32 Run test spec update as part of codegen. Test specs now will be updated when the Chromium build files change. It will be automatically included as part of the Chromium->ANGLE roll. Bug: angleproject:5114 Change-Id: If99c2a20033d417a5999295f425a3bb203f5da3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2860962 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
a16aea95 2021-05-05 14:05:34 Fixes to roll_chromium_deps.py. Includes the new sheriff email alias, and also fixes to the Clang version detection. The new version checks the CopyBara mirror to find the real clang rev ANGLE ends up with. Bug: angleproject:5926 Change-Id: Ie70319feeb5eefbfba8a6b6d2d57110273d6c3e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2872070 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
167a4b6d 2021-05-05 13:42:44 infra: Add Linux isolated scripts to specs. We were missing the perftests and Gold tests from Linux Intel/NV. Bug: angleproject:5114 Change-Id: I1cfc0963b3890c621f0646bb5879e47ea6d336a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873457 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
e2c87b4f 2021-05-04 11:46:36 Fix Vulkan-only build The translator_gl_d3d_only target cannot build if neither of the gl or d3d backends are built. This target is used by Chrome's validating command decoder only. Bug: angleproject:5922 Change-Id: Ibebae6d6aa78ad88498a727d3b0e1695bb110535 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2871969 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
adc9033b 2021-05-05 02:13:10 Roll Chromium from e9e6d55fed07 to 2270e13321c2 (399 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e9e6d55fed07..2270e13321c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/153efb2bc3..85859d61bc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/db10e8b046..069528e565 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d4ee032a15 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/029279376e..6b022d1efb * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/84ada2da16..dbcffda598 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c08b1fc7ae..ae0aa94845 No update to Clang. No-try: true Bug: chromium:1199451 Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: I307bdafb592fac023dcac181e525f354b1574990 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873070 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
ab3b50bc 2021-05-03 21:17:14 [infra][realms] upgrade to LUCI security realms in all Angle builds. To be landed after ~1 day at 25% if all is well. Change-Id: I106add7cc9103bde8d77a1c61438ad0fcb54a7b3 Bug: chromium:1204972 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867636 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
fdb376ea 2021-05-03 14:58:09 Vulkan: minimize-gpu-work: Skip blit from offscreen fbo Since we only care about driver state tracking logic, blit is unrelated here. This further reduce the noise of test result. Instead of blit and swap every N frame, we will issue glFlush for offscreen rendering. The onscreen will still issue swap every frame. Bug: b/186881553 Change-Id: Id048eaafa6dcef26d851fd19f069331d240e1bf5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846527 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
3fc83291 2021-04-29 19:03:27 Vulkan: offscreen perftests: use two FBOs and call glFlush every frame For offscreen variant of perf tests, we blit from offscreen to onscreen for every frame and then every N frames we call swap. Right now we never call glFlush. This causes test accumulate many frames rendering without a flush, which changes the behavior. For example, gfxbench does issue glFlush for every frame. This CL adds glFlush call for every frame when swap is not called. Also ARM native GLES driver and ANGLE skip glFlush call if it is issued within the same FBO. For some traces that does not use any FBO, there is no frame boundary for drivers to detect, versus for onscreen there is actual frame boundary. To solve this mismatch problem, this CL also uses two offscreen FBOs and ping pong between them so that it will still have the frame boundary but not goes to screen. This allows drivers that try to detect frame boundary still function properly. Bug: b/184766477 Change-Id: I23edda66fdf391930afd3f6b1d955b41ec6ad019 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2861844 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
b62f8dd1 2021-04-27 06:22:57 Use ANGLE GL for Lacros Chrome Currently, no ANGLE platform flag is enabled for Lacros Chrome. GL is selected as default by this change. Bug: chromium:1203176 Change-Id: I7f810c496dc1806c030e7292a319624d45c33fa1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851829 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
5d5e4bb9 2021-05-04 10:01:04 Roll vulkan-deps from 4676514cf188 to bc5a26253bb7 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4676514cf188..bc5a26253bb7 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/56b17b2f2d..41e39c615b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8ec9f456e6..1020e394cb * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/884579ec29..0e7f7a9e10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I32a50e5b5dd8083bb9c3d7d243b425cabe40ceda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2871391 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
99beb97a 2021-05-03 16:54:11 Vulkan: Fix MAX_VERTEX_OUTPUT_COMPONENTS limit gl_Position is excepted from contributing to MAX_VARYING_VECTORS, which is taken into account when calculating this limit based on Vulkan limits (which don't have such an exception). This exception was mistakenly also being applied to other limits such as MAX_VERTEX_OUTPUT_COMPONENTS. Bug: angleproject:5916 Change-Id: I394761efa02d3093741d2bff21023daf997e5e69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2869145 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
9655de62 2021-05-04 08:29:43 Roll Chromium from 34166dd37ed5 to e9e6d55fed07 (345 revisions) https://chromium.googlesource.com/chromium/src.git/+log/34166dd37ed5..e9e6d55fed07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c0a55af977..153efb2bc3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5da6005cc9..e72cd4587a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cdfd5533e4..db10e8b046 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..785c56fc0f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f663e54338..029279376e * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e8da4daa81..eb9ce8c993 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I0809d05fb2c6331054d3f9167675ecb0154317fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2871390 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
f45dad5e 2021-05-03 11:05:23 Capture/Replay: Enable test for CopyTextureTestWebGL.NPOT Bug: angleproject:5850 Change-Id: I5a8e3ebf6d220251a76f8a428b959b226dca2ca0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867077 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
39cef942 2021-04-27 08:28:13 Capture/Replay: capture WebGL compatibility With that we can also enable the tests DifferentStencilMasksTest.* Bug: angleproject:5851 Change-Id: If2c992e456716f606320e3992f389823d0af050f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2853584 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
c6fb0e5a 2021-05-03 16:29:17 Roll Chromium from ae499a6ea7cf to 34166dd37ed5 (607 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ae499a6ea7cf..34166dd37ed5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f105bbfeaa..c0a55af977 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/791177086b..cdfd5533e4 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/a81066b46b..2000d0a880 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a934af8883 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d1afc9729..f663e54338 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ba668f13d1..84ada2da16 * tools/luci-go: git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155..git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273 * tools/luci-go: git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155..git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273 * tools/luci-go: git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155..git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4dbf0676ae..c08b1fc7ae * tools/skia_goldctl/linux: tB-aCGPgfoZoJkUY-FwC5e0McBlS1VYtKsDpf5G42GUC..qFSgTPN6Qn1vdxIOe4gDnS7rsfvJpQ63e0fEOHdwwK8C * tools/skia_goldctl/mac: 010YBDimThQHTBULjf4bYMXghL37h6xogw08_Ij5RrMC..wEpZZg5Ap8EImS0KyVLAaILjjArMqHjI4T4y2MKKd5MC * tools/skia_goldctl/win: PtSSNrSR0okAf8Q4RMYxK1dSmKxaw9jqoyxdNvNzOqwC..kT3OqAqb0i8bSfls2rf77GfIiw0YSfqm97knAwMxkCcC No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I6c0a38409309e816102631d755ad5341400a0ff7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867487 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
83a1a385 2021-05-03 12:42:05 infra: Add trybot_analyze_config. This file is used to specify ignores and excludes for analyze. Initially only contains DEPS. Whenever a file in exclusions is changed, we'll run the entire CQ instead of only the affected tests. Bug: angleproject:5114 Change-Id: Ie7328604f5ee56288f992710d5c3dbc559e6d9a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867886 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
dd4564ca 2021-05-03 17:36:28 [infra][realms] bump usage to 25% of all builds. Change-Id: I106add7749103bde8d77a1c61438ad0fcb54a7b3 Bug: chromium:1204972 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867633 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
57202fb0 2021-04-30 13:56:11 Fix Rolling ANGLE into AOSP Rolling ANGLE into AOSP currently generates several build errors. This CL fixes them. Bug: angleproject:5919 Bug: angleproject:5873 Change-Id: Ic24c3c27a2dd3a1db4d6d2e3642eb1b16148569a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2863883 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
05fb2272 2021-04-27 19:31:31 Add support for OpenCL ICD Loader Bug: angleproject:5908 Change-Id: Idafc0d15b69f9a21f2ab5e48c4c34f0dc0e0ee96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854598 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: John Plate <jplate@google.com>
bcae4fe1 2021-05-03 15:07:05 Roll vulkan-deps from c5559fe406e3 to 4676514cf188 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c5559fe406e3..4676514cf188 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7ab4afe505..884579ec29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com,syoussefi@google.com Change-Id: If43cecb9faae73c1ce83a9b5b4205fda03efd1bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867786 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
03a9bf1e 2021-05-03 17:14:19 [infra] use realms on 5% of Angle builds. All swarming tasks triggered from realm-enabled build will be realm-enabled, too. This CL is safe to revert in case of problems. The problems, if any, should not affect CQ badly due to retries, but on CI they'd probably manifest as purple builds that won't be retried without human involvement or new Git commit. Change-Id: I106a587749103bde8d77a1c61438ad0fcb54a7b3 Bug: chromium:1204972 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867083 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
32ed5069 2021-05-03 17:08:02 infra: init LUCI Realms config for Angle. This doesn't yet have any effect on Angle builds/tasks, but allows to associate Angle pools with the Realms config in https://crrev.com/i/3802849 Change-Id: Id756c14e7e181cc1820cee735668949bf9567d0c Bug: chromium:1204972 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867082 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
de3753d4 2021-05-03 17:05:37 infra: validate configs using lucicfg tool in PRESUBMIT.py This validates that: a) checked in generated files correspond to what lucicfg actually generates; b) lucicfg is formatted c) (same as before) configs are validated against respective LUCI services. Change-Id: I727723beb4172c3dd265c4a4edbc2ecbfb479eb9 Bug: chromium:1204972 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867081 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
471e62c8 2021-05-03 12:23:17 infra: remove redundant ACL. Bug: chromium:1204972 Change-Id: If3ab89699adfc47d0a163f8b999da17b10d86ebd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867079 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
4ab224f7 2021-04-30 15:07:44 infra: Always checkout swarming_client in standalone. This repo is needed to trigger and wait for swarming tests. Bug: angleproject:5114 Change-Id: I02b5da49cb0f12e1189ddf56c8f1b7348bb9bd45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862927 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
23ff18f9 2021-04-30 16:45:04 Roll vulkan-deps from 42d8716d0294 to c5559fe406e3 (24 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/42d8716d0294..c5559fe406e3 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/18eef33bd7..56b17b2f2d * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/c624d5387c..72a2ec4c1b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/22b82872b4..8ec9f456e6 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/074fa3055c..3f437c4a94 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/d0f1abe22e..5dcea8a449 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/eb3d67bd17..4ee5f2a8be * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f6b4a3dea4..7ab4afe505 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:5905 Tbr: jonahr@google.com,ynovikov@google.com Change-Id: I462413910900b8dc38b3e88b78d9ff2e10b103b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2863562 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
a4588e33 2021-04-29 14:24:20 Vulkan: Disable logMemoryReportStats if driver extension not exist logMemoryReportCallbacks and logMemoryReportCallbacks features are useful for memory debugging. But they rely on VK_EXT_device_memory_report extension. Right now if this extension is not there and you enable the log, you still see the logs but everything is all zero. This CL will disable the feature and print out warning message if the extension is not supported. Bug: None Change-Id: I478ae0ac7ba1ee43245a9fd8a3f1d9907f5d833c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2861310 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>