kc3-lang/angle

Log

Author Commit Date CI Message
Jamie Madill 2265e37b 2022-10-12T09:27:16 Capture/Replay: Auto-generate EGL capture code. Replaces the custom code in the EGL stubs. Skips a few "Get" entry points because this CL doesn't implement pointer capture like we do for all the GL entry points. Includes a new state in the AttributeMap that indicates which type of attribute values we used when initializing the map. Bug: angleproject:4035 Change-Id: I272eac5e4068602ce710ef66c9a1dce5387943a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3949911 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 7c4dc253 2022-10-12T08:38:46 Capture/Replay: Clean up EGL capture. This switches the EGL capture types to ANGLE-casted pointers since that's what we receive in the capture layer. Note that even if the capture layer were used as a pure layer, not an EGL implementation, we'd still have these types for state tracking. This also prefixes each EGL class in the entry points with the egl namespace for consistency and for simplifying the ParamType code. Required changing to non-const gl::Context * in a few places. Also changes the gSurfaceMap to be indexed by the raw pointer value, which cleans up the code somewhat. Bug: angleproject:4035 Change-Id: Id800c1ba25e5819ac7ea1df8aab806bc393fe192 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3949910 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Greg Schlomoff 0a4a7ea7 2022-10-13T17:58:18 Make ANGLE's Worker Pool actually pool the threads. When starting a lot of short-lived tasks, this increases performance by over 70 times on my machine. Old code, decoding a 16x16 ASTC texture with 8 threads: *RESULT AstcDecoderPerfTest.cpu_time: run= 2,847,708 ns *RESULT AstcDecoderPerfTest.wall_time: run= 1,841,014 ns New code: *RESULT AstcDecoderPerfTest.cpu_time: run= 81,602 ns *RESULT AstcDecoderPerfTest.wall_time: run= 27,088 ns Bug: angleproject:7757 Change-Id: Ib643405675c50b2ed8ccd24d6caa7e57335130e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3953905 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Greg Schlomoff <gregschlom@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao e8f9355c 2022-10-13T16:51:32 Vulkan: Add forceWaitForSubmissionToCompleteForQueryResult flag Add forceWaitForSubmissionToCompleteForQueryResult feature flag and enable it for ARM. Also force host wait if async submission is enabled. Bug: b/253522366 Change-Id: Ie2d7373930f1a2b3fc761d2f8d2df8fa84983c54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3954044 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 72894f42 2022-10-14T18:27:07 Roll VK-GL-CTS from 7aaf3aef809d to bfc5b6f54270 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7aaf3aef809d..bfc5b6f54270 2022-10-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main 2022-10-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main 2022-10-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main 2022-10-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main 2022-10-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/github-main into vk-gl-cts/main 2022-10-14 ziga@lunarg.com Fix uninitialized variable in multisample clear attachments tests 2022-10-14 aitor@lunarg.com Add remaining div by zero tests 2022-10-14 ziga@lunarg.com Add tests with primitive restart with no restart index 2022-10-14 zzoon@igalia.com Add tests for VkImageDrmFormatModifierExplicitCreateInfoEXT 2022-10-14 rgarcia@igalia.com Fix build on main branch 2022-10-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I7935ed36082d8571aa2e29cd7021b31f0b7a513d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3956122 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 19fb11b6 2022-10-14T11:12:20 Vulkan: Merge warmed up compute cache into renderer It was done for graphics, but was accidentally missing for compute. Bug: angleproject:5881 Bug: angleproject:7629 Change-Id: I28a4c2e38b07b08e1636b443f2c0963130965ebb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3956496 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll b53970b6 2022-10-14T14:02:57 Roll VK-GL-CTS from f4ed7376e1da to 7aaf3aef809d (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/f4ed7376e1da..7aaf3aef809d 2022-10-14 quic_mnetsch@quicinc.com Merge pull request #360 from tomeuv/zlib-uprev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ifc000c175264d2c79d4b530ee1a37c5abfb91f62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3955960 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 7d76160b 2022-10-14T09:03:12 Remove GLES 1.0 conformance tests on Win/Intel. Now this test suite is causing timeouts. e.g.: https://ci.chromium.org/ui/p/angle/builders/ci/win-test/2637/overview Bug: angleproject:7750 Change-Id: I62c0ca237d7a0f618823fbe5ff15070c21a9cdd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3956495 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 09a1aec4 2022-10-14T08:59:07 Expand suppression for async timer tests. Flaking on SwiftShader as well. Bug: angleproject:7548 Change-Id: I419c602184c03141c75b21bf3a0b66d8b2a34303 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3956494 Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 10a0d021 2022-10-14T10:01:22 Roll SwiftShader from 6d0e2d57acf9 to ab3cb3f5416b (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/6d0e2d57acf9..ab3cb3f5416b 2022-10-14 sugoi@google.com Move the inner loop out of TestRoutine 2022-10-13 sugoi@google.com Add robustBufferAccess to PipelineCache::SpirvBinaryKey 2022-10-13 sugoi@google.com Add robustBufferAccess as part of PixelProcessor::States If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Id60e6bc2b8cef992d0e7fd9f7e0abef353fb9dd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3953330 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3ca4cde7 2022-10-14T10:01:02 Roll vulkan-deps from 3ff9f454761a to 18608d767af1 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3ff9f454761a..18608d767af1 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/ef6c9714a8..5755de46b0 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a88144de30..61187c4084 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/2446b5b849..e52fa1cf2d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c1afb7e157..78ce46e479 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I0046836694086151c77796546e3d5afb7e1f3548 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3955383 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 8e644365 2022-10-11T11:47:55 Vulkan: Rearrange state specification for pipeline libraries This change splits pipeline state setup based on whether the complete pipeline is being created or only a subset of it. However, no partial pipelines are yet created, that will be done in a following CL. Bug: angleproject:7369 Change-Id: Ife34c4bc39641ab8f06e7c78502f95a6bc16d15d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3949917 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 94b45181 2022-10-12T14:54:14 Vulkan: Rearrange graphics pipeline desc bits In preparation for use of VK_EXT_graphics_pipeline_library, the pipeline state is split in three contiguous regions: - Vertex input - Pre-rasterization and fragment stages ("Shaders" for short) - Fragment output There is some state that affects both Shaders and Fragment output, which is split and placed in between the two. This will allow the hash and compare functions to eventually access each of those pipeline subsets as a contiguous piece of memory. Bug: angleproject:7369 Change-Id: Iedc4cf15ed6c7fed6ba93039889fbf5dd191e041 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3949914 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 96bbc80b 2022-10-13T15:09:12 Restore default angle_gles1_conformance_tests Win Intel batch size Low batch size suspect for causing blue screen on this platform. Bug: angleproject:7750 Change-Id: I331f3aef22e313e318aeabb84b1277f4bf1678c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3953493 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 0b7f3f5e 2022-10-12T17:47:06 More robustness tests Similar test to what was introduced in https://chromium-review.googlesource.com/c/angle/angle/+/3943534, but for vertex and compute shaders. Bug: angleproject:7629 Change-Id: I743233136125358edb6a15760b1ece63c36d3f85 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3949915 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll a0fc6e43 2022-10-13T10:01:50 Roll vulkan-deps from 0386d7db7e59 to 3ff9f454761a (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0386d7db7e59..3ff9f454761a Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/89db4e1caa..ef6c9714a8 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a3350c0ff0..b53d3a6be3 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/0df9899602..98f440ce68 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ae08f71147..a88144de30 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d05c85054b..c1afb7e157 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I5b0c4e027ae3fb3ca4c78691b6650c94a93b19e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3949839 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8d719a66 2022-10-13T10:01:35 Roll SwiftShader from 48f7cb2ab354 to 6d0e2d57acf9 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/48f7cb2ab354..6d0e2d57acf9 2022-10-12 swiftshader.regress@gmail.com Regres: Update test lists @ 48f7cb2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ic96a547bf3b34e5c18276db6cd106b9e76834970 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3950348 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c75adc3c 2022-10-13T07:01:59 Roll Chromium from 2a6c105f6b8f to 0bc5f81b0765 (627 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2a6c105f6b8f..0bc5f81b0765 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/aa1e02dfa7..a07961eeea * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f4e35bb2e9..24fa2da896 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/ebf2d34001..64d36e572d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/849e53c238..9572e56a12 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/118a58005a..1111799723 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/27f289c474..88f6dc3118 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2eecb3e113..58c69ecc36 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4793433248 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/17cf81d90a..2c0a8c736a * third_party/r8/d8: z23wTHakTR_i93g5BoaHQuO_yWgLT-AAt0fjTqQm_YgC..tQcmB4wHWxamdPd8ix5IwMv8eBEbMBeN4vEtGjikDeQC * tools/luci-go: git_revision:a0624fca6d6e6fc1da6462ce0ee7678d4cc739d8..git_revision:9f65ffe719f73af390727d369b342c22fa37ea54 * tools/luci-go: git_revision:a0624fca6d6e6fc1da6462ce0ee7678d4cc739d8..git_revision:9f65ffe719f73af390727d369b342c22fa37ea54 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/20dd97665a..003fad096b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/28e985ae84..1d02fed28c * tools/skia_goldctl/linux: vMuEaxuoKcSgIEyacUY5YqByCP4RveJIid7OXrLUZnwC..N6uCjU9yuRs_YqzOLUOdwHsH-AYHQKQp4gidLlDHDesC * tools/skia_goldctl/mac_amd64: OKl2kxI6rF8oLCJQma7QhqQHTC_J3hMRKoAqyW4tqq0C..spR3Wh59oLDHcwMl_Aw4KX_h3c0G4xcOxQSi7KM8uNgC * tools/skia_goldctl/mac_arm64: pZmD81q5BF6lQcwTgrtJre8iXtofPubDLM8624rQKNsC..GBW03jFiyCg47tt4xFsQ4Qql_kYZm-A-ADSEmuqRCRIC * tools/skia_goldctl/win: 3IrV971Fn9UEAXu0UwL8cBBY3L8il5zi4Qjhvfa43TQC..UQplRaUw9FHcOfJNcDs_v_q1RgFiRQOm1YPonxadxu0C No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I4df3292490706e24cfd6af757095c724dcad9a3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3949586 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 460efa21 2022-10-12T10:01:14 Roll SwiftShader from acdfa394561f to 48f7cb2ab354 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/acdfa394561f..48f7cb2ab354 2022-10-11 capn@google.com Unplug SPIR-V instruction profiling support 2022-10-11 capn@google.com Unplug the shader debugging support 2022-10-11 capn@google.com Refactor GroupNonUniformArithmetic handling 2022-10-11 swiftshader.regress@gmail.com Regres: Update test lists @ acdfa394 2022-10-11 sugoi@google.com Recursively update dEQP files when running the daily change in Regres If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I57ca20176395b9d968ef2fd57915b8969416c37b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3948048 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 10e45613 2022-10-12T10:01:34 Roll vulkan-deps from 24053e9970b7 to 0386d7db7e59 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/24053e9970b7..0386d7db7e59 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1cecf91701..a3350c0ff0 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/cb519989cd..ae08f71147 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7625be6a26..d05c85054b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ia069065d02f7b4b8fc7393a39209e5dcd99a0ef0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3947946 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0f74cd0b 2022-10-12T08:06:26 Roll Chromium from 475715430cb8 to 2a6c105f6b8f (1733 revisions) https://chromium.googlesource.com/chromium/src.git/+log/475715430cb8..2a6c105f6b8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6b83819915..aa1e02dfa7 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b47f3d62c4..f4e35bb2e9 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/eddc4cee09..ebf2d34001 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/db2a783a7d..849e53c238 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/08ebcbe7b6..118a58005a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cdb43fc0b8..27f289c474 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/11566d5c44..94f1169192 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0dc9361cea * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/51a6576d1b..17cf81d90a * third_party/fuchsia-sdk/sdk: version:9.20221006.4.1..version:9.20221006.5.1 * third_party/r8/d8: IgKfK01VX-GA1mjxpHqq-7kL9VDb5qlXZnSW0Jtl6cAC..z23wTHakTR_i93g5BoaHQuO_yWgLT-AAt0fjTqQm_YgC * third_party/turbine: RXO2k7-PyXvbDjiK9EjbsheQfxXme2n0ABNX-MxR0JcC..rrpgWQ-uylo8c5IPgUVP464LwcVOmt29MqwsR59O_zkC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/14ceacc495..d672069387 * tools/luci-go: git_revision:c893d7a542f324fe7c1a63c83e57ccea23631ffe..git_revision:a0624fca6d6e6fc1da6462ce0ee7678d4cc739d8 * tools/luci-go: git_revision:c893d7a542f324fe7c1a63c83e57ccea23631ffe..git_revision:a0624fca6d6e6fc1da6462ce0ee7678d4cc739d8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/88a9d4ea84..20dd97665a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0cbb10ffdf..28e985ae84 * tools/skia_goldctl/linux: pnprsw4_qiLaFOB3waX424Uaz5zX3MSh6Iz5A3OwpR8C..vMuEaxuoKcSgIEyacUY5YqByCP4RveJIid7OXrLUZnwC * tools/skia_goldctl/mac_amd64: qMTthZODlW9LCvkQX3upPhaL6t3VwQcYrs9cDYwP75oC..OKl2kxI6rF8oLCJQma7QhqQHTC_J3hMRKoAqyW4tqq0C * tools/skia_goldctl/mac_arm64: 3NLkdA7AHyUKOEdv0Dc16lTUNJN9FjFkDIzVXthPsDkC..pZmD81q5BF6lQcwTgrtJre8iXtofPubDLM8624rQKNsC * tools/skia_goldctl/win: wEIMZs5miJMkTVDLFMkQjh4dJWrLB4k8VQDU4aUPSwYC..3IrV971Fn9UEAXu0UwL8cBBY3L8il5zi4Qjhvfa43TQC No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I2d4ef8f9e2f99b6f5e7286208492239e6e9c352a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3947945 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu c22f091d 2022-09-29T18:58:33 Replace Hard-Coded egl image attribs This change is adapted from https://crrev.com/c/3838866 Added two hash maps to track below information: EGLImage* --> EGLint* attrib TextureID --> EGLImage* During the CaptureShareGroupMidExecutionSetup, when we iterate through all the textures the app created, if the texture is bound to External target, we will refer to the hash map TextureID --> EGLImage* to find the EGLImage* pointer, and then use the result as the key to refer to the other hash map EGLImage* --> EGLint* attrib to find the attributes used to create that EGLImage object. We can then use the attributes to populate eglCreateImage or eglCreateImageKHR calls in the trace calls. Bug: angleproject:7570 Change-Id: I729de4ddea59242ccbe6243e036451f290545185 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3928212 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 1119dfbd 2022-10-03T16:47:29 Vulkan: disable supportsHostQueryReset feature if func is null This is try to clean up a old fix for chromium security bug chromium:1273344 that in some bots we are seeing supportsHostQueryReset feature enabled but vkResetQueryPoolEXT pointer is null. We fixed that in crrev.com/c/3313382 that added a check of vkResetQueryPoolEXT AND supportsHostQueryReset feature flag. This CL disables the feature flag if vkResetQueryPoolEXT pointer is null so that other places we only need to check feature flag. Bug: b/250706693 Change-Id: I2d9f9726f081e21a37bbb0bb205003c390f2d32c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929236 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 135022e4 2022-10-11T00:03:11 Vulkan: Create robust pipelines based on context state Previously, pipelines were made robust based on whether any context in the share group has so far been made robust. This means that pipelines created on non-robust contexts would still be compiled as robust. Inefficiency aside, this was buggy because robustness was not part of the pipeline cache key, so if a pipeline was created as non-robust first, then recreated in a robust context, it would reuse the non-robust variant. With VK_EXT_pipeline_protected_access, a similar situation arises for context protected-ness. However, it is incorrect in that case to create pipelines as protected unnecessarily. This change makes pipeline robustness a part of the pipeline cache key, in preparation for protectedness to be added similarly. Compute programs may now generate multiple pipelines as a result too. Bug: angleproject:7629 Change-Id: Ie95f10eff878f8c8b221c1018da44385c7aad15e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3943534 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 9b5fff82 2022-10-05T21:56:00 Vulkan: Emulate shader stencil export for MSRTT The MSRTT emulation code had one corner case issue that could lead to performance and memory inefficiencies. That is when stencil needs to be unresolved and VK_EXT_shader_stencil_export is not supported. This change adds a path to emulate VK_EXT_shader_stencil_export and removes this inefficiency. This should help Chromium on older Android devices that lack both this and the recent VK_EXT_multisampled_render_to_single_sampled extensions. Chromium frequently breaks the render pass (crbug.com/1336981), which easily leads to this situation. Bug: angleproject:4836 Change-Id: Ifceec43f7f3807b7e32f4b379edcd4351ae76414 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3935892 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Charlie Lao b1d699da 2022-10-04T15:27:51 Vulkan: Don't wait QueueSerial if supportsHostQueryReset enabled In QueryVk::getResult() we are waiting for query's queueSerial to complete, even though QueryHelper::getUint64Result() we are also using VK_QUERY_RESULT_WAIT_BIT to ask vulkan driver to wait for result. Based on the comment, the reason for that queueSerial wait is because "its reset command may not have been performed by the GPU yet.". But if mFeatures.supportsHostQueryReset is enabled, we use vkResetQueryPoolEXT to reset the query, and this host reset is immediate, so there is no need to wait for queueSerial in this case. This CL disables the wait when host reset is enabled and relies on vkGetQueryPoolResults(VK_QUERY_RESULT_WAIT_BIT) to do actual wait. This should help performance on immediate renderer where the query result might be available before renderpass completion. Bug: angleproject:3965 Change-Id: Ibe61c289f1f3d1312e79ac80a2b5de23b90ef87c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3935444 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
Charlie Lao 76f377c5 2022-06-17T16:05:16 Vulkan: Break renderpass when switch from query to non-query getQueryResult will wait for query result to be available, which means a potential CPU bubble if the result is not yet available. On tiler GPUs it will at least wait for renderpass to complete. Usually query enabled draws are very tiny (usually just draw a point to see if it is occluded or not), and query disabled draws are expensive. Some apps do issue a glFlush when switch from query draw to non-query draw, but app like dead_by_daylight does not issue such flush. In order to reduce the bubble, this CL ends renderpass and issue a flush when we switch from query enabled draws to non-query enabled draw so that the result will be available much earlier, this reduce the CPU bubble. This result in dead_by_daylight frame time improves from 5.45ms to 3.5ms (35% improvement). Bug: b/250706693 Change-Id: Ia3a32a9fb336e6f256809b3cad83f61a45415fb1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3931739 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Brian Sheedy 219af5de 2022-10-11T18:05:47 Revert "Reland "EGL: Implement EGL_EXT_image_dma_buf_import_modifiers"" This reverts commit f53eac299fb2e0083fa386af1f04038b32faebe4. Reason for revert: Suspected of causing problems on kevin devices again. Original change's description: > Reland "EGL: Implement EGL_EXT_image_dma_buf_import_modifiers" > > This is a reland of commit 1d8dce2587a23b59f911c801856372996bdb2f64 > > New changes: > - fail softly on buggy drivers (which are part of the CI) > > Original change's description: > > EGL: Implement EGL_EXT_image_dma_buf_import_modifiers > > > > This reverts Ifbb0a182171646df8161f6f42eafe2a476fea6b2 and implements > > the previously missing bits. Inspired by the corresponding Vulkan > > implementation. > > > > The extension is used by an upcoming Exo feature which was successfully > > tested with this patch, see > > https://chromium-review.googlesource.com/c/chromium/src/+/3857556 > > > > Bug: angleproject:7664 > > Change-Id: I951d1a787e1db3a77b19fcea6186b7aa0a29872f > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3904345 > > Reviewed-by: Geoff Lang <geofflang@chromium.org> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > Bug: angleproject:7664 > Change-Id: I732fc9dad54366553987104fa035bde2afe08ecd > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3924350 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7664 Change-Id: I2ffc508ea4cc9e95055084fed4f63a52d9afdbd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3946903 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki a217dd56 2022-10-06T11:25:31 Tests: Add The Witcher: Monster Slayer trace. Test: angle_perftests --gtest_filter="*the_witcher_monster_slayer*" Bug: angleproject:7747 Change-Id: I1851fc00cb665485b6111b4e01b0075d2440e62a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3942649 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Roman Lavrov 6eff905c 2022-10-11T10:08:12 Make Android gold tests populate os and os_version correctly. os = Android os_version = {ro.build.fingerprint} These show up in Skia gold. Currently set to Linux info. Bug: None Change-Id: If2ffe5e8a6620fde9bd0a983f9c0d11ffe6a75c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3946179 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill f8930fd8 2022-10-11T09:20:24 infra: Increase timeout on perf bots. This sets an explicit 3 hour timeout for all bots, and bumps the timeout for the perf bots to 5 hours. Bug: angleproject:7738 Change-Id: I2ed3ce319046ef8a9ec61128f4970c03ec1d2ecf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3945072 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 32908ad5 2022-10-11T10:01:13 Roll vulkan-deps from 1172dba33888 to 24053e9970b7 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1172dba33888..24053e9970b7 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/6c64537135..cb519989cd * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/96595a7710..7625be6a26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I76d603893b611536430cb1fa9b59aef219a86bc9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3944893 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny f2785e41 2022-10-10T08:21:36 capture/replay: validate after resetting unpack alignment Otherwise validation will fail, because we try to validate the temporary set alignment against the alignment that would be active without MEC. Bug: angleproject:7564 Bug: angleproject:7180 Change-Id: I40cac84be122c779b9beba39f155567f9edbee75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3936631 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Cody Northrop 5bafe449 2022-10-05T20:09:23 FrameCapture: Create default context reset calls Add support for emitting default reset calls for some entrypoints when recording a capture from the beginning. Test: Lineage 2 Revolution MEC Bug: angleproject:7741 Change-Id: I8e4e1184f3e3b68527a65283c459a43d135e95b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3938442 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi b3b855d2 2022-10-09T21:39:16 Vulkan: Features for two exts - VK_EXT_graphics_pipeline_library - VK_EXT_pipeline_protected_access Bug: angleproject:7369 Bug: angleproject:7714 Change-Id: I42b5b5a2758b32625dc12352d521cfa1dff1aa90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3939919 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a8f03d40 2022-10-10T16:58:58 Roll VK-GL-CTS from 3739dbc26ccf to f4ed7376e1da (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/3739dbc26ccf..f4ed7376e1da 2022-10-10 ziga@lunarg.com Add imageless framebuffer with different attachments test 2022-10-10 gleese@broadcom.com Add depth range interaction tests 2022-10-10 rgarcia@igalia.com Enable some combined pipeline and image robustness tests 2022-10-10 russellc@nvidia.com Add more VK_EXT_acquire_drm_display tests 2022-10-10 russellc@nvidia.com Add VK_EXT_acquire_drm_display tests 2022-10-10 ziga@lunarg.com Add tests with create pipeline cache flags 2022-10-10 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I014e5053382dca945511b74676eb6016250733df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3942406 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 70244096 2022-10-10T10:20:12 Perf Tests: Enable --split-shard-samples on the bots. This should make all sharts run at most one sample for each test. This in turn should mitigate inter-run variance because we'll sample from a wider pool of machines for each test. Bug: angleproject:7738 Change-Id: Ied96235edff81c8ea6f3fb8ac0e4fb21d6254d4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3942604 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill d0a024f9 2022-10-09T16:47:33 Lower perf tests resource usage further. This reduces the warmup trials from 2->1 and the trial time from 5s -> 4s. Old: (2 warmup + 3 trials) * 5s / trial ~= 25s per sample New: (1 warmup + 3 trials) * 4s / trial ~= 16s per sample The tests should run in about 2/3 the time as it took prior. A future change will likely have to split up the tests so we can run shorter shards in sequential groupings between tests. Bug: angleproject:7738 Change-Id: Ic6c744be838174b61f4eb832189ccad14f89103d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3939917 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 3e25d37f 2022-10-10T10:01:59 Roll SwiftShader from 01fade1fc521 to acdfa394561f (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/01fade1fc521..acdfa394561f 2022-10-07 capn@google.com Update Marl to 14549e9d1 2022-10-07 capn@google.com Fix enabling XCB and Wayland WSI builds on Linux If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I0c69e8d43fbc374435ec17cf70444bfcdaadff4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3939782 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
George Burgess IV 54d094fe 2022-05-23T13:05:46 angle: fix potential nullptr dereference `checkIsScalarBool` immediately deref's `typedCond`, which may be NULL. Prevent that. Caught by the static analyzer: > device/generic/vulkan-cereal/third-party/angle/src/compiler/translator/ParseContext.cpp:893:9: warning: Called C++ object pointer is null [clang-analyzer-core.CallAndMessage] Bug: b/206470603 Test: None Change-Id: I2c055d637fb3ef254c0cebfae32bfbe17bf850ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3935460 Auto-Submit: Greg Schlomoff <gregschlom@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki 85631d24 2022-10-06T10:13:31 Tests: Add 3D Pool Ball trace. Test: angle_perftests --gtest_filter="*3d_pool_ball*" Bug: angleproject:7742 Change-Id: I92870b928ee66af3eae903d91512b6943b893599 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3932171 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 1b5cf9f0 2022-10-07T19:02:16 run_perf_tests: Reduce warmup trials from 3 to 2. This is an attempt to reduce utilization on the bots, which are now taking too long and causing errors. Bug: angleproject:7738 Change-Id: I1c576b2d0989240482d332712f7d93841e933902 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3937051 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill f8d393da 2022-10-05T10:09:34 Capture/Replay: Make retrace restore touch output files. This should force a recompile of modified files. Bug: angleproject:7731 Change-Id: I52c607fdda97c09e557a9ac3144fa67de3a17ee7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3937048 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 8bac3563 2022-10-07T17:36:53 infra: Update timeout for perf tests. Changes 200 minutes to 120 minutes. Also applies the timeout to the Pixel 4 perf tests which are now timing out with the latest increase in warmup time. Bug: angleproject:7738 Change-Id: Ib43d61cb218aac24a5d9ae190813256a72b9eccc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3937050 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Tiago Vignatti cad7979e 2022-10-07T11:08:14 Metal: Build fix TextureMtl code Changes introduced in CL https://crrev.com/c/3915180 caused an issue when building Metal with TARGET_OS_SIMULATOR enabled. This fixes that and a minor formatting issue that presubmit hook caught). Test: build ANGLE with Metal renderer enabled on iOS. Bug: angleproject:7573 Change-Id: I08baf64e3d37b97af76e9e04188836ed253d34b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3939217 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Chris Dalton 7c1ddff3 2022-10-06T18:28:45 Include Apple1 in the Metal framebuffer-fetch impl of PLS Framebuffer fetch was mistakenly limited to the Apple2+ GPU families, but Apple1 also supports programmable blending. Bug: angleproject:7279 Change-Id: Ia5a63ac1cb6462a6299db12bfb67fea12f15bb8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3935458 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Jamie Madill b6cc672c 2022-10-06T11:10:42 Perf Tests: Divide test samples between shards. Instead of a single test shard running all samples for a test, we run a single sample on different shards to produce a combined measurement that can account for variance between test machines. Bug: angleproject:7671 Change-Id: I04bbd51de257f2f299783ce3bd65da3d9348c8dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3937044 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill ad2fbc7d 2022-10-07T14:35:49 Roll third_party/OpenGL-Registry/src/ 11d7b7bae..5bae8738b (5 commits) Also removes our copy of gl.xml now that upstream patches are merged. https://chromium.googlesource.com/external/github.com/KhronosGroup/OpenGL-Registry/+log/11d7b7baebfc..5bae8738b23d $ git log 11d7b7bae..5bae8738b --date=short --no-merges --format='%ad %ae %s' 2022-09-29 sunserega2 [xml] Fixes for defined but unused enum groups (#520) 2022-09-29 julius_hager Added group PixelType to multiple-enums (#529) 2022-09-29 gnl021 EXT_separate_depth_stencil: Explicit unsupported cases (#531) 2022-09-29 jmadill Add enum groups for ANGLE use cases. (#538) 2022-09-29 syoussefi Clarify that PLS doesn't allow leak from outside framebuffer (#540) Created with: roll-dep third_party/OpenGL-Registry/src Bug: angleproject:6461 Change-Id: I6b7d8471144babe5cdd465c64574804f85c9e4f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3937049 Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 8d502f2d 2022-10-06T10:20:26 Perf Tests: Simplify merger script. This script contains a lot of logic copied from Chromium scripts that we don't need. This CL removes some of it. Bug: angleproject:7671 Change-Id: I831c2620cf5d5d1325d51605122a6998fcf2d3c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3937043 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Chih-Hung Hsieh 7072bd9b 2022-02-09T14:43:18 Fix cert-dcl16-c warnings Bug: b/120614316 Test: make tidy-soong_subset Change-Id: Iddde03d9a554b078ef87d3b8d4ab3de78b40a725 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3935459 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Greg Schlomoff <gregschlom@google.com>
Solti 496b3532 2022-10-07T15:49:08 fix typo Bug: None Change-Id: Ieca7fcd5b8172ad16cc73f453f6e2e2f29ae6016 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3939221 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya dbbfdd22 2022-10-06T13:39:20 Vulkan: Bug fix in GL_QCOM_shading_rate Don't initialize "vkCmdSetFragmentShadingRateKHR" before creating VkDevice as it leads to a nullptr assertion in RendererVk::canSupportFragmentShadingRate. Separate out instance and device function pointer initializations. Bug: angleproject:7172 Change-Id: I55b5b41313857a2861a197f17d7f88b71aec907f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3938443 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 0dd4e4e6 2022-10-07T10:01:42 Roll vulkan-deps from 7d797ec7d6bb to 1172dba33888 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7d797ec7d6bb..1172dba33888 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a6e6454ef2..1cecf91701 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/cd9b4afed4..6c64537135 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a02d471126..96595a7710 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I9f4ccd63e2803daf2beb250ae8808640969506cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3939208 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fdf4a584 2022-10-07T10:01:18 Roll SwiftShader from 2b155acd6a90 to 01fade1fc521 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/2b155acd6a90..01fade1fc521 2022-10-07 nicolascapens@google.com Merge changes Ie0e663e1,I97918fd5 2022-10-06 sugoi@google.com Regres main.go cleanup 2022-10-06 martin.troiber@gmail.com Fix repeated character If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Id42afc15f6dce0e17bc51de6d070f50b4b0ffe78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3938759 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2b3c8aaf 2022-10-07T08:31:21 Roll Chromium from 7903a06a3c9a to 475715430cb8 (558 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7903a06a3c9a..475715430cb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c34b59a3b6..6b83819915 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8d901f9a01..b47f3d62c4 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/27c4bb6c70..eddc4cee09 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6ed9a5cc4a..cdb43fc0b8 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/65b2c6ba64..394370865d * third_party/android_build_tools/manifest_merger: 0cYQOUjN8K9fAtfcm6Vwi30XcO6mPJU_5v4-pUkBg0sC..bUREd_PkCqlp2ww6zmyOLGf0jhqgbnf6GT4V1xkAZ10C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c4219fa517..11566d5c44 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/04b33506bf..1bf9b93243 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/a34cd77b53..3f159e715e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6cc3b1e4ab * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/99c8282eb5..51a6576d1b * third_party/fuchsia-sdk/sdk: version:9.20221005.2.1..version:9.20221006.4.1 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/af7b288c8f..b35e191547 * third_party/r8/d8: C5fVAulygxp-vnd9QQ9555s4drK-wMwSthIIcDX0N-wC..IgKfK01VX-GA1mjxpHqq-7kL9VDb5qlXZnSW0Jtl6cAC * tools/luci-go: git_revision:9b6501cd8b61afbb92c76207dfd2594606a4b4d1..git_revision:c893d7a542f324fe7c1a63c83e57ccea23631ffe * tools/luci-go: git_revision:9b6501cd8b61afbb92c76207dfd2594606a4b4d1..git_revision:c893d7a542f324fe7c1a63c83e57ccea23631ffe * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/186c5f3430..88a9d4ea84 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5a0113e764..0cbb10ffdf * tools/skia_goldctl/linux: vvnmipanCNz0xZWcZxMxqF8Dm17k5IzoIIuSAxayctEC..pnprsw4_qiLaFOB3waX424Uaz5zX3MSh6Iz5A3OwpR8C * tools/skia_goldctl/mac_amd64: IvvIkJXPEctNxoRBIUUUuHSJN0vsFTR9XgTza8JoCngC..qMTthZODlW9LCvkQX3upPhaL6t3VwQcYrs9cDYwP75oC * tools/skia_goldctl/mac_arm64: PobY7qdsILEzxp0nSF8_mIJNJpPQiFs2mtNqOXLZlAYC..3NLkdA7AHyUKOEdv0Dc16lTUNJN9FjFkDIzVXthPsDkC * tools/skia_goldctl/win: mMto2aiE2BsVX1RoY_FYEPJ7ph496TgwksEHvbcwQJsC..wEIMZs5miJMkTVDLFMkQjh4dJWrLB4k8VQDU4aUPSwYC No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I066bdd85c5bec0e2a3390e9ca0bb6eec807e32ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3939205 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Dean Jackson 592b60fb 2022-10-06T12:34:48 Remove unnecessary fprintf of Metal shader output type Bug: angleproject:7740 Change-Id: I487913df1d0f29302ac6e955c27ee7cf4f34a73b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3934692 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Amirali Abdolrashidi c19ec948 2022-08-23T10:43:59 Vulkan: Implement imageless framebuffers * Added the attachment image and create info objects to be used for imageless framebuffers created in getFramebuffer(). * New helper class for framebuffers in RenderPassCommandBufferHelper: MaybeImagelessFramebuffer, which includes a framebuffer object, if the framebuffer is imageless, and the image views. This is to make sure that the args for render pass begin info will be correctly set up according to the status of the used framebuffer. * Refactored the collection of attachments in getFramebuffer() into a new function, getAttachmentsAndImagesFromRenderTargets(). It also returns their corresponding ImageHelper* objects used to create the framebuffer (from their image properties). * New struct: RenderTargetInfo; which keeps track of render targets and whether resolve image should be used for the render pass in the form of the enum class RenderTargetImage. * Added a new arg to getFramebuffer(): resolveRenderTargetIn; to use when there is a valid resolveImageViewIn. * Without using the framebuffer cache, we would require to handle the framebuffer destruction by adding it to the garbage instead of releasing it. For example, FramebufferVk::destroy() now adds mCurrentFramebuffer to the garbage. * Added new framebuffer unit tests. * Added tests where two textures with different attributes are bound to the same framebuffer before drawing, one after another. * Added test where a blit occurs from a multisample texture into a non-zero level of a resolve texture, each bound to a separate FBO. * Added a new perf test to compare performance for enabled imageless framebuffers vs disabled. (Credit: cclao) Bug: angleproject:7553 Change-Id: Iacdbd73aaa01cbb0e37abf01ae4892bdfdd4b12f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827644 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Jamie Madill 4ebdac79 2022-08-29T16:25:46 Vulkan: Ensure we sync the draw FB before beingQuery. Bug: chromium:1354271 Change-Id: I5fe3649d9d39de37d0a59c80a4f31a17d1a72838 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3863145 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Chris Dalton 2d31fe98 2022-09-22T21:04:22 Implement PLS on Apple Silicon Implements a subset of EXT_shader_framebuffer_fetch in the Metal translator that is sufficient to support pixel local storage. Metal's "programmable blending" feature is available on all Apple family GPUs beginning with version 2. Support for non-Apple GPUs will come later via readWrite textures, which can also be coherent by annotating them with [[raster_order_goup(0)]]. Bug: angleproject:7279 Change-Id: Ic74f6c0d21e87eb919e1f487163388d08d126857 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3916794 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Gregg Tavares <gman@chromium.org>
Jamie Madill 04f3ed80 2022-10-04T08:24:16 Perf Tests: Use specified trial time for warmup. When the user specifies a trial time, use this for the warmup time instead of using the calibration time. This will give a longer warmup time on our test infra and should help stabilize perf testing scores on our bots. Bug: angleproject:7671 Change-Id: I65fb8a7ae1f684d3f7834613d8341d17bd2df00f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3933315 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Robert Mader f53eac29 2022-09-19T15:08:54 Reland "EGL: Implement EGL_EXT_image_dma_buf_import_modifiers" This is a reland of commit 1d8dce2587a23b59f911c801856372996bdb2f64 New changes: - fail softly on buggy drivers (which are part of the CI) Original change's description: > EGL: Implement EGL_EXT_image_dma_buf_import_modifiers > > This reverts Ifbb0a182171646df8161f6f42eafe2a476fea6b2 and implements > the previously missing bits. Inspired by the corresponding Vulkan > implementation. > > The extension is used by an upcoming Exo feature which was successfully > tested with this patch, see > https://chromium-review.googlesource.com/c/chromium/src/+/3857556 > > Bug: angleproject:7664 > Change-Id: I951d1a787e1db3a77b19fcea6186b7aa0a29872f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3904345 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7664 Change-Id: I732fc9dad54366553987104fa035bde2afe08ecd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3924350 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 9925671c 2022-10-06T10:01:35 Roll vulkan-deps from a93889caf313 to 7d797ec7d6bb (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a93889caf313..7d797ec7d6bb Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/28b53119bd..89db4e1caa * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/000c5f0fa4..85a1ed200d * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4dbc66380d..a6e6454ef2 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/467f61cd34..2446b5b849 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4e11b1990d..a02d471126 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I9e8d4454447a5e465340647c1b8ca840f2079624 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3937884 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9374b4bd 2022-10-06T10:01:40 Roll SwiftShader from 3d7faaa40575 to 2b155acd6a90 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/3d7faaa40575..2b155acd6a90 2022-10-05 capn@google.com Remove Unicode handling from Subzero 2022-10-05 capn@google.com Use local XCB header copies 2022-10-05 capn@google.com Use local Wayland header copies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Iaac6a15e5ae9a29ed68b81f8b9c5c95f89a4b6a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3936980 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 46672dae 2022-10-06T07:00:35 Roll Chromium from cbf7ac747397 to 7903a06a3c9a (479 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cbf7ac747397..7903a06a3c9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1326123dbe..c34b59a3b6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e564697e6c..8d901f9a01 * buildtools/linux64: git_revision:cc28efe62ef0c2fb32455f414a29c4a55bb7fbc4..git_revision:b9c6c19be95a3863e02f00f1fe403b2502e345b6 * buildtools/mac: git_revision:cc28efe62ef0c2fb32455f414a29c4a55bb7fbc4..git_revision:b9c6c19be95a3863e02f00f1fe403b2502e345b6 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7261e95e51..27c4bb6c70 * buildtools/win: git_revision:cc28efe62ef0c2fb32455f414a29c4a55bb7fbc4..git_revision:b9c6c19be95a3863e02f00f1fe403b2502e345b6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/32e58ce34c..6ed9a5cc4a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/751b72a8c1..2eecb3e113 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0c709a95ed * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c54a19bd0..99c8282eb5 * third_party/fuchsia-sdk/sdk: version:9.20221004.1.1..version:9.20221005.2.1 * third_party/r8/d8: 0ji9wClrgOUJelQ_489AiysBnUebh6jZLyQU8BSZQo0C..C5fVAulygxp-vnd9QQ9555s4drK-wMwSthIIcDX0N-wC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5fa4996834..14ceacc495 * tools/luci-go: git_revision:4fd960efe8027d39520e9aea3bbc8d669b53218f..git_revision:9b6501cd8b61afbb92c76207dfd2594606a4b4d1 * tools/luci-go: git_revision:4fd960efe8027d39520e9aea3bbc8d669b53218f..git_revision:9b6501cd8b61afbb92c76207dfd2594606a4b4d1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/af67e99541..186c5f3430 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/572d9dcf87..5a0113e764 * tools/skia_goldctl/linux: vCe9K2hrd7rulzEscCqmJ73IvKvUMAFoedwTMZ2tyOEC..vvnmipanCNz0xZWcZxMxqF8Dm17k5IzoIIuSAxayctEC * tools/skia_goldctl/mac_amd64: n_JzdshI5mmavD9RQUw_r4Wod2s3q6WWySo2hoFBA4YC..IvvIkJXPEctNxoRBIUUUuHSJN0vsFTR9XgTza8JoCngC * tools/skia_goldctl/mac_arm64: oyvITC73Vi_A8AzxypnanjLCP0FWKOUp4O82SKljngUC..PobY7qdsILEzxp0nSF8_mIJNJpPQiFs2mtNqOXLZlAYC * tools/skia_goldctl/win: mwncd-pNoe2LQDqPamvkmkqvSBhPh4QwWEV65ny5K-cC..mMto2aiE2BsVX1RoY_FYEPJ7ph496TgwksEHvbcwQJsC Clang version changed llvmorg-16-init-6457-g20a269cf:llvmorg-16-init-6578-g0d30e92f Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/5fa49968341ed4c2f0f7ab5eac5c298924b3f63e..14ceacc495b517075c992e493c46210ce72f4950/scripts/update.py Bug: None Tbr: ianelliott@google.com Change-Id: I3820f2999bc64a12b70bdd63414bdbabcc734fe1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3936581 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 13195f8a 2022-10-05T11:17:35 Vulkan: Fix missing input attachment usage on MSRTT When combined with advanced blend (or framebuffer fetch for that matter), MSRTT attachments could be used as input attachments. This change fixes the missing usage bit. Bug: angleproject:7739 Change-Id: I2190e4a6e534e120357dd68189fb9de07b6c54fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3936444 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 159f3e62 2022-09-28T23:34:06 Vulkan: Make sure spirv-val doesn't generate friendly names This makes it harder to debug as the disassembly uses raw ids. Additionally, the generation of friendly names itself is costly. On GLES1's TexCombine test, this change reduces run time by ~7%. Bug: angleproject:6644 Change-Id: I47e6752cd709733c49915dd374c18f5438c0bfdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3926038 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Chris Dalton b5514bb2 2022-09-21T20:47:00 Support pixel local storage on ES 3.0 Now that the application-facing API is implemented, we don't have to rely on ES 3.1 anymore. Expose and test the extension on ES 3.0. Bug: angleproject:7279 Change-Id: I5635620b9088201c20bafd283813092a329225d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3915327 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Chris Dalton <chris@rive.app> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Hailin Zhang 5ddf631c 2022-10-04T11:17:45 Vulkan: Choose host visiable device local based on heap size. set preferDeviceLocalMemoryHostVisible based on the host visiable device local and device local heap memory heap size. Bug: b/246909451 Change-Id: I1e63931baceda02396b0eb8f24671949920ac2a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3934479 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Hailin Zhang <hailinzhang@google.com> Reviewed-by: Mateusz Przybylski <mprzybyl@google.com>
Cody Northrop c09d1475 2022-10-05T14:52:40 restricted_trace_perf: Switch to --warmup-trials Restore functionality after updates in: https://chromium-review.googlesource.com/c/angle/angle/+/3906144 Test: restricted_trace_perf.py Bug: angleproject:6970 Change-Id: I0632907b6dab0c0ad91536d42cac8eaf433f4da7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3936966 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Cody Northrop e577353d 2022-09-29T17:20:22 restricted_trace_perf: Sleep between tests option In order to get the most "real world" numbers possible, we're going to start running with clocks unlocks on Pixel devices. To avoid thermal throttling, allow for a pause between each test. Test: restricted_trace_perf.py Bug: angleproject:6970 Change-Id: If3f813cf1eadab6ea56122a3945f694eed79ed9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3936965 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi a3b3d948 2022-10-05T14:15:32 Revert "Suppress DrawBuffersTest.MidRenderPassClearWithGapsRGB" This reverts commit 668184941e8d107d585743c91359963f3410d434. Reason for revert: VVL bug fixed Original change's description: > Suppress DrawBuffersTest.MidRenderPassClearWithGapsRGB > > To get vulkan-deps Autoroller working again > > Bug: angleproject:7736 > Change-Id: Iff6bb5bfc04fb22cb2cd7126d5ecbd932a5e9af5 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3934478 > Commit-Queue: Ian Elliott <ianelliott@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Auto-Submit: Ian Elliott <ianelliott@google.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: angleproject:7736 Change-Id: I2727447907f2e25cf9b854ffcc9ccfc04db2fb95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3936442 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Cody Northrop 503b250a 2022-08-31T20:06:57 restricted_trace_perf: Use Android platform loader With persistent shader caching enabled, we now need to run the trace tests exclusively in "native" mode, with ANGLE as the driver. The cache is provided via the EGL_ANDROID_blob_cache extension, and it is only enabled using Android's EGL loader. Test: restricted_trace_perf.py Bug: angleproject:6970 Change-Id: If791bfe199217dcc80105b55d8769fe43ffd9739 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3868310 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 391644f4 2022-08-24T14:59:21 Vulkan: Use VK_EXT_rasterization_order_attachment_access When available, this extension makes coherent framebuffer fetch / advanced blend official. Bug: angleproject:7604 Change-Id: Ifc552a0fa7a3612a3fc568feb61d6dd348e856ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3855698 Reviewed-by: Chris Dalton <chris@rive.app> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill d8489db5 2022-10-05T12:57:06 Perf Tests: Reduce resource usage. This halves the amount of time spent running the tests on desktop platforms. It also reduces the number of shards used on desktop platforms, to reduce resource utilization. It also bumps up the test timeout to keep from getting infra errors. Bug: angleproject:7738 Change-Id: Ie487c06452a39bb9ad1fe29b0d682e9c1bf297d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3936448 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll f9afc53d 2022-10-05T16:08:16 Roll vulkan-deps from 5d66d3e5917b to a93889caf313 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5d66d3e5917b..a93889caf313 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/4bd8fc0c8c..000c5f0fa4 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ed24831042..4e11b1990d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I2a32aea0348c621c77dcc8acfc9b9d53a555c631 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3935360 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Le Hoang Quyen d64c54e3 2022-09-26T21:25:18 D3D11: Make DebugAnnotator11 thread safe. Bug: chromium:1366778 Change-Id: I50662895be8ec40de4ded8c4f84bde59ae40e98b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3917936 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll da44ba32 2022-10-05T10:01:41 Roll vulkan-deps from e0aed16f882f to 5d66d3e5917b (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e0aed16f882f..5d66d3e5917b Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/81ba8f78f6..f09ba27777 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c71f94d8a8..cd9b4afed4 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/db898178ff..ed24831042 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I5709d8d5c2aa86a4b0cb7d141e6925274aed734c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3935624 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 06d0389a 2022-10-04T19:26:48 Remove leftover code regarding render pass serial * Removed the render pass serial reset in the function where the current framebuffer is released. (left over from a prior CL.) Bug: angleproject:7553 Change-Id: I61b4a12ac8957f6e1dcd4bf0f4e233c068736dff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3931901 Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 008acb09 2022-10-05T10:01:07 Roll SwiftShader from 08dfcbb37734 to 3d7faaa40575 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/08dfcbb37734..3d7faaa40575 2022-10-04 capn@google.com Consistently format pointer-to-const 2022-10-04 capn@google.com Consistently format const references 2022-10-04 capn@google.com Remove unnecessary vector component indexing 2022-10-04 capn@google.com Fix CMAKE_BUILD_PARALLEL_LEVEL link 2022-10-04 swiftshader.regress@gmail.com Regres: Update test lists @ 08dfcbb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I6a437cf4130724c76c385580273738999e217c6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3935868 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0d8c8de0 2022-10-05T07:01:30 Roll Chromium from ea588e320b5b to cbf7ac747397 (579 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ea588e320b5b..cbf7ac747397 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7e7c21a9ac..1326123dbe * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9174abb6ac..e564697e6c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a3c5c93af6..32e58ce34c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0c709a95ed * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fe24047cdc..2c54a19bd0 * third_party/fuchsia-sdk/sdk: version:9.20221003.3.1..version:9.20221004.1.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/1c95dd77bf..ad71a3730f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a5e0d72349..5fa4996834 * tools/luci-go: git_revision:45c4b0ebf2c594bbd64adf3f042f3f491c16bbdf..git_revision:4fd960efe8027d39520e9aea3bbc8d669b53218f * tools/luci-go: git_revision:45c4b0ebf2c594bbd64adf3f042f3f491c16bbdf..git_revision:4fd960efe8027d39520e9aea3bbc8d669b53218f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/14ab6399f8..af67e99541 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0f04c83ca2..572d9dcf87 * tools/skia_goldctl/linux: 4jQ6gzrqaKCyEn_8V_Y5qXFi7zg2AYJ-OdNJsmywBJUC..vCe9K2hrd7rulzEscCqmJ73IvKvUMAFoedwTMZ2tyOEC * tools/skia_goldctl/mac_amd64: 68Q-YqkF1ut4cqxu8AL0aBux2bqV8J1T1x6L9sOg8g0C..n_JzdshI5mmavD9RQUw_r4Wod2s3q6WWySo2hoFBA4YC * tools/skia_goldctl/mac_arm64: 2BbiGimzY0i9eeqhzJAe3mynFtS0uE4wB33voz1XNqYC..oyvITC73Vi_A8AzxypnanjLCP0FWKOUp4O82SKljngUC * tools/skia_goldctl/win: v8uUG8MbJk5MqnqE-Oe0lpCWpvwrzmhT4Bb0jKxA-hoC..mwncd-pNoe2LQDqPamvkmkqvSBhPh4QwWEV65ny5K-cC Clang version changed llvmorg-16-init-6084-g2f3d7c2c:llvmorg-16-init-6457-g20a269cf Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/a5e0d72349d028a4023927d6d166a8478355fac3..5fa49968341ed4c2f0f7ab5eac5c298924b3f63e/scripts/update.py Bug: None Tbr: ianelliott@google.com Change-Id: I5ae55c4b521cc29779daa1533a9b5b2a530f5de6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3935623 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 637209c9 2022-10-02T22:05:12 Tests: Add Survivor.io trace Test: angle_perftests --gtest_filter="*survivor_io*" Bug: angleproject:7728 Bug: angleproject:7733 Bug: angleproject:7737 Change-Id: Ic337af781a209c3302bee748c5aed47f367993a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3932009 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll d26ee619 2022-10-03T18:28:18 Roll vulkan-deps from cce3d29fab2b to e0aed16f882f (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/cce3d29fab2b..e0aed16f882f Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3ec6b3698e..4dbc66380d * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/9c40a28e3e..c71f94d8a8 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/facac95131..467f61cd34 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0a7b14dce3..db898178ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I42fa5589c8eb47e0b32270a4f0736823f68f31cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929751 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott 66818494 2022-10-04T12:21:02 Suppress DrawBuffersTest.MidRenderPassClearWithGapsRGB To get vulkan-deps Autoroller working again Bug: angleproject:7736 Change-Id: Iff6bb5bfc04fb22cb2cd7126d5ecbd932a5e9af5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3934478 Commit-Queue: Ian Elliott <ianelliott@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Ian Elliott <ianelliott@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Shahbaz Youssefi 7d10d160 2022-09-29T23:31:40 Vulkan: Fix VK_EXT_pipeline_robustness vs compute Robustness was not specified for compute. Bug: angleproject:5845 Change-Id: I3f3b1e90cc4e965ff4cfcd569587caa952e5eaa2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3924871 Reviewed-by: Alexis Hétu <sugoi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi fb83e6c5 2022-10-03T18:25:42 Infra: Use smaller batches for GLES1 tests The GLES1 conformance tests are few, but each take a long time. As such, --bot-mode only divides them by platform and otherwise the tests run serially. This change uses a smaller batch size to increase parallelism. Bug: angleproject:6644 Change-Id: I1401db0899d4f57735cbfdfb4b051a2d19f8e2a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3933829 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f9373863 2022-10-04T08:17:36 Roll Chromium from 34801c7ce64b to ea588e320b5b (503 revisions) https://chromium.googlesource.com/chromium/src.git/+log/34801c7ce64b..ea588e320b5b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0a1188f24a..7e7c21a9ac * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2e919977e0..7261e95e51 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/20a144a49a..db2a783a7d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6ff813a5ed..a3c5c93af6 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b44f27b137..c4219fa517 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0237c57801 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a724859f7a..fe24047cdc * third_party/fuchsia-sdk/sdk: version:9.20221002.2.1..version:9.20221003.3.1 * third_party/r8/d8: bmb4lLBpRLAMLRw1TtdElddObY0_tmNi69zHS8ugBiwC..0ji9wClrgOUJelQ_489AiysBnUebh6jZLyQU8BSZQo0C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/6fe4ce825f..d689fca54d * tools/luci-go: git_revision:20c50aa39686d91330c2daceccaa4ef1a0a72ee4..git_revision:45c4b0ebf2c594bbd64adf3f042f3f491c16bbdf * tools/luci-go: git_revision:20c50aa39686d91330c2daceccaa4ef1a0a72ee4..git_revision:45c4b0ebf2c594bbd64adf3f042f3f491c16bbdf * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9b7d6729b5..14ab6399f8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0aaadcf773..0f04c83ca2 * tools/skia_goldctl/linux: UdHMUZDUIpKh3Fkx8MkPeRz_hbu1MnpCmJdM7inIoQ0C..4jQ6gzrqaKCyEn_8V_Y5qXFi7zg2AYJ-OdNJsmywBJUC * tools/skia_goldctl/mac_amd64: F6P1CZGSbpsEUcMbvplibXMpTLn8eJ2JEyFoJNFJRPcC..68Q-YqkF1ut4cqxu8AL0aBux2bqV8J1T1x6L9sOg8g0C * tools/skia_goldctl/mac_arm64: g7lVD9PQ8qtqyTgw31tXGQr3XYgNTGXbmo0SCsi5hJEC..2BbiGimzY0i9eeqhzJAe3mynFtS0uE4wB33voz1XNqYC * tools/skia_goldctl/win: xQDgjyn3X4sbT9v84yOcqZKH28r7ZtHM7EMnTDPGkLMC..v8uUG8MbJk5MqnqE-Oe0lpCWpvwrzmhT4Bb0jKxA-hoC No update to Clang. Bug: angleproject:7722 Tbr: ianelliott@google.com Change-Id: I95d328b0f24f39ab30feb5b5d74c1902f68bfc2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3933806 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 5b3781ec 2022-10-03T16:09:35 Remove namespacing from all ANGLE loaders. This will make it easier to work with pure C files. Bug: angleproject:7731 Change-Id: I2fe9af486af5f339d973c9149f082eb1f2efa8c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3925426 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 309520d0 2022-10-04T10:01:04 Roll SwiftShader from 666fb5f89f5a to 08dfcbb37734 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/666fb5f89f5a..08dfcbb37734 2022-10-04 capn@google.com Remove index parameter for SPIR-V pointer operands 2022-10-03 sugoi@google.com Regres: Update test lists @ 666fb5f8 2022-10-03 sugoi@google.com shaderStorageImageArrayNonUniformIndexing support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I2eb472b67cd70b0243d169abb240810cbeaf6bf6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3933725 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop be8aa9e9 2022-10-01T21:53:14 Test: Add The Gardens Between trace Test: angle_perftests --gtest_filter="*the_gardens_between*" Bug: angleproject:7725 Change-Id: I3160155018d843f57ec6e2cd6455fd2f6e1af580 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3931398 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 5d7c4eca 2022-10-02T02:27:27 Vulkan: Don't flush depth/stencil on color blit When syncing the read framebuffer for blit, deferred clears are picked up for the attachments that are not being synced. They are then redeferred so a future command would pick them hopefully as loadOp. This change improves the frame time of Pretty Derby on Pixel 6 by ~23%. Bug: angleproject:7727 Change-Id: Ie7d84c58315cd09204e5229f1ec73605d5a7f639 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3931973 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 1d73bad5 2022-10-01T22:50:48 Vulkan: Fix reclear of rendered-to depth/stencil An optimization drops re-clears of images to the same value. When a render pass does: - clear - render - store the "cleared" status of the image was removed because at the end of the render pass, the image no longer has the cleared value. However, this was mistakenly only done for color, but should have been done for depth and stencil as well. Bug: b/239430388 Change-Id: Ib99e0df460eaa82ce87b593276abd9b07f0a8375 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3931972 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott 34977cc5 2022-10-03T11:55:28 Supress vkDestroySemaphore-semaphore-01137 Bug: angleproject:7729 Change-Id: If93b6411bed472417d62f8e63682991a493dc526 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929750 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Ian Elliott <ianelliott@google.com>
Junji Watanabe 4bcfc270 2022-10-03T11:19:02 Install CIPD ninja using DEPS See chromium/src's CL https://crrev.com/c/3869740 for the context. Bug: chromium:1340825 Change-Id: I6ff84c6bd3402b0a5301779af04bfee4bd26cccf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929902 Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 485f4d48 2022-10-03T07:03:09 Roll Chromium from 82e52bf17d2f to 34801c7ce64b (613 revisions) https://chromium.googlesource.com/chromium/src.git/+log/82e52bf17d2f..34801c7ce64b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2d2482275f..0a1188f24a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cccaf48c82..9174abb6ac * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/5ee02b2993..2e919977e0 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/5c3e02e92a..20a144a49a * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/7ff728a977..08ebcbe7b6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/94b0e722f5..6ff813a5ed * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..16eb727884 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e3ed6a8e01..a724859f7a * third_party/fuchsia-sdk/sdk: version:9.20220929.2.1..version:9.20221002.2.1 * third_party/r8/d8: YRMWFybrAcIrgAxXJdeWJ3Qn_MbhEUGC5vZAcOAHnJIC..bmb4lLBpRLAMLRw1TtdElddObY0_tmNi69zHS8ugBiwC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/cbb6b98dc2..6fe4ce825f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c398c4a9c1..a5e0d72349 * tools/luci-go: git_revision:78063b01b53dd33a541938207b785cc86d34be37..git_revision:20c50aa39686d91330c2daceccaa4ef1a0a72ee4 * tools/luci-go: git_revision:78063b01b53dd33a541938207b785cc86d34be37..git_revision:20c50aa39686d91330c2daceccaa4ef1a0a72ee4 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/faa6164498..9b7d6729b5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3cb8993fff..0aaadcf773 * tools/skia_goldctl/linux: WBDrUDeM_a9K-F0R-4P29K3JwXJUEWawXi_gTzC_kFgC..UdHMUZDUIpKh3Fkx8MkPeRz_hbu1MnpCmJdM7inIoQ0C * tools/skia_goldctl/mac_amd64: MQ13YYzbw_7X4YyfuuDuR8BSjHqdE2fc6Rrv6-SjmRMC..F6P1CZGSbpsEUcMbvplibXMpTLn8eJ2JEyFoJNFJRPcC * tools/skia_goldctl/mac_arm64: IJsWDjGmEqVcNpRYh5ESn0o-zH19w6FWY8osQVIQS6oC..g7lVD9PQ8qtqyTgw31tXGQr3XYgNTGXbmo0SCsi5hJEC * tools/skia_goldctl/win: GFphHdC69wbrz1vjJDhfiJCezaivApJ54F036JCnBdsC..xQDgjyn3X4sbT9v84yOcqZKH28r7ZtHM7EMnTDPGkLMC No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I4dc226ba164b57962026903f125f8dd7311fd1a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3932011 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton a7dc51f2 2022-10-01T08:49:11 Add a framebuffer fetch implementation of PLS The framebuffer fetch implementation works by attaching PLS backing textures to the framebuffer, and then rewriting PLS uniforms as "inout" fragment variables. The compiler's existing machinery takes it from there and makes it work on GL and Vulkan, and soon Metal. EXT_shader_framebuffer_fetch is now the preferred backend for pixel local storage, but we also use EXT_shader_framebuffer_fetch_non_coherent if shader images can't be coherent. This is especially interesting for Vulkan, since noncoherent framebuffer fetch is possible without any extensions. Bug: angleproject:7279 Bug: angleproject:7683 Bug: angleproject:7684 Bug: angleproject:7724 Change-Id: I33f3b2c6df9a5709969d9165c448ea71b096c9e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3900142 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Cody Northrop 9905dabe 2022-09-30T00:47:17 Tests: Add Darkness Rises trace Test: angle_perftests --gtest_filter="*darkness_rises*" Bug: angleproject:7719 Change-Id: I0b99678003662c5e0bb89a5b78490276224a8eaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929333 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 2f05dd9f 2022-09-30T22:52:16 Roll VK-GL-CTS from 7bbdc916a414 to 3739dbc26ccf (13 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7bbdc916a414..3739dbc26ccf 2022-09-30 piotr.byszewski@mobica.com Test cmdCopyBuffer with unaligned offsets & sizes 2022-09-30 ziga@lunarg.com Fix tracking image layout in load_store_op_none tests 2022-09-30 gleese@broadcom.com Enable extended_dynamic_state tests for VK1.3 2022-09-30 zzoon@igalia.com Add alpha to one tests with single sample. 2022-09-30 zzoon@igalia.com Add FSR tests with ImageView VK_NULL_HANDLE for dynamic rendering. 2022-09-30 zzoon@igalia.com Add more tests for occlusion and statistics query. 2022-09-30 ziga@lunarg.com Add tests for transfers with uneven vertical sizes 2022-09-30 michal.jakubek@mobica.com Apply BLAS pool to ray_tracing_pipeline.build.* tests 2022-09-30 marcin.zajac@mobica.com Add tests for transformFeedbackStreamsLinesTriangles 2022-09-30 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main 2022-09-29 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main 2022-09-28 souravp@nvidia.com VKSC check offline pipeline compiler result. 2022-09-27 aitor@lunarg.com Merge branch 'dev/VK_EXT_legacy_dithering' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,romanl@google.com Change-Id: Ifbdaa13b463b9d3f711123082d8ad833d5156413 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3930874 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Hailin Zhang 836cc5e2 2022-09-09T22:06:22 Vulkan: add etc to bc compute transcoding. use compute shader to transcode etc format to bc format. Bug: b/243398683 Change-Id: Idbd0820a2df8d92fe690055dae2933bc559e9bfd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3888501 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Hailin Zhang <hailinzhang@google.com>
Cody Northrop f7a5cce1 2022-09-29T10:42:26 Tests: Add Life is Strange trace Test: angle_perftests --gtest_filter="*life_is_strange*" Bug: angleproject:7711 Bug: angleproject:7723 Change-Id: I83d9d58270a80435dba8991875b20a215372334f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3928205 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Chris Dalton a81679bc 2022-09-26T23:56:34 Support EXT_shader_framebuffer_fetch on GLES All the frontend functionality for EXT_shader_framebuffer_fetch is already present, but only supported on Vulkan. This change wires it up for the native GLES backend as well. Bug: angleproject:7279 Bug: angleproject:7703 Change-Id: Ie1fce79e08a78662c8af65d33f3d8417c96cf58e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3920577 Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0