kc3-lang/angle

Log

Author Commit Date CI Message
James Darpinian 27af0b2d 2020-10-19T16:49:48 Reland "ANGLE_platform_angle_device_context_volatile_* extensions" This is a reland of e70f6aa679dd72eca5c88c71b0932928e92d6067 Original change's description: > ANGLE_platform_angle_device_context_volatile_* extensions > > Change from Kimmo Kinnunen downstream: > https://bugs.webkit.org/show_bug.cgi?id=216106 > > Add two extensions for EAGL and CGL backends to declare the > underlying platform context being "volatile". It means that > the thread-global current context is being modified behind > ANGLE. If ANGLE context is marked volatile for a particular > API, it will sync the underlying context for every EGL > function that needs the context. Most intuitive use is > for the client to call eglMakeCurrent before calling any > gl function if the client knowns the platform state might > be dirty. > > Implement eglReleaseThread for EAGL and CGL backends. > Releasing thread will unset the platform current context. > > Fix a bug of omitting EGL_ANGLE_device_eagl from being > advertised. > > Bug: angleproject:5104 > Change-Id: I1ec98ad35bc0caada23556ae8697fdef20f65b1a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2486548 > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:5104 Change-Id: I88265625a4bb4c1412532768d17d7b4356c7be41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508842 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Geoff Lang fa616931 2020-09-03T14:58:03 Mark uniform samplers in an array unused per element https://bugs.webkit.org/show_bug.cgi?id=215630 Fix an issue with the OpenGL backend where entire arrays of uniforms would be marked as unused if a single element was reported as unused by the driver. Bug: angleproject:5006 Change-Id: I9bbb75a5f113472393e8d9f1fb60a7865aa9529a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2486540 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Shahbaz Youssefi a0e91016 2020-10-30T10:01:36 Vulkan: Don't break the render pass on scissor change Prior to this change, the render area was decided when the render pass was started, and remained fixed. If a small scissor was initially used, this created a render pass with a small area. If then the scissor region was expanded, the render pass was broken. This change instead expands the render area on scissor change to avoid breaking the render pass. If glInvalidateSubFramebuffer previously successfully resulted in storeOp=DONT_CARE, this optimization may need to undo that. As a result, the invalidate area is stored in the render pass and if the render area grows beyond that, invalidate is undone. Bug: angleproject:4988 Change-Id: I4e8039dec53a95a193a97cb40db3f71e397568d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508983 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya bf1a4627 2020-11-04T12:48:47 Vulkan: Enable GL_EXT_buffer_storage extension This change 7bbe497 accidentally disabled support for GL_EXT_buffer_storage extension for the Vulkan backend, enable it again. Bug: angleproject:5056 Tests: angle_end2end_tests --gtest_filter=BufferStorageTestES3*Vulkan Change-Id: If4da2fe2c3e8b098875c89643d366f15fd0ea8b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519875 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott 74e50cac 2020-11-04T12:47:52 Vulkan: Suppress VUID-VkImageViewCreateInfo-usage-02652 Bug: angleproject:5309 Change-Id: Iafe91565138a5b94c482aeff7607d09c10d2aeaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519874 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6372a56f 2020-11-04T14:07:03 Gold trace tests: Add logging for filter misses. The prior fix still didn't work. Add logging to debug why. Bug: angleproject:5299 Change-Id: I758cfa87066e1cdf4a5d1289c030943e9bded58d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519400 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 4989667a 2020-11-03T16:28:37 Vulkan: Make ImageHelper::flushStagedUpdates take gl::LevelIndex More consistent with the rest of the public functions in this class. Bug: angleproject:4891 Change-Id: I72c7c3d21f8287cc1711772671c6e7ad524fd096 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518179 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 6ef8f848 2020-11-04T11:10:48 Trace Gold Tests: Fix filter name. Was incorrectly checking the individual test name instead of the full name including the test suite. Bug: angleproject:5299 Change-Id: I60df15bf1a748ce24d54f56b48ffe6eaca2ba54b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519396 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Le Hoang Quyen ca8b58d7 2020-10-25T22:32:45 Metal: Enable dEQP GLES3 tests on AMD Bug: angleproject:2634 Bug: angleproject:4235 Change-Id: I159b635b9d02b019a2012da24801a4bdd090961e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497340 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Ian Elliott 88b46b9f 2020-11-03T12:08:42 Vulkan: VVL errors once again cause dEQP tests to fail Was previously setting the global g_debugAnnotator class to DebugAnnoatorVk, and only when a desktop environment variable or Android setting indicated to. Setting to DebugAnnoatorVk was equated with a desire to generate Vulkan debug markers. Will now set g_debugAnnotator to the generic LoggingAnnotator class when Vulkan debug markers are not needed. That will enable VVL errors to again cause dEQP tests to fail. Bug: angleproject:5291 Bug: angleproject:5304 Change-Id: Ib9169037423dd9de3f799e77f7f47468eeeeac20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518168 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 23d1f9b4 2020-11-02T13:00:08 Vulkan: Add support for VK_KHR_image_format_list extension GLES sRGB extensions allows for a texture to be respecified, with say the sRGB_override extension, which will require us to reinterpret the data in the texture in sRGB colorspace (or linear depending on the format of the texture). If the underlying ICD supports VK_KHR_image_format_list extension we create a texture's backing VkImage with the VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT enabled since we already know the format we might need to reinterpret the texture as. Bug: angleproject:3609 Bug: angleproject:4561 Bug: angleproject:5281 Change-Id: Ia4bed596ed3000f8af1a8fd73fb8e6c2cb9b5d6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2513110 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Le Hoang Quyen 8a275449 2020-10-25T03:22:10 Metal: Add ES3_METAL to ANGLE_ALL_TEST_PLATFORMS_ES3 Bug: angleproject:2634 Change-Id: Iacc3aaf17565c7b16879897db4b9dac16826d829 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494526 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Xiaoxuan Liu db00732e 2020-11-04T10:24:39 Vulkan display mode: fix skia build failure Separate angle_use_vulkan_display into another declare_args() for skia build. Bug: angleproject:5214 Change-Id: I9f829b8a8c95947832f69ca2d78e050aa60ce8ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519171 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Le Hoang Quyen 9ff063e9 2020-10-25T03:08:25 Metal: fix max varyings, copyImage between mips, depth fmt - GLSLTest_ES3.MaxVaryingWithFeedbackAndGLline failed before because gl_Position takes up one slot from max varyings on Metal back-end. FIXED - Previously, copyImage() between mips of the same texture would fail. Due to the read RenderTargetMtl is released before the copy happens. FIXED - GL_DEPTH_COMPONENT24 texture data upload didn't work due to the source 32 bit depth data wasn't handled properly. FIXED - D24S8 format will be disabled on AMD for now, it will be converted to D32S8 instead. Bug: angleproject:2634 Bug: angleproject:5235 Bug: angleproject:5242 Change-Id: Ie7082f0545c0885ce5ec72df8a7ec4ee5d5de4b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494525 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 4707feaa 2020-11-04T10:01:07 Roll SwiftShader from b5bf82693f85 to 19f01495a8a1 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/b5bf82693f85..19f01495a8a1 2020-11-04 capn@google.com Fix LLVM alloca array size type 2020-11-04 capn@google.com Resolve MSan symbols dynamically 2020-11-04 capn@google.com Switch Chromium/Fuchsia to use the LLVM ORCv2 JIT 2020-11-03 nicolascapens@google.com Clarify the ICD/loader compatibility 2020-11-03 swiftshader.regress@gmail.com Regres: Update test lists @ b5bf8269 2020-11-03 capn@google.com Set LLVM_ENABLE_ABI_BREAKING_CHECKS for Debug builds only If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I9f78b5ccdfaa645092c5b01967d51535a6959eb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518390 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d896c8d3 2020-11-04T10:01:13 Roll Vulkan-ValidationLayers from 1b2f8307f21d to 128608f6da3a (17 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1b2f8307f21d..128608f6da3a 2020-11-03 mark@lunarg.com tests: Add 2718 security VUID tests 2020-11-03 mark@lunarg.com stateless: Fix clang-formatting issues 2020-11-03 mark@lunarg.com stateless: Comment out unused legacy vuids 2020-11-03 mark@lunarg.com stateless: Output correct VUID for validate_string_array 2020-11-03 mark@lunarg.com stateless: Remove non-VU pNext chain cycle check 2020-11-03 mark@lunarg.com stateless: Remove warnings from viewport validation 2020-11-03 mark@lunarg.com stateless: Use correct VUIDs for drawCount check 2020-11-03 jzulauf@lunarg.com syncval: Add raster order rules to load op validation 2020-11-03 jzulauf@lunarg.com syncval: Add layout transition info w/o prev access 2020-11-03 jzulauf@lunarg.com syncval: Remove unsafe/unused code path. 2020-11-03 jzulauf@lunarg.com syncval: Support range gen w/ empty subres ranges 2020-11-03 jzulauf@lunarg.com syncval: Add dst scope barriers to all ILT 2020-11-03 jzulauf@lunarg.com tests: Add multi dependency syncval test 2020-11-03 jzulauf@lunarg.com syncval: Multidep subpass layout transition rework 2020-11-03 jzulauf@lunarg.com syncval: Simplify input attachment read tracking 2020-11-03 jzulauf@lunarg.com syncval: vkCmdPipelineBarrier multidep support 2020-11-03 jzulauf@lunarg.com syncval: Cleanup input attachment read tracking If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Ie499781f65a856f4c8c3f6010e2a022f19aec362 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519413 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0297981c 2020-11-04T10:01:18 Roll SPIRV-Tools from 5735576f87be to bcf5b211db92 (4 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5735576f87be..bcf5b211db92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Id1a1dfa8a43cd266a1d6c5bd4b2c1f8c11bbb1b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518391 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Le Hoang Quyen cb6176f3 2020-09-29T01:08:00 Metal: Support tri-fan & line-loop with primitive restart Triangle fan: - If primitive restart is NOT enabled and there is no active render pass, use Compute Shader to generate indices. - If primitive restart is enabled, use CPU to generate indices. Line loop: - If draw non-instanced without primitive restart, generate and draw only one additional last segment (fastest). - If draw instanced, primitive restart is NOT enabled, and there is no active render pass, use Compute Shader to generate indices (OK). - Otherwise, use CPU to generate indices (slowest). Also Disable OcclusionQueriesTest.ClearNotCounted failure on NVIDIA. Bug: angleproject:2634 Bug: angleproject:5307 Change-Id: Ia5529825807a964f5fcb2a4af8844778896cd42a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2435859 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 945791e1 2020-11-04T07:00:37 Roll Chromium from ce54b897663f to 9c36b5262108 (443 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ce54b897663f..9c36b5262108 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/af988c68a6..465d72166f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/98881a1297..95fa84e35d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2c417bea4f..616adef0a3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b8b4d61dd3 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8cd0fc1ed5..e84c9a3fd7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4c43492bfa..c37ae578a8 * tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb * tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb * tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ecd52ecc48..28a51d0a2e No update to Clang. Bug: angleproject:5124,angleproject:5273,angleproject:5297,angleproject:5298 Tbr: courtneygo@google.com Change-Id: I402d2869b2997b144fb623d09526a27dd0ba6ad6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518941 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 265c5fa9 2020-11-02T21:50:25 Vulkan: Fix scissor update in FramebufferVk::syncState A previous change [1] made FramebufferVk::syncState update scissor and rasterization samples only when the DRAW framebuffer is synced. This is incorrect as the READ framebuffer is synced before the DRAW framebuffer, and if the two are the same, the latter is discarded. Very few functions sync both READ and DRAW framebuffers when they are identical. A test is tailored to expose this bug. [1]: https://chromium-review.googlesource.com/c/angle/angle/+/2510013 Bug: angleproject:4988 Change-Id: I6123ac18dded938171bc90a04d4d81f1b42a1694 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2515742 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Xinghua Cao dc1c1cb5 2020-08-12T13:30:26 Restrict to translate uniform block to StructuredBuffer We had translated an uniform block only containing a large array member into StructuredBuffer instead of cbuffer on D3D backend for slow fxc compile performance issue with dynamic uniform indexing. Now we add more conditions to restrict the translation. Only indexing operator is allowed to operate on this uniform block variable. And we also restrict the types of uniform block's member. Bug: angleproject:3682 Change-Id: I992b7890d84fcaa6169722af6d7e14785526d48a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2351728 Commit-Queue: Xinghua Cao <xinghua.cao@intel.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Ian Elliott 3980b1f8 2020-10-27T10:01:05 Refactor FrameCapture.cpp to use common utility The frame-capture-specific AndroidGetEnvFromProp() function has been ported to the general utility, GetEnvironmentVarFromAndroidProperty(). Bug: b/170249632 Change-Id: I97de8205ceef140dfd8fab8e6f2d52b90cd996cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2502772 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 8afe3f17 2020-11-03T10:55:31 Vulkan: Fix use of uninitialized data in staged clears When depth/stencil data are staged, only the depthStencil field of VkClearValue is initialized. However, when comparing staged clears, memcmp is used which also compares the extra bytes in the aliasing color field. Bug: chromium:1144491 Change-Id: Ic384ba792e9fd199d8e9c3e534ccdc6ea65ee9b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2517244 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang a51b57fa 2020-10-30T10:00:05 Revert "Vulkan: Add features to modify sampling parameters" Bug: b/167404532 Change-Id: Iae19dfe165074e8c01216312bddd744c4fb504a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2510012 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Courtney Goeltzenleuchter 64f04516 2020-11-03T13:36:11 Fix presubmit failure with recent glslang update Recent glslang update moved a #include inside a #if statement. The scripts/export_targets.py presubmit check doesn't know how to handle that so need to exclude the header in the script. Bug: angleproject:5294 Change-Id: I68563d59983ce2053f9e03c84b2736721db9fe95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518175 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 302f234d 2020-11-03T14:55:55 Gold Trace Tests: Handle test filter. This will allow the Chromium recipe retry mechanism to work properly. That in turn will let the recipe properly fail tests that pass without the patch and fail with the patch. Bug: angleproject:5299 Change-Id: Ic744e125779c6bc6a091e1ed89ac1be6b97fd942 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518172 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3e5b6f81 2020-10-31T12:33:28 Enable writing histogram-set-json-format. This uses the protobuf histogram functionality to build up a histogram set. The test suites then output the histograms to JSON. This is only implemented for angle_perftests. Bug: angleproject:5161 Change-Id: Ia5a7868e8d8dcf4f13d83115ae622828c63ef0d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2482295 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 39adaeb0 2020-11-03T13:15:41 Don't print reuse warning when forcing new displays. Bug: angleproject:5274 Change-Id: I2c21a0f097398c508cc116217e3cb97d78a795b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518241 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Stuart Morgan ed90c991 2020-11-02T15:22:33 Fix copyright line format Removes a double comment indicator from a copyright line. This can break scripts that parse files to extract copyright and license information. Bug: None Change-Id: I891d865020b64a4ae3dbe9dee369471e3d0368bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2516206 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 6a4c9bbd 2020-11-03T11:13:18 Roll SPIRV-Tools from f7da52775714 to 5735576f87be (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f7da52775714..5735576f87be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I0601d74d3d121a076d319c044750967cfc3747e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2516491 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 10bd755d 2020-11-03T10:01:27 Roll Vulkan-Tools from 3f747ee91e3b to 51c1c5ab56d5 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/3f747ee91e3b..51c1c5ab56d5 2020-11-02 nathaniel@lunarg.com mockicd: Remove VK_KHR_portability_subset If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I344cb4e507e9d6cb6cb71a717e4254a154d8fd2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2516486 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d3304848 2020-11-03T10:01:12 Roll Vulkan-ValidationLayers from e46399ddd2c7 to 1b2f8307f21d (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e46399ddd2c7..1b2f8307f21d 2020-11-02 tony@lunarg.com layers: Fix checks for 02502 and 02503 2020-11-02 tony@lunarg.com gpu: Report OpLine info even if no source 2020-11-02 tony@lunarg.com tests: Add test for variable count descriptors 2020-11-02 tony@lunarg.com layers: Add validation for variable descriptor count 2020-11-02 tony@lunarg.com layers: Fix error message 2020-11-02 jeremyg@lunarg.com syncval: Add override keyword to ValidationObject method overrides. 2020-11-02 s.fricke@samsung.com layers: Relabel vkCmdDrawIndirectByteCountEXT VUs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I90db3ff50f5f4ac44fa3d6df41eb2c8dc60719f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2516485 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8f81aa02 2020-11-03T10:01:07 Roll SwiftShader from 7751fe38f474 to b5bf82693f85 (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/7751fe38f474..b5bf82693f85 2020-11-03 jari.komppa@siru.fi Add script to verify proper Memset template use 2020-11-02 capn@google.com Set the LLVM module's target triple 2020-11-02 sugoi@google.com Merge changes If776b87d,I27098964 2020-11-02 capn@google.com Consistently remove double colon from llvm namespace 2020-11-02 capn@google.com Emulate gather/scatter for MSan builds 2020-11-02 capn@google.com Prevent 'most vexing parse' issue 2020-11-02 amaiorano@google.com Subzero: fix Ice::BitVector::grow not copying old to new data If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Ic7530ac4dd154ee7aa3c7221db6d34007f904996 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2516484 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3b9b77ec 2020-11-03T07:01:07 Roll Chromium from a64ace71870c to ce54b897663f (254 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a64ace71870c..ce54b897663f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/787a783b96..af988c68a6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/289a835ec8..2c417bea4f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..52f3a2ddb1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eb065289a4..4c43492bfa No update to Clang. Bug: None Tbr: courtneygo@google.com Change-Id: I3908d8f475866910bde69d21ac0b8f6932f2597c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2516205 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 019e3f77 2020-11-02T17:20:19 Vulkan: Use dst access masks to determine if barrier is needed Src access mask may be 0 with WAR barriers. Bug: angleproject:5290 Change-Id: I798d4c36aa7d3d14db333a7e86794e13c8137f96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514841 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Xiaoxuan Liu 61180d01 2020-10-12T16:40:13 Reland "Add support for Linux vulkan backend with VK_KHR_display" This is a reland of a7bb6a9b15ddeb8497523f8871deb25de2676d9f Original change's description: > Add support for Linux vulkan backend with VK_KHR_display > > Implement Linux simple display mode with vulkan backend > through VK_KHR_display. > > Added value 'EGL_PLATFORM_VULKAN_DISPLAY_MODE_SIMPLE_ANGLE' for > attribute EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE to identify > the new simple display mode. Also reserved > EGL_PLATFORM_VULKAN_DISPLAY_MODE_HEADLESS_ANGLE for headless mode. > > How to enable: > Add > > ``` > use_x11=false > angle_vulkan_display_mode="simple" # default value > ``` > > into args.gn, then compile with linux vulkan args. > > Bug: angleproject:5214 > Change-Id: I1247585b9de8b55df106aba99322281f1c183203 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494320 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:5214 Change-Id: I3921f6cb292c86658f39e739a878baad1ef64dba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2515327 Commit-Queue: Xiaoxuan Liu <xiaoxuan.liu@arm.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Courtney Goeltzenleuchter 6bc362c4 2020-10-18T19:09:47 Allow single threaded CommandProcessor In replacing the legacy CommandQueue code with the threading capable CommandProcessor it would be good to be able to run the CommandProcessor in a single-thread environment. This CL changes the meaning of the feature flags for the commandProcessor and asynchronousCommandProcessing so that enabling commandProcess only changes the code paths to use the command processor but work it still done as part of the submitting thread (e.g. ContextVk). Enabling asynchronousCommandProcessing will cause a separate worker thread to be spawned which will asynchronously process the commands. This allows us to switch to the CommandProcessor without threading and then enable threading once performance issues are resolved. Bug: b/161912801 Bug: b/170329600 Change-Id: I534862b109a7e7708108190b7c3e894071d4c2ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2483580 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Jamie Madill c06a424f 2020-11-02T21:13:39 Test Runner: Robustly handle unexpected crashes. This adds the ability for the test runner to parse unexpected crashes from the stdout. It also processes the stdout to determine which tests failed. Tests that run after the crash are re-tried in a follow-up child process. Will allow for the test runner to handle very crashy test suites and also processes crashes from win-asan and other configs where it is harder to intercept crashes. Bug: angleproject:5251 Change-Id: Iee03130622571580cb7910f4fb097fe3659d75ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2513288 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Mohan Maiya 3fcf17e6 2020-11-02T12:51:35 Vulkan: Bug fix in sRGBDecode logic When a sampler's GL_TEXTURE_SRGB_DECODE_EXT state was toggled between GL_DECODE_EXT and GL_SKIP_DECODE_EXT VkImageViews of the TextureVk object were not being updated. Add sRGB_decode state as part of ImageViewSubresourceSerial so we retrieve the correct VkImageView from the texture cache. Bug: angleproject:3609 Tests: angle_end2end_tests --gtest_filter=SRGBTextureTestES3.SRGBDecodeSamplerParameterToggle*Vulkan Change-Id: I897e461957d408b5a5b4f03fefc05f2e9684c7b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514900 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 59fbb989 2020-11-02T13:27:52 Test Runner: Add ability to retry flaky tests. Bug: angleproject:5273 Change-Id: Ie89559bb0897a04213981aa8fe4e2f2bfe78959a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2513287 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 8e878d95 2020-11-02T19:58:37 Roll VK-GL-CTS from e69b9b7294af to 9e07e4424cd4 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/e69b9b7294af..9e07e4424cd4 2020-11-02 alexander.galazin@arm.com Update Vulkan headers 2020-10-30 rgarcia@igalia.com Test invalid pInheritanceInfo for primary command buffers 2020-10-30 michal.m.pawlowski@mobica.com Add array of images copy tests 2020-10-30 rgarcia@igalia.com Test extended dynamic state vertex data offsets 2020-10-30 michal.m.pawlowski@mobica.com Add push constant lifetime tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC courtneygo@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com,angle-bots+autoroll-info@google.com Change-Id: I65627838c072f3e27af0990e41d210707285a66e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514515 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tom Anderson 11cbd12d 2020-10-29T13:30:04 Remove dependency on //build/config/linux:x11 This is needed for Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/2508226 BUG=chromium:1066670 Change-Id: I61aa2a21e19cb74259413631b654cb45e3e051c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508224 Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 4c91061a 2020-11-02T18:11:49 Roll Chromium from f2fabcd1994c to a64ace71870c (130 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f2fabcd1994c..a64ace71870c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC courtneygo@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/01121614f1..787a783b96 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3e2640a325..289a835ec8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..584ab49109 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e5230a2de4..eb065289a4 No update to Clang. Bug: None Tbr: courtneygo@google.com,jmadill@google.com Change-Id: I4343f24ff8458aaee0195ebd9880e0482afe99c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514581 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 924c3dab 2020-11-02T13:08:16 Expand suppression of new EGL test. This test fails on the older N6P device as well as the N5X. Bug: angleproject:5280 Change-Id: Ie1a2b3b3a296e2e4dbbed69ebff6ce325b46ce95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514638 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 7dc92430 2020-10-30T13:05:05 Noop clear of non-existing attachments. Bug: angleproject:4988 Change-Id: Ib6ff9756ec7ae5aa2b11f4d12932829fe05656d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2511369 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 42e10d3e 2020-10-30T16:36:45 Noop empty-scissor clears Bug: angleproject:4988 Change-Id: I64909292927e20c65141302c9bf5e7ef09af84b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2511370 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 807e6b33 2020-11-02T17:15:03 Revert "Add support for Linux vulkan backend with VK_KHR_display" This reverts commit a7bb6a9b15ddeb8497523f8871deb25de2676d9f. Reason for revert: Failing on Ozone builder, see bug. Bug: angleproject:5289 Original change's description: > Add support for Linux vulkan backend with VK_KHR_display > > Implement Linux simple display mode with vulkan backend > through VK_KHR_display. > > Added value 'EGL_PLATFORM_VULKAN_DISPLAY_MODE_SIMPLE_ANGLE' for > attribute EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE to identify > the new simple display mode. Also reserved > EGL_PLATFORM_VULKAN_DISPLAY_MODE_HEADLESS_ANGLE for headless mode. > > How to enable: > Add > > ``` > use_x11=false > angle_vulkan_display_mode="simple" # default value > ``` > > into args.gn, then compile with linux vulkan args. > > Bug: angleproject:5214 > Change-Id: I1247585b9de8b55df106aba99322281f1c183203 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494320 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> TBR=syoussefi@chromium.org,sunny.sun@arm.com,jmadill@chromium.org,xiaoxuan.liu@arm.com Change-Id: I3e2a2a044c220ed8d25be0d82184e5fba7b9c06a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:5214 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514637 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 53aef103 2020-11-01T08:52:58 Tests: Print warning when we hit display reuse limit. This helps devs reduce test cases that are hit from test ordering. Bug: angleproject:5274 Change-Id: Ia4d2b5f3adffc73a2d4582e3a738fc194729a6ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2513286 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 57f7c9b5 2020-10-29T16:31:46 Vulkan: Fix prerotation bug with glInvalidateSubFramebuffer The area passed to FramebufferVk::invalidateSub is not rotated, but was being compared with the rotated framebuffer dimensions / render area. Bug: angleproject:5264 Change-Id: I2de181bf77ad650418b757a3848395bbdab13d8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508978 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Amy Liu f34ba646 2020-10-30T14:40:22 Fix maxShaderAtomicCounters value. Set maxShaderAtomicCounters to zero when atomic operation is not supported. Some cts tests will only check maxShaderAtomicCounters instead of vertexPipelineStoresAndAtomics before run. Test: dEQP-GLES31.functional.shaders.opaque_type_indexing.atomic_counter.*vertex Bug: angleproject:5272 Change-Id: Iceb4fc13eb26548ccbfaa430501d88f5ba3dfcc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507280 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Xiaoxuan Liu a7bb6a9b 2020-10-12T16:40:13 Add support for Linux vulkan backend with VK_KHR_display Implement Linux simple display mode with vulkan backend through VK_KHR_display. Added value 'EGL_PLATFORM_VULKAN_DISPLAY_MODE_SIMPLE_ANGLE' for attribute EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE to identify the new simple display mode. Also reserved EGL_PLATFORM_VULKAN_DISPLAY_MODE_HEADLESS_ANGLE for headless mode. How to enable: Add ``` use_x11=false angle_vulkan_display_mode="simple" # default value ``` into args.gn, then compile with linux vulkan args. Bug: angleproject:5214 Change-Id: I1247585b9de8b55df106aba99322281f1c183203 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494320 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6865cd7e 2020-11-02T10:01:18 Roll SPIRV-Tools from 34ae8a475754 to f7da52775714 (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/34ae8a475754..f7da52775714 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I844582892f5c97b281a5278c775f7e9f4eb46401 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514097 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4d696180 2020-11-02T10:01:13 Roll Vulkan-ValidationLayers from f673b4e6ebf3 to e46399ddd2c7 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f673b4e6ebf3..e46399ddd2c7 2020-10-30 nathaniel@lunarg.com layers: Fix test error introduced by #2276 2020-10-30 s.fricke@samsung.com layers: Add extra api names to errors 2020-10-30 s.fricke@samsung.com tests: Add SampleMask Array Limit VUID 2020-10-30 s.fricke@samsung.com layers: Add SampleMask Array Limit VUID 2020-10-30 s.fricke@samsung.com layers: Add table for buffer image copy VUs 2020-10-30 s.fricke@samsung.com layers: Add VK_EXT_4444_formats support 2020-10-30 mark@lunarg.com contributing: Updated for Travis CI migration 2020-10-30 mark@lunarg.com readme: Updated for Travis migration 2020-10-30 s.fricke@samsung.com layers: Add missing 1.2 overload functions 2020-10-30 s.fricke@samsung.com tests: Add input attachment aspectMask/layout 2020-10-30 s.fricke@samsung.com layers: Remove non-input aspectMask check If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ic67f63c01db7d16723cc4c50f907f915de04dc6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514096 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8a174114 2020-11-02T10:01:06 Roll glslang from 740ae9f60b00 to 142cb87f803d (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/740ae9f60b00..142cb87f803d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Icc91ec0899bd945e43b654aec3894ba31b987f60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2513789 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 64365c9d 2020-11-02T10:01:07 Roll SwiftShader from e6c9497255c6 to 7751fe38f474 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/e6c9497255c6..7751fe38f474 2020-11-02 jari.komppa@siru.fi Ignore third party libraries during presubmit 2020-10-30 sugoi@google.com Merge changes Idde36437,Id477959d,I68027fa8,I8e6cf710 2020-10-30 jari.komppa@siru.fi Add check for vtable in memset template If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I415232bac6e261431e3389fd14f07443f2760518 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514095 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 74aa2f96 2020-11-02T10:01:25 Roll Vulkan-Headers from 320af06cbdd2 to 87451c55aa8b (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/320af06cbdd2..87451c55aa8b 2020-11-02 oddhack@sonic.net Update for Vulkan-Docs 1.2.159 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: Ia7e9110a6b26d2ec995b82c56d23c4466d43f6bd Bug: None Tbr: ianelliott@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2512391 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ed916ddf 2020-11-02T10:01:27 Roll Vulkan-Tools from ee0de094ddff to 3f747ee91e3b (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ee0de094ddff..3f747ee91e3b 2020-10-29 shannon@lunarg.com build: Update known-good files for 1.2.158 header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Idcd263a2d1d148452097bbfad9a08a6d7d394b66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514098 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4d252a5b 2020-11-02T07:00:41 Roll Chromium from 1e88b939ff30 to f2fabcd1994c (528 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1e88b939ff30..f2fabcd1994c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5cdd7aaa22..01121614f1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/98789ba90c..3e2640a325 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..dcd4fb3a50 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/12b3cd36d8..e5230a2de4 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/88a308c1a4..ecd52ecc48 No update to Clang. Bug: angleproject:2634,angleproject:4235 Tbr: geofflang@google.com Change-Id: I090e3caa1d0bca8b95c315d7673c7ebe348910ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2512737 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 068bb086 2020-10-31T12:33:28 RapidJSON: Enable std::string handling. This will be useful for histogram output to JSON. Bug: angleproject:5161 Change-Id: Ifed3dfcd10e0cee94b7c13b9c92fdc351329d5c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2513084 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 97843bda 2020-10-30T17:03:36 Vulkan: Fix EGL Surface robust init. The error here was related to using a single cache variable for the robust init setting for all the surfaces in a DisplayVk. Fix this by passing down the robust init setting from the SurfaceVk to image init. Bug: angleproject:5274 Change-Id: I9bc9c20990268d1d5166411fb53f8f2593fd1971 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2510694 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Le Hoang Quyen 6c618ce3 2020-11-01T16:39:36 Metal: Suppress UniformBufferTest.ManyBlocks on Intel Also slightly modified UniformBufferTest.ManyBlocks to add 2nd draw call with modified uniform buffer. Bug: angleproject:5283 Change-Id: Ib192a9143ce7c492537dfcfee7af2ae17220815a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2512625 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 9c66a092 2020-10-30T09:56:19 Vulkan: Update scissor only in DRAW framebuffer's syncState Bug: angleproject:4988 Change-Id: I16f9268cdc221c84f962bbb9bd06ef5b19a6ac05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2510013 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Le Hoang Quyen 8a50b42b 2020-10-24T19:29:12 Metal: Convert index & vertex format on GPU when possible. - When converting vertex buffer: - if there is no render pass active, use compute shader to convert. - if there is a render pass active and device supports explicit memory barrier then convert the buffer in vertex shader with direct buffer write and insert a memory barrier. - if there is a render pass active and device doesn't support explicit memory barrier then convert the buffer on CPU. Bug: angleproject:2634 Change-Id: I5346e3a2adb855f40e46a3912d9db404a4482e0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2434025 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Le Hoang Quyen ed23dc84 2020-10-24T19:12:32 Metal: default integer attribs & offset mod for idx conv. - Support default integer attributes. - When converting index buffer, use offset modulo instead of offset to reduce number of conversions if application uses many different offsets to the index buffer. Bug: angleproject:2634 Change-Id: I97aa9ea1826ffc9dbe5784fe5b5af2f99df63e2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494524 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Le Hoang Quyen 83539557 2020-09-27T16:27:16 Metal: Implement texture swizzle Only enabled on macOS 10.15 and iOS 13.0 for now. Bug: angleproject:2634 Change-Id: Ic44a245198e32f076e429312cae844c510e864d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2433333 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
angle-autoroll 76ca9f36 2020-10-31T02:14:10 Roll Vulkan-Loader from 428654245ad3 to 07bbf14a831b (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/428654245ad3..07bbf14a831b 2020-10-30 shabbyx@gmail.com Revert "Generate libvulkan.so.1 on Linux instead of libvulkan.so" 2020-10-30 xantares09@hotmail.com Add an option to disable MASM Bug: angleproject:5216 Bug: chromium:1143750 Bug: chromium:843346 Change-Id: I39a62314bef79c7f81f15e99b1c1b8709a107e40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2512405 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 09932e04 2020-10-29T00:31:49 Vulkan: Support emulated pre-rotation in dEQP testing Similarly to end2end tests, the window dimensions are swapped with emulated prerotation at 90 and 270 degrees, while maintaining to the application that dimensions are as requested. The following new command line argument can be used to select an emulated prerotation: --emulated-pre-rotation=90 --emulated-pre-rotation=180 --emulated-pre-rotation=270 For example: $ ./angle_deqp_gles2_tests --use-angle=vulkan \ --deqp-case=*draw* \ --emulated-pre-rotation=270 Additionally, the deqp test expectations can be marked with the following new tags to add suppressions for failing tests under prerotation: PREROTATION PREROTATION90 PREROTATION180 PREROTATION270 Bug: angleproject:4901 Change-Id: I7a68c1a1e7da4366cde981469c589d8d900c40c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506810 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill bef8124f 2020-06-24T11:14:50 Output unknown enum to aid debugging When investigating issues with apps it's handy to see the actual enum value, not just that it's an invalid value. Based on http://crrev.com/c/2182578 by Courtney Goeltzenleuchter. Bug: b/155487768 Change-Id: I91611cb620a3bf2d302d667e0f168ca5cb6c9d3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507637 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 8f36b846 2020-10-29T15:13:55 Vulkan: Optimize glFramebufferSubInvalidate If glFramebufferSubInvalidate() is called with an area that covers the whole framebuffer, behave as if glFramebufferInvalidate() is called. This allows deferred clears to be removed for example, and attachment contents to be marked undefined. Bug: angleproject:4988 Change-Id: Iff3f291ea6c07abccc2740174d0451b432ac5da8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508977 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Le Hoang Quyen aff43fa0 2020-10-25T16:12:59 Metal: prepare to run dEQP GLES3 tests Bug: angleproject:2634 Bug: angleproject:4235 Change-Id: I6618b9de94ce88f8cbf81a163d0821b25ab07186 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494528 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Geoff Lang 8ace36f8 2020-10-30T09:51:16 Revert "Add a Vulkan feature to compress float32 vertex formats." Bug: b/167404532 Bug: b/161716126 Change-Id: I95157a006d5c1fd2d3c0c2c2be37fa0403c07f93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2510011 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill 3fe652d0 2020-10-29T08:54:57 Add option to disable SwiftShader when retracing. Bug: angleproject:5133 Change-Id: I589252d7eb9648a37a98f896c2a14462b2b34c48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506492 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Jamie Madill 02deb199 2020-10-29T08:54:56 Write export labels into replay functions. This will allow them to be recaptured in such a way that they can be built into separate modules. This is building towards separate binaries for each trace. Bug: angleproject:5133 Change-Id: I306204e69a6d754282193f44055dbc85ccb01e9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506491 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Jamie Madill 42ad0279 2020-10-24T10:44:12 Omit types in EVENT macros. The type information is redundant with the parameters. Cleans up both the debugger and text-based traces. Bug: b/170249632 Change-Id: I00f96dc1d69ec7a8c5ca24b1a275f3bc7c29d376 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507636 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll e680818d 2020-10-30T10:01:12 Roll Vulkan-ValidationLayers from a72e7b987746 to f673b4e6ebf3 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a72e7b987746..f673b4e6ebf3 2020-10-29 shannon@lunarg.com build: Reconcile final 158 VUID inconsistencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Icdc92303ef357bdb2f5390402af65c0d8209e82e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2509672 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a8c01862 2020-10-30T10:01:07 Roll SwiftShader from c1839ee3cedd to e6c9497255c6 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/c1839ee3cedd..e6c9497255c6 2020-10-29 capn@google.com Fix LLVM pointer element type 2020-10-29 capn@google.com Avoid false-positive MSan error for thread_local 2020-10-29 capn@google.com Update Marl to 3285a2dfb 2020-10-28 capn@google.com Temporarily support both ORCv1 and ORCv2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ibcf37e0128989e89d6e5ec2cf5033f1cf2d599f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2509671 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d811c4e3 2020-10-30T07:02:44 Roll Chromium from 80c364fa8e53 to 1e88b939ff30 (901 revisions) https://chromium.googlesource.com/chromium/src.git/+log/80c364fa8e53..1e88b939ff30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/899545e432..5cdd7aaa22 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e74c871704..98789ba90c * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d24a1910b9..dbf0550693 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..24bd418544 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f9b4a22424..12b3cd36d8 * tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596 * tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596 * tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1d51f2aa14..88a308c1a4 No update to Clang. Bug: angleproject:2930,angleproject:3020,angleproject:3111,angleproject:3481,angleproject:5213,angleproject:5227,angleproject:5259 Tbr: geofflang@google.com Change-Id: I41975759f796173e010b3f986815ff845f3b2da0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508985 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 257b9ad9 2020-10-29T12:40:33 Add a perf test for scissored draw calls Bug: angleproject:4988 Change-Id: I59facc66aaa2af216d3a6c6ef1e4efa934a45cb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506779 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 39b777c6 2020-10-29T16:55:06 Capture/Replay: Two cleanups. This changes from returning a vector to directly returning a pointer to the binary data for the serialized state. The second cleanup is to use a ContextID as a wrapped type which simplifies the output formatting code. Bug: angleproject:5247 Change-Id: Ieb8afdb9326a12968dd2d69c05e1ed811b93abff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506198 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 04d7be3f 2020-10-29T20:40:48 Skip InstancingTest.NonIndexed* with non-zero Offset on Mac Mini 8.1 Bug: angleproject:5271 Change-Id: I644b28670ce0501407797f7ae7e749a66a63d84e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508975 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 646cf5b2 2020-10-29T20:22:38 Skip EXTMultisampleCompatibilityTest.DrawAndResolve on Mac Mini 8.1 Bug: angleproject:5270 Change-Id: I11ec5f9eef3989ac99a618bf5ab707484710a254 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508972 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 655aca7b 2020-10-29T20:13:23 Suppress 2 DepthStencilFormatsTest.DepthStencilReadback on MacMini8.1 DepthStencilFormatsTest.DepthStencilReadback_Float/ES2_OpenGL DepthStencilFormatsTest.DepthStencilReadback_UInt/ES2_OpenGL Bug: angleproject:5269 Change-Id: I223c80d8c8ac47176d5a4ecdff34f6ce27286284 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508971 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov e77b7624 2020-10-29T19:36:05 Skip ReadPixelsTextureTest.*LayerAttachment*PBO on Mac Mini 8.1 Bug: angleproject:5267 Change-Id: I41a7c7c07701e0236a85becd93f2d23db2cdaa8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508538 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 2bb6a5d1 2020-10-29T20:00:06 Skip WebGLCompatibilityTest.EnablePixelBufferObjectExtensions Crashes on Mac Mini 8.1 Bug: angleproject:5268 Change-Id: I18cab39a8b6a8703e798cd8fb14d498a3a611eec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508969 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Dirk Pranke 5c79613f 2020-10-29T15:10:27 Make sure commit position is a string. In Python 3, you have to be careful to distinguish between bytes and strings when reading from subprocesses; the code to read the commit position was failing to do that in one place. Bug: chromium:1112471 Change-Id: Ifbfba6872f762d7e5d7e356772e93b4a7ee1dfeb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508746 Commit-Queue: Dirk Pranke <dpranke@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten fcd35965 2020-09-29T14:15:51 Vulkan: Make DescriptorPoolHelper a Resource Descriptor pools need to live as long as the descriptor sets that are allocated from them. Using Serials while building a command to judge a pool's lifetime is prone to errors, since a command's Serial value isn't known until the command is submitted, leading to deleting pools too early relative to when the descriptor set is actually used. This CL updates DescriptorPoolHelper to inherit from Resource, so the descriptor pools can be retain()'ed. This allows the Resource's counter to indicate that a pool is in use until the command's Serial is known and can be recorded to indicate when the command completes. This prevents descriptor pools from being destroyed before the command completes (while the descriptor sets are still in use), or even before the command has been submitted. Destroying a descriptor pool resets all of the descriptors that were allocated from it, which can trigger a variety of VVL errors depending on when it's erroneously performed. This CL also adds the necessary retain() calls for the descriptor pools. In particular, the pools need to be retained each time a cached descriptor set that was allocated from it is re-used. This is relatively simple with the current design, since we always clear the descriptor set caches whenever a new pool is allocated, so the descriptor pool binding is always accurate. Bug: angleproject:5030 Test: VulkanMultithreadingTest::MultiContextDrawSmallDescriptorPools() Change-Id: Iac9e7efef338f169a6bf8ac3b2140e03dd326641 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2504457 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Yuly Novikov 1070802c 2020-10-29T17:02:45 Skip Instanced MultiDrawTest.MultiDrawArrays on Mac Mini 8.1 Bug: angleproject:5265 Change-Id: I1d3f1802398472c0da2d00526bd7eb52f6596bea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508532 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill e77e3528 2020-10-29T16:55:06 Gold Tests: Include SHA1 files in trace inputs. This will force "GN analyze" to pick up changes in the gold tests when all that GN sees is a new SHA1 file. In effect a SHA1 change means all the sources in a trace have changed. Bug: chromium:1143507 Change-Id: Idf44045ebd5d2bda9380b339e95d336b6804ce8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508530 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mohan Maiya e895ced6 2020-10-29T09:06:00 Vulkan: Add OES_shader_image_atomic support Add support for shader builtins and enable the extension. Bug: angleproject:3578 Tests: dEQP-GLES31.functional.*image_atomic* Change-Id: Idd45b2ee62efe1474c6c5947c77da64ff2221bf6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2505540 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 4c5630d0 2020-10-29T12:45:46 Disable libcxx_abi_unstable in roll_aosp.sh The definition _LIBCPP_ABI_UNSTABLE breaks std::string in Android AOSP builds, starting with GetHelperExecutableDir(), but others fail later if that's worked around. Instead, we'll disable that flag with a GN arg for AOSP rolls. Bug: angleproject:5263 Test: Build on AOSP and launch Cuttlefish Change-Id: Ia4b293a5ce0b09206f4ed87a5a442e544e2021c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508529 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill a5c9e672 2020-10-29T12:24:58 Add newline when using OutputDebugStringA logging. Prior changes had made it so we no longer were spacing out the output correctly. Bug: None Change-Id: Icf81b579271f2b4c8fa5a1d90d323dc062f23585 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507635 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll a653a9ba 2020-10-29T10:01:04 Roll Vulkan-ValidationLayers from 87b0951f8dba to a72e7b987746 (3 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/87b0951f8dba..a72e7b987746 2020-10-28 mark@lunarg.com tests: Add invalid stride test for GetQueryPoolResults 2020-10-28 mark@lunarg.com corechecks: Added 4519 vuid for GetQueryPoolResults stride 2020-10-28 krzysio.kurek@wp.pl stateless: Add a missing "not" to ValidateGreaterThan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I3c1003765bf75b46f22781458a81e13378ebe451 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507093 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 990684da 2020-10-29T10:01:07 Roll Vulkan-Loader from 8308d6744d50 to 428654245ad3 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8308d6744d50..428654245ad3 2020-10-28 xantares09@hotmail.com Configure vulkan.pc when pkg-config is available If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ic3137a446d4e977d94168c2e9abb1fc23d49974b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507094 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b2e3a2bd 2020-10-29T14:44:38 Roll VK-GL-CTS from 483a71c5130e to e69b9b7294af (10 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/483a71c5130e..e69b9b7294af 2020-10-25 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master 2020-10-25 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master 2020-10-24 alexander.galazin@arm.com Notice of withdrawal of Vulkan CTS 1.1.6.x 2020-10-24 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/master 2020-10-23 mika.vainola@siru.fi ANGLE waiver for GLES XFB array element capture 2020-10-23 siglesias@igalia.com Fix depth/stencil resolve compatibility tests 2020-10-23 ari.suonpaa@siru.fi Fix validation errors in AHB tests 2020-10-23 zzyiwei@google.com Add create and destroy object tests for the VK_EXT_device_memory_report extension 2020-10-23 mikko.tiusanen@siru.fi Add tests for clamping of depth values 2020-10-23 joshua@froggi.es Implement custom border color tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com,angle-bots+autoroll-info@google.com Change-Id: I2cd46cab1b48ccd22233cf4ea938590bab4d0945 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507709 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jonah Ryan-Davis 30083024 2020-10-29T10:52:53 Remove include of nonexistant directory This would include "angle:angle_common" which is not a directory. Bug: b/171848471 Change-Id: Ic4f03b174a4cd4b81470862b3ed79a58b415ad04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507630 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill cb1a3ce5 2020-10-29T10:13:40 Skia Gold: Fix Android stdout parsing. A recent change in Chromium broke how we were parsing stdout for capturing system info on Android. Fix the break and also update some helper scripts to work better when run manually. Bug: angleproject:5261 Change-Id: Iecc00bbe540461ab50ea31b5245b8b38a7250956 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507633 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Geoff Lang 68b95b63 2020-10-29T14:09:08 Revert "ANGLE_platform_angle_device_context_volatile_* extensions" This reverts commit e70f6aa679dd72eca5c88c71b0932928e92d6067. Reason for revert: dEQP failures: dEQP.EGL/functional_get_frame_timestamps_rgb565_no_depth_no_stencil dEQP.EGL/functional_get_frame_timestamps_rgb565_no_depth_stencil dEQP.EGL/functional_hdr_metadata_cta861_3 dEQP.EGL/functional_hdr_metadata_smpte2086 dEQP.EGL/functional_mutable_render_buffer_basic dEQP.EGL/functional_swap_buffers_with_damage_resize_after_swap_buffer_age_clear dEQP.EGL/functional_swap_buffers_with_damage_resize_after_swap_buffer_age_clear_clear dEQP.EGL/functional_swap_buffers_with_damage_resize_after_swap_buffer_age_render dEQP.EGL/functional_swap_buffers_with_damage_resize_before_swap_buffer_age_clear dEQP.EGL/functional_swap_buffers_with_damage_resize_before_swap_buffer_age_clear_clear dEQP.EGL/functional_swap_buffers_with_damage_resize_before_swap_buffer_age_render Original change's description: > ANGLE_platform_angle_device_context_volatile_* extensions > > Change from Kimmo Kinnunen downstream: > https://bugs.webkit.org/show_bug.cgi?id=216106 > > Add two extensions for EAGL and CGL backends to declare the > underlying platform context being "volatile". It means that > the thread-global current context is being modified behind > ANGLE. If ANGLE context is marked volatile for a particular > API, it will sync the underlying context for every EGL > function that needs the context. Most intuitive use is > for the client to call eglMakeCurrent before calling any > gl function if the client knowns the platform state might > be dirty. > > Implement eglReleaseThread for EAGL and CGL backends. > Releasing thread will unset the platform current context. > > Fix a bug of omitting EGL_ANGLE_device_eagl from being > advertised. > > Bug: angleproject:5104 > Change-Id: I1ec98ad35bc0caada23556ae8697fdef20f65b1a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2486548 > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> TBR=geofflang@chromium.org,kbr@chromium.org,jdarpinian@chromium.org,jonahr@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:5104 Change-Id: Ib683625a55a582c39e5a4a0466038cfa6e782e6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507260 Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 3591997b 2020-10-28T14:52:44 Roll Vulkan-Loader from 8e2b7d03ccfd to 8308d6744d50 (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8e2b7d03ccfd..8308d6744d50 2020-10-28 shabbyx@gmail.com Generate libvulkan.so.1 on Linux instead of libvulkan.so 2020-10-27 shannon@lunarg.com build: Update known-good files for 1.2.158 header Bug: angleproject:5216 Change-Id: I74e10c44950f3be05cc12f22b44f1627af08ca81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506196 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill e3eaa60f 2020-10-29T01:40:22 Revert "Tests: Update COD:Mobile trace" This reverts commit 8442ea94eacf56eedf6f2f8046e1e93b4b09ea82. Reason for revert: GN messed up and missed the build. Gold wasn't run so this is likely breaking stuff. Original change's description: > Tests: Update COD:Mobile trace > > Updates to reflect changes in the application. > > Test: angle_perftests --gtest_filter="*cod_mobile*" > Bug: b/164426913 > Change-Id: I207102c10578abe8eb02fe5ce22aef10b6b1d6f9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506076 > Commit-Queue: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> TBR=cnorthrop@google.com,courtneygo@google.com,jmadill@chromium.org Change-Id: I70fec773b7ff3b20eb4ce9d7545f1dc54233e8ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/164426913 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506501 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ian Elliott f418c109 2020-10-28T15:15:15 Vulkan: Document how to turn on debug markers Bug: b/170249632 Change-Id: Ie71a2e9699c3da88dd7e285177bb0ce1520f5bbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506420 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
kmx.io     mail     discord kmxgit v0.4.0