|
d193d51b
|
2024-06-17T22:46:08
|
|
Replace issue ids post migration to new issue tracker
This change replaces anglebug.com/NNNN links.
Bug: None
Change-Id: I8ac3aec8d2a8a844b3d7b99fc0a6b2be8da31761
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5637912
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
434a5b01
|
2024-02-28T19:00:26
|
|
Fix #2 upload_results_to_perf_dashboard usage
Pass output_json_file name as an argument, instead of the open file.
Bug: chromium:40807291
Change-Id: Ia0f52ff3b3a3551bcdcda235ebaa90ae217cea54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5332432
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
|
|
|
f8dac42e
|
2024-02-28T15:06:19
|
|
Fix upload_results_to_perf_dashboard usage
Bug: chromium:40807291
Change-Id: I0a3ca2bfac1a29a9d56b6af15c5f123b0a41f817
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5332430
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
|
|
006fb7b6
|
2023-04-11T14:29:15
|
|
Avoid "KeyError: 'exit_code'" error in failed shard detection
Apparently there are cases where a shard is broken but exit_code is not
present in json. Example build:
https://ci.chromium.org/ui/p/angle/builders/ci/android-pixel4-perf/4038/overview
Bug: chromium:1346781
Change-Id: I7ee5b8cac5da3123e5b57b3bca393db12ce8921a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4414233
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
753d59e9
|
2023-01-10T18:49:54
|
|
Return success when shard(s) failed.
A failed shard might cause the merge script to fail, which messes up
the CI UI and makes it much more difficult to find failed shards:
https://crbug.com/1346781#c112
Bug: angleproject:7299
Bug: chromium:1346781
Change-Id: Ic458002c38243ae605665bac6c3cef988a6e780f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4153133
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
1f89b777
|
2023-01-10T15:41:30
|
|
Use third_party/depot_tools/gsutil.py instead of gsutil
This also worked on Windows in my tests.
Bug: angleproject:7299
Change-Id: I0cfcaa3f034f86a4adcdd21e3f296e9fe2064a4f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4153012
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
eab59474
|
2023-01-10T16:56:50
|
|
Suppress merge script failure due to missing gsutil on Windows.
Log exception but return success for now. Need to figure out how to run
gsutil from merge scripts on Windows as depot tools doesn't seem to be
on PATH.
Bug: angleproject:7299
Change-Id: I9f0332b7f333430cef90aa8cc15b62ebf1c21e35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4153130
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
2b1bc4fd
|
2023-01-09T12:17:17
|
|
Upload angle metrics to the gs bucket in skia perf format.
ConvertToSkiaPerf converts the data format from angle_metrics.json
to what skia perf ingests. Injestion happens automatically when the
gs bucket is updated.
Example data from this CL on non-perf bots with upload enabled
(smoke mode so actual values aren't meaningful):
https://angle-perf.skia.org/e/?queries=buildername%3Dlinux-test%26metric%3Dwall_time%26test%3Dtrex_200
Bug: angleproject:7299
Change-Id: Ica700b586e08c205968fbc3c1d15cf742ad537f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4148167
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
5c4e1c35
|
2023-01-06T12:22:48
|
|
Fix angle_metrics.json handling
Nested for loops work the other way around :S
Bug: angleproject:7299
Change-Id: Ic1d21a6a354f9cebca09ae0975eba126ab6406f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4143440
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
Auto-Submit: Roman Lavrov <romanl@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
056f8044
|
2022-10-11T11:58:20
|
|
Perf tests: write metrics to file and read from merge script.
The idea behind is to save metrics in a structured output with
full context so that we don't have to parse stdout and
reconstruct that context (e.g. which test was running when
the output was printed etc).
Note: we already have a "histogram" file (addHistogramSample)
written but it is structured using some UUID-based ids making its
digestion more complicated (https://anglebug.com/7299#c3).
This CL just writes events as one-json-per-line
simplifying downstream handling and debugging.
Just a sanity check / logging in the merge script for now.
Bug: angleproject:7299
Change-Id: I56dada643eceef180ce9bb1aa9ae6a641ea41e4c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3945112
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
8d502f2d
|
2022-10-06T10:20:26
|
|
Perf Tests: Simplify merger script.
This script contains a lot of logic copied from Chromium
scripts that we don't need. This CL removes some of it.
Bug: angleproject:7671
Change-Id: I831c2620cf5d5d1325d51605122a6998fcf2d3c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3937043
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
da9c0678
|
2022-06-17T19:04:32
|
|
Revert "Spawn via vpython when old module detected."
This reverts commit 28dfa45d60395d977d1ff96d04ee2ed78c1c22d2.
Reason for revert: No longer needed: https://crbug.com/1326517#c18
Original change's description:
> Spawn via vpython when old module detected.
>
> Not sure of a better way to detect this case as it seems to be running
> with the same python version as our vpython but modules are old.
>
> Bug: angleproject:7326
> Change-Id: I1750f65afdfdfc289af71bc7f426d5ba50dfd4a4
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3642804
> Commit-Queue: Roman Lavrov <romanl@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Bug: angleproject:7326
Bug: chromium:1326517
Change-Id: I1940dafa54859b8b1c9f1c4f702381c4346c7e5b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3708994
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
28dfa45d
|
2022-05-11T16:46:52
|
|
Spawn via vpython when old module detected.
Not sure of a better way to detect this case as it seems to be running
with the same python version as our vpython but modules are old.
Bug: angleproject:7326
Change-Id: I1750f65afdfdfc289af71bc7f426d5ba50dfd4a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3642804
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
cb0b4b7e
|
2021-08-04T08:05:14
|
|
Perf Bots: Upload proper build URL.
We were missing setting the 'project' when communicating with
the upload script.
Bug: chromium:1236071
Bug: angleproject:6090
Change-Id: I984761483d9b47aecfe52366c47a972700266829
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3065831
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
91b35c90
|
2021-06-30T09:28:17
|
|
infra: Add perf results processing script.
This script is a modified version of the Chromium script:
https://chromium.googlesource.com/chromium/src/+/main/tools/perf/process_perf_results.py
The primary change is to add additional build info to the
histogram set before upload. This additional info isn't
available to the test harness and is required for the perf
dashboard upload.
We can also use this as a basis for uploading to the Skia
perf dashboard.
Test: led launch
Bug: angleproject:6090
Change-Id: Ie439ed34a24ce66f4b60b947f221e4cb96cf7d25
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2997002
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
27ccdc85
|
2021-07-22T13:13:45
|
|
Add Chromium perf result processing script.
We will override this script in a follow-up CL to meet ANGLE's
specific needs.
Bug: angleproject:6090
Change-Id: I8d3a326645367e90ae79f49ef15ace700d6af106
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3042213
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|