kc3-lang/angle
Branch :
Log
| Author | Commit | Date | CI | Message |
|---|---|---|---|---|
 |
32c57b79 | 2019-12-03 07:01:40 | Roll third_party/spirv-tools/src 47f3eb42641b..3ed4586044f2 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/47f3eb42641b..3ed4586044f2 Created with: gclient setdep -r third_party/spirv-tools/src@3ed4586044f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I43e63689ab019e69440bac9c2a92fffa7b87a838 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947721 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
 |
fb40d231 | 2019-12-02 16:39:18 | Add new test runner harness. The ANGLE test harness is a harness around GoogleTest that provides functionality similar to the Chromium test harness. It supports: * splitting a test set into shards * catching and reporting crashes and timeouts * outputting to the Chromium JSON test results format * multi-process execution Unit tests are added in test_utils_unittest.cpp. Bug: angleproject:3162 Change-Id: Idb15f113de8eb32db12bc93542de93b08d7c1447 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1478016 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> | |
 |
9601a548 | 2019-11-23 23:44:52 | Vulkan: implement external semaphore barriers glWaitSemaphoreEXT and glSignalSemaphoreEXT functions optionally request buffer and image barriers to be performed by the implementation. If any barriers are present, a single global memory barrier is inserted to take care of memory accesses. In both functions, buffer and image memory barriers are used to perform queue ownership transfers to ANGLE's queue (glWaitSemaphoreEXT) or the EXTERNAL queue (glSignalSemaphoreEXT). In glWaitSemaphoreEXT, the given layouts are information regarding how the external entity (the caller) has modified the images' layouts, and is used to update ANGLE's internal state tracking. Bug: angleproject:3289 Bug: 1026673 Change-Id: Ic478a8813df727c89413c8ae2adf42b5c1d06069 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1933016 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> | |
|
190d9a81 | 2019-11-29 09:57:40 | Fix RenderingLimitToDefaultFBOSizeWithNoAttachments test MAX_DRAW_BUFFERS has a minimum value of 4. This test was unconditionally using 6 draw buffers. Bug: angleproject:4092 Bug: angleproject:4180 Change-Id: I069874a6402da1cb007bf9504e68b9910951cf63 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1944527 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexis Hétu <sugoi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
745999a9 | 2019-11-19 12:59:02 | Add test for multithreaded shared-context resource The test does this: 1. Context 1: Read Texture 1 and draw into Framebuffer 1 2. Context 2: Read Texture 1 and draw into Framebuffer 2 3. Context 1: Delete Framebuffer 1 4. Context 1: Flush 5. Context 2: Modify Texture 1 Issue is Texture 1's mCurrentReadingNodes contains one node from each context's command graph, one of which is deleted at step 4. At step 5, a dependency is added from both nodes (one already deleted) to a new node, causing use-after-free. Bug: angleproject:4130 Change-Id: I06720aec20d0b49114937f1cd9b193a4f1df9d8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1924790 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
 |
47a1fda2 | 2019-12-02 09:23:45 | D3D: Log why a renderer fails to initialize. BUG=1029091 Change-Id: I80a69f5d5294522d7229976f41ba5a61a6c2724d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1945891 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> | |
 |
ca1b0fb8 | 2019-11-25 12:13:01 | VULKAN: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.framebuffer_texture2d Add the following SWANGLE test failure to deqp_gles31_test_expectations.txt: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.framebuffer_texture2d Bug: angleproject:3590 Test: None Change-Id: I0f234ea2d7a90e2b95220b152cb0da3822df1ef3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1933764 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Tim Van Patten <timvp@google.com> | |
 |
19f9f414 | 2019-11-29 10:30:25 | Vulkan: Textures incorrect on Android maps with Vulkan Backend The issue was fixed, but adding a regression test to avoid it again. glMemoryBarrier inserts a memory barrier and breaks the submission order, which causes the copyBufferToImage happens before copyImageToBuffer and image corruption. This test fails on commit 052167b, and can pass on the latest build. Bug: angleproject:4074 Change-Id: Icc42dd7b2ba167815b223085ce933682654ce760 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943848 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> | |
|
8784a928 | 2019-12-02 07:01:04 | Roll third_party/SwiftShader fb7ca1d5aca5..b64fbfec4dcd (3 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/fb7ca1d5aca5..b64fbfec4dcd git log fb7ca1d5aca5..b64fbfec4dcd --date=short --first-parent --format='%ad %ae %s' 2019-11-30 bclayton@google.com VkPipeline: Replace spirv-opt list with RegisterPerformancePasses() 2019-11-29 paulthomson@google.com Regres: refactor for use as a library 2019-11-29 swiftshader.regress@gmail.com Regres: Update test lists @ fb7ca1d5 Created with: gclient setdep -r third_party/SwiftShader@b64fbfec4dcd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Id3d9dfdb0769511da8391220411aac9726ebb6b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1946094 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
0e8baa59 | 2019-12-02 07:01:04 | Roll third_party/spirv-tools/src b334829a91d6..47f3eb42641b (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b334829a91d6..47f3eb42641b Created with: gclient setdep -r third_party/spirv-tools/src@47f3eb42641b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I814d0cb3b82a5218140d785421b3c69d5fb8ebd3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1946095 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
4c23d7fe | 2019-12-02 07:01:04 | Roll third_party/glslang/src 38b4db48f98c..83af46951202 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/38b4db48f98c..83af46951202 Created with: gclient setdep -r third_party/glslang/src@83af46951202 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I4476e3fdea378cb843430a21d64d2f17e13983a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1946096 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
 |
ea0dcd4b | 2019-11-29 15:51:14 | Use Vulkan rectangle lines to emulate OpenGL multisampled lines SwiftShader recently added support for multisampled Bresenham lines to be spec compliant with Vulkan, so now Angle must explicitly request non-Bresenham lines when multisampling is enabled. Bug: angleproject:4087 Change-Id: Ie854746144894e3e0a68622e985cbd4ba7781ac3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1944529 Commit-Queue: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
6935b029 | 2019-11-29 10:57:20 | Ignore .git_cl_description_backup depot_tools used to create this file in $HOME, but now stores it in the current repository. Bug: None Change-Id: Ia127c2273eb23e7acffd5d0cf7c61e5d4f521a0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1944528 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
 |
5e6d6c49 | 2019-11-28 10:18:30 | Update flex and bison binaries for Windows. These binaries were updated using update_flex_bison_binaries.py. Please see instructions in tools/flex-bison/README.md. flex is at version 2.6.4 bison is at version 3.3.2 Bug: 3419 Change-Id: I640621e670a918c72fbb21186893a2cc438c0eb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943027 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
102aa522 | 2019-11-28 12:00:06 | Update flex and bison binaries for Linux. These binaries were updated using update_flex_bison_binaries.py. Please see instructions in tools/flex-bison/README.md. flex is at version 2.6.4 bison is at version 3.3.2 Bug: 3419 Change-Id: Iac8d0029b18602cc6e5f495d3b8c6bc928977500 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943029 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
7012250a | 2019-11-25 15:19:52 | Infrastructure for uploading flex/bison binaries The binaries are retrieved from MSys2 on windows and built from source on Linux. Updates to these binaries should be infrequent enough to not warrant a completely automated system. Bug: angleproject:3419 Change-Id: I282f9ca14059d1fe0d88f2ffd31d02df0ea6b88f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940571 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
87e10803 | 2019-11-29 07:01:51 | Roll third_party/vulkan-validation-layers/src 61050599ec0f..4fde9b750992 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/61050599ec0f..4fde9b750992 git log 61050599ec0f..4fde9b750992 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 pdaniell@nvidia.com layers: Fix VK_KHR_separate_depth_stencil_layouts bugs Created with: gclient setdep -r third_party/vulkan-validation-layers/src@4fde9b750992 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I8fe4e0dfced4ccbca13d54b9e8983347c57fa03e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1944049 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
c96187a9 | 2019-11-29 07:01:04 | Roll third_party/SwiftShader d6e903bdc9ef..fb7ca1d5aca5 (13 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/d6e903bdc9ef..fb7ca1d5aca5 git log d6e903bdc9ef..fb7ca1d5aca5 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 bclayton@google.com SpirvShaderEnumNames: Use spirv-tools' spvOpcodeString() 2019-11-28 bclayton@google.com Rename SpirvShader_dbg.cpp -> SpirvShaderEnumNames.cpp 2019-11-28 bclayton@google.com SpirvShader: Remove now unused includes 2019-11-28 bclayton@google.com SpirvShader: Move arithmetic ops to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move image handling to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move spec ops to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move group ops to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move memory ops to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move control flow handling to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move GLSLstd450 handling to new cpp file 2019-11-28 bclayton@google.com Pipeline: Move utility functions to ShaderCore 2019-11-28 jmadill@chromium.org Fix ICD generation (again). 2019-11-28 bclayton@google.com Regres: Use android.googlesource.com for dEQP Created with: gclient setdep -r third_party/SwiftShader@fb7ca1d5aca5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ib5511403e97be57c78784cbec8619f6cb4907312 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1944048 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
 |
bc82fb14 | 2019-11-28 16:58:19 | Suppress failing end2end tests for ASAN builds GLSLTest_ES31.StructArraySample and ComputeShaderTest.DispatchComputeIndirect both hit stack-buffer-overflow errors with ASAN enabled, using the vulkan backend. Right now ASAN is only tested on Mac, so these are only hit when Mac is using swiftshader-vulkan. Bug: 1029378 Change-Id: Ie590f73c29be44f683fd47fe4da139e1b5f96289 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943408 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> | |
|
82219d28 | 2019-11-26 10:17:11 | Vulkan: fix alpha values in convert vertex shader When reading vertex attributes, GLES requires the y and z components to be filled with 0 if missing, and the alpha channel to be filled with 1.0 for float types and 1 for integer types. At the same time, this change reduces the number of variations in this shader. Bug: angleproject:3192 Change-Id: I1bdf491952c296962fa9160f2d29d415eb3d570d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1936708 Reviewed-by: Jaedon Lee <jaedon1.lee@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
5afd5ec6 | 2019-10-25 10:53:40 | Vulkan support for MacOS (using SwiftShader) Created a new WindowSurface/Display for MacOS/Vulkan, along with some GN changes to get it working. Bug: 1015454 Change-Id: I3f7a12f173795efe598856c702ce53b1e50831eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880163 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
 |
39f3ccda | 2019-11-28 17:45:01 | Suppress SimpleStateChange failure on Metal NVIDIA BUG=angleproject:4177 TBR=geofflang@chromium.org Change-Id: I642e4bd3650b5b6beb6d9b18106d787c5dbc14f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1942348 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> | |
 |
6ebed542 | 2019-11-27 19:10:16 | Add arm64 to libpng build configuration. In libpng build option, neon files were missing for arm64, add "arm64" option to libpng build configuration. BUG=angleproject:4026 Change-Id: I38280c8089be93de224959583091f3a151f94ab0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940017 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
7fd3ad46 | 2019-11-28 07:01:03 | Roll third_party/spirv-tools/src f31f26f73930..b334829a91d6 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f31f26f73930..b334829a91d6 Created with: gclient setdep -r third_party/spirv-tools/src@b334829a91d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I5e77e15f61a924a4183ea49965e4b586374a5729 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1941570 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
b9a9a3c7 | 2019-11-28 07:01:03 | Roll third_party/vulkan-tools/src 6f6e3371c92a..979b531e9fff (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/6f6e3371c92a..979b531e9fff git log 6f6e3371c92a..979b531e9fff --date=short --first-parent --format='%ad %ae %s' 2019-11-27 jeremyk@lunarg.com vkcube: Fix Cube Squishing on Resize Created with: gclient setdep -r third_party/vulkan-tools/src@979b531e9fff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I2d43213baf6132eefa9a9f660d3300c64af81a55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1941569 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
c5f45365 | 2019-11-28 07:01:04 | Roll third_party/SwiftShader 663dcefa22ea..d6e903bdc9ef (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/663dcefa22ea..d6e903bdc9ef git log 663dcefa22ea..d6e903bdc9ef --date=short --first-parent --format='%ad %ae %s' 2019-11-28 sugoi@google.com Support multisampled Bresenham lines 2019-11-27 sugoi@google.com Support sample image instruction operand 2019-11-27 jmadill@chromium.org Fix ICD build when using multiple toolchains. 2019-11-27 chrisforbes@google.com gles: Only clamp default block uniform indexes Created with: gclient setdep -r third_party/SwiftShader@d6e903bdc9ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I0596f70dda8f3be71bda0d2fe48d2010f415e50e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1941571 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
7bb0115c | 2019-11-28 07:01:51 | Roll third_party/vulkan-validation-layers/src 8c954d5a413d..61050599ec0f (6 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8c954d5a413d..61050599ec0f git log 8c954d5a413d..61050599ec0f --date=short --first-parent --format='%ad %ae %s' 2019-11-27 camden@lunarg.com layers: Fix naming convention in PD_STATE 2019-11-27 camden@lunarg.com layers: Remove CALLSTATE everywhere except BP 2019-11-27 jasuarez@igalia.com tests: Implement test for VK_KHR_timeline_semaphore 2019-11-27 jasuarez@igalia.com layers: Implement VK_KHR_timeline_semaphore validations 2019-11-27 digit+github@google.com build: Fix Vulkan headers detection with CMake 2019-11-27 jbolz@nvidia.com layers: Remove MemTrack-FreedMemRef that has moved to best_practices Created with: gclient setdep -r third_party/vulkan-validation-layers/src@61050599ec0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ib47de40f60be363ade83ea8f4591ff68ab272e28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1941572 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
fc3ec57d | 2019-11-27 21:43:22 | Reland "Vulkan: Accelerate Texture PBO updates" This reverts commit 27d3c9399925d23726880ef910b9068fa39307cf. Reason for revert: Investigation is unable to reproduce the regresion. Shows up on the perf CI. Original change's description: > Revert "Vulkan: Accelerate Texture PBO updates" > > This reverts commit efb45edaefc07fc7120ebbde83bbc84876afda1a. > > Reason for revert: Significant perf regression on several benchmarks. > See bug for more details. > > Bug: chromium:1027098 > > Original change's description: > > Vulkan: Accelerate Texture PBO updates > > > > If the format of the image and the PBO match, > > use a vkCmdCopyBufferToImage transfer operation. > > > > Test: angle_end2end_tests --gtest_filter=*PBOCompressedSubImage* > > angle_end2end_tests --gtest_filter=*PBOWithMultipleDraws* > > dEQP-GLES3.functional.texture.specification.tex*image*d_pbo* > > Bug: angleproject:3777 > > Change-Id: I3f271024a635be113202a16f8893a199c194172d > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906203 > > Reviewed-by: Cody Northrop <cnorthrop@google.com> > > Commit-Queue: Mohan Maiya <m.maiya@samsung.com> > > TBR=cnorthrop@google.com,syoussefi@chromium.org,jmadill@chromium.org,m.maiya@samsung.com,b.schade@samsung.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: angleproject:3777 > Change-Id: I774655962e9ab5a866b9324002fb8edae8550834 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1939927 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=cnorthrop@google.com,syoussefi@chromium.org,jmadill@chromium.org,m.maiya@samsung.com,b.schade@samsung.com Change-Id: I8560a2e70de230eac3256a1df5eb2ecaa6f26bcf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1027098, angleproject:3777 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1939852 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
 |
c4f889fb | 2019-11-25 16:53:04 | Fix format/internalformat confusion Bug: angleproject:4084 Change-Id: I24a184b78bef2994a3045b141ecd72a49d66cfdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934890 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> | |
|
232d009d | 2019-11-27 10:12:23 | Fix string literal comparison in validation String literals shouldn't be compared by pointer, especially if the literal is declared in a header (so the two pointers can come from different translation units, because the string literal might have a different copy in each). Use strcmp instead. Bug: angleproject:4175 Change-Id: I6002ccb185f48928b67ce8a7b3508e427761a8c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940568 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
33adad19 | 2019-11-27 10:21:20 | Roll chromium_revision 5fe256ab5e..d209d45ba4 (709762:719599) Change log: https://chromium.googlesource.com/chromium/src/+log/5fe256ab5e..d209d45ba4 Full diff: https://chromium.googlesource.com/chromium/src/+/5fe256ab5e..d209d45ba4 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/258e22bc61..ebec9c5ad4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cf454b247c..6b3e658d6f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/85152663b9..72e16daaa5 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/403ca5ad3a..e77e1c06c8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/662cbb8d60..05979d8cad DEPS diff: https://chromium.googlesource.com/chromium/src/+/5fe256ab5e..d209d45ba4/DEPS Clang version changed 64a362e7216a43e3ad44e50a89265e72aeb14294:e84b7a5fe230e42b8e6fe451369874a773bf1867 Details: https://chromium.googlesource.com/chromium/src/+/5fe256ab5e..d209d45ba4/tools/clang/scripts/update.py TBR=jmadill@chromium.org, BUG=None Change-Id: I81aa1bc885ae18abddf04593245d1c394679a679 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940569 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
2ed71c81 | 2019-11-27 11:42:08 | Vulkan: Isolate DisplayVk.h from Display.cpp. With this change we no longer can access Vulkan (or Volk) headers in the ANGLE front-end. The only header that needs to be visible is the new "DisplayVk_api.h". This will simplify a bit of Volk integration. Also reworks how the entry points and headers are exposed to the tests. Bug: angleproject:3740 Change-Id: Ic1434f304619427ed6ad6370bc090ceb7858df94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1936707 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> | |
|
2a72553d | 2019-11-25 14:22:50 | Add EGLSurfaceTest.ResizeWindowWithDraw This test will ensure the backbuffer is also properly resized when the window is resized. Bug: angleproject:4167 Change-Id: I1d73f07379b4f05e453520e22ef1369f51182197 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934311 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> | |
|
ea1c2400 | 2019-11-27 10:49:57 | Suppress -Wsizeof-array-div in dEQP. Until the upstream bug is fixed. Tracked in https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/2127 Bug: angleproject:4176 Change-Id: I094735e1153c83439db54b43545297466ef2e2c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940570 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> | |
 |
b6148c3a | 2019-11-21 10:13:44 | Metal: re-enable end2end tests Bug: angleproject:4157 Change-Id: Ia7e29c32696c84556e9ea527fc48b086b1bc4766 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940007 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> | |
|
74d4bf98 | 2019-11-26 15:34:11 | Remove !empty() assert on FastVector::data() The user of the API is allowed to call data() on an empty vector. Bug: 1026414 Change-Id: I41ea65c50b94115ace7930d75cd8f14782548d6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1937807 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
95b176e4 | 2019-11-27 10:15:57 | Tweaks to roll_deps.py. Removes a few repos that are no longer in DEPS. Also remove fuchsia_sdk as it's not avaiable by default on some platforms and isn't really part of Chromium. Bug: angleproject:4176 Change-Id: I141213811c085b4281f64d93a14eb4a2b83e005e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940567 Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
27d3c939 | 2019-11-27 11:39:41 | Revert "Vulkan: Accelerate Texture PBO updates" This reverts commit efb45edaefc07fc7120ebbde83bbc84876afda1a. Reason for revert: Significant perf regression on several benchmarks. See bug for more details. Bug: chromium:1027098 Original change's description: > Vulkan: Accelerate Texture PBO updates > > If the format of the image and the PBO match, > use a vkCmdCopyBufferToImage transfer operation. > > Test: angle_end2end_tests --gtest_filter=*PBOCompressedSubImage* > angle_end2end_tests --gtest_filter=*PBOWithMultipleDraws* > dEQP-GLES3.functional.texture.specification.tex*image*d_pbo* > Bug: angleproject:3777 > Change-Id: I3f271024a635be113202a16f8893a199c194172d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906203 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Mohan Maiya <m.maiya@samsung.com> TBR=cnorthrop@google.com,syoussefi@chromium.org,jmadill@chromium.org,m.maiya@samsung.com,b.schade@samsung.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:3777 Change-Id: I774655962e9ab5a866b9324002fb8edae8550834 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1939927 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
781bb85e | 2019-11-27 07:01:04 | Roll third_party/spirv-tools/src 85f3e93d13f3..f31f26f73930 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/85f3e93d13f3..f31f26f73930 Created with: gclient setdep -r third_party/spirv-tools/src@f31f26f73930 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I5f6bd01cb79c8328e8d91582c2524f39d4cd79b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1938443 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
f8482560 | 2019-11-26 15:47:48 | Don't use too many color attachments in clear test GL_MAX_COLOR_ATTACHMENTS has a minimum value of 4. The test was unconditionally using 5 attachments. Bug: angleproject:4172 Change-Id: I793c297b50e3fdc54f75e2c5608508279028359f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1937808 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
 |
c373dfd8 | 2019-11-22 08:48:22 | Vulkan : Handle dirty state correctly when there are muiltiple VAOs If vertex array object binding is changed, we need to update the pipeline cache with the attribute information of the newly bound VAO. We cache the strides of attributes because emulated attributes will have strides that don't match the stride info cached in its binding struct. Also added a test case that switches between multiple VAOs. Bug: angleproject:4127 Test: angle_end2end_tests.exe --gtest_filter=SimpleStateChangeTestES31.MultipleVertexArrayObjectRendering Change-Id: I4f23aec33d5aa5988baa41f3c63db5534daf75ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1917453 Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com> | |
|
88752889 | 2019-11-20 14:09:52 | Vulkan: Fix barriers w.r.t sampled->storage image update df415528411f97454e765ff6a83ed1cbc90a7d13 implemented a feature where images are not created with the storage flag until needed. This is a necessary optimization. There were a few misuses of the BufferHelper::onRead/Write helpers that set up the appropriate barriers that this change fixes. Bug: angleproject:3816 Change-Id: I7e62d98b7325f938152a1972f4ebee083ed319c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1924989 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Xinyi He <xinyi.he@arm.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Sunny Sun <sunny.sun@arm.com> | |
|
5b2740c5 | 2019-11-22 11:55:25 | Vulkan: Remove unnecessary barrier in image -> buffer copy There was already a changeLayout call that inserted an imageBarrier. A TRANSFER_SRC to TRANSFER_SRC barrier was unnecessarily (and manually) added afterwards that was pointless. Bug: angleproject:3816 Change-Id: I8177487fc843fa5869c7b5063c74602933a81d58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1929270 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Sunny Sun <sunny.sun@arm.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
fe2d3ddd | 2019-11-26 15:04:06 | Roll third_party/SwiftShader afc52b0b26d7..663dcefa22ea (10 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/afc52b0b26d7..663dcefa22ea git log afc52b0b26d7..663dcefa22ea --date=short --first-parent --format='%ad %ae %s' 2019-11-26 bclayton@google.com Reactor: Work around new MSVC brokenness. 2019-11-26 swiftshader.regress@gmail.com Regres: Update test lists @ f2637d0d 2019-11-26 bclayton@google.com Merge changes I672a4d28,I4a74212f,I5c51e8aa,I323ea936 2019-11-25 jonahr@google.com Present should return OUT_OF_DATE if the window size outdated 2019-11-25 cwallez@chromium.org Make GN builds produce an ICD JSON in the build dir 2019-11-25 chrisforbes@google.com Add missing vkCmdSetLineStippleEXT function 2019-11-25 sugoi@google.com Improved pNext pointer handling 2019-11-25 awoloszyn@google.com Fix vkQueuePresentKHR is pResults is not null. 2019-11-25 swiftshader.regress@gmail.com Regres: Update test lists @ d44d6151 2019-11-25 kadam@inf.u-szeged.hu ExecutionEngine: add preliminary support for COFF ARM64 Created with: gclient setdep -r third_party/SwiftShader@663dcefa22ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com,jmadill@google.com Change-Id: I1def792ab0ddefa27b2252f2a9a7a88c9528c9f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1936550 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
c3c15fcf | 2019-11-26 07:01:51 | Roll third_party/vulkan-validation-layers/src 5efc3922e3e8..8c954d5a413d (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5efc3922e3e8..8c954d5a413d git log 5efc3922e3e8..8c954d5a413d --date=short --first-parent --format='%ad %ae %s' 2019-11-26 locke@lunarg.com tests: Using wrong queue 2019-11-26 locke@lunarg.com tests: pipeline stage conditional rednering 2019-11-26 locke@lunarg.com layers: Add conditional rendering Created with: gclient setdep -r third_party/vulkan-validation-layers/src@8c954d5a413d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I8d3103ede0b89d6cc75ba359badeba8d43522ff1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1936102 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
a57c1fb6 | 2019-11-26 15:08:26 | Vulkan: Large builtins overflow during string construction in glslang It is fixed in the glslang that the string size expands to 200, so remove the workaround in the commit 4c7db77. Bug: angleproject:4120 Change-Id: Iacc17259a68b3c92763c309a61b7fd87b130edc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1936074 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> | |
|
4cef8a49 | 2019-11-26 00:04:00 | Metal: Support depthRange near > far Metal doesn't natively support near > far depthRange, need to emulate it via shader. Bug: angleproject:2634 Change-Id: I1885cad3467478a0dcc4b25b7d41f980b9e03103 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919282 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
|
ab63fd28 | 2019-11-26 07:01:02 | Roll third_party/vulkan-tools/src 39b3005ba560..6f6e3371c92a (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/39b3005ba560..6f6e3371c92a git log 39b3005ba560..6f6e3371c92a --date=short --first-parent --format='%ad %ae %s' 2019-11-25 code@mstoeckl.com cube: Port Wayland impl from wl-shell to xdg-shell Created with: gclient setdep -r third_party/vulkan-tools/src@6f6e3371c92a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I1c10c31b8d98144f516637d8a529392ad410cfbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1936100 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
 |
f65b2124 | 2019-11-25 18:04:35 | [fuchsia] Change all Angle Presents to Present2s Bug: fuchsia:41855 Change-Id: Ia754c61c0ff7256781d9bf7d97b77e3bda1b01e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1935327 Reviewed-by: Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> | |
 |
4b53273c | 2019-11-21 09:42:42 | Vulkan: Fix validation issue with swiftshader Need to check that a VBO is actually bound (or rather no client arrays are bound) and return appropriate error. Test: angle_deqp_khr_gles31 --use-angle=swiftshader --gtest_filter=dEQP.KHR_GLES31/core_draw_indirect_negativenoVBOarrays Bug: angleproject:3564 Change-Id: Ic200993f9afcc3b43706ac0b509b10fa905857f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1922303 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> | |
 |
a825eb70 | 2019-11-21 11:37:17 | Implement BaseVertex draw calls for Vulkan, OpenGL, NULL contexts. This adds support for the following functions: - glDrawElementsBaseVertex - glDrawRangeElementsBaseVertex - glDrawElementsInstancedBaseVertex Bug: angleproject:3582 Bug: angleproject:3402 Bug: angleproject:4166 Change-Id: I83770f62e3a918c0965fd4ca8c7d9e598b8b4154 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1929083 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
8dfc2b05 | 2019-11-25 15:12:58 | Update codegen presubmit error. Clarifies that gclient sync should happen before codegen to avoid using stale hashes on upload. Bug: angleproject:3227 Change-Id: I7777458b6fa659a07307ad1d845ac7d332afa8f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934313 Reviewed-by: Ethan Lee <flibitijibibo@gmail.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
e5b474c6 | 2019-11-19 23:04:00 | Metal: support ANGLE_instance_arrays/EXT_instance_arrays Also added TRIANGLE_FAN & LINE_LOOP instanced draws test cases. Bug: angleproject:2634 Change-Id: I84740a7221ab49710cf23767c81fa2d303aad364 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919280 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
34e5a96e | 2019-11-25 11:46:15 | Fix header typo in rapidjson. Was found when using the custom test harness. Bug: angleproject:3162 Change-Id: I9db11eddb51508ff1eaebe02c106cd4a95c369b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1932342 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
04e074d1 | 2019-11-25 08:32:51 | Roll third_party/vulkan-headers/src 24347673152e..2b89fd4e2734 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/24347673152e..2b89fd4e2734 git log 24347673152e..2b89fd4e2734 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 oddhack@sonic.net Update for Vulkan-Docs 1.1.129 Created with: gclient setdep -r third_party/vulkan-headers/src@2b89fd4e2734 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=cwallez@google.com Bug: None Change-Id: I2d4e0d6776b358fd06dd20ec2dda61be22f0951f Tbr: cwallez@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934050 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
214e8700 | 2019-11-25 07:37:45 | Roll third_party/SwiftShader 131a1ba8d06a..afc52b0b26d7 (7 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/131a1ba8d06a..afc52b0b26d7 git log 131a1ba8d06a..afc52b0b26d7 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 bclayton@google.com Fix build: Do not return stack temporary. 2019-11-25 bclayton@google.com Fix chrome build: Use spaces (not tabs) in .gn files (2/2) 2019-11-25 bclayton@google.com Fix chrome build: Use spaces (not tabs) in .gn files 2019-11-22 chrisforbes@google.com Fix vkGetDescriptorSetLayoutSupport implementation 2019-11-22 srisser@google.com Log unsupported extensions used in pNext structs 2019-11-22 sugoi@google.com Handle new device extension properties 2019-11-22 swiftshader.regress@gmail.com Regres: Update test lists @ 698235ce Created with: gclient setdep -r third_party/SwiftShader@afc52b0b26d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Ia87fd46f9df69ec256ce3b6458bd7e9fe2b66f50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1932035 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
09891ef6 | 2019-11-25 07:01:50 | Roll third_party/glslang/src 43fe7bafb14e..38b4db48f98c (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/43fe7bafb14e..38b4db48f98c Created with: gclient setdep -r third_party/glslang/src@38b4db48f98c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I0b086a9a322b3e04dd108ae4f94a8f44778018c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1932030 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
b1393d70 | 2019-11-25 07:01:35 | Roll third_party/spirv-tools/src 45dde9ad6dde..85f3e93d13f3 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/45dde9ad6dde..85f3e93d13f3 Created with: gclient setdep -r third_party/spirv-tools/src@85f3e93d13f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I027066165401dd47e80c31302e2811a546ecd95f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1932028 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
 |
e9b68f33 | 2019-11-19 19:34:24 | Clean unused NewCreateImagePipeCmd This call is to be deprecated. Bug: angleproject:3905 Change-Id: Iffca3a3bee4d0ff930598635a27592e068696bbf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1925032 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> | |
 |
6430e5e0 | 2019-11-20 19:56:10 | Enable frame capture on Android This CL gets capture/replay working on Android again. * Updates where Android frame captures are written * Uses debug system properties to prime Android environment variables * Adds a configurable target Context to the capture_replay sample * Updates capture/replay documentation for Android Bug: angleproject:4036 Test: Captured TRex on Android, replayed on Linux Change-Id: I94b4f6dc77468cd179b9d884b4dcd4afa56bd28c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1928056 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> | |
|
d32650bb | 2019-11-21 12:52:34 | Posix: Fix async LaunchProcess. The prior method was only checking for a PID's existance. We should also check for zombie process states. This allows our child process launcher to correctly determine when a process is done on Linux and other Posix systems. Also starts the test timer on Posix LaunchProcess implementations. Also removes the need to end command line arg lists with nullptr. Also removes some Fuchsia-specific preprocessor checks. Also adds a regression test. Bug: angleproject:3162 Change-Id: I5725a8a0e8c5151f2d3e06df0a36dd64c0e0ee69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1928873 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
 |
fb1c2fe8 | 2019-11-13 11:10:39 | EXT_texture_norm16 readpixels fix Adding validation logic for RGBA16 readpixels. Change readPixels format from UNSIGNED_BYTE to UNSIGNED_SHORT in the test. FYI: According to https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_texture_norm16.txt ReadPixels format and type used during CopyTex* are limited to RGBA Bug: 1024387, 1000354, angleproject:1365, angleproject:4089 Change-Id: I70517f255fe335f60e55bdf15f7ebf82e3de0800 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1914127 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> | |
|
f3d35f8f | 2019-11-22 14:24:52 | Suppress flaky failure with Win7/NVIDIA/D3D11 Seeing intermittent failure on this test only on Win7/NVIDIA/D3D11. Suppress for now. Bug: angleproject:4163 Change-Id: Idfa44516a194dcd5710622d11801ce089c1e829d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1931338 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> | |
|
4c7db77e | 2019-10-31 15:42:31 | Vulkan: Set limitation on maxComputeWorkGroupCount According to Table 20.45 and Chapter 17 in the ES 3.1 spec, MAX_COMPUTE_WORK_GROUP_COUNT is get as a GLint by using GetIntegeri_v. However, it is an unsigned integer in the Vulkan. It needs to set limitation on maxComputeWorkGroupCount[] during translating. 1. Change the data type to GLint stored in Caps. 2. Ensure that the limitation is set during initialization. 3. Add workaround for angleproject:4120 Bug: angleproject:4066 Change-Id: I1659ba1d560e30b9599cace0feeab8a18890c3ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1890586 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
b868861c | 2019-11-22 07:01:23 | Roll third_party/SwiftShader f2c9ce1e08ed..131a1ba8d06a (14 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/f2c9ce1e08ed..131a1ba8d06a git log f2c9ce1e08ed..131a1ba8d06a --date=short --no-merges --format='%ad %ae %s' 2019-11-22 sugoi@google.com libVulkan references and deferences structures uselessly 2019-11-21 srisser@google.com Revert submission 2019-11-21 sugoi@google.com Vulkan header update 2019-11-21 srisser@google.com Log unsupported extensions used in pNext structs 2019-11-21 amaiorano@google.com Subzero: add subzeroEmitTextAsm flag 2019-11-21 amaiorano@google.com Subzero: add subzeroDumpEnabled flag 2019-11-21 amaiorano@google.com Subzero: map optimization level none/less to m1 2019-11-21 amaiorano@google.com Subzero: fix invalid asserts during emit() 2019-11-21 amaiorano@google.com Subzero: fix invalid register allocation 2019-11-21 amaiorano@google.com Subzero Win64: fix Call for ptr and spillover args 2019-11-21 chrisforbes@google.com Regres: Update deqp to 3ca6f6fe2e4e023cb9d4ea763990336d762b49e2 2019-11-21 digit@google.com [OpenGL] Fix implicit int-to-float-conversion compiler warning. 2019-11-21 sugoi@google.com Remove quadLayout 2019-11-21 kadam@inf.u-szeged.hu Add new relocation types. Created with: gclient setdep -r third_party/SwiftShader@131a1ba8d06a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=courtneygo@google.com Change-Id: Icd8079a4199e28725242b97e25099d6d84dd22c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1930472 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
732cbdac | 2019-11-22 08:45:03 | Roll third_party/glslang/src f4d4668529f1..43fe7bafb14e (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f4d4668529f1..43fe7bafb14e Created with: gclient setdep -r third_party/glslang/src@43fe7bafb14e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=courtneygo@google.com Change-Id: Id991cfa06a627a3e2872123a8d8096efa76c1727 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1930482 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
8bba14cb | 2019-11-22 07:01:29 | Roll third_party/vulkan-validation-layers/src 53902309eda9..5efc3922e3e8 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/53902309eda9..5efc3922e3e8 git log 53902309eda9..5efc3922e3e8 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 rgarcia@igalia.com layers: Fix broken config file parsing Created with: gclient setdep -r third_party/vulkan-validation-layers/src@5efc3922e3e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=courtneygo@google.com Change-Id: I8935b073c7f40619c2560e1ab091ef6de238ffa5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1930473 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
bcf9cf89 | 2019-11-22 07:01:52 | Roll third_party/vulkan-headers/src ba6cbb047868..24347673152e (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/ba6cbb047868..24347673152e git log ba6cbb047868..24347673152e --date=short --no-merges --format='%ad %ae %s' 2019-11-21 mark@lunarg.com build: Clarify Windows build instructions Created with: gclient setdep -r third_party/vulkan-headers/src@24347673152e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=courtneygo@google.com Bug: None Change-Id: I878b7705cf15ac97516b26dc78dedcb7452a98f9 Tbr: courtneygo@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1929923 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
37ba927e | 2019-11-20 01:51:12 | UWP: Implement GetPathSeparatorForEnvironmentVar Bug: angleproject:4142 Change-Id: Idb5e1b540d9ac7ab802357f247b41a6546173a35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1925254 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
d83dc175 | 2019-11-20 01:50:36 | GN: Only link to delayimp when d3d9 is enabled Bug: angleproject:4142 Change-Id: If7afac61386f205271997bcae53cd726a1786114 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1925253 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
c5c096aa | 2019-11-15 15:36:16 | Enable Compute Shader Program Input Queries Compute shader inputs were not being tracked in the Shader or Program states, causing program interface queries to fail. This change treats compute shader inputs (all built-ins) as Attributes and pipes them through from the Compiler to the Program to enable input queries. While compute shader inputs are not technically attributes (or varyings), the ANGLE code understands and handles attributes and a program can never have both a vertex and compute shader, so there can't be any conflicts. The naming of these variable lists should probabaly be revisited at some point to better handle these different use-cases. Bug: angleproject:3596 Test: dEQP-GLES31.functional.program_interface_query.program_input.resource_list.compute.empty Change-Id: Ie52cd59041868cfdb5d3d759bb4ec53c8d5b38d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919557 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com> | |
|
6fcc0bb8 | 2019-11-21 01:19:40 | Metal: Re-add end2end test configs (running test is still disabled) angle_test_instantiate.cpp & angle_test_instantiate_apple.mm: - Disabled metal platform selection on pre-10.13 mac devices for Bug: angleproject:4153 Explicitly disabled tests on metal: - DifferentStencilMasksTest.DrawWithDifferentMask - PointSpritesTest.PointSizeAboveMaxIsClamped - WebGL2ReadOutsideFramebufferTest.CopyTexSubImage3D This requires the crash fix in http://crrev.com/c/1924101 Bug: angleproject:4153 Bug: angleproject:2634 Change-Id: I95046d731a8ba7414cf1a1f4b6f2940282725872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1926389 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
|
84c074cf | 2019-11-20 15:32:44 | Vulkan: Simplify AppendToPNextChain use The function is turned into a template to avoid the reinterpret_cast at call sites. Additionally, uses Vulkan's own VkBaseOutStructure instead of a bespoke definition. Bug: angleproject:4027 Change-Id: Ib236d44a12c0363e7e89b9bf2ed5ab8166252730 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1924992 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> | |
|
b0a9de95 | 2019-11-20 13:42:37 | Fix assert in angle_deqp_khr_gles* executables The //build/config/gcc:symbol_visibility_hidden config was removed in an attempt to improve stack traces on Linux. However, this resulted in the in-class-inline-functions in glslang to be weak symbols. The KHR dEQP tests link against glslang as well as libGLESv2.so, resulting in angle_deqp_khr_gles*_tests to link those weak symbols. Due to glslang's usage of a global variable in InitializeDll.cpp, a bug is created where ANGLE sometimes calls into its own copy of glslang and sometimes the KHR dEQP's version, with the two copies of the global variable being inconsistent. Bug: angleproject:4123 Change-Id: I0cfe3236117b1219db4fea4495e1583334c04fbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1926887 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
05af7590 | 2019-11-20 01:04:00 | Metal: Fix FramebufferMtl's read-after-delete Due to late verification, ContextMtl might call onFinishedDrawingToFrameBuffer() on a deleted framebuffer object inside syncState() Fix: - Switch to call onStartedDrawingToFrameBuffer() on new FBO instead of calling onFinishedDrawingToFrameBuffer() on old (and possibly deleted) FBO. - Also discard framebuffer only takes effect per render pass. The discard flag will be reset when render pass starts. Bug: angleproject:4144 Change-Id: I7c6c96862892f1c241ce4af3b61862fa4b710a94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1924101 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
 |
7c95d081 | 2019-11-12 15:42:43 | Fix crash during resizes when using the OpenGL renderer on Windows Partial revert of f06076396afa8585e19e140f4a8b02720ede77e5 Address test failures Guard context reset in DisplayWGL::makeCurrent with !mUseDXGISwapChains BUG=chromium:1004117 Change-Id: I9b6eb7bc83a6e4b1a21fa0703404e41c6090730d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1913314 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> | |
|
b61069ce | 2019-11-21 09:52:53 | Manually roll Vulkan-Loader DEPS Move from tobin_remove_wdk_dependence back to master. Bug: 1022751 Change-Id: I3ac11fd6297cd8db935877cd934c66744d61956e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1928614 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> | |
|
ba8f4e7d | 2019-11-21 07:57:24 | Update auto-roller list in wrangling doc Bug: angleproject:1944 Bug: angleproject:4095 Change-Id: Ieb16cb6718f04e07394e457f1c7b73b3cd8a1c10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1929135 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
 |
97267272 | 2019-11-20 15:07:48 | Vulkan:Remove exceptions for passing tests These two test groups are now passing so removing from exceptions file: dEQP-GLES31.functional.state_query.integer.max_framebuffer_samples* dEQP-GLES31.functional.state_query.integer.max_uniform_locations* Bug: angleproject:3520 Change-Id: I47634a52d3306202f944dc9548ba44c3dda8fc91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1924993 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com> | |
|
1898c082 | 2019-11-21 06:37:39 | Roll third_party/android_ndk/ 89e8db0cd..27c0a8d09 (1 commit) $ git log 89e8db0cd..27c0a8d09 --date=short --no-merges --format='%ad %ae %s' 2019-11-20 jmadill Remove case-sensitive netfilter headers. Created with: roll-dep third_party/android_ndk Bug: angleproject:2344 Bug: angleproject:4139 Change-Id: Ief7276110fb2631d73d64524d35857903ed7e51a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1928613 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
bf492e49 | 2019-11-21 07:01:22 | Roll third_party/SwiftShader 2377845dd216..f2c9ce1e08ed (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/2377845dd216..f2c9ce1e08ed git log 2377845dd216..f2c9ce1e08ed --date=short --no-merges --format='%ad %ae %s' 2019-11-20 awoloszyn@google.com Fix xcb library name. 2019-11-20 sugoi@google.com Remove unused depth buffer quad layout logic 2019-11-20 sugoi@google.com Fixed 3D image copy 2019-11-20 sugoi@google.com Remove depth+stencil formats from the Blitter Created with: gclient setdep -r third_party/SwiftShader@f2c9ce1e08ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=courtneygo@google.com Change-Id: Ib47a2058d10ff40ce321bce67041ea98221e54d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1928219 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
34e21921 | 2019-11-21 07:01:38 | Roll third_party/vulkan-tools/src 40cd2166a446..39b3005ba560 (26 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/40cd2166a446..39b3005ba560 git log 40cd2166a446..39b3005ba560 --date=short --no-merges --format='%ad %ae %s' 2019-11-20 shannon@lunarg.com build: Update known good for 1.1.128 Vulkan header 2019-11-19 charles@lunarg.com vulkaninfo: check that extensions aren't disabled 2019-11-15 daniel.charles@intel.com vulkaninfo: return properly on xcb onnection errors 2019-11-06 shannon@lunarg.com build: Update known good for 1.1.127 Vulkan header 2019-11-06 jeremyk@lunarg.com build: Update MoltenVK version to v1.0.38 2019-11-01 charles@lunarg.com vulkaninfo: added more documentation for show-formats 2019-11-01 jeremyk@lunarg.com vulkaninfo: Fix gitlab issue 181 2019-10-30 charles@lunarg.com vulkaninfo: fix infinite sleep for non text outputs 2019-10-30 charles@lunarg.com vulkaninfo: fixed spelling of properties 2019-10-30 mikes@lunarg.com gn: Generate VkICD_mock_icd.json on mac 2019-10-29 charles@lunarg.com vulkaninfo: add documentation for show-formats 2019-10-29 charles@lunarg.com vulkaninfo: add documentation for --show-formats 2019-10-28 shannon@lunarg.com build: Update known-good commits for SDK 126 2019-10-25 shannon@lunarg.com build: Update known good for 1.1.126 Vulkan header 2019-10-23 georges.stavracas@gmail.com cube: Try to bind to wl_compositor v4 2019-10-15 shannon@lunarg.com build: Update known good for 1.1.124 Vulkan header 2019-10-15 charles@lunarg.com vulkaninfo: Present Surfaces now wont show duplicates 2019-10-14 charles@lunarg.com vulkaninfo: Added asserts to check output 2019-10-14 jeremyk@lunarg.com cube: Revert 1.1.114 SDK workaround for vkcube 2019-10-11 charles@lunarg.com vulkaninfo: updated json documentation 2019-10-11 jeremyk@lunarg.com build: Fix Vulkaninfo Bundle build on MacOS 2019-10-08 charles@lunarg.com vulkaninfo: Fix closing immediately on windows 2019-10-08 charles@lunarg.com vulkaninfo: Handle device group extension not available 2019-10-07 charles@lunarg.com vulkaninfo: fix extra newlines 2019-10-04 charles@lunarg.com vulkaninfo: Major Refactor 2019-09-19 jeremyk@lunarg.com build: Update MoltenVK version in known_good.json Created with: gclient setdep -r third_party/vulkan-tools/src@39b3005ba560 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=courtneygo@google.com Change-Id: I1dff115525481d8d765682551c00d03a3ee0c4ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1928221 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
59cd8821 | 2019-11-21 07:01:29 | Roll third_party/vulkan-validation-layers/src 720c5deb0244..53902309eda9 (9 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/720c5deb0244..53902309eda9 git log 720c5deb0244..53902309eda9 --date=short --no-merges --format='%ad %ae %s' 2019-11-20 petr_kraus@email.cz tests: Fix Mock workaround in acquire test 2019-11-20 petr_kraus@email.cz tests: Remove redundant skip msg in acquire test 2019-11-20 mikes@lunarg.com build: Add command counter object to GN build 2019-11-20 lionel.g.landwerlin@intel.com tests: Add tests for VK_KHR_performance_query 2019-11-20 lionel.g.landwerlin@intel.com layers: Add VK_KHR_performance_query validations 2019-11-20 mark@lunarg.com tests: Add test for BeginQuery timestamp qpool type 2019-11-20 mark@lunarg.com corechecks: Add check for QP timestamp type in BeginQuery 2019-11-20 camden@lunarg.com tests: Add Subclass for BestPractices Tests 2019-11-20 shannon@lunarg.com build: Update VUIDs for 1.1.128 header Created with: gclient setdep -r third_party/vulkan-validation-layers/src@53902309eda9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=courtneygo@google.com Change-Id: Ifc8638f072f801727f8dc0de1f3b2192d8c8a6b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1928220 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
fdbc1ace | 2019-11-21 07:01:57 | Roll third_party/spirv-tools/src 2ee9aaa288d9..45dde9ad6dde (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2ee9aaa288d9..45dde9ad6dde Created with: gclient setdep -r third_party/spirv-tools/src@45dde9ad6dde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=courtneygo@google.com Change-Id: I7af9d507cbe8ec3740c0380c325a56fcc490cf82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1928222 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
 |
b8e748be | 2019-11-07 18:00:50 | Vulkan: Add an end2end test to log GLES capabilities Logs information listed at: https://opengles.gpuinfo.org/listcapabilities.php in CSV format The list from gpuinfo doesn't include capabilities introduced by extensions Test: angle_end2end_tests.exe --gtest_filter=*PrintGLESCapabilities* Bug: angleproject:4093 Change-Id: I59c82879ee2e3486269aa0cb40e2ee6c6e646ec5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1917443 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
5530b3ff | 2019-11-20 17:13:04 | Update dEQP KHR-GLES31 expectations. Bug: angleproject:3596 Bug: angleproject:4132 Bug: angleproject:4145 Bug: angleproject:4146 Bug: angleproject:4147 Bug: angleproject:4148 Bug: angleproject:4150 Change-Id: I5495c31f5c2d85a9c3f7d177c53e800f50675354 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1925389 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
2ba626dc | 2019-11-20 17:13:02 | Work around dEQP KHR-GLES31 bug with tess/geom support. dEQP was inadvertendly requiring the presence of these extensions to even run the tests. There's a WIP fix to the dEQP tests and this CL implements that fix as a temporary workaround until we can update dEQP. Fixes several tests in KHR-GLES31.core.constant_expressions and KHR-GLES31.core.shader_macros. They now correctly return unsupported. Bug: angleproject:4143 Change-Id: I110beb2f18fd29f8f02b2ab166cfcfcfae80c2c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1924620 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
10f41ebb | 2019-11-19 12:53:36 | GN: Make dEQP import libEGL/libGLESv2 as data_deps. This removes the hard link dependency on ANGLE. Allows us to use ANGLE dEQP tests with msan. Otherwise they were complaining about missing shared libraries. Also would eventually let us test ANGLE dEQP tests against a native driver. Was done as a part of investigating SwapBuffers crashes on SwiftShader. Bug: angleproject:4060 Change-Id: I569de15573c8eb7808bd7783f1a514655d1c6422 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1898207 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
c1776c61 | 2019-11-13 11:36:35 | Vulkan:Add Swiftshader configs Add Swiftshader configs to existing test instantiation macros for all ESX variants. This causes Swiftshader to be used to run end2end tests. Added detection code to know when tests are running on Swiftshader and skipping a number of fails initially. Note that when running ANGLE end2end tests within Chromium build on Win32 bots there were crashes with Swiftshader config for tests that should have been skipped. Due to this, just skipping Swiftshader configs on Win32 for now. Bug: angleproject:4081 Bug: angleproject:4092 Change-Id: I32527a62304c5fad90f645b372edf9411ca2b212 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1914126 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
4193e212 | 2019-11-20 11:03:09 | Clean up dontUseLoopsToInitializeVariables condition This workaround is ported from chrome's dont_use_loops_to_initialize_variables workaround, which is enabled on Qualcomm Adreno devices. Better to check for Qualcomm than !NVIDIA Bug: 784817 Change-Id: I2f8314ca97aeca7fdcea60ef9d2fb9e64f075a32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1924625 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> | |
|
efb45eda | 2019-09-24 09:23:53 | Vulkan: Accelerate Texture PBO updates If the format of the image and the PBO match, use a vkCmdCopyBufferToImage transfer operation. Test: angle_end2end_tests --gtest_filter=*PBOCompressedSubImage* angle_end2end_tests --gtest_filter=*PBOWithMultipleDraws* dEQP-GLES3.functional.texture.specification.tex*image*d_pbo* Bug: angleproject:3777 Change-Id: I3f271024a635be113202a16f8893a199c194172d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906203 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mohan Maiya <m.maiya@samsung.com> | |
|
f9c3eaf4 | 2019-11-19 15:19:04 | Add ability to disable all ANGLE features Chrome has a --disable-gpu-driver-bug-workarounds flag that needs to be able to be forwarded to ANGLE Bug: 1016377 Change-Id: Ied6c8656742e25c32d508b8bfe76a902d82bcf93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1925249 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> | |
|
8392b118 | 2019-11-20 16:57:08 | Revert "Metal: Enable end2end tests." This reverts commit 0bb42e091b77f174632434a05789b2ce632bd902. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1026633 Causing failures on Mac bots. Original change's description: > Metal: Enable end2end tests. > > Explicitly disabled tests: > - DifferentStencilMasksTest.DrawWithDifferentMask > - PointSpritesTest.PointSizeAboveMaxIsClamped > - WebGL2ReadOutsideFramebufferTest.CopyTexSubImage3D > > Bug: angleproject:2634 > Change-Id: I76ab450c06d0e1be1e7469a8b9c6497684c3ca54 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906607 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> TBR=geofflang@chromium.org,jonahr@google.com,jmadill@chromium.org,le.hoang.q@gmail.com Change-Id: Iaa4264834170a49c274f186d3d74f57714c84b32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:2634 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1926378 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> | |
|
41352a8f | 2019-11-19 16:32:45 | Update expecatations for Program Pipeline tests Tests that depend on Program Pipeline that had generic bug IDs have been collected under anglebug.com/3570 as the program pipeline work tracker. Bug: angleproject:3570 Change-Id: Ifefd445376f16c48d872eb5abf63bad7d6e4c99a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1925531 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
caeb2174 | 2019-11-20 22:30:17 | Mac: Add dsymutil to DEPS Needed for ASAN build on Mac. Bug: angleproject:4149 Change-Id: If2041727ec9bbe40723a991e7455cad12d05ddff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1926387 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
 |
0303cf6b | 2019-10-30 16:46:38 | OpenGL: Port all Intel-related workaround conditions from gpu_driver_bug_list.json This patch ports all the Intel-related shader workarounds defined in gpu_driver_bug_list.json used by Chromium validating command buffer into ANGLE so that they can also take effect in Chromium passthrough command buffer. Bug: 1020467 Bug: 642605 Bug: 403957 Change-Id: I8e4866fc34d5e8f1b2f4dbfa8e526b80249ba166 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1889386 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> | |
|
b066177a | 2019-11-19 15:13:20 | Vulkan: Remove duplicate shader variation ConvertVertex's UintToUint and HalfFloatToHalfFloat were generating identical shaders. Bug: angleproject:3802 Change-Id: I8eb2d55debbc5501f191830a2723b02d0d1f0827 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1925248 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Hyunchang Kim <hckim.kim@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
0bb42e09 | 2019-11-19 23:04:00 | Metal: Enable end2end tests. Explicitly disabled tests: - DifferentStencilMasksTest.DrawWithDifferentMask - PointSpritesTest.PointSizeAboveMaxIsClamped - WebGL2ReadOutsideFramebufferTest.CopyTexSubImage3D Bug: angleproject:2634 Change-Id: I76ab450c06d0e1be1e7469a8b9c6497684c3ca54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906607 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> | |
|
1f13f5e6 | 2019-11-20 08:52:22 | Roll third_party/SwiftShader 79afb7620a69..2377845dd216 (6 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/79afb7620a69..2377845dd216 git log 79afb7620a69..2377845dd216 --date=short --no-merges --format='%ad %ae %s' 2019-11-20 bclayton@google.com Reactor: Move print apis out of core reactor header. 2019-11-20 bclayton@google.com Reactor: Remove the CallSupported capability. 2019-11-20 bclayton@google.com Reactor: Add ConstantData() and member function calling 2019-11-20 bclayton@google.com Reactor/Traits: Swap the naming of CToReactorPtr and CToReactorPtrT. 2019-11-20 bclayton@google.com Reactor/Traits: Fix brokenness with CToReactor::cast of pointers. 2019-11-19 bclayton@google.com Reactor: Split Traits.hpp into Traits.hpp and Traits.inl Created with: gclient setdep -r third_party/SwiftShader@2377845dd216 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=courtneygo@google.com Change-Id: Ia4518bf1b446bfbb1226e96bb1dda97879f0cd8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1925880 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
c8de7532 | 2019-11-20 07:01:58 | Roll third_party/spirv-tools/src 57b4cb40b21d..2ee9aaa288d9 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/57b4cb40b21d..2ee9aaa288d9 Created with: gclient setdep -r third_party/spirv-tools/src@2ee9aaa288d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None TBR=courtneygo@google.com Change-Id: I548de5576ac5e9dedbe3592340e39a08dfdf4f63 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1925363 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> |