Log

Author Commit Date CI Message
Tim Van Patten 33b58ebb 2019-11-25T16:31:43 Vulkan: Give unsized arrays at least 1 entry The function ShaderVariable::getNestedArraySize needs to return at least 1 entry for unsized arrays to ensure the shader buffer sizes are reported correctly. This also allows ANGLE to treat unsized arrays of structs and basic types the same way, allowing for the special treatment of unsized arrays in TraverseStructArrayVariable() to be removed. Bug: angleproject:3596 Test: dEQP-GLES31.functional.program_interface_query.shader_storage_block.buffer_data_size.* Change-Id: I3b2a3a68c25e0913b79e989d7c719b34ce9b75fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934952 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 2d5da029 2020-04-15T17:15:37 Minor angle_end2end_tests cleanups. Minor refactoring and call consolidation. Was done while working on deferring clears in the Vulkan back-end. Bug: angleproject:4517 Change-Id: I60d80d4f9646c990c4cb8bbc349fc0051389bf02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2151171 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Le Hoang Quyen dc3477f3 2020-03-14T17:22:41 Separate GLES1's state enum switch code from GLES2+ Some enum values such as GLES1's GL_CLIP_PLANE0 and GLES2+'s GL_CLIP_DISTANCE0_EXT have the same value. Thus, the enum switch code has to be separated for GLES1 & GLES2+ Bug: angleproject:4481 Change-Id: I2fcb95f3f75f1fe683a072bee02e797a95686480 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145284 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Charlie Lao 8c67c079 2020-04-16T14:42:15 Vulkan: store ImageLayout in PackedAttachmentOpsDesc The layout in the PackedAttachmentOpsDesc only have 5 bits, not enough for raw VKImageLayout enums. This change will store vk::ImageLayout which are ANGLE defined and packed for 5 bits and able to handle the extension bits of VKImageLayout. Bug: b/153885625 Change-Id: Ida268a974094188d8aeee39c61019eef30a60507 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2153845 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang 6cea4405 2020-04-17T12:29:07 Remove more bad files before rolling into AOSP. third_party/VulkanMemoryAllocator/OWNERS also includes owners that block uploading. Move the deletion of the bad files earlier in the script and rm them instead of git rm. They may or may not be committed git files but rm always works. BUG=b/150892231 Change-Id: Iee60fba504ed1c16e994ed1ba83d2b7c58c0a01c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154537 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Geoff Lang 13e4cdb2 2020-04-16T14:35:54 Accept b/ for bug IDs in ANGLE CLs. Bug: b/151095080 Change-Id: Ic9da14a1476958eb00d4499dacdaa9c529b0626c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152849 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll c090ea78 2020-04-17T07:01:30 Roll third_party/vulkan-loader/src 3682237cb326..50eaecd721a2 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3682237cb326..50eaecd721a2 git log 3682237cb326..50eaecd721a2 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 cwallez@google.com BUILD.gn: Generate libvulkan.so.1 on Linux Created with: gclient setdep -r third_party/vulkan-loader/src@50eaecd721a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ib4212a491cc1f1082616d06588c23673f1a4b0e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2153674 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 94b50338 2020-04-17T07:02:12 Roll third_party/vulkan-headers/src e01f13e1f777..382bf3de06fc (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/e01f13e1f777..382bf3de06fc git log e01f13e1f777..382bf3de06fc --date=short --first-parent --format='%ad %ae %s' 2020-04-16 rahul@snap.com Export versioned targets for CMake Created with: gclient setdep -r third_party/vulkan-headers/src@382bf3de06fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=timvp@google.com Bug: None Change-Id: I3b713e1072e293f558db7413b7d70b83f8435275 Tbr: timvp@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154334 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll aa954cc5 2020-04-17T07:01:38 Roll third_party/SwiftShader 2430d665d3f2..d25ce8725224 (18 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/2430d665d3f2..d25ce8725224 git log 2430d665d3f2..d25ce8725224 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 digit@google.com Fix LLVM-based Arm64 build. 2020-04-16 bclayton@google.com CMakeLists: Enabled more clang warnings. 2020-04-16 bclayton@google.com Device/Blitter: Initialize filter3D fields 2020-04-16 digit@google.com Fuchsia: Add LLVM 10.0 configuration headers. 2020-04-16 amaiorano@google.com CMake: fix PowerVR_Examples build 2020-04-16 amaiorano@google.com Don't fail build if Vulkan headers are different 2020-04-16 amaiorano@google.com CMake: fix add_subdirectory(SwiftShader) when CMAKE_BUILD_TYPE is set in parent project 2020-04-16 amaiorano@google.com CMake: make submodule initialization work for add_subdirectory(SwiftShader) 2020-04-16 amaiorano@google.com CMake: fix add_subdirectory(SwiftShader) 2020-04-16 amaiorano@google.com CMake: use directory variables consistently 2020-04-16 amaiorano@google.com CMake: make root compile options and link libraries private 2020-04-16 bclayton@google.com VkSemaphore: Unlock/Lock the mutex outside the blocking_call. 2020-04-16 bclayton@google.com Regres: Include a better error message when git add fails. 2020-04-16 bclayton@google.com Regres: Avoid dereferencing a nil on process timeout. 2020-04-16 bclayton@google.com Make memoryPageSize() functions thread-safe. 2020-04-16 bclayton@google.com Vulkan: Move SpecializationInfo to own file. 2020-04-16 bclayton@google.com Fix chrome autorollers 2020-04-16 bclayton@google.com Reimplement LRUCache, fold away LRUSnapshotCache, add tests. Created with: gclient setdep -r third_party/SwiftShader@d25ce8725224 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I2ffd43f61a7258e9bc677ceb99789daea811bdda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2153675 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll eda526d3 2020-04-17T07:01:30 Roll third_party/vulkan-tools/src 0d4857ea576a..454ab259c1b8 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/0d4857ea576a..454ab259c1b8 git log 0d4857ea576a..454ab259c1b8 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 locke@lunarg.com icd: Image memory size Created with: gclient setdep -r third_party/vulkan-tools/src@454ab259c1b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ia25a9e8ad7814f5ed38f3363963664350f4baa47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2153673 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten f93cc8bd 2020-04-16T10:29:16 Vulkan: Skip failing BlendIntegerTest tests Several BlendIntegerTest tests are failing due to an update to the Vulkan Validation Layers that are now checking if formats support VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT and generating an error if not while pipeline.pColorBlendState.pAttachments[0].blendEnable is VK_TRUE. Bug: angleproject:4571 Test: BlendIntegerTest* Change-Id: Ibbfe415af3d6d6a879a502adb6541a5bfe8cd13a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152947 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill aefa3aa9 2020-04-15T14:27:12 Vulkan: Make staged clears store aspect mask. This will allow us to store depth- or stencil-only clear when we defer clears in FramebufferVk syncing. Currently a refactoring change only. Bug: angleproject:4517 Change-Id: Ifc9bf8f9ebab993509155cf6cf66db5b11f35163 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2151169 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3fb33ade 2020-04-09T15:27:12 Vulkan: Forward RenderBuffer/Surface dirty messages. Previously we were only forwarding Texture staging changes to the Framebuffer for re-sync. We could miss out on clears that were staged in Surfaces and Renderbuffer attachments. Complete the chain by making the SurfaceVk and RenderbufferVk forward notifications from the VkImage. Bug: angleproject:4517 Change-Id: I15f36c225517e915f656d0c2464a99631ef9f945 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2150699 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 1033d55d 2020-04-07T14:01:24 Pass binding enum to Framebuffer::syncState. Will allow us to determine if we're clearing the read or draw FBO. Then we can stash clears for the draw FBO only and issue them immediately for the read FBO in the Vulkan back-end. Bug: angleproject:4517 Change-Id: Ifc043317d6156a75749b13f9d2c44a17e14ee378 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139997 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Geoff Lang 8116c488 2020-04-09T12:18:02 Remove the merge command from roll_aosp.sh There are two issues doing the merge in the script: - This command makes the merge specific to an AOSP branch - It uses the version of roll_aosp that is from the previous roll instead of the ToT version. BUG=b:150892231 Change-Id: I579484092ca3d8c5e0e2d4d4bd1272eaeccc9da3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152667 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 1589de9e 2020-04-09T14:08:09 Remove some bad files when generating an ANGLE roll into Android Add a list of files that should be removed when rolling ANGLE into Android. The jsoncpp OWNERS file fails to upload to the Android gerrit because it contains owners that have never signed into the Android gerrit. BUG=b:150892231 Change-Id: I699dada53cdda2fbd012733a7a91eb8b5fb79d35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152668 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jian Li 943c3bc1 2020-04-16T11:25:02 Vulkan: Fix transform feedback on AMD platform Make sure pCounterBufferOffsets is never a null pointer when counterBufferCount is greater than zero. Bug: angleproject:3206 Change-Id: If161473239b53d2a65b1cccaaf1426a4fefd243a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152030 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang 005793e4 2020-04-09T12:16:20 Remove --preserve-root from roll_aosp.sh This flag is not supported on mac and generates errors when trying to roll. BUG=b:150892231 Change-Id: I22d10a2b9b37610d409df4d72e0aba2672f7b192 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152666 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 6b705ae7 2020-04-09T12:15:48 Roll VulkanMemoryAllocator into Android Bug: angleproject:2162 Change-Id: I0b1fc1ba1a3de8c4c00c5f6d26f8451e3ba8627e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152665 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Tobin Ehlis cbdc14be 2020-04-14T16:44:32 doc: Discuss manual roll in note on Vulkan-Headers repo Fix the formatting of the note on the Vulkan-Headers auto-roll failing. Also add information about performing a manual roll when multiple dependent repos have to be rolled in unison. Bug: angleproject:1944 Change-Id: I0acee1531f46e8dec67666de5eb18715dc012fe9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2148493 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
angle-autoroll d113c17a 2020-04-16T07:01:30 Roll third_party/vulkan-tools/src 1be434141625..0d4857ea576a (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1be434141625..0d4857ea576a git log 1be434141625..0d4857ea576a --date=short --first-parent --format='%ad %ae %s' 2020-04-15 petr_kraus@email.cz icd: Make VkPhysicalDevice unique Created with: gclient setdep -r third_party/vulkan-tools/src@0d4857ea576a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I9652559df93b6e9fa74da16a55bae5edbe94da06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152353 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bdd985d3 2020-04-16T07:01:38 Roll third_party/SwiftShader 81e08df29531..2430d665d3f2 (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/81e08df29531..2430d665d3f2 git log 81e08df29531..2430d665d3f2 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 amaiorano@google.com CMake: split out turbo-cov target 2020-04-15 amaiorano@google.com CMake: split out test and benchmark targets 2020-04-15 bclayton@google.com VkPipelineCache: Do not publically expose internal mutexes 2020-04-15 bclayton@google.com CMake: Fix build when building with `SWIFTSHADER_ENABLE_VULKAN_DEBUGGER` Created with: gclient setdep -r third_party/SwiftShader@2430d665d3f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I32f760225bb100968b82921889d5838f6d341106 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152357 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6eb2f118 2020-04-16T07:01:30 Roll third_party/vulkan-loader/src 3f7e3cbf33a7..3682237cb326 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3f7e3cbf33a7..3682237cb326 git log 3f7e3cbf33a7..3682237cb326 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 charles@lunarg.com tests: fix non-msvc windows test building Created with: gclient setdep -r third_party/vulkan-loader/src@3682237cb326 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ia126ec6080a64bfb2b98d5cd5765fce2854b378c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152355 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5f3889a6 2020-04-16T07:01:37 Roll third_party/spirv-tools/src c018fc6ae667..61b7de3c39f0 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c018fc6ae667..61b7de3c39f0 Created with: gclient setdep -r third_party/spirv-tools/src@61b7de3c39f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I9bbe69b1e77df3759c904d6248ac11714a86b1f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152356 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Rafael Cintron 49ad8eaa 2020-04-13T17:55:25 Enable allowClearForRobustResourceInit for Intel drivers NVidia drivers have no trouble clearing textures without showing corruption. AMD ones do. Intel drivers that have trouble have been relegated to the DX9 runtime by Chromium. Bug: angleproject:4460 Change-Id: I9ffbfa041e0f7ef8e05edcc14274bf9530eafae3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2147821 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Ancheng Qiao 1478ec3c 2020-03-18T09:42:37 Add gles1 primtest tests Bug: angleproject:2303 Change-Id: Idece2eb2fb291799c9aae811ce63dafdd9333887 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2143029 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tim Van Patten 868122c2 2020-04-10T13:17:44 Add 'java_api_finder' to Android.bp Per the Mainline requirement to setup coverage for APIs used by modules, we need to add the plugin 'java_api_finder' to ANGLE's Android.bp to enable the instrumentation. Bug: b:148987998 Test: Generate Android.bp, verify GoogleANGLE can build in goog/master Change-Id: Id3d82f18ecb9ff6a57cda4a60f14cd2464dff234 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145236 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Jian Li d5ba916d 2020-04-07T17:59:08 Vulkan: Change to record transform feedback related APIs per spec Fix not to record vkCmdBindPipeline and vkCmdBindTransformFeedbackBuffers during transform feedback is active. Initiated by Hyunchang Kim hckim.kim@samsung.com https://chromium-review.googlesource.com/c/angle/angle/+/1971953 Pause Transform feedback on binding graphics pipeline and end of render pass. Set a new dirty bit to indicate transform feedback may need resume when invalidate graphics pipeline. Test: dEQP-GLES3.functional.transform_feedback.* Test: angle_end2end_tests --gtest_filter=TransformFeedbackTest* Bug: angleproject:3206 Change-Id: I6c70ef461a31dcd618058b167835ac278a21d04a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139474 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 2aa42d8b 2020-04-15T07:01:38 Roll third_party/SwiftShader 711867566999..81e08df29531 (9 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/711867566999..81e08df29531 git log 711867566999..81e08df29531 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 sugoi@google.com Fix fragments depth values not being clamped 2020-04-14 amaiorano@google.com CMake: split out Vulkan sources into separate CMakeLists 2020-04-14 bclayton@google.com Device: Rename RoutineCacheT to RoutineCache 2020-04-14 bclayton@google.com Device: Don't inherit [Vertex,Setup,Pixel]Processor. 2020-04-14 digit@google.com [vulkan] Implement VK_FUCHSIA_external_memory extension. 2020-04-14 capn@google.com Reuse Store logic for Modf and Frexp output parameters 2020-04-14 capn@google.com Separate Operand store logic from EmitStore() 2020-04-14 capn@google.com Only store component count in Operand 2020-04-14 capn@google.com Rename size/sizeInComponents to componentCount Created with: gclient setdep -r third_party/SwiftShader@81e08df29531 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: If6202649d0e98bafbcc15fb88f9db8ef6710cc19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2150104 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 01de0c59 2020-04-15T07:01:30 Roll third_party/vulkan-tools/src ae0f0ead3a56..1be434141625 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ae0f0ead3a56..1be434141625 git log ae0f0ead3a56..1be434141625 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 jeremyk@lunarg.com build: Remove glslang dependancy from known-good Created with: gclient setdep -r third_party/vulkan-tools/src@1be434141625 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I242fcb852689b89a67e34c9c283ea4b091fc03cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2150100 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 749f70ea 2020-04-15T07:01:37 Roll third_party/spirv-tools/src e70d25f6fa5d..c018fc6ae667 (9 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e70d25f6fa5d..c018fc6ae667 Created with: gclient setdep -r third_party/spirv-tools/src@c018fc6ae667 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I0e7a20e1444006458413a7dfb1b3a025190a706f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2150103 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0c9ffcc4 2020-04-15T07:01:31 Roll third_party/vulkan-loader/src bb8be13e3ffe..3f7e3cbf33a7 (9 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/bb8be13e3ffe..3f7e3cbf33a7 git log bb8be13e3ffe..3f7e3cbf33a7 --date=short --first-parent --format='%ad %ae %s' 2020-04-11 charles@lunarg.com loader: Fix deadlock introduced by preloading ICDs 2020-04-11 charles@lunarg.com loader: Preload ICD's to speed up common path 2020-04-10 lenny@lunarg.com build: Find headers package from external dir 2020-04-09 kpet@free.fr Log debug messages with verbose severity instead of info 2020-04-08 shannon@lunarg.com build: Update known-good for 1.2.137 header 2020-04-08 lenny@lunarg.com tests: Update layer path test to strip empty paths 2020-04-08 lenny@lunarg.com loader: Strip out empty search paths 2020-04-08 david.c.hubbard@gmail.com loader: Fix clang-format formatting issues 2020-04-08 david.c.hubbard@gmail.com loader: Remove duplicate search paths on posix Created with: gclient setdep -r third_party/vulkan-loader/src@3f7e3cbf33a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Iec4a96b434135be41f62b0dc0a2a3f513ad1f338 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2150102 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5e7ef660 2020-04-15T07:01:30 Roll third_party/vulkan-validation-layers/src f89de66a9bcb..da9102fb013d (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f89de66a9bcb..da9102fb013d git log f89de66a9bcb..da9102fb013d --date=short --first-parent --format='%ad %ae %s' 2020-04-14 petr_kraus@email.cz tests: Remove mock workarounds for vkAcquire 2020-04-14 s.fricke@samsung.com layers: Update AHB to Android Q and better logging 2020-04-14 mark@lunarg.com test: Temporarily disable AHBCreateImageView test Created with: gclient setdep -r third_party/vulkan-validation-layers/src@da9102fb013d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ie96c4e25fb54f55fc44bd548890d6f45c9e15b95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2150101 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Hyunchang Kim 6e0d718a 2020-03-31T18:41:57 Vulkan: Implement device memory sub-allocation Use AMD Vulkan Memory Allocator for device memory sub-allocation. We now have a mempool from which all glBuffer memory is allocated. The CPU overhead involved in repeated IOCTL calls to the kernel is reduced significantly. Bug: angleproject:2162 Change-Id: Id7681ffe2ac3d2853141ebe34c7df7b7fdd0d55e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2124519 Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
shrekshao d26fb99e 2020-04-10T16:04:26 Add DrawBaseVertexVariants Tests This tests different DrawElements*BaseVertex draw calls from different extensions including OES_draw_elements_base_vertex, EXT_draw_elements_base_vertex, and ANGLE_base_vertex_base_instance, with various combinations of base vertex, base index values. Bug: angleproject:4536 Change-Id: I3cd256522684c6040199d7704aac8575237dbd96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2146292 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com>
Tobin Ehlis 1b30886d 2020-04-09T16:20:30 doc: Add note on Vulkan-Headers repo Added a note about other Vulkan repos being dependent on Vulkan-Headers repo. When the Headers repo roll fails, we need to pause it until after LunarG has manually updated the dependent repos with new Vulkan-Headers code. Bug: angleproject:1944 Change-Id: I5ac2b061ff7e262595760645a843850b1235332f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2144538 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
Xinyi He 7ce8f3e0 2020-04-14T11:07:25 Enable perFrameWindowSizeQuery by default on Mali It doesn't return out of date error after the native window has resized, so we need to enable perFrameWindowSizeQuery on Mali GPU. Bug: angleproject:4564 Change-Id: Ib454898c5653fbb1b05dc542f7266dfffb03e793 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145879 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 83678e51 2020-04-14T08:47:29 Tests: Update dEQP KHR GLES 3.1 expectations Last fix for this test group was merged here: https://github.com/KhronosGroup/glslang/pull/2175 Test: KHR-GLES31.core.shader_bitfield_operation.* Bug: angleproject:4402 Bug: b:153165560 Change-Id: Icfd8fcc0b4ef293870bff6fdc0852e85784bb16e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2148960 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 3d894d87 2020-04-14T07:01:38 Roll third_party/SwiftShader 9d2fd9c161ab..711867566999 (3 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/9d2fd9c161ab..711867566999 git log 9d2fd9c161ab..711867566999 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 capn@google.com Use the type and result ID helpers 2020-04-14 capn@google.com Obtain type ID from instruction 2020-04-14 capn@google.com Add helper methods for obtaining type and result ID Created with: gclient setdep -r third_party/SwiftShader@711867566999 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I5c762953ae81a1342956a1aa8e21c3ba176ef512 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2148712 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e742f507 2020-04-14T07:01:30 Roll third_party/glslang/src 46572440189e..4d2298bfd78a (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/46572440189e..4d2298bfd78a Created with: gclient setdep -r third_party/glslang/src@4d2298bfd78a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Icd70f042d69d7fe3ec9b8630815fbd08494b1625 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2148110 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6f7b0884 2020-04-14T07:01:30 Roll third_party/vulkan-tools/src 490e39372126..ae0f0ead3a56 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/490e39372126..ae0f0ead3a56 git log 490e39372126..ae0f0ead3a56 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 shannon@lunarg.com build: Update known-good files for 1.2.137 header Created with: gclient setdep -r third_party/vulkan-tools/src@ae0f0ead3a56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Iccceb7ba39e3df0be13a28dde86b5fa3666c17eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2148108 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll eb910b20 2020-04-14T07:01:37 Roll third_party/spirv-tools/src 34be23373b9e..e70d25f6fa5d (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/34be23373b9e..e70d25f6fa5d Created with: gclient setdep -r third_party/spirv-tools/src@e70d25f6fa5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I1ef922d305db17730c8e8f9434cf746c5ac6b4e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2148111 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 965eedbf 2020-04-14T07:01:30 Roll third_party/vulkan-validation-layers/src 019f4e38eb79..f89de66a9bcb (7 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/019f4e38eb79..f89de66a9bcb git log 019f4e38eb79..f89de66a9bcb --date=short --first-parent --format='%ad %ae %s' 2020-04-14 jzulauf@lunarg.com layers: Add missing WaitSemaphores (KHR/not) entry 2020-04-13 petr_kraus@email.cz layers: Add missing instance chassis locks 2020-04-13 s.fricke@samsung.com tests: Add support for VUID 02261 and 02262 2020-04-13 s.fricke@samsung.com layers: Add support for VUID 02261 and 02262 2020-04-13 s.fricke@samsung.com layers: Fix general external AHB tracking 2020-04-13 peter.griffin@linaro.org layers: Silence expected GCC warning 2020-04-13 rgarcia@igalia.com layers: Take separate stencil usage flags into account Created with: gclient setdep -r third_party/vulkan-validation-layers/src@f89de66a9bcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ib904e4f1e9cd44a904aeef4b88d80595a18a9067 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2148109 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao dee4d7a5 2020-04-10T10:22:56 Vulkan: Early fragment tests optimization Checks if early fragment tests as an optimization is feasible and enable it if we can. In the link time, if context state diagrees with optimization (in rare case), then remove the ExecutionModeEarlyFragmentTests sprv op code. Bug: angleproject:4508 Change-Id: Ifbb06c0ffb050a9f3ddb16ab50362e908b4b9cf6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2136490 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Tobin Ehlis 32457326 2020-04-13T12:01:42 Vulkan: Roll Headers and VVL repos Need to sync the Vulkan-Headers and Vulkan Validation Layers roll. Header update also requires codegen update. Bug: angleproject:3320 Change-Id: Id2256372797e8c9c280ef22c19eeca19d319279c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2147608 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
angle-autoroll ee7525af 2020-04-13T07:01:30 Roll third_party/glslang/src fd593d5f0834..46572440189e (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/fd593d5f0834..46572440189e Created with: gclient setdep -r third_party/glslang/src@46572440189e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Id93e9d89011dd0a4667b8b7a3cadac153d70e8f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2147376 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8b4d25b6 2020-04-13T07:01:30 Roll third_party/vulkan-tools/src 2fd41fab58c8..490e39372126 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/2fd41fab58c8..490e39372126 git log 2fd41fab58c8..490e39372126 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 petr_kraus@email.cz icd: Make swapchain images persistent 2020-04-10 petr_kraus@email.cz icd: Fix vkGetSwapchainImages behavior Created with: gclient setdep -r third_party/vulkan-tools/src@490e39372126 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Id6e2946e874a2f8181a99a9d1bcab1eff75d564c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2147375 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8128233d 2020-04-13T07:01:38 Roll third_party/SwiftShader e6f65d9265e7..9d2fd9c161ab (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/e6f65d9265e7..9d2fd9c161ab git log e6f65d9265e7..9d2fd9c161ab --date=short --first-parent --format='%ad %ae %s' 2020-04-11 bclayton@google.com LLVMReactor: Replace deprecated CreateCall overload 2020-04-10 digit@google.com [cmake] Add support for CMAKE_SYSTEM_NAME == "Fuchsia" Created with: gclient setdep -r third_party/SwiftShader@9d2fd9c161ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ia62a60b80d559b55d9532b01f5e2143a0cac97eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2147378 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya cf2c8e60 2020-04-09T18:52:29 EGL: Relax test skip conditions for a few colorspace ImageTests Relax test skip conditions for the following colorspace ImageTests - - SourceRenderbufferTargetTexture_Colorspace - SourceRenderbufferTargetTextureExternal_Colorspace - SourceRenderbufferTargetTextureExternalESSL3_Colorspace For these tests, it is sufficient to check for support of EGL_EXT_image_gl_colorspace extension Bug: angleproject:3756 Tests: angle_end2end_tests --gtest_filter=ImageTest.SourceRenderbufferTargetTexture*_Colorspace* Change-Id: I123fb14fc79e8f949a903b7586a0badf54297cfa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2144549 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
angle-autoroll 469c029a 2020-04-10T07:01:37 Roll third_party/spirv-tools/src 538512e8e898..34be23373b9e (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/538512e8e898..34be23373b9e Created with: gclient setdep -r third_party/spirv-tools/src@34be23373b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I8653cb757293dde84e52093935ef77c6ec9ba134 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145322 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 098baab3 2020-04-10T08:45:30 Roll third_party/glslang/src 75de196cecab..fd593d5f0834 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/75de196cecab..fd593d5f0834 Created with: gclient setdep -r third_party/glslang/src@fd593d5f0834 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I9a6f36dae55e9f5fe3c3e1feb16c8ecaba6afd14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145439 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e42f81e1 2020-04-10T07:01:30 Roll third_party/vulkan-validation-layers/src 47d5e27460af..e7bbc302dff2 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/47d5e27460af..e7bbc302dff2 git log 47d5e27460af..e7bbc302dff2 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 mikes@lunarg.com scripts: BP skip vkEnumerateInstanceVersion Created with: gclient setdep -r third_party/vulkan-validation-layers/src@e7bbc302dff2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I5a97db12c7518d1c9818b1053c5a355142b8b7e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145321 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ddaff6b6 2020-04-10T07:01:30 Roll third_party/vulkan-tools/src ae6787114fb5..2fd41fab58c8 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ae6787114fb5..2fd41fab58c8 git log ae6787114fb5..2fd41fab58c8 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 mark@lunarg.com Revert "icd: Fix vkGetSwapchainImages behavior" 2020-04-09 mark@lunarg.com Revert "icd: Make swapchain images persistent" Created with: gclient setdep -r third_party/vulkan-tools/src@2fd41fab58c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I3f845e2e3502a15b3330881a2bd361685157d6be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145320 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e9713ba1 2020-04-10T07:01:38 Roll third_party/SwiftShader 3cfa8e28be80..e6f65d9265e7 (5 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/3cfa8e28be80..e6f65d9265e7 git log 3cfa8e28be80..e6f65d9265e7 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 capn@google.com Rename GenericValue to Operand 2020-04-09 bclayton@google.com CMake: Fix linux build with SWIFTSHADER_BUILD_PVR 2020-04-09 bclayton@google.com Vulkan/Debug: Fix clang-10 warning 2020-04-09 bclayton@google.com third_party/cppdap: Roll forward to 4dcca577 2020-04-09 cwallez@chromium.org Clamp _SNORM formats to -1.0 Created with: gclient setdep -r third_party/SwiftShader@e6f65d9265e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I3ad322f6559f10baa889b97dd86f40b209731122 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145323 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Xinghua Cao c68dfaf3 2020-04-01T16:36:25 Avoid GPU-GPU copy for StructuredBuffer If uniform block is translated to StructureBuffer on D3D backend, must do a GPU-GPU copy when updating uniform buffer. If buffer's latest usage is StructuredBuffer, directly upload to structured buffer. Bug: angleproject:3682 Change-Id: I7303866d08705a43238732e5f5ae4858f0a33d63 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2131871 Commit-Queue: Xinghua Cao <xinghua.cao@intel.com> Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll df3cc205 2020-04-09T22:17:31 Roll third_party/vulkan-tools/src bb32b2a70168..ae6787114fb5 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/bb32b2a70168..ae6787114fb5 git log bb32b2a70168..ae6787114fb5 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 tobine@google.com mockicd: Track memory allocation size 2020-04-09 petr_kraus@email.cz icd: Make swapchain images persistent 2020-04-09 petr_kraus@email.cz icd: Fix vkGetSwapchainImages behavior 2020-04-09 petr_kraus@email.cz icd: Fix vkAcquireNextImageKHR generation Created with: gclient setdep -r third_party/vulkan-tools/src@ae6787114fb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com,tobine@google.com Change-Id: I284c0d5d29fa5c43ba82b6f2d1b901d188f28637 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2144983 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 405f8e7b 2020-02-24T17:38:10 Vulkan: Support Program Pipeline Objects Add support for PPOs to the Vulkan back end. Bug: angleproject:3570 Change-Id: I5403456929847c185467b008d810f31ecfcb60cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2072652 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Alexey Knyazev c12c1f57 2020-04-03T01:33:54 D3D11: Skip setting BlendState for integer attachments Some D3D11 drivers may produce unexpected results when blending is apllied to integer attachments. Minor cleanup: early exit for nullptr attachments. New BlendIntegerTest in angle_end2end. Bug: angleproject:4548, angleproject:4547, angleproject:4525, angleproject:4394 Change-Id: I236ac6db1f8dcaca54e9bc1b0803e1775fd75632 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2134448 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya dac5cc3b 2020-04-08T18:26:46 EGL: Add support for EGL_EXT_image_gl_colorspace extension Add support for creating images with custom colorspace. Bug: angleproject:3756 Tests: angle_end2end_tests --gtest_filter=ImageTest* Change-Id: I9c332c012541c094728d9d9bde7add4189084a33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104088 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
angle-autoroll 728b9178 2020-04-09T07:01:30 Roll third_party/vulkan-tools/src 444b7cd3eecd..bb32b2a70168 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/444b7cd3eecd..bb32b2a70168 git log 444b7cd3eecd..bb32b2a70168 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 charles@lunarg.com vulkaninfo: dynamically link vulkan on apple 2020-04-08 jeremyk@lunarg.com build: Update MoltenVK version in known-good.json Created with: gclient setdep -r third_party/vulkan-tools/src@bb32b2a70168 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I45796d1660670a5c1d681a4398906fd58a45e5b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2143561 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ec795053 2020-04-09T07:01:30 Roll third_party/vulkan-validation-layers/src 4db086125947..47d5e27460af (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4db086125947..47d5e27460af git log 4db086125947..47d5e27460af --date=short --first-parent --format='%ad %ae %s' 2020-04-08 tony@lunarg.com layers: Don't remove container contents during iteration 2020-04-08 mikes@lunarg.com layers: Fix operator= recursion 2020-04-08 mikes@lunarg.com layers: GCC -Wignored-qualifiers warning 2020-04-08 mikes@lunarg.com layers: GCC -Wdeprecated-copy warning Created with: gclient setdep -r third_party/vulkan-validation-layers/src@47d5e27460af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I160ac9d44094658510e72d63e75febb93679392a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2143560 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 41e665c4 2020-04-09T07:01:38 Roll third_party/SwiftShader 63ed0e445fa5..3cfa8e28be80 (7 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/63ed0e445fa5..3cfa8e28be80 git log 63ed0e445fa5..3cfa8e28be80 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 sugoi@google.com Remove debug only code limiting the number of primitives 2020-04-08 bclayton@google.com Regres: Post coverage results even if the test lists have not changed. 2020-04-08 amaiorano@google.com CMake: split out all src/OpenGL targets into their own CMakeLists 2020-04-08 amaiorano@google.com CMake: split out SwiftShader GL deps into separate files 2020-04-08 amaiorano@google.com CMake: clean up dependencies 2020-04-08 bclayton@google.com Add SystemBenchmarks. 2020-04-08 bclayton@google.com VkCommandBuffer: Remove static Cast() method Created with: gclient setdep -r third_party/SwiftShader@3cfa8e28be80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I360d07f9e492b562cd4c92e7a2fb8e2e40c4f129 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2143564 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll dcee8f94 2020-04-09T07:01:30 Roll third_party/glslang/src 9c3204a1fde0..75de196cecab (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9c3204a1fde0..75de196cecab Created with: gclient setdep -r third_party/glslang/src@75de196cecab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I2102b364c9eed8c66b93a166f423ac19e77f60ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2143562 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Xinghua Cao 2caf7ffd 2020-03-23T12:12:42 Address a TODO for instance uniform block This patch resolves one TODO that Support to translate instance uniform block containing only a large array member to Structured buffer on D3D backend when necessary. Bug: angleproject:4205 Change-Id: If2cd6cf633080820ea33e52269d7d86cd587c9ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2114912 Commit-Queue: Xinghua Cao <xinghua.cao@intel.com> Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang 23196076 2020-04-08T10:47:33 GL: Protect against infinite loops with CONTEXT_LOST in CheckError If the GL context generates a CONTEXT_LOST error, stop checking for errors. This error will be generated continuously and result in an infinite loop. BUG=angleproject:3020 Change-Id: Ib78d1ff3f84103e658307f2f892538700916449d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2142312 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 9f14f785 2020-04-08T07:01:20 Roll third_party/vulkan-validation-layers/src 004b2914bfe3..4db086125947 (9 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/004b2914bfe3..4db086125947 git log 004b2914bfe3..4db086125947 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 s.fricke@samsung.com tests: Add PhysicalDeviceFormatProperties2 for Device Profile API 2020-04-07 tony@lunarg.com tests: Fix extraneous errors 2020-04-07 tony@lunarg.com layers: Fix error message 2020-04-07 petr_kraus@email.cz tests: Remove commented code 2020-04-07 petr_kraus@email.cz tests: Refactor DeviceExtensionSupported 2020-04-07 mark@lunarg.com chassis: Use init funcs for device val obj setup 2020-04-07 mark@lunarg.com chassis: Use init funcs for instance val obj setup 2020-04-07 mark@lunarg.com layers: Init validation object types in child constructors 2020-04-07 s.fricke@samsung.com Improve Android build documentation Created with: gclient setdep -r third_party/vulkan-validation-layers/src@4db086125947 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I6acd0d4027ea1ff2eea4282535264a77aaf10930 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2141832 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 823b0c6d 2020-04-08T08:28:09 Roll third_party/SwiftShader bdb6807825ac..63ed0e445fa5 (8 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/bdb6807825ac..63ed0e445fa5 git log bdb6807825ac..63ed0e445fa5 --date=short --first-parent --format='%ad %ae %s' 2020-04-08 bclayton@google.com Remove src/Device/Config.cpp 2020-04-08 bclayton@google.com Kokoro: Check that build files don't reference non-existent files 2020-04-07 bclayton@google.com Regres: Fix uncovered calculations after optimizations 2020-04-07 bclayton@google.com Regres: Optimize coverage processing 2020-04-07 bclayton@google.com Regres: Re-populate treeFile.allSpans on parse. 2020-04-07 bclayton@google.com Update third_party/marl/BUILD.gn with new files 2020-04-07 bclayton@google.com Update Marl to 539094011 2020-04-07 bclayton@google.com Coverage: Improve uncovered visualizations Created with: gclient setdep -r third_party/SwiftShader@63ed0e445fa5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I20bccd4f47f8ec53c301759722a4838f28c69f17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2141842 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a5854a72 2020-04-08T07:01:19 Roll third_party/vulkan-loader/src 122067a02a25..bb8be13e3ffe (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/122067a02a25..bb8be13e3ffe git log 122067a02a25..bb8be13e3ffe --date=short --first-parent --format='%ad %ae %s' 2020-04-07 jmadill@chromium.org build: Fix not finding registry path in some cases Created with: gclient setdep -r third_party/vulkan-loader/src@bb8be13e3ffe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I8e0af907281be1c932c2a684b2ede117898a59b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2141831 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b69da999 2020-04-08T07:01:52 Roll third_party/spirv-tools/src 4af38c49bfee..538512e8e898 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4af38c49bfee..538512e8e898 Created with: gclient setdep -r third_party/spirv-tools/src@538512e8e898 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: If471dca9184dd7fb9c49678b7f37ff1bc9a5635c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2141834 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3d1386f3 2020-04-08T07:01:10 Roll third_party/vulkan-tools/src 1fbefe048387..444b7cd3eecd (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1fbefe048387..444b7cd3eecd git log 1fbefe048387..444b7cd3eecd --date=short --first-parent --format='%ad %ae %s' 2020-04-07 mark@lunarg.com mockicd: Make physical device static 2020-04-07 charles@lunarg.com vulkaninfo: fix app bundle not finding loader Created with: gclient setdep -r third_party/vulkan-tools/src@444b7cd3eecd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ib19f7829272f9298f16a63ec3cac95f58818f9a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2141630 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 8bd3dab1 2020-04-03T17:44:02 Create Context::getActiveLinkedProgram() In preparation for support Program Pipeline Objects, the new function Context::getActiveLinkedProgram() is being created that will handle returning the correct Program whether there is currently a Program or PPO active. This initial implementation doesn't actually support PPOs yet; that work is done in a follow-on CL. Bug: angleproject:3570 Test: CQ Change-Id: I534261738a55b2f671ca152c2ef9a1e81517a99c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135931 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Brandon Schade a156df23 2020-03-20T08:12:34 Vulkan: add support for EXT_texture_sRGB_R8 Added support for EXT_texture_sRGB_R8. The GL_SR8_EXT format will be available if the VK ICD supports VK_FORMAT_R8_SRGB. This does not add support for emulation of this format. Bug: angleproject:4503 Bug: angleproject:3609 Test: dEQP-GLES3.functional.texture.*.srgb_r8_* Change-Id: Ifaec92ac1a8561881f54ddb7fdf0975112711736 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135853 Commit-Queue: Brandon Schade <b.schade@samsung.com> Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Geoff Lang dd90f5a5 2020-04-07T12:59:23 Depend on vulkan headers in angle_gpu_info_util angle_gpu_info_util is capable of dynamically loading vulkan without a dependency but it still requires the dependency on the headers to compile on some systems. BUG= b:153394225 Change-Id: I698a825499364c09faea39384d25d454f83955b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139414 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang cb6470f9 2020-04-01T09:44:35 Set sdk_version for cc_genrules used by modules with sdk_version set sdk_version now creates a new variant, so the cc_genrules also need sdk_version set. Bug: b:149591340 Change-Id: I8c58cca2d4e73e9f123f968d47361e878743e1b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2131251 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill 76d52be3 2020-04-07T09:14:29 Vulkan: Add VulkanMemoryAllocator to DEPS. Bug: angleproject:2162 Change-Id: If91ae40c1fe818a59d775bb2fa066227dd52859d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139992 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 4609c4ac 2020-04-06T19:02:29 Feature::condition must not be NULL Since it's returned by eglQueryStringiANGLE, and the doc says: 1. eGLQueryStringiANGLE returns a pointer to a static, null-terminated string 2. On failure, NULL is returned So, we shouldn't be returning NULL when there is no failure. This was breaking 'chrome --enable-gpu-service-logging'. Bug: angleproject:3947 Change-Id: I2dcc7d479899dc1fc5fd59a502e84defe44f64c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2137939 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 2a0c3596 2020-03-31T15:36:45 Vulkan: Clean up robust and emulated image clears. This change consolidates image clears in multiple places into a single site in ImageHelper initialization. It adds support for appending clear image commands as well as prepend (the default). We prepend clears because image initialization happens after data upload. The Vulkan robust clear path now works like the other back-ends. The change flushed out a bug where partially uninitialized CopyTexImage was not correctly initializing a texture before triggering a full resource clear. Texture::copyImage now uses a workaround where we first init the image before clearing it. After the init we upload the new data. We'll use the appending clears path when implementing deferred clears. Bug: angleproject:4517 Change-Id: If9212f3b8cdd0fc8b7e729d364530801a644e164 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2130627 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 78a471ba 2020-04-03T16:21:21 TextureGL: Signal DirtyBitsChanged on dirty bits. This is a refactoring change only in preparation for a change in the Vulkan back-end. We'll need to split the handling for Vulkan and GL into different functions. Bug: angleproject:4517 Change-Id: I2ddf9c70fe247d1dcb4e0aa9ca929bbbd61bd42b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135893 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill c916fe8a 2020-04-02T16:57:49 Don't call syncState inside FBO queries. This prevents a syncState ordering issue that was confusing FBO sync when robust resource init is enabled. Also cleans up some redundant format processing for the half float extensions. Bug: angleproject:4517 Change-Id: Ieb13fc5203cf824a3e8affda96ea5cbbd89d78ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2134411 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill a30c6f35 2020-04-07T11:25:20 Vulkan: Pass RendererVk to BufferHelper::destroy. Bug: angleproject:2162 Change-Id: I7c0090d48b0a5bac222b1edf4c2db280d5b32930 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139993 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
angle-autoroll e4da6f15 2020-04-07T07:01:19 Roll third_party/vulkan-loader/src bb74deab0a4d..122067a02a25 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/bb74deab0a4d..122067a02a25 git log bb74deab0a4d..122067a02a25 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 udknight@gmail.com docs: Improve vkNegotiateLoaderLayerInterfaceVersion's description 2020-04-06 arnfranke@yahoo.com Add newlines to two DXGI files 2020-04-06 udknight@gmail.com docs: Correct one minor discrepancy in "Implicit vs Explicit Layers" 2020-04-06 lenny@lunarg.com build: Enable building static loader on MacOS Created with: gclient setdep -r third_party/vulkan-loader/src@122067a02a25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I3170f0a78d08f6ffa3abe717ce22ba2ef91aff46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139124 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
shrekshao 90e07c73 2020-04-06T17:04:32 Hook up several drawElements variants in Context11 Turns out the issue for the skia bug is not related to index range cache but simply several new drawElemnts variants are not properly hooked up. Change-Id: I2d1ae15c74233185e4fee8a1443ffe0477f9c444 Bug: angleproject:3402, angleproject:4536 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2137943 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll eb298a02 2020-04-07T08:25:52 Roll third_party/glslang/src b5757b95005b..9c3204a1fde0 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b5757b95005b..9c3204a1fde0 Created with: gclient setdep -r third_party/glslang/src@9c3204a1fde0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ib47c20eccdf3543272966d75e2fdf21fe29762c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139375 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d14735b2 2020-04-07T07:02:06 Roll third_party/vulkan-headers/src 0e78ffd1dcfc..b4b0f994204e (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/0e78ffd1dcfc..b4b0f994204e git log 0e78ffd1dcfc..b4b0f994204e --date=short --first-parent --format='%ad %ae %s' 2020-04-06 devrel@oddhack.org Update README.md with warning of pending header changes Created with: gclient setdep -r third_party/vulkan-headers/src@b4b0f994204e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=jonahr@google.com Bug: None Change-Id: I7b5b7a693c6e2e4aa6750643a2fc27be933626eb Tbr: jonahr@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139096 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c8007e14 2020-04-07T07:01:52 Roll third_party/spirv-tools/src e95fbfb1f509..4af38c49bfee (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e95fbfb1f509..4af38c49bfee Created with: gclient setdep -r third_party/spirv-tools/src@4af38c49bfee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I60bbf896f59abb085bc290e6e9c5cc950b49bc43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139126 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8d3f27d1 2020-04-07T07:01:20 Roll third_party/vulkan-validation-layers/src dbd073615280..004b2914bfe3 (5 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/dbd073615280..004b2914bfe3 git log dbd073615280..004b2914bfe3 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 petr_kraus@email.cz layers: Add some headers to cmake 2020-04-06 jbolz@nvidia.com tests: Test for pAccelerationStructures objects 2020-04-06 jbolz@nvidia.com lifetimes: Validate acceleration struture objects 2020-04-06 petr_kraus@email.cz tests: Remove noop from InitSwapchain() 2020-04-06 mikew@lunarg.com build-gn: Keep generate*.py identical across repos Created with: gclient setdep -r third_party/vulkan-validation-layers/src@004b2914bfe3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I01be09bc177a133a33d4cefccb7068e67b051c4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139125 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3f00ec81 2020-04-07T07:01:10 Roll third_party/SwiftShader b8d47928094f..bdb6807825ac (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/b8d47928094f..bdb6807825ac git log b8d47928094f..bdb6807825ac --date=short --first-parent --format='%ad %ae %s' 2020-04-06 sugoi@google.com Don't blend integer formats 2020-04-06 amaiorano@google.com Clamp GLES sine/cosine to [-1,1] 2020-04-06 sugoi@google.com Delete Plane.cpp and Plane.hpp 2020-04-06 bclayton@google.com CMake / Kokoro: Build and run system-unittests. Created with: gclient setdep -r third_party/SwiftShader@bdb6807825ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I556b6e20b1bc02d6b16c7243faaddd5aef423f36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139121 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll de9f945f 2020-04-07T07:01:10 Roll third_party/vulkan-tools/src 698d82e38b39..1fbefe048387 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/698d82e38b39..1fbefe048387 git log 698d82e38b39..1fbefe048387 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 joshua@froggi.es cube: Pick non-SRGB surface formats first 2020-04-06 joshua@froggi.es cube: Remove unncessary VK_FORMAT_UNDEFINED check for surface formats Created with: gclient setdep -r third_party/vulkan-tools/src@1fbefe048387 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I2b0ad5ede6e54cb9e288fdb1e3fa5c52a54c4fd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139122 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 461f9ab1 2020-03-30T12:41:34 Capture/Replay: Implement more GLES entry points Test: Temple Run capture and replay Bug: b:152512564 Bug: angleproject:3662 Change-Id: I4cb5d081e4f590d297dc4af6b49f5dc67584ecb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128329 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Cody Northrop 84323449 2020-03-30T12:40:12 Capture/Replay: Track buffer contents by ID This CL updates how we restore buffer data after the client has unmapped it. We do this because we have no visibility into whether the buffer has been changed while mapped. Tracking a buffer map/unmap pairing by target as we have been is insufficient as apps can bind multiple buffers in succession before rebinding and unmapping selectively. To avoid this, we change our buffer data resource tracking to use the buffer ID instead of target. Also, since the app can map multiple buffers, we need to track the active buffer during MapBufferRange so we can use it during replay to restore from the appropriate handle. This is a deferred operation, so we store it as a new member of the ParamBuffer to preserve the information. Test: Temple Run capture and replay Bug: b:152512564 Bug: angleproject:3662 Change-Id: I1d3f594b496e5675e814b82acb4a238f845e26d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128328 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
angle-autoroll d2de511e 2020-04-06T07:01:46 Roll third_party/SwiftShader f99302c4efe6..b8d47928094f (15 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/f99302c4efe6..b8d47928094f git log f99302c4efe6..b8d47928094f --date=short --first-parent --format='%ad %ae %s' 2020-04-04 bclayton@google.com Vulkan: Destruct the list of vk::Query in QueryPool 2020-04-03 amaiorano@google.com Really fix Android build 2020-04-03 amaiorano@google.com Fix Chromium and Android build 2020-04-03 bclayton@google.com Debug: Add missing include. 2020-04-03 bclayton@google.com Vulkan/Debug: Create a PhysicalFile if DebugSource has no content 2020-04-03 bclayton@google.com Vulkan/Debug: Always provide the dap::Source::path 2020-04-03 bclayton@google.com CMake: Don't always regenerate OpenCLDebugInfo100.h 2020-04-03 amaiorano@google.com CMake: use gtest and gmock targets 2020-04-03 amaiorano@google.com CMake: split out atsc-encoder into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: clean up cppdap usage 2020-04-03 amaiorano@google.com CMake: split out Reactor into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out boost into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out libbacktrace into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out subzero and llvm-subzero into their own CMakeLists 2020-04-03 bclayton@google.com Kokoro: Add the ppa:ubuntu-toolchain-r/test apt-repository Created with: gclient setdep -r third_party/SwiftShader@b8d47928094f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ibef6255d40850dce7a49cc52f7196511c9ac3024 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2137129 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d560ecf0 2020-04-06T07:01:05 Roll third_party/vulkan-tools/src 7844b9b4e180..698d82e38b39 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/7844b9b4e180..698d82e38b39 git log 7844b9b4e180..698d82e38b39 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 charles@lunarg.com vulkaninfo: fix msvc warnings from wrapper classes Created with: gclient setdep -r third_party/vulkan-tools/src@698d82e38b39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I2b080a43e16b6f565a324101b37ddf5748495e3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2137127 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2ba196d8 2020-04-06T07:01:08 Roll third_party/vulkan-validation-layers/src 9a283ae3457f..dbd073615280 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9a283ae3457f..dbd073615280 git log 9a283ae3457f..dbd073615280 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 sam.walls@arm.com tests: Add tests for Arm perfdoc check 17 2020-04-03 sam.walls@arm.com practices: Add implementation of Arm perfdoc check 17 2020-04-03 sam.walls@arm.com tests: Add tests for Arm perfdoc checks 12 + 13 2020-04-03 sam.walls@arm.com practices: Add implementation of Arm perfdoc checks 12 + 13 Created with: gclient setdep -r third_party/vulkan-validation-layers/src@dbd073615280 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ifc7136d37c715be29ed36c5c7aa977e4583fcb4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2137128 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 1c95795f 2020-04-03T14:49:45 Use ImageIndex in ensureSubImageInitialized. Passes an already initialized struct so we don't need to separately pass a level and layer. Also removes some redundant gl:: prefixes in Texture.cpp and adds a new helper function doesSubImageNeedInit. Refactoring change only. Bug: angleproject:4517 Change-Id: Ib2d8a5c9ceaada03cc8d299adcb5aed53a0cf13c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135928 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill c9c4e4ed 2020-04-02T10:29:52 Track rendering feedback loops by-context. This fixes an issue where feedback loops detection would trigger false positives based on texture use in multiple contexts. 1) there are two contexts, C1 and C2, sharing resources 2) in C1, there is a texture T bound to GL_TEXTURE_2D, and a program in use that will sample C1 3) in C2, a framebuffer is created and T is bound to it This fix indexes each set of active bindings in an object by ContextID. We can potentially redo this solution in the future if this proves to have too much tracking overhead. Includes a test writen by Ken Russell. Bug: angleproject:4517 Change-Id: I67012e68947c42d863dca193972576c82d5f3712 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2134406 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Mohan Maiya 96c26c68 2020-04-03T07:52:52 Add support for NV_shader_noperspective_interpolation Added support for GL_NV_shader_noperspective_interpolation on the Vulkan and Desktop OpenGL backends Bug: angleproject:4388 Test: angle_end2end_tests --gtest_filter=ShaderInterpTest.NoPerspective/* Change-Id: I12473830c0ea8b4fffeae9c4a8ec92d979c8e18c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107234 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill e259e7e3 2020-04-02T17:33:17 Pass layer count to robust 2D array texure init. The Vulkan back-end needs the layer count to correctly initialize the whole range of the mip level. Otherwise we were only clearing a single layer of the 2D array. This only popped up when the code started to be lazier about robust resource init. Bug: angleproject:4517 Change-Id: Id5007c877d413dc80d54d9800a5898e130593451 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2134412 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Courtney Goeltzenleuchter 390ef299 2020-03-25T14:10:38 Enable blob cache when debugging We've had several issues with shader caches which are only implemented on Android which makes them challenging to debug. The existing BlobCache object has a default implementation that is disabled by default. When debug layers are enabled resize the default cache so that it gets used and provides behavior closer to Android. This caching will be enabled when debug layers are enabled, e.g. EGL_PLATFORM_ANGLE_DEBUG_LAYERS_ENABLED_ANGLE attribute is true. This is done for angle_end2end_tests and deqp tests. Reland after bugfix angleproject:4535 Bug: b:152292873 Bug: angleproject:4535 Change-Id: Icefa8c55e39985d653d8d8a8bc8c734210025b50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2134449 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
angle-autoroll 78b66a16 2020-04-03T07:01:36 Roll third_party/vulkan-validation-layers/src 499f6df688c9..9a283ae3457f (7 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/499f6df688c9..9a283ae3457f git log 499f6df688c9..9a283ae3457f --date=short --first-parent --format='%ad %ae %s' 2020-04-02 mikes@lunarg.com scripts: Make VU text sanitizing more robust 2020-04-02 jungwan82@naver.com codegen: Fixed encoding errors 2020-04-02 petr_kraus@email.cz layers: Make code Cpp20 compatible 2020-04-02 mark@lunarg.com cmake: Disable WarningsAsErrors on obsolete CLANG versions 2020-04-02 tony@lunarg.com tests: Misc cleanup 2020-04-02 s.fricke@samsung.com tests: Add Disjoint Image Barrier VUID 2020-04-02 s.fricke@samsung.com layers: Add Disjoint Image Barrier VUID Created with: gclient setdep -r third_party/vulkan-validation-layers/src@9a283ae3457f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Icf971eeb37112c462522b3659dcdd9529325c7cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135460 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill e4aa679c 2020-04-01T17:46:31 Texture: Pass explicit unpack buffer to setImage. This will allow us to call setImage internally even if there's an unpack buffer bound. Useful when implementing robust resource init with copyTexImage in some edge cases. Bug: angleproject:4517 Change-Id: I7e8e9536ab9222c620e572f7b6c20b08fa29d646 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2133088 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>