kc3-lang/angle

Log

Author Commit Date CI Message
Cody Northrop 33c86fde 2024-11-14T14:33:21 Tests: Add SimCity BuildIt trace Test: angle_trace_tests --gtest_filter="*simcity_buildit*" Bug: b/379097986 Change-Id: I8753014ebcf6ab1ea55868141a527429e8fb4f8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6021680 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 5754fb80 2024-11-15T10:01:28 Roll vulkan-deps from 1096ec1aabbb to c93d7c04d2f7 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1096ec1aabbb..c93d7c04d2f7 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/cb9a9d375dfde6477c14a4f3de9e320134d37447..4f8fa5f970def61619b4f3810842d5c725650910 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/35e5f1160ecd2b963682e14e869001a60160a0c4..27433b11e9e9e2738eb34d7dd07694a82fc0b51d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/dbc663dcf28c5bd0bc2e7374e04e5127c0590302..9959ca313e3a7bee3d6a02b7033fd08c51d06871 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/117b968efe36ce262d4b1b65125196e71ad08677..7207c18845e936fb9ff7dc745722e6213c360a03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Iae9f5e9084e6e037d3fb7d48d1ea795aa70c06db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6023883 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b3af0563 2024-11-15T10:01:30 Roll SwiftShader from d5c428477411 to 4d3a7b64279f (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/d5c428477411..4d3a7b64279f 2024-11-14 zequanwu@google.com Disable Clang -Wnontrivial-memaccess warning on Memset.hpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: If13c6e6d9ae8fc35a2b54f6b63564f3593b4a78f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6024080 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Rafay Khurram 0dc407dc 2024-06-25T11:49:25 CL/Vulkan: Address slicePitch and rowPitch issues in images * Based on spec, the slicePitch >= the row pitch for 1D array * Validation should check if slicePitch >= rowPitch * region[1] for 2D array and 3D images * The row pitch should be based on region rather than image extent for the host copy * Offset in staging buffer is modified to be based on row and slice pitch * Returned row and slice pitch for clEnqueueMapImage is updated to be based on image's extent since mapped staging buffer is utilized Tests-Passing: OCLCTS.test_basic imagereadwrite, OCLCTS.test_basic imagereadwrite3d, OCLCTS.test_basic enqueue_map_image, OCLCTS.test_cl_fill_images use_pitches Bug: angleproject:42266936 Change-Id: I0f9bc5c576167bbdcdde467773f8159eb7bddb99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6014983 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Rafay Khurram <r.khurram@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Rafay Khurram b9932271 2024-06-18T16:38:28 CL/Vulkan: Add handling for NormalizedSamplerMaskPushConstant * Includes code for parsing reflection data and adding push constant * Creates a new sampler that is normalized to conform with constant * Fixed pointer returned in getImageDataChannelOrderRange/DataTypeRange Tests-Passing: OCLCTS.test_basic readimage3d, OCLCTS.test_basic readimage3d_fp32, OCLCTS.test_basic readimage3d_int16 Bug: angleproject:42266936 Change-Id: I6390193401c0c0411df87d9f61c917c8df7918d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6016821 Commit-Queue: Rafay Khurram <r.khurram@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Rafay Khurram aaf07534 2024-06-14T03:07:12 CL/Vulkan: Fix clEnqueueUnmapMemObject for host ptr image cases * For CL_MEM_USE_HOST_PTR case, host ptr has to be utilized in unmap. Tests-Passing: OCLCTS.test_cl_fill_images use_pitches 1D, OCLCTS.test_cl_fill_images use_pitches 1Darray, OCLCTS.test_cl_fill_images use_pitches 2D, OCLCTS.test_cl_fill_images use_pitches 2Darray, OCLCTS.test_cl_fill_images use_pitches 3D Bug: angleproject:42266936 Change-Id: I8fd3cd91fea61283ad5c28c1a7040d43310a0345 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5987534 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Rafay Khurram <r.khurram@samsung.com>
Rafay Khurram 08ce5672 2024-06-11T17:28:34 CL/Vulkan: Add pitches handling for image APIs * Changes applied to clCreateImage, clEnqueueReadImage, and clEnqueueWriteImage * Involved performing CPU copies to/from the staging buffer with pitch factored in Tests-Passing: OCLCTS.test_cl_read_write_images use_pitches 1Darray, OCLCTS.test_cl_read_write_images use_pitches 2D, OCLCTS.test_cl_read_write_images use_pitches 2Darray, OCLCTS.test_cl_read_write_images use_pitches 3D, OCLCTS.test_cl_fill_images 2D, OCLCTS.test_cl_fill_images 3D, OCLCTS.test_cl_fill_images 1Darray, OCLCTS.test_cl_fill_images 2Darray Bug: angleproject:42266936 Change-Id: I9d5bbecb9d83b2138b40e40e23a22218e497dcd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5987702 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rafay Khurram <r.khurram@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Rafay Khurram c5242b6f 2024-06-03T00:40:05 CL/Vulkan: Add extent, offset, and layers handling for arrays * Sets the array layer count to appropriate value * For 1D/2D array, base layer is equivalent to the y/z origin * For 1D/2D array, offsets and extents should be set to 0/1 for unused dimensions Tests-Passing: OCLCTS.test_cl_copy_images 1Darray, OCLCTS.test_cl_copy_images 2Darray, OCLCTS.test_cl_copy_images 2Darrayto2D, OCLCTS.test_cl_copy_images 2Darrayto3D, OCLCTS.test_cl_copy_images 2Dto2Darray, OCLCTS.test_cl_copy_images 3Dto2Darray, OCLCTS.test_cl_copy_images max_images 1Darray, OCLCTS.test_cl_copy_images max_images 2Darray, OCLCTS.test_cl_copy_images max_images 2Darrayto2D, OCLCTS.test_cl_copy_images max_images 2Darrayto3D, OCLCTS.test_cl_copy_images max_images 2Dto2Darray, OCLCTS.test_cl_copy_images max_images 3Dto2Darray, OCLCTS.test_cl_copy_images small_images 1Darray, OCLCTS.test_cl_copy_images small_images 2Darray, OCLCTS.test_cl_copy_images small_images 2Darrayto2D, OCLCTS.test_cl_copy_images small_images 2Darrayto3D, OCLCTS.test_cl_copy_images small_images 2Dto2Darray, OCLCTS.test_cl_copy_images small_images 3Dto2Darray, OCLCTS.test_cl_read_write_images 1Darray, OCLCTS.test_cl_read_write_images 2Darray, OCLCTS.test_cl_read_write_images max_images 2Darray Bug: angleproject:42266936 Change-Id: I5ffb792c640c536045450ad6583d8d3bc0358d64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5987532 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Rafay Khurram <r.khurram@samsung.com> Commit-Queue: Rafay Khurram <r.khurram@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 12b14840 2024-11-15T07:02:13 Roll Chromium from 159c891eeeab to b3ded8346a3f (616 revisions) https://chromium.googlesource.com/chromium/src.git/+log/159c891eeeab..b3ded8346a3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8ad811f135..91e3b5c7b8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/50812be68c..ed05804014 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1ffd70268e..16df85f9a7 * third_party/android_build_tools/aapt2/cipd: qXnC3iub0jUgx1jcQKtjij1JiQWCJr2RQjRQB8IogXQC..JPmxYHMZl4VH2Umf2-flGSdTVHtNDdFBmXd7v1Gs7EoC * third_party/android_build_tools/error_prone/cipd: DBKfaigj6AuTYPdN1_6jkOlQUuJa1szDRIMvHbtZrD8C..Lijeddt6PPk-Lv6NK95TXf-pTUjBQfa-785WIbM7UT8C * third_party/android_build_tools/lint/cipd: HN75GJDpeKeDLCh_GsgxNHaTxdvaq67g2pKrfyGIpggC..XU62_R9yK-y7lyUbMQtZnJk1I3PVCT4te30rymGl2lsC * third_party/android_build_tools/manifest_merger/cipd: 9J06ckbu_XLEYhJf97q_OfRzNqGgH-_dVFaS6GwAl_UC..CjffpWaQIednn-RajH5mg2H1j44x-63USR1VII1i9pcC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/35e2c6c5ab..8f76963b42 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/6337c445f9..fd83463c1f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9d74d92bfa..7d031cd662 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eda5c0c348..c22f4dc74f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/9e360f4237..7702c3d2a1 * third_party/r8/cipd: QRnmywGxnFEYZfWN6jqCj7S5cxMyArjgzNnMIxLPoTYC..vRC_kBieOulAhXzHCjKExmKxyhh02DgRzvPVaaM2swwC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/93d3de8232..f02f3bd277 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9acda1601e..d60624d4b1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/425674896e..287e3c282d * tools/skia_goldctl/mac_amd64: AUrEBiy7rYPBIDIqxKxT1eVxxP4HxYFWhP3B6qyiALYC..aWw1JVWpKckecy3rBuN-5Y_osHIckC0ganu7xQ28f4UC No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ie613a9347177e8255f09ea9dd1cbf035334b40c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6023880 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 7ba69645 2024-11-14T10:07:31 Fix unnamed outs w/ initializeUninitializedLocals Fix translator initializeUninitializedLocals pass for anonymous out parameters. The parameters should be initialized to zero, similar to named but unassigned parameters. Initialization would be skipped on GLSL output, assert on Metal. Functions need to be replaced if their parameter names change. In case the function had a prototype declaration, that has to be replaced too. All calls to old functions must be replaced with calls to new function. Bug: angleproject:378584780 Change-Id: I9a990fa3840f6e26cd30f35bf6c99d9a8816f272 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6020245 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Rafay Khurram 52831fc0 2024-05-30T02:28:11 CL/Vulkan: Add handling for image push constants Tests-Passing: OCLCTS.test_kernel_image_methods 1D, OCLCTS.test_kernel_image_methods 2D, OCLCTS.test_kernel_image_methods 3D, Bug: angleproject:42266936 Change-Id: Ie0c488ec02047a4a3da387c32178d05397c9d174 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5987700 Commit-Queue: Rafay Khurram <r.khurram@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen 03c75d35 2024-11-14T14:24:44 Remove SeparateStructFromFunctionDeclarations Move SeparateStructFromFunctionDeclarations to SeparateDeclarations It is logical part of the separate declarations step. Bug: angleproject:378966971 Change-Id: Ie102a1d936f7b444f5f9f2ac2fe8dc6c10027782 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6022857 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Rafay Khurram e557b60e 2024-05-28T17:40:49 CL/Vulkan: Add destruction of staging buffer for CLImageVk * Staging buffer wasn't being destroyed leading to a memory leak. Tests-Passing: OCLCTS.test_cl_fill_images 3D, OCLCTS.test_cl_fill_images max_images 3D, OCLCTS.test_cl_copy_images 3D, OCLCTS.test_cl_copy_images max_images 3D, OCLCTS.test_cl_copy_images small_images 3D, OCLCTS.test_cl_copy_images 2Dto3D, OCLCTS.test_cl_copy_images max_images 2Dto3D, OCLCTS.test_cl_copy_images small_images 2Dto3D, OCLCTS.test_cl_copy_images 3Dto2D, OCLCTS.test_cl_copy_images max_images 3Dto2D, OCLCTS.test_cl_copy_images small_images 3Dto2D Bug: angleproject:42266936 Change-Id: I2526eb994563f20b8e8f352d303957e768a3bde0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5987531 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rafay Khurram <r.khurram@samsung.com>
Rafay Khurram 485f6c34 2024-05-24T03:06:31 CL/Vulkan: Implement clEnqueueFillImage * Packs fillColor values, copies image to staging buffer, fills the relevant pixels in mapped staging buffer, and then copies back to image Tests-Passing: OCLCTS.test_cl_fill_images 1D, OCLCTS.test_cl_fill_images max_images 1D Bug: angleproject:42266936 Change-Id: I2ceb98830f49318edb71a1be14cecfdb4476d7ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5961949 Commit-Queue: Rafay Khurram <r.khurram@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Igor Nazarov bf07bcb7 2024-11-11T17:23:43 Vulkan: Remove dead code since mSwapchainImages always valid All elements of the `mSwapchainImages` always contain valid images. This fact makes code calling `acquireNextSwapchainImage()` in the `WindowSurfaceVk::lockSurface()` a dead code. Probably, instead of `acquireNextSwapchainImage()` it should call `doDeferredAcquireNextImage()` if `needsAcquireImageOrProcessResult()` is true, but this is another issue. This CL simply removes a dead code. Bug: angleproject:42264593 Bug: angleproject:42262606 Change-Id: Ic7bda330d74e1ccad149ffab723954f45dab700b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6018092 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen df61fc7f 2024-11-14T13:31:24 Avoid reordering structs when separating from func Avoid reordering structs when separating struct declarations and function declarations. Consider: struct S1 { ... }; struct S2 { S1 a; } f(); SeparateStructFromFunctionDeclarations would insert the S2 to the beginning of the containg block, so before S1 definition. Fix by not inserting the structs to the parent block. Instead, return the nodes from multi-replacement, so that the struct definition is inserted at the site of the replaced function. Bug: angleproject:378966971 Change-Id: I47582660610c1fcb28a9b5bd592ac020b5c48e34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6022856 Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 54e8e665 2024-11-12T12:53:54 Trace tests: generate and use trace list according to gn args Generates out/<config>/gen/trace_list.json which contains the list of traces included in the build according to the angle_restricted_traces gn arg (or all traces if not set). Test runner uses that file instead of the full restricted_traces.json. Android runner pushes that file to the device to the usual location (e.g. /sdcard/chroimum_tests_root/gen/trace_list.json) This also fixes the issue where `angle_trace_tests --list-tests` lists all traces, not just those that were selected with the gn arg. Similarly, running all traces without a filter would be limited to the same list. This transitively applies to trace bundles. Bug: b/376923930 Change-Id: I63506a074d766a51b860472f7211842f8a080ecd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6011956 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 8134b1cc 2024-11-13T21:45:38 CL: Rename ocl_cts_binary to ocl_cts_source_set Bug: angleproject:372722560 Change-Id: I6dcc033adf199a9d2522921f4bcbfaeb3e10137f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6019866 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen a402f9cb 2024-11-11T15:08:41 Metal: Do not use number digit separator in .mm The review system turns ' to strings for Obj-C syntax highlighting. Bug: angleproject:378421872 Change-Id: I201f6561def7c4b945f37e3e02ec0b8915954e8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6011209 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 05bd847c 2024-11-14T10:01:27 Roll vulkan-deps from 4cd63162a07c to 1096ec1aabbb (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4cd63162a07c..1096ec1aabbb Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/996c728cf7dcfb29845cfa15222822318f047810..45b314049d6262c850cc873c8f9a30f41a1e0c13 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/692529b941dc5d7dfbd90dfa5796c60cd0a50431..35e5f1160ecd2b963682e14e869001a60160a0c4 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/87ab6b39a97d084a2ef27db85e3cbaf5d2622a09..247accd4ed34bb80c745a9c844a59cdc992bd7e9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/f284b633cbb822da16375bd98d7b173ea864bd85..117b968efe36ce262d4b1b65125196e71ad08677 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: If8bdfb3ec6befd1fcacca8be04e8f05733b75ee2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6022540 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 06f476ea 2024-11-14T07:00:48 Roll Chromium from 8b70336fb4c3 to 159c891eeeab (662 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8b70336fb4c3..159c891eeeab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b415ee83cd..8ad811f135 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0f8a0e6574..50812be68c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b8ace7091f..35e2c6c5ab * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1261fbb4d6..9d74d92bfa * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/25f9761514..eda5c0c348 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/cec7f47835..6c4fa00e4b * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/4691d30558..9e360f4237 * third_party/r8/cipd: zTXs2yShcafS05919QFe3oyiR3XiKMdk_yiNHqGTGoQC..QRnmywGxnFEYZfWN6jqCj7S5cxMyArjgzNnMIxLPoTYC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c7678ba8af..7e2e4d7c65 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/a7c4c789db..93d3de8232 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4bd500b6f2..37d1894d53 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/45239f8c24..9acda1601e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/fedd080f97..425674896e * tools/skia_goldctl/mac_amd64: aWw1JVWpKckecy3rBuN-5Y_osHIckC0ganu7xQ28f4UC..AUrEBiy7rYPBIDIqxKxT1eVxxP4HxYFWhP3B6qyiALYC No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I4950457cae9b6f34537d9b59912530de90f73e58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6022529 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Rafay Khurram 924ee1ba 2024-08-28T02:16:55 CL: Enable CTS over GTest interface * Enables all CTS test suites excluding test_subgroups * Creates one gtest-based executable per OpenCL CTS executable Bug: angleproject:372722560 Change-Id: Iae96c2f12716b3c21d5035fbf6c9d838cb812025 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5938948 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 817b7d20 2024-11-13T10:41:49 Trace Tests: Skip solar_smash on Intel Windows Non-deterministic on Intel Windows. Bug: b/378900717 Change-Id: I393bf4fbeb6764ecb3cba61e012036f8f69605c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6017397 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Solti Ho <solti@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Cody Northrop b09008fd 2024-11-13T10:28:36 FrameCapture: Warn when shaders are not attached yet Instead of assert, print a warning when we don't have attached shaders on an unlinked program. There's work involved to support it, but also scenarios where it isn't a blocker to capturing a trace. For instance, if the program isn't used, we don't care if it doesn't have attached shaders. Test: SimCity BuildIt Bug: b/334030316 Change-Id: Ied85af433e769ec8f1e436de82e911ff691ea9c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6017396 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 14e4435b 2024-11-12T23:08:55 FrameCapture: Start active queries last in MEC Before this CL, we cycle through all queries, Begin and End them, unless they are active, and we skip End. That can give us a sequence like this: glGenQueries(1, (GLuint *)gReadBuffer); UpdateQueryID(1, 0); glBeginQuery(GL_TIME_ELAPSED_EXT, gQueryMap[1]); glEndQuery(GL_TIME_ELAPSED_EXT); glGenQueries(1, (GLuint *)gReadBuffer); UpdateQueryID(2, 0); glBeginQuery(GL_TIME_ELAPSED_EXT, gQueryMap[2]); glGenQueries(1, (GLuint *)gReadBuffer); UpdateQueryID(3, 0); glBeginQuery(GL_TIME_ELAPSED_EXT, gQueryMap[3]); glEndQuery(GL_TIME_ELAPSED_EXT); Note that gQueryMap[2] is not Ended because it is active. That results in a GL error when we try to Begin gQueryMap[3]: INFO: glBeginQuery: GL error: HIGH: Other query is active. To fix this, we need to start active queries last. That results in the following sequence: glGenQueries(1, (GLuint *)gReadBuffer); UpdateQueryID(1, 0); glBeginQuery(GL_TIME_ELAPSED_EXT, gQueryMap[1]); glEndQuery(GL_TIME_ELAPSED_EXT); glGenQueries(1, (GLuint *)gReadBuffer); UpdateQueryID(2, 0); glGenQueries(1, (GLuint *)gReadBuffer); UpdateQueryID(3, 0); glBeginQuery(GL_TIME_ELAPSED_EXT, gQueryMap[3]); glEndQuery(GL_TIME_ELAPSED_EXT); glBeginQuery(GL_TIME_ELAPSED_EXT, gQueryMap[2]); Test: Filament mosquito trace Bug: b/322364529 Change-Id: I4de9401e49bf93b0cfe02ba5ad536f3ab3079b81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6017473 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Kimmo Kinnunen eb614d7e 2024-11-11T13:24:35 Metal: Avoid leaking library and binary sources Reland: Fix build with metal_internal_shader_compilation_supported = false Fix leak of dispatch_data during binary load. The dispatch object was not released. Dispatch objects are Obj-C objects, so hold with AutoObjCPtr. Fix leak of MTLLibrary objects when creating the objects. The method newLibraryWithData returns +1 due to being "new" type method. This ref must be adopted. Avoid using autoreleased objects, use AutoObjCPtr. Some leaks regressed in commit c5ab1cebccaab0f8de466e5f797faa3d5a84bea5. Bug: angleproject:351165323 Change-Id: I08bc6bcb787cdc3f71e9487d80a44e24b01b6b4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6017845 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll d9af7ac7 2024-11-13T11:20:16 Roll vulkan-deps from d1b8acb8cd01 to 4cd63162a07c (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d1b8acb8cd01..4cd63162a07c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/384d527ebb7578b5a8d69fb05f41c5aa9a363115..692529b941dc5d7dfbd90dfa5796c60cd0a50431 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/15f2de809304aba619ee327f3273425418ca83de..df2ac1bb61f09a80db979d7108adf07b6fe55913 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/62da7221c04e85e4c0bba0bc3f748cfaab55b6fe..f284b633cbb822da16375bd98d7b173ea864bd85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: If6e6f2e4a566aff4ea40132cb7d67e5966239492 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6017472 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1ae78f55 2024-11-13T07:01:56 Roll Chromium from 75279b66ac13 to 8b70336fb4c3 (552 revisions) https://chromium.googlesource.com/chromium/src.git/+log/75279b66ac13..8b70336fb4c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8a810c637f..b415ee83cd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/319e286ea3..0f8a0e6574 * third_party/android_build_tools/aapt2/cipd: cfGQ9GV4juNnGZIPzTmaL3ehiZM1hs6UsB5HUA8fT6oC..qXnC3iub0jUgx1jcQKtjij1JiQWCJr2RQjRQB8IogXQC * third_party/android_build_tools/lint/cipd: vBoRPSPyoHi8GYvjtidLlKAtqp5a-2CaHgpEZb16dAoC..HN75GJDpeKeDLCh_GsgxNHaTxdvaq67g2pKrfyGIpggC * third_party/android_build_tools/manifest_merger/cipd: 1gDDnuAjB1-mlxlnLFAfx4h9f_hG3lEIIbwyYr86i1wC..9J06ckbu_XLEYhJf97q_OfRzNqGgH-_dVFaS6GwAl_UC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/af142f1e69..1261fbb4d6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/41d43a2a22..25f9761514 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/ca74a72e2b..4691d30558 * third_party/r8/cipd: 6tS5W0W6vy5TPDxAc-wTObNng6QBVt7cQr3lazvrbpEC..zTXs2yShcafS05919QFe3oyiR3XiKMdk_yiNHqGTGoQC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/9b898fa7cc..a7c4c789db * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e7abceab37..fedd080f97 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I5466a5f61f14c0a63b6cfdef8edc90d4677bfcd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6014982 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Solti Ho b2d84a66 2024-11-12T20:14:48 Revert "Metal: Avoid leaking library and binary sources" This reverts commit 6359ec111595c57e6be04b0468ca866f91593f2f. Reason for revert: https://chromium-review.googlesource.com/c/angle/angle/+/6011208/comments/c1453ef2_2c6a5e49 Original change's description: > Metal: Avoid leaking library and binary sources > > Fix leak of dispatch_data during binary load. The dispatch object > was not released. Dispatch objects are Obj-C objects, so hold with > AutoObjCPtr. > > Fix leak of MTLLibrary objects when creating the objects. > The method newLibraryWithData returns +1 due to being "new" type > method. This ref must be adopted. > > Avoid using autoreleased objects, use AutoObjCPtr. > > Some leaks regressed in c5ab1cebccaab0f8de466e5f797faa3d5a84bea5. > > Bug: angleproject:351165323 > Change-Id: If23859fbddd21693d923f66f6fb015eed494f06e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6011208 > Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Note: the revert merges the changes of https://crrev.com/c/6011902 Bug: angleproject:351165323 Change-Id: Iec1a14c8043e0883190723edf7302127c27f2de4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6013090 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski c7a43ec8 2024-10-28T12:26:05 Capture/Replay: Track framebuffers by context Some game titles treat framebuffer objects as shared. Framebuffer objects are now tracked per-context to avoid conflicts. Test: angle_trace_tests --gtest_filter=TraceTest.limbo --offscreen Bug: b/371985732 Change-Id: I34ae5b54d569eec75ad86b7b363f7a84d56d955c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5973639 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Matthew Denton 4a835cf2 2024-11-01T13:31:00 WebGPU: send uniforms to GPU for use in shader Basic uniforms should now be accessible in the shader during a draw call, rather than just via glGetUniform*(). This is unoptimized and creates a new GPU-side copy of all the uniforms, every time any uniform changes. This sets up the bind group layout for a pipeline and sets the bind groups in the renderer pass. Right now these bind groups only contain the default uniform blocks, but in the future will need to contain textures, samplers, and non-default uniform blocks (UBOs). Bug: angleproject:376553328 Change-Id: I50891b81ab2ee374d674213257f76319c0222120 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5980972 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Amirali Abdolrashidi 4707e5bb 2024-11-05T10:59:46 Unskip mini_world for other QCOM devices Currently, mini_world is being skipped for all QCOM devices. However, it seems to be working on more recent devices. Therefore, the skip could be limited to P4/P4XL due to image diffs and errors respectively. * In the case of P4XL, it is not confirmed if the original error still persists. Bug: b/331271522 Change-Id: I7ee00a74131ea47463a513121b15e445bddb9289 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5994385 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Gowtham Tammana 267a3daf 2024-11-05T19:51:58 CL/Vulkan: Use enums for cmd exec status instead of bools Setup the `createEvent()` interface to take the initial state of the event using an enum, instead of boolean for better readability. Bug: angleproject:377997556 Change-Id: Ib5a23cf2034e61e90b345bb432af59d96338b707 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6004063 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Gowtham Tammana 05b58737 2024-11-04T13:52:09 CL: Add CL command execution status to the enum list Adding the CL command execution status enums to the auto enum generation list - packed_cl_enums.json. The execution status are defined as cl_int in the CL api, and as such they are not packed at the entry points - entry_points_cl_autogen.{h,cpp}, and are left to be used at the implementation layer. The following files are autogeneration through `run_code_generation.py` script. - scripts/code_generation_hashes/packed_enum.json - src/common/PackedCLEnums_autogen.cpp - src/common/PackedCLEnums_autogen.h Bug: angleproject:37997556 Change-Id: Ia00fc12ef02e3882d47a1ad18cd6c11ce6bf63dc Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6004062 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 9cd3dc64 2024-10-04T12:33:04 Reland "Vulkan: Enable build on Chrome/Android" This is a reland of commit e2a238511238fdd94b260f3397db5271c1c1e45a Original change's description: > Vulkan: Enable build on Chrome/Android > > Bug: chromium:371512561 > Change-Id: I4cecb44550c5de5ee843e2db0fc138b5aaab3c71 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905861 > Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: chromium:371512561 Change-Id: I2007d3dd2c96cb5241474401361291caa03e5536 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6014641 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen f5b9e0ed 2024-11-11T16:06:30 Metal: Query MSL print env var with bool getter Use angle::GetBoolEnvironmentVar. Bug: angleproject:378404988 Change-Id: I45778690e215325e9e4eb67c6feefa9b17941f49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6011902 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Kimmo Kinnunen c46e6bac 2024-11-12T13:55:01 Make intermediate output symbol names consistent Make intermediate output symbol names consistent across uses in parameter names, struct names, variable names: - built-in without quotes - '' empty - #satb ANGLE internal - 'a' user-defined Previously empty parameters would output the symbol id-generated name ("sabb"), which was surprising when this is used only when the symbol is in AngleInternal namespace, and not in Empty namespace. Bug: angleproject:378584780 Change-Id: I87b13cf964a1ae3ee54b8f4ef7a00eddcd474760 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6011018 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen b8b962d2 2024-11-08T14:53:00 Parse function parameters into TPublicType Parse function parameters into TPublicType instead of TType. TType holds the type info, TPublicType holds the type specification info. This helps in moving the TType::isStructSpecifier into the AST nodes, away from the type system which it is not part of. Removes duplicated code where unnamed unsized arrays would cause different error message than named unsized arrays. Bug: angleproject:377330017 Change-Id: I102b9e87823a545f7e64f971aafbdcd313a542fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6000009 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Kimmo Kinnunen 4f4062ae 2024-11-08T10:18:02 Add support for running the parser generation on Mac For cloud storage, uses new bucket angle-flex-bison-mac for clarity, the names Linux and Mac clash. The lexer diffs seem to be due to formatter changes after the last generation of tjhe lexer. The diffs repro on Linux too. Lexer produces too hard to format source or diffs, and one hunk is left unformatted the first time. Add a workaround. Bug: angleproject:377941128 Change-Id: Id9d8f9a5c4a169955ccd8cd9cb3d632fbb339d28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6000005 Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll ceb8f1ac 2024-11-12T10:01:51 Roll SwiftShader from 76855a9baecc to d5c428477411 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/76855a9baecc..d5c428477411 2024-11-11 swiftshader.regress@gmail.com Regres: Update test lists @ 76855a9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Id19932286715bef828f5348651f28449ed0e52fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6014403 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 13f74e25 2024-11-12T10:01:56 Roll vulkan-deps from a2dfb2276ea5 to d1b8acb8cd01 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a2dfb2276ea5..d1b8acb8cd01 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9c644fcb5b9a1a9c975c50a790fd14c5451292b0..cb9a9d375dfde6477c14a4f3de9e320134d37447 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9117e042b93d4ff08d2406542708170f77aaa2a3..384d527ebb7578b5a8d69fb05f41c5aa9a363115 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/b0177a972b8d47e823a4500cf88df88a8c27add7..dbc663dcf28c5bd0bc2e7374e04e5127c0590302 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6cde840752a4510dfaa45de753b0be0694bc8c4b..62da7221c04e85e4c0bba0bc3f748cfaab55b6fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Id00dd08bd46ec3899520c0d49119db37dd82d905 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6013185 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 0d02f857 2024-11-07T09:32:28 Test SeparateDeclarations This makes it easier to fix issues with SeparateDeclarations Bug: angleproject:377330017 Change-Id: I53b9ca06971e0272563b6b3c752e0438c5802193 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6000533 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll c9407fec 2024-11-12T07:00:51 Roll Chromium from dcfc04e3c072 to 75279b66ac13 (575 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dcfc04e3c072..75279b66ac13 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/827e4e2f1e..8a810c637f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c448863360..319e286ea3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5a79ab5495..af142f1e69 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1063637350..41d43a2a22 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8ba0a768d6..cec7f47835 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/ccaf1e62d0..ca74a72e2b * third_party/r8/cipd: uYapBJQiyZps8iko9FUxKUIPKRvOfk4a3umRDg9TpdgC..6tS5W0W6vy5TPDxAc-wTObNng6QBVt7cQr3lazvrbpEC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/05cdff4728..4bd500b6f2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/644714c582..e7abceab37 * tools/skia_goldctl/linux: IlHPGzbUfx7oVzokTZJFxwi8WlNeBa4rBMtyFdiZgt4C..AiY7CO223oVpSMe9b7SwHVhQrF-ijgHEDzjsAV8SUKoC * tools/skia_goldctl/mac_amd64: L7lW1QzG1t7Sx50nS77H6FJxV7HyorteX0aL7QiRd1AC..aWw1JVWpKckecy3rBuN-5Y_osHIckC0ganu7xQ28f4UC * tools/skia_goldctl/mac_arm64: OTCCrMReyAqtbtGf3MMr15PrWMvHQNwZ7tt-CGp64JUC..WnSB4H9RkKT6MKFpLZ9yfWPnBUeECncOVa3XuRnyTEEC * tools/skia_goldctl/win: 9_wlbFkVOPWD2yCsq4B7K45Wd8UAGtlKOPrZ3_iWDJkC..EK_tQRk4h7ikvzyk5kFX_pkGw3gjHkP4QPmEjN8D54EC No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I896ddabb33922eb5d77a13d8d0391bd2011f1fb2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6014315 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu e5619a5c 2024-10-15T18:27:00 Use EGL sync global lock for all EGL*sync entrypoint calls To free EGL sync operations from waiting for other EGL calls to finish, we use a separate global lock for EGL*sync entrypoints. Below angle::SimpleMutex are added to protect resources that may have race condition due to being accessed by EGL*sync calls and non EGL*sync calls at the same time: 1. Display::mContextMapMutex that protects Display::mState.contextMap 2. static angle::base::NoDestructor<angle::SimpleMutex> anglePlatformDisplayMapMutex that protects static angle::base::NoDestructor<ANGLEPlatformDisplayMap> displays 3. static angle::base::NoDestructor<angle::SimpleMutex> devicePlatformDisplayMapMutex that protects static angle::base::NoDestructor<DevicePlatformDisplayMap> displays EGL_Terminate() entry point takes both global lock and global egl sync lock. This is to protect Display::mSyncMap, Display::mSyncPools, and Display::mSyncHandleAllocator being get cleared by thread 1 calling eglTerminate, while they are still accessed by thread 2 through a call such as eglCreateSync. So that we won't have thread 2 finish validating the sync object with syncID exists in Display::mSyncMap, but then find the mSyncMap.find(syncID) returns a nullptr due to the mSyncMap is cleared by thread 1. Same applies to EGL_LabelObjectKHR(), EGL_ReleaseThread(), ThreadCleanupCallback(). EGL_Initialize() writes to Display::mInitialized. This is read by EGL Sync API validation functions. EGL_Initialize() also takes both global lock and global sync lock to prevent race conditions between EGL_Initialize() and EGL Sync APIs. When ANGLE_CAPTURE_ENABLED is enabled, fall back to global lock, as the CaptureEGLCallToFrameCapture() touches many resources (e.g. mMaxAccessedResourceIDs, mFrameCalls) that could lead to race conditions without a global lock. Bug: b/362604439 Change-Id: Ic0d54a4cd66743bcd0f48f41f247dd223cff2f5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5933570 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 1c70fb79 2024-11-11T10:54:26 Fix dependency metadata invalid date warnings According to the latest third-party dependency metadata template: https://source.chromium.org/chromium/chromium/src/+/main:third_party/README.chromium.template, Date field is OPTIONAL if Version or Revision is supplied. If Date field is supplied, it needs to be in the format of YYYY-MM-DD. Since the Revision field is supplied, we can remove the N/A Date field. Bug: chromium:378273799 Change-Id: I30af7f462f0c53d0bbdb65a94f38218cb61e597f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6013040 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxin Hu f0d8a820 2024-11-11T11:35:24 Fix dependency metadata invalid date warnings According to the latest third-party dependency metadata template: https://source.chromium.org/chromium/chromium/src/+/main:third_party/README.chromium.template, Date field is OPTIONAL if Version or Revision is supplied. If Date field is supplied, it needs to be in the format of YYYY-MM-DD. Since the Revision field is supplied, we can remove the N/A Date field. Bug: chromium:378273779 Change-Id: I58b5699fed8cbab2d2bf6d0662dd4173eaa3e18f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6013366 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 1f82ca25 2024-11-08T12:19:32 Enable KHR-NoContext* and KHR-Single* tests on Linux Nvidia Bug: angleproject:40644911 Change-Id: I9a37aa742cc8af237d653535e51439b899757aaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6005396 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Austin Annestrand f198e807 2024-10-16T17:47:17 CL/VK: Serialize cmds when queue profiling enabled When queue profiling is enabled by user (opt-in) we should serialize/finish each cmd. Bug: angleproject:377942756 Change-Id: I7809df073c0a6de0e4d5338bec2fa2032ebc1577 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6003807 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Austin Annestrand ac41a84a 2024-10-10T17:35:20 CL/VK: Fix reflection parsing out-of-order cases Some clspv generated binaries cause the SPIR-V Tools parser to parse reflection instructions out-of-order (with respect to what we see in disassembler dump). This fix addresses kernel and kernel args so that order does not matter anymore. Bug: angleproject:377941117 Change-Id: I75da428b6f0a9f155f3faf5db7a0408485d4ebdc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6003806 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Austin Annestrand a4172290 2024-10-08T13:20:40 CL/VK: Initial impl for migrateMemObjects Defer migration handling in multi-device setups. Allow API to return error-free on 1 device cases (nop) for now. Bug: angleproject:377942759 Change-Id: I9bcc238ad4d2965e1281a99ec2782e8cfe6c05a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6003805 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Austin Annestrand 1071079a 2024-10-23T17:32:37 CL/VK: Fix frontend cl_mem_flags default access Additionally, if neither of these flags are specified: - CL_MEM_READ_WRITE - CL_MEM_READ_ONLY - CL_MEM_WRITE_WRITE Then we need to bitwise OR the default kernel access flag (according to spec): CL_MEM_READ_WRITE Bug: angleproject:377942757 Change-Id: I5decd05096a834469fdb6bca941284a400b2c69c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6003804 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Austin Annestrand 152f8035 2024-10-29T14:14:03 CL/VK: Fix missing default device on contextFromType Bug: angleproject:377941119 Change-Id: Ia75184233a5b0b422425626cbce46a2105b08249 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6003463 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand de287909 2024-08-30T18:38:40 CL/VK: Generalize host transfer sync utility Rework host transfer sync utility to handle multiple non-blocking enqueue transfer ops for buffer/image reads. Bug: angleproject:377545840 Change-Id: Ic382162ded15cb15c900baf724e02592bfd846c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6001611 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Kimmo Kinnunen efcb94ab 2024-11-06T15:55:02 Output the type of constant union Output the type of the constant union node in OutputTree output. This makes it easier to understand typing bugs related to the constant union. Adds a node nesting level for constant unions. This makes it easier to understand consecutive constant unions. Bug: angleproject:377330017 Change-Id: Ia83072b78c4d1713f839fd136692b254f6d2c517 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6000532 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Shahbaz Youssefi e3011d96 2024-11-08T16:17:07 Translator: Optimize size calculation for variable arrays Bug: angleproject:373924024 Change-Id: Id3a8b844b8274c19c0c2c833842fb8b501f50174 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6004338 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen 6359ec11 2024-11-11T13:24:35 Metal: Avoid leaking library and binary sources Fix leak of dispatch_data during binary load. The dispatch object was not released. Dispatch objects are Obj-C objects, so hold with AutoObjCPtr. Fix leak of MTLLibrary objects when creating the objects. The method newLibraryWithData returns +1 due to being "new" type method. This ref must be adopted. Avoid using autoreleased objects, use AutoObjCPtr. Some leaks regressed in c5ab1cebccaab0f8de466e5f797faa3d5a84bea5. Bug: angleproject:351165323 Change-Id: If23859fbddd21693d923f66f6fb015eed494f06e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6011208 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll ce13a00a 2024-11-11T10:01:58 Roll vulkan-deps from 12e843b4aad1 to a2dfb2276ea5 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/12e843b4aad1..a2dfb2276ea5 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/76cc41d26f6902de543773023611e40fbcdde58b..9c644fcb5b9a1a9c975c50a790fd14c5451292b0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/1cf0cede5f779a1f9bca38ad5ad632c7d50b3aad..6cde840752a4510dfaa45de753b0be0694bc8c4b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I9802c2d8158f93e435f04c25d1cce304783e28b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6007531 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 65288796 2024-11-11T07:01:24 Roll Chromium from 4201d3dd229a to dcfc04e3c072 (845 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4201d3dd229a..dcfc04e3c072 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/83dc15583b..827e4e2f1e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e47bfb0661..c448863360 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e9b2687111..5a79ab5495 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/46ade108f8..1063637350 * third_party/fuchsia-sdk/sdk: version:25.20241102.1.1..version:25.20241109.3.1 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/3fdba6f550..8ba0a768d6 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/93a837d836..5b01ea4a6f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/846cb08622..ccaf1e62d0 * third_party/r8/cipd: Vz8vXNhg5R5IAETlzCdV1ZZTBHqr108_RhW0meOJXTcC..uYapBJQiyZps8iko9FUxKUIPKRvOfk4a3umRDg9TpdgC * third_party/siso/cipd: git_revision:f0f43ce899b4da811f906ab3557c9b4b5418769b..git_revision:aa31236f9e208039b6196cbae4318d56d4c30e3d * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c656cea22c..05cdff4728 * tools/luci-go: git_revision:aa31236f9e208039b6196cbae4318d56d4c30e3d..git_revision:a52658ecc54d0fa4ad0065918588c890982634b2 * tools/luci-go: git_revision:aa31236f9e208039b6196cbae4318d56d4c30e3d..git_revision:a52658ecc54d0fa4ad0065918588c890982634b2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/37d1642b0d..45239f8c24 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9c9896ada1..644714c582 * tools/skia_goldctl/linux: Vd2g1IexnjJOyeYJEnBauprtDO72lnM7KoV7KH8_pyMC..IlHPGzbUfx7oVzokTZJFxwi8WlNeBa4rBMtyFdiZgt4C * tools/skia_goldctl/mac_amd64: 2lbVntmxhc-PqX6iK1PNyXMBxSNA36UXTfDQKNkxsFcC..L7lW1QzG1t7Sx50nS77H6FJxV7HyorteX0aL7QiRd1AC * tools/skia_goldctl/mac_arm64: 8Mdyp7IxqQT8bs3V_9W9nMgt0ZtRY7FpJuSYk6aoK68C..OTCCrMReyAqtbtGf3MMr15PrWMvHQNwZ7tt-CGp64JUC * tools/skia_goldctl/win: NE6rhxS2e-F58MAathE-L_OuUVdzbPXFhze5SlpUIpQC..9_wlbFkVOPWD2yCsq4B7K45Wd8UAGtlKOPrZ3_iWDJkC No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I98577146e196c790e5cdb36c02eacbf8fc7c72fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6010466 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 7fea539c 2024-10-23T11:40:51 Vulkan: Remove extra non-conformant flag checks It may be possible to remove the flag check and simply rely on the checks performed in CanSupportGLES32() to determine support for ES 3.2. The non-conformant flag can remain utilized for certain features until the relevant issues are resolved and this flag is no longer needed. * Removed the checks from getMaxConformantESVersion(). * Removed the flag check in Renderer::getMaxSupportedESVersion(). * Added exception to the blend extension when using the non-conformant flag for Win/Intel. * Skipped the related tests on this platform that now fail. * Added a new feature flag to force-enable ES 3.2 on certain platforms for testing. * exposeES32ForTesting * If the bots are updated to support ES 3.2, it can be removed from using this flag. * Skipped some VVL errors when the flag is enabled. * Skipped end2end ES 3.2 tests on SwS. * Skipped some dEQP tests on P4 and SwS that would use ES 3.2 features that are not available on those platforms. Bug: b/374841339 Bug: b/376899587 Change-Id: Ifd405457ab8bf2076eb8fb5c92c5316f4d520595 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5958147 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Ho Cheung d30d81d0 2024-11-06T16:08:28 [code health] Remove underscores from test names in ANGLE (1/N) In the GoogleTest framework, underscores are not allowed. [1] ANGLE has underscores in many test names, and those should be changed. At the same time, add a comment to a test case according to the requirements of the Presubmit check. ```` *************** ANGLE requires a comment describing what a test does. *************** ```` [1] https://github.com/google/googletest/blob/main/docs/faq.md#why-should-test-suite-names-and-test-names-not-contain-underscore Bug: angleproject:377543127 Change-Id: I90e634bd985ca518eca43e2c919a3a8bca91a55b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5997835 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Ho Cheung <hocheung@chromium.org>
Igor Nazarov 11d73f1d 2024-11-04T20:31:57 Revert "spirv::Print without ANGLE_ENABLE_ASSERTS -> compile error" This reverts commit be9e63ad090dc4b86eae08ad8f9f4c9f1a18a6a4. Reason for revert is to fix build error in "CLProgramVk.cpp" if build with `dcheck_always_on = false`. Since https://crrev.com/c/5898609, `spirv::Print()` is now always defined, so no liker error if `ANGLE_ENABLE_ASSERTS` is not defined. Bug: angleproject:370557215 Change-Id: I983b57987eb63f601a75e90646c24b9cd16170a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6003012 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuxin Hu 094a0b11 2024-11-07T17:45:50 Skip KHR-GLES31.core.tessellation_shader.single.primitive* on win Bug: angleproject:377993076 Change-Id: I7d7d99b87b51911bbb3046b4e7353afb18060d5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6003811 Commit-Queue: Roman Lavrov <romanl@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
angle-autoroll a0866346 2024-11-08T10:01:06 Roll vulkan-deps from 12b75c58255f to 12e843b4aad1 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/12b75c58255f..12e843b4aad1 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/58b4fcad7be86c8f60baae3cfb2fb45096b437e8..1cf0cede5f779a1f9bca38ad5ad632c7d50b3aad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I76ae965005287116aa9f444d4f7e8295c3f98d38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6004057 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fec8786e 2024-11-08T07:59:09 Roll Chromium from 369ac471ea04 to 4201d3dd229a (705 revisions) https://chromium.googlesource.com/chromium/src.git/+log/369ac471ea04..4201d3dd229a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0fc767f93a..83dc15583b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cb21bddb7a..e47bfb0661 * third_party/android_build_tools/error_prone/cipd: P4ar2IVWgipWzMglFQGb45LE-VKychgjOUmbssZK7qcC..DBKfaigj6AuTYPdN1_6jkOlQUuJa1szDRIMvHbtZrD8C * third_party/android_build_tools/lint/cipd: ZtEs7jgil5yykPwZynLNdQuisSTtHKp4uUi7aZHTc-YC..vBoRPSPyoHi8GYvjtidLlKAtqp5a-2CaHgpEZb16dAoC * third_party/android_build_tools/manifest_merger/cipd: -Yqd1ysKh8HXbxIODxAAUrZ6hSS9NCVF1fceEtPMCPsC..1gDDnuAjB1-mlxlnLFAfx4h9f_hG3lEIIbwyYr86i1wC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/31beb497fc..e9b2687111 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0ff74cfe9f..46ade108f8 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/171c504c4b..3fdba6f550 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c3b4ce8edd..93a837d836 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/194ae301ad..846cb08622 * third_party/r8/cipd: YpJxENNZqq3mMt24rEGk3QC1-tzRwn6Tu5HD2vsxzGIC..Vz8vXNhg5R5IAETlzCdV1ZZTBHqr108_RhW0meOJXTcC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/3850115d14..9b898fa7cc * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/830220aa08..c656cea22c * tools/luci-go: git_revision:17620695ace472852acc003b74bf240c94a07cbc..git_revision:aa31236f9e208039b6196cbae4318d56d4c30e3d * tools/luci-go: git_revision:17620695ace472852acc003b74bf240c94a07cbc..git_revision:aa31236f9e208039b6196cbae4318d56d4c30e3d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8fe44e5d21..37d1642b0d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bd85c54890..9c9896ada1 * tools/skia_goldctl/linux: C0CwX5cN6vEo8BX2QpfBB0hMQ6Yg_BpTgtW6kED6a0QC..Vd2g1IexnjJOyeYJEnBauprtDO72lnM7KoV7KH8_pyMC * tools/skia_goldctl/mac_amd64: xmAykgoYIP74ev2nA3hQCJv5t-THH1oVqgTA8O4Sfu4C..2lbVntmxhc-PqX6iK1PNyXMBxSNA36UXTfDQKNkxsFcC * tools/skia_goldctl/mac_arm64: B_QRS0ZdBtI8oL8MDGOn6KQaMsdqpc-nV2lKWRGlOKAC..8Mdyp7IxqQT8bs3V_9W9nMgt0ZtRY7FpJuSYk6aoK68C * tools/skia_goldctl/win: 2J10fvw0AgR3Dpcg6wIiMTbhXIqL2J_QDOSXlOTBfpwC..NE6rhxS2e-F58MAathE-L_OuUVdzbPXFhze5SlpUIpQC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I218871cb6d9cfadc56558fd751d7bd17cd49b2cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6003821 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 2a61126b 2024-10-30T14:42:08 Remove GLES 3.2 tests from swiftshader backend GLES 3.2 is not supported with swiftshader backend. Remove the GLES 3.2 tests from swiftshader bots. Bug: b/374841339 Change-Id: I5ab51c139550ee3ecec4e06292bcfdd04f403ff5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5980409 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 2c7e9830 2024-11-04T10:05:25 restricted_trace_perf: Setup and wrapper support This CL adds support for installing and setting up traces. Also allows running via the wrapper in http://crrev/c/5985570 With this change, if you run without using the wrapper, you must provide the --build-dir flag. It allows running the script from any directory: --build-dir ../../../out/Android Bug: b/376300037 Change-Id: I2259ee120b2af5e1917a2a57a27fa3dcfca761e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5983806 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov bdebee8c 2024-10-29T17:08:11 Tests: add repro for running out of outside RP serials Bug: b/375661776 Change-Id: I2cd82710bdf5b00a6165ddad6ef21f30150aa5bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5977123 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 750d9a24 2024-11-06T17:28:19 Skip SourceAHBTarget2DGenerateMipmap* tests on S22 There is a vulkan driver bug on S22 device: https://chromium-review.googlesource.com/c/angle/angle/+/5966623/comments/44b72fb9_3ba112c5, causing ImageTestES3.SourceAHBTarget2DGenerateMipmap* to fail. Skip these tests on S22 until the vulkan driver of the device is updated. Bug: angleproject:40644776 Change-Id: Id5e68aa4ad8f2172c5cdda9adb26af60da87b905 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6001577 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov d01f5101 2024-11-01T18:45:55 Tests: add wrappers for restricted_trace scripts Example use: out/Android/restricted_trace_gold_tests \ --bypass-skia-gold-functionality \ --filter=dota_underlords:dragon_raja out/Android/restricted_trace_perf --flags Bug: b/376300037 Change-Id: Ic3e8cb241af25a770f5d1888538d13482f877b6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5985570 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 6cda99d8 2024-11-07T09:53:01 Tests: fix run_angle_android_test.py and trace bundle The output_directory arg is provided when invoked by the wrapper, but not when running with run_angle_android_test.py, in which case cwd has been historically used such as: cd out/AndroidPerformance; ../../src/tests/run_angle_android_test.py ... Move the import added in https://crrev.com/c/5985232, as 1) it now imports protobufs which is not included with python3 and requires an additional package 2) build/ is excluded from trace bundles where running traces with the Chromium runner isn't supported. Bug: b/377875190 Change-Id: Ie092dc6382e74ac7413a42acffaf507c05b73514 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6002496 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 7ac10ebe 2024-11-07T10:01:42 Roll vulkan-deps from 155bbe2e1429 to 12b75c58255f (31 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/155bbe2e1429..12b75c58255f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d81aeef9f82050bd5940ce1c475d8316ad41d747..76cc41d26f6902de543773023611e40fbcdde58b https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/cb6b2c32dbfc3257c1e9142a116fe9ee3d9b80a2..996c728cf7dcfb29845cfa15222822318f047810 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9aaa2601400a29ce39ce1111aa9f790e5c9d4c1b..9117e042b93d4ff08d2406542708170f77aaa2a3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/9276d73f29651c92402f0f0389108d69bb51b9ca..b0177a972b8d47e823a4500cf88df88a8c27add7 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/e94085e2167e33b6b18474da24ff18f46bc56976..15f2de809304aba619ee327f3273425418ca83de https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/9123b8c04b378c1b81899314e3060a80f255a24b..87ab6b39a97d084a2ef27db85e3cbaf5d2622a09 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/7d88badaa519c125a2a7a4c041634acb9baba52d..58b4fcad7be86c8f60baae3cfb2fb45096b437e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Ie5f103164dc63689b681f9102a731254a5480ed5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6001579 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a04cedac 2024-11-07T07:00:09 Roll Chromium from aba74d57387d to 369ac471ea04 (477 revisions) https://chromium.googlesource.com/chromium/src.git/+log/aba74d57387d..369ac471ea04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5534012c41..0fc767f93a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9958df0c62..cb21bddb7a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03d405a15f..0ff74cfe9f * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b1a4d63356..171c504c4b * third_party/r8/cipd: YyLscJSIeKgVII-9Cs-Apvzq0aP3NL1pFHvlh4ZXDNwC..YpJxENNZqq3mMt24rEGk3QC1-tzRwn6Tu5HD2vsxzGIC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/4f4782e7c7..3850115d14 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e0c1633a7a..830220aa08 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a4a07db8ee..8fe44e5d21 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ee092511cb..bd85c54890 * tools/skia_goldctl/linux: ab2tOr3TlFy5RVGJNCDNzx7GN0z5CmqjNjihGpMiJuoC..C0CwX5cN6vEo8BX2QpfBB0hMQ6Yg_BpTgtW6kED6a0QC * tools/skia_goldctl/mac_amd64: x7CeAkfbwULBde4pP6MdPN62gDQ-9F310_BaLecUP_4C..xmAykgoYIP74ev2nA3hQCJv5t-THH1oVqgTA8O4Sfu4C * tools/skia_goldctl/mac_arm64: x7HadrOySXOgPFJ2HqfBPetsWzNrSqufiw_1TqdrbZkC..B_QRS0ZdBtI8oL8MDGOn6KQaMsdqpc-nV2lKWRGlOKAC * tools/skia_goldctl/win: UsIbI7R1j3k4UfymAMNHHW2qV_tFb1pC9FjE8d7cpoUC..2J10fvw0AgR3Dpcg6wIiMTbhXIqL2J_QDOSXlOTBfpwC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I8019c49a937012c452e89ecabacf27e8652a4a43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6001578 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 026ba848 2024-11-06T16:14:21 Manual roll Chromium from 64d6e30da907 to aba74d57387d (848 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/64d6e30da907..aba74d57387d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4e8de165cd..5534012c41 * buildtools/reclient: re_client_version:0.170.0.08051991-gomaip..re_client_version:0.171.0.1869ad5c-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ce678c02c7..9958df0c62 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/78991980f5..1ffd70268e * third_party/android_build_tools/error_prone/cipd: XiEOJCA7q-Q8YABdSSaYOW06nR1GvKOoSAxrsNzxEBYC..P4ar2IVWgipWzMglFQGb45LE-VKychgjOUmbssZK7qcC * third_party/android_build_tools/lint/cipd: hSFon_JjQvR4BuNkKM_aUTmw20ucssOQ2oFB2eXiw2EC..ZtEs7jgil5yykPwZynLNdQuisSTtHKp4uUi7aZHTc-YC * third_party/android_build_tools/manifest_merger/cipd: WkTffFZv5M3W9L_yy3Z8ZQLMagWNQgAN_QmLR8BzCHEC..-Yqd1ysKh8HXbxIODxAAUrZ6hSS9NCVF1fceEtPMCPsC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3a454956bc..31beb497fc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37c0cf9100..03d405a15f * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/53f8886e48..b1a4d63356 * third_party/r8/d8/cipd: zNYp2KVrHI9KDsLQCdJIFzXTvkqx3Dav9o5vR1UlMxQC..MnTG4zEzUB1GchkIsnkYCRziw_tkkWGJ7v_T6NUJHksC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/1d14a955d9..4f4782e7c7 * tools/luci-go: git_revision:f0f43ce899b4da811f906ab3557c9b4b5418769b..git_revision:17620695ace472852acc003b74bf240c94a07cbc * tools/luci-go: git_revision:f0f43ce899b4da811f906ab3557c9b4b5418769b..git_revision:17620695ace472852acc003b74bf240c94a07cbc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/751a4f4982..ee092511cb * tools/skia_goldctl/linux: Xe04Orb62kNw7G2RahBXWQgnaFaSVnePM49IX9xxOZQC..ab2tOr3TlFy5RVGJNCDNzx7GN0z5CmqjNjihGpMiJuoC * tools/skia_goldctl/mac_amd64: yW207_i1jDYnbWVrWjhE71mVOkcoovgS05scBJCeJzMC..x7CeAkfbwULBde4pP6MdPN62gDQ-9F310_BaLecUP_4C * tools/skia_goldctl/mac_arm64: 7AVueq6vBSRyrlg5DE8fULb1Nv8b8LnSgfLkUh_t9uUC..x7HadrOySXOgPFJ2HqfBPetsWzNrSqufiw_1TqdrbZkC * tools/skia_goldctl/win: 4Tr5RFJLbgif5NawL-lkD1cSxwBi2-xjqufcRBMG-4kC..UsIbI7R1j3k4UfymAMNHHW2qV_tFb1pC9FjE8d7cpoUC No update to Clang. Bug: None Tbr: yuxinhu@google.com,ynovikov@google.com Change-Id: Ifcd46248190e10bf1c88a4796ffaf0cc954f40d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6000614 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi f44427b5 2024-11-05T15:18:59 Vulkan: Fix MSAA glReadPixels into PBOs The temporary image used to resolve the MSAA framebuffer during glReadPixels did not have the SAMPLED usage bit. Additionally, the image was supposed to be garbage collected afterwards but ImageHelper's release() function was accidentally immediately destroy()ing it. This was not an issue with blocking glReadPixels paths, because the command buffer was immediately flushed and the GPU work was waited on before the image was destroyed in RendererScoped's destructor. Bug: b/377437834 Change-Id: I1dca47172d6f363277059a848fe9446ac2a872d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5995530 Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll d399841a 2024-11-06T10:01:52 Roll SwiftShader from 1495532f997f to 76855a9baecc (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/1495532f997f..76855a9baecc 2024-11-05 swiftshader.regress@gmail.com Regres: Update test lists @ 1495532f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Idf15cd2ed21d3b4c026cfdbbbd77386dc32380fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5997998 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov cc2edfd1 2024-11-05T15:37:21 Fix getPerfMonitorCounterData maxResults, skip AsyncCommandQueue test Skips TextureDataInLoopManyTimes on SwS AsyncCommandQueue. Add more debug info to the test although without the AsyncCommandQueue variant we likely won't be see flakes. Bug: angleproject:377503738 Change-Id: I372531451c280b04ffed84b020463657440fca08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5995531 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com>
Gowtham Tammana 644b91f7 2024-02-29T16:37:37 CL/Vulkan: Implement buffer map/unmap Implement the buffer map, for now mapping is performed at the call site. Bug: angleproject:42267077 Change-Id: I16929920be8a49863de514b541ff0a57b6ac4453 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5971713 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Lichen Liu d4420489 2024-10-25T08:53:17 Add check for iOS simulator when initializing caps in metal On Intel-arch MacBook, the system API [supportsFamily:MTLGPUFamilyApple3] returns false on the iOS simulator, causing maxVertexOutputComponents to be set to 60, which is below than the required value of 64, resulting in WebGL2 initialization failure on chromium iOS. Add a TARGET_OS_SIMULATOR check to ensure the values of caps can be set correctly in the siumulator environment. Bug: angleproject:375244081 Change-Id: Iafc44a2aa62130b09127bbec7ea6940506a4165c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5961039 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 6df20e5f 2024-08-21T13:29:36 CL/VK: Add missing HostPtr-BufferVk sync on unmap Missing extra copy/sync for enqueueUnmapMemObject routine for USE_HOST_PTR scenario. Bug: angleproject:377366930 Change-Id: Ifcb0ed58beabf5870e00ed47b36cfd08767eba70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5990104 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 2a569b2b 2024-11-04T11:41:29 Vulkan: Document that hex can be viewed with spirv-dis Since https://github.com/KhronosGroup/SPIRV-Tools/pull/5870, spirv-dis is able to disassemble SPIR-V given a hex stream. This change indicates this when retrieving shader debug info (a WebGL extension). Bug: angleproject:42266948 Change-Id: Ifab4668d6608093700d3e03ddd7ea675fd2bcf42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5988173 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 17a01469 2024-10-26T06:07:31 Vulkan: Bugfix TextureVk::generateMipmap Add support for generating mipmaps of textures that are EGLImage texture targets with colorspace overrides Bug: angleproject:40644776 Tests: ImageTestES3.SourceAHBTarget2DGenerateMipmap* Change-Id: I9b4ff802f4118a42d54dc8d80ab30e2f9958bfee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5966623 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Mohan Maiya e2cd9082 2024-11-05T04:07:17 Vulkan: Bugfix in setCurrentImageLayout Make sure to update mLastNonShaderReadOnlyLayout and mCurrentShaderReadStageMask when updating the current layout. Bug: angleproject:40644776 Change-Id: Ie8652099a0d4caca9f9aea5bac38256a513b08e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5992020 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 5a9f361c 2024-11-05T08:39:33 Roll Chromium from 69b5e685119d to 64d6e30da907 (601 revisions) https://chromium.googlesource.com/chromium/src.git/+log/69b5e685119d..64d6e30da907 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/679ccfd7d2..4e8de165cd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/10d0c29aa1..ce678c02c7 * third_party/android_build_tools/error_prone/cipd: O1OVfpqbI-kjqiCSF27xOQ2CmfQMGSY-Lq4qH671sdMC..XiEOJCA7q-Q8YABdSSaYOW06nR1GvKOoSAxrsNzxEBYC * third_party/android_build_tools/lint/cipd: 9quVbgwnFSKuZJ3QNXnfzy0iokvyHFOL1Q7qkgafP1MC..hSFon_JjQvR4BuNkKM_aUTmw20ucssOQ2oFB2eXiw2EC * third_party/android_build_tools/manifest_merger/cipd: rdroZtdhMUv8gACwfRmE_Gycwkb8DTSDjw-PpVSx1nIC..WkTffFZv5M3W9L_yy3Z8ZQLMagWNQgAN_QmLR8BzCHEC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/39b2e4efd6..37c0cf9100 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/191356bd99..53f8886e48 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/bf062897f1..c3b4ce8edd * third_party/siso/cipd: git_revision:bf523d95598ccdc9003361bf8a4142414af474f1..git_revision:f0f43ce899b4da811f906ab3557c9b4b5418769b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/6a846861ae..1d14a955d9 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c7e4aee0f5..e0c1633a7a * tools/luci-go: git_revision:4797ba66f62a28b1bedf6790134a0cc6d1fe89ea..git_revision:f0f43ce899b4da811f906ab3557c9b4b5418769b * tools/luci-go: git_revision:4797ba66f62a28b1bedf6790134a0cc6d1fe89ea..git_revision:f0f43ce899b4da811f906ab3557c9b4b5418769b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a4a0ab9ea5..751a4f4982 * tools/skia_goldctl/linux: TFJRb4k3TwngoVhErGjZ2UWUBCpvMrPlLBPpA0vhw_AC..Xe04Orb62kNw7G2RahBXWQgnaFaSVnePM49IX9xxOZQC * tools/skia_goldctl/mac_amd64: Qdi4Rk6BKCq4Nh1ayE1--3i1ZGo5RdOkCMcD3NC9StAC..yW207_i1jDYnbWVrWjhE71mVOkcoovgS05scBJCeJzMC * tools/skia_goldctl/mac_arm64: 9hJI5SrV6oIvn3p0aspVvHaI3MYOB2C_T9v3epRey60C..7AVueq6vBSRyrlg5DE8fULb1Nv8b8LnSgfLkUh_t9uUC * tools/skia_goldctl/win: gLMz4_WFdf2HxxnlVjNztw4Dcl1tfttWR1bHdsFxdssC..4Tr5RFJLbgif5NawL-lkD1cSxwBi2-xjqufcRBMG-4kC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ie03484a23118a7599486afb73383990a36eab690 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5993374 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gowtham Tammana 84a24a1e 2024-07-02T11:56:25 CL: Implement clone for kernel object clCloneKernel() can be used to make a shallow copy of a kernel object. The returned object is an exact copy of the source kernel, with latest calls to arguments sets applied to the kernel. Implement a clone version at the front-end with replicating the `clSetKernelArg` called on the source kernel. The `clSetKernelArgsSVMPointer` and `clSetKernelExecInfo` are ignored as they are currently unsupported. Bug: angleproject:376023087 Change-Id: I2e21931d9ff799e35b153cffe91fd4a2adbbf88d Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5971715 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana 8dae26c6 2024-06-26T11:35:24 CL: Add missing validation checks -1- Check on device enqueue support Add a check for the device enqueue support before proceeding with the device enqueue info queries. -2- Validate the non uniform work groups The spec requires reporting CL_INVALID_WORK_GROUP_SIZE when non-uniform workgroups are not supported and supplied work sizes dont evenly distribute the work items. Adding a check in the validation. -3- Check for alignment on sub-buffer creation The spec requires the sub-buffer origin to be aligned to CL_DEVICE_MEM_BASE_ADDR_ALIGN value. Check for this in validation layer. Bug: angleproject:42267011 Change-Id: I9dc086fea16b200cc05c0fca29e3608403099a2c Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5975419 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 1daf17b5 2024-11-04T11:05:46 Tests: restore angle_end2end_tests --help on Android https://crrev.com/c/5985232 added support for choosing the test runner, but that inadvertently changed behavior with --help (or with certain flags). This CL restores that behavior. parse_known_args() exits the process by default, so add manual --help handling. Bug: b/344849382 Change-Id: I87f197f90a161ec141a6e1f46ba81cfbf01a2fec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5987387 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 924f2079 2024-11-04T13:55:18 Manual roll Chromium from 601f829c4935 to 69b5e685119d (60 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/601f829c4935..69b5e685119d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/43a2115b4e..679ccfd7d2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cda399271a..10d0c29aa1 * third_party/turbine/cipd: YDjqj5VA9_8SsjmFf_gJG3tSTb6BdOLqQnr8SabZmFEC..1iVaPZ0ts_R6ymFUftgOKVE50dXSx6duVZEOP891WCMC No update to Clang. Bug: None Tbr: yuxinhu@google.com,ynovikov@google.com Change-Id: I434225a7b07653e005df9cdccbab7348618b15d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5987707 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 47fafdb9 2024-11-04T10:05:12 Disable tracegz (trace interpreter) by default, remove from CI Trace interpreter is incomplete and we've been punting on it. Can be re-enabled with angle_enable_tracegz=true in gn args. This avoids accidentally pulling trace sources into builds. Bug: b/376300037 Change-Id: Ib755fa9f57885216b02a481fd670a1bb0266f0db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5987382 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov e43d3591 2024-11-01T16:23:27 Tests: allow choosing Chromium/our test runner + screen checks Chromium test runner (build/android/test_runner.py) is currently the default runner for most suites. One exception is angle_trace_tests where we're always using our scripts instead (android_helper.py etc). We do that by setting android_test_runner_script to our runner for that angle_test instance. This CL supports setting android_test_runner_script to our script but then choose whether to run with the Chromium runner or android_helper depending on the command-line arg (--angle-test-runner) This CL also adds a check for the screen state which will be performed regardless of the runner. This is to have a fast and clean failure when the device wasn't properly initialized by the infra (see bug). The check is based on the output of `dumpsys deviceidle | grep mScreen` (this is the most generic check I found, I previously used nfc but that depends on nfc and turns out the output is device-dependent) This CL enables this mode for angle_end2end_tests. Bots will continue to run with Chromium runner as before (but with the added screen checks). Locally, we will now be able to switch to our scripts directly: out/Android/angle_end2end_tests \ --gtest_filter='*ClearTextureEXT2DMSStencil*' \ --angle-test-runner Now when running end2end tests locally (regardless of the runner) with a locked device screen, we'll see the following error right away instead of sporadic failures or stuckness during execution: Exception: Unexpected device screen state: ['mScreenOn=false', 'mScreenLocked=true']; expected: ['mScreenOn=true', 'mScreenLocked=false'] The plan is to enable this mode for all suites, after which the current local script run_angle_android_test.py will no longer be needed. Bug: b/344849382 Change-Id: I77e7733804ab37e2f3d26bf3574a52a9553e4274 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5985232 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 7ce8b268 2024-11-04T10:01:36 Roll vulkan-deps from a52547961655 to 155bbe2e1429 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a52547961655..155bbe2e1429 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/e5c1498afa1daa8cf3a48af7a74e3b7429afb05d..9aaa2601400a29ce39ce1111aa9f790e5c9d4c1b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/f2eb740f3f0340ad941e563484d5ba45a5ec6af0..cbcad3c0587dddc768d76641ea00f5c45ab5a278 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b8093e3a1854285cbd183fa98b410090889fa500..7d88badaa519c125a2a7a4c041634acb9baba52d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I44727ebef8f9161749620187f471daa9bb971846 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5987530 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d06410da 2024-11-04T09:04:56 Roll Chromium from d8c3950b24a5 to 601f829c4935 (447 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d8c3950b24a5..601f829c4935 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8faf4d87eb..cda399271a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/77ab8f9211..3a454956bc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b832657a0c..39b2e4efd6 * third_party/fuchsia-sdk/sdk: version:25.20241025.6.1..version:25.20241102.1.1 * tools/luci-go: git_revision:4a7755a0f40eb3aa20ff4dcecde6bab0f6a24889..git_revision:4797ba66f62a28b1bedf6790134a0cc6d1fe89ea * tools/luci-go: git_revision:4a7755a0f40eb3aa20ff4dcecde6bab0f6a24889..git_revision:4797ba66f62a28b1bedf6790134a0cc6d1fe89ea * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/715bc5a0af..a4a0ab9ea5 * tools/skia_goldctl/linux: VabgQkFnMfqcuiR6DAjGRzgo-flvZDQ3ZOqJSRnONWwC..TFJRb4k3TwngoVhErGjZ2UWUBCpvMrPlLBPpA0vhw_AC * tools/skia_goldctl/mac_amd64: 6LbtEUb4VFflDPP_gLkZm69GPz_kldTfr0GKZqTcY10C..Qdi4Rk6BKCq4Nh1ayE1--3i1ZGo5RdOkCMcD3NC9StAC * tools/skia_goldctl/mac_arm64: ZBwJMfIfaokP3eCIzjf9r2JF1lxyFoWutFyAIMJIkAkC..9hJI5SrV6oIvn3p0aspVvHaI3MYOB2C_T9v3epRey60C * tools/skia_goldctl/win: V37TmFdJ6NMKXBOncF_8W9vtnJJRfLQIVmoHmDsH4LkC..gLMz4_WFdf2HxxnlVjNztw4Dcl1tfttWR1bHdsFxdssC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ie2eb3f160f202beb95f92d3c9de3188f672207ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5986476 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen eccfec93 2024-11-01T11:49:11 Metal: gl_ClipDistance fails validation Failure is "Found child with two parents". Result from reusing gl_ClipDistance in: float gl_ClipDistance[8]; ClipDistance_0 = gl_ClipDistance[0]; ... Fix by creating new node for each symbol access. Bug: angleproject:376718272 Change-Id: I7a866a10e389cc25d0cff4e6f18ae9c70ab376e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5979781 Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Gowtham Tammana 7483897c 2024-10-01T17:23:37 CL/Vulkan: Add numeric versioning for extensions With extended versioning support, the version number of extensions need to be reported as well. Using the numeric versioning mode for adding supported extensions. Also, fix the version number for cl_khr_icd and cl_khr_extended_versioning extensions. Bug: angleproject:372085147 Change-Id: I7bf3157227f9579c69c351a63a88b92be7f07d71 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5916159 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana 9ce9e678 2024-04-16T10:07:02 CL/Vulkan: Set storage buffer usage for cl buffers clspv is setting all the buffer objects as storage buffers, so removing the distinction on the CL MEM flags for now. Bug: angleproject:365694588 Change-Id: I3bd65457d53a6a2fb5fd5c8f2a0b8c25094ed563 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5916158 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana 2f8ad9c1 2024-09-26T20:34:34 CL/Vulkan: Add support for sub-buffer creation Sub-buffer is setup to point to offset location of the parent buffer. The copy buffer interface is updated to account for copies from the same sub-buffer. Bug: angleproject:372157566 Change-Id: I668c7182a8c4c12e265115f1c28d9bfbfe562bb0 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5916156 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Rafay Khurram 3c1e98a3 2024-05-22T01:46:52 CL/Vulkan: Fix clEnqueueMapImage/clEnqueueUnmapMemObject * Updates slice_pitch and row_pitch parameters with relevant values according to the spec. * For mapping, image is copied to staging buffer, then copied to dynamically allocated array * For unmapping, the reverse is done with the array being freed Tests-Passing: OCLCTS.test_cl_copy_images 2D, test_cl_copy_images small_images 2D, test_cl_copy_images max_images 2D, test_cl_copy_images 3D, test_cl_copy_images small_images 3D, test_cl_copy_images max_images 3D, Bug: angleproject:42266936 Change-Id: I0cd778244832ce66e72a58a228ed889a9002171e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5961948 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rafay Khurram <r.khurram@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi bd9d0285 2024-10-26T01:12:23 Remove feature description / condition enums Since ANGLE no longer produces anything for these strings, Chromium no longer queries them and they can be removed. Bug: chromium:371512561 Change-Id: I921cbd91a3328df99b15262d31d52986d4a7b806 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5966697 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 5242386b 2024-11-01T20:29:53 Manual roll Chromium from 61c4298a5d2e to d8c3950b24a5 (286 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/chromium/src.git/+log/61c4298a5d2e..d8c3950b24a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a378269311..43a2115b4e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8aa2471595..8faf4d87eb * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c73dc115ba..b832657a0c * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/29d8a79ce5..0cbab48ca5 * third_party/r8/cipd: RzOonm113-m5_HZcKgMupfMghkDOTHWOJGYHjaaWfRIC..YyLscJSIeKgVII-9Cs-Apvzq0aP3NL1pFHvlh4ZXDNwC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/c9e8288d5f..6a846861ae * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c67de0cebb..715bc5a0af No update to Clang. Bug: None Tbr: romanl@google.com,syoussefi@google.com Change-Id: Ib7dc6f375c6ccc69dc3e38629157538b9392bf96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5985113 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 2b8d6bbe 2024-11-01T11:23:35 Vulkan: Use UpdateFullTexturesDescriptorSet when cache missed DescriptorSetDescBuilder::updateDescriptorSet() relies on the cache key to build descriptorSet. UpdateFullTexturesDescriptorSet() builds descriptorSet directly from state, it does not use cache key. Test shows UpdateFullTexturesDescriptorSet is much faster than updateActiveTexturesForCacheMiss and updateDescriptorSet pair. This CL removes updateActiveTexturesForCacheMiss() function and uses UpdateFullTexturesDescriptorSet for cache miss case. The timing code is added around the cache miss functions to measure the time. Old: asphalt_9 average 7,554 nanosec gl_driver2_off: 20,354 nanosec batman_telltale: 12,992 nanosec New: asphalt_9 average 916 nanosec gl_driver2_off: 1,839 nanosec batman_telltale: 3,437 nanosec Bug: angleproject:372268711 Change-Id: I176d67ed732c3fe3a18a079df7c4973aa926087a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5984893 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao fbe34df7 2024-10-29T16:19:29 Vulkan: More texture descriptorSet code cleanup Removed unused argument `pipelineType` from updateActiveTexturesForCacheMiss(). Removed unused argument `context` from getReadImageView() Rename getBufferViewAndRecordUse() to getBufferView() since there is no "record use" happening. Moved UpdateFullActiveTexturesDescriptorSet() function from vk_cache_utils.cpp to ProgramExecutableVk.cpp anonymous name space, since it is only used in this file. Bug: angleproject:372268711 Change-Id: Ib7240c1063f727fb52588234e79fba349f9aff9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5977481 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
kmx.io     mail     discord kmxgit v0.4.0