|
2be71410
|
2021-03-19T14:07:02
|
|
Handle inactive structure type varyings correctly
Correctly handle inactive varyings of structure type when collecting
transform feedback varyings. Previously, all varyings of structure type
were marked as active by mistake.
Bug: angleproject:5557
Test: TransformFeedbackTest.InactiveStructureVarying*
Change-Id: Ica1cbce5c551cdbb97999eeac59d09a961937615
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770680
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
570970f9
|
2021-03-19T13:43:35
|
|
Vulkan: Handle compilation error involving gl_InvocationID
We need to generate a compiler error only when the vertex index
of an output variable as an l-value, in a tessellation control shader,
is not the indentifier gl_InvocationID.
Bug: angleproject:5557
Tests: dEQP-GLES31.functional.tessellation.shader_input_output.barrier
Change-Id: Ica075b8d85916caa228f057b203ae81b27f65e2d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2758915
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
02acc5ee
|
2021-03-18T16:08:59
|
|
Vulkan: More cleanups to perf counters.
This refactors the pipeline type in the ContextVk class to also use
a packed enum map. It also expands the object perf counters to store
both a specific and cumulative version for use in different cases.
Bug: angleproject:5736
Change-Id: I6ff78e38065eb577f2b95b1d9c4f9cc31d7f325f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774184
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
ecbd870f
|
2021-03-21T22:54:24
|
|
Tests: Add Avakin Life - 3D Virtual World trace
Test: angle_perftest --gtest_filter="*avakin_life*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/183344915
Bug: angleproject:5779
Change-Id: Iaf2d8341055d5b7c6f3c8a7a7a1fb3d1399fabc5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776746
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
0380f115
|
2021-03-18T09:56:14
|
|
Skip ResizeWindow test on Linux.
ARM Linux doesn't support window surface resize.
Bug: angleproject:4453
Change-Id: Ia8631f5191c2b3ebd822766cc7f92275aa62dff3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2777578
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
7fe44a53
|
2021-03-20T09:39:09
|
|
Vulkan: Don't acquire new BufferHelper for external buffers
EXT_external_buffer spec -
This extension allows the data store for an immutable buffer to be
sourced from an external EGLClientBuffer, allowing sharing of EGL
client buffers across APIs, across processes, and across different
processing cores such as the GPU, CPU, and DSP.
The intent is for a single backing memory to be reused across various
processes and processors. Ensure that a glBuffer backed by external
memory does not orphan the memory when glBuffer APIs like
glBufferSubData or glMapBufferRangeEXT modify the glBuffer.
Bug: angleproject:4380
Bug: angleproject:5073
Tests: ExternalBufferTestES31.*DoesNotCauseOrphaning*Vulkan
Change-Id: I4e88f80d93ee1ba1208378121412926351d10af8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776192
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
90cf278c
|
2021-03-19T16:17:43
|
|
Add multi-thread/context test for compute shaders
The "Ragnarok M: Eternal Love" game uncovered a bug where 2 contexts
shared a VkCommandBuffer. The one context was used by one thread for
rendering, and the other context/thread dispatched compute shaders.
When the rendering thread destroyed a VkCommandBuffer, future compute
dispatches crashed because the new VkCommandBuffer didn't have a
compute pipeline bound.
Bug: b/181711029
Change-Id: I8bc85150c1c6202e02feb84a7ccc0ad7b9c39258
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770681
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
d5bc8a27
|
2021-03-17T18:21:35
|
|
Vulkan: Add VUID-vkCmdDraw-None-04584 validation error to ignore list
Aztec ruins is using the same texture (but different level controlled by
a uniform variable) for textureLod and rendering. This triggers vulkan
validation error. This CL put it in the ignore list so that it can pass.
Bug: b/175584609
Change-Id: I7623e7b448514b3c12268aa5fe154f4c2f59b059
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770686
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
867411a4
|
2021-03-08T19:08:14
|
|
Vulkan: Track images used for both attachment and sampler
This CL adds a new layout ImageLayout::ColorAttachmentAndShaderRead. We
detect that the same ImageHelper object is used for both sampler and
attachment and will pick this new layout instead of ColorAttachment.
Bug: b/175584609
Change-Id: I2089f59d4dc1ad4de7edab0e067797adcfa9b020
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749479
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
0a80f2e1
|
2021-03-15T16:56:08
|
|
D3D: Mark images dirty after recovering from storage
When images are recovered from storage due to resizing storage, they
were marked as clean and not always re-copied to the new storage.
Bug: angleproject:5757
Bug: chromium:1188854
Change-Id: Idd11025820433ab74ff769cd9508efcec4575c32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2763282
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
9b3b5733
|
2021-03-17T15:38:42
|
|
Tests: Add Ragnarok M: Eternal Love trace
Test: angle_perftests --gtest_filter="*ragnarok_m_eternal_love*"
TBR: timvp@google.com,jmadill@google.com
Bug: b/181800519
Bug: angleproject:5772
Change-Id: I1dcde486e909f7c2b5d59132e5f673c7e8ab1d01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774264
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
ba0bd785
|
2021-03-15T16:00:33
|
|
Fix the assert error and inbalence parens for SSBO
This PR strengthens below two cases:
1. Support calculate unsized array size for any type. Previously,
it reported error when the type was a structure.
2. Correctly add the right paren for store function when any
load/length functions are nested in it.
Bug: angleproject:5734
Change-Id: I3428fa35f1481275e1d193094ceddb011f747cf1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762655
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
|
|
|
1f1b4ffe
|
2021-03-08T11:44:28
|
|
Vulkan: Test render and sample the same texture but with different LOD
This simulates aztec ruin's usage. This works properly on native OpenGL
but generates validation error on vulkan backend and renders incorrect
as well.
Bug: b/175584609
Test: FramebufferTest_ES3.SampleFromAttachedTextureWithDifferentLOD
Change-Id: I402c205a1b625669cae29ee201dddd144e0dfbde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743797
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
bb7c1442
|
2021-03-17T10:17:31
|
|
Fix immutable texture base level validation
Jeff's new rendering feedback loop test
(https://github.com/KhronosGroup/WebGL/pull/3221) found a couple of
issues with texture base level validation. For immutable textures the
base level is clamped to the valid range, so setting an out of range
base level does not make an immutable texture sampler incomplete, and
we need to use the clamped value when checking for rendering feedback
loops.
Bug: angleproject:5768
Change-Id: Ie065709efd736f2cf75d4f980e8ac27999f80142
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2767901
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
f6eccc20
|
2021-03-12T09:17:27
|
|
Tests: Add June's Journey trace
Test: angle_perftests --gtest_filter="*junes_journey*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/182566407
Bug: angleproject:5752
Change-Id: I083507949c9bc16bf701028a678540df9a3531dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2755840
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
81dcf078
|
2021-03-08T11:21:31
|
|
Reland "Vulkan: Support EXT_sRGB_write_control"
This is a reland of 6073af536cf627742696823edc82c9b0a481a8bc
with 2 changes -
1. Don't enable the extension even in nonConformant mode
2. Don't enable VK_KHR_image_format_list for swiftshader
Original change's description:
> Vulkan: Support EXT_sRGB_write_control
>
> Implement support for EXT_sRGB_write_control. This extension
> requires VK_KHR_image_format_list to be supported.
>
> The spec requires this functionality to work with glBlitFramebuffer
> as well but support for that will be added in a follow up change.
> As such, this extension is only exposed in non-conformant mode.
>
> Bug: angleproject:5075
> Tests: SRGBFramebufferTest.*Vulkan*
> Change-Id: I59b38f6cd810a3d0d67ec29f4f19c25f65f70862
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617243
> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: angleproject:5075
Change-Id: I8e149d196a39c3c4769bfa8690792f3c53831299
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762647
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
522d609b
|
2021-03-16T11:30:32
|
|
Fix download_restricted_traces.py :: run_command()
run_command() was using the undefined variable 'cmd', rather than the
pass in parameter 'command'.
Bug: angleproject:5210
Change-Id: I5e80869b18b717835217ad14a562bb4d223d52c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2765005
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
c99e405c
|
2021-03-12T12:39:27
|
|
Disable timestamp queries for some GPUs on Android
Copy some workaround from chromium.
Bug: chromium:702980,chromium:477514,chromium:462553,chromium:1178333
Change-Id: I9acb6ef49c91193a9e6bb03c6fc5eabf336cba9a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756728
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
687d3153
|
2021-03-15T16:55:26
|
|
Skip plants_vs_zombies_2 on Windows+AMD
Step "angle_restricted_trace_gold_tests on ATI GPU on Windows on
Windows-10" failing on builder "Win10 FYI x64 Release (AMD RX 5500 XT)"
Bug: chromium:1187752
Change-Id: Ia48dd06c3e3aca66ff3194fc945e3c235fde85df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762645
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
cd881848
|
2021-03-12T15:26:36
|
|
Actually skip a flaky/timeout test
Also, create SwANGLE KHR 3.1 expectations section
Bug: angleproject:5755
Change-Id: I902b3d3de0c3c4dd190d36c6b5f2def33420efc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757125
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
191bee56
|
2021-03-12T13:44:19
|
|
Suppress flaky test on win-swangle
This test times out. It takes a while on my underpowered Windows
laptop.
Bug: angleproject:5755
Change-Id: Id112c170a5e57c8e765dd94277ce0cf2801fae6d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757118
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
4f6d4d6f
|
2021-03-12T10:32:57
|
|
Suppress flaky EGL resize failure on Linux
Bug: angleproject:5753
Change-Id: I0bf716b09d329e9881bf5ca146ef6839d898a1b4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757107
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
89d2a96a
|
2021-03-09T18:37:57
|
|
Vulkan: Add test for UBO descriptor allocations.
This performance counter test verifies that re-binding the same
two buffers repeatedly doesn't allocate new descriptor sets. Currently
the test fails because we don't cache descriptor sets for UBOs.
Covers equivalent code patterns in Asphalt 9.
Reorganizes the perf counters collected for the program objects. Now
they are per-frame reset instead of cumulative. This tracking is now
consistent for the different counter types. In the future we can add
cumulative tracking for all per-object and global perf counters.
Bug: angleproject:5736
Change-Id: I23d04b6453e38af1cf4af7274d24382d136efad3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746176
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
cef5b717
|
2021-03-11T09:22:33
|
|
EGL: Add attribute check in ValidateQueryContext
Implementation of EGL_IMG_context_priority was
missing attribute check in ValidateQueryContext
Add test case.
Test: angle_end2end_test --gtest_filter=EGLCreateContextAttribsTest
Bug: angleproject:5746
Change-Id: Idf5df29fcb343d969a031675b6c5985a9be0a705
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752891
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
225e1952
|
2021-03-11T17:05:43
|
|
Tests: Add Plants vs. Zombies 2 trace
Test: angle_perftests --gtest_filter="*plants_vs_zombies_2*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/182512556
Bug: angleproject:5749
Change-Id: Ib6c279f49ac95964f34e430d311a49600928166b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752898
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
d98e436a
|
2021-03-11T13:32:07
|
|
Tests: Add Lineage M trace
Test: angle_perftests --gtest_filter="*lineage_m*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/182491024
Bug: angleproject:5748
Change-Id: I901b68eef1ddac98ce6e1a4640e2b034d1027a45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752894
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
c5a7da47
|
2021-03-11T13:12:04
|
|
Suppress flaky MultithreadingTest on Win/Swangle
MultithreadingTest.MultiContextDrawWithSwapBuffers/ES3_Vulkan_SwiftShader_NoVirtual
Bug: angleproject:5099
Change-Id: I12ab4a6fb7fff8d6bc7358e6017cb10e46362b88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752893
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
7c7cf3e5
|
2021-03-11T14:27:51
|
|
Skip dEQP tests flakily timing out on SwANGLE
Bug: chromium:1173237
Change-Id: I93810cb7cbaae847848eae0dc050c2c00df956af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753144
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
7c02cfee
|
2021-03-11T19:01:13
|
|
Avoid undefined behavior in BPTCCompressedTextureTest
Bug: angleproject:5360, angleproject:5731
Change-Id: Ia883d2d319d7ce4659f4e1e99b5eccf0e01a45e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752747
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
36770173
|
2021-03-10T15:23:03
|
|
capture_replay_tests: Don't shadow subprocess import.
Rename local variable, so using subprocess.Timeout does not result in
an exception.
This patch fixes the test timeout counter.
Bug: angleproject:5742
Change-Id: Ib6991bc58df6ea653f765dfe9f6117add75b85db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2748339
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
9265d1e2
|
2021-03-05T17:54:59
|
|
frame_capture_utils: Do not serialize 0 bindings.
Since we are only interested in the difference to non-default states,
bindings with a zero ID should not be serialized.
This resolves the comparision error in the GetTexLevelParameterTest.*
tests. The test now do not need to be skipped.
Bug: angleproject:5645
Change-Id: I887bc22b52a201c467c00c42f6ddb3b38895a7c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739726
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
44b9579c
|
2021-03-10T08:10:33
|
|
Vulkan: Treat varyings in a separable program as active
When separable programs are linked, varyings at the separable program's
boundary need to be treated as active.
Bug: angleproject:5557
Test: ProgramPipelineTest31.VaryingIOBlockSeparableProgram*
Change-Id: I28af2bdf6478a408b3a7155ab4376ed6a19192f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2742659
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
04a641ac
|
2021-03-04T10:57:37
|
|
capture_replay_tests: Change status to crashing.
Move both SemaphoreTests to crashing.
Don't skip passing VulkanExternalImageTest.*.
Explicitly list VulkanExternalImageTest.* tests that still crash.
All these tests compile now.
Bug: angleproject:5721
Change-Id: Ib529dff8895496925001e4649aabcae78ce77236
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739725
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
c9c75b99
|
2021-03-04T10:21:03
|
|
capture_gles_ext_params: Implement glGetIntegervRobustANGLE.
Move RobustClientMemoryTest.* to crashed tests, as it builds now.
Bug: angleproject:5721
Change-Id: I590f4bd679374ee3302fc985a53747ddd60dd429
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739724
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
14152cf4
|
2021-03-09T11:53:41
|
|
Tests: Add Extreme Car Driving Simulator trace
Test: angle_perftests --gtest_filter="*extreme_car_driving_simulator*"
TBR: jmadill@google.com, timvp@google.com
Bug: b/180419767
Bug: angleproject:5735
Change-Id: I5c197a71354a0cb3b907718b7ae7161037f7266f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743806
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
c935ba5b
|
2021-03-09T08:40:22
|
|
Vulkan: Collect inactive varyings by block name for I/O blocks
ANGLE only collects inactive varyings by instance name. The SPIR-V
transformer expects I/O blocks to be identified by block name. If an I/O
block is inactive, an assertion would fire because the block name is not
in the shader variable info map.
Bug: angleproject:5676
Test: GLSLTest_ES31.VaryingIOBlockNotDeclaredIn*Shader*
Change-Id: I40e51c9770b03457e3896dcb2afa4e9525b098d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2742658
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
7f1c0c3b
|
2021-03-09T08:09:55
|
|
Call resolveLink in Program::attachShader and Program::detachShader
Previously glAttachShader and glDetachShader would only call
resolveLink during validation.
Adding the resolveLink in attachShader/detachShader handles the case
where glAttachShader and glDetachShader is called with
EGL_CONTEXT_OPENGL_NO_ERROR_KHR to skip validation.
Tests: angle_end2end_tests --gtest_filter=ContextNoErrorTest.DetachAfterLink*
Bug: angleproject:2868
Change-Id: I1e01cf8e6f8a382333226bdef037c46f4c62a119
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745654
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
ac382039
|
2021-03-08T16:02:18
|
|
Allow graceful no-error failure in CastStateValues.
Bug: angleproject:5738
Change-Id: Iecc498b35281b8fd676f1168c3a4ed6b407d18a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743668
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b27740f3
|
2021-03-09T16:15:15
|
|
Revert "Vulkan: Support EXT_sRGB_write_control"
This reverts commit 6073af536cf627742696823edc82c9b0a481a8bc.
Reason for revert: crbug.com/1186140
Original change's description:
> Vulkan: Support EXT_sRGB_write_control
>
> Implement support for EXT_sRGB_write_control. This extension
> requires VK_KHR_image_format_list to be supported.
>
> The spec requires this functionality to work with glBlitFramebuffer
> as well but support for that will be added in a follow up change.
> As such, this extension is only exposed in non-conformant mode.
>
> Bug: angleproject:5075
> Tests: SRGBFramebufferTest.*Vulkan*
> Change-Id: I59b38f6cd810a3d0d67ec29f4f19c25f65f70862
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617243
> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: angleproject:5075,chromium:1186140
Change-Id: Ib0d4d60fe7434fb950f99db2c210aab9af7d2d0e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743663
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
|
57727c4e
|
2021-03-08T17:32:25
|
|
Further suppress tests failing on Ozone.
Since MipmapTest and Texture3DTestES2 fail in testSetUp(),
it also needs to be skipped, in addition to the failing tests.
Also suppress instantiation error for ES3-only QueryObjectTest
Bug: angleproject:5725, angleproject:5728, angleproject:5704
Change-Id: Iac6549afd7609a2aee78bcfdb7c3de41886f3505
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743920
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
6073af53
|
2021-03-08T11:21:31
|
|
Vulkan: Support EXT_sRGB_write_control
Implement support for EXT_sRGB_write_control. This extension
requires VK_KHR_image_format_list to be supported.
The spec requires this functionality to work with glBlitFramebuffer
as well but support for that will be added in a follow up change.
As such, this extension is only exposed in non-conformant mode.
Bug: angleproject:5075
Tests: SRGBFramebufferTest.*Vulkan*
Change-Id: I59b38f6cd810a3d0d67ec29f4f19c25f65f70862
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617243
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
92b5fccd
|
2021-03-02T08:43:18
|
|
Handle nullptr in GetQueryObjectParameter()
There are applications that disable validation using
EGL_CONTEXT_OPENGL_NO_ERROR_KHR extension. In such usecases
the GetQueryObjectParameter() method needs to account for the
possibility that the query object has not yet been created.
Bug: angleproject:5704
Tests: angle_end2end_tests --gtest_filter=QueryObjectTest*
Change-Id: Ib9e1cb32a6d64f2772124178223cf07cbb84691b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729298
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
a0bc2589
|
2021-03-05T19:27:04
|
|
Skip tests failing on Ozone.
MipmapTest.DefineValidExtraLevelAndUseItLater
MipmapTest.GenerateMipmapAfterModifyingBaseLevel
MipmapTest.GenerateMipmapAfterSingleLevelDraw
MipmapTest.GenerateMipmapFromInitDataThenRender
MipmapTest.GenerateMipmapFromRenderedImage
MipmapTest.MipMapGenerationD3D9Bug
MipmapTest.MipmapsForTexture3DOES
MipmapTest.RenderOntoLevelZeroAfterGenerateMipmap
MipmapTest.TextureCubeGeneralLevelZero
MipmapTest.TextureCubeRenderToLevelZero
MultisampleTest.AlphaToSampleCoverage
MultisampleTest.ContentPresevedAfterInterruption
MultisampleTest.Line
MultisampleTest.Point
MultisampleTest.Triangle
Texture3DTestES2.CopySubImageAlpha
Texture3DTestES2.CopySubImageLuminance
Texture3DTestES2.CopySubImageRGBA
Texture3DTestES2.Luminance
Texture3DTestES2.RGBA
Bug: angleproject:5725, angleproject:5727, angleproject:5728
Change-Id: Ibe7d7e44e01ce430e381edd0c83c3e24069b35aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738718
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
a318b3d6
|
2021-03-05T16:38:47
|
|
Roll VK-GL-CTS from 9cdde06fb38a to 9be79728eafb (18 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9cdde06fb38a..9be79728eafb
2021-03-02 ynovikov@google.com Fix Windows build
2021-03-01 alexander.galazin@arm.com Update Vulkan headers
2021-02-25 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2021-02-25 rgarcia@igalia.com Pipeline bind point tests
2021-02-25 rgarcia@igalia.com Add tests for sparseImageFloat32Atomics
2021-02-25 anholt@google.com Fix more spurious failures in KHR-GL*.transform_feedback.api_errors_test
2021-02-25 anholt@google.com Fix spurious failures on KHR-GL30.transform_feedback.api_errors_test
2021-02-25 tapani.palli@intel.com Print ints for pixel values instead of chars in error message
2021-02-25 thomas.spurden@broadcom.com Fix exit code for cts-runner
2021-02-25 mikko.tiusanen@siru.fi Tests for GLES3 framebuffer completeness
2021-02-25 alexander.galazin@arm.com Support GL 4.5 in the Program interface query tests
2021-02-25 lionel.g.landwerlin@intel.com Silence validation layers warning on missing sType
2021-02-25 mika.vainola@siru.fi Allow wildcards in waiver vendor strings
2021-02-25 boris.zanin@mobica.com Add a list of unused shaders into log
2021-02-25 boris.zanin@mobica.com Add concurrent transform feedback streams query tests
2021-02-24 gleese@broadcom.com Remove a waiver for a non-existant device
2021-02-23 mika.vainola@siru.fi Add tests for implicit unmap on free
2021-02-23 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC jonahr@google.com,angle-bots+autoroll-info@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: angleproject:5684, angleproject:5722
Tbr: jonahr@google.com,angle-bots+autoroll-info@google.com,ynovikov@google.com
Change-Id: Ibd432a2135665ed89f93549e24923c108a08f97b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739041
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
a1f86b4d
|
2021-03-05T16:55:47
|
|
Skip vulkan_car_parking_multiplayer on Win Intel
Internal Vulkan error (-4):
The logical or physical device has been lost.
Bug: angleproject:5724
Change-Id: I80eb21d087341fac23393d7365bd5ea4c5ac6e05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739387
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
8a48f4de
|
2021-03-05T14:33:16
|
|
Skip CopyTextureVariationsTest failing on Ozone
CopyTextureVariationsTest.CopyTexture
CopyTextureVariationsTest.CopySubTexture
Bug: angleproject:5723
Change-Id: Iad62344b9bc503a2553647877c5975b03bb6829d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738602
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
d96b9ffa
|
2021-03-04T09:57:53
|
|
capture_replay_tests: Don't skip tests that pass.
These tests were skipped due to compilation problems, but do now fully
pass on SwiftShader ES2.
Remove PointSpritesTest.PointWithoutAttributesCompliance/*
Remove ExplicitContextTest.GetProcAddress/*
Remove RobustBufferAccessBehaviorTest.EmptyBuffer/*
Remove EGLSyncTest.AndroidNativeFence_WaitSync/*
Bug: angleproject:5721
Change-Id: I3f50272c69ba78e2432f4278753e5d48d8601910
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739723
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
fe2efefa
|
2021-02-27T08:28:03
|
|
Add FramebufferAttachmentPerfTest
Two tests are added to measure the overhead involved in the
Observer/Subject interface -
1. FramebufferAttachmentBenchmark - stresses repeated attach/detach
of observers to subjects.
2. FramebufferAttachmentStateUpdateBenchmark - stresses state updates
to subjects and their propagation to observers.
Bug: angleproject:5692
Change-Id: I6e573f3a948ef2b20c56091e549eb871051e0103
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725740
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
2f737c25
|
2021-02-25T16:55:14
|
|
Translator: Rename GLSL to SPIR-V in Vulkan and Metal output
Preparation for actual SPIR-V output instead of GLSL.
Bug: angleproject:4889
Change-Id: Ic279b23d3a817bd5dca66a844905378207afdbac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2721194
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
a6b16d29
|
2021-03-02T19:04:57
|
|
Suppress UNINSTANTIATED_PARAMETERIZED_TEST failures on Ozone
We only support ES2 on Ozone, so tests that depend on ES3 or ES31
support are not instantiated there.
Bug: chromium:1183147
Change-Id: Id58bcd9b44a5b9a70b5ae8115e27c44f5dc81226
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726550
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
54294c9a
|
2021-03-02T22:15:05
|
|
Partially upgrade codegen to Python 3
Bug: angleproject:5707
Change-Id: I4e26c2c7ba4a36185b28ecd6e87be1161b60431a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729567
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
d8557cc8
|
2021-03-03T10:17:46
|
|
Fix for readPixels() to PBO fast path.
Include the "pixels" (data) pointer as offset.
Bug: angleproject:5702
Change-Id: Idc9f3ee4c0dbb1cc9308393bbf877d6137598486
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732789
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
|
|
|
71c7e346
|
2021-03-02T21:52:35
|
|
Tests: Add Rope Hero: Vice Town trace
Test: angle_perftests --gtest_filter="*rope_hero_vice_town*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181727986
Bug: angleproject:5711
Change-Id: I11021ae91f968bd453b98a35c60cab90d71e5ed6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2731288
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
18314bce
|
2021-03-03T10:28:07
|
|
Tests: Skip car_parking_multiplayer on Nvidia
The trace doesn't cause any errors, which would have blocked
landing it. But it does spew undefined behavior warnings which
fills the log. See the bug for details, skipping for now.
Test: angle_perftests --gtest_filter="*car_parking_multiplayer*"
Bug: angleproject:5613
Change-Id: I54bf63eeb7c5212b6ce40cf2b45354822e8456e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733089
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
cdef22a5
|
2021-03-03T10:19:31
|
|
Skip TransformFeedbackTest.MultiContext on Metal
This test is flaky on the metal backend.
Bug: angleproject:5713
Change-Id: I1d789825e0322f00b017a60f8fd1cef02b5b3088
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732787
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
fbbd143b
|
2021-02-27T17:42:05
|
|
Tests: Add Talking Tom Hero Dash trace
Test: angle_perftests --gtest_filter="*talking_tom_hero_dash*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181415750
Bug: angleproject:5614
Change-Id: I6110f5e3e6bbc60706c448ad3643de73b3c2eca2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726134
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
1de8b5a6
|
2021-03-02T14:42:22
|
|
Tests: Add Car Parking Multiplayer trace
Test: angle_perftests --gtest_filter="*car_parking_multiplayer*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181696940
Bug: angleproject:5710
Change-Id: I50366e0bb993c1f19906aa5d96f47a00247a24f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729605
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
210a464e
|
2021-03-02T12:05:08
|
|
Test: Add Standoff 2 trace
Test: angle_perftests --gtest_filter="*standoff_2*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181681788
Bug: angleproject:5708
Change-Id: I36314d1addc880cc4fb0dc321cda4ba3eabab000
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2728662
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
22fc9523
|
2021-02-03T15:32:48
|
|
EGL: implement EGL_EXT_buffer_age
Add extension flag.
Add Validation check to surface query.
Enable extension for vulkan.
Modify AcquireNextImage to ++frame count and tag images
with frame number.
Buffer age is the difference between current frame count
and the tagged frame number on the buffer.
getBuffeAge may need to trigger AcquireNextImage to be current.
Pass through egl extension and query.
Add EGLBufferAgeTest
Test: angle_end2end_test --gtest_filter=EGLBufferAgeTest
Test: angle_deqp_egl_tests
--deqp-case=dEQP-EGL.functional.buffer_age.*
Bug: angleproject:3529
Change-Id: I0cb94be1c3e85d6f33e82a6a1ccdc9731b6a7f23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2684724
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
c11186c2
|
2021-03-02T14:42:08
|
|
capture_replay_tests: Fix MemoryObjectTest.
Add gles_ext_params Capture functions for MemoryObjectsEXT.
Add case for GLCreateMemoryObjectsEXT to MaybeCaptureUpdateResourceIDs.
Don't skip MemoryObjectTest, as it passes now on SwiftShader ES2.
Bug: angleproject:5703
Change-Id: I930fab675cf0848f46a846388955a6bd3274a587
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729004
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
87b1875c
|
2021-03-01T19:17:35
|
|
Tests: Add Among Us trace
Test: angle_perftests --gtest_filter="*among_us*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181616715
Bug: angleproject:5698
Change-Id: If52ee0e989c6b4a3c21b4a2bc0b77dbbea2a3d6d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2728564
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
3e017cfe
|
2021-02-26T15:37:41
|
|
Tests: Use context version from trace
Test: Capture and replay ES 3.2 apps
Bug: angleproject:5652
Change-Id: Ib46250acd8a50390f0cbd40853623cdf31bd0203
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698392
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
6af0c03f
|
2021-02-25T18:15:21
|
|
Vulkan: Always write to swapchain alpha channel
This fixes an issue with the "Ragnarok M: Eternal Love" game, which
uses a GL_RGB8 format for its window, which is actually backed by a
GL_RGBA8 format (a.k.a. "emulated alpha"). The game does no explicit
clear per frame. Therefore, ANGLE selects a render pass
loadOp=DONT_CARE, which leaves the alpha channel undefined (0.0 on a
Pixel 4 XL). That causes SurfaceFlinger to show (blend or alternate
vsyncs) what should have been covered up by the game (e.g. the Android
launcher and live wallpaper).
The solution is to prevent loadOp=DONT_CARE for emulated alpha.
Test: ClearTest.ChangeFramebufferAttachmentFromRGBAtoRGB
Test: dEQP-GLES2.functional.fbo.render.stencil_clear.tex2d_rgb_stencil_index8
Bug: b/180139027
Change-Id: Ied97b57c93d41326cb3294ff246691e09f316791
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2704949
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
5b82fa2e
|
2021-02-28T11:11:34
|
|
Suppress UNINSTANTIATED_PARAMETERIZED_TEST failures on Win AMD
GTest complains that we don't run some tests on D3D/Vulkan backends.
They only run on GL backend, which is disabled on Win AMD
per http://anglebug.com/5123
Bug: chromium:1183147
Change-Id: I95fdd9a24aff69aa60e2f60613d8300ae1019a27
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726576
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
2b55f876
|
2021-01-29T18:02:21
|
|
Reland "Workaround for Mac Intel drawArraysInstanced with first > 0"
This is a reland of 027bc47ca5b7b291fbda907173eefa05ad3d45a8
Original change's description:
> Workaround for Mac Intel drawArraysInstanced with first > 0
>
> Workaround by forcefully set instanced arrays (divisor > 0)
> as streaming attributes and apply extra offset at front. Recover
> those attribute bindings when first == 0 and other draw calls
> (drawElementsInstanced)
>
> Bug: chromium:1144207, chromium:1144247, chromium:1144373
> Change-Id: Ie7836cc71b45a290513f34f90d49bd15b14ddba8
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2661095
> Commit-Queue: Shrek Shao <shrekshao@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Bug: chromium:1144207
Bug: chromium:1144247
Bug: chromium:1144373
Bug: angleproject:5271
Change-Id: Id0b818b25a605376c98c2366c1f2029e2490c6cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2704799
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
f9c595b4
|
2021-02-26T11:53:30
|
|
Skip 3 SimpleStateChangeTestES31
DrawWithTextureThenDrawWithImage on Win Intel GL
ClearThenSampleWithCompute on Linux AMD GL
TransformFeedbackThenReadWithCompute on Win AMD Vulkan
Bug: angleproject:5686, angleproject:5687, angleproject:5688
Change-Id: If380074389382bc7e9a8b8668c83fb9c8ef2084d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2723291
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
d24398b3
|
2021-02-25T15:07:00
|
|
gl.xml: Annotate glDiscardFramebufferEXT with param groups.
Remove tests from expectations list, as it now passes on SwiftShader for
ES2 and ES3.
Bug: angleproject:4401
Change-Id: If05b16e40632154a0ba2c22f1c3bf29e12113389
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2720259
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
d3cde02d
|
2021-02-24T16:50:35
|
|
Cleanup EGLMakeCurrentPerfTest instantiation
Bug: angleproject:2735, chromium:1180570
Change-Id: Iddf97121c36a0e27bda5676212690574efe8a83d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2716613
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
ba233b6a
|
2021-02-25T13:44:32
|
|
Suppress 1 VulkanExternalImageTest on Linux AMD Vulkan
VulkanExternalImageTest.TextureFormatCompatChromiumMutableNoStorageFd
Bug: angleproject:5682
Change-Id: Id2aa15f4943f9132d133eeb540e35e405896a3b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2718530
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
9b1c569b
|
2021-02-24T11:32:39
|
|
Vulkan: Handle vertex count and primitive mode error cases in TS
When handling tessellation shaders these 2 requirements need to be met -
1. TCS - vertex count should be declared at least once
2. TES - primitive mode should be declared at least once
After translating TCS/TES check whether these requirements are met
and error out if they are not.
Bug: angleproject:5557
Test: dEQP-GLES31 -
functional.shaders.linkage.es31.tessellation.varying.rules.unspecified_*
KHR-GLES32 -
core.tessellation_shader.compilation_and_linking_errors.te_lacking_primitive_mode_declaration
Change-Id: I727d548ad446646bbece1fb78197639537b5f395
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2714465
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
550f2a3e
|
2021-02-24T09:49:42
|
|
Vulkan: Shader support for EXT_shader_framebuffer_fetch_non_coherent
Translator can accept gl_LastFragData and 'inout' variable to gain
access to framebuffer attachment data. The Vulkan translator replaces
it with the SubpassInput type variable. Note that this works only for
the noncoherent version of the extension.
Bug: angleproject:5454
Test: *EXTShaderFramebufferFetchNoncoherent*.*
Change-Id: I392f84ee3ad3eb9fbd09d0b7ff83731a9a3f33f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598060
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
999da35e
|
2021-02-18T17:29:20
|
|
Vulkan: Optimize glMemoryBarrier more
The implementation assumed that the X_BARRIER_BIT bits implied two
barriers; write->X and X->write. However, they only imply write->X,
with the exception of SHADER_IMAGE_ACCESS_BARRIER_BIT and
SHADER_STORAGE_BARRIER_BIT which handle X->write for images and buffers
respectively.
As a result, the other bits no longer set the MEMORY_BARRIER dirty bit
as they don't guard against X->write usage.
Bug: angleproject:5070
Change-Id: Id23904c455a5f56dc45fc6832a74fdfbba6a4827
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705702
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a833f200
|
2021-02-23T17:23:31
|
|
Docs: Update ANGLE trace creation steps
Bug: angleproject:5677
Change-Id: I76ff3991f2124b27cd5c0cd9bad3754ae875cfc4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2717102
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Paul Thomson <paulthomson@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
d81e5d17
|
2021-02-18T16:02:35
|
|
Add a test for sample after deferred clear
To ensure that deferred clears are flushed before sampling.
Bug: angleproject:5070
Change-Id: I72bfef752074eb1e722c669edaa2d0b5ddfd20b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705027
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
39d7fc18
|
2021-02-17T00:18:41
|
|
Vulkan: Don't break the render pass on dispatch calls
The only reason a dispatch call may need to break the render pass
implicitly is for read-after-writes where the write originates from the
render pass but is not through a storage buffer/image. There are only
two such scenrios possible:
- Framebuffer attachment write -> texture sample
- Transform feedback write -> ubo read
All other uses of the buffers and textures that require breaking the
render pass are handled by `glMemoryBarrier`.
Bug: angleproject:5070
Change-Id: I92b50d69d8782097ee8ff477ac57da6209c326a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698998
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
5d7f4e80
|
2021-02-18T17:06:12
|
|
Remove incorrect memory barrier tests
The tests were written with the assumption that the X_BARRIER_BIT
implied two barriers, write->X and X->write. However, they only imply
write->X, with the exception of SHADER_IMAGE_ACCESS_BARRIER_BIT and
SHADER_STORAGE_BARRIER_BIT which handle X->write for images and buffers
respectively.
Bug: angleproject:5070
Change-Id: Ic9bfac997d0663b70f1d40baca6c111a4dc300c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705701
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
016c5ff0
|
2021-02-23T11:34:30
|
|
Roll VK-GL-CTS from 1a524349f06b to 9cdde06fb38a (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/1a524349f06b..9cdde06fb38a
2021-02-23 alexander.galazin@arm.com Merge pull request #241 from enunes/gles2-EXT_texture_rg
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: angleproject:5674
Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com
Change-Id: Ie6e73c958321b224de7338c1bd5c3e7c719accb1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2714485
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1330aa2c
|
2021-02-12T15:21:31
|
|
capture_replay_tests: Fix repository path retrieval.
Use relation to retrieve angle repository path.
The previous way of detecting the root repository folder failed to
detect a correct path if the angle directory was in a path that
contained the string angle.
e.g. `/home/user/code/angle/angle`
Other paths that would fail with the current implementation:
`/home/user/my-angle-workspace/angle`
`/home/tangled/workspace/angle/`
`/home/user/code/angle-android`
This way the path is constructed with the known relation of the script
path inside the repository. Another advantage of this way is that the
`angle` repository could be checked out with a different name.
The disadvantage of this method is that whenever the script was moved,
the relative path must be updated.
Bug: angleproject:5645
Change-Id: I9a56aeba449b248273087382adceb0d6fba5a494
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2715323
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
37752956
|
2021-02-11T16:12:48
|
|
Generators: Use fixed year in license headers.
Remove dynamic year generation from generator scripts, as required by
the Chromium C++ style guide.
The dynamic year values were replaced by the current year at the time
the file was created according to git log. The code to dynamically
generate the year was removed.
This patch also refreshes generated files and hashes.
Bug: angleproject:5516
Change-Id: I735028bccb5c83217e92c380538f1abf0a906b2c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690950
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
2be24692
|
2021-02-21T21:14:35
|
|
Skip more flaky crashing dEQP tests on Nexus 5X
Bug: angleproject:5665
Change-Id: I29f7cdd39c13d105c52ab0803e6241205fc743fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2710908
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
6eb7ae4f
|
2021-02-21T19:43:44
|
|
Suppress 2 failing dEQP GLES3 tests on Mac AMD Metal
Bug: angleproject:5666
Change-Id: Ie4b62868ebca6806bb40f78ce49f1fbf70f96fcf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2710907
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
c03a4235
|
2021-02-20T16:14:37
|
|
Suppress UNINSTANTIATED_PARAMETERIZED_TEST failures on Nexus 5X
GTest complains that we don't run some tests on GLES backend.
Bug: chromium:1180570
Change-Id: I9427ac25c3b6f06f3c042caa3c0afc7000cf1599
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2710783
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
5c931b61
|
2021-02-20T13:18:32
|
|
Skip more flaky crashing dEQP tests on Nexus 5X
Bug: angleproject:5665
Change-Id: I17da18f451c90a767ac957ea03e1ce0eb38302d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2710623
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
be943b3b
|
2021-02-19T15:23:54
|
|
Skip flaky crashing dEQP tests on Nexus 5X
Bug: angleproject:5665
Change-Id: Ifccd1d11edcbdfc57765144ba5dc65d12de53af2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2705766
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
4b608a6c
|
2021-02-17T22:14:18
|
|
Tests: Add Messenger Lite trace
Test: angle_perftests --gtest_filter="*messenger_lite*"
Bug: b/180562361
Bug: angleproject:5659
Bug: angleproject:5663
Change-Id: I9938b925962ea13fd626f2b82676655d07d78c0d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2703733
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
f18b92ad
|
2021-02-17T19:40:53
|
|
testing: Mark uninstantiated GL & EGL test suites
googletest CL 315255779 causes test binaries to fail when they include
test suites / parametrized tests that are not instantiated, and when
they include empty test suites.
This CL uses the GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST() macro
to annotate the suites / tests that are causing test failures. This is
necessary to get googletest rolled past CL 315255779.
Bug: chromium:1163396
Change-Id: I05c0619186ffc265b8e32e8b69d6680a6acdbb48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2701292
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
dceb2412
|
2021-02-18T16:44:37
|
|
Roll VK-GL-CTS from eab348e95425 to beffa5287574 (5 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/eab348e95425..beffa5287574
2021-02-18 alexander.galazin@arm.com Support GL 4.5 in the Built-in Constant Tests
2021-02-18 ari.suonpaa@siru.fi Add tests for mixing matrix packing in nested structs
2021-02-18 gleese@broadcom.com Extend CopyImage tests to test astc_sliced_3d
2021-02-18 mika.vainola@siru.fi Fix undefined behavior in FloatToHalf
2021-02-18 mikko.tiusanen@siru.fi Add tests for all ES 3.0 internal formats
Bug: angleproject:5661
Bug: angleproject:5662
Change-Id: Iab7a28e17523e0b69fb76fbd6281423db63569fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2703517
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
|
|
|
9d83517b
|
2021-02-17T23:20:03
|
|
Tests: Add AliExpress trace
Test: angle_perftests --gtest_filter="*aliexpress*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/180565449
Bug: angleproject:5660
Change-Id: I61ac0e7dbfbe6fd23c71b63fa6f8c00b20a94006
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2703735
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
fd132e4e
|
2021-02-18T18:21:32
|
|
testing: Mark uninstantiated perftests
googletest CL 315255779 causes test binaries to fail when they include
test suites / parametrized tests that are not instantiated, and when
they include empty test suites.
This CL uses the GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST() macro
to annotate the suites / tests that are causing test failures. This is
necessary to get googletest rolled past CL 315255779.
Bug: chromium:1163396
Change-Id: I13ffa09c4263a6dc8baf1749c3df5d2c54904e68
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2704800
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
bd276beb
|
2021-02-12T10:58:43
|
|
Vulkan: Don't wait on unflushed sync objects without a Context
The app "Car Parking Multiplayer" issues a ClientWaitSync() command
without having already flushed the sync object and without an active
context. We should return TIMEOUT immediately rather than attempting to
wait on the sync object, since we can't flush it and it'll never be
signalled.
Bug: angleproject:5613
Bug: angleproject:5656
Test: MultithreadingTest.NoFlushNoContextReturnsTimeout
Change-Id: Ieaf675ca9144f9c851c73b9ca399daaf4ed1cd0f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2693375
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
7ae8531b
|
2021-02-17T15:20:07
|
|
Vulkan: Fix crash with 0-sized element buffer
VertexArray::syncState syncs all dirty bits, including
DIRTY_BIT_ELEMENT_ARRAY_BUFFER even for draw calls that don't use this
buffer, such as glDrawArrays. If the element buffer is given 0 size,
this caused a crash in the Vulkan backend.
Bug: chromium:1172577
Change-Id: I02d78c9660c07b896f7403867b648901478251fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2701831
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
436b43a6
|
2021-02-16T14:28:06
|
|
Add comprehensive memory barrier tests
Optimizing glMemoryBarrier can get very tricky. This change adds tests
for every glMemoryBarrier bit in different scenarios for a total of
about 1500 tests. With the current implementation, there are no syncval
errors running these tests.
Bug: angleproject:5070
Change-Id: I5358bfeed84f586a67c90ba5ab0fe624db6820b5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698288
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
907a3cee
|
2021-02-17T08:07:45
|
|
Vulkan: Add support for EXT_shader_framebuffer_fetch_non_coherent
EXT_shader_framebuffer_fetch_non_coherent is implemented using subpass
input attachments. The extension will be enabled in a follow up change
that adds required changes to the Vulkan translator.
Bug: angleproject:5454
Test: FramebufferFetchNonCoherentES31.*Vulkan
Change-Id: Ic73c66a476c4a21db5269431166a198841f1dc0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598059
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
82337b00
|
2021-02-17T16:47:48
|
|
Add suppressions for failing tests on Linux Nvidia GL
The following failing without a clear reason (asides from PartitionAlloc
changes in Chromium maybe). This CL suppresses them while we find what
the issue is.
TBR=syoussefi@chromium.org
Bug: angleproject:5651
Change-Id: I6cba67351dfba37fd6d86a07ac748b7998665361
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2700511
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
|
|
|
64b5b3d3
|
2021-02-12T17:31:58
|
|
Vulkan: Further restrict enabling LINE_RASTERIZATION_MODE_BRESENHAM
The app "Car Parking Multiplayer" enables GL_SAMPLE_ALPHA_TO_COVERAGE,
which leads to a VVL error when LINE_RASTERIZATION_MODE_BRESENHAM is
also enabled:
VUID-VkGraphicsPipelineCreateInfo-lineRasterizationMode-02766:
The Vulkan spec states: If the lineRasterizationMode member of a
VkPipelineRasterizationLineStateCreateInfoEXT structure included in the
pNext chain of pRasterizationState is
VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT or
VK_LINE_RASTERIZATION_MODE_RECTANGULAR_SMOOTH_EXT and if rasterization
is enabled, then the alphaToCoverageEnable, alphaToOneEnable, and
sampleShadingEnable members of pMultisampleState must all be VK_FALSE.
This CL adds the additional checking to
GraphicsPipelineDesc::initializePipeline() to ensure those conditions
are met before setting lineRasterizationMode to
VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT.
Bug: angleproject:5613
Test: StateChangeTest.AlphaToCoverageEnable
Change-Id: Ie2286078f6916c01a19ae6f932321a86619bd4e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2694094
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
0fa6c307
|
2021-02-04T11:23:06
|
|
Enable ES 3.2 in ANGLE's loader
Test: Capture and replay ES 3.2 apps
Bug: angleproject:5652
Change-Id: I2dac84d3cf6534ee1b10889ba1312ae247ae8f62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698391
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
c7ae5d28
|
2021-02-17T15:57:37
|
|
Suppress ClearThenMaskedClearFramebufferTest on Linux AMD VK
The test has been failing on that configuration since it was introduced.
TBR=syoussefi@chromium.org
Bug: angleproject:5655
Change-Id: If852bcd574fa0cd4018220b7d6749b95a717a7c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698117
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
|
|
|
e8c0aa81
|
2021-01-26T23:40:36
|
|
Vulkan: Clean up transform feedback extension pause/resume
1. The xfb counter buffer barrier issued was wrong, following a typo in
the spec. This barrier is now correctly issued using the usual
barrier APIs.
2. A mechanism was added to automatically pause/resume transform
feedback when a program pipeline needs to be rebound. This is
incorrect as it misses the xfb counter buffer barrier. The render
pass is broken instead if transform feedback is active/unpaused and
the program pipeline is changed.
3. The transform feedback counter buffers are now disposed of when
transform feedback is ended. This avoids an unnecessary barrier that
this change would have otherwise incurred (and hence render pass
break) in Manhattan which repurposes the same transform feedback
object.
Bug: angleproject:5528
Change-Id: I1ffe8b4b8975645ba43afd70e9cdbb0765529da5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2651647
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d7037aa2
|
2021-02-11T14:35:30
|
|
Vulkan: noop glMemoryBarrier(CLIENT_MAPPED_BUFFER_BARRIER_BIT_EXT)
CLIENT_MAPPED_BUFFER_BARRIER_BIT_EXT requires a memory barrier: shader
buffer write -> host read. According to the spec, the data is only
available after a call to glFinish or wait on sync:
> The application must call MemoryBarrier with the
> CLIENT_MAPPED_BUFFER_BARRIER_BIT_EXT set and then call FenceSync with
> SYNC_GPU_COMMANDS_COMPLETE (or Finish). Then the CPU will see the
> writes after the sync is complete.
When a buffer is written to by the GPU, ANGLE calls
onHostVisibleBufferWrite(), which ensures a "memory write -> host read"
barrier is issued at the end of the command buffer.
Additionally, persistently mapped buffers use
VK_MEMORY_PROPERTY_HOST_COHERENT_BIT, so there's no need for a call to
vkInvalidateMappedMemoryRanges.
As a result, there's nothing necessary in ANGLE to do for this barrier
bit. Note that should persistenly mapped buffers start using
non-coherent memory, this barrier should imply a call to
vkInvalidateMappedMemoryRanges for the persistently mapped buffers.
Bug: angleproject:5070
Change-Id: Iaeae019dadfa659a47d2dac41c0c09f1c15e584b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689380
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
30622479
|
2021-02-16T12:33:40
|
|
Vulkan: Fix crash with deferred clears and MSRTT
The following scenario was mishandled:
- MSRTT draw with an unresolve operation (i.e. has two subpasses)
- Deferred clear
- Flush deferred clear with MSRTT framebuffer not needing unresolve
(i.e. has one subpass)
Bug: chromium:1178693
Change-Id: If3548e99897d698d61dfafbe9f86193723d06e5a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2697648
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|