kc3-lang/angle

Log

Author Commit Date CI Message
Steven Noonan 397a27bb 2021-10-20T20:33:20 VertexArray: on destroy, remove observer on element array buffer Otherwise there will be a null pointer dereference in gl::Buffer::onContentsChange(). Signed-off-by: Steven Noonan <steven@valvesoftware.com> Bug: angleproject:6599 Change-Id: I73388b6d0ccc357ca1944452a18ccf462dd8046c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3236206 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 85515acf 2021-10-21T10:01:55 Roll SwiftShader from 2a86d62642ce to 6683bca5f94e (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/2a86d62642ce..6683bca5f94e 2021-10-21 sergeyu@google.com [Fuchsia] Fix Vulkan compilation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I490d36324f498577a2b014736e049bb99e651504 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3235704 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 66e8faf7 2021-10-20T14:06:08 Remove ProgramExecutable's "isCompute" property. This consolidates the lists of uniforms, ssbos, etc into one. Requires a few checks to change from graphics shader stages into all shaders. Bug: angleproject:6596 Change-Id: Ic8f6bfc4fa295c3bea9f5f1ded11e8fbca1c3164 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233361 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill aac5d678 2021-10-20T11:48:57 Make "isCompute" private to ProgramExecutable. This eliminates uses of "isCompute" is the Vulkan back-end. Instead of checking the state flag, we can use the context of the current command to determine if we're running a compute or a graphics command. This will eventually lead to us being able to compile the program pipeline objects before we run a draw or dispatch command. Changes the driver uniforms descriptor desc to bind to both graphics and compute shader stages to simplify the code. This could have theoretical but low-risk performance implications. Bug: angleproject:6595 Change-Id: Ie30d419b6ece5b33f5066a034d3805fe96519b36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233903 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill bdc633a8 2021-10-20T12:33:42 Pass command type down to ContextImpl::syncState. This mirrors the command type passed to the object sync functions. It will be useful to determine if we're syncing for a draw or a dispatch call. Bug: angleproject:6595 Change-Id: Ia04bd14a3c2dd2eb211c47a6e55f8ddcbfedfaaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233904 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny c621fd97 2021-10-12T20:09:49 Capture/Replay: capture some ProgramPipeline parameters Bug: angleproject:6561 Change-Id: Iff99153c0399f316d973b15fd55821a722401b07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3220634 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny f020c713 2021-10-12T20:29:15 Capture/Replay: Allow capturing Gen/Delete with zero elements This is allowed, and hence the capture/replay should also work. Bug: angleproject:6558 Change-Id: Iae40e2870f9ff121c8396ee4c0caf0905d3fd84c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3220632 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 8b627444 2021-10-13T10:58:40 Capture/Replay: capture program with ActiveShaderProgram too Here the program parameter is the second parameter, so UpdateCurrentProgram needs some refactoring too, to support specifying the parameter position. Bug: angleproject:6560 Change-Id: Iea08e1c0b7271bcd82aba64898cec76c09edefbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3220690 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Cody Northrop b06606b9 2021-10-20T14:45:02 Tests: Add Zillow trace Test: angle_perftests --gtest_filter="*zillow*" Bug: b/203693727 Bug: angleproject:6596 Change-Id: If1a29c452de60b124b234645953a6a8a53a35b67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3235480 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Cody Northrop 5a682795 2021-10-19T18:10:43 Capture/Replay: Fix glAttachShader filtering Dota Underlords capture was filtering shaders that should be active. It is using a pattern that creates shaders in advance, then attaches them in later frames. This requires MEC to setup the shader, but not the program. We were failing to set those active because glAttachShader refers to two ShaderProgramIDs, and we've only been scanning for the first in any given API call: glAttachShader(gShaderProgramMap2[1], gShaderProgramMap2[2]); This CL fixes it by scanning for all ShaderProgramIDs in each call. Test: Dota Underlords MEC Bug: angleproject:5857 Change-Id: I1f76ad3345178cdfeb00479a84489dd363858e13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233875 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tim Van Patten 78ae5d70 2021-10-20T12:15:33 Vulkan: Remove support for GL_RGB8 from DisplayVkAndroid The Android Vulkan loader doesn't support GL_RGB8, so remove it from DisplayVkAndroid::generateConfigs(). The list of supported swapchain formats is available at: https://cs.android.com/android/platform/superproject/+/master:frameworks/native/vulkan/libvulkan/swapchain.cpp;l=465-486?q=GetNativePixelFormat This fixes launching the Zillow app. Bug: angleproject:6277 Change-Id: I34f06e2b45a1de77864701462bf11712285b7ae2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3235466 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
Kyle Piddington 43fd49e6 2021-10-19T14:42:57 Metal: Add Shadow Sampler Grad workaround for AMD This change allows the direct translator to use emulated gradient shadow compare functions for AMD devices, and devices that don't support shadow compare sampler. Bug: angleproject:5107 Change-Id: I8cc8dcb6e6982531c2a858782869283e6dc97052 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3232818 Commit-Queue: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Jamie Madill 5ad7ae4a 2021-10-20T11:15:43 Remove Nexus 5X expectations from dEQP tests. Bug: angleproject:2322 Bug: angleproject:3308 Bug: angleproject:3309 Bug: angleproject:3434 Bug: angleproject:3715 Bug: angleproject:3716 Bug: angleproject:5169 Bug: angleproject:5184 Bug: angleproject:5665 Bug: angleproject:6527 Change-Id: If64efe229e12bb2a0bd4fe7f942899000a7aad76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233902 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 420e77a6 2021-10-20T15:02:45 Revert "Vulkan: Flush descriptor set updates during flush*Commands()" This reverts commit 02b73c2fd738b237f1ab3ecd400feec222903a48. Reason for revert: Causes test to crash on Linux/Intel: anglebug.com/6591 Original change's description: > Vulkan: Flush descriptor set updates during flush*Commands() > > The intent of this CL is to reduce the number of descriptor set updates > by delaying the work until all of the GLES commands that could trigger a > re-update have been performed and the command stream is being flushed. > To achieve this, flushDescriptorSetUpdates() is being moved from > setupDraw()/setupDispatch() to > flushRenderPassCommands()/flushOutsideRPCommands(). > > This change also exposed an issue where the BufferView handles were not > being preserved until flushDescriptorSetUpdates() was called. To resolve > this, flushDescriptorSetUpdates() is also being called during > BufferViewHelper::release() before the BufferView memory is released. > > Bug: angleproject:5706 > Change-Id: I61e19af9c0fac891aa2115d72391459b80d22f19 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939385 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Tim Van Patten <timvp@google.com> Bug: angleproject:5706 Bug: angleproject:6591 Change-Id: I9d1ee3fcb3d1aebc86e60896e0065cab847a92b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233901 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill d8c18ac6 2021-10-08T13:00:19 Re-land: "Isolate commit_id.h from other code." Re-land limits the angle_version deps to Windows to fix an iOS visibility rule violation in GN. Instead of recompiling multiple source files, we can seal off the files that include commit_id to prevent recompilations when the commit changes and source files don't change. Bug: angleproject:2551 Change-Id: I033f00ec7afe4bfd01e29e0eea8848eea27747a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233899 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 4b75345a 2021-10-06T22:47:16 Vulkan: Don't create pipeline with depthWrite if !depthTest depthWrite is ineffective without depthTest. This change makes sure that depthWrite/depthTest combinations of true/false and false/false generate the same Vulkan pipeline. Bug: angleproject:6410 Change-Id: I47e1524379d40dfb956f026903e0affc7f4fc59d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3210628 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Jamie Madill 5ab95ec3 2021-10-20T10:07:10 infra: In milo, split console into 'compile' and 'test'. This will provide an easier-to-read summary for wranglers because test failures will be grouped instead of spread out in between compile builders. Bug: angleproject:6496 Change-Id: I45e2f1a868d887de22133684aa0b4821ed4c8f84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233900 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 0fb59c09 2021-10-18T08:25:26 infra: Remove old bot configs. This can be landed after the change to switch the CQ to the new configs. Bug: angleproject:6496 Change-Id: I3b6ec4697a2fa7a279e5a761ea1717f652af84a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3231835 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll e5dafc33 2021-10-20T11:08:57 Roll SwiftShader from 85101b9ec148 to 2a86d62642ce (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/85101b9ec148..2a86d62642ce 2021-10-20 swiftshader.regress@gmail.com Regres: Update test lists @ 6b700ffc 2021-10-19 srisser@google.com Add VK_KHR_shader_integer_dot_product structs 2021-10-19 swiftshader.regress@gmail.com Regres: Update test lists @ 85101b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I49c11a73546735784c1c9b8d292c499b2ce62313 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3234358 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 9a7b62ad 2021-10-19T15:21:31 Remove glext_angle.h, merge contents into gl2ext_angle.h Currently glext_angle.h file, which is for GLES 1.x, has enums for GL_ANGLE_yuv_internal_format which is an ES 3.0+ extension. Merge contents of glext_angle.h into gl2ext_angle.h and remove glext_angle.h Bug: angleproject:6579 Change-Id: Iec5427af131888a2d9c473f4f497afb71dcafdac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3232822 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 066fb91b 2021-10-18T15:31:27 Vulkan: SPIR-V Gen: Handle scalar(const) produced by index clamp Normally scalar(const) is folded into a constant. The index clamp transformation may produce such a code where the index looks dynamic at first (for example `false ? uniform_value : constant`), but becomes constant after folding. This change makes SPIR-V generation robust in that case. A potential future change could avoid the clamp entirely by making FoldExpressions adjust the op of the EOpIndexIndirect node whose index is being replaced with a constant with EOpIndexDirect (and apply the clamp on the argument). Bug: chromium:1260651 Change-Id: I552b7527d821d1cb52e0e53212cc481285674861 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226311 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll ca127443 2021-10-20T10:01:34 Roll vulkan-deps from fe06f6ff26f8 to 59f9313742fc (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/fe06f6ff26f8..59f9313742fc Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/7f1d926a3a..6351fcef28 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4578db3c41..001604bd4a * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f857c9258c..d3c917b9bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I0a62cbf70784160e839aa8945a12d8caec00fd06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233943 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 660c44db 2021-10-20T07:40:13 Roll Chromium from 0d22e489aa33 to 0d66e54fc44e (485 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0d22e489aa33..0d66e54fc44e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/40338b8d2a..d50a437691 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cc9c74dc19..1acfcd28c1 * third_party/android_build_tools/aapt2: QTle7uOqwUcpHkoK4T62iuIj5-BlSM7NC9sR8su220IC..oJ_fhfmT6sLorimH6Eo6hwWS2R2gU0c4ZUQfXvzae1UC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2d036344bd * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/650f853ced..b6ce244503 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/51064c3ff6..c990ea1afe * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/aec1c87de6..a2b665b90f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b403a49da0..df163762a1 * tools/skia_goldctl/mac: uNABaGj6En3IVtFLWvrw2nXvWtpM4JVX0Yynz3_7Yr0C..s5FQ4at83HB6cms6U4yFCQ-DS8LAIk6BsYD0SYwtiyMC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I8ebe976da6349e7fca82d38b3a7eba52aa284472 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233938 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi ef237faf 2021-10-18T16:22:40 Translator: Validate precision for function args In fragment shaders, float does not have a default precision. Any declaration of this type must therefore specify the precision if a default one is not provided. This was not validated for function arguments. Bug: chromium:1255089 Change-Id: I0d17e226ec88610692ec7dd18793cf4d471f12e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226314 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 02b73c2f 2021-07-14T15:45:47 Vulkan: Flush descriptor set updates during flush*Commands() The intent of this CL is to reduce the number of descriptor set updates by delaying the work until all of the GLES commands that could trigger a re-update have been performed and the command stream is being flushed. To achieve this, flushDescriptorSetUpdates() is being moved from setupDraw()/setupDispatch() to flushRenderPassCommands()/flushOutsideRPCommands(). This change also exposed an issue where the BufferView handles were not being preserved until flushDescriptorSetUpdates() was called. To resolve this, flushDescriptorSetUpdates() is also being called during BufferViewHelper::release() before the BufferView memory is released. Bug: angleproject:5706 Change-Id: I61e19af9c0fac891aa2115d72391459b80d22f19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939385 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Gregg Tavares bf42f009 2021-10-19T11:25:20 Update bug number for point clipping AMD metal Bug: angleproject:6589 Change-Id: Ibc33b9870ab566c2b36caa2b6ccdeb256078d3cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3232286 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gregg Tavares 83bb2705 2021-10-19T15:20:41 Update bug numbers in dEQP test expectations Bug: angleproject:6080 Change-Id: Ic0fa2c41b9a132cdebfd81dfd6137cf6623632c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3232820 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki d3753039 2021-10-14T17:21:47 Reland "RendererVk: Enable VK_KHR_image_format_list on SwiftShader." This is a reland of 8559d50b3b6fcc71b939be4a2c0ca3b48a797d61 Original change's description: > RendererVk: Enable VK_KHR_image_format_list on SwiftShader. > > This reverts commit 08b42714f51dc87e16d52757b4b115037218a4ba. > > Bug: angleproject:5281 > Bug: chromium:1245774 > Change-Id: I773d95225301ccf3c2807fd2269b6d7da1195a16 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3223679 > Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5281 Bug: chromium:1245774 Bug: chromium:1260941 Change-Id: Ic6992bcc4b44aa16a2931271350a6f6d2a23d9c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3232555 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny eee3936b 2021-10-12T20:08:27 libANGLE: Assert on mExecutable when syncing images In the loop in syncImagesInit mExecutable is dereferenced and mProgram is not even touched, so assert on mExecutable Bug: angleproject:6557 Change-Id: Icf482bda281c574e952113a97cbaf1e1d93fc1e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3220631 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill e0de97cf 2021-10-18T08:29:50 infra: Remove SwANGLE bots from CQ. These configs are now included in win-tests and linux-tests. Bug: angleproject:6496 Change-Id: I1ab3961e74bde6672617e4494027da1ff490b352 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226302 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi e637e4c9 2021-10-18T13:54:00 Vulkan: Optimize updating blend state in pipeline desc Updating blend funcs and equations always updated all 8 slots. Now that's only done for the attachments that are present. Bug: angleproject:6298 Change-Id: I58fa7e4dfa27d05fef54cc9d56c7b2aa5ef43dd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3202550 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 7defdb60 2021-10-19T14:07:07 Revert "Isolate commit_id.h from other code." This reverts commit 6d7ebf656d06f1152967aa5f4457d3787a24732c. Reason for revert: Suspected reason for failing ANGLE roll into Chromium Original change's description: > Isolate commit_id.h from other code. > > Instead of recompiling multiple source files, we can seal off the > files that include commit_id to prevent recompilations when the > commit changes and source files don't change. > > Bug: angleproject:2551 > Change-Id: I98800c5a8e04ec7d4c3e57ea0eb3b636d3b224bb > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212895 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Bug: angleproject:2551 Bug: angleproject:6588 Change-Id: I19f41141f57d0683efb9a4ec043e078a9f7dc925 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226056 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Jamie Madill 7fea17b9 2021-10-19T11:08:26 infra: Add new configs to CQ. This leaves the old configs in place. We can't remove them until the CQ bots switch over. Bug: angleproject:6496 Change-Id: Id9ee70cfd65cd85a7525b42f08d78873f31a7cd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226301 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 4bb0a7af 2021-10-18T12:14:04 Vulkan: Async Queue: Fix signal of external semaphores Per the Vulkan spec: > ... when a semaphore wait operation is submitted to a queue: > > - A binary semaphore must be signaled, or have an associated semaphore > signal operation that is pending execution. It is incorrect for ANGLE to defer the submission that signals an external semaphore, because then it's impossible for the application to know when it can wait on the semaphore. Bug: angleproject:6574 Bug: b/172704839 Change-Id: I5469b500b2f7d402acec31d9848585a9947843c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226308 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c9e0da8e 2021-10-18T13:54:00 Vulkan: Improve wording in DeferredClears.md Bug: angleproject:1944 Change-Id: I268e8191cfb7aeb16e33c1f9b39382461c5ac3e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226310 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Weiwei Lin aa630727 2021-10-18T00:16:51 [milo] migrate to new bug_url_template The old way of specifying bug template is deprecated. R: geofflang, jmadill Bug: chromium:1218698 Change-Id: I1b3dc9b4ebb3bdcbd6a1f574209f30a8b27f129e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3230302 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny 1d1b7573 2021-10-13T09:24:53 Capture/Replay: Skip binary formats test when none are supported During capture/replay the number of supported binary formats is set to zero, so the test can't run successfully, hence skip it. Bug: angleproject:6559 Change-Id: Iabff38669bd6bbbbec770888ae940be3961b136e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3220633 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll a213d0d2 2021-10-19T10:01:34 Roll vulkan-deps from a9d8c46f2b61 to fe06f6ff26f8 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a9d8c46f2b61..fe06f6ff26f8 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b9ba4c5743..7f1d926a3a * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/35fd0e17d0..4578db3c41 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/61688e09fe..f524349518 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/78b1f89454..f857c9258c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I4ce4d083db48202aa306b7d5f8fda580cbd460b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3230337 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b8131bf4 2021-10-19T10:01:56 Roll SwiftShader from 33eaf1f76b60 to 85101b9ec148 (7 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/33eaf1f76b60..85101b9ec148 2021-10-19 capn@google.com Avoid SPIR-V binary identifier clashes 2021-10-19 capn@google.com Avoid recompiling identical SPIR-V binaries 2021-10-19 capn@google.com Store the SPIR-V binary of a vk::ShaderModule in an sw::SpirvBinary 2021-10-18 sugoi@google.com Fix uninitialized memoryOwner on unused DescriptorSet 2021-10-18 sugoi@google.com Fix BC6h decoder 2021-10-18 sugoi@google.com Fix blitting of various packed formats 2021-10-18 srisser@google.com Update Vulkan headers to version 1.2.196 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I901482bde712e84c14748436fdcb25da57df4595 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3230336 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2e0e9e8a 2021-10-19T07:01:14 Roll Chromium from 54930e1ff6ee to 0d22e489aa33 (634 revisions) https://chromium.googlesource.com/chromium/src.git/+log/54930e1ff6ee..0d22e489aa33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3df8a59b75..40338b8d2a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a9bc3e2831..aa2fb0187c * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/198699532a..025086bfe7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/faf29ca944..cc9c74dc19 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2d036344bd * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/335fe83e13..9215e8e1d0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/eff3136246..aec1c87de6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/de168d1b50..b403a49da0 * tools/skia_goldctl/mac: s5FQ4at83HB6cms6U4yFCQ-DS8LAIk6BsYD0SYwtiyMC..uNABaGj6En3IVtFLWvrw2nXvWtpM4JVX0Yynz3_7Yr0C No update to Clang. Bug: angleproject:6501 Tbr: syoussefi@google.com Change-Id: I37c0d584aa61e15860a5544e1310e97132e58e4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3230333 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 7f87a326 2021-10-18T13:06:29 Vulkan: SPIR-V Gen: Fix crash in array of struct constant Bug: chromium:1260690 Change-Id: I51fe85a2ebc23c3fcaa3c961c4ebf84688bbed31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226309 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 9a323cd0 2021-10-18T22:02:46 Vulkan: Suppress failing test on AMD/Linux EXTBlendFuncExtendedDrawTest.FragData/* has started flaking for an unknown reason. This test has multiple suppressions for the Vulkan backend on different hardware. Bug: angleproject:6585 Change-Id: I7b97c8210a0846bbc6935812fcad743291c516be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3230522 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi bb0e0dea 2021-10-18T21:46:44 Roll vulkan-deps from 5be75e2ae595 to a9d8c46f2b61 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5be75e2ae595..a9d8c46f2b61 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/06ebc4806b..35fd0e17d0 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/6d9e5b07d6..61688e09fe * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/77cd59ba80..78b1f89454 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:6584 Change-Id: I8da9da9f82ccaf781d89a4f7975fb7520d3b6b28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226052 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop e2e77baa 2021-10-18T16:04:43 Revert "Revert "Translator: Remove the SH_VALIDATE flag"" This reverts commit 701e8892f45e6f416dcbb0d23a155d346d0280fa. Reason for revert: Chromium dependency fixed in http://crrev/c/3214440 Original change's description: > Translator: Remove the SH_VALIDATE flag > > The SH_VALIDATE flag is a noop, defined as zero (0). > > Also move option descriptions up in the file. > > Bug: angleproject:6501 > Change-Id: I898106eb68b4508d8f94534cbff66652a69f4f3e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3207360 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Cody Northrop <cnorthrop@google.com> Bug: angleproject:6501 Change-Id: I4d1514d6ac04e5bedf3624facf8e9339828fa291 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3229955 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 670b58d8 2021-10-18T19:50:10 Revert "RendererVk: Enable VK_KHR_image_format_list on SwiftShader." This reverts commit 8559d50b3b6fcc71b939be4a2c0ca3b48a797d61. Reason for revert: Causes MSAN failures. See crbug.com/1260941 Original change's description: > RendererVk: Enable VK_KHR_image_format_list on SwiftShader. > > This reverts commit 08b42714f51dc87e16d52757b4b115037218a4ba. > > Bug: angleproject:5281 > Bug: chromium:1245774 > Change-Id: I773d95225301ccf3c2807fd2269b6d7da1195a16 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3223679 > Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5281 Bug: chromium:1245774 Bug: chromium:1260941 Change-Id: Id6712aed68ed04d2525549ae016594aa05243a5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226312 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten eb1d2474 2021-10-04T20:23:26 Vulkan: Add R8G8B8_UNORM to vk_format_map.json The map of R8G8B8_UNORM -> VK_FORMAT_R8G8B8_UNORM is missing from vk_format_map.json. This leads to attempting to get format bits for angle::FormatID::NONE / VK_FORMAT_UNDEFINED. This CL adds R8G8B8_UNORM to vk_format_map.json, so devices that support it, like ARM, can use it. This allows those devices to import AHBs created with R8G8B8_UNORM. This CL also adds some additional ASSERT() and UNREACHABLE() calls to catch missing formats sooner. This allows the EGL tests to pass on ARM devices, but the tests are still skipped due to Qualcomm not having the necessary support for optimal tiling. Bug: angleproject:6277 Test: dEQP-EGL.functional.image* Change-Id: I41b7ead97a10ae80be4b6048d36d0d85ad71784f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3204152 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 8996b1e6 2021-10-18T12:13:09 Vulkan: Suppress failing async queue tests Bug: angleproject:6574 Change-Id: I2da6c65a43cc53bd6100c7be1a325d56766a175a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226307 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Peter Kasting bcd3ae61 2021-10-18T09:36:49 Fix some instances of -Wshadow. Bug: chromium:794619 Change-Id: I5efe04e64800455585438467bcf6c262e91f398d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3229095 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shannon Woods f7cbca80 2021-10-18T12:33:14 Update link to old presentation Bug: angleproject:1944 Change-Id: I750bfe9fd15c51dbc0f2acc8da966cfdb07f51e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3229428 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 6d7ebf65 2021-10-08T13:00:19 Isolate commit_id.h from other code. Instead of recompiling multiple source files, we can seal off the files that include commit_id to prevent recompilations when the commit changes and source files don't change. Bug: angleproject:2551 Change-Id: I98800c5a8e04ec7d4c3e57ea0eb3b636d3b224bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212895 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi ddedcdaf 2021-10-14T23:35:45 Vulkan: Recycle vkAcquireNextImageKHR semaphores This change optimizes CPU performance by recycling semaphores used for ANI instead of creating and deleting them every frame. Bug: angleproject:6580 Change-Id: I151ea227870ed7b8bd123cbf629a65723c4696d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3225085 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 87b4f0fb 2021-10-18T08:52:29 Suppress colorspace trace tests. These were recently enabled with a Vk SwiftShader CL. Bug: angleproject:6578 Change-Id: I5f6716f3c8a4c314d0679f8393532b25f9f5c032 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226303 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi f3334d03 2021-09-30T23:44:54 Vulkan: Fix importing layered AHBs Bug: angleproject:6475 Change-Id: Iceb0880cadc54552d3f01593d2e12088cafa10cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3198733 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 8fbce1e0 2021-10-18T10:01:55 Roll SwiftShader from ce1449fd798a to 33eaf1f76b60 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/ce1449fd798a..33eaf1f76b60 2021-10-15 liyl@google.com Use smart pointer for the LibX11Exports singleton 2021-10-15 swiftshader.regress@gmail.com Regres: Update test lists @ ce1449fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I6af8147eea2731f900481ad0024a5a60418e1fa5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3229013 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 485cb718 2021-10-15T23:45:02 Roll Chromium from 9fcbc0940fc3 to 54930e1ff6ee (222 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9fcbc0940fc3..54930e1ff6ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7694937a1e..3df8a59b75 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/03fbde054b..faf29ca944 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..59de2526fa * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a36d697d8..650f853ced * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c64ca6a1cc..eff3136246 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cf5ad1a309..de168d1b50 No update to Clang. Bug: None Tbr: jonahr@google.com,ynovikov@google.com Change-Id: Ie803eb43a59de40b0dfb6b458e5be22af63c54e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3227701 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott 6c448659 2021-10-15T15:43:18 Improve EGL validation errors Improvements: - Report the numeric value of a bad attribute - Show the requested/desired/unsupported version and the max version - Correct printf attribute set and previous errors fixed Bug: b/186543601 Change-Id: I889f2384afbe134496cad9e349766b7ff756dcee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3224566 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Kenneth Russell 4d571129 2021-10-15T16:27:05 Suppress ObjC exceptions in OSXWindow::messageLoop. Crashes have been seen inside the Cocoa-internal NS_setFlushesWithDisplayLink function. Web searches indicate this is a regression in macOS 11. See whether catching and ignoring these exceptions improves stability. Bug: angleproject:6570 Change-Id: Id0be68077163bf4e9f98189461eea016a35edd73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3227697 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Gregg Tavares eb9b3f8e 2021-10-14T17:10:23 Update bug for intel metal mip test expectations Bug: angleproject:6571 Change-Id: I3a7c46ad479b4fc5d15e261269a12742c841a955 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3224101 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Gregg Tavares 6cd1a0a5 2021-10-14T17:32:42 Metal: Update test expectations for AMD filtering issue Also adjust suppressions for incorrect lodMinClamp application on Intel GPUs. Bug: angleproject:6466 Bug: angleproject:6534 Bug: angleproject:6571 Change-Id: I574e0e92111c8d0a6021fe90f7a2076103435975 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3224662 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Charlie Lao 22ecd454 2021-07-19T17:28:05 Vulkan: Move BufferMemory class from vk_helpers.h to vk_utils.h In preparation for the StagingBuffer may also use BufferMemory, this CL moves the class to vk_utils.h so that it can be used by any class without create kinks on header file inclusion. Bug: b/195588159 Change-Id: I97ab136be691322fe6284fd1b4b7336fdf1f904f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3040106 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jonah Ryan-Davis 60271a71 2021-10-15T10:14:35 GL: Re-scope Intel/Mesa version for disableSyncControlSupport. This workaround's scope was widened due to issues detecting intel GPUs in systems with multiple GPUs. That was fixed, so we can re-scope the workaround. Bug: chromium:1187475 Change-Id: Iaf946369273dc5c1e2f8f91a14758b6751615c7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226721 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi f5d65922 2021-10-14T15:58:38 Vulkan: Optimize QueryVk::getResult() This function always incurred a check for completed commands to ensure forward progress for applications (or rather, tests) that busy-wait until the query results become available. This change instead does an initial isCurrentlyInUse() check and only if that's true will it check to see if there are any finished commands. This should reduce one checkCompletedCommands() call when the application queries the status of the Query well after it's issued. Based on patch authored by Igor Nazarov <i.nazarov@samsung.com> Bug: angleproject:6573 Change-Id: Iad4ed6b7eb6ae5316707e6d916e5ca3054d6c5aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3225083 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6f69986b 2021-10-15T15:43:05 Roll Chromium from b35194229662 to 9fcbc0940fc3 (624 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b35194229662..9fcbc0940fc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e55f2dd692..7694937a1e * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/0054d1d20c..198699532a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5a3fcbea80..03fbde054b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9b3ab9c811..e7c7291277 * third_party/android_build_tools/aapt2: O9eXFyC5ZkcYvDfHRLKPO1g1Xwf7M33wT3cuJtyfc0sC..QTle7uOqwUcpHkoK4T62iuIj5-BlSM7NC9sR8su220IC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..59de2526fa * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9fe4fb87a6..9a36d697d8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c00aa10009..51064c3ff6 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/256755a787..c64ca6a1cc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bae49e6b9d..cf5ad1a309 Clang version changed llvmorg-14-init-6355-gb2217b36:llvmorg-14-init-6722-g0fbd3aad Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/c00aa10009548ad073810d810cc4a71d2965f75b..51064c3ff683079293f80d071a9a726858fbaa12/scripts/update.py Bug: angleproject:2551 Tbr: jonahr@google.com,jmadill@google.com Change-Id: Iae0b73913324695c874fddb3eb76c75dcd54bb9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3225995 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Charlie Lao 8ef1b2a2 2021-07-15T15:27:15 Vulkan: Add BufferMemoryAllocator class BufferMemoryAllocator class will be responsible for memory allocation for vkBuffers. The original Allocator class remains the wrapper for vmaAllocator. Bug: b/195588159 Change-Id: I26d016e2f8d13ba459d0aa0bd4e1ebf4d0d48251 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3036256 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 0c7018a5 2021-10-12T13:43:20 infra: Update bot naming scheme. Old names: use config pairs when they can vary, e.g. android-arm-dbg android-arm64-rel linux-clang-dbg win-clang-x64-rel win-msvc-x86-dbg win-trace-rel New names: use config names when they differ from the the default test config for a system, and suffix with -compile and -test for compile-only and compile-and-test bots. For Android configs, we keep the full target arch. e.g. android-arm-dbg-compile android-arm64-test linux-dbg-compile win-test win-msvc-x86-dbg-compile win-trace The new naming scheme prioritizes having short names to avoid redundant or implicitly understood information. This should reduce the mental load when looking at a set of test results. This also adds SwiftShader win10-x64 configs so we can add these to the CI easily. Also the plan is to turn off the GCC configs for now. If we ever support GCC properly we can re- enable them. This CL adds the new configs to CI, then a following CL will add them to CQ and remove the old configs at the same time. Bug: angleproject:6496 Change-Id: I0ecdcd392c4d7067d6b180664f160ba7c048d16d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3219590 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 7aba3bc5 2021-10-14T23:14:37 Vulkan: Use a CircularBuffer helper class in SurfaceVk There are two instances of circular buffer in SurfaceVk. A common helper class is introduced by this change to consolidate the implementation. This is in preparation for a follow up change that introduces yet another circular buffer in this class. Bug: angleproject:6401 Change-Id: Id01b585567310a2528888114239a5c80ff93f1ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3225084 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 58b47b19 2021-10-15T09:50:55 GN: Disable SwiftShader by default with MSVC. This was broken as fallout from http://crrev.com/c/3189512 and is currently breaking the Chromium -> ANGLE roll. Instead of trying to fix the warnings, disable compiling SwiftShader with MSVC. Bug: angleproject:6572 Change-Id: I041a4366b348b77f8213802495dd88c4050a714c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226720 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 9e100e54 2021-10-15T10:01:34 Roll vulkan-deps from 6fb1e5bb439b to 5be75e2ae595 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6fb1e5bb439b..5be75e2ae595 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3e6a85303d..06ebc4806b * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e8b24f02d1..7001f2eb37 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4defcad9cd..77cd59ba80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ie756b9b4628e5e74de588302297165140446782d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3225994 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a425ccea 2021-10-15T10:01:55 Roll SwiftShader from e0af842a439e to ce1449fd798a (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/e0af842a439e..ce1449fd798a 2021-10-14 sugoi@google.com Fix Depth+Stencil image copy 2021-10-14 sugoi@google.com Fix blitting of compressed images 2021-10-14 sugoi@google.com Make decompression functions const If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ieb1cbf0862bc59b7c367689710652f9e1ff0a01e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3225949 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 57b73c07 2021-10-14T15:51:18 Vulkan: SPIR-V Gen: TODO clean up This change removes a number of stale TODOs. Bug: angleproject:4889 Change-Id: If21d55717e61383ffdd58a7f88da5961988e035f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3223643 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi ca75c7bb 2021-09-29T16:28:11 Vulkan: Fix async queue testing Due to a feature renaming, the async queue tests where actually ran without the required feature that makes them async. This change fixes the feature name so async queue testing will be resumed. Bug: angleproject:6437 Change-Id: I73c9c8cd196576455265f72144399a93edc82bdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3193420 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 123ba58d 2021-10-14T11:56:35 Vulkan: Remove "last submitted serial". This fixes race conditions with the async command processor. Instead of querying specific serial numbers, we ask the command queue to either wait for idle, or return the answer to "are you busy" directly. Bug: b/172704839 Change-Id: I06a8268d9b58d8c33b783af00ca74979ee158316 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3223641 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b3d77208 2021-10-14T15:38:51 Vulkan: SPIR-V Gen: Make unfolded constants SPIR-V constants If a constant is not folded by the translator, for example because it's an array, this change makes sure that it becomes a constant in SPIR-V anyway. This is particularly important to support cases where a constant is required, for example as argument to textureGatherOffsets(). Bug: angleproject:4889 Bug: angleproject:5362 Change-Id: Ic43e4be13a8917bb100ea64902ba90048cfbb9ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3223642 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
YuxinHu 2aa5286d 2021-10-12T17:05:48 Add Entry Point name to validation errors Add gl/gles entry point names to validation error messages some special cases: 1. Debug::insertPerfWarning() is invoked from multiple places, such as TextureVK, ContextVK, adding an extra entryPoint function parameter in these files will need extra investigations. I am passing the entryPoint name GLInvalid as a temp workaround. 2.ErrorSet::hangleError() is invoked from multiple Context*.cpp files, adding an extra entryPoint function parameter in these files will need extra investigations. I am passing the entryPoint name GLInvalid as a temp workaround. 3. Debug::insertMessage(), Debug::popGroup(), Debug::pushGroup() can be invoked from more than one GL entry points, e.g. Debug::pushGroup() can be invoked from either GL_APIENTRY GL_PushDebugGroup() or GL_APIENTRY GL_PushDebugGroupKHR() through context->pushDebugGroup() call. Right now the same entry point name glPushDebugGroup will be printed out in the error message for both cases. However, we should be able to tell the actual entry point by checking which version: KHR version or core version the application uses, and this helps avoid the confusion. For now we will let the same entry point name getting printed for both cases. Bug: angleproject:6523 Change-Id: I64a5463d9168d8444d376d1f428c3b3d894f2ea9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3215063 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Kenneth Russell 9d3ec7d7 2021-10-14T13:50:59 Mac: suppress frequent test flakes on OpenGL backend. Mac/NVIDIA: ClearTest.ChangeFramebufferAttachmentFromRGBAtoRGB This test is crashing very frequently for an as-yet-unknown reason. The NVIDIA MacBook Pros are not a critical testing configuration, so skip this test for the time being to stabilize the CQ. Mac/Intel: WebGLCompatibilityTest.L32FTextures WebGLCompatibilityTest.R32FTextures WebGLCompatibilityTest.RGB32FTextures These tests are occasionally failing with incorrect rendered pixel values again for unknown reasons. Mark these as failing on this configuration for the moment. Bug: angleproject:6570 Change-Id: Ic9e3c5f8d06a1555a4b1dfed2d9495e98c32abf1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3224361 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 1dc2b702 2021-10-13T16:02:37 Vulkan: Pass shader module map to init pipelines. Instead of pulling out the shader modules from the shader map when we start the call chain, pull them out right in the init call. This saves a bunch of boilerplate code. Refactoring change only. Bug: angleproject:6566 Change-Id: Ib8d79bd7284d7ddb83522270f3d4df9086ab7300 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3221134 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lingfeng Yang 2615e6b2 2021-10-07T07:07:46 Remove the syncFramebufferBindingsOnTexImage workaround It's unused Bug: angleproject:6503 Change-Id: Ia9039432006ec6988e93db08b9a572c7a7f837ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212428 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 06a4ce3b 2021-10-14T17:57:37 Roll vulkan-deps from bd01823faf6f to 6fb1e5bb439b (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bd01823faf6f..6fb1e5bb439b Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/97a438d214..e4243b898c * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/5ea2d62e8c..19e8350415 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b46995741b..3e6a85303d * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/fa27a13cf7..dd99e0f51f * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/aeffbbd6b9..6d9e5b07d6 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4ddd7fa6ed..4defcad9cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com,ynovikov@google.com Change-Id: Idf504a62c90f415d6456ce31d4c2299e4e848245 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3224099 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Lubosz Sarnecki 8559d50b 2021-10-14T17:21:47 RendererVk: Enable VK_KHR_image_format_list on SwiftShader. This reverts commit 08b42714f51dc87e16d52757b4b115037218a4ba. Bug: angleproject:5281 Bug: chromium:1245774 Change-Id: I773d95225301ccf3c2807fd2269b6d7da1195a16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3223679 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cheryl Wei b95cdec3 2021-10-12T11:26:15 Vulkan: Switch to `std::unordered_map` to cache renderpass ANGLE use `flat_hash_map` by default,while it will not retain pointer stability which causes random null pointer issue when running MH31 with asynccommandqueue.This change switch to using `std::unordered_map` to cache renderpass. Bug: angleproject:6436 Bug: angleproject:6569 Change-Id: Ia2829a41251eea39ce2a79a9a42b6fe9dff6b120 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3219010 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll b30dc00c 2021-10-14T12:58:55 Roll SwiftShader from ca2ada82f494 to e0af842a439e (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/ca2ada82f494..e0af842a439e 2021-10-14 srisser@google.com Remove LOG_TRAP 2021-10-13 thakis@chromium.org Disable -Wbitwise-instead-of-logical for llvm-10.0 in swiftshader 2021-10-13 swiftshader.regress@gmail.com Regres: Update test lists @ ca2ada82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I46ff112a3d11b629f11e7c0465b597a82152d461 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3223301 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9f179f86 2021-10-14T08:09:13 Roll Chromium from a3c5add36792 to b35194229662 (448 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a3c5add36792..b35194229662 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/edba8be55a..e55f2dd692 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9eb0245224..0054d1d20c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8eb878544b..5a3fcbea80 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/099aba70f7..9b3ab9c811 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/26700faf76..93c5e2d335 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e608069579 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/756e98f5aa..9fe4fb87a6 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/add20af232..6e73e226c4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a8ec5ddc8a..bae49e6b9d No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I740af5e0f2d48b3be0abfaf0e39f38cf36e98069 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3222465 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi f3d5dac3 2021-08-23T17:25:15 Vulkan: SPIR-V Gen: Drop dependency to glslang The SPIR-V gen path is now made default. Compilation through glslang is still supported for debugging, and is enabled on the GLSL* end2end tests for smoke testing. On release builds, glslang is not supported. To test with glslang, add the following gn arg (only necessary if dcheck is disabled): angle_enable_spirv_gen_through_glslang = true Then enable the generateSPIRVThroughGlslang feature. This can be done by setting an environment variable: ANGLE_FEATURE_OVERRIDES_ENABLED=generateSPIRVThroughGlslang ./angle_deqp_gles2_tests Binary size saving: - 1.3MB on Linux (SPIR-V gen itself: 240KB) - 730KB on Android (SPIR-V gen itself: 140KB) Perf tests: - LinkProgramBenchmark.Run/vulkan_compile_single_thread * Through glslang: truncated mean: 1287033.36 * Direct SPIR-V Gen: truncated mean: 244495.91 (~80% reduction) - LinkProgramBenchmark.Run/vulkan_compile_multi_thread * Through glslang: truncated mean: 4565894.83 * Direct SPIR-V Gen: truncated mean: 1158164.10 (~75% reduction) Bug: angleproject:4889 Bug: angleproject:6210 Change-Id: I486342702977c8114e90073b97183aba115a8b2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3115140 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Aditya Kushwah d8471b29 2021-10-02T10:36:33 Fix ASAN bug caused by passing empty label string. This CL will fix the ASAN bug that was caused by passing empty label string to getMultisampledRenderTarget, function of TextureStorage11. Instead, pass mTextureLabel so we can get WebGL labels now. Also to avoid this in future, convert ref mTextureLabel to now store copy. The change in the test reflects the steps to first set the label string and later the label being used to initialize mTextureLabel via texture storage creation. Bug: chromium:1254746 Change-Id: I007bdf1c7a421a2b4b9288aa71fa4368c14cf333 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3201030 Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
YuxinHu bf744752 2021-10-04T23:57:15 README.md maintenance -Mark the document OpenGL Insights chapter on ANGLE as historical reference. -Modify the visual studio build instruction in ANGLE'S orientation link. -Point the Start Projects link to the angle starter bug lists. -Remove doc/Starter-Projects.md. (most bugs listed in Starter-Projects.md are closed. mark bugs 2734, 2556, 2506 as starter bugs. remove link to WebGL conformance on Windows as they are outdated) -Remove IRC channel join info. -Add more instructions on how to join Angle Slack channel. -Add warning indicating the iframe tags are not displayed properly in doc/dEQP-Charts.md. Bug: angleproject:6509 Change-Id: Idd4364fe48b506b44d3a2b40fa0e6ebd9e810a1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3204132 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
YuxinHu d4c7b594 2021-10-12T23:24:54 Add fixes on the doc based on Jamie's Suggestions This is a follow up change based on comments Jamie provided in a previous change list: https://chromium-review.googlesource.com/c/angle/angle/+/3204430. Fixes include: 1. Wrap each line into 80 characters. 2. Add links to project files. 3. Add one more future work. 4. Modify the two simple wordings. Bug: angleproject:6508 Change-Id: I84a5694682d8871ebb46c4dfe245399021e0cff7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3219715 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao ea580484 2021-10-05T13:40:01 Vulkan: Add feature flag to prefer CPU copy instead of staged update For ARM GPU, use GPU to do buffer to buffer copy has performance penalty due to potential bubble in the vertex pipeline. This CL adds a feature flag preferCPUForBufferDataSubData so that we can enable this behavior for ARM GPUs. This CL also tracks if GPU has referenced this BufferVk's storage since it got new storage. Due to sub-allocation, we may get a new sub-range of the same BufferHelper object when allocating new storage. But we currently do not have a way to track GPU progress of the sub-range of a buffer. So we will end up using BufferHelper's queueSerial to decide if it is still GPU busy or not. This CL adds mHasBeenReferencedByGPU boolean variable that will set to false when we got a new allocation and set to true as soon as buffer is been referenced by any GPU command. We use this to avoid checking queueSerial if it never been referenced by GPU. This is a temporary workaround for the bug, the full fix is tracked by https://issuetracker.google.com/201826021 Bug: b/200067929 Change-Id: I231fb0a678b0165a2ce1775d0aa4dbe7512fb4a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3183398 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Charlie Lao 9a48ad4e 2021-10-05T17:45:48 Vulkan: Add test for acquireAndUpdate Add two new tests to IndexBufferOffsetTestES3 tests that will call bufferSubData with more than 1/2 buffer size, which will force vulkan backend go into a different code path. Bug: b/200067929 Change-Id: Id831982bbb044a529e9711be62d82f3e8c05e1a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3213415 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jonah Ryan-Davis 7d1b12eb 2021-10-12T15:54:57 Clean up PlatformMethods enum allocation EGL_PLATFORM_ANGLE_PLATFORM_METHODS_ANGLEX was allocated to 0x3482 without reserving an enum in the ANGLE drive. This value was later used for EGL_POWER_PREFERENCE_ANGLE, causing a collision. This CL re-allocates the enum. Bug: angleproject:6105 Change-Id: I0da95dbd307954e2f7f5107d0179d580ec536f2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3219591 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill 100ebfd7 2021-10-13T12:07:21 Revert "Re-enable PoolAllocatorAlignmentTest.Alignment" This reverts commit 7eada73ac4964df5ffd539efb7a0569a97e4fd3d. Reason for revert: Breaking Lollipop tester likely b/c of 32-bit issues. Bug: chromium:1259544 Original change's description: > Re-enable PoolAllocatorAlignmentTest.Alignment > > The PoolAllocatorAlignmentTest.Alignment/64 variant of the test fails on > windows/debug, so this change re-enables this test everywhere except for > that variant (and speculatively /128) on windows. > > Bug: angleproject:6536 > Change-Id: Ibc4fcbe04e7579f3ad7eb68f4f460078ee27ac88 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212329 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:6536 Change-Id: I74ebf1c78c8b15c14c9d1496948adafd13e0d2ba No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3220971 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 558eda6e 2021-10-12T15:34:45 Vulkan: Remove provoking-vertex structs from "custom" list This extension has been released. Bug: angleproject:4063 Change-Id: I007c20a895819aa11382837a3ad654839e127365 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3217938 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny bb5dbd49 2021-10-05T11:57:44 Capture/Replay: Handle TvoidPointer in specialization Bug: angleproject:6521 Change-Id: I863ad5307498e6394f5fbe3e650ce29c821083b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3204960 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll f25d1b21 2021-10-13T10:01:34 Roll vulkan-deps from 0d9dbc23381d to bd01823faf6f (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0d9dbc23381d..bd01823faf6f Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1230a564c7..4ddd7fa6ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I755e89ae0a5937cb9805cee31057c70290a7b27b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3220244 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 69730164 2021-10-13T10:01:55 Roll SwiftShader from b0f8eb113c65 to ca2ada82f494 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/b0f8eb113c65..ca2ada82f494 2021-10-13 sugoi@google.com Fix border update when rendering to cube face 2021-10-12 capn@google.com Revert "Kokoro: Disable gcp_ubuntu builds failing to update CMake" 2021-10-12 sugoi@google.com Regres: Roll dEQP to master revision e2aeccd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Id506f3aa88c51afc3b00bcacacc376ee2dd60e5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3220126 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f8b1306f 2021-10-13T07:30:13 Roll Chromium from 98d6c07f2252 to a3c5add36792 (519 revisions) https://chromium.googlesource.com/chromium/src.git/+log/98d6c07f2252..a3c5add36792 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ed0a6d903d..edba8be55a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/69da32119f..8eb878544b * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/49fa1a3684..26700faf76 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2ef79f5f33 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4a06fb5432..756e98f5aa * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/cb29a121b4..0c48c93118 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/edc0e0684f..6da1d53b97 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/203feb7891..c00aa10009 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c3e712a10a..256755a787 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7ba7d556a2..a8ec5ddc8a Clang version changed llvmorg-14-init-5759-g02895eed:llvmorg-14-init-6355-gb2217b36 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/203feb789163278951e55ffeb624d70e016508e3..c00aa10009548ad073810d810cc4a71d2965f75b/scripts/update.py Bug: angleproject:6527 Tbr: jonahr@google.com Change-Id: I2d04180c7bbd93afb078a3a11e559e134839e8f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3220235 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 43be4d9c 2021-10-11T13:50:28 Vulkan: Fix unnecessary performance warnings for two tests Fix two existing tests so that it wont generate performance warnings that is not related to the test and not intended anyway. Bug: b/200067929 Change-Id: I64a9272be077c536627644ae44104d98cecee7cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3218270 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 7eada73a 2021-10-07T11:09:50 Re-enable PoolAllocatorAlignmentTest.Alignment The PoolAllocatorAlignmentTest.Alignment/64 variant of the test fails on windows/debug, so this change re-enables this test everywhere except for that variant (and speculatively /128) on windows. Bug: angleproject:6536 Change-Id: Ibc4fcbe04e7579f3ad7eb68f4f460078ee27ac88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212329 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Charlie Lao 6793d50e 2021-10-06T15:48:55 Vulkan: Remove ImageHelper::setFirstAllocatedLevel and Add assertion ImageHelper::mFirstAllocatedLevel is set via ImageHelper::initExternal. There isn't a good use to set the mFirstAllocatedLevel when mImage is invalid, and semantically it is wrong to try to get mFirstAllocatedLevel or format while its storage is invalid (i.e., not allocated). This CL removes ImageHelper::setFirstAllocatedLevel() API all together and added assertion that image is valid when ImageHelper::getFirstAllocatedLevel and getActualFormat and various other get APIs whose value are set during initExternal call. Bug: angleproject:6532 Change-Id: I9c97f488b3e959443fec632540e7f0906a49dc13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3209838 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 185e48a7 2021-10-06T18:53:08 Vulkan: Make TextureVk::mRedefinedLevels bitmask of gl::LevelIndex We have gl::LevelIndex and vk::LevelIndex. gl::LevelIndex means level index at OpenGL concept and is used in TextureVk code. vk::LevelIndex means already adjusted with baseLevel and is used by ImageHelper object. This mRedefinedLevel is gl::TexLevelMask type, but it actually is a bit mask of vk::LevelIndex right now. This is inconsistent and confusing. This CL changes it to bit mask of gl::LevelIndex to be consistent with the namespace of "gl". Bug: angleproject:6532 Change-Id: Ic88e373f70d3bd3e3fea676765c82fd0941e245c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3210726 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Steven Noonan 01341f94 2021-10-11T19:26:07 D3D11: implement EXT_clip_control This implements EXT_clip_control for the D3D11 renderer, so that I can use a reversed-Z depth buffer with ANGLE. Tested with angle_deqp_gles2_tests.exe --deqp-egl-display-type=angle-d3d11 --deqp-case=dEQP-GLES2.functional.clip_control.* and angle_end2end_tests.exe --gtest_filter=*D3D11* Bug: angleproject:6554 Change-Id: I1d11cd04a6654c28530b11104470f0cad0009abe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3218659 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0