kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 49a1d9ff 2021-08-23T10:01:58 Roll vulkan-deps from 1dec6c3c106b to 1262ad6fdd3f (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1dec6c3c106b..1262ad6fdd3f Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/bab4e5911b..c062b6b852 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b3f17dc515..931cff66d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I0eaa013fb32dd07d2d223ada25d37dc1eae73f40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3113446 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 210773db 2021-08-05T10:41:59 Translator: Be more explicit about precisions GLSL ES requires that every symbol (variable, block member, function parameter and return value) is appropriately qualified with a precision, either individually or through the global precision specifier. Some tree transformations however produced symbols with EbpUndefined precision. In text GLSL output, these would produce unqualified symbols which was often incorrect. In this change, the transformations are made to produce explicit / more consistent precisions. The validation (that caught these issues) is not included in this change as there are still a few corner cases left to address. Bug: angleproject:4889 Bug: angleproject:6132 Change-Id: Icca8a0a5476f8646226e7243aa8f501f44acc164 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3075127 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll b9709a46 2021-08-23T07:01:15 Roll Chromium from 873a11ee2df8 to 2136fe7a73f0 (293 revisions) https://chromium.googlesource.com/chromium/src.git/+log/873a11ee2df8..2136fe7a73f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4636eb3d7e..3d596a3537 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e4b161d43b..ffda0347a4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/07ee0ecea6..56ae8bbfb2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ebf22ea4f9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2b4ec95534..52b4510cde * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4893aadcb6..35d7ec7c98 No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: Ia5878d8d3c3ff27e2fe03b7cacb510a9a57e929b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3112653 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 8c05fd4f 2021-08-21T23:03:16 Add ASTC & PVRTC to GLenumToString Bug: angleproject:4093 Change-Id: Iab19fddd2e0680a39741d2ef0b9003af5a808d49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3110552 Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Jamie Madill 2f45d93d 2021-08-18T16:58:44 Capture/Replay: Init shader outputs during self-tests. This forces all uninitialized variables to have default values. For instance if the application doesn't initialize the output color, or a varying that's use in the output, this will ensure we don't use any undefined values in the computation. Found when working on a re-trace of T-Rex, which doesn't write to the alpha channel in the final rendering pass. Also fixes undefined values in GLSLTest.InactiveVaryingInVertexActiveInFragment. Bug: angleproject:5133 Change-Id: Ia291338e5adf23dab5263cb2ebe737dc05852d3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3110225 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill b196eec0 2021-08-20T12:32:03 translator: Fix InitializeVariables with gl_ClipDistance. The extension allows for the shader to redeclare this variable with a different size. This would sometimes put the tree in an inconsistent state when used with the InitializeVariables feature. Fix this by using the user declaration of gl_ClipDistance when available. Found when working on trace validation, where using the init output variables option in the compiler would then cause tree validation to fail for one specific test. Test: ClipDistanceTest.ThreeClipDistancesRedeclared Bug: angleproject:5133 Change-Id: I42c9bfbe313826ac5d391068d9fc18eb5793375f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3110752 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e30dd478 2021-08-20T17:10:51 infra: Update Milo perf short names. Use the name of the Android device or GPU manufacturer. Bug: angleproject:6090 Change-Id: I2e26586578c51f9a714fed23586854bb14030242 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3111028 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6a956ef9 2021-08-20T17:04:01 infra: Update angle_mb_config.pyl with new perf names. Was missing from the prior CL. Bug: angleproject:6090 Change-Id: I454605fad48690a2d84a2fe3a436140931e2cb9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3111027 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll ba6b8287 2021-08-20T18:58:42 Roll Chromium from 40a15381a86b to 873a11ee2df8 (930 revisions) https://chromium.googlesource.com/chromium/src.git/+log/40a15381a86b..873a11ee2df8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/02ca29f24d..4636eb3d7e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6f9b470988..88e9a2946f * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8452f0657d..e4b161d43b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c5717aa498..07ee0ecea6 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/dc7fdb25d6..eb31fd8aa1 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/38a0c99ec5..dd8bbe8204 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a5d06af47f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a0189cd7a..2b4ec95534 * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/6ac5f7effd..6db8da1615 * third_party/r8: Nu_mvQJe34CotIXadFlA3w732CJ9EvQGuVs4udcZedAC..version:2@3.1.16 * tools/luci-go: git_revision:a5735121c6339dee9b1b3644535e230744daaac9..git_revision:24b519169c7848dbeae2dba04698c41666388a45 * tools/luci-go: git_revision:a5735121c6339dee9b1b3644535e230744daaac9..git_revision:24b519169c7848dbeae2dba04698c41666388a45 * tools/luci-go: git_revision:a5735121c6339dee9b1b3644535e230744daaac9..git_revision:24b519169c7848dbeae2dba04698c41666388a45 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/128a63e365..bf467773c4 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/494ba2a758..cf7ada42dc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/447b548acd..4893aadcb6 No update to Clang. Bug: None Tbr: jmadill@google.com,ynovikov@google.com Change-Id: I3240bfab01a73b31ba6108046d56fa291c8dda95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3111453 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 6c1ad60b 2021-08-20T09:30:47 infra: Make perf builders GPU-config-specific. Separating only by OS makes the perf dashboard uploads land in the same bucket for NVIDIA and Intel results. The two are intermingled on the dashboards. Split this by separating the GPU configs into their own builders. Must land before http://crrev.com/c/3110765 Bug: angleproject:6090 Change-Id: Icee3b19d3462977b4ec86bfe08d7c44431426d24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3110745 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill d2d1f41f 2021-08-16T08:05:55 Add EGL extension to create window with a swap interval set. On Vulkan this allows creating a window once without needing to recreate the swapChain after we specify the swap interval. Also adds a simple regression test and EGL enum assertion printing formatting. Bug: angleproject:5133 Change-Id: I72af124cb0e8f7cddfa810988a9862c0f36a0e46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3097806 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill f65d6acc 2021-08-18T12:20:40 Test Runner: Determine slow tests from test expectations. This updates the test harness to handle slow test based on the TIMEOUT test expectation. It removes the "registerSlowTests" API in favor of using the test expectation files. Also updates some of the timeout handling for various angle tests, including on SwiftShader for multithreading tests. Increases the timeout for tests in a batch to attempt to fix the problem of the first test being much slower. Bug: angleproject:6261 Change-Id: I7427344da5a0c1ea26d8c2d6eb0e9be2557b56e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3104007 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 0adaabfc 2021-08-18T16:29:12 Ensure RGB10A2 format properly uses 4 pixel bytes. This fixes a problem with capture/replay where using pixelBytes was returning a 3 byte stride for this 4 byte format. Note this format is a bit odd, because it forces the alpha to 1.0, but the format is specified as using 4 byte upload width, with 2 bits unused. Also adds compile and run-time checking to ensure our bits are always multiples of 8. This flushed out an issue with 565 formats which were using an extra 1 bit for alpha. Test: TexureUploadFormatTest Bug: angleproject:5133 Change-Id: Ia41e86a4980fc041bb1a19b548c32329fa486d03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3104686 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang fc09350a 2021-08-18T12:24:39 GL: Update VertexArrayGL to use ANGLE_GL_TRY. Bug: angleproject:3020 Change-Id: If3409d0d4bc9fdc5c990cece92461e2526c752c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1809058 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill f6b8db1d 2021-08-18T15:20:10 Capture/Replay: Don't access OOB in TexImage2D. The last row of pixels is treated specially because we don't need to round up to the unpack alignment. This fixes an ASAN error with some 1x1 texture tests with small-sized formats. Test: TextureUploadFormatTest Bug: angleproject:5133 Change-Id: I4c56958b83406aff380bda56b90d3258020a1f99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3104685 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny e2485d60 2021-08-14T17:40:14 Capture/Replay: Add the layer to the texture data label string Otherwise the output map will seperate the hash from the raw data when multiple layers are written for the same mip-map level. Bug: angleproject:5133 Change-Id: I7636b6dc66f7ec31958e6eb44591c0a9b9280b00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3093814 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll c72e9264 2021-08-20T10:01:58 Roll vulkan-deps from 4a1a688a34d6 to 1dec6c3c106b (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4a1a688a34d6..1dec6c3c106b Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1ad8b71359..d699296b4d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f6bb4bbc6c..b3f17dc515 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Id6d870efb085965b8c9742dc33a25c5719243ab3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3109711 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gregg Tavares 54e31116 2021-08-19T15:02:16 Add delimeter to attribute search Attributes are written in MSL as type nameOfAttrib __unassigned_attribute__ and then at link time a string substitution replaces __unassigned_attribute__ The test had these attributes metal::float4 floatInput __unassigned_attribute__; metal::uint4 uintInput __unassigned_attribute__; metal::int4 intInput __unassigned_attribute__; and was searching for "intInput __unassigned_attribute__" which matching "uintInput __unassigned_attribute__". Adding a space in front of the search string fixes the issue. This fixes this test: WebGL2CompatibilityTest.VertexShaderAttributeTypeMismatch/ES3_Metal Bug: angleproject:5505 Change-Id: Ide07e5120e88927b1fdeb3cc32b456a661092802 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3108339 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Jonathan Ross 6a8abffc 2021-08-19T17:24:24 Turn off ProgramBinaryES3Test direct-to-Metal tests We enabled these tests, however they are failing consistently on Intel. Original change: https://chromium-review.googlesource.com/c/angle/angle/+/3105442 Bug: angleproject:5505 Bug: angleproject:6301 Change-Id: Iddc36400d55e8b06b15663c2d9bc00df7e04ce02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3107508 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 762db3c0 2021-08-18T09:06:42 Capture/Replay: Improvements to testing script. Using new Python APIs for multiprocessing logging. Also updates some logging to be simpler / more consistent. Also a few other small fixes. Bug: angleproject:5133 Change-Id: I4acbc9173a3891989f409cc499c8e6431e712c0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3104006 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill b2cb9e50 2021-08-19T07:37:28 Capture/Replay: Fix extra frame captured with trigger. A prior CL erroneously removed the -1 from the trigger frame count. Restore this to ensure we capture the right number of frames. Bug: angleproject:5133 Change-Id: Ic24404fbfeb8578badd6204db8316f081eafaa53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3104693 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 58889799 2021-08-19T12:10:43 Roll SwiftShader from 803ceb58c92c to 9eb5acaba94c (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/803ceb58c92c..9eb5acaba94c 2021-08-19 sugoi@google.com Add external memory parameter to size computations 2021-08-19 sugoi@google.com Remove useless 'target' parameter 2021-08-19 capn@google.com Separate analysis info from SPIR-V execution modes 2021-08-18 capn@google.com Update Marl to 49602432d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: If60bba4501248b549f3713af8604f3a19176409a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3106172 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 49af677a 2021-08-16T07:59:18 Capture/Replay: Update serialization logic. - Uses more common toString methods instead of custom ones. - Uses enum to string in more places intsead of numeric enums. - Adds missing group scopes in several places. - Skips serializing empty image levels. Bug: angleproject:5133 Change-Id: I2c9523981aba4ec0afb5f0623cb34154db263e6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3097805 Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll f219db48 2021-08-19T10:01:58 Roll vulkan-deps from 370f9682fb33 to 4a1a688a34d6 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/370f9682fb33..4a1a688a34d6 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/7ca4dfa061..a4599ef756 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/926ff6d1ba..1ad8b71359 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/25679b5cb7..f6bb4bbc6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Icd10e9c930281a7675ea9b3f38225470d08cebb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3106170 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kenneth Russell 8ffb4602 2021-08-18T16:55:56 Turn on the first few direct-to-Metal tests by default. All of the subtests of these previously-asserting tests are passing with --bot-mode: ProgramBinaryES3Test UniformTest WebGLGLSLTest so start running them on ANGLE's CQ. Bug: angleproject:5505 Change-Id: Ibdaa814cec846379e2c073117efa816fc871be33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3105442 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gregg Tavares 5ca0953d 2021-08-18T13:22:22 Use the correct attribute locations in Metal Fixes these tests: BlendIntegerTest.MRTSigned/ES3_Metal BlendIntegerTest.MRTUnsigned/ES3_Metal DrawBuffersTest.Gaps/ES3_Metal DrawBuffersTest.BlendWithGaps/ES3_Metal DrawBuffersTest.FirstAndLast/ES3_Metal DrawBuffersTest.FirstHalfNULL/ES3_Metal DrawBuffersWebGL2Test.TwoProgramsWithDifferentOutputsAndClear/ES3_Metal WebGLCompatibilityTest.DrawBuffers/ES3_Metal Bug: angleproject:5505 Change-Id: I9ea82a8c7a0c5bbc78eb69eb92552909e3f437f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3105439 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Alexey Knyazev eb458fbe 2021-08-18T14:17:31 GL: Add emulateImmutableCompressedTexture3D workaround The workaround replaces glTexStorage3D with a series of glCompressedTexImage3D calls. Bug: chromium:1060012 Change-Id: I08e026e68dd697654cc4ab8feb190a35e56ea133 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3103070 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Jamie Madill 02005fdc 2021-08-18T12:22:58 Fix Texture2DTest.TextureSize. This CL fixes a number of issues: fixes the calls to texture size query, fixes an uninitialized memory read, fixes some incomplete texture cases, and fixes an out-of-bounds with the color array. It also cleans up the test logic, and splits the test into four sub-tests so it runs more smoothly in CI. Noticed while working on the capture/replay harness with ASAN. Bug: angleproject:5982 Change-Id: I15459381b92332db5adad2bd91c0b9eb0f8b5961 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3104005 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill b2238a3c 2021-08-16T08:23:00 Capture/Replay: MEC consistency improvements. Fixes a few very small bugs in MEC. The current program wasn't always captured correctly. Also texture bindings were not always left in the right state. Fixes this by tracking the currently bound GL state between the "shared" and "aux" MEC capture functions. Also updates the vertex array capture to detect when to use ES 2.0 semantics. ES 3.1 is left unimplemented as it was before. Bug: angleproject:5133 Change-Id: I5f03b8ffbdccec2664fda4698581b166a36fabdd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3097809 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 839d5318 2021-08-16T08:29:28 Capture/Replay: Changes to MEC first frame capture. Recent changes made it so it was impossible to trigger MEC *after* the first frame and *before* the second frame. Instead it was only possible to capture *before* the first frame or *after* the second frame. Makes it possible for the retracing script to do identical captures. Also includes a number of refactorings to make it simpler to follow the code, including renaming methods, and removing some extra output files. Bug: angleproject:5133 Change-Id: Ice6a189eb9f4d53e8ee1ba39beb537af2ef5fd9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3097807 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuly Novikov 2967166e 2021-08-04T19:31:54 Reland "Properly report xcb_connect failures in DisplayVkXcb" This is a reland of 81bee2e7f6deeda15691dd0b7fca90626b66bfb8 Changes for the reland: Do not attempt to use Xcb if DISPLAY is not defined - for headless ozone. Original change's description: > Properly report xcb_connect failures in DisplayVkXcb > > Bug: chromium:1223431 > Change-Id: Iaefddbda3fef283eed365fe010ee003a3b3beca8 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3083383 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1223431 Change-Id: I19be7d10cbd3692e1de6458bc0e2db5996a755af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3099674 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Gert Wollny f2c96887 2021-08-16T15:23:34 Capture/Replay: Pop only after using values it in endGroup When running the replay in valgrind the use of an undefined value in the JsonSerializer::endGroup shows that 'name' value on the stack is handled in an unexpected fashion, i.e the pop seems to invalidate the values that should have already been moved. Using the reference of the top() values and doing pop() only after the new group entry has been created avoids this. Bug: angleproject:6180 Change-Id: I8e5f8dd3d14928d4763faabe236379b40a4f6f4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3093815 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll 56a4dce6 2021-08-18T14:39:31 Roll Chromium from df8e98bc8f6e to 40a15381a86b (437 revisions) https://chromium.googlesource.com/chromium/src.git/+log/df8e98bc8f6e..40a15381a86b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4ea12fb9e6..02ca29f24d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/671803fd96..8452f0657d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/53ffcd7342..c5717aa498 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5d3907f90f..dc7fdb25d6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..77a7089299 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af70e1bf3b..9a0189cd7a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1a399d5b62..128a63e365 No update to Clang. Bug: angleproject:5543,angleproject:6037,angleproject:6245 Tbr: jmadill@google.com Change-Id: Ic4d71e98c678648e19a085ec1dafef7045930748 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3101478 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ffb974d6 2021-08-18T13:10:59 Roll vulkan-deps from 59563d9384fb to 370f9682fb33 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/59563d9384fb..370f9682fb33 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/e71feddb3f..449bc986ba * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b2e36b67ec..926ff6d1ba * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/521f91d793..c5b7a2fa18 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8a3a1676ef..90fd66f60f * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/415320f80f..5805106266 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d6be28f1b1..25679b5cb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I4e7933ee13759a78fccbc806237ef25d9b7b946c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3101476 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill ad286e71 2021-08-17T10:43:47 Capture/Replay: Clean up ResourceTracker access. This reduces the boilerplate needed to tracked genned/deleted resources. Refactoring change only. Bug: angleproject:5133 Change-Id: I81f8877b2c308fe9d4136999f3ca63371a070720 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3100591 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 9872e5af 2021-08-18T07:56:38 Vulkan: Suppress layered FB validation error. This is popping up with a new roll of the VVL. Instead of fixing it, we can disable it for now. Bug: angleproject:6293 Change-Id: I6cd12a24b26a4f536db16631e198317e8c4d9fcc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3103505 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e3f2acb9 2021-08-18T08:03:26 Trace Tests: Skip sakura school sim on Win/Intel. This test seems to produce non-deterministic rendering/flakiness. Bug: angleproject:6294 Change-Id: I5cb72318c865f21814d114fd13a18dfd44e5db60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3103506 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 7e040640 2021-08-16T08:43:17 libANGLE: Minor cleanups. Removes a couple duplicated cached members in gl::State. Also a few other small refactorings. Bug: angleproject:5133 Change-Id: I0c6cd4c6544ef1690a4ce95d40dac70c688c7092 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3097808 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Brandon Schade cc52e7cd 2021-04-19T21:37:20 Prevent separable programs from relying on attached shaders Previously, several linking functions were reliant on the HasAttachedShaders interface. The information stored there has been moved to ProgramExecutable. Linking information such as uniforms and uniform blocks from attached shaders is now also stored in temporary pending variables inside ProgramExecutable. Bug: angleproject:5506 Test: ProgramPipelineTest31.VaryingLocationMismatch* Test: GeometryShaderTest.RecompileSeparableVSWithVaryings* Test: ProgramBinaryES31Test.SeparableProgramLinkedUniforms* Change-Id: I93591431959c1c4c547ada92ec358369a3417723 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2909760 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Jamie Madill d55d57ac 2021-08-17T14:16:07 GN: Disable unreachable code warnings in GLES 1 tests. Bug: chromium:1240679 Change-Id: Ib140cbd32386a7836acf9a4f477693b14bf3c6d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3100590 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gregg Tavares 63bb0e53 2021-08-16T16:30:32 Add depth fix to convert from GL to Metal Vertex shaders need to convert from GL's -1 to +1 z range to Metal's 0 to +1 z range with: z = (z + w) * 0.5 This code is being upstreamed from WebKit. It fixes these end to end tests. BlitFramebufferTest.MultisampleDepthClear/ES3_Metal BlitFramebufferTest.MultisampleDepthClear/ES3_Metal_NoStencilOutput BlitFramebufferTest.BlitDepthStencilPixelByPixel/ES3_Metal BlitFramebufferTest.BlitDepthStencilPixelByPixel/ES3_Metal_NoStencilOutput ClearTest.ClearStencilMask/ES2_Metal ClearTest.ClearStencilMask/ES3_Metal ClearTestES3.ClearMultipleAttachmentsIndividually/ES3_Metal ClearTestES3.MaskedClearHeterogeneousAttachments/ES3_Metal ClearTestES3.ScissoredClearHeterogeneousAttachments/ES3_Metal ClearTestES3.ClearBufferivStencilMask/ES3_Metal ClearTestES3.ClearBufferfiNoStencilAttachment/ES3_Metal MaskedScissoredClearTest.Test/ES2_Metal__clear_s MaskedScissoredClearTest.Test/ES2_Metal__clear_s_mask_s MaskedScissoredClearTest.Test/ES2_Metal__scissored_clear_s_mask_s MaskedScissoredClearTest.Test/ES2_Metal__clear_d MaskedScissoredClearTest.Test/ES2_Metal__scissored_clear_d MaskedScissoredClearTest.Test/ES2_Metal__clear_ds MaskedScissoredClearTest.Test/ES2_Metal__scissored_clear_ds MaskedScissoredClearTest.Test/ES2_Metal__clear_ds_mask_s MaskedScissoredClearTest.Test/ES2_Metal__scissored_clear_ds_mask_s MaskedScissoredClearTest.Test/ES2_Metal__clear_cs MaskedScissoredClearTest.Test/ES2_Metal__clear_cs_mask_s MaskedScissoredClearTest.Test/ES2_Metal__scissored_clear_cs_mask_s MaskedScissoredClearTest.Test/ES2_Metal__clear_cd MaskedScissoredClearTest.Test/ES2_Metal__scissored_clear_cd MaskedScissoredClearTest.Test/ES2_Metal__clear_cds MaskedScissoredClearTest.Test/ES2_Metal__scissored_clear_cds MaskedScissoredClearTest.Test/ES2_Metal__clear_cds_mask_s MaskedScissoredClearTest.Test/ES2_Metal__scissored_clear_cds_mask_s MaskedScissoredClearTest.Test/ES2_Metal__clear_cs_mask_cs MaskedScissoredClearTest.Test/ES2_Metal__scissored_clear_cs_mask_cs MaskedScissoredClearTest.Test/ES2_Metal__clear_cd_mask_c MaskedScissoredClearTest.Test/ES2_Metal__scissored_clear_cd_mask_c MaskedScissoredClearTest.Test/ES2_Metal__clear_cds_mask_c MaskedScissoredClearTest.Test/ES2_Metal__scissored_clear_cds_mask_c MaskedScissoredClearTest.Test/ES2_Metal__clear_cds_mask_cs MaskedScissoredClearTest.Test/ES2_Metal__scissored_clear_cds_mask_cs MaskedScissoredClearTest.Test/ES3_Metal__clear_s MaskedScissoredClearTest.Test/ES3_Metal__clear_s_mask_s MaskedScissoredClearTest.Test/ES3_Metal__scissored_clear_s_mask_s MaskedScissoredClearTest.Test/ES3_Metal__clear_d MaskedScissoredClearTest.Test/ES3_Metal__scissored_clear_d MaskedScissoredClearTest.Test/ES3_Metal__clear_ds MaskedScissoredClearTest.Test/ES3_Metal__scissored_clear_ds MaskedScissoredClearTest.Test/ES3_Metal__clear_ds_mask_s MaskedScissoredClearTest.Test/ES3_Metal__scissored_clear_ds_mask_s MaskedScissoredClearTest.Test/ES3_Metal__clear_cs MaskedScissoredClearTest.Test/ES3_Metal__clear_cs_mask_s MaskedScissoredClearTest.Test/ES3_Metal__scissored_clear_cs_mask_s MaskedScissoredClearTest.Test/ES3_Metal__clear_cd MaskedScissoredClearTest.Test/ES3_Metal__scissored_clear_cd MaskedScissoredClearTest.Test/ES3_Metal__clear_cds MaskedScissoredClearTest.Test/ES3_Metal__scissored_clear_cds MaskedScissoredClearTest.Test/ES3_Metal__clear_cds_mask_s MaskedScissoredClearTest.Test/ES3_Metal__scissored_clear_cds_mask_s MaskedScissoredClearTest.Test/ES3_Metal__clear_cs_mask_cs MaskedScissoredClearTest.Test/ES3_Metal__scissored_clear_cs_mask_cs MaskedScissoredClearTest.Test/ES3_Metal__clear_cd_mask_c MaskedScissoredClearTest.Test/ES3_Metal__scissored_clear_cd_mask_c MaskedScissoredClearTest.Test/ES3_Metal__clear_cds_mask_c MaskedScissoredClearTest.Test/ES3_Metal__scissored_clear_cds_mask_c MaskedScissoredClearTest.Test/ES3_Metal__clear_cds_mask_cs MaskedScissoredClearTest.Test/ES3_Metal__scissored_clear_cds_mask_cs DepthStencilFormatsTest.DepthTextureRender/ES2_Metal DepthStencilFormatsTest.DepthBuffer16/ES2_Metal DepthStencilFormatsTest.DepthBuffer24/ES2_Metal DepthStencilFormatsTest.VerifyDepth32UploadData/ES2_Metal DepthStencilFormatsTest.VerifyDepth16UploadData/ES2_Metal TinyDepthStencilWorkaroundTest.DepthTexturesStick/ES3_Metal DiscardFramebufferEXTTest.ClearDepthThenDrawWithDepthTestThenDiscard/ES2_Metal DiscardFramebufferEXTTest.ClearDepthThenDrawWithDepthTestThenDiscard/ES3_Metal Bug: angleproject:5505 Change-Id: I9b52bb46569678636afc6a243bfa8779f101b6af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3097161 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Jamie Madill 162847ca 2021-08-17T13:26:06 infra: Increase sharding in CI angle_perftests. The test shards right now are taking 20-30+ minutes. Sometimes they time out on the test infra. Increase sharding because the overhead from sharding is very small relative to the test time used by shards. Bug: angleproject:6090 Change-Id: I45c7bf077da7242743559d68b45d45dbea18355e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3100586 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 17d41054 2021-08-17T13:22:46 Skip a flaky test on SwANGLE. The test was already marked flaky on Windows. Mark it TIMEOUT everywhere since likely the root causes are the same. KHR-GLES31.core.arrays_of_arrays.SizedDeclarationsPrimitive Bug: angleproject:5755 Change-Id: Ief208a5a2cb533e5ba4b88ef65e82a2a14dcf0b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3100585 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 864b0204 2021-08-17T12:44:26 Roll Chromium from aeae79104c34 to df8e98bc8f6e (460 revisions) https://chromium.googlesource.com/chromium/src.git/+log/aeae79104c34..df8e98bc8f6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a0d51919fe..4ea12fb9e6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6810b870e0..6f9b470988 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c0ea7c3386..53ffcd7342 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/9b466c11a1..2d100d89bb * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..77a7089299 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0c42eff6d1..af70e1bf3b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f1ab49ba22..6002926a08 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2a295d6d76..447b548acd Clang version changed llvmorg-14-init-1002-gb5e470aa:llvmorg-14-init-1380-gee659383 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/f1ab49ba228127b73e1e590a9687d7edfdc65151..6002926a08a57b7bd87c4f7780ce43981a320bbb/scripts/update.py Bug: angleproject:6281 Tbr: jmadill@google.com Change-Id: Ia6fae91c48e98daf6eeb474960dc8a7a59b2a55c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3099885 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 98e2410d 2021-08-17T07:52:03 dEQP: Remove Pixel 2/XL test expectations. We no longer support Vulkan on the P2. Bug: angleproject:2808 Bug: angleproject:3683 Bug: angleproject:3816 Bug: angleproject:4024 Bug: angleproject:4097 Bug: angleproject:4159 Bug: angleproject:4166 Bug: angleproject:4194 Bug: angleproject:4219 Bug: angleproject:4344 Bug: angleproject:4822 Bug: angleproject:5340 Bug: angleproject:5370 Bug: angleproject:5572 Bug: angleproject:6008 Bug: b/161540999 Change-Id: Ie2cb634201c2d604cb247eb0369d5e90d7600e8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3098490 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll ae1882b9 2021-08-17T10:01:45 Roll SwiftShader from 526b987888fb to 803ceb58c92c (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/526b987888fb..803ceb58c92c 2021-08-16 sugoi@google.com Xcb: Check if geom is valid before using it 2021-08-16 capn@google.com Fix integer overflow in vertex buffer access robustness check If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ifc8ff74a3bc55a04fcf6968be64de55b23dafe76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3099214 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 680ce669 2021-08-17T10:01:58 Roll vulkan-deps from 510c98092bc0 to 59563d9384fb (18 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/510c98092bc0..59563d9384fb Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/00b106e769..b2e36b67ec * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/de99f8f6be..8a3a1676ef * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d1f10bf970..d6be28f1b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I7892ee95335521af54023759d4599dd8c3210457 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3099079 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 7007e472 2021-08-17T07:11:49 Manually roll android bundle tool. This is necessary to unblock the Chromium->ANGLE roll. Bug: angleproject:6287 Change-Id: Ief694fbfd78f8f1d7d40ec7031747379fd288210 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3099786 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 130a8b63 2021-08-16T17:09:10 Perf Runner: Properly merge histograms. The prior method was emitting 5 histograms per test. The new script method merges the 5 histogram samples together and recomputes the running statistics. Should improve reporting on the dashboard. Bug: angleproject:6090 Change-Id: I58a5e020f3a3257a8545df2785bc3eaa811ee38e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3096550 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jason Macnak 0be285c6 2021-07-20T11:36:22 Vulkan: Flush read RT if color attachment is the read buffer Prior to this change, the following sequence: * eglMakeCurrent(..., draw=surface1, read=surface1, ...); * glClear(...); * eglMakeCurrent(..., draw=surface2, read=surface1, ...); * glBlitFramebuffer(...); * eglMakeCurrent(..., draw=surface1, read=surface1, ...); * glReadPixels(...); would end up with the `vkCmdClearColorImage()` on surface1 occuring after the `vkCmdBlitImage()`. This CL updates flushColorAttachmentUpdates() to flush any staged updates to both the read and draw attachments, since they can be different if different read and draw surfaces are bound. Adds a test which is a small repro of android.opengl.cts.FramebufferTest#testBlitFramebuffer failure. Bug: b/192327017 Test: EGLSurfaceTest.BlitBetweenSurfaces/* Change-Id: Iabad26dfcd8633e9dcfcee2fb16ba352bc3931d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078980 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Gert Wollny 4aedb71f 2021-08-11T17:00:41 Capture/Replay: Force count and length in CaptureShaderSource The problem ist that there is a mix on how the captured shader source is written out, in some cases one string is written, e.g. with the test ZeroShaderLength, and in others case an array if strings is written, a with MixedShaderLengths. Be constistent about it and capture the shader source always as one string and handle it like this, and override the count to be 1 to reflect this and set the length to {-1} to use the new accumulated shader strings automatically. Bug: angleproject:6268 Change-Id: Ide927db1a6e4facdbab4d35c023b9bce4b6c30d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087448 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Jamie Madill a835912f 2021-08-09T13:58:37 Texture: Mark initialized after syncState. This fixes an issue with retracing where textures that are never used or only used once may have different init states on re-tracing. Bug: angleproject:5133 Change-Id: I29fdc477e3522582c8e2eece0b4b86384ecf6d9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3081762 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 1b9d95fc 2021-08-16T10:01:57 Roll vulkan-deps from 4d36e22f8cc6 to 510c98092bc0 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4d36e22f8cc6..510c98092bc0 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/aa2d4bd2f4..7ca4dfa061 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/54524ffa6a..00b106e769 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/69c0fb545d..d1f10bf970 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ib71e5808f06dd6cfb503bc2b15978d34f65198c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3097090 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 55e21771 2021-08-16T07:00:14 Roll Chromium from 30bbd66599a2 to aeae79104c34 (422 revisions) https://chromium.googlesource.com/chromium/src.git/+log/30bbd66599a2..aeae79104c34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d09a3175f2..a0d51919fe * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f063da141c..6810b870e0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b1a5d27579..c0ea7c3386 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/61d9d5c057..9b466c11a1 * third_party/android_build_tools/aapt2: aKJ5MrSRXjVPtBx2DoBnJtmmjO6W6PkQrTYuBtdu46YC..PHj2SHpCe6Sr9lcIR9W1onhKN4FIIPL2Mho5aAQG-QIC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/12d2cf1a46..38a0c99ec5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..126f6a8996 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/699d70d878..0c42eff6d1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/541f598e64..1a399d5b62 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/eb8f364120..2a295d6d76 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Iccff80dd6649971bb655d920d9efc6f8c645877c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3097128 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi d20afde4 2021-08-05T23:06:44 Vulkan: Retain precision of uniform variables When gathering in a uniform block, the precision of default uniforms was dropped. Bug: angleproject:4889 Bug: angleproject:6132 Change-Id: Ie6a8e2e7cef7cd3808cee08d20f886fc4e762cd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076124 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 1fb846cb 2021-08-03T01:57:49 Validate texStorage dimensions with compressed formats Bug: angleproject:6230 Change-Id: I501ec1e6974bdc7e6731dcb88045edb0aa22b888 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067329 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Kenneth Russell d8cb9967 2021-08-04T18:15:51 In WebGL, constrain base level of compressed textures. Enforce that if a mipmap level > 0 is specified for a compressed texture, that it implies that the size of the base level of the texture is a multiple of the format's block size. Makes the test changes in https://github.com/KhronosGroup/WebGL/pull/3304 largely pass. There are some needed follow-on fixes to that PR, and this CL changes a sub-test result in the existing S3TC and S3TC-sRGB tests which will need to be suppressed Chromium-side first. Bug: angleproject:6245 Change-Id: I7723d7882091b78a353d8d273e80b819dd384021 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3072568 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 728baa50 2021-08-13T18:47:50 Revert "Skip UpdateRenderTargetCacheOnDestroyTexStorage on Metal" This reverts commit bf4eb2636ebae19cfa8d3edb9828bdb464360df5. Reason for revert: branch created before angle_end2end_tests_expectations.txt existed, need to use the old-fashioned suppression method. Original change's description: > Skip UpdateRenderTargetCacheOnDestroyTexStorage on Metal > > Fails in M92 branch, e.g. > https://ci.chromium.org/ui/p/chromium-m92/builders/try/mac_optional_gpu_tests_rel/67/overview > > Bug: chromium:1234829 > Change-Id: I74b9694a16fccc4ba358db5dc1168cf9e21ecab0 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3094707 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1234829 Change-Id: Ifd01947e0ae79619cec3290e4afe1489933a650e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3093248 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov bf4eb263 2021-08-13T14:09:14 Skip UpdateRenderTargetCacheOnDestroyTexStorage on Metal Fails in M92 branch, e.g. https://ci.chromium.org/ui/p/chromium-m92/builders/try/mac_optional_gpu_tests_rel/67/overview Bug: chromium:1234829 Change-Id: I74b9694a16fccc4ba358db5dc1168cf9e21ecab0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3094707 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 26cf48c1 2021-08-13T11:27:36 Roll VK-GL-CTS from bf3d63599bad to 7103920041db (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/bf3d63599bad..7103920041db 2021-08-13 alexander.galazin@arm.com Merge pull request #276 from Ella-0/master 2021-08-12 ilkka.saarelainen@siru.fi Add missing items to android cts mustpass list 2021-08-12 soroush.kashani@imgtec.com Fix bug in compressed PixelStorageModes tests 2021-08-12 david.emett@broadcom.com Work around bogus GCC 9 warnings 2021-08-12 antto.makinen@siru.fi Fix a GraphicsFuzz coverage test 2021-08-06 ari.suonpaa@siru.fi Added layered AHB EGL tests 2021-08-06 rgarcia@igalia.com Improve buffer to buffer copy tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Manually suppressing some newly added tests in dEQP-EGL.functional.image.*android_native* Bug: angleproject:6277 Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com Change-Id: I8c942b49e5e8216695d449b8d1ef38d0f1198d0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3093790 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 6c32e8d9 2021-08-13T10:01:38 Roll vulkan-deps from 20a966e2b2fd to 4d36e22f8cc6 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/20a966e2b2fd..4d36e22f8cc6 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/76a2e6cc59..69c0fb545d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ie87bb497994d5421d2d2fa30acf3a9ffed3abf86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3093789 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fe6804e8 2021-08-13T10:01:49 Roll SwiftShader from b2af6a85583d to 526b987888fb (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/b2af6a85583d..526b987888fb 2021-08-12 eugenis@google.com Disable hwasan in llvm-10.0. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ie09182e918b9e2136b6f58996a7abf15d3d6a2aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3092883 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1698ba2b 2021-08-13T07:01:11 Roll Chromium from 5a1d66a9d8fb to 30bbd66599a2 (82 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5a1d66a9d8fb..30bbd66599a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4d07fd6ad5..d09a3175f2 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/37dc929ecb..f063da141c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7a163851ec..b1a5d27579 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..bd47f22ad2 * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/e9be5fd6d7..4e6fe9d154 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/aedb340bd7..eb8f364120 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Idb68a1639a9e21134a24202dae711bed9d5ea418 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3093787 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 201960e4 2021-08-13T00:25:18 Roll Chromium from 00e190ef4059 to 5a1d66a9d8fb (406 revisions) https://chromium.googlesource.com/chromium/src.git/+log/00e190ef4059..5a1d66a9d8fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ee35ebe42c..4d07fd6ad5 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/eed07007f8..671803fd96 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/44c5a11573..7a163851ec * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/380b3ce66e..61d9d5c057 * third_party/android_build_tools/aapt2: R2k5wwOlIaS6sjv2TIyHotiPJod-6KqnZO8NH-KFK8sC..aKJ5MrSRXjVPtBx2DoBnJtmmjO6W6PkQrTYuBtdu46YC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..bd47f22ad2 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4b973b6e6e..699d70d878 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f7a26285a7..aedb340bd7 No update to Clang. Bug: angleproject:5543,angleproject:6245 Tbr: ynovikov@google.com Change-Id: I1fe2692a1e32889f3e17fefd311eae9a270e8492 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3092967 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 2ae998ac 2021-08-12T16:24:11 Enable ResultDB on standalone Try builders Including the presubmit builder. crrev.com/c/3087640 missed Try builders and only enabled ResultDB on CI. Bug: angleproject:6275 Change-Id: Ia645205973008c535a2334b3b78b0d95a791c95d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3092465 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov e6d9ef98 2021-08-12T14:53:07 Enable ResultDB adapter for standalone bots In crrev.com/c/3087640 'has_native_resultdb_integration' was erroneosly enabled on ANGLE standalone bots. Disable it, so that the Chromium recipe would enable result adapter from JSON to ResultDB format. Bug: angleproject:6275 Change-Id: I1f94a8f2cbd1159be89bc1413669ed90e249c5b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3092045 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tim Van Patten fa74421d 2021-08-06T18:30:57 Capture/Replay: Add LoadEGL() Add LoadEGL() to gen_restricted_traces.py. This is a pre-requisite to frame capture being able to generate EGL calls, which is required for multi-context support. Bug: angleproject:5878 Change-Id: I210035aecad42173626834588bae51019deaa076 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078994 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 62cac8b5 2021-08-06T18:24:52 Capture/Replay: Add EGL support to generate_entry_points.py Add EGL support to generate_entry_points.py. This is a pre-requisite to frame capture being able to generate EGL calls, which is required for multi-context support. Bug: angleproject:5878 Bug: angleproject:4035 Change-Id: I3b8e9c91f9e2820b5207fc02d858e8109921f581 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078993 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll ce6b0cd7 2021-08-12T16:15:11 Roll vulkan-deps from 95cbcd95b33b to 20a966e2b2fd (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/95cbcd95b33b..20a966e2b2fd Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/e7b49d7fb5..e71feddb3f * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/de69f32e89..54524ffa6a * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/fbb56aacce..de99f8f6be * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2fe826b04c..76a2e6cc59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I3eb2bbedb4915f399ab6e6a87770bfa15922bd07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3090816 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov ac2d1434 2021-08-11T15:48:57 Enable resultdb for ANGLE standalone builders Otherwise, they fail with https://crrev.com/c/3088213, e.g. https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/23678/overview Doesn't actually upload to BigQuery yet, pending declaring the tables. Bug: chromium:1135718 Change-Id: Ia429260e2f53f836279383aa84ca3e8e58c3392b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087640 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll bfad749c 2021-08-12T07:01:05 Roll Chromium from 176cfbd86223 to 00e190ef4059 (514 revisions) https://chromium.googlesource.com/chromium/src.git/+log/176cfbd86223..00e190ef4059 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bbf7f0ed65..ee35ebe42c * buildtools/linux64: git_revision:eea3906f0e2a8d3622080127d2005ff214d51383..git_revision:69ec4fca1fa69ddadae13f9e6b7507efa0675263 * buildtools/mac: git_revision:eea3906f0e2a8d3622080127d2005ff214d51383..git_revision:69ec4fca1fa69ddadae13f9e6b7507efa0675263 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/24e92c2bee..eed07007f8 * buildtools/win: git_revision:eea3906f0e2a8d3622080127d2005ff214d51383..git_revision:69ec4fca1fa69ddadae13f9e6b7507efa0675263 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/30fcc783eb..44c5a11573 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/32263815a7..5d3907f90f * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/5be11071ec..380b3ce66e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3ef3f2c876 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/49a703f3d9..4b973b6e6e * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/7c54c1f227..6ac5f7effd * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6a8e571efd..f1ab49ba22 * tools/luci-go: git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe..git_revision:a5735121c6339dee9b1b3644535e230744daaac9 * tools/luci-go: git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe..git_revision:a5735121c6339dee9b1b3644535e230744daaac9 * tools/luci-go: git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe..git_revision:a5735121c6339dee9b1b3644535e230744daaac9 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/836d7670f0..541f598e64 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/7235d59a2b..494ba2a758 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8552b7ec98..f7a26285a7 Clang version changed llvmorg-14-init-591-g7d9d926a:llvmorg-14-init-1002-gb5e470aa Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/6a8e571efd68de48d226950d1e10cb8982e71496..f1ab49ba228127b73e1e590a9687d7edfdc65151/scripts/update.py Bug: None Tbr: ynovikov@google.com Change-Id: I0e8d45c81fdc66b37c9fea29c8be703fadb638b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3089661 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kenneth Russell ff64d2c7 2021-08-06T21:24:09 Choose direct-to-Metal translator through a feature. Define directMetalGeneration in FeaturesMtl.h. If ANGLE_ENABLE_METAL_SPIRV is defined to 1 (still the default), directMetalGeneration defaults to false. It can be overridden via the standard ANGLE mechanism: ANGLE_FEATURE_OVERRIDES_ENABLED=directMetalGeneration It can also be overridden by instantiating angle_end2end_tests with the directives: WithDirectMetalGeneration(ES2_METAL()) WithDirectMetalGeneration(ES3_METAL()) These directives aren't working properly yet though. The direct-to-Metal compiler is instantiated, but the _DirectMetalGen versions of the tests fail. They pass when switching the Metal backend's default behavior using the above environment variable. This will be debugged in follow-on CLs. Thanks to syoussefi@ for the prototype of this CL: https://chromium-review.googlesource.com/3076129 Bug: angleproject:5505 Change-Id: I188ab89abc75bf89c5ed2d90102af311feaa1960 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3079083 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Lubosz Sarnecki 331be08f 2021-08-11T11:28:29 Tests: Add Sonic The Hedgehog trace. Test: angle_perftests --gtest_filter="*sonic_the_hedgehog*" Bug: angleproject:6181 Change-Id: I40a5affe804a747445ef620c4f78e842c1eed1ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087444 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Gert Wollny d3031c65 2021-08-11T12:30:01 Capture/Replay: Update expectations with bug IDs In addition, update two tests that are just failing and no longer crashing. Bug: angleproject:6166 Change-Id: I9f19bf411c79c39f4f1f3156a9f8682609d6b3d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087445 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll 29270a63 2021-08-11T10:01:12 Roll vulkan-deps from 902c4504128f to 95cbcd95b33b (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/902c4504128f..95cbcd95b33b Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c4c6f2ba5c..de69f32e89 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/9fe958cdab..521f91d793 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a2edd93673..fbb56aacce * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8dca1fa770..415320f80f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bc1468932d..2fe826b04c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I231ec887713f25bc84328640a07cb70526f481e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087841 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 88725917 2021-08-11T07:00:58 Roll Chromium from 6db26672c5bd to 176cfbd86223 (476 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6db26672c5bd..176cfbd86223 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8e6db3edf0..bbf7f0ed65 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c54c079bce..30fcc783eb * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/09da6e47b4..32263815a7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..abc7ba7d87 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/24dc2c7823..49a703f3d9 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/ad8b3b0f84..ff19e5b2e1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/77b4e6e8d4..f2eeaf2ef3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/79ff382907..836d7670f0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e4df839dbe..8552b7ec98 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ibed6651e595c5cfa7fa5a01b016c7346411e4760 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3088002 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 392ba63f 2021-08-10T19:20:47 Suppress 2 dEQP GLES3 tests on Win SwANGLE functional.shaders.operator.unary_operator.minus.lowp_uvec3_vertex functional.shaders.operator.unary_operator.minus.mediump_uvec3_vertex Fails on x86 when llvmorg-13-init-15561-gf98ed74f Clang rolled. Unfortunately, expectation file doesn't support architecture, so suppressing on both x86 and x64 Windows, keeping the test running on x64 Linux. Bug: angleproject:6265 Change-Id: I15f8955eaf38c95d0d3036378d97afdb1871d44e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3088016 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jeff Vigil 6136620b 2021-03-25T15:43:06 Reland "EGL: GLES: Implement GL_EXT_protected_textures" This is a reland of 6210a9b34a721df2c84cf69170ad9bf7ba40e4aa This removes changes in gl backend. Original change's description: > EGL: GLES: Implement GL_EXT_protected_textures > > Implement EGL_EXT_protected_content Images > Add protected member to Images and Textures > Add error when creating objects if not supported or > does't match native buffer > When creating siblings pass protected state > Add extension caps > Add Validation > Add GetTexParameter and SetTextparameter > Add protected to Texture and state > Expand tests for images and textures > > Test: angle_end2end_test --gtest_filter=EGLProtectedContentTest > > Bug: angleproject:3965 > Change-Id: I35a89b4e80bba6d9b6831c68e71630eef304dacb > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2802852 > Commit-Queue: Mohan Maiya <m.maiya@samsung.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Test: angle_end2end_test --gtest_filter=EGLProtectedContentTest Bug: angleproject:3965 Change-Id: Id36d697c53afc0f0dadf92bda4565f9157f4fc2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076825 Commit-Queue: Brandon Schade <b.schade@samsung.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 0bd5cac2 2021-08-06T17:56:58 Allow BufferSubData with persistently mapped buffers Per the GL_EXT_buffer_storage extension: What commands are affected by the relaxed errors for persistently mapped buffers? RESOLVED: In GL 4.5 the following commands have the relaxed language BufferSubData, ClearBufferSubData, CopyBufferSubData, GetBufferSubData and InvalidateBufferSubData. Of these commands the only ones that apply to ES 3.1 are BufferSubData and CopyBufferSubData. However, if additional extensions add any of the other commands and EXT_buffer_storage is supported, they would have the same behavior in ES. Therefore we need to allow BufferSubData and CopyBufferSubData on persistently mapped buffers. Current we fail these scenarios in validation. This was detected when running Fortnite on Android using the game's GLES backend. Also added two tests: - StorageCopyBufferSubDataMapped to recreate the exact Fortnite scenario using glCopyBufferSubData. - StorageBufferSubDataMapped is a contrived case to cover glBufferSubData Test: BufferStorageTestES3.StorageCopyBufferSubDataMapped/* Test: BufferStorageTestES3.StorageBufferSubDataMapped/* Bug: b/180418810 Bug: angleproject:5658 Change-Id: Ib678e84f367934656ec10f0f4ad0d35ac687f0b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078316 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuly Novikov 8f214193 2021-08-10T20:40:36 Revert "Properly report xcb_connect failures in DisplayVkXcb" This reverts commit 81bee2e7f6deeda15691dd0b7fca90626b66bfb8. Reason for revert: fails on https://ci.chromium.org/ui/p/chromium/builders/try/linux-ozone-rel/918054/overview Original change's description: > Properly report xcb_connect failures in DisplayVkXcb > > Bug: chromium:1223431 > Change-Id: Iaefddbda3fef283eed365fe010ee003a3b3beca8 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3083383 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1223431 Change-Id: I1da24861375a29f448e61771a609396e777c2e29 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087555 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 0b651e42 2021-07-20T11:48:38 Vulkan/D3D11/Metal: Expose GL_NV_framebuffer_blit GL_NV_framebuffer_blit is equivalent to ES3 blit which these backends support. Bug: chromium:1220246 Change-Id: I6ef0b80f9e9ba7828d6720cdbe19c83c4abdc4cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3041878 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 81bee2e7 2021-08-04T19:31:54 Properly report xcb_connect failures in DisplayVkXcb Bug: chromium:1223431 Change-Id: Iaefddbda3fef283eed365fe010ee003a3b3beca8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3083383 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Lubosz Sarnecki 97c21277 2021-08-03T15:06:37 FrameCapture: Don't capture default drawbuffers state. When capturing framebuffers during mid-execution-capture the drawbuffers state is now compared with the default one and skipped when equal. This prevents capturing the unavailable glDrawBuffers call when using OES_framebuffer_object on GLES 1 contexts. Bug: angleproject:6181 Change-Id: Id2076223067dc5f89df88fe6a3a48b09fa9a3f5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3068957 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 856228b0 2021-08-05T23:10:25 D3D9: Expose EXT_sRGB and EXT_texture_compression_s3tc_srgb sRGB reads are supported on D3D9 via SetSamplerState. sRGB writes are supported on D3D9 via SetRenderState. Bug: angleproject:6258 Change-Id: I841c25ce66486e93ae2122b370e910f383fed774 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076359 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Lubosz Sarnecki 595ce2b8 2021-08-03T15:06:14 FrameCapture: Use OES suffixes for framebuffer functions on ES1. Functions using the GL_OES_framebuffer_object extension on GLES 1.1 require the OES suffix or will otherwise crash on certain native OpenGL drivers. The framebuffer capture functions are stored in a struct. This patch makes replay of Sonic The Hedgehog possible on Pixel 4 XL native GL. Bug: angleproject:6181 Change-Id: I689267b024824818bfcf28e652b835e075208415 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3068956 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Jamie Madill d25c9d7f 2021-07-07T12:15:12 Add perf tests runner script. This script will be responsible for running the perf tests multiple times to try and stabilize measurements. We'll use it on the bots instead of just running the perf tests directly. Because the script invokes the binary multiple times, this slows down execution. Most significantly on Android, where we now need to use 20 shards, up from 6. Also marks one test as flaky on OpenGL. Bug: angleproject:6090 Change-Id: I5280035cb0bdb290a68dc6961a384eaf4b40dd4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3011422 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 4eac0bf1 2021-08-10T10:01:12 Roll vulkan-deps from 8e25231b71ac to 902c4504128f (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/8e25231b71ac..902c4504128f Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/e0f3fdf433..aa2d4bd2f4 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/706dc27a62..c4c6f2ba5c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9db21837b8..bc1468932d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I790425565050497ad4a4632a4283afa9b021d5ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3085081 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 17d4ff96 2021-08-10T07:13:16 Roll Chromium from bfd7c5a55cd0 to 6db26672c5bd (464 revisions) https://chromium.googlesource.com/chromium/src.git/+log/bfd7c5a55cd0..6db26672c5bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1b131580ae..8e6db3edf0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/97a17ccfc8..c54c079bce * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/d5413f72f6..5be11071ec * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/b291e88d8e..e98c753917 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/ff9352c23f..37226d67bc * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b35ee4986e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e989bf92db..24dc2c7823 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/9ce4c7a678..77b4e6e8d4 * tools/luci-go: git_revision:e7749d37e8e52fd6eb9c79266a17d7fcb6f6ec04..git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe * tools/luci-go: git_revision:e7749d37e8e52fd6eb9c79266a17d7fcb6f6ec04..git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe * tools/luci-go: git_revision:e7749d37e8e52fd6eb9c79266a17d7fcb6f6ec04..git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/55fedb1a47..79ff382907 * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/57697a9873..c16b0dc8db * tools/skia_goldctl/linux: H5Ax0_QmNml9Df-r61hCscndRQDsCim7j6-ST_Bqc7QC..jQH5G1XR31QSX-Y7BEw3-HCqj-rqMbmFt8ia4QT9X_IC * tools/skia_goldctl/mac: VP9yR_72z50Efyz4lp6uXyLhZowfvEScnoGf8RMWlHAC..rBeQmF5YzW5gOYg2G0CKoVli5wQ536stUnVW9UXdTagC * tools/skia_goldctl/win: P8MltnujOo50R-Kl3rxhuKLOYs02wz_YJUkzOruEDYwC..XTbWn-rB8RlBWCMTnyklV8yZV_fBb4VoUNOZ9dgtQJgC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I71abad2ab63c443a3cc09364a24745d722f3d426 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3084071 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1d49cb66 2021-08-09T10:01:13 Roll vulkan-deps from ad1ae9d489da to 8e25231b71ac (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ad1ae9d489da..8e25231b71ac Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/175ecd49ed..706dc27a62 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4c901a731a..a2edd93673 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/28bd6d60be..9db21837b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I5b2573412586f8460f4ab802e59adcdfea2ea7d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3080663 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov b1b760e7 2021-08-09T13:37:10 Ignore VUID-vkCmdClearAttachments-baseArrayLayer-00018 New message added in https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/3133 Blocks vulkan-deps rolls. Bug: angleproject:6262 Change-Id: Iaaafe7539092cbe7eadd01e47b67071d60779929 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3081376 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 23a50a7c 2021-08-06T18:15:30 Serialization: Fix groups & ensure compile resolution. This change has two fixes: 1) Some texture groups had multiple duplicate keys. Namely image descs and image contents. 2) Programs and Shaders would serialize non-deterministically because we would not ensure the compile/link was resolved. Fix this by explicitly ensuring the shaders/programs are done. Bug: angleproject:5133 Change-Id: I2f7f7768c76f90275f81e032ac08e3f2bc828ea2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076134 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Tim Van Patten 06b19ed8 2021-08-06T17:02:36 Framecapture: Update file naming Update the file naming to add "shared" and remove the unnecessary frame numbering: angle.angledata.gz angle_capture_context1.cpp angle_capture_context1.h angle_capture_context1_files.txt angle_capture_context1_frame001.cpp angle_capture_shared.cpp angle_capture_shared.h Bug: angleproject:6256 Change-Id: I6454a3dc412896557f29faee1269dfa55146d43b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078908 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill 4686da27 2021-08-06T18:13:14 Add GetImage test with RGB. This test covers a case in T-Rex with an unused RGB texture that was tripping up serialization. It isn't currently possible to make the test fail but it does cover some new code paths. Bug: angleproject:5133 Change-Id: I87c066779f270752bed3c1c1882951c71f16d378 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076133 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 0e88f240 2021-08-06T18:20:05 EGLWindow: Add option to force robust init. Not currently used but may be useful in the future. Bug: angleproject:5133 Change-Id: I11c082a3285587217d5b955048547b0617b8c51b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076132 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 7ed0729d 2021-08-06T15:10:58 EGLWindow: Add option to enable capture limits. This will be useful for the replay serialization validation. Bug: angleproject:5133 Change-Id: Ib5bb2a9522b0e35e47bdf2b1321fe6a18dcdb897 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076131 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll fd4590a6 2021-08-09T07:01:03 Roll Chromium from 29702b8b93b0 to bfd7c5a55cd0 (62 revisions) https://chromium.googlesource.com/chromium/src.git/+log/29702b8b93b0..bfd7c5a55cd0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8388d56981..1b131580ae * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4d423d82f5..97a17ccfc8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c71b1c718d No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I4919c503ec72b7325511a3901abb873779845f19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3080699 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 6c415487 2021-07-26T13:08:46 Capture/Replay: Add option to override test disabling In order to be able to easily run disabled tests, add a flag --force-run-capture that makes it possible to ignore the SKIP_FOR_CAPTURE designation. Bug: angleproject:6166 Change-Id: I195248045d5c928d965f16b5ae17681d78686374 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3053363 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny af35fd22 2021-07-12T14:58:01 Capture/Replay: rework test runner to use expectations This CL changes the test runner to use a expectation file for all the tests including failing tests. The expectation file is also used to disable running certain tests. e.g. because they are known to crash or result in compilation failures, which then take down all the test in the corresponding batch. The capture_replay_tests.py script will report failure if the test result doesn't meet the expectation. In order to keep the current behaviour to run subsets of tests in tact, the test filter is also applied to the expectation. In addition to the "normal" expectations, FLAKY was added to tag tests that can be captured and compiled correctly but have unstable results. This CL also adds the expectation for ES2_Vulkan_SwiftShader and ES2_Vulkan Bug: angleproject:6166 Change-Id: Ica05303e6ae3b7c6d2b6749c2c9c6593b659cc1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3024209 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll 7f38e289 2021-08-08T01:17:25 Roll Chromium from 54236e566eab to 29702b8b93b0 (355 revisions) https://chromium.googlesource.com/chromium/src.git/+log/54236e566eab..29702b8b93b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1398273c28..8388d56981 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/90f7ea6722..4d423d82f5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c71b1c718d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5339c686ff..e989bf92db * tools/luci-go: git_revision:467ab48f5ed9f3ef32ae17f5b73a117e0c86566b..git_revision:e7749d37e8e52fd6eb9c79266a17d7fcb6f6ec04 * tools/luci-go: git_revision:467ab48f5ed9f3ef32ae17f5b73a117e0c86566b..git_revision:e7749d37e8e52fd6eb9c79266a17d7fcb6f6ec04 * tools/luci-go: git_revision:467ab48f5ed9f3ef32ae17f5b73a117e0c86566b..git_revision:e7749d37e8e52fd6eb9c79266a17d7fcb6f6ec04 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/da62336ef6..55fedb1a47 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/22df772766..e4df839dbe No update to Clang. Bug: angleproject:6158,angleproject:6228 Tbr: syoussefi@google.com Change-Id: Iec4d0184871e7eaf74d4acd49d1f822451603e01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3079560 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kenneth Russell 1654537d 2021-08-06T17:49:52 Fix default and driver uniforms' binding indices. These abstractions were introduced in the SymbolTable during upstreaming of the direct-to-Metal compiler and were accidentally swapped, leading to widespread test failures. Fix the comment reference in ContextMtl's DriverUniforms struct. Add missing emulatedInstance field, and add a TODO about its missing support in direct-to-Metal translator. Define it in SPIR-V Metal translator; the driver uniforms for the two must match. Bug: angleproject:6259 Change-Id: I0330ab4efca5b64a749b9cca90564fdbc84d7a80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078998 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0