kc3-lang/angle

Log

Author Commit Date CI Message
Junji Watanabe 4bcfc270 2022-10-03T11:19:02 Install CIPD ninja using DEPS See chromium/src's CL https://crrev.com/c/3869740 for the context. Bug: chromium:1340825 Change-Id: I6ff84c6bd3402b0a5301779af04bfee4bd26cccf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929902 Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 485f4d48 2022-10-03T07:03:09 Roll Chromium from 82e52bf17d2f to 34801c7ce64b (613 revisions) https://chromium.googlesource.com/chromium/src.git/+log/82e52bf17d2f..34801c7ce64b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2d2482275f..0a1188f24a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cccaf48c82..9174abb6ac * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/5ee02b2993..2e919977e0 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/5c3e02e92a..20a144a49a * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/7ff728a977..08ebcbe7b6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/94b0e722f5..6ff813a5ed * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..16eb727884 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e3ed6a8e01..a724859f7a * third_party/fuchsia-sdk/sdk: version:9.20220929.2.1..version:9.20221002.2.1 * third_party/r8/d8: YRMWFybrAcIrgAxXJdeWJ3Qn_MbhEUGC5vZAcOAHnJIC..bmb4lLBpRLAMLRw1TtdElddObY0_tmNi69zHS8ugBiwC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/cbb6b98dc2..6fe4ce825f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c398c4a9c1..a5e0d72349 * tools/luci-go: git_revision:78063b01b53dd33a541938207b785cc86d34be37..git_revision:20c50aa39686d91330c2daceccaa4ef1a0a72ee4 * tools/luci-go: git_revision:78063b01b53dd33a541938207b785cc86d34be37..git_revision:20c50aa39686d91330c2daceccaa4ef1a0a72ee4 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/faa6164498..9b7d6729b5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3cb8993fff..0aaadcf773 * tools/skia_goldctl/linux: WBDrUDeM_a9K-F0R-4P29K3JwXJUEWawXi_gTzC_kFgC..UdHMUZDUIpKh3Fkx8MkPeRz_hbu1MnpCmJdM7inIoQ0C * tools/skia_goldctl/mac_amd64: MQ13YYzbw_7X4YyfuuDuR8BSjHqdE2fc6Rrv6-SjmRMC..F6P1CZGSbpsEUcMbvplibXMpTLn8eJ2JEyFoJNFJRPcC * tools/skia_goldctl/mac_arm64: IJsWDjGmEqVcNpRYh5ESn0o-zH19w6FWY8osQVIQS6oC..g7lVD9PQ8qtqyTgw31tXGQr3XYgNTGXbmo0SCsi5hJEC * tools/skia_goldctl/win: GFphHdC69wbrz1vjJDhfiJCezaivApJ54F036JCnBdsC..xQDgjyn3X4sbT9v84yOcqZKH28r7ZtHM7EMnTDPGkLMC No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I4dc226ba164b57962026903f125f8dd7311fd1a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3932011 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton a7dc51f2 2022-10-01T08:49:11 Add a framebuffer fetch implementation of PLS The framebuffer fetch implementation works by attaching PLS backing textures to the framebuffer, and then rewriting PLS uniforms as "inout" fragment variables. The compiler's existing machinery takes it from there and makes it work on GL and Vulkan, and soon Metal. EXT_shader_framebuffer_fetch is now the preferred backend for pixel local storage, but we also use EXT_shader_framebuffer_fetch_non_coherent if shader images can't be coherent. This is especially interesting for Vulkan, since noncoherent framebuffer fetch is possible without any extensions. Bug: angleproject:7279 Bug: angleproject:7683 Bug: angleproject:7684 Bug: angleproject:7724 Change-Id: I33f3b2c6df9a5709969d9165c448ea71b096c9e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3900142 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Cody Northrop 9905dabe 2022-09-30T00:47:17 Tests: Add Darkness Rises trace Test: angle_perftests --gtest_filter="*darkness_rises*" Bug: angleproject:7719 Change-Id: I0b99678003662c5e0bb89a5b78490276224a8eaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929333 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 2f05dd9f 2022-09-30T22:52:16 Roll VK-GL-CTS from 7bbdc916a414 to 3739dbc26ccf (13 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7bbdc916a414..3739dbc26ccf 2022-09-30 piotr.byszewski@mobica.com Test cmdCopyBuffer with unaligned offsets & sizes 2022-09-30 ziga@lunarg.com Fix tracking image layout in load_store_op_none tests 2022-09-30 gleese@broadcom.com Enable extended_dynamic_state tests for VK1.3 2022-09-30 zzoon@igalia.com Add alpha to one tests with single sample. 2022-09-30 zzoon@igalia.com Add FSR tests with ImageView VK_NULL_HANDLE for dynamic rendering. 2022-09-30 zzoon@igalia.com Add more tests for occlusion and statistics query. 2022-09-30 ziga@lunarg.com Add tests for transfers with uneven vertical sizes 2022-09-30 michal.jakubek@mobica.com Apply BLAS pool to ray_tracing_pipeline.build.* tests 2022-09-30 marcin.zajac@mobica.com Add tests for transformFeedbackStreamsLinesTriangles 2022-09-30 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main 2022-09-29 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main 2022-09-28 souravp@nvidia.com VKSC check offline pipeline compiler result. 2022-09-27 aitor@lunarg.com Merge branch 'dev/VK_EXT_legacy_dithering' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,romanl@google.com Change-Id: Ifbdaa13b463b9d3f711123082d8ad833d5156413 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3930874 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Hailin Zhang 836cc5e2 2022-09-09T22:06:22 Vulkan: add etc to bc compute transcoding. use compute shader to transcode etc format to bc format. Bug: b/243398683 Change-Id: Idbd0820a2df8d92fe690055dae2933bc559e9bfd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3888501 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Hailin Zhang <hailinzhang@google.com>
Cody Northrop f7a5cce1 2022-09-29T10:42:26 Tests: Add Life is Strange trace Test: angle_perftests --gtest_filter="*life_is_strange*" Bug: angleproject:7711 Bug: angleproject:7723 Change-Id: I83d9d58270a80435dba8991875b20a215372334f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3928205 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Chris Dalton a81679bc 2022-09-26T23:56:34 Support EXT_shader_framebuffer_fetch on GLES All the frontend functionality for EXT_shader_framebuffer_fetch is already present, but only supported on Vulkan. This change wires it up for the native GLES backend as well. Bug: angleproject:7279 Bug: angleproject:7703 Change-Id: Ie1fce79e08a78662c8af65d33f3d8417c96cf58e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3920577 Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Brian Sheedy 0a288f29 2022-09-30T18:25:04 Revert "EGL: Stop announcing EGL_EXT_image_dma_buf_import_modifiers" This reverts commit 11ac69d0a4942a0bbbf71193c10a39eb054d1448. Reason for revert: Breaks ChromeOS tests crbug.com/1368287 Original change's description: > EGL: Stop announcing EGL_EXT_image_dma_buf_import_modifiers > > The extension was enabled in > https://chromium-review.googlesource.com/c/angle/angle/+/2128190 without > implementing the required functions, `DisplayImpl::queryDmaBufFormats` > and `DisplayImpl::queryDmaBufModifiers`, resulting in crashes. > > Bug: angleproject:7664 > Change-Id: Ifbb0a182171646df8161f6f42eafe2a476fea6b2 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3902321 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7664 Change-Id: Idfeecffc18bebfbda5256ad510ee0c60aeb1338f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3930547 Reviewed-by: Roman Lavrov <romanl@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org>
Shahbaz Youssefi 583fd03e 2022-09-29T16:28:05 Translator: Fix ClampIndirectIndices vs. unsized arrays A deepCopy() was missing from this code path, which led to an AST validation error. However, clamping indices for unsized arrays is not strictly correct. For example, an out of bounds write with robustness is expected to be dropped, not overwrite the last element. Since robustness already covers storage blocks, this clamping is no longer done. Bug: angleproject:7712 Change-Id: I96dd18ef47cd453f19391bdccbd4372c24854ade Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3924863 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Corentin Wallez 90201481 2022-09-30T17:37:15 Add missing include for std::function A roll of libc++ in Dawn finds these issues. Bug: dawn:1532 Change-Id: I5e3f8e89630b13e22b2942e10648761bed80920c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3925805 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Jamie Madill 67af8d89 2022-09-19T15:19:57 Perf Tests: Make dynamic step count calibration optional. This uses a fixed test time for the tests, instead of using an extra step to calibrate a number of steps to run in an approximate maximum time. Before: 1. run a test for <test time>, return the number of steps 2. for <num samples> x <num trials> times, run the tests for that number of steps After: 1. for <num samples> x <num trials> times, run the tests for <test time> This saves some total time since we don't need to run the tests in a pre-process to calibrate the number of steps, and it also makes this test script more like the restricted trace perf script. Bug: angleproject:7671 Change-Id: I413cbf8d65f9f2f87781d8607f799d2450a71ea7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3906144 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 74b37bcb 2022-09-30T12:28:22 Remove run_gtest_angle_test script. Shouldn't be used after crrev.com/c/3399045 and crrev.com/c/3035587 Bug: angleproject:5417 Change-Id: Iadf629d94a561a99ebfe2539dbabda5e17db5be6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929144 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 63c54da3 2022-09-29T22:32:54 FrameCapture: Fix default uniform sampler base loc Follow up to: https://chromium-review.googlesource.com/c/angle/angle/+/3928253 Samplers are handled specially above the previous changes. Test: Darkness Rises MEC Bug: angleproject:7719 Bug: angleproject:7720 Change-Id: I72848eaced4da379fe724aebf61a75616f614e1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929328 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll 4f6d223c 2022-09-30T10:01:35 Roll SwiftShader from 4dbbcd05ce72 to 666fb5f89f5a (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/4dbbcd05ce72..666fb5f89f5a 2022-09-29 swiftshader.regress@gmail.com Regres: Update test lists @ 4dbbcd05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I5ee25ef0d298f2428d6ed977d83773e708441d19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929688 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 943d71e1 2022-08-11T10:17:06 gl_test: add a test to capture/replay MEC with EGL images Bug: angleproject:7564 Change-Id: I1cb84c5bccd20b5614ddd400797f112138f8c200 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3826162 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 1f899f55 2022-09-30T08:21:56 Roll Chromium from 5c4a77844a5d to 82e52bf17d2f (602 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5c4a77844a5d..82e52bf17d2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9868184629..2d2482275f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/133d7cdb35..cccaf48c82 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/11bdb46a42..5ee02b2993 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b1c37f6f10..94b0e722f5 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e594b95790..b44f27b137 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5eb0675d9c * third_party/fuchsia-sdk/sdk: version:9.20220928.2.1..version:9.20220929.2.1 * third_party/r8/d8: ph4ji7m0nOipD5V48QjtM23WPzpNxYAOFUzDJ6cHBXUC..YRMWFybrAcIrgAxXJdeWJ3Qn_MbhEUGC5vZAcOAHnJIC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/209fff0a4f..c398c4a9c1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/92b729fbc4..faa6164498 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d88a81a644..3cb8993fff Clang version changed llvmorg-16-init-5189-gbfcd536a:llvmorg-16-init-6084-g2f3d7c2c Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/209fff0a4f6b87435669c94b4aa6ed4da73bdbf5..c398c4a9c1a3c9ffdb431e075b8ec0bc61747c48/scripts/update.py Bug: None Tbr: romanl@google.com Change-Id: I869e21fdeb592f845750321c8872797b06f85c5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929336 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Constantine Shablya ff7aa214 2022-09-29T19:56:28 GL_PALETTE* sampling Implement GL_PALETTE* formats by decoding them into a R8G8B8A8_UNORM image at load time. Test: angle_end2end_tests --gtest_filter="PalettedTextureTest.*" Bug: angleproject:7599 Bug: angleproject:7688 Bug: angleproject:7710 Change-Id: I94d51e2c480fcdd39f1a0ad241b311d3b4de1579 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3863251 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Constantine Shablya <constantine.shablya@collabora.com>
Antonio Maiorano 3cc948ad 2022-09-29T21:09:11 Scope LogMessage debug mutex lock to avoid deadlock on ANGLE_CRASH In the LogMessage destructor, in debug builds, the g_debugMutex gets locked; however, if ANGLE_CRASH() is called at the bottom of the function, and SEH (via /EHsc) is used (such as in googletest), then the lock destructor will not get called, and the mutex will not be released. If another LogMessage is created subsequently, the process will hang on attempting to lock the mutex again. This is exactly what happened when this Dawn unit test failed, and would hang for about 2 hours until the runner timed out: http://go/bbid/8801856579635182833 This CL scopes the lock to not include the ANGLE_CRASH() call (and the break into debugger). Bug: angleproject:7715 Change-Id: Ib31ad9c0641a521e28f1179c079ba1555c3274e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3928211 Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 053c6a06 2022-09-20T15:17:28 Vulkan: Add more tests for attachmentless framebuffer This CL adds below test scenarios for attachmentless framebuffer: 1. Create first attachmentless framebuffer with larger size, and create second attachmentless framebuffer with smaller size. 2. Create an attachmentless framebuffer with smaller size, and grow its default width and height. 3. Create an attachmentless framebuffer with larger size, and shrink its default width and height. 4. Create an attachmentless framebuffer with larger size, given it an attachment with a medium size, and shrink its default width and height. This CL also splits the test failure bugs on different vendor and renderer to different bug tickets. This CL addresses a bug on vulkan backend: only skip onFramebufferChange() if the framebuffer has at least one attachment, and mCurrentFramebufferDesc equals to priorFramebufferDesc. Otherwise in test scenario 2 and 3 above, we will use the wrong scissor size, because the FramebufferDesc remains the same before and after changing the default width and height, and we will wrongly skip onFramebufferChange() where we update scissor area to match with the new default width and height. Bug: angleproject:7666 Bug: angleproject:7697 Bug: angleproject:7699 Bug: angleproject:7700 Bug: angleproject:7705 Change-Id: Ieb143b27f8c1a229dab8f43d0a16e3e871185941 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3908332 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop a047af14 2022-09-29T16:12:28 Disable NV_framebuffer_blit during capture This extension is only available on ANGLE and Nvidia. Disabling the extension allows for a more portable trace. Test: Life is Strange MEC Bug: angleproject:7711 Change-Id: I11d941af97a504386a53a6ba7ac4008b1f4300a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3928208 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 5a80e19b 2022-09-29T20:18:25 Roll vulkan-deps from 9af2b2b2ef97 to cce3d29fab2b (35 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9af2b2b2ef97..cce3d29fab2b Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b40f87f1d3..28b53119bd * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/ddaa2da629..81ba8f78f6 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/87d5b782be..4bd8fc0c8c * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/11d0d16227..3ec6b3698e * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/5177b119bb..0df9899602 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3090fc12bd..9c40a28e3e * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/5b4f221819..facac95131 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/221bb37645..0a7b14dce3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I136c924998b2eb12e84eaab628f56841abb6496a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3928204 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 6dc30c00 2022-09-29T08:41:53 FrameCapture: Reset default uniform arrays If an application has updated a single uniform in the middle of an array, we need to emit the Reset call for the entire array. We don't track Reset calls per individual location in an array. Test: Life is Strange MEC Bug: angleproject:7711 Change-Id: Idec991ad060eb5e12272713a58aa921c5912f1cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3928253 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill c5fc9c22 2022-01-18T09:15:13 Don't use run_gtest_angle_test. Instead use the wrapper script in the run directory, and process sharding args directly in the test runner. Also removes passing --bot-mode, instead using the Chrome-based wrapper script to implicitly pass --test-launcher-bot-mode. Bug: angleproject:5417 Bug: angleproject:6937 Change-Id: I11882e10eb2e4d86ba9333326e7aab8eeb64e8db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3399045 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org>
Roman Lavrov 4d096ce4 2022-09-28T10:57:58 Move cflags added by script to its own cc_defaults. This simplifies the downstream "-fno-unwind-tables" diff as we'll have it all in one place, and also avoids having it dependent on `arch` (which adds complexity as described in b/242929755#comment6) Android.bp diff (might take a while to render): https://diff.googleplex.com/#key=2ssQav0Jzifk Search for `third_party_zlib_zlib_arm_crc32` to see how it resolves the `arch` issue. Tested locally that it builds (arm64 and x64). Bug: b/242929755 Change-Id: I46c71e50942dfe42075b7ffef722e6c009fbf316 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3923457 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop 055d4c2f 2022-09-28T17:31:37 Tests: Add Star Wars: Galaxy of Heroes trace Test: angle_perftests --gtest_filter="*star_wars_galaxy_of_heroes*" Bug: angleproject:7709 Change-Id: I00937ea7e637d618999ec57af6e1b5efed56ebe3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3927947 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 6f037273 2022-09-28T18:46:13 Make last lines of batch stdout more visible in logs. So that it looks like this: https://gist.github.com/romanl-g/dd0d2f7e0eddf16fd802bed97789024c Bug: angleproject:7708 Change-Id: Ic92a9de6cba24637119ae9041e9126364d414948 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3923459 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com>
Jamie Madill b681e939 2022-09-19T13:20:23 Turn on trace data hash checking automatically. This should save time uploading trace data already present on the device. Bug: angleproject:7671 Change-Id: Ie655cba284b6b3aec2e264cd4d64e4d18ebff8a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3905902 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll 2a4dddcf 2022-09-29T10:01:52 Roll SwiftShader from 52e0004a627b to 4dbbcd05ce72 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/52e0004a627b..4dbbcd05ce72 2022-09-29 syoussefi@google.com Consistently use `const auto` 2022-09-28 syoussefi@google.com Consistently use auto * instead of auto when pointers 2022-09-28 swiftshader.regress@gmail.com Regres: Update test lists @ 52e0004a 2022-09-28 sugoi@google.com Temporarily fix pipelineStageCreationFeedbackCount = 0 issue 2022-09-28 srisser@google.com Update mipmap precision bits If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I3f6675744033ae2fa47ec54b4317412e8ebe20dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3928544 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0d5ba4e0 2022-09-29T07:02:18 Roll Chromium from b6105122ebd7 to 5c4a77844a5d (596 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b6105122ebd7..5c4a77844a5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4f7a8d7266..9868184629 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f9d0f8488f..133d7cdb35 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/71619e734c..11bdb46a42 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7b6ba87ea3..b1c37f6f10 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/fa30a0badb..751b72a8c1 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/47a0ef5311..e594b95790 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5eb0675d9c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fcf9fc4c36..e3ed6a8e01 * third_party/fuchsia-sdk/sdk: version:9.20220927.1.1..version:9.20220928.2.1 * third_party/r8/d8: xpZ7PmWRng3qxWvJQkt5btj_zJ-3QbBxahH-_MsVX48C..ph4ji7m0nOipD5V48QjtM23WPzpNxYAOFUzDJ6cHBXUC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6d9f2a7eed..92b729fbc4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6886879e42..d88a81a644 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I72e08d9867aceabfa7a49e50edb1d93144dd9de2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3928302 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi d524157f 2022-09-28T23:16:02 GLES1/Vulkan: Don't validate SPIR-V as VVL does the same Improves TexCombine runtime by ~15%. Bug: angleproject:6644 Change-Id: I01f580fef0caa91ebf600cfc0bbbeca1aa20eb06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3926037 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 1abeeaae 2022-09-28T12:22:58 GLES1/Vulkan: Remove double SPIR-V validation assertion The SPIR-V transformation is validated on program link because many tests link programs but don't draw with them. This helps catch bugs. However, GLES1 programs are always created right before draw, so the SPIR-V transformer will definitely be run on them. The link-time validation is thus unnecessary. This change disables the latter on GLES1, which cuts down the TexCombine test run time by about 10%. Bug: angleproject:6644 Change-Id: Idb9d229fc08bf746f933fa8924fa67e5426f87a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3926036 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Robert Mader bf22843c 2022-09-22T16:58:37 EGL: Update EGL headers In order to implement EGL_EXT_device_drm_render_node Bug: angleproject:7686 Change-Id: If9b0e2852a816071bad79c103f1e291dd43eb45c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3913209 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Robert Mader <robert.mader@collabora.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 65d3d0f6 2022-09-19T10:42:43 run_perf_tests: Add option to find test binary in out dir. This allows us to run the perf test runner script from any directory and use that as a basis to find the most recently modified test suite binary. This saves us from chdir()ing into test directory every time we want to run a test suite. Ideally this should move into the test utils folder to be used by the gold tests script as well. Bug: angleproject:7671 Change-Id: Iead98670bb5f7627ae32f7ac41b4ebcee2726841 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3904427 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll adba8136 2022-09-28T10:01:32 Roll SwiftShader from 49e4cc58722e to 52e0004a627b (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/49e4cc58722e..52e0004a627b 2022-09-27 syoussefi@google.com Support VK_EXT_graphics_pipeline_library If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I73de5f54a31e66915e2ea98fe311670203bde9c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3924168 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Johannes Kauffmann 1b908d0a 2022-09-28T00:43:13 HandleAllocator: add missing <limits> include The existing <algorithm> and <functional> includes are not specified to also include <limits>, which is required for std::numeric_limits<T>::max and friends. Bug: None Change-Id: I4cee038b652a887ef5cdf82098fbc62bd4fc7483 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3924334 Auto-Submit: Johannes Kauffmann <johanneskauffmann@hotmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang 5c995ef3 2022-09-28T08:06:13 Revert "EGL: Implement EGL_EXT_image_dma_buf_import_modifiers" This reverts commit 1d8dce2587a23b59f911c801856372996bdb2f64. Reason for revert: causes test failures on chromeos kevin bot b/248404756 Original change's description: > EGL: Implement EGL_EXT_image_dma_buf_import_modifiers > > This reverts Ifbb0a182171646df8161f6f42eafe2a476fea6b2 and implements > the previously missing bits. Inspired by the corresponding Vulkan > implementation. > > The extension is used by an upcoming Exo feature which was successfully > tested with this patch, see > https://chromium-review.googlesource.com/c/chromium/src/+/3857556 > > Bug: angleproject:7664 > Change-Id: I951d1a787e1db3a77b19fcea6186b7aa0a29872f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3904345 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7664,b/248404756 Change-Id: Ib46d3ca76ce575be593dfa5322315621fb006158 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3924955 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll 3a8437fd 2022-09-28T07:00:49 Roll Chromium from 401265d5586d to b6105122ebd7 (609 revisions) https://chromium.googlesource.com/chromium/src.git/+log/401265d5586d..b6105122ebd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4c6e936292..4f7a8d7266 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/7fca26a6d1..f9d0f8488f * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c23f69f322..71619e734c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cddecff250..7b6ba87ea3 * third_party/android_build_tools/lint: 5VEarWAn_3EKCg2sfWwuJwgimmh4wV86NgyCEVR-1GYC..DO1bMH_JFEfZXSkAknIs7AfgNh4IwLtJaeMJTdzfuJwC * third_party/android_build_tools/manifest_merger: XhGZiPc3z6aGVUr2C_t4rtWPdqtON_KEjj1eAl4ubgAC..0cYQOUjN8K9fAtfcm6Vwi30XcO6mPJU_5v4-pUkBg0sC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5eb0675d9c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9ef048cd50..fcf9fc4c36 * third_party/fuchsia-sdk/sdk: version:9.20220926.3.1..version:9.20220927.1.1 * third_party/r8/d8: xSIcikL1PDal0LfVuHAK-q1NOalVeNp3x9KaFZ8Yju4C..xpZ7PmWRng3qxWvJQkt5btj_zJ-3QbBxahH-_MsVX48C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8f22e90f00..cbb6b98dc2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0c9138dee3..6d9f2a7eed * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9a43283e09..6886879e42 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I78ad5fcacdffcff7ad33a4002ae98b93b0d66fb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3924036 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi b9cd542e 2022-09-15T17:31:35 Vulkan: Use serial to check which FBO has open RP In preparation for the scenario where an imageless framebuffer is shared, checking whether the started render pass belongs to a certain framebuffer is tweaked to use a serial-based method instead of checking the framebuffer handle. * Added the last render pass serial to ContextVk, which increments every time a render pass begins. The serial is also stored in the FramebufferVk object invoking it. * Added the type RenderPassSerial for this purpose. * Serials are generated through a serial factory in ContextVk. * Updated hasStartedRenderPassWithSerial() to match the serials instead of the handles. * Removed the getFramebuffer() calls from FramebufferVk and UtilsVk that are now unused. Bug: angleproject:7553 Change-Id: Id60dcbf7973558d35e55ff4af4c71e50c6853bba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3897970 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi c1dc9de5 2022-09-27T12:49:21 GLES1: Enable SpotExpDir Likely fixed by the lighting fixes. Bug: angleproject:6201 Change-Id: Idc74d4e169dd3c1b2176b6db0a2559c25197ebd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3922777 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 74c2f2d3 2022-09-27T11:40:51 GLES1: Enable UserClip tests Passing now. Bug: angleproject:3408 Change-Id: I4306f5eb8ae85d52dca8956cc22eac49ce957a14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3922775 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 36424efd 2022-09-27T12:02:54 Don't set configs empty in angle_gpu_info_util Added in https://crrev.com/c/3915081, seemingly unintentionally: angle_static_library defaults to angle_common_configs, not empty list Spotted accidentally due to diffs in an Android roll: https://screenshot.googleplex.com/8WrA4wu3NZeTyYZ Bug: chromium:1340081 Change-Id: If379e5ce449dd6bb43f778a3b0a963ed20d67eff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3922776 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop 380ae37b 2022-09-26T21:34:22 Tests: Add Sky Force Reloaded trace Test: angle_perftests --gtest_filter="*sky_force_reloaded*" Bug: angleproject:7701 Change-Id: I6d86c760d007807a14cc88e869e8fc3c5e8f6a2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3920575 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 7d0c5cc0 2022-09-26T20:47:48 Tests: Add Gacha Club trace Test: angle_perftests --gtest_filter="*gacha_club*" Bug: angleproject:7698 Change-Id: I84d055115235fb5506b8d14b5777b3070ed2728a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3920574 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov f65554d9 2022-09-27T11:30:38 functools.cache -> functools.lru_cache .cache is "too new", >= py3.9 and just wraps lru_cache to look nicer. Bug: b/246559064 Change-Id: Id4f4fd7b5ef88deee4b46ff9eab442c4fa2644fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3922774 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Lubosz Sarnecki 97bdac9b 2022-09-13T11:09:51 Tests: Add Zenonia 4 trace. Test: angle_perftests --gtest_filter="*zenonia_4*" Bug: angleproject:7652 Change-Id: I7a3ff361085ba64f389be8ed487af635400fa2e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3913504 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll f297a1ba 2022-09-27T10:01:12 Roll SwiftShader from 4f495efb55d4 to 49e4cc58722e (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/4f495efb55d4..49e4cc58722e 2022-09-26 sugoi@google.com Remove incorrect assert If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I638f67ee1fa947b90426f1f46e2df6e0150a370c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3921336 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6abd93db 2022-09-27T07:01:26 Roll Chromium from 73f358f3727f to 401265d5586d (564 revisions) https://chromium.googlesource.com/chromium/src.git/+log/73f358f3727f..401265d5586d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f87b9ff92e..4c6e936292 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/15fa3e772d..7fca26a6d1 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4d2c483d6d..c23f69f322 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/790b2291a5..cddecff250 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ca067aa89d..fa30a0badb * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/342bcbcba3..47a0ef5311 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5eb0675d9c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/08bb5c487f..9ef048cd50 * third_party/fuchsia-sdk/sdk: version:9.20220919.2.1..version:9.20220926.3.1 * third_party/r8/d8: yLqNlRPjLffH3UB3LM_-5qHmatPQNt_SzRz4BoZhjtQC..xSIcikL1PDal0LfVuHAK-q1NOalVeNp3x9KaFZ8Yju4C * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/2d782e232a..0c9138dee3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ca01098c09..9a43283e09 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I09074d31d3d472bd2097e406196f83fc6bb96d0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3920578 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi dd0fc335 2022-09-26T22:56:29 GLES1: Make CTS verbose The `machine` parameters were uninitialized (set to 0 as globals). As a result, the test failure messages were not emitted, making it harder to understand what is failing. Bug: angleproject:3408 Change-Id: Ib8351755af24e01736314d1832160edf10a8e767 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3920894 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 01285f16 2022-09-26T23:19:28 Remove Platform.h Overloaded name. Causing trouble with gles1's platform.h on case-insensitive file systems despite the different case. Bug: angleproject:3408 Change-Id: Icc1644a4c6a9c9076a2bbafbfb1d6eac578b731a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3920895 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 163e56e4 2022-09-20T00:40:55 Allow feature overrides to end in * (wildcard) Makes it easier to apply overrides to features with long names. Also works around Android's limit of 92 characters for debug properties. Bug: b/238024366 Change-Id: I8f417287f92b2439de1a7b7d6abbaf9e61b405e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3906222 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Geoff Lang 818a8ace 2022-09-26T19:50:03 Revert "Vulkan: Add missing part for supporting GBM Platform type" This reverts commit 43354edbe671af534c469089066e0259731563c7. Reason for revert: Fails on ChromeOS bots in Chrome. Original change's description: > Vulkan: Add missing part for supporting GBM Platform type > > Adds missing part to support GBM platform type. > > Bug: angleproject:7481 > Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> > Change-Id: I46caa4a958274de1111b30b144df592ac4cdcf6e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3736243 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jeff Vigil <j.vigil@samsung.com> > Reviewed-by: Antonio Caggiano <antonio.caggiano@collabora.com> Bug: angleproject:7481 Bug: angleproject:7696 Change-Id: I76fa4e38ea1f866575bc38725c23b697d17b53a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3918856 Reviewed-by: Geoff Lang <geofflang@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Peng Huang 28aadf46 2022-09-26T09:20:49 Fix CFI problem in SystemInfo_vulkan.cpp SystemInfo_vulkan.cpp gets and call vulkan functions with pointers. It cause test failures with Linux CFI bot. Fix the problem, by disabling cfi checking for it. Bug: chromium:1340081 Change-Id: Ife04cd2002d77324a665393b6a05cdd5193284bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3915081 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Roman Lavrov c630e283 2022-09-26T11:52:56 Cleanup: simplify merge_bps. Less code and branching by using dict.setdefault, dict.get, set.intersection, comprehensions. Did this while looking into b/242929755#comment6 and found the code a bit difficult to follow. Bug: b/242929755 Change-Id: I6f6da6b2986e7c5a278573d6eaf730913d47b5a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3918851 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang 25bad36c 2022-09-23T13:23:57 Metal: Remove unpackLastRowSeparatelyForPaddingInclusion This speculative fix did not work. Bug: angleproject:7573 Change-Id: I345db1746f8725d82420aabffb37c8dd01230a34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3915182 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Gregg Tavares <gman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Geoff Lang 70e5e90f 2022-09-23T13:17:34 Metal: Avoid locking IOSurfaces in glReadPixels on AMD. The AMD driver tends to crash when locking IOSurfaces. Avoid this by using the copyIOSurfaceToNonIOSurfaceForReadOptimization feature to do a texture-texture copy before reading back data to the CPU. This is a *speculative* fix due to seeing crashes in the ClientLockIOSurface function in the AMD driver. Bug: angleproject:7573 Change-Id: Ia120f2a96eed65431b5f8a99cf1da7d7e85da639 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3915181 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Gregg Tavares <gman@chromium.org>
Roman Lavrov bc21af43 2022-09-23T11:38:17 Cleanup: readability and make --genAndroidBp non-destructive. `roll_aosp.sh --genAndroidBp` used to nuke out/Android. Move that out of the function so that it's only nuked when ran without args. Add a warning at the top of roll_aosp.sh. Use explicit flags to avoid dependency on keeping ABI ordering in sync between roll_aosp.sh, also makes it easier to understand when looking at --help etc. Use all caps for module-level constants, common in python. Replace @cache with python3's @functools.cache. Switched to python3 in https://crrev.com/c/3907879. Bug: b/242929755 Change-Id: Ib3fcd46c283f00e3d2d573c1ac7bbb6f6c1231e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3913627 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 8af5ea79 2022-09-26T10:01:12 Roll SwiftShader from 0dd58092b204 to 4f495efb55d4 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/0dd58092b204..4f495efb55d4 2022-09-24 swiftshader.regress@gmail.com Regres: Update test lists @ a90523fa 2022-09-23 sugoi@google.com Set conformance version to 1.3.3.1 2022-09-23 tristan.van.berkom@gmail.com Avoid inadvertently adding a wayland dependency 2022-09-23 sugoi@google.com Temporary patch for OOB read issue 2022-09-23 sugoi@google.com Partially revert "Pipeline robustness fix" 2022-09-23 wangqing-hf@loongson.cn marl: Add new source file for loongarch64. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ib90938ef6d81e6782d834267b2006ac62774ac6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3917695 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c7306ecd 2022-09-26T07:01:00 Roll Chromium from c4be4c7e0a43 to 73f358f3727f (154 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c4be4c7e0a43..73f358f3727f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2f2727f2d4..f87b9ff92e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b79692f320..15fa3e772d * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a4dc7f17ca..4d2c483d6d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5eb0675d9c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/40b472e305..209fff0a4f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4d5e36a4f4..ca01098c09 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I4310b8b1fc85084a4f67b78a0e128aa7bbc0130e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3916042 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 2aa52da7 2022-09-23T13:15:44 Metal: Upload IOSurface data with staging buffers on AMD Crashes have been seen in the AMD driver when locking IOSurfaces. Avoid this by always using a staging buffer and doing a GPU-GPU copy for uploading client side data to IOSurfaces. Bug: angleproject:7573 Change-Id: I4d981a24554a755a7248199699b486d98cbad83d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3915180 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Gregg Tavares <gman@chromium.org>
angle-autoroll b59609c5 2022-09-24T08:33:01 Roll Chromium from a63c34f9ead3 to c4be4c7e0a43 (867 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a63c34f9ead3..c4be4c7e0a43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/806b01ed96..2f2727f2d4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/154d994baf..790b2291a5 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/3f9b61db95..342bcbcba3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5eb0675d9c * third_party/r8/d8: Qn31g4m2cofkyvGgm46Uzkzds5DKdNYrdPePwRkVnv4C..yLqNlRPjLffH3UB3LM_-5qHmatPQNt_SzRz4BoZhjtQC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/082ae7e274..40b472e305 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e48843f70d..2d782e232a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b9495c6a27..4d5e36a4f4 * tools/skia_goldctl/mac_arm64: jlDLLpfmnZhh8JXbe-APEB1MB3rL8A_DZRfgESIFivsC..IJsWDjGmEqVcNpRYh5ESn0o-zH19w6FWY8osQVIQS6oC Clang version changed llvmorg-16-init-4949-g8ace9ea258c9:llvmorg-16-init-5189-gbfcd536a Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/082ae7e2740667a50444c6f80eece71c73c56352..40b472e3053a3e13d350d842ccafe7f23d75c256/scripts/update.py Bug: angleproject:7689 Tbr: abdolrashidi@google.com,ynovikov@google.com Change-Id: I4dd84361b4764c14a1a00e04c1ceff46c029fce8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3916795 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 1fc6c49c 2022-09-23T16:39:26 Log additional info when "failed to record some samples" Check each sample instead of total in the end to make it more clear. Bug: angleproject:7117 Change-Id: I7d6137c535266e4cf47e772b816cfb8bfa4575d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3916516 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com>
Peter Kasting 9f40871c 2022-09-23T10:29:02 Roll third_party/jsoncpp. Bug: chromium:1284275 Change-Id: Ic5260275ae3c2cc5c38f8bbb33c216149e82397d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3913630 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi f4389797 2022-09-23T15:36:13 GLES1/Vulkan: Enable GL_EXT_multisample_compatibility ... with a non-conformant implementation. This unblocks some tests that unnecessary call glDisable(GL_MULTISAMPLE) and trip up on it generating validation error. Bug: angleproject:7676 Bug: angleproject:7657 Bug: angleproject:3863 Bug: angleproject:3864 Change-Id: Iaebbea66da81fc9a30bf7a87deed7cf88ff38476 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3891546 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi bc447ca4 2022-09-20T22:38:16 GLES1: Move lighting to vertex shader In the spec, lighting is done as part of vertex processing, and results in a new vertex color. Texturing is applied later. ANGLE however did lighting in the fragment shader. With this change, lighting is moved to the vertex shader. This fixes rendering of lit objects, as interpolation is done linearly or flat between the vertices per spec, instead of done precisely per fragment. While typically this is inferior to per-fragment lighting, it's what the spec mandates. On the dr_driving trace, this reduces the render pass time by ~20% on Pixel 6. Bug: angleproject:6201 Bug: angleproject:6644 Change-Id: I10e37df8c56c22d520a738af8f8630bc6a01ca7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3906394 Reviewed-by: Constantine Shablya <constantine.shablya@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sungyong Choi 43354edb 2022-06-30T10:18:41 Vulkan: Add missing part for supporting GBM Platform type Adds missing part to support GBM platform type. Bug: angleproject:7481 Signed-off-by: Sungyong Choi <sywow.choi@samsung.com> Change-Id: I46caa4a958274de1111b30b144df592ac4cdcf6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3736243 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jeff Vigil <j.vigil@samsung.com> Reviewed-by: Antonio Caggiano <antonio.caggiano@collabora.com>
Shahbaz Youssefi ab255263 2022-09-20T22:37:00 GLES1: Fix material color update when COLOR_MATERIAL According to the spec, when COLOR_MATERIAL is enabled, the material ambient and diffuse colors are updated on every glClear* call. Additionally, setting these values individually is ineffective when COLOR_MATERIAL is enabled. Bug: angleproject:6201 Change-Id: I846513c983254a043ea83101c0f83025c12b4364 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3906392 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang 9f99d594 2022-09-22T10:04:42 Add driverApiVersion in GPUDeviceInfo Bug: chromium:1340081 Change-Id: I9a1b190d3299b4f5e4603ac3e45869f385df0c48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3913426 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Dan Glastonbury d2a58f00 2022-09-08T14:19:21 EGL: Implement eglCopyMetalSharedEventANGLE Add eglCopyMetalSharedEventANGLE function to the ANGLE_metal_shared_event_sync extension. This brings the extension on par with the EGL_ANDROID_native_fence_sync extension. eglCopyMetalSharedEventANGLE allows for copying the Metal event object from EGLSync objects implemented by the ANGLE Metal renderer. This function follows Objective-C convention for "copy" methods and increases the retain count of the Metal event object. The EGL API user is thus responsible for ensuring to release the returned object to avoid memory leaks. Test: angle_end2end_tests --gtest_filter=EGLSyncTestMetalSharedEvent.* Bug: angleproject:7561 Change-Id: I8c35b559014b85cb8c6a0e76ac2ab7891eed5da0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3881423 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll 655cc456 2022-09-22T23:35:50 Roll vulkan-deps from c9e298759959 to 9af2b2b2ef97 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/c9e298759959..9af2b2b2ef97 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/fa16134161..221bb37645 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Idccd229a7ece9f9defba95f108bbb8ea37364f38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3915328 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 5e3bf6d8 2022-09-22T15:53:39 Tests: Add Eve Echoes trace Test: angle_perftests --gtest_filter="*eve_echoes*" Bug: angleproject:7215 Bug: angleproject:7690 Change-Id: Ib636ab57831cddac5fe793ec5cf7d05764e90766 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3914041 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 7d82f62a 2022-09-23T12:58:31 Roll SwiftShader from bd8f8a8fc544 to 0dd58092b204 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/bd8f8a8fc544..0dd58092b204 2022-09-23 swiftshader.regress@gmail.com Regres: Update test lists @ bd8f8a8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I339bdb6c1217b202bd934af3871bcd26107c9c64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3915558 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 2debd07d 2022-09-21T11:40:18 Automatically query status of features for tests Now tests can skip based on what features exist, compared to what features are explicitly asked for. For example, a test suite may override-enable a (normally disabled) feature that depends on a hardware capability. With this change, it can be skipped if said hardware capability doesn't exist. As a bonus, tests now correctly skip if the feature is overriden through an environment variable. This change also cleans up VulkanPerformanceCounterTest tests which did the same for a number of specific features. Bug: b/243398683 Change-Id: I84f026e3394eab56fd123e02bee72720c7ed94c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3909789 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 5d15e9c6 2022-09-22T22:50:50 Roll vulkan-deps from 90c58209c2e3 to c9e298759959 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/90c58209c2e3..c9e298759959 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/adf0995bb9..ddaa2da629 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8e2c50886a..fa16134161 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I4ceed17fddf2d6ac947f46e3cb5ea8ddecef7f13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3915325 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Gregg Tavares 7d712c47 2022-09-08T09:42:10 Metal: ProvokingVertexHelper stop using a separate cmdbuffer This simplifies the code. Without this you always need to be aware that the provoking vertex helper's command buffer might have commands in it that need to be committed before starting other operations. Bug: angleproject:7643 Change-Id: I1c73d451c12c268ecbdb6a1cd63a77c291949ef9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3884275 Commit-Queue: Gregg Tavares <gman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Brian Ho 3cfea56c 2022-09-21T13:55:02 Avoid ANGLE formats on dmabuf-backed EGL images DrmFourCCFormatToGLInternalFormat can return ANGLE-internal formats that are only used on the Vulkan backend. This CL adds special logic to dmabuf-backed EGL images to convert those formats back to GL_RGB8. Bug: chromium:1353374 Change-Id: Id270d3d47d289620730c522d2e29d7fc67dc8321 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3911355 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org>
angle-autoroll 338cb4c0 2022-09-22T20:03:08 Roll vulkan-deps from 3a373f5689ff to 90c58209c2e3 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3a373f5689ff..90c58209c2e3 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/91c29a197f..11d0d16227 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5f9b0a44e9..8e2c50886a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I788caf3176fc340674609b94c905ed114fbd1f00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3913854 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Jamie Madill 094b49db 2022-09-19T10:13:28 Android Test Runner: Skip APK install if hash matches. Bug: angleproject:7670 Change-Id: I984fe9377728e5a575fd04be2f5cb3ed1cdbafb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3904425 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Loic Sharma 878d58f0 2022-09-22T10:26:26 Make astc_encoder optional The `astc_encoder` dependency should be optional as its not enabled when built with Chromium: https://chromium.googlesource.com/angle/angle/+/refs/heads/main/gni/angle.gni#193 Bug: angleproject:7687 Change-Id: Ie90b5f9b41b27d8ea064c28d20299bc84a803339 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3914175 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Constantine Shablya e82eaff9 2022-09-22T16:01:06 Stubs for paletted images Bug: angleproject:7599 Change-Id: Idb49f8ba07ebd3b6cad461fa9e90b856af666183 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3909396 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Constantine Shablya <constantine.shablya@collabora.com>
Amirali Abdolrashidi 0d34d4f8 2022-09-21T18:51:04 Suppress more VVL errors about vkCmdDraw*-None * Suppressed the following VVLs: * VUID-vkCmdDrawIndexed-None-02686 * VUID-vkCmdDrawIndirect-None-02686 * VUID-vkCmdDrawIndirectCount-None-02686 * VUID-vkCmdDrawIndexedIndirect-None-02686 * VUID-vkCmdDrawIndexedIndirectCount-None-02686 Bug: angleproject:7685 Change-Id: I41390ee2a2a01509367a6e98697da3ad7e3cc2e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3910174 Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 9313ee01 2022-09-22T10:01:50 Roll SwiftShader from 495c41ce34af to bd8f8a8fc544 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/495c41ce34af..bd8f8a8fc544 2022-09-22 swiftshader.regress@gmail.com Regres: Update test lists @ 495c41ce 2022-09-22 sugoi@google.com Fix create_instance_layer_name_abuse test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I4cad3dff74e1f429ce8afc238d5d818b156e29ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3912902 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0f12cf1d 2022-09-22T07:00:41 Roll Chromium from 2c406fc99b42 to a63c34f9ead3 (560 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2c406fc99b42..a63c34f9ead3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/621ff0c805..806b01ed96 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/dea2dd1d45..b79692f320 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/cec1dd0bf6..a4dc7f17ca * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/77b82eb53f..7ff728a977 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/167ce2f7ce..154d994baf * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a4119ad89a..ca067aa89d * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/8007b38021..3f9b61db95 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5b90d5e756 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d126c974c..08bb5c487f * third_party/r8/d8: vKZR8R88hGbFuOFG9Z_QBBK7TqYCAub34XjJ2TAwhW4C..Qn31g4m2cofkyvGgm46Uzkzds5DKdNYrdPePwRkVnv4C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0cb9db10f9..082ae7e274 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/30297a7bfb..e48843f70d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c0cdef957e..b9495c6a27 * tools/skia_goldctl/linux: C6ORhWPGTAD-OiqYaLuZ-zJBwdBndRNTjCdUCVDJ5qkC..WBDrUDeM_a9K-F0R-4P29K3JwXJUEWawXi_gTzC_kFgC * tools/skia_goldctl/mac_amd64: BPDLaVlOGtQ_hg6yiAr4PXk0x_7MHKrF6eCMos2EsGUC..MQ13YYzbw_7X4YyfuuDuR8BSjHqdE2fc6Rrv6-SjmRMC * tools/skia_goldctl/win: JC-5wBqTAlkmWfg6n74WF5jgf2HxvHT7fx-wTfz0OqYC..GFphHdC69wbrz1vjJDhfiJCezaivApJ54F036JCnBdsC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Id50e71aaef159f89e8e5eebb8e5002a26796a131 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3911800 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f90db550 2022-09-22T03:23:02 Roll vulkan-deps from 13962002fdf0 to 3a373f5689ff (20 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/13962002fdf0..3a373f5689ff Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/c0cf8ad876..b40f87f1d3 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/f6ca617825..adf0995bb9 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/272e4b3d07..91c29a197f * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/88ebcb08cb..5177b119bb * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/2f87e2b3a5..3090fc12bd * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/f7dff1f7dd..5b4f221819 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/92ed21f6a1..5f9b0a44e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I8def32ab3adfe4b30cbfb48b2efe9b70cf0e415c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3911796 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peng Huang 76a3f050 2022-09-21T09:03:47 Fix crash in vkGetPhysicalDeviceProperties2() In rare case, the driver may not support vulkan 1.1 and then calling vkGetPhysicalDeviceProperties2() will cause crash. Bug: chromium:1340081 Change-Id: Id612785ed97abab451dc28bf1c45014b38d7bf0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3909788 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gregg Tavares 3700a059 2022-09-22T00:04:52 Revert "Add ReadPixels Perf Test" This reverts commit ea7eff37c18d9728f7ca0796fb29cff9bb80662c. Reason for revert: It takes too long on the bots Original change's description: > Add ReadPixels Perf Test > > Trying to compare the Metal backend to the OpenGL > backend and it's useful to have a perf test. > > Bug: angleproject:7117 > Change-Id: I5a7518fdd749841c3dffb1b53a9c4bfb88813c3c > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3906338 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Gregg Tavares <gman@chromium.org> Bug: angleproject:7117 Change-Id: Ia5e3138abe6686b2f7929a5367782c47f0f7af2d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3911543 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Gregg Tavares <gman@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll 03e912c1 2022-09-21T22:27:03 Roll vulkan-deps from 7d70d765a648 to 13962002fdf0 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7d70d765a648..13962002fdf0 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/df7fec2cfa..c0cf8ad876 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/49deada730..272e4b3d07 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b48bd2b501..92ed21f6a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I0f9f407741a9a76fd3aa24a938f50d416c44617f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3911236 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b931880f 2022-09-21T21:23:00 Roll vulkan-deps from d9371f187fcc to 7d70d765a648 (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/d9371f187fcc..7d70d765a648 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ce0a206064..b48bd2b501 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I93c79688456e6b5e26402039c02c3ca258955693 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3911795 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 8b2aff28 2022-09-12T10:27:28 Implement the ANGLE_shader_pixel_local_storage API Implements the OpenGL ES API for ANGLE_shader_pixel_local_storage and adds thorough validation and testing as outlined in the spec. This feature is still implemented entirely in the frontend, but the extension now works end-to-end with a passing test suite, and can be used externally. Over time we can start gradually moving the implementation into backends as appropriate. Bug: angleproject:7279 Bug: angleproject:7647 Change-Id: I1c861a0fca96423be02e17bbe1fb7f57b99ea63f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3886462 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Loic Sharma 59f496c0 2022-09-19T14:21:35 Only close COM if it was initialized Change-Id: I4ad62ca3fe642ae255f4c808d6ae9e5d7ff72c37 Bug: angleproject:7675 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3906325 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi d78f7d20 2022-09-14T16:25:52 GLES1: Enable PointAntiAlias and RescaleNormal tests These tests are passing. Bug: angleproject:3408 Change-Id: I9cc680235a31b93e455499e83d128b8122328726 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3896213 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 2f1f9500 2022-09-14T15:52:11 GLES1: Fix behavior with incomplete mipmap textures GLES1 requires texturing to be disabled when a mipmap-enabled texture is incomplete. Bug: angleproject:3408 Change-Id: I2c3b0206282a71f9a54d77ecdf2c7e42c7175fe5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3896212 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 7edc6dab 2022-09-21T11:57:37 Suppress VVL error about vkCmdDraw-None * Suppressed the following VVL: * VUID-vkCmdDraw-None-02686 Bug: angleproject:7685 Change-Id: I1c926637729f11f58667d20ea0f5c5f545dc5181 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3910798 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Robert Mader 1d8dce25 2022-09-19T15:08:54 EGL: Implement EGL_EXT_image_dma_buf_import_modifiers This reverts Ifbb0a182171646df8161f6f42eafe2a476fea6b2 and implements the previously missing bits. Inspired by the corresponding Vulkan implementation. The extension is used by an upcoming Exo feature which was successfully tested with this patch, see https://chromium-review.googlesource.com/c/chromium/src/+/3857556 Bug: angleproject:7664 Change-Id: I951d1a787e1db3a77b19fcea6186b7aa0a29872f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3904345 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 2b4699ad 2022-09-21T12:19:20 Vulkan: Fix validation error with unset-logic-op in UtilsVk Bug: angleproject:7654 Change-Id: Ie4da045a30fdd12eedd910ade3cb5ffe95e2c9a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3909791 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 41de8a02 2022-09-21T09:08:12 Suppress VVL error about input attachment desc * Suppressed the following VVL: * UNASSIGNED-input-attachment-descriptor-not-in-subpass Bug: angleproject:7685 Change-Id: I8a23f8d4ddbc91df791f5c98b4ce1e11278b7cc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3910796 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gregg Tavares ea7eff37 2022-09-19T17:32:59 Add ReadPixels Perf Test Trying to compare the Metal backend to the OpenGL backend and it's useful to have a perf test. Bug: angleproject:7117 Change-Id: I5a7518fdd749841c3dffb1b53a9c4bfb88813c3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3906338 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Yuly Novikov 44adf8c6 2022-09-21T12:02:12 End Mac 12.5.1 qualification for ANGLE on Intel Bug: chromium:1361069 Change-Id: I1f7f8a0801432be6b94614533789f2686c1004b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3909393 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Lubosz Sarnecki dbb9f38d 2022-09-13T12:08:02 FrameCapture: Capture Texture Environment in MEC. Persist the state of glTexEnv in mid-execution capture for OpenGL ES 1.X contexts. Implement equality operators overload for the TextureEnvironmentParameters struct. Test: angle_end2end_tests --gtest_filter="TextureEnvTest.*" Bug: angleproject:7652 Change-Id: I131eec5c838c9e434e135bd3c6b050fca44c3231 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3892015 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll f621ff8a 2022-09-21T10:01:53 Roll SwiftShader from b405d5dd04c4 to 495c41ce34af (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/b405d5dd04c4..495c41ce34af 2022-09-21 swiftshader.regress@gmail.com Regres: Update test lists @ 98486622 2022-09-20 sugoi@google.com Temporary workaround for CTS bug 2022-09-20 swiftshader.regress@gmail.com Regres: Update test lists @ b405d5dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I087cad9d8e3bb29dc7c1518af333d28a629eec4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3907570 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0