kc3-lang/angle

Log

Author Commit Date CI Message
Geoff Lang 54bc3dab 2020-02-27T15:52:04 Add the ANGLE Android developer options to the ANGLE repository. The ANGLE repository will house all the scripts needed to build ANGLE.apk and the developer options are packaged in the APK. BUG=angleproject:2344 Change-Id: I29090bd91a07546a1d2ccc03a6af19f45ffa3d90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079194 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Xiaoxuan Liu b07816d6 2020-01-02T15:13:37 Vulkan: Add robust init for NULL texture image. In gl::ReadPixels(), ValidateReadPixels() will try to flush staged updates before readPixels. In the case where a texture was initialized with null RGBA data, no Framebuffer dirty bits are set, and thus the staged clear would never be flushed from the staged updates. 1. Add robust init in TextureVk::initImage to ensure image is initialized. Test: ./angle_end2end_tests --gtest_filter=\ RobustResourceInitTest*_Vulkan_AllocateNonZeroMemory 2. Update stageSubresourceRobustClear() to kEmulatedInitColorValue in the case where robust resource was initialized without full RGBA format to update init value of robust resource. Test: texture-attachment-formats.html in webgl_conformance_vulkan_passthrough_tests. 3. Revert "Suppress Vulkan RobustResourceInit tests." Revert commit a8e6a463121b9920564fb6efd7f2c857d7023fe3. Reason for revert: re-enable related robust tests. Bug: angleproject:4255 Change-Id: I79f20e0c02c2f1b1cd68ab590f0f765229f9e780 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1985503 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Brandon Schade 6c56c579 2020-01-21T11:08:36 Add Android boot animation and rounding error test This introduces an end2end test that makes the same GLES1 calls as Android's default boot animation. The test uses images of much smaller sizes, but we do the same thing with the images as the original code (it uses one image as a mask and moves the other along behind it). The original default boot animation code can be found here: https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/cmds/bootanimation/BootAnimation.cpp#422 This change also implements glTexParameterx since the default boot animation requires it. This function is part of OES_FIXED_POINT. This also includes a test to check for int to floating point cast errors when using GL_TEXTURE_CROP_RECT_OES. Tests: angle_end2end_tests --gtest_filter=*DefaultBootAnimation* angle_end2end_tests --gtest_filter=*TextureParameterTest.IntConversionsAndIntBounds* Bug: angleproject:3644 Change-Id: Ib7e99c9dc1c001c71543d03ea4dd76082192f6a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053506 Commit-Queue: Brandon Schade <b.schade@samsung.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com>
Yuly Novikov fb551728 2020-02-28T11:10:29 Suppress SwANGLE dEQP-GLES3.functional.texture.compressed.astc.* failures Started after SwiftShader enabled ASTC in https://swiftshader-review.googlesource.com/c/SwiftShader/+/41568 Bug: angleproject:4447 Change-Id: I251ff26d4972f17f1f76f8ad1df57dc9c539782c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2078755 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 1e1d7446 2020-02-28T07:33:16 Roll third_party/glslang/src 07e1a0a67aee..f13d38f3cd3c (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/07e1a0a67aee..f13d38f3cd3c Created with: gclient setdep -r third_party/glslang/src@f13d38f3cd3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I076b53154399d1d6bf03f7c1def768986d7752cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080041 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 936f9069 2020-02-28T07:01:39 Roll third_party/vulkan-validation-layers/src 38f68cce445b..8c312ef4c7a9 (5 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/38f68cce445b..8c312ef4c7a9 git log 38f68cce445b..8c312ef4c7a9 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 mark@lunarg.com threading: Remove use of debug report defs 2020-02-27 attilio.provenzano@arm.com tests: Add BP tests for small allocations 2020-02-27 attilio.provenzano@arm.com practices: Add checks for memory allocations 2020-02-27 attilio.provenzano@arm.com tests: Add BP tests for command buffers 2020-02-27 attilio.provenzano@arm.com practices: Add checks for command buffers Created with: gclient setdep -r third_party/vulkan-validation-layers/src@8c312ef4c7a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I95d6318d381accc38b0c6a8743cb7c2e3bb7927e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080039 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8c6e40d2 2020-02-28T07:01:37 Roll third_party/SwiftShader 4b34ee3de531..05f5e0b34ac8 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/4b34ee3de531..05f5e0b34ac8 git log 4b34ee3de531..05f5e0b34ac8 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 jmadill@chromium.org Add codereview.settings. 2020-02-27 amaiorano@google.com Subzero: add support for variadic calls (System V) Created with: gclient setdep -r third_party/SwiftShader@05f5e0b34ac8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I938aa6bcdd73607f4684000806d93befd8ec00d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080038 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tobin Ehlis a60e4973 2020-02-27T20:11:20 Revert "Vulkan:Include precision qualifier in GLSL" This reverts commit 93e72f5f0eb80b89334ea8fe577b32901a00b5fb. Reason for revert: This is having a negative impact on gfxbench Manhattan 3.1 tests (20-30%) with only a minor improvement (~4%) in TRex offscreen. Pulling out for now and need to re-evaluate best solution here. Original change's description: > Vulkan:Include precision qualifier in GLSL > > With this initial implementation, it's possible to get precision > qualifier mis-matches in the generated GLSL 4.50. According to the > spec this is allowed. From GLSLangSpec 4.50 section 4.7 "Precision and > Precision Qualifiers": > > For the purposes of determining if an output from one shader stage > matches an input of the next stage, the precision qualifier need not > match. > > However, when converted to SPIR-V and run through the shader validation > any mismatches will cause shader validation errors. Initially just > ignoring those errors with this commit. > > Bug: angleproject:3078 > Change-Id: Ia2b04f90f0a7b6b1302c1b1b3e32bcfd8db9ed49 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057749 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Tobin Ehlis <tobine@google.com> > Reviewed-by: Tim Van Patten <timvp@google.com> > Commit-Queue: Tobin Ehlis <tobine@google.com> TBR=tobine@google.com,timvp@google.com,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:3078 Change-Id: I84984e2a963bde573f0f1de585001ceb83623c89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079334 Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reid Kleckner 78da538a 2020-02-26T21:23:16 Revert "Vulkan: Disable global merge for volk" This reverts commit bab2b3de2273796ca15edfc46747f3bbab3f27c3. Reason for revert: A fixed clang version has been rolled in, so this flag should no longer be necessary. Original change's description: > Vulkan: Disable global merge for volk > > This optimization pass breaks the build by exporting volk's internal > binding symbols from libGLESv2.so. Since the test binary also links volk, > this causes a SEGV as the wrong (uninitialized) function pointer is > called. > > This is an LLVM bug and will be fixed upstream: > https://reviews.llvm.org/D73235 > > Bug: angleproject:4351 > Change-Id: Iebe0eabd975f8109231df30eef8c9074af8190e9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023910 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Michael Spang <spang@chromium.org> TBR=spang@chromium.org,syoussefi@chromium.org,jmadill@chromium.org Bug: angleproject:4351 Change-Id: Ie832d7d42fab7c8360f2d4d548f1708164c60d3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076138 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org>
Jamie Madill 5dde4db5 2020-02-27T15:39:30 Capture/Replay: Capture DrawBuffersEXT. The extension entry point can forward to the ES 3.0 entry point. Needed for capturing the mutiple draw buffers sample. Bug: angleproject:4433 Change-Id: I1081e6a5ad57eca6dc328947bb0f9037d47fe9f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079155 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill da6d12d0 2020-02-27T14:20:32 Fix out-of-bounds read in test. The test wasn't reserving a large enough buffer when initializing the vertex data. Fix the test buffer limits. Bug: angleproject:4430 Change-Id: I4b9a98e1af1cc8088afb871816061d7ee4dd6a2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079153 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis 698ffd02 2020-02-27T10:59:13 eglGetConfigAttrib validation missing extension check The extension EGL_ANGLE_iosurface_client_buffer adds a new attribute to the config: EGL_BIND_TO_TEXTURE_TARGET_ANGLE. However, validation was not checking the extension was present when this attribute was requested. Bug: chromium:1015454 Change-Id: I24c6e20f3b602e8a71a46f0f1e99c1472d5bbb1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2078892 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang 4d2040a6 2020-02-27T09:59:11 Make GLSLTest_ES31.MixOfAllResources more lenient. Lower precision in Vulkan caused off-by-one issues with this test. BUG=angleproject:4438 Change-Id: I17111a06133ef403be1f0c99321f1dbf8ab6083c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2078791 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Charlie Lao f0d32401 2020-02-14T14:50:25 Vulkan: Optimize element buffer conversion Uses CPU copy if the buffer is CPU visible. Also add dirty bit check to avoid repeated conversion on clean data Bug: angleproject:4400 Change-Id: I1f472703ebc4a65ee0de129c27f56b081748f900 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057758 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
angle-autoroll 201bb086 2020-02-27T07:01:36 Roll third_party/SwiftShader da659b374113..4b34ee3de531 (3 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/da659b374113..4b34ee3de531 git log da659b374113..4b34ee3de531 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 jmadill@chromium.org Fix comparison of specialization constant keys. 2020-02-26 amaiorano@google.com Subzero: add support for large stacks on Windows 2020-02-26 capn@google.com Build with -Bsymbolic to prevent symbol preemption Created with: gclient setdep -r third_party/SwiftShader@4b34ee3de531 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: angleproject:4426 Tbr: geofflang@google.com Change-Id: I11df2c2bb3b1d3f9d2faef9b2e1471f080b7d377 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076807 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3cef98b7 2020-02-27T07:01:39 Roll third_party/vulkan-validation-layers/src 3f4d08da8897..38f68cce445b (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3f4d08da8897..38f68cce445b git log 3f4d08da8897..38f68cce445b --date=short --first-parent --format='%ad %ae %s' 2020-02-26 mikes@lunarg.com scripts: Add line diff to generate_source.py Created with: gclient setdep -r third_party/vulkan-validation-layers/src@38f68cce445b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ic081ef4abe3e69ef9d4a8724314db2c1a6efc8a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076808 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott cb7f5f4a 2020-02-26T16:59:01 Vulkan: Updated expectations after SwS fixed 4259 Bug: angleproject:4259 Change-Id: I518db27a1fb50d35f2c784f655d3e7ee40f4bdf2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076415 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Yuly Novikov 8b8dc561 2020-02-26T19:09:31 Fix Android component build. Shared libraries have .cr.so extension in Android component builds. Tests were failing to load the ANGLE libraries with just .so extensions. Bug: angleproject:4396 Change-Id: I88555c830c49136623ea9da9896f86ea6204f3b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076778 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Ian Elliott e488d8b8 2020-02-26T16:11:29 Vulkan: Implement Android pre-rotation As an Android GLES driver on top of Vulkan, ANGLE must pre-rotate rendering on behalf of the application. This involves modifying the vertex shader to multiply gl_Position with a mat2 "rotation matrix". Not doing so means that SurfaceFlinger (SF) will perform a costly rotation blit before presenting every image. Setting WindowSurfaceVk::mPreTransform to mCurrentTransform tells SF to not do the blit. When the surface is rotated 90 or 270 degrees, the width and height must be swapped for: - The swapchain images, and for any depth, stencil, and/or multisample attachments used with the swapchain image. - The viewport, scissor, and render area. Because the Metal back-end shares the TranslatorVulkan, it will define the same preRotation (mat2) DriverUniform that is used for Vulkan. Bug: angleproject:3502 Change-Id: I968dbe8869ba0f50de18dd41f1195e847c06b545 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2038272 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang ba8ef68c 2020-02-24T14:13:40 Always use commit_id.py to generate commit.h commit_id_.py is capable of generating the default commit.h. This makes it so we always take a single path in gn. Remove the existing commit.h and generate it into the root generation folder (not the id subfolder) because Android blueprints can't handle generating into subfolders that don't exist. Make the <angle_dir> argument capable of taking a filename or directory name. This allows us to pass the .git/HEAD file which is a gn input. Android blueprints require all paths used as input or output to a script are listed as inputs or outputs in the genrule. BUG=angleproject:2344 Change-Id: I6600083fc400faf07808316c4a6244d6599df79a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2074924 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill c79b0ea5 2020-02-25T08:26:23 Vulkan: Document command access APIs. Includes a short description of the ContextVk command APIs. Also a few small cleanups to other Vulkan back-end documentation. Bug: angleproject:4029 Change-Id: I3bd04861f27b718e6a94fdae00644c124452bc62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2070597 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Jamie Madill 0a450363 2020-02-26T15:27:55 Fix MultipleDrawBuffers sample. Was attempting to read invalid shader paths. Noticed when working on trace/replay. Bug: angleproject:4433 Change-Id: If43c08891b40f210112db8ffb98b8c6f53528496 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2076137 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tobin Ehlis 93e72f5f 2020-02-25T12:02:31 Vulkan:Include precision qualifier in GLSL With this initial implementation, it's possible to get precision qualifier mis-matches in the generated GLSL 4.50. According to the spec this is allowed. From GLSLangSpec 4.50 section 4.7 "Precision and Precision Qualifiers": For the purposes of determining if an output from one shader stage matches an input of the next stage, the precision qualifier need not match. However, when converted to SPIR-V and run through the shader validation any mismatches will cause shader validation errors. Initially just ignoring those errors with this commit. Bug: angleproject:3078 Change-Id: Ia2b04f90f0a7b6b1302c1b1b3e32bcfd8db9ed49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057749 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
Brandon Schade 8aea6d5a 2020-02-25T11:22:00 glslang: enforce initialize and release as once per process Bug: angleproject:4354 Change-Id: Ice0912a90d4e9a4fe3fdaf67d67292afc0eba8a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2073201 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Courtney Goeltzenleuchter b9b4569b 2020-02-25T15:01:21 Save binding information when caching shader Test: KHR-GLES31.core.layout_binding.sampler2D_layout_binding_texture_FragmentShader Bug: angleproject:4106 Bug: angleproject:3089 Change-Id: Ia92ee172ae574e50bf1759583e46ffb54f348962 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2072871 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
angle-autoroll de3b97eb 2020-02-26T07:01:42 Roll third_party/spirv-tools/src 8910ea5f1c7b..70f888131ede (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8910ea5f1c7b..70f888131ede Created with: gclient setdep -r third_party/spirv-tools/src@70f888131ede If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I9645668cf93574256604db6f7ef1858a8cea6c11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2073603 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 908dc220 2020-02-26T07:01:39 Roll third_party/vulkan-validation-layers/src a09ab94aa920..3f4d08da8897 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a09ab94aa920..3f4d08da8897 git log a09ab94aa920..3f4d08da8897 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 mark@lunarg.com tests: Use VkDisplayKHR objects in thread safety validation 2020-02-25 mark@lunarg.com threading: Cover createobject calls for display objects Created with: gclient setdep -r third_party/vulkan-validation-layers/src@3f4d08da8897 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I731601f1f8190596d8313408052415f14dff42ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2073602 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Robert Liao 4a9ec2ef 2020-02-25T16:33:21 Revert "Always use commit_id.py to generate commit.h" This reverts commit 4dc19c38c0c5e307350ecd8b9f80d59573161df9. Causes a git error during 'gn gen': fatal: this operation must be run in a work tree BUG=chromium:1055991,angleproject:2344 Change-Id: I74dd36d557dcaf1bd1b13264d806a1c6b09e1a56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2073200 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tobin Ehlis a1ceb87b 2020-02-25T11:58:19 Vulkan:Refactor precision emulation code GLSL, ESSL, and HLSL translators all had the same code to emulate precision so migrate that code to base class. This is a structural change to prepare for honoring precision qualifiers in the Vulkan translator as well, which is done in a follow-on commit. Bug: angleproject:3078 Change-Id: Id85bba83543189e3bbc4002be92b056e63afc8de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2072644 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
Nicolas Capens 27cb806c 2020-02-25T12:15:14 Update DEPS for SPIRV-Tools and SwiftShader They have to be rolled simultaneously due to a breaking change. https://swiftshader.googlesource.com/SwiftShader.git/+log/214ec337a0b2..da659b374113 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/79f8caf9154a..8910ea5f1c7b Bug: angleproject:4425 Change-Id: If9b402295375436fcdb344835b65be7d2b55abc7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2071011 Commit-Queue: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 916d204c 2020-02-25T14:18:38 Vulkan: Use new APIs in BufferHelper::copyFromBuffer. We shouldn't need to special case the barrier logic in this function any more. Instead use the 'onBufferRead' and 'onBufferWrite' APIs. Bug: angleproject:4029 Change-Id: I7f67b67aa312d9ae64172b40d73086b7772d49d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2071143 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 660c0dd6 2020-02-25T13:30:33 Vulkan: Fix padding out Buffer allocations on AMD. We would often pad incorrectly given the constraints of the max stride. We shouldn't really be rounding up the buffer size, but we should instead be adding the max alignment size to the end of the buffer. Bug: angleproject:4428 Change-Id: Id2afc572c85985548a18f60b42cdc388d83d5c4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2071235 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 5b7ce876 2020-02-25T09:52:05 Vulkan: Update buffer accumulation TODO bug IDs. Bug: angleproject:4029 Bug: angleproject:4429 Change-Id: Ice4ae48a92e376ea916f05d1433a68f3accc09d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2071145 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Xinyi He b185002d 2020-02-21T16:58:39 Fix the condition of glOrtho{fx} validation According to the OpenGL ES 1.1 spec, remove the conditions of glOrtho validation that n and f must be positive. Bug: angleproject:4281 Change-Id: I644a25408a026ce87211f2203b8e8203eeaf69bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2067002 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Pierre-Marc Berube f031f7c8 2020-02-19T18:13:32 Fix a GCC 10 build failure. Build failed on GCC10 with C++17. An #ifdef was added to support both C++17 and C++14 Bug: angleproject:4390 Change-Id: I397513a8ebad4a55635ba863c47edc658e405729 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063545 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Brandon Schade 46cb0f62 2020-02-21T11:38:17 Vulkan: prevent volk reloading on null instance and devices Bug: angleproject:4419 Change-Id: I82f9bb157e88754efd074358dccef1bb82cab0f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068902 Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 14a2983f 2020-02-20T17:14:02 Trace/Replay: Add uniform locations map. This portability feature allows a single T-Rex capture done on Vulkan to work seamlessly on the ANGLE GL back-end and the WGL-loaded NVIDIA OpenGL driver. Previously the uniform locations would not be consistent between ANGLE and a native driver. And incompatiblities would trigger error messages between ANGLE back-ends. Will allow us to compare ANGLE performance vs the native driver using a capture. Example captured calls: glLinkProgram(gShaderProgramMap[3]); UpdateUniformLocation(gShaderProgramMap[3], "s_texture", 0); Bug: angleproject:4411 Change-Id: I5ddc76d75e15a9291b351e2aab94af4881f6ef47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068121 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill aa09ca69 2020-02-24T13:33:30 Vulkan: Update ContextVk command buffer access methods. Use the following names: - flushAndBeginRenderPass - endRenderPassAndGetCommandBuffer - flushAndGetPrimaryCommandBuffer This clarifies that a flush is part of the method. Bug: angleproject:4029 Change-Id: I6c870761339ea7aa39c83142200781ba39ad6a4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068129 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Geoff Lang 4dc19c38 2020-02-24T14:13:40 Always use commit_id.py to generate commit.h commit_id_.py is capable of generating the default commit.h. This makes it so we always take a single path in gn. Remove the existing commit.h and generate it into the root generation folder (not the id subfolder) because Android blueprints can't handle generating into subfolders that don't exist. Make the <angle_dir> argument capable of taking a filename or directory name. This allows us to pass the .git/HEAD file which is a gn input. Android blueprints require all paths used as input or output to a script are listed as inputs or outputs in the genrule. BUG=angleproject:2344 Change-Id: Ifd9c8331f421586db6f2c6e17faf3242376e11d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2070600 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 74cc3a05 2020-02-21T12:43:15 Make Soong ignore build files in third_party Some of ANGLE's dependencies have Android build files that are not compatible with the current Android build system. BUG=angleproject:2344 Change-Id: Ie414828a234d4c37f12d4c812751421b4f14b24a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068125 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill 263232ef 2020-02-23T15:02:16 Trace/Replay: Pass CallCapture to parameter replay writer. This will allow more advanced processing when writing the cpp replay for a specific parmeter. For the uniform locations map it'll allow us to look up the specified program from the call parameters. Bug: angleproject:4411 Change-Id: I4e91b3e4c6775c42140d00b2d155344b553a7404 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2067629 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Anders Leino e3aee0b4 2020-02-20T15:19:18 Remove skip dEQP-GLES31 test now passing on NVIDIA More precisely, the test is dEQP-GLES31.functional.vertex_attribute_binding.usage.mixed_usage.mixed_api_change_binding_point Bug: angleproject:2432 Change-Id: Iafb401380ed00bd823a821d6814be5c22f9667a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065670 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Julien Isorce a889d30f 2020-02-04T23:08:55 Reland "Provide default implementation of rx::DisplayEGL" This is a reland of 123fd97000bb9fd912159bb9ccc62308b763aead Original change's description: > Provide default implementation of rx::DisplayEGL > > Will allow to use EGL instead of GLX on X11. > > Meant to be used on modern EGL so it requires the extensions > EGL_KHR_no_config_context and EGL_KHR_surfaceless_context. > This keeps the default implementation simple (no pBuffer > fallback) > > Also provide simple WorkerContextEGL. > > Bug: angleproject:4328 > Change-Id: I92a1ded9e09e65de8bb83710274e0a73ecdff0a4 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061168 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:4328 Change-Id: I02046613324e9283ba8f2ed02dd9c7ce703e0fde Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063045 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill c7f63a01 2020-02-23T16:46:41 Fix debug callback in perf tests. Was not outputting correctly. Also print more information like the type and severity of the message. Moves some stringification code out of RendererGL into common/utilities. Bug: angleproject:3630 Change-Id: I029e279764fa4ae5cab8d903bd0ef7d376b7b846 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2067630 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 959d077f 2020-02-24T07:01:29 Roll third_party/vulkan-tools/src 16cf5591e399..a553ed74b7fe (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/16cf5591e399..a553ed74b7fe git log 16cf5591e399..a553ed74b7fe --date=short --first-parent --format='%ad %ae %s' 2020-02-21 charles@lunarg.com vulkaninfo: dynamically load vulkan 2020-02-21 charles@lunarg.com vulkaninfo: Fix uninitialized surface capabilities 2020-02-21 charles@lunarg.com vulkaninfo: Fix uninitialized surface capabilities Created with: gclient setdep -r third_party/vulkan-tools/src@a553ed74b7fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I938f3be97272ce1cc0f3c5d2ecf19b174925b685 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2069909 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b7840380 2020-02-24T07:01:53 Roll third_party/glslang/src c12493ff69e2..07e1a0a67aee (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c12493ff69e2..07e1a0a67aee Created with: gclient setdep -r third_party/glslang/src@07e1a0a67aee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ib613e2bf160c21f10c5bac3a6a682a2a8125486e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2069910 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8b73596f 2020-02-24T07:01:14 Roll third_party/SwiftShader f50cc82b3bed..214ec337a0b2 (3 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/f50cc82b3bed..214ec337a0b2 git log f50cc82b3bed..214ec337a0b2 --date=short --first-parent --format='%ad %ae %s' 2020-02-23 thakis@chromium.org Fix Wrange-loop-analysis warnings in swiftshader. 2020-02-21 amaiorano@google.com Replace target_cpu with current_cpu in Build.gn files 2020-02-21 sugoi@google.com Revert "Subzero: add support for large stacks on Windows" Created with: gclient setdep -r third_party/SwiftShader@214ec337a0b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I5445af4e346d8d80d91f299f373e0958a210d6a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2069908 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Michael Spang b5576b67 2020-02-21T20:44:42 Vulkan: Fix pipeline stage when waiting on a semaphore Using VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT in pWaitDstStageMask doesn't create a dependency, since no memory is accessed during that stage. Switch to VK_PIPELINE_STAGE_ALL_COMMANDS_BIT to synchronize all accesses. This fixes flickering observed in WebGL on ARM GPUs when composited using Vulkan in Chromium. Bug: angleproject:4422 Change-Id: I37da461c03dbf52f8658408b159c2b173cccd0b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068906 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org>
Jamie Madill a741abb9 2020-02-21T16:37:37 Vulkan: Rename CommandGraphResource to Resource. Also renames the h and cpp files to ResourceVk (to keep distinct from other resource.h/cpp files) and renames 'onResourceAccess' to 'retain'. Cleans up a few remaining mentions of the command graph in comments. Bug: angleproject:4029 Change-Id: Ifc8e880c8cea3fc48a4aec4730191c88aa35a076 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065920 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Michael Spang 468dfed3 2020-02-21T12:12:51 Reformat GN files Otherwise this blocks the CQ at presubmit. Bug: angleproject:3492 Change-Id: I3cf77c72daa358f5e1eabecf1dcb8808a1dc9e07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068538 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov eacec98a 2020-02-21T17:23:21 Suppress SwANGLE dEQP GLES3 failure. Bug: angleproject:4418 Change-Id: Iec75633351add75433eef3044390934149903ba8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068898 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Michael Spang 042fe72c 2020-02-21T17:03:11 Roll chromium_revision a9ad696264..86e00b5dd2 (742676:743688) Change log: https://chromium.googlesource.com/chromium/src/+log/a9ad696264..86e00b5dd2 Full diff: https://chromium.googlesource.com/chromium/src/+/a9ad696264..86e00b5dd2 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5499c7c1d6..5d6bdfc4f1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/afc5b798c7..feb2d0c562 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/177ef69e99..74854b3f7b * third_party/yasm: https://chromium.googlesource.com/chromium/src/third_party/yasm/+log/0d0134789a..8e4e548d0b DEPS diff: https://chromium.googlesource.com/chromium/src/+/a9ad696264..86e00b5dd2/DEPS No update to Clang. TBR=spang@google.com, BUG=None Change-Id: I1aab8058773e5846dc731170737840084363b587 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068897 Reviewed-by: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org>
Khushal f3325dd8 2020-02-21T10:20:01 Add uniform location checks for ignored/invalid location R=geofflang@chromium.org Bug: chromium:1028418 Change-Id: Iae257fbfa8d58f9a0aa7b876fba416bb060fbe54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068127 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 8df46810 2020-02-21T13:32:29 Suppress SwANGLE dEQP failures As observed from try runs on SwANGLE waterfall. Bug: angleproject:4110, angleproject:4371, angleproject:4416 Change-Id: I61cf86c60085a53896b7b66fcbf662ab7abe1c18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068542 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 39087f4a 2020-02-16T11:53:23 Refactor DrawCallPerf test parameters. Use the new combiners functions added in an earlier CL. Makes it easy to maintain bigger lists of test combinations. Also a few other changes: - removes some D3D9 perf testing since we don't maintain this config - removes the "validation only" tests. these were mostly redundant - makes the tests permutation combinations more consistent Bug: angleproject:3630 Change-Id: I175d887a01b21123f83f9fa4f64dacaa2644147a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059468 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Michael Spang c4197713 2019-06-03T19:23:02 Implement glImportMemoryZirconHandle & glImportSemaphoreZirconHandle Implement import of fuchsia external objects passed by zircon handle. This works exactly the same as with file descriptors. Bug: angleproject:3492 Change-Id: I4d46917dfc5902f00c94550158a9f8073097f0a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1642334 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang 5b78b389 2020-02-21T12:03:22 Add geofflang@google.com to OWNERS. Rolling ANGLE into AOSP is done with an @google.com account so we need to have @google.com accounts in the OWNERS file to land rolls. Will add more @google.com accounts if this is successful. BUG=angleproject:2344 Change-Id: I0319656a5ee5d3cc6403906ae6756721608c773b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068124 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill a18f4145 2020-02-19T22:42:12 Trace/Replay: Add uniform location type. This is a large refactor that replaces instances of "GLint location" for uniform locations with "UniformLocation location". This boxed type is similar to the ResourceID types that we use to capture resource IDs more easily. Eventually this will give us a more portable replay. Bug: angleproject:4411 Change-Id: I848e861c3956d95b6b953f57f8b6a2c4a676766f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066117 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill d3aad0f4 2020-02-20T08:59:58 Vulkan: Remove command graph size overlay widget. No longer applicable without the command graph. Bug: angleproject:4029 Change-Id: If75e3aca56eb18567074e14ceb23b3fd7a0afb3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065919 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 61194f93 2020-02-21T07:01:02 Roll third_party/vulkan-loader/src c357af84c7cb..136207a63495 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c357af84c7cb..136207a63495 git log c357af84c7cb..136207a63495 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 mark@lunarg.com loader: Remove standard_val refs from LoaderLayerIF doc 2020-02-20 dj2@everburning.com Move BUILD_TESTS option up as well 2020-02-20 dj2@everburning.com Allow Vulkan-Headers to be in externals. Created with: gclient setdep -r third_party/vulkan-loader/src@136207a63495 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I99ef890234ddba0dd2ebaa2f85621eec902ba17e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068199 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 91817365 2020-02-21T07:01:08 Roll third_party/SwiftShader 74d3f371f201..f50cc82b3bed (6 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/74d3f371f201..f50cc82b3bed git log 74d3f371f201..f50cc82b3bed --date=short --first-parent --format='%ad %ae %s' 2020-02-20 amaiorano@google.com Subzero: add support for large stacks on Windows 2020-02-20 sugoi@google.com VK_EXT_shader_stencil_export support 2020-02-20 bclayton@google.com Remove rr::Thread 2020-02-20 capn@google.com Support JIT on a separate thread 2020-02-20 sugoi@google.com Revert "VK_EXT_shader_stencil_export support" 2020-02-20 sugoi@google.com VK_EXT_shader_stencil_export support Created with: gclient setdep -r third_party/SwiftShader@f50cc82b3bed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Iee314936392d69caf6fe77de0cbd9fd64b61aae5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068202 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5b057604 2020-02-21T07:01:05 Roll third_party/vulkan-validation-layers/src 6112b121e104..a09ab94aa920 (5 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6112b121e104..a09ab94aa920 git log 6112b121e104..a09ab94aa920 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 mark@lunarg.com stateless: Remove redundant API version check 2020-02-20 mark@lunarg.com corechecks: Remove redundant API version checks 2020-02-20 mark@lunarg.com tests: Added BP tests for deprecated extension warnings 2020-02-20 mark@lunarg.com practices: Updated deprecrated extension list 2020-02-20 camden@lunarg.com layers: Add deprecated extension warnings to BP Created with: gclient setdep -r third_party/vulkan-validation-layers/src@a09ab94aa920 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I291d41cff90476679d7cdf34f403f629bb4e300e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068200 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill c58458e6 2020-02-19T14:51:41 Vulkan: Remove CommandGraph code. Also updates relevant comments to no longer refer to a graph. Bug: angleproject:4029 Change-Id: Ic29716e9ae4926870f902947d49d8fee7af98662 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057804 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 519163ee 2020-02-15T12:20:17 Run debug callback in perf render tests. This can catch unexpected GL errors from ANGLE or the system driver. Only enable when ASSERTs are enabled to ensure that we get full performance when profiling. Helpful to diagnose incorrect perf test rendering. In this case it helped diagnose that our frame tracing and replay do not correctly remap uniform locations. Bug: angleproject:3630 Change-Id: Ifd9f47196381e48f74a810ea0c9f9c0fd7a13a22 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057352 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com>
Alexey Knyazev b8c6521a 2020-02-14T14:23:08 Reland "Move sampleAlphaToCoverage out of blendState" This is a reland of f6e73131c528b1317067624bc71c3ce41a48f9aa Aligned BlendStateKey fields Original change's description: > Move sampleAlphaToCoverage out of blendState > > This is the second step towards exposing OES_draw_buffers_indexed (that defines independent blend state for each draw buffer). This flag is global in all graphics APIs, however D3D11 technically puts it in the blend state. > > D3D11: BlendStateKey was extended to keep existing D3D11 state caching semantics. > > D3D9: a comment was added explaining why this feature was never implemented there. > > Bug: angleproject:4394 > Change-Id: Ie6a294eeb6fcf4c868a1f1001c4f7efd61692ccd > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057063 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: angleproject:4394 Change-Id: Ia7aed863f0f9f6066daf1b02ecade3256f494062 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066698 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 94ec1e5f 2020-02-19T15:29:54 Vulkan: Update shader compilation documentation Bug: angleproject:3394 Change-Id: If8df97644d07f258a8f1ea1bde6b6b3572f6d024 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062745 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Michael Spang e4ba2d87 2020-02-20T16:05:02 Pass ContextVk instead of gl::Context to internal methods Minor cleanup to change funciton signatures of vulkan specific methods in MemoryObjectVk & SemaphoreVk. Bug: angleproject:2475 Change-Id: I230664548004ebc48b559e0f25264ea948ce5a1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2067500 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop b8ca4309 2020-02-20T08:27:33 CaptureReplay: Emit unused resources In the final frame of Manhattan, resources are cleaned up, even if they are non-existent. This is allowed by the GLES spec. Compilation of the replay would fail, for instance: error: use of undeclared identifier 'gRenderbufferMap'; did you mean 'gFramebufferMap'? const GLuint glDeleteRenderbuffers_renderbuffersPacked_0[] = { gRenderbufferMap[0] }; ^~~~~~~~~~~~~~~~ This is because we are only declaring resources if they are used. Instead, go ahead and emit the resources, then circle back when filtering is implemented, allow that to optimize the replay. Bug: angleproject:4091 Bug: angleproject:4223 Change-Id: Ib48da0d9c3f4f2eca268646e7717a12126b1d85c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066455 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill ce4918f1 2020-02-19T09:39:44 Vulkan: Sanitize Images & Buffers with non-zero values. Only enabled for specific tests at the moment. This CL allows our tests to sanitizes memory for the robust resource access extension. It is quite slow so should not be enabled by default. Only works for 1 level 2D color textures and buffers. Makes several flaky robust resource initialization tests consistently fail. Controlled via an angle::Feature in FeaturesVk. It works by initializing memory to an abitrary non-zero value: - if newly allocated memory is mappable, we map it in init and set it - if a buffer or texture can be a transfer destination, we use a staging resource - otherwise we don't attempt to initialize the resource. Bug: angleproject:4384 Change-Id: I9b4f347bfcddf3096f491ed0243bef86837feaa0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2043271 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Michael Spang dec00bc8 2019-04-03T15:51:28 Generate entrypoints for Fuchsia external objects extensions Add GL_ANGLE_memory_object_zircon_handle & GL_ANGLE_semaphore_zircon_handle extensions to supported extensions list and re-generate bindings. Bug: angleproject:2475 Change-Id: I464aa402aaac916c1f459930c771a0813ec63c9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1642333 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3352d492 2020-02-19T17:41:24 Vulkan: Add command stream diagnostics when graph is disabled. Very simple diagnostics that prints out the command stream. Since there is very little deferral right now the graph itself became quite a bit simpler. Also fills in some missing values in the switch that prints the command name string. Bug: angleproject:4029 Change-Id: Ib64a7fed6f9f56ce406cc7dbc6cc993ed510e2cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065530 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Tobin Ehlis cf2ec3b1 2020-01-31T16:55:50 Vulkan:Add FramebufferVk cache This adds a FramebufferVk cache. Cache signature is based on unique Serial values that are assigned to ImageHelper objects backing all color and DS rendertargets as well as level/layer values unique to the imageView. Update the Serials and cache signature at FramebufferVk::syncState() time. L0 cache is a currently active framebuffer. L1 cache retrieves previously created framebuffer from new cache. If neither of those hit, create new FramebufferVk and add to L1. Bug: angleproject:4322 Change-Id: I3f585271798ddfb9e5f194020adca8cf8a6b19dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2033869 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Jamie Madill 709f6285 2020-02-20T08:56:17 Vulkan: Enable FenceNV extension without graph. Bug: angleproject:4029 Change-Id: I6b3f469b692010e373b9c82b689966da98b8a6cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065918 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Michael Spang 0941e653 2020-02-19T15:49:23 Add external object extensions for Fuchsia to GL API Add extensions layered on top of GL_EXT_memory_object and GL_EXT_semaphore to support GL & Vulkan interoperation on Fuchsia. They are analagous to the file descriptor versions, except not quite as opaque. This is a draft; the underlying vulkan extensions have not been submitted to Khronos. Bug: angleproject:3492 Change-Id: Ic4723ded9fff752c4186eaa6a7f07d9ac51a3364 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1642332 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill 0aab41b7 2020-02-20T08:39:10 Vulkan: Make mapped memory available with graph disabled. This copies functionality out of the command graph path. A preemptive barrier ensures we don't need to issue an availability barrier when we need to map buffer memory. Bug: angleproject:4029 Change-Id: I868ce8bdb3c452dccf35cc9e70adf81ad7905c66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065917 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Jeff Gilbert 166875eb 2019-03-27T13:52:04 Don't clamp in glBlendColor if context supports renderable [half-]float. Add test for glBlendColor >1.0, skipped on D3D9 since it's unsupportable there. Bug: angleproject:3323 Change-Id: I3fcf867dae96bdadf8a0183269d8f27b659d0baf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1541723 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jeff Gilbert <jgilbert@mozilla.com>
Jamie Madill a61e273a 2020-02-19T14:51:40 Vulkan: Fix store ops with linear command recording. DiscardFramebuffer was being ignored in the new linear path. Fix this by using the correct APIs. Also cleans up some of the access to the "RenderPassCommandBuffer" struct in ContextVk. Add a new accessor that returns the RenderPass without a flush that ensures it is only called when a RenderPass is already started. Bug: angleproject:4029 Change-Id: Ibd199f3a371c0f91b448a0b34c8752dc8b76c284 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057329 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Courtney Goeltzenleuchter b4357d46 2020-02-20T08:29:49 Update expectations after swiftshader fix Swiftshader fixed issue with shader array length() function. Bug: angleproject:4098 Change-Id: I129f87a80c4ac254bf1b1112d34fcd2b858eab6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066454 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop 612cf818 2020-02-20T07:56:39 Vulkan: Update ES 3.1 test expections Breaking up an old test, narrowing the scope. Bug: angleproject:4312 Bug: angleproject:4413 Bug: angleproject:4414 Change-Id: Ib570450dc42de111baaf72ba0033515e519bab5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066451 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill bd4e756a 2020-02-17T09:49:45 Const-ify the validation layer. Enforces that the validation layers should be working pretty much read- only with the exeption of updating caches. Requires a few tricks: - updates EP code generation to add 'const' to pointer parameters - enables a kludge const_cast to enable the robust query extension - makes some members of Framebuffer mutable to work around syncState - makes 'is' queries and other methods in Context/State const Will allow us to more safely expose the no_error extension. Bug: angleproject:1280 Change-Id: Id9756757854c9e68fc096ecec8d93759fbe6b3a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2060689 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Xinyi He 4864413b 2020-02-17T15:34:33 Vulkan: Implement eglWaitNative function Implement eglWaitNative API. It will call XSync() on XCB and do nothing on other systems. Bug: angleproject:4281 Change-Id: I597b75124a380df519ab10af3cab9b6e26f3194f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059620 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 2527327a 2020-02-20T07:01:08 Roll third_party/glslang/src 113d07a6ebda..c12493ff69e2 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/113d07a6ebda..c12493ff69e2 Created with: gclient setdep -r third_party/glslang/src@c12493ff69e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I3152a0b7a861fa97d13687335fcc273dae06a831 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066053 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tobin Ehlis 32101999 2020-02-19T15:50:29 Vulkan:Skip appendToStartedRenderPass() In the case where command graph is disabled, we don't need to call appendToStartedRenderPass(). Bug: angleproject:4029 Change-Id: I9b9d1ad666a903fcb63ab394944cfe7adb836a08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065708 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
Wez bb654cf8 2020-02-15T23:54:44 [fuchsia] Migrate to SDK-provided FIDL & package targets. Bug: chromium:1050703 Change-Id: I7c031f4501b567fde117c30b25f0bc071d4acc44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2058948 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0a9c0b7b 2020-02-19T14:55:04 Vulkan: Fix image queue changes with graph disabled. These again weren't being tested on the CQ. Probably necessary for some image sharing scenarios. Bug: angleproject:4029 Change-Id: Iccbebf127e2ec6fdb74dd213998674fff77b75b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2065529 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org>
Shahbaz Youssefi 475c527b 2020-02-19T22:06:42 Update status of ANGLE conformance Bug: angleproject:1944 Change-Id: Ifd26d11fad1395a7cb87bea9dc5385c122fd30d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066077 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 9421a20d 2020-02-20T07:01:08 Roll third_party/SwiftShader 8def9063c4fd..74d3f371f201 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/8def9063c4fd..74d3f371f201 git log 8def9063c4fd..74d3f371f201 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 sugoi@google.com Array length fix Created with: gclient setdep -r third_party/SwiftShader@74d3f371f201 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ibc8be2fa16e4ff4efa8eb41e69a8b8f78954b860 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066054 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2156c444 2020-02-20T07:01:05 Roll third_party/vulkan-validation-layers/src f155ccfd202d..6112b121e104 (8 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f155ccfd202d..6112b121e104 git log f155ccfd202d..6112b121e104 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 jeremy@lunarg.com tests: Skip negative test if extension unavailable 2020-02-19 mark@lunarg.com tests: Update threading test to include api name 2020-02-19 mark@lunarg.com threading: Plumb API names throught to error messages 2020-02-19 tony@lunarg.com layers: Fix swapchain CreateInfo flags 2020-02-19 mark@lunarg.com layers: Delete standard_validation.json source file 2020-02-19 mark@lunarg.com tests: Remove layer refs to standard_validation 2020-02-19 mark@lunarg.com BUILD.gn: Remove copying of standard_validation.json file 2020-02-19 mark@lunarg.com cmake: Remove copy of standard_validation.json file Created with: gclient setdep -r third_party/vulkan-validation-layers/src@6112b121e104 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I64239e4ac00cfc9f84307954d75abc822edc3fe8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066052 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b0e9cd66 2020-02-20T07:01:02 Roll third_party/vulkan-loader/src 39e685ccd37e..c357af84c7cb (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/39e685ccd37e..c357af84c7cb git log 39e685ccd37e..c357af84c7cb --date=short --first-parent --format='%ad %ae %s' 2020-02-19 lenny@lunarg.com loader: Remove queue info count check Created with: gclient setdep -r third_party/vulkan-loader/src@c357af84c7cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I6c9c43a48864722c9d1a137eecbac38847c6d6d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066051 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 2801bf43 2020-02-19T15:39:17 Add .vscode to .gitignore Visual Studio Code project file. Bug: None Change-Id: I4dddee7c1e14a6bf601bd79ebca0e107829b0d65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062746 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 49010904 2020-02-15T12:21:17 Refactor test parameters to TracePerfTest. Reduces much of the code duplication by adding some new helper methods. The helpers allow combining test parameters similarly to how the GoogleTest Combine() and Values() generators work. They are more general and work by returning collections of test parameters instead of combining generator functions. Also updates the GLMark2 benchmark runner to use the new methods. Bug: angleproject:3630 Change-Id: Ibc10f9afb401e119d67a7119974a1a8d9b5abb60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057353 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 25097b6c 2020-02-19T08:07:23 Vulkan: Lift failing test suppression. EGLContextSharingTest.DeleteReaderOfSharedTexture/ES2_Vulkan Passes with the new command graph linearization. Bug: angleproject:4130 Change-Id: Ic7233696d2c06303ddf46947610b793a1a9e8a65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063041 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 113d0002 2020-02-19T12:09:39 Roll chromium_revision 8ffb18d0b9..a9ad696264 (736949:742676) Change log: https://chromium.googlesource.com/chromium/src/+log/8ffb18d0b9..a9ad696264 Full diff: https://chromium.googlesource.com/chromium/src/+/8ffb18d0b9..a9ad696264 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e5293d8fa2..5499c7c1d6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cf6ed46cff..177ef69e99 * third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/c83f99e10c..703ca235f0 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/b9b9a5af7c..c2eb8a7f7a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/953ea7aff8..eeaa53b76f DEPS diff: https://chromium.googlesource.com/chromium/src/+/8ffb18d0b9..a9ad696264/DEPS Clang version changed eaabaf7e04fe98990a8177a3e053346395efde1c:c29003813ab9bd6ea7b6de40ea8f1fe21979f13f Details: https://chromium.googlesource.com/chromium/src/+/8ffb18d0b9..a9ad696264/tools/clang/scripts/update.py TBR=ynovikov@chromium.org, Bug: chromium:1050703 Change-Id: Ic3b5104698fe7c1a8d95b22fee164af1b8d3c02c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2064067 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Pierre-Marc Berube 9a481b6e 2020-02-18T19:21:34 Add missing #include to fix build with GCC 10. Bug: angleproject:4389 Change-Id: I4a2f04a12a059924871f5d54f137c67670747ebd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063042 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill ee0498b9 2020-02-15T09:24:03 GN: Update trace tests build. Includes two small fixes: - add .gitignore for trace tests. - fix path for restricted traces, should fix bots. Bug: angleproject:4386 Change-Id: I51c657c4f2e772411e95faa76188d43c8b6981f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057350 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 1f5f7ea3 2020-02-14T23:39:11 Vulkan: Fix SPIR-V transformation name-info association Prior to this commit, when "OpName %id name" was encountered, the info corresponding to "name" was immediately associated with %id. This is not necessarily correct because there could be multiple ids with the same name. For example a sampler declaration and an unrelated function argument could have the same name. In this case, the sampler declaration and function argument name don't even need to be in the same shader stage. This change modifies the SPIR-V transformation such that the name-id mapping is tracked until the OpVariable instruction that actually declares the variable is visited. The mapping to variable info is only done if the storage class specified in this instruction corresponds to a shader interface variable. Bug: angleproject:3394 Change-Id: I35a1f6f8278e4b1ad81c9955a55e1b72d6f2e4ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057248 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ethan Lee 4b4ea4be 2020-02-03T09:48:09 Remove getIndexRange call from ValidateDrawRangeElementsBaseVertex This is essentially the same commit as fed0dda, but with the BaseVertex variant. Bug: angleproject:4373 Change-Id: I2d6fe46a0e8ce5faa8c92d4db6909f8cabd9692f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2032972 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll c5b227ba 2020-02-19T07:01:02 Roll third_party/vulkan-loader/src 0bd30e43c007..39e685ccd37e (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0bd30e43c007..39e685ccd37e git log 0bd30e43c007..39e685ccd37e --date=short --first-parent --format='%ad %ae %s' 2020-02-18 bas@basnieuwenhuizen.nl loader: Deal with failure loading implicit layer libraries. 2020-02-18 georg.m.lehmann@gmail.com loader: correct the name of vkNegotiateLayerInterfaceVersion Created with: gclient setdep -r third_party/vulkan-loader/src@39e685ccd37e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I6f92fecb5ea14e14fdabe7e73d7f4327c0dacb25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2064049 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9b731d47 2020-02-19T07:01:29 Roll third_party/vulkan-tools/src fb2272297f00..16cf5591e399 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/fb2272297f00..16cf5591e399 git log fb2272297f00..16cf5591e399 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 shannon@lunarg.com build: Update known-good for 1.2.133 header Created with: gclient setdep -r third_party/vulkan-tools/src@16cf5591e399 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I92325cf3cf797b12eeafd8c1b52f38dfd6cc1736 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2064052 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bbd00336 2020-02-19T07:01:07 Roll third_party/spirv-tools/src 77fefe765c06..79f8caf9154a (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/77fefe765c06..79f8caf9154a Created with: gclient setdep -r third_party/spirv-tools/src@79f8caf9154a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ia851eb56702cc4c02ccd238ad4c49ad9f31ca91f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063813 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0