kc3-lang/angle

Log

Author Commit Date CI Message
Mohan Maiya 59162e2e 2024-12-30T12:22:10 Vulkan: Update a few features and extensions for Samsung Enable disableProgramCaching Disable rgbxInternalFormatANGLE clipDistanceAPPLE cacheCompiledShader preferMonolithicPipelinesOverLibraries Bug: angleproject:386749841 Change-Id: Iea8033e2999c65b8715c6069d2096a709f78f438 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6133540 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi d1496a22 2025-01-03T22:54:27 Produce same compile errors for op= as op Bug: chromium:376787367 Change-Id: Ic2c1415c184c603b86876e5eb70eee602639abbf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6142515 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Hans Wennborg 49e7801b 2025-01-07T12:55:05 Suppress false-positive UBSan falures in rsgExpression.cpp A recent Clang roll introduced false-positives like runtime error: load of address 0x7f9c4f3ae6c0 with insufficient space for an object of type 'const IsConversionOkFunc' (aka 'bool (*const)(ConstValueRangeAccess)') Suppress them until a fixed version of Clang has been rolled in. Bug: chromium:388039125 Change-Id: I0823e52bb892feac519b123ae66716c3dc96f6b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149452 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 29619d42 2025-01-07T12:36:24 Roll vulkan-deps from 0cf38d98a8ba to 37201c17e85f (16 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0cf38d98a8ba..37201c17e85f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/4c1027dc7e12adc8da50f00f5b219e81ddd2d85d..369f59ad598b60d6ed9f553af651c5cccd20234c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/a71347ae4d76eb8454459373d4e1bfb929ea6a89..315964ad5aabd5b148a484e5fbea8a365c8d1eb3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/503060ebab2768b07c2df8987de608c657794311..b8427832bef9443081c3a8bcc30f4e999ab48b6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ife3a3829930eaeeadc625c357289a78b54d581ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149767 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 853087b7 2025-01-07T02:01:46 Roll SwiftShader from e76961fac58c to 52586b554f93 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/e76961fac58c..52586b554f93 2025-01-06 dneto@google.com Update to cmake 3.22.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I6f319860592b877d33f067ced8f6bc00af8a5fbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6152081 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 15b1fb37 2024-12-29T00:38:43 Fix mixing multisampled renderbuffers and textures When querying a renderbuffer's render-to-texture sample count, the number of samples was returned. This made it look like the renderbuffer attachment is MSRTT even if it was really multisampled. When mixed with a multisampled texture (where this mistake wasn't made), the framebuffer completeness code marked the framebuffer incomplete because it looked like one attachment is MSRTT and the other is not. Test credit zephyrxiao@tencent.com Bug: angleproject:382393146 Change-Id: I9fe516d6a92033512646414f88a9848aa1e1edc9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6138979 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 465299fb 2025-01-06T16:49:15 context_private_call.cpp -> context_private_call.inl.h Most functions are trivial wrappers resulting in unnecessary forwarding calls. Most are called exactly once from entry points autogen. This _reduces_ the .so size by ~14KB and I'm seeing 1-2% better frame time in my driver_overhead_2 tests on a mobile device. Bug: b/383305597 Change-Id: I1f2a048e067c76993bacfbbce655fc1c898fdba7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149814 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tingwei Guo 83047378 2024-12-20T15:07:02 Add supplement GL_ARM_shader_framebuffer_fetch_depth_stencil tests * Add two tests about detaching the depth attachment and stencil attachment separately works correctly. * Add six tests to test whether multisample, GL_FETCH_PER_SAMPLE_ARM and fragment discard work properly in different situations. Bug: angleproject:385170273 Change-Id: I8a4299e2336a8bf800ffe286775a53f59b407c8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108524 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana b01e9b58 2024-10-07T17:48:34 CL/Vulkan: Add timestamps for skipped transitions In certain scenarios, the event state transitions might be skipped - i.e. move from QUEUED -> COMPLETE. In those cases, set time stamps for intermediate states. Bug: angleproject:377942756 Change-Id: I41ae7d555b04e4ba6a8432718c0493f9f2e88fdd Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Updated-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6120465 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Matthew Denton 53ec86ab 2024-12-17T14:40:31 WGSL: support small stride arrays in uniforms WGSL requires arrays in the uniform address space to have a stride a multiple of 16. This CL makes WGSL translator emit wrapper structs for array element types used in the uniform address space, when the array stride is not a multiple of 16. The exception is for structs that aren't an aligned size of 16n, and for any types matCx2, since they are (or will be) handled in different ways that ensure alignment to 16. This should leave only f32, i32, u32, and vec2. See https://www.w3.org/TR/WGSL/#example-67da5de6 for an example of using a wrapper struct. This requires converting arrays with a wrapper struct element type to arrays with an unwrapped element type when they are first used; this can be "optimized" later for the common case of accessing a single array element, which can then be unwrapped immediately. This CL generates WGSL conversion functions when necessary. After this, the only types that can't yet be used in a uniform are matCx2 and bools. This is #2 in https://docs.google.com/document/d/17Qku1QEbLDhvJS-JJ9lPQAbnuZtLxWhG-ha5eCUhtEY/edit?tab=t.0#bookmark=id.rt3slgehd4te Bug: angleproject:376553328 Change-Id: I1edfa7f481a6cbf5b595643aae8728e67bc4b770 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6092038 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Matt Denton <mpdenton@google.com> Commit-Queue: Matt Denton <mpdenton@google.com>
Mark Lobodzinski 491335c4 2024-12-26T10:25:32 Tests: Add Bullet Echo ANGLE trace Test: angle_trace_tests --gtest_filter=*bullet_echo Bug: b/387973432 Change-Id: Ib5694f53dd2f5a2b0d8a417582e4ff8054565461 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149436 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Solti 4d2f4d97 2025-01-06T19:49:29 skip some dEQP basic_shader.* tests on Linux Bug: angleproject:388052193 Change-Id: I2e78dbacc2367af87fa102306b2458a1ef13e313 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6150288 Commit-Queue: Solti Ho <solti@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Shahbaz Youssefi f80d15ad 2025-01-03T16:19:13 Vulkan: Fix crash with array of array of samplers vs comma Bug: chromium:385256122 Change-Id: I9b356401e7c007060e95bb95ca8269411178ce66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6143373 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 1a8d7712 2025-01-06T12:44:00 Inline common cases of PackParam<BufferBinding> This appears to improve frame time by ~0.8% in some of my driver_overhead_2 tests on a mobile device. Default implementation is FromGLenum<BufferBinding> https://crsrc.org/c/third_party/angle/src/common/PackedGLEnums_autogen.cpp;drc=0bb109aa3311f35bf0b51bcda3d7e095048168c8;l=106 and has 15 cases. This CL avoids the call for 3 of those cases, most common ones according to frequency of glBindBuffer arg in our trace cpp files. This mapping adds compare/branch instructions for each case, hence inlining increases the caller a little. In this case the increase is about 60 bytes. With the total of 23 callers (GL_*Buffer* exports), this increase the .so size by ~1.3KB. Just inlining the function would yield higher bloat and wouldn't prioritize the common cases. Bug: b/383305597 Change-Id: Icc205fd46fb8ef195c8ffaf67f9cd5194d1d1a5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6148838 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 2c025cb9 2025-01-06T08:36:23 Revert "Proper clean up for EGLLockSurface3Test" This reverts commit 9d9e3efce077dbfe261b13fdfb3b20fc1e4a5e4c. Reason for revert: Suspected cause of flakiness anglebug.com/387828389 Original change's description: > Proper clean up for EGLLockSurface3Test > > Perform unmakecurrent during test teardown > > Bug: angleproject:42264593 > Change-Id: I1148b5c6631e81090f7ae931495bba1b43c24502 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6133539 > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: mohan maiya <m.maiya@samsung.com> Bug: angleproject:42264593 Bug: angleproject:387828389 Change-Id: Ia8b484e391931e9401bd644c919c34ef65718b37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6147815 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexander Bobrovnik 87d4656a 2024-06-24T16:16:47 Fix EGL_NO_SURFACE on eglCreatePbufferFromClientBuffer Bug: angleproject:348452183 Change-Id: I2fe1d3a76aa896e2034ed01ec88bcae563e6071f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5646493 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 6e813222 2025-01-06T10:48:58 Inline other trivial forwarding validation calls Following Shabi's comment on https://crrev.com/c/6108030 Otherwise these end up as actual "trampoline" function calls Bug: b/383305597 Change-Id: Ie1e7f57d6b630736aa8de914ba4abe3c2d5ee09d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6148833 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll fbaaeb7b 2025-01-06T10:01:02 Roll vulkan-deps from a09312dc04d3 to 0cf38d98a8ba (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a09312dc04d3..0cf38d98a8ba Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/1757b68e6e4d490a4ed96ca9fdc9853b3ed8ee4f..503060ebab2768b07c2df8987de608c657794311 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I1d7a44313852bc638de514ea0defeb3b32e997c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6147164 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ed3deea8 2025-01-06T08:01:00 Roll VK-GL-CTS from 77d5e6888a99 to 9509eb274dfe (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/77d5e6888a99..9509eb274dfe 2025-01-03 piotr.byszewski@mobica.com Test concurrent access across device and host 2025-01-03 ziga@lunarg.com Add missing shader object test case 2025-01-03 russellc@nvidia.com Lower dimensions for image concurrent copy tests 2025-01-03 marcin.zajac@cognizant.com Fix validation error in ycbcr tests 2025-01-03 marcin.zajac@cognizant.com Fix validation error in transform feedback tests 2025-01-03 marcin.hajder@mobica.com Made border_clamp tests independent on out of spec precision 2025-01-03 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-12-31 andrew.shadura@collabora.co.uk Fix instances of -Wmissing-template-arg-list-after-template-kw If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I2deed801ab285a74a6ece7121904460d4d6fc7d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6147148 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu d65751b4 2025-01-03T15:44:59 Skip monopoly_go trace on devices where the trace crashes Bug: angleproject:385226328 Change-Id: I8448e9bd355205dbf36599b6d82e5e05873b936e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6143534 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 970fcf27 2025-01-03T11:01:05 Roll vulkan-deps from 96fab523bf7d to a09312dc04d3 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/96fab523bf7d..a09312dc04d3 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a90793e52ee4d30738154e5647605561c4696dad..1757b68e6e4d490a4ed96ca9fdc9853b3ed8ee4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I715443192966ef7bde9f0bb2612a84711623e71b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6140268 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b225419f 2025-01-02T11:46:21 Roll vulkan-deps from 04a50a3dd7b9 to 96fab523bf7d (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/04a50a3dd7b9..96fab523bf7d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d6141280aadb706f49cd46128b1dee2b3a361c2e..a90793e52ee4d30738154e5647605561c4696dad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I46fce7a296cefd4dde507664f05df9214070c210 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6137315 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6b6f51ca 2025-01-02T08:45:09 Roll Chromium from 5929f2432039 to a1ed57f54522 (117 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5929f2432039..a1ed57f54522 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/44bcc9d7b8..6b60728ea9 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/8ea7f7e9d8..b0de9011b9 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ieb83a2c92129aaf9fbfabed565b8eb6b8931155e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6137928 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 9d9e3efc 2024-12-30T12:10:57 Proper clean up for EGLLockSurface3Test Perform unmakecurrent during test teardown Bug: angleproject:42264593 Change-Id: I1148b5c6631e81090f7ae931495bba1b43c24502 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6133539 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 3a2dbe02 2025-01-01T10:01:06 Roll vulkan-deps from bfa23916c97e to 04a50a3dd7b9 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bfa23916c97e..04a50a3dd7b9 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/34b85f655e7b07865ce554eb365ab8241cb8be6e..d6141280aadb706f49cd46128b1dee2b3a361c2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I2ff3b5e38eb686afd68a5444bb9397c51f6f33fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6135731 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 06a2e5e5 2025-01-01T07:00:59 Roll Chromium from 3d34cc12858a to 5929f2432039 (134 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3d34cc12858a..5929f2432039 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependency * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/30f439e02e..8ea7f7e9d8 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I3dbba954c1cd02c8a4aa999d93e9818e27f9fcf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6136362 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6015e730 2024-12-31T10:01:01 Roll vulkan-deps from 4cc576cd0e3d to bfa23916c97e (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4cc576cd0e3d..bfa23916c97e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3a2834e7702651043ca9f35d022739e740563516..f754c852a87988eb097a39480c65f704ceb46274 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I2a768ef76f36be3382a1d94fe50f0802b9c2b888 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6134642 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5e515f77 2024-12-31T07:00:58 Roll Chromium from 544ef0629b65 to 3d34cc12858a (215 revisions) https://chromium.googlesource.com/chromium/src.git/+log/544ef0629b65..3d34cc12858a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/425a626135..f0d4499c36 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/fa202ff628..30f439e02e No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: If3090006a6a15378e97fb10735dc8edabe32f31f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6134548 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 39882b2b 2024-12-28T12:00:19 Vulkan: Fix flakiness in MultipleProgramsShareDescriptors Precision differences causes the test to be flaky on some vendors. The test is not validating color accuracy, there is no need to use random numbers. Bug: angleproject:42265270 Change-Id: Ied8794d14b394e049e5735d4c42a7baf6e3aca0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6129616 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 017a9382 2024-12-30T10:01:22 Roll vulkan-deps from 2ceb995d091f to 4cc576cd0e3d (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2ceb995d091f..4cc576cd0e3d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/becf97fdc95572165e941feadc1a3064e2b95c87..1a0658f55aab97e1803ca46896596a04c395d50d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2897317be9f49fbca8d1e14d87fb08b56023b5ed..34b85f655e7b07865ce554eb365ab8241cb8be6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I2edd9a56128a1829b8e1fbb4fa463960e4f8f078 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6130912 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b8027afe 2024-12-30T10:44:38 Roll VK-GL-CTS from 7655439d7333 to 77d5e6888a99 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7655439d7333..77d5e6888a99 2024-12-30 rgarcia@igalia.com Test depth/stencil layout changes in the transfer queue If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Iea8a930ed9ff6f433b2856bca937a2eba61f386c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6131698 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c9a1a52a 2024-12-30T02:01:58 Roll SwiftShader from 118f577b4188 to e76961fac58c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/118f577b4188..e76961fac58c 2024-12-27 rprichard@google.com regcomp: avoid a namespace collision with C23 <float.h> If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I58d62ff36f28682f4b125b5adce56ae16ad3eb29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6132385 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0559bc5a 2024-12-30T07:01:17 Roll Chromium from 8bb7bbeac941 to 544ef0629b65 (853 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8bb7bbeac941..544ef0629b65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8f6742f233..44bcc9d7b8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2344736aa3..425a626135 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9b52643950..86d6f8ee61 * third_party/fuchsia-sdk/sdk: version:26.20241220.3.1..version:26.20241227.3.1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/2222607a3e..fa202ff628 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d0c22105ed..3da60bb598 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I9322fbe779b48177469051b332c6a80ec0361a92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6130907 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 7c766c0e 2024-12-23T15:12:44 Vulkan: Bugfix in OverrideFeaturesDependent test On some vendors there is a second order effect of disabling some features, account for such vendors. Bug: angleproject:42266725 Change-Id: I53e93d595ee09210ef7781d667470e2b46c10e55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6118433 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 35ea113c 2024-12-27T06:03:23 Manual roll VK-GL-CTS from 1797eec1a51d to 7655439d7333 (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/1797eec1a51d..7655439d7333 2024-12-20 michal.jakubek@mobica.com Vulkan SC doesn't report waived test case count 2024-12-20 piotr.byszewski@mobica.com Test NoContraction keyword 2024-12-20 marcin.hajder@mobica.com Added tests for non-layered bindings of 2D shader images 2024-12-20 kamil.goras@mobica.com Enable ES31_compatbility tests. Those tests are implemented but were not added to any test package. Move SampleVariablesTests, ShaderImageLoadStoreTests, ShaderStorageBufferObjectTests to common 2024-12-20 piotr.byszewski@mobica.com Fix copy tests using NaN for sfloat formats 2024-12-20 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-12-18 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-12-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-12-12 rgarcia@igalia.com Test depth/stencil copies on the transfer queue 2024-12-12 mateusz.bahyrycz@mobica.com Fix validation error in ray tracing tests 2024-12-12 antonio.ospite@collabora.com Build testlog-* and other tools also on Android 2024-12-12 marcin.hajder@mobica.com Added missing texture parameter for shadow samplers 2024-12-12 tomeu@tomeuvizoso.net Fix Android standalone executables to work with EGL tests 2024-12-12 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-12-12 gleese@broadcom.com Make autogen for VK, VK SC consistent If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I73077c44cfae8ba31d7334e2b149e368c6c1f579 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6116045 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c486ce8c 2024-12-27T06:24:19 Manual roll Chromium from faba6412dc5c to 8bb7bbeac941 (279 revisions) https://chromium.googlesource.com/chromium/src.git/+log/faba6412dc5c..8bb7bbeac941 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/63ad9737d7..8f6742f233 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/56013b77b6..2823e220cb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/41bfee6b2b..2344736aa3 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/11c38d901d..9ba1d4922a * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/f6418697ac..2559e1ff2f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e6eba9706f..d0c22105ed No update to Clang. Bug: None Change-Id: I6c019235e8a99d74c91496d1cdfa37b56891d65f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6121262 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shufen Ma a614c8ab 2024-12-10T11:14:29 Check alpha in ColorMask for YUV target ColorMask is used to mask the writing of R, G, B and A values to all active draw buffers. r, g, b, and a indicate whether R, G, B, or A values, respectively, are written or not (a value of TRUE means that the corresponding value is written) except when the color buffer is in YUV color space, in that case setting any one of the r, g, b, and a values as false would generate draw time INVALID_OPERATION error. Bug: angleproject:383174962 Change-Id: I38c2510c307dd8158e71c920986cb497ca923ff9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6083471 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Tingwei Guo aa263d13 2024-12-19T17:48:13 Increase GL_MAX_ARRAY_TEXTURE_LAYERS to 4096 and end2end test Increase GL_MAX_ARRAY_TEXTURE_LAYERS from 2048 to 4096, and add an end2end test to test whether the increased GL_MAX_ARRAY_TEXTURE_LAYERS meets the memory limit. Bug: angleproject:385040554 Change-Id: Ibb1ebcb2414c530dd838b3414dc82b14ce017bc4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108301 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu d75f4b83 2024-12-26T11:21:04 Revert "build: Generate gn_logs.txt" This reverts commit 4abc704df420b7f3fb6dbe35c39c7f60cfdaac3a. Reason for revert: breaks ANGLE to Skia auto roller: https://skia-review.googlesource.com/c/skia/+/930206 Original change's description: > build: Generate gn_logs.txt > > This is necessary to make Siso builds work for angle. > See https://crrev.com/c/6083212 > > Bug: b/385244283 > Fixed: b/385244283 > Change-Id: I6bc6d82744106cce1c358f415e53ad842241b567 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108522 > Commit-Queue: Roman Lavrov <romanl@google.com> > Auto-Submit: Junji Watanabe <jwata@google.com> > Reviewed-by: Roman Lavrov <romanl@google.com> Bug: b/385244283 Change-Id: I4106d696c8f7b5db9fba1814b04c2c5c404e9413 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6125598 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 00756ced 2024-12-26T01:23:08 Vulkan: Fix build on some compilers Bug: angleproject:352690896 Change-Id: Ia31fef4a3179db08d7fa9f402067c0a9aaf23ffc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6114509 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 9f82ea63 2024-12-26T00:53:39 Unsupress fixed tests Bug: angleproject:370792795 Change-Id: I7f81a58a2f502b0de321b2b2eb5d08e6dcd80d97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6121250 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll ae30ab0a 2024-12-24T10:01:32 Roll vulkan-deps from d9e522973bf6 to 2ceb995d091f (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d9e522973bf6..2ceb995d091f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9295a8b94ed0751565fa9cda6d949f5e388b32d9..becf97fdc95572165e941feadc1a3064e2b95c87 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/6a6878c614c8c6dbe81ee7a9f1176bdb52dc7dd7..4c1027dc7e12adc8da50f00f5b219e81ddd2d85d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ib689795b70cb734100d6d633ba5d9226d0ad120f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6121647 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 711b2c32 2024-12-23T10:23:13 Vulkan: Let XFB's BufferHelper keep SharedDescriptorSetCacheKey instead of BufferBlock. Unlike uniform buffers which uses VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC, the descriptorSet for transform feedback buffers also have the buffer offset baked in, so it is not helpful to use BufferBlock's serial in the cache key. This CL changes to use BufferHelper's serial for cache key. With this we can also let BufferHelper keep the SharedDescriptorSetCacheKey instead of store it in the BufferBlock. In the case that BufferHelper gets destroyed and recreated, the SharedDescriptorSetCacheKey will also get destroyed. Right now because we cache BufferBlock serial, the SharedDescriptorSetCacheKey will not be destroyed even though BufferHelper is destroyed and there is very rare case that it can be reused, thus causing BufferBlock's SharedDescriptorSetCacheKey queue keep increasing, which causes perf issue. Bug: b/384839847 Change-Id: I76b8f0d56486079740cca302e8b14a04a6e24074 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6115111 Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 501f07a6 2024-12-23T10:01:37 Roll vulkan-deps from 45d90843193e to d9e522973bf6 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/45d90843193e..d9e522973bf6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/70c6ba3d70dc038cc1fcf319fa2ea46b8edc5d3b..73995ddc2b38b5653c8eb3b4a0d1cd6cc2cea4c0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/b8315514467ace9e22070dd8e0491aaffb9690d1..6a6878c614c8c6dbe81ee7a9f1176bdb52dc7dd7 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/90851ef5b77757556217122061672dc52e21629c..2897317be9f49fbca8d1e14d87fb08b56023b5ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I9c30781c2a571a884d0235d16d5d18216d7decf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6118432 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6bca07bd 2024-12-23T08:10:45 Roll Chromium from ebb01bde9709 to faba6412dc5c (564 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ebb01bde9709..faba6412dc5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b8a4536db2..63ad9737d7 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c1b2946e54..56013b77b6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0dd064ac2c..41bfee6b2b * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/af88579bcb..a9315aaaa1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/22ebef9201..9b52643950 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/19548ed7a2..58625e82c6 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/175bf00303..11c38d901d * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/ca233e8056..2222607a3e * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/63612d4a53..f2066b43ae * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6f856e0b36..306a47aa4c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2fa3bb999c..e6eba9706f * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/917b7d7bef..02403d4e52 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ia99acec7b78f9f9c736af1d41a2d769921127768 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6119500 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 81a41e4f 2024-12-21T01:14:31 Manual roll vulkan-deps from 2d70513951de to 45d90843193e (20 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/2d70513951de..45d90843193e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/6a74a7d65cafa19e38ec116651436cce6efd5b2e..d4a196d8c84e032d27f999adcea3075517c1c97f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/7ccaa5e0206fcaa03135312fccb4624ae110a19b..b8315514467ace9e22070dd8e0491aaffb9690d1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/2744de9936755fea6912d47e7a0a8857d8a4fdee..a71347ae4d76eb8454459373d4e1bfb929ea6a89 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/7f8738669b15a7a158b2a77aff2033973dcd8751..5a88b6042edb8f03eefc8de73bd73a899989373f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2cbfec7bb95b3de7bab8db92716197ec9a855fb2..90851ef5b77757556217122061672dc52e21629c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I7f4b0e5ffbae1a159fe1085aaf48c5eb4f219cda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6115340 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2849e8f1 2024-12-20T16:04:55 Manual roll Chromium from 7c4073fa4450 to ebb01bde9709 (737 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/7c4073fa4450..ebb01bde9709 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1923aa3e32..b8a4536db2 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b8ff6f5a95..c1b2946e54 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0305a85a20..0dd064ac2c * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/79b08c29b3..72093794ac * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e7c18388ac..22ebef9201 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fcb6178914..19548ed7a2 * third_party/fuchsia-sdk/sdk: version:26.20241213.3.1..version:26.20241220.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d0ddad5b79..175bf00303 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/02cb512292..83dfa1f5bf * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/05bd4c24a2..ca233e8056 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/3ef711c420..f6418697ac * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dffea2e717..6f856e0b36 * tools/luci-go: git_revision:cde70f87137f7a20bfc3c8d0c03a25c29932a790..git_revision:320a8df0f7934159fda7721f3b507e707531d284 * tools/luci-go: git_revision:cde70f87137f7a20bfc3c8d0c03a25c29932a790..git_revision:320a8df0f7934159fda7721f3b507e707531d284 * tools/luci-go: git_revision:cde70f87137f7a20bfc3c8d0c03a25c29932a790..git_revision:320a8df0f7934159fda7721f3b507e707531d284 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5df8dc0a32..2fa3bb999c * tools/skia_goldctl/linux: qB-N09rgIx7yC6Zqn7Y2JvrIlrTweZuYNwSsc6xbILQC..PNE7Fclbe9QG9LF9goXEGcZdLRF9BTfPrN_kguKqNR0C * tools/skia_goldctl/mac_amd64: CFFGYiI44XKMhON-DbnaT7dFxhCTcMt3y5Cnrbwkt4IC..urNQsuWSpqZHCVVDj3airG0ps7V55Zz8JNfj5p1N0h4C * tools/skia_goldctl/mac_arm64: Bge_01Gtd7niAlYa0ekw745cni6y4ZGAAHAvBp_G5lUC..N0tUKPzw6eyaiqY-Ea9g6TujzrSjazJW1GwHD6GiJvkC * tools/skia_goldctl/win: CrceP9s_KaQvTDquHpILvfcu7lSVZOcDCsnClOyhmYQC..higEnuoHCI_e6VMHGBAiodkRZW6nOOTVKClWpyaRYJoC No update to Clang. Bug: None Tbr: abdolrashidi@google.com,ynovikov@google.com Change-Id: I536e8b573b1f74d58134bf9c4b99494e3cd893a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6114699 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Junji Watanabe 4abc704d 2024-12-20T13:23:33 build: Generate gn_logs.txt This is necessary to make Siso builds work for angle. See https://crrev.com/c/6083212 Bug: b/385244283 Fixed: b/385244283 Change-Id: I6bc6d82744106cce1c358f415e53ad842241b567 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108522 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Roman Lavrov 195c3a20 2024-12-19T19:09:38 Inline non-PPO getActiveLinkedProgram and ValidateUniform1-4* The non-PPO part of getActiveLinkedProgram is small, and ValidateUniform1-4* are just a single call to ValidateUniform, and end up an actual function call due to being located in a different translation unit (validationES.cpp vs validationES2.cpp) Estimated 0.5-1% improvement to driver_overhead_2 wall_time on pixel 8 Bug: b/383305597 Change-Id: I256bf11952f36bbd5033f191df19aa293dbeefdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108030 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuxin Hu febba52a 2024-12-12T17:26:59 Optimize for swap after clear Bug: angleproject:382006939 Change-Id: Ia6b9a53042a1d188dbd5a5f6436f17ca1e389a4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6072416 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov db3a88fd 2024-12-19T09:15:50 Add missing include Bug: angleproject:42262955 Change-Id: If0e075d1f291321e3a265d1d68b9d813f8559d68 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6110804 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Johnson <hibrian@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Solti Ho <solti@google.com>
angle-autoroll 8016c2c0 2024-12-19T02:01:26 Roll SwiftShader from 23b93c7cfe27 to 118f577b4188 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/23b93c7cfe27..118f577b4188 2024-12-18 dneto@google.com kokoro: Use Python 3.12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I5131168c09664926a5b1c347b4b810778f87ef1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6110616 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6bf0acbe 2024-12-19T10:01:56 Roll vulkan-deps from ae8417f428a1 to 2d70513951de (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ae8417f428a1..2d70513951de Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b3a6aa7b03c51ba976e4f4e96b1e31f77f43f312..3a2834e7702651043ca9f35d022739e740563516 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/1a84052a5c332faaed12ea2431420b72febda807..9295a8b94ed0751565fa9cda6d949f5e388b32d9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/0ab12c1668642874f77bad0e4f4006cbd2f7eaee..7f8738669b15a7a158b2a77aff2033973dcd8751 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/fed45fcbb6cace64d6a28439d55b87327fafb34a..2cbfec7bb95b3de7bab8db92716197ec9a855fb2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I573b47f32e6ec2a2ae966e33044dbb13abe5ac6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6110617 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c656c5fc 2024-12-19T07:00:53 Roll Chromium from 56d2640e97e6 to 7c4073fa4450 (673 revisions) https://chromium.googlesource.com/chromium/src.git/+log/56d2640e97e6..7c4073fa4450 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5f2852b973..1923aa3e32 * buildtools/linux64: git_revision:7296b601ea80252ccf8cce300c4bebcabf235f20..git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd * buildtools/mac: git_revision:7296b601ea80252ccf8cce300c4bebcabf235f20..git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd * buildtools/win: git_revision:7296b601ea80252ccf8cce300c4bebcabf235f20..git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7153a13a08..0305a85a20 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/07cede3272..79b08c29b3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d74466096c..e7c18388ac * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/138f15432a..fcb6178914 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/77e59bec0f..02cb512292 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3605d6cf39..05bd4c24a2 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/22d3b30294..3ef711c420 * tools/luci-go: git_revision:94ce62005f7d368ce9e36897e15bb570cf0d0027..git_revision:cde70f87137f7a20bfc3c8d0c03a25c29932a790 * tools/luci-go: git_revision:94ce62005f7d368ce9e36897e15bb570cf0d0027..git_revision:cde70f87137f7a20bfc3c8d0c03a25c29932a790 * tools/luci-go: git_revision:94ce62005f7d368ce9e36897e15bb570cf0d0027..git_revision:cde70f87137f7a20bfc3c8d0c03a25c29932a790 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d004cd1259..5df8dc0a32 * tools/skia_goldctl/linux: aXHJ25ncUXPVNosfIlyKwiMy1_7taQbInefMc4nqOX0C..qB-N09rgIx7yC6Zqn7Y2JvrIlrTweZuYNwSsc6xbILQC * tools/skia_goldctl/mac_amd64: n7u7fnD8_JipALcOofxpNMbvph2fsWaAgmaeLeCkSs0C..CFFGYiI44XKMhON-DbnaT7dFxhCTcMt3y5Cnrbwkt4IC * tools/skia_goldctl/mac_arm64: X-JBelmtsD7X26HqTaYu0LMCepx-_ANJcSvFWh1tM24C..Bge_01Gtd7niAlYa0ekw745cni6y4ZGAAHAvBp_G5lUC * tools/skia_goldctl/win: 7nms2AMNrHCf-FHq9enXo2f6vRLs_lA_98qZ2cRiE78C..CrceP9s_KaQvTDquHpILvfcu7lSVZOcDCsnClOyhmYQC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Id7a3b148bf9898160c21e17e80fc594b6faae0a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6109849 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi bb640019 2024-12-18T12:36:13 Vulkan: Fix partial clear texture for RGB8 snorm When clearing an RGB8 snorm texture, due to this format not being renderable, a temporary buffer is filled with the clear value and applied to the image as a buffer update. However, this buffer's unpack state has nothing to do with the context's unpacking state. This should be reflected on the pixel unpack state that is used to calculate the required buffer size for the update. Otherwise, it can result in wrong colors for parts of the image. * Updated the pixel unpack state in the unrenderable part of the clear function for textures (TextureVk::clearSubImageImpl()). * It will now use "1" as the alignment since it is tightly packed. * Added unit test to clear one corner of an RGB8 snorm texture and use it for drawing. * Clear2DRGB8SnormCorner Bug: angleproject:384765600 Change-Id: Id302a9f4049626aae1a68798e86d7183d5c264e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108140 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi da687935 2024-12-18T14:17:21 Skip stencil clear test for QCOM Bug: b/328156792 Change-Id: I0f76d5c76cb1b25f2d0aafbb5bd7f4e6ef8cbc2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108177 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Mark Lobodzinski 0dabe316 2024-12-18T09:35:35 Tests: Add Monopoly Go trace Test: angle_trace_tests --gtest_filter=*monopoly_go Bug: b/384879555 Change-Id: I64ab6efb23745ab9e099c1243d4f09cee0f311d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6106530 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll f78f4585 2024-12-18T10:01:18 Roll vulkan-deps from 960d6a89ffb2 to ae8417f428a1 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/960d6a89ffb2..ae8417f428a1 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/a4084887e4a71473a77d8f1109057e1c3c421da0..1a84052a5c332faaed12ea2431420b72febda807 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/160e946f5d4b3a657f47b7fc4b0bd3cc8d0d6afd..0ab12c1668642874f77bad0e4f4006cbd2f7eaee https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b54d52d8f7ccd201ae30454628986580afd240e4..fed45fcbb6cace64d6a28439d55b87327fafb34a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I1deb71c169c001c716c37fe1859b4a1c7a189fd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6104454 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7fb481a6 2024-12-18T07:04:50 Roll Chromium from 2afb57f1b7d9 to 56d2640e97e6 (592 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2afb57f1b7d9..56d2640e97e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0958114dad..5f2852b973 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ddb7dc3c42..b8ff6f5a95 * buildtools/linux64: git_revision:468c6128db7fabe32a29d4753460ef53594406fc..git_revision:7296b601ea80252ccf8cce300c4bebcabf235f20 * buildtools/mac: git_revision:468c6128db7fabe32a29d4753460ef53594406fc..git_revision:7296b601ea80252ccf8cce300c4bebcabf235f20 * buildtools/win: git_revision:468c6128db7fabe32a29d4753460ef53594406fc..git_revision:7296b601ea80252ccf8cce300c4bebcabf235f20 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d94ed7278b..7153a13a08 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/11d0977d59..af88579bcb * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/abd0e1e8cc..d74466096c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/263e08dde3..138f15432a * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/574b92bc1d..77e59bec0f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/d911e97c96..3605d6cf39 * third_party/r8/cipd: 4GP31XSTv8hw3F8OO6XHx00UfLiyEz2CDY9jcjJa9XUC..q_wvk54XItTBlBNQMHkS4NRMp-tapPW97M292KTXHrsC * third_party/r8/d8/cipd: o7pbwAFk68RQBPYLlCUm0mQ6B3Bj9pykXOPvv8akR5kC..q_wvk54XItTBlBNQMHkS4NRMp-tapPW97M292KTXHrsC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/d332e8e543..22d3b30294 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/70df2ea80a..63612d4a53 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c742f9fe2a..dffea2e717 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5d54ecf10c..d004cd1259 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I0498f22cbbc3b98cd8a5289c18c85c108b462330 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6103817 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 37d26888 2024-12-17T13:57:27 Skip some context sharing tests on S22 * Skipped the following tests from EGLContextSharingTestNoFixture: * EglTerminateMultiThreaded * EglDestoryContextManyTimesSameContext Bug: angleproject:384799391 Change-Id: Ide9d86d900cb99f761ca007a703689c762eff167 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6102980 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxiang Qian db8e5617 2024-10-23T15:21:33 Reland "Add check for some EGL API attrbute values" This is a reland of commit 9481eb625b358897583f8adeca5fc520f8c215ae Original change's description: > Add check for some EGL API attrbute values > > EGL validation in ANGLE lacks of some error handlings mentioned > in EGL spec. Those error handlings are added, and we need to > make sure angle end2end tests are not influenced. > > Bug: angleproject:375528200 > Change-Id: Ic0686d9ccc70e18b0cf3449184452771c77c06b7 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6034532 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:375528200 Change-Id: I6db890a95825156848d7da8ebc15f7e30b0902ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6088519 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 5579baea 2024-12-17T18:57:24 Explicitly build for x64 on Mac bots In preparation for cross-compiling on arm64 and vice-versa. Bug: b/373881483, angleproject:42266214 Change-Id: Id55f7e0b84a2e8703eac8db45508990e9a0c2978 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6099214 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop 0f0d2cc7 2024-12-17T09:50:56 Tests: Add Riptide GP2 trace Test: angle_trace_tests --gtest_filter="*riptide_gp2*" Bug: b/384714388 Change-Id: I09984201c2c96797dcc867ef818aa18684561275 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6101168 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Cody Northrop 645c192a 2024-12-17T09:45:41 retrace: Fix assumption in get_min_reqs Only try to remove implied extension if it is present. Test: retrace_restricted_traces.py get_min_reqs --traces riptide_gp2 Bug: b/384714388 Change-Id: Ic0240c387012923e1918fccd2ea6c341d9a84609 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6101167 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Roman Lavrov b7d6605a 2024-12-17T09:17:20 Rename GC and CL dispatch threads to <16 chars Current names too long (there is a 15 char pthread limit), they just gets ignored. Add an assert. Bug: angleproject:42262955 Bug: angleproject:375231041 Change-Id: If26c98b709524b9c072f26759b98f81fe0d4367d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6096873 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
Yuly Novikov ae97e569 2024-12-17T10:36:41 Stop Win NVIDIA experiment Bug: chromium:40805707 Change-Id: I385262a568e5dcde003267f9bb58c69b675fd529 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6098193 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Roman Lavrov 87d891dc 2024-12-13T19:51:42 Inline more tiny functions on hot path Similar to https://crrev.com/c/6094283, not as hot but broader. Highlighted by PGO profile of driver_overhead_2 trace combined with size and offset of the corresponding .so sections to maximize reduction in TLB misses. Improves driver_overhead_2 performance by 1~2% on Pixel 8. Almost no change in .so size as functions are tiny. Bug: b/383305597 Change-Id: Ib1c021d4635141b879667b59305e4d45de7b8aef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6088958 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 1c096a85 2024-12-17T10:01:53 Roll vulkan-deps from 296cdf58b6ec to 960d6a89ffb2 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/296cdf58b6ec..960d6a89ffb2 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8ad28db18a601c43ff0d7e369533f5e8c450b39e..b3a6aa7b03c51ba976e4f4e96b1e31f77f43f312 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/7cac4f3551b177ebc32aa58d47e3a5ce734f160f..a4084887e4a71473a77d8f1109057e1c3c421da0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/037ed53cffefd8e58f3223b47c5ec69bec0d4857..7ccaa5e0206fcaa03135312fccb4624ae110a19b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/cf3372f90d354d2c824de503a591b3d0afe3b6fd..b54d52d8f7ccd201ae30454628986580afd240e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I9a7262596970451be7aa3afd6f5eb0e0740a23e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6101165 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ea17bfe1 2024-12-17T07:02:10 Roll Chromium from e28e83b69fbe to 2afb57f1b7d9 (575 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e28e83b69fbe..2afb57f1b7d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bc67f77f4f..0958114dad * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/7d7540c349..ddb7dc3c42 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5f13158534..d94ed7278b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/197e2d4092..07cede3272 * third_party/android_build_tools/lint/cipd: e7TqJrHnUCGyZXuBsbG8sf1IjzAYRuSzHRSWUJu_Nj4C..yRtv3ENAOirUsdXx8YvmGiB0eKZ5gBioAfsRlt9K0-UC * third_party/android_build_tools/manifest_merger/cipd: gsCtvMuqN-QovWEu4yfq_-E0wb0sL2kbuqtNEODHfFkC..X4iLz22sYpi8ovi3X8Iv6PXgOcy2934mOa16hL5-w2gC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/02aa3279dd..11d0977d59 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/452b85ea51..abd0e1e8cc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77e8bd6385..263e08dde3 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/5e0e903f13..d0ddad5b79 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/ac38246731..d911e97c96 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/f385058192..d332e8e543 * third_party/siso/cipd: git_revision:90146f88d98328d9b83b42d16ee30ff54b48d214..git_revision:f9bfa081826a4ffb6f2a96b640d009cef900e69f * third_party/turbine/cipd: c4onccFJcd8rKHM_6js-X_ucjXdFqhDWK8aUX4ARSkkC..dz8pRLjwNlToJ0tS14T-TDQJNikmFXEDByMo-OzBbl0C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e911dd7a7e..c742f9fe2a * tools/luci-go: git_revision:dbbe363b4b1aa09520e53ccdd2d52cb661875e53..git_revision:94ce62005f7d368ce9e36897e15bb570cf0d0027 * tools/luci-go: git_revision:dbbe363b4b1aa09520e53ccdd2d52cb661875e53..git_revision:94ce62005f7d368ce9e36897e15bb570cf0d0027 * tools/luci-go: git_revision:dbbe363b4b1aa09520e53ccdd2d52cb661875e53..git_revision:94ce62005f7d368ce9e36897e15bb570cf0d0027 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/07b0ccface..8e880be2d6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c6b397dfef..5d54ecf10c No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I0611e5b829a3c149643333eaea32b5f6ab2a8a42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6100471 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu c0ee7b20 2024-12-12T16:49:40 Swap getWidth() and getHeight() if the swapchain is 90 emulate rotated When checking if we need to recreate swapchain, we should swap the getWidth() and getHeight() if Is90DegreeRoration(mEmulatedPreTransform) is true. This is because: When creating swapchain, if Is90DegreeRoration(mEmulatedPreTransform) is true, we store swapped mSurfaceCaps.currentExtent.width and mSurfaceCaps.currentExtent.height in getWidth() and getHeight(), but we use the original mSurfaceCaps.currentExtent.width and mSurfaceCaps.currentExtent.height to create the swapchain. On next acquire, to check if the swapchain property changes, we should swap getWidth() and getHeight() if if Is90DegreeRoration(mEmulatedPreTransform) is true, otherwise we are recreating swapchains when width and height are unchanged. Bug: b/382006939 Change-Id: I1cbe9da2ff5e76602a90963514d2d0d5fbf677e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6090199 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi e72cc71b 2024-12-13T11:59:29 Vulkan: Remove framebuffer fetch from shader if unused Some application shaders may use `inout` variables to simplify shader generation (presumably), but in the end don't actually ever read from those variables. This change tries to detect some very simple but common cases where it's clear that the shader completely overwrites the variable without reading from it and turns `inout` into `out`. When coherent framebuffer fetch emulation kicks in, these shaders would no longer cause unnecessary barriers. Bug: angleproject:377923479 Change-Id: I0970b72f551b24409337a375cf97aa63bb511fb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6094425 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll d8efbad8 2024-12-16T10:01:49 Roll vulkan-deps from 034518ee55a5 to 296cdf58b6ec (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/034518ee55a5..296cdf58b6ec Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/340bf88f3fdb4f4a25b7071cd2c1205035fc6eaa..8ad28db18a601c43ff0d7e369533f5e8c450b39e https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/bfc0ffa353cb2b7bfda65c6b65f15c5c4d0564d0..70c6ba3d70dc038cc1fcf319fa2ea46b8edc5d3b https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/13b59bf1d84054b8ccd29cdc6b1303f69e8f9e77..7cac4f3551b177ebc32aa58d47e3a5ce734f160f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/f00d38b79154d717654f1e513460bf4471e46013..cf3372f90d354d2c824de503a591b3d0afe3b6fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I97525a871b5da8adb81da75c7179b1243618ca72 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6096321 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9f6c2783 2024-12-16T02:01:50 Roll SwiftShader from c0fe4d40475b to 23b93c7cfe27 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/c0fe4d40475b..23b93c7cfe27 2024-12-13 dneto@google.com kokoro: use cmake-3.31.2 in kokoro bots If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ia585b8f041d43b6c89f60cbb6358b5eeb37f6186 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6095957 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 51bf3080 2024-12-16T07:01:03 Roll Chromium from 41d46852e819 to e28e83b69fbe (803 revisions) https://chromium.googlesource.com/chromium/src.git/+log/41d46852e819..e28e83b69fbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/88cd7324ae..bc67f77f4f * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a3088d386a..7d7540c349 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4056715131..5f13158534 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b5ecd2133b..197e2d4092 * third_party/android_build_tools/error_prone/cipd: AYoMbR1EWdl0sGTYnDZkWcRZOQnKpArFh-Mq-qpoq3gC..3uVZCorp5AfUqWJh9_b88WPAXGcMXzb2-_RELEMkIAAC * third_party/android_build_tools/lint/cipd: rEOy2pZDcjaTl2F78H5_hqHHcofjPkK9CESlIPmCmwAC..e7TqJrHnUCGyZXuBsbG8sf1IjzAYRuSzHRSWUJu_Nj4C * third_party/android_build_tools/manifest_merger/cipd: 3FQUDYdvPIJhN5cvl_0KGxzA_XRYfOksxkEdXVDy4ZMC..gsCtvMuqN-QovWEu4yfq_-E0wb0sL2kbuqtNEODHfFkC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1b79868a9b..02aa3279dd * third_party/android_sdk/public: B4p95sDPpm34K8Cf4JcfTM-iYSglWko9qjWgbT9dxWQC..OCGHZKTdjXjIELVI6FMAgcDkfnd_1ybB0_MtljPtz-8C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/77bb168c21..452b85ea51 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9b4d1e485d..77e8bd6385 * third_party/fuchsia-sdk/sdk: version:26.20241203.6.1..version:26.20241213.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2d9b9a9eea..5e0e903f13 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a6362b2727..574b92bc1d * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/19bfdd55df..d1e95b102f * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/5dda25750d..ac38246731 * third_party/r8/cipd: lKhbNcMvJ5dFn56zD1r3KUOhXVK3ybW4iS_Ju6ylTBYC..4GP31XSTv8hw3F8OO6XHx00UfLiyEz2CDY9jcjJa9XUC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/c2c91c04ca..70df2ea80a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b7f833f53d..e911dd7a7e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/557d05265f..c6b397dfef No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Iadb464cc75ecf4807a0e36cd032513461680fa49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6095454 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 00d9ef8f 2024-12-13T11:59:29 Inline GetUniformTypeInfoFromIndex A very small function call on hot path, highlighted by PGO profile data from driver_overhead_2. Makes driver_overhead_2 1~2% faster on Pixel 8 (measured with shared context lock off). Bug: b/335295728 Bug: b/383305597 Change-Id: I36e58b42b06c72c8f4c282110c85bb5130ced8d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6094283 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 1287e19e 2024-12-13T15:28:59 Vulkan: Further improve recreateSwapchain() error handling Fixed problem in cases if something fails after assigning `mSwapchain = newSwapChain` and before setting `mAcquireOperation.state = impl::ImageAcquireState::NeedToAcquire`. In the above case we will already have `mSwapchain` pointer with potentially undefined state of related members, while `mAcquireOperation.state` may remain `NeedToProcess`. Returning in case of a failure without assigning `mSwapchain` we will stay in the "invalid swapchain" state while still have new swapchain in the `mLastSwapchain`. This state is already handled by existing code and will try to call `recreateSwapchain()` again until it succeeds. Bug: angleproject:380234227 Change-Id: I465115deef4c06f35d40b90efc192b51e7b9fd44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6089081 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Yuxiang Qian a1be7e61 2024-11-26T14:39:18 Implement EGL_EXT_surface_compression This patch adds implementation of EGL_EXT_surface_compression to ANGLE, including new API eglQuerySupportedCompressionRatesEXT and adding EGL_SURFACE_COMPRESSION_EXT in EGLQuerySurface and EGLCreateWindowSurface/EGLCreatePlatformWindowSurface. Angle end2end test is added to verify the extension. Bug: angleproject:375496226 Change-Id: I06926930d94485a378fc831d552cf55fe7938a57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6073355 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 5fad41a0 2024-12-03T17:18:35 CL: Fix Non-Uniform Query check The following method needs updating: https://github.com/google/angle/blob/main/src/libANGLE/CLDevice.cpp#L424 It currently does not account for lower OpenCL driver versions that do not contain the query value: CL_DEVICE_NON_UNIFORM_WORK_GROUP_SUPPORT As this was only introduced as of OpenCL 3.0 support https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html#CL_DEVICE_NON_UNIFORM_WORK_GROUP_SUPPORT Bug: angleproject:381335059 Change-Id: I9f1e61270690077bdca0be3aef0d88b77c27bf11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6068289 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 8caf0e78 2024-08-30T20:16:33 CL/VK: Add writeBufRect staging/transfer routine Adding enqueueWriteBufferRect staging/transfer code/routine for the non-blocking conditions. Allows us to correctly stage writes in a batch of cmds with multiple enqueueWriteBufferRect cmds. Bug: angleproject:42267074 Change-Id: I715bb4c139374fa24ad5d1a0db329ae0f35ae741 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6068288 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 9e1ce8c1 2024-08-30T20:11:06 CL/VK: Add readBufRect staging/transfer routine Adding enqueueReadBufferRect staging/transfer code/routine for the non-blocking conditions. Allows us to correctly stage writes in a batch of cmds with multiple enqueueReadBufferRect cmds. Bug: angleproject:42267074 Change-Id: I46b7b9f4e1fbcd0314a7700525935ed2743b1587 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6068287 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 2c404434 2024-12-13T09:05:48 Revert "Add check for some EGL API attrbute values" This reverts commit 9481eb625b358897583f8adeca5fc520f8c215ae. Reason for revert: Causes failures when rolling into chromium: https://chromium-review.googlesource.com/c/chromium/src/+/6089841 Original change's description: > Add check for some EGL API attrbute values > > EGL validation in ANGLE lacks of some error handlings mentioned > in EGL spec. Those error handlings are added, and we need to > make sure angle end2end tests are not influenced. > > Bug: angleproject:375528200 > Change-Id: Ic0686d9ccc70e18b0cf3449184452771c77c06b7 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6034532 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:375528200 Change-Id: I8e59113e4d94571b0ec1d8135519e829d3571a15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6094284 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Shahbaz Youssefi bafb661e 2024-12-13T12:01:19 Vulkan: Remove debug log + dead code Bug: angleproject:376572258 Change-Id: Ie774fd248a37fc65b4e05df0b4e4dffb778b9b4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6090907 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 9c67a505 2024-12-11T14:29:59 Vulkan: Rename CommandProcessor.* to CommandQueue.* Bug: angleproject:42262955 Change-Id: I5585309479d8c66e9ddfa41e12a757381ebb80bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6089885 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll d3186daa 2024-12-13T02:01:13 Roll SwiftShader from 7e54d43d6905 to c0fe4d40475b (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/7e54d43d6905..c0fe4d40475b 2024-12-13 tikuta@google.com add missing includes for the build with use_libcxx_modules If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: If4918284e6993b2876b4162c03f74304db7c7cb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6093004 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ea39c3fc 2024-12-13T10:01:06 Roll vulkan-deps from bd600597bc4b to 034518ee55a5 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bd600597bc4b..034518ee55a5 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a0995c49ebcaca2c6d3b03efbabf74f3843decdb..340bf88f3fdb4f4a25b7071cd2c1205035fc6eaa https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/1229f1ef3b82498af600965141cde29a3c928e29..13b59bf1d84054b8ccd29cdc6b1303f69e8f9e77 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/eab360311909074896aee1c5dd59a07756fc7f4e..037ed53cffefd8e58f3223b47c5ec69bec0d4857 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/828d51af674a36f8a6cbaf99c83f30808e9d94e2..f00d38b79154d717654f1e513460bf4471e46013 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ie474defc2feae18ca1b9ac683295bb89a1774d6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6093034 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 90a57e76 2024-12-13T07:01:28 Roll Chromium from 7b13ac11cb7e to 41d46852e819 (501 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7b13ac11cb7e..41d46852e819 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d4122dbe61..88cd7324ae * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/75f731e7de..a3088d386a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6701fb9387..4056715131 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/0b76dfe4ff..b5ecd2133b * third_party/android_build_tools/lint/cipd: ogvoJt-5sfVvPmkufyujLCkY4ZsHBN3VIirNJGSH0mUC..rEOy2pZDcjaTl2F78H5_hqHHcofjPkK9CESlIPmCmwAC * third_party/android_build_tools/manifest_merger/cipd: hyODeowQwjjxMHe11I3-FOtBGbTg6MQdr3Uh9ZUUHA4C..3FQUDYdvPIJhN5cvl_0KGxzA_XRYfOksxkEdXVDy4ZMC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/cdb1f13073..1b79868a9b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3ad6a49db4..77bb168c21 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/238650f0b1..9b4d1e485d * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/643441dc2f..2d9b9a9eea * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d82e9c4d06..a6362b2727 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/758bbcaa6a..5dda25750d * third_party/r8/cipd: j0CWzYzqsndnaKDzw-cLHbbkO-1-KUttLvurGT_Ve-UC..lKhbNcMvJ5dFn56zD1r3KUOhXVK3ybW4iS_Ju6ylTBYC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/db95c7fa4a..f385058192 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/ee45457cda..c2c91c04ca * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5c9878dc3c..b7f833f53d No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I0df6ddba9eda765effb5caa355a7bfeb625dfb96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6093030 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi c75bd915 2024-12-10T23:01:44 Vulkan: Remove asyncCommandQueue It's been years and it never showed an advantage. In the meantime, performance without this feature seems close to native drivers (i.e. the feature has lost its appeal) and it's frequently a source of complication and bugs. Bug: angleproject:42262955 Bug: angleproject:42265241 Bug: angleproject:42265934 Bug: angleproject:42265368 Bug: angleproject:42265738 Bug: angleproject:42266015 Bug: angleproject:377503738 Bug: angleproject:42265678 Bug: angleproject:173004081 Change-Id: Id8d7588fdbc397c28c1dd18aafa1f64cbe77806f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6084760 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alex Dean 9c566e86 2024-12-11T17:42:16 CL/VK: Fix event blocking for enqueueReadImage/enqueueMapImage There were issues with enqueueReadImage and enqueueMapImage getting blocked when one of the waitEvents is a user event. This change fixes the issue by staging a transfer routine. Additionally, this change removes the redundant struct BufferBox. Bug: angleproject:381199196 Change-Id: Id0c09d9930b36b79229f5e2367f8132e9e5e476e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6056426 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll dc86d618 2024-12-12T10:01:24 Roll vulkan-deps from 9ee24c2aa734 to bd600597bc4b (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9ee24c2aa734..bd600597bc4b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/c8ae21c728aecf3a512f65babf3ea2ce1b43121b..828d51af674a36f8a6cbaf99c83f30808e9d94e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I7ad1d38463e622fcb3a4806582204b33c4624b3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6090038 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 71e22bf2 2024-12-12T07:00:47 Roll Chromium from f6784391405b to 7b13ac11cb7e (547 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f6784391405b..7b13ac11cb7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5431efe022..d4122dbe61 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/863e50ee3c..75f731e7de * testing: https://chromium.googlesource.com/chromium/src/testing/+log/50b5edf820..6701fb9387 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1a2321d01d..cdb1f13073 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/40c51c5d3e..3ad6a49db4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a7b6e2238a..238650f0b1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/92b37caa42..643441dc2f * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/bb3dd07735..d82e9c4d06 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/6066b14957..19bfdd55df * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/457859ab60..758bbcaa6a * third_party/r8/cipd: jnP8YjPJaWAXthtBv-bT_5HD3c6ywpAmGL31ZURB3fgC..j0CWzYzqsndnaKDzw-cLHbbkO-1-KUttLvurGT_Ve-UC * third_party/siso/cipd: git_revision:332cc31376cbaab640d0622ed3619f3200e1f1e1..git_revision:90146f88d98328d9b83b42d16ee30ff54b48d214 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/487d92d9b3..ee45457cda * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7e9f30e93a..557d05265f No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I1957dea9b150aff274baafc3fc69b707f63f6434 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6090036 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski e9b33f04 2024-12-11T15:17:51 Tests: Add Don't Starve Pocket Edition trace Test: angle_trace_tests --gtest_filter=*dont_starve Bug: b/383500194 Change-Id: I924436d5bb2b166dac5798feff1d614ce1453adb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6090033 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 16e62810 2024-12-03T15:00:13 Add option to run deqp tests with native driver on Android Add a new value option for --deqp-egl-display-type to launch dEQP tests with native GLES driver on Android: --deqp-egl-display-type=native-gles This new value is only parsed and used on Android builds. Applying it has no effects on non-Android builds. Bug: b/379363846 Change-Id: Ia194e09e6cf50a3e505d756a396ef047a8f1ce59 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6068187 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Gowtham Tammana 4532beb0 2024-12-04T11:46:42 CL/Vulkan: Set depth and height initial values For types that dont have depth and height set them to 1, and upate query method correspondingly. Updated the test suit to add new tests to the CI, and the following file was autogenerated using `scripts/run_code_generation.py` - `infra/specs/angle.json` Bug: angleproject:382527246 Change-Id: I982f0558248d053759d50b6fc3ca29d389c62acf Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6075440 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Austin Annestrand <a.annestrand@samsung.com>
angle-autoroll 5efc2682 2024-12-11T21:46:45 Manual roll vulkan-deps from 0057c6fd95c9 to 9ee24c2aa734 (16 revisions) Manual roll requested by cnorthrop@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/0057c6fd95c9..9ee24c2aa734 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/4d2f0b40bfe290dea6c6904dafdf7fd8328ba346..1229f1ef3b82498af600965141cde29a3c928e29 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/c33168850e057596dd6647e154487102091bb65a..eab360311909074896aee1c5dd59a07756fc7f4e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3d71b8748ca519be54daacdabed9dcb6fa4367bf..c8ae21c728aecf3a512f65babf3ea2ce1b43121b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I184a5ab23b02a5a9922d5c6cd0287d8ccbde0a08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6089891 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi fc4fc174 2024-12-10T22:01:28 Vulkan: Prevent crash with D/S FF without D/S attachment The spec says that the values for gl_LastFragDepth/StencilARM are undefined if there is no depth/stencil attachment. This "just" works on tiling GPUs, because reading input attachments simply translates to reading _something_ from the tile memory. For ANGLE, the situation is a little more complicated. ANGLE has to bind descriptors for input attachments (because non-tilers read from the input attachment descriptor instead of using the knowledge that input and color/depth/stencil attachments are one and the same thing in tile memory). When a depth/stencil attachment is missing, there is no image to bind to the descriptor set. ANGLE cannot skip binding an image to the descriptor set, because OpImageRead (translated from subpassLoad()) attempts to access the input descriptor; skipping this causes an internal crash in SwiftShader for example. ANGLE cannot bind a bogus image as input attachment, as Vulkan requires that input attachments are also color/depth/stencil attachments. ANGLE _could_ bind a bogus image as input attachment and also as depth/stencil attachment. This is rather risky, as it then also has to be careful to make sure that depth/stencil attachment is never actually used (i.e. it affects the depth/stencil state, load/store ops etc). In this change, the shader itself is modified to remove references to the depth/stencil input attachments if the attachment is missing. This is rather inefficient, as it means the pipeline warmup will not produce a usable pipeline, but it's accepted as a workaround for something apps shouldn't really be doing. Bug: angleproject:376572258 Change-Id: I0de68252b61615cb82cba7d1730699aadf41e92f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6085368 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e9ba1681 2024-12-10T21:29:26 Vulkan: Fix DR vs FF vs non-draw RP start DR is Dynamic Rendering FF is Framebuffer Fetch RP is Render Pass With DR, whether framebuffer fetch is used or not is no longer tracked in the framebuffer's RenderPassDesc, because that property has no bearing on the framebuffer anymore. It still exits in RenderPassDesc to support legacy VkRenderPass objects. After a draw call starts a render pass, the state of the command buffer's copy of RenderPassDesc (copied from the framebuffer's) is updated to include the correct framebuffer fetch mode. However, this was not done when the render pass starts through other means, such as when a scissored or masked clear would call `Context::startRenderPass`. This change moves the aforementioned update of the framebuffer fetch mode to `Context::startRenderPass` so it affects everywhere the render pass may start from. Bug: angleproject:383356851 Change-Id: I82eff43863fc5b9fe67e57453269ee73859a6cd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6085367 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Gowtham Tammana bde4d143 2024-09-27T14:08:43 CL/Vulkan: Setup a dispatch loop per commandqueue Commands submitted to renderer need clean up ops post completion. Setup a background thread per commandqueue that waits on the command completion and performs the post completion operations. Updated test suite and `angle.json` was autogenerated with `scripts/run_code_generation.py`. Bug: angleproject:375231041 Change-Id: I82b4211ee6e229c679ef31897fc63d61fa904bb5 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5960590 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuxiang Qian 9481eb62 2024-10-23T15:21:33 Add check for some EGL API attrbute values EGL validation in ANGLE lacks of some error handlings mentioned in EGL spec. Those error handlings are added, and we need to make sure angle end2end tests are not influenced. Bug: angleproject:375528200 Change-Id: Ic0686d9ccc70e18b0cf3449184452771c77c06b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6034532 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mark Lobodzinski 09f3bc3a 2024-12-10T15:57:49 Tests: Add Loop Hero trace Test: angle_trace_tests --gtest_filter=*loop_hero Bug: b/383282700 Change-Id: Iff3b5a37b3dfea898344007f544ec25c8b6fa0be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6085489 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shufen Ma f9d08964 2024-10-29T14:14:43 Fix primitive restart issue with line loop Refine function CopyLineLoopIndicesWithRestart and function CopyLineLoopIndicesWithRestart so that they can deal with the case when there is only one index before/after restartIndex. Bug: angleproject:376097643 Change-Id: I06ee0208522d6dc5b6cd6ec0ba4f8682de7b12f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5975353 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0