kc3-lang/angle

Log

Author Commit Date CI Message
Geoff Lang 60e8ea7e 2024-06-14T10:27:03 GL: Don't sync redundant texture state. TextureGL::syncState would always update the state if a dirty bit was set even if that state was already applied. This exposed some driver bugs such as IMG crashes when setting the border color on too many textures. Bug: angleproject:347186590 Change-Id: I81c2403043b389a2ad3cfe5a3461e3b6cdbc9a5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5634131 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 8007cad4 2024-06-14T09:46:48 Android tests: run perf tests on temp_band < 30C bots Applying to both pixel 6 and pixel 4 bots. This should improve the odds of avoiding overheating bots. Bug: b/345514719 Change-Id: Iee3a3efc7ccf93baee56de8b72e05d333f513e3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5630172 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll bcb567a7 2024-06-14T10:01:04 Roll vulkan-deps from 7db4057407f4 to 42ee85cf2154 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7db4057407f4..42ee85cf2154 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/03c0920555fc900b741f6eab0089cb6b52f9f506..99a7973d3c4f5413c6c14b2519d0980041cce68f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e130d5bd2cea031409a9481e3c85c4cd3ddc39fc..828e72c93fb5604dc6fcd97b70a1af077da093e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: If996c970233383ac14bd6308777b3270943d0d74 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5629589 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b100fd57 2024-06-14T07:00:17 Roll Chromium from d9c3e9b06f65 to 972874fcbdf2 (598 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d9c3e9b06f65..972874fcbdf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8f637e82fe..7389598eec * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2bd8dea61c..29f08456d6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a57eb07c61..b9f59df545 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/c704d99cc2..06aa1dc684 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3abd368265..1adfb3f1c6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/43c6415bce..cf92f43226 * third_party/fuchsia-sdk/sdk: version:21.20240606.0.1..version:21.20240613.1.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/852bc6746f..bb4e2e900e * third_party/r8: HVi_TeCysuvnKkdCInnPmFTts90iSXAZ0aAkDruiV6oC..sa1RATDDp0qd7ta7bA984UK5H_bg8gR6iIMIZCx8_AQC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e8ef2fe83c..1274a73b7f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/af75fc97e7..9adebe51ce * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e3bb26a9a8..ec19154875 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0b67d23ab4..1d82f690c6 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ia27f91e9b7c42d381d74fcf1e37d1d74aa93761e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5629588 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 165b85b6 2024-06-13T16:54:03 Vulkan: Disable VK_EXT_shader_stencil_export on SwiftShader Bug: chromium:40942995 Change-Id: I4c469108c420d3e68008a30f627989655a64c27c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5630161 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Mohan Maiya 8ae91859 2024-06-13T15:38:11 Vulkan: Optimize ProgramExecutableVk::resetLayout Instead of iterating through all elements of caches and programinfo, track valid permutations of ProgramTransformOptions. Bug: angleproject:8297 Change-Id: I7676f153f696bf8c4fb268792c667fdac12f827c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5629578 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Mohan Maiya 06f1b72f 2024-06-03T08:59:46 Vulkan: Bugfix in MSRTT emulation Transient multisampled images should have no mips. Enforce this requirement when MSRTT is being emulated Bug: angleproject:4836 Tests: MultisampledRenderToTexture*MultipleLevelsMultisample* Change-Id: I6df21bbb49a4c45aa3ee321f7d49b81f55352562 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5601347 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 479c950e 2024-06-06T00:00:00 D3D11: Implement fragment shader image2D layout updates Checked for updated image2D bind layout when triggering program recompilation. Included image2D bind layout variants into D3DPixelExecutable cache. Added tests for binding 2D array texture layers. Fixed: angleproject:8124 Change-Id: I228a29b5bb175bbf0f8b13e70d1f09e8eb4ebb2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5630654 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev decaefc9 2024-06-06T00:00:00 D3D11: Generalize shader image2D layout cache Ensured that mImage2DBindLayoutCache exists for vertex and fragment shaders. Changed the dirty bit used for image binding updates because they use the ShaderConstants11::updateBuffer function, which is called only for driver uniform updates of vertex and fragment shaders. Bug: angleproject:8124 Change-Id: Ifdfc18f28598b636a1019f53af7617a60c12412e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5621178 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Takuto Ikuta 973e5261 2024-06-13T17:29:20 Roll third_party/dawn/ ff26bfbd4..6cdf3a1a1 (180 commits; 3 trivial rolls) https://dawn.googlesource.com/dawn.git/+log/ff26bfbd4920..6cdf3a1a195f $ git log ff26bfbd4..6cdf3a1a1 --date=short --no-merges --format='%ad %ae %s' 2024-06-13 jrprice [ir] Fix IR dumping for disassembler rename 2024-06-13 dawn-autoroll Roll ANGLE from e1ecc0f1fe4b to 65f8dc8e3ad8 (4 revisions) 2024-06-13 jrprice [msl] Add polyfill for textureNumLevels 2024-06-13 jrprice [msl] Add polyfill for textureSampleBias() 2024-06-13 jrprice [msl] Add polyfill for textureSampleLevel() 2024-06-13 enga Return wgpu::Status from SharedTexture/BufferMemory Begin/EndAccess 2024-06-13 jrprice [msl] Fix undef struct constructor args 2024-06-13 dawn-autoroll Manual roll vulkan-deps from 62eb765e42dd to 7d45b6d174eb (8 revisions) 2024-06-13 dsinclair [hlsl] Start flushing out some printer tests. 2024-06-13 hao.x.li Metal: Skip timestamp period estimation on Intel Iris Plus 655 2024-06-13 dawn-autoroll Roll DirectX Shader Compiler from a44c88e2b803 to 4353db3983e2 (2 revisions) 2024-06-12 dneto spirv-reader: fix call to textureDimensions when the result is unsigned 2024-06-12 enga Remove cmake ubsan/asan bots from CQ 2024-06-12 dawn-autoroll Roll Depot Tools from fd8560139886 to c0883c509ea3 (5 revisions) 2024-06-12 senorblanco OpenGLES: triage T2B failures on Qualcomm. 2024-06-12 enga Renumber webgpu.h enums to reserve 0 except for undefined 2024-06-12 jiawei.shao Improve the error message on the invalid value type of `@blend_src` 2024-06-12 srijan.dhungana6 tint: Experimental Static Samplers Extension 2024-06-12 jrprice [tint] Add --compat flag to Tint exe 2024-06-12 jrprice [compat] Move sample_{index,mask} validation to Tint 2024-06-12 senorblanco Compat CTS: suppress some recent failures. 2024-06-12 hitawala [metal] Add GetMTLDevice to MetalBackend 2024-06-12 jrprice [msl] Skip undef arguments in struct constructors 2024-06-12 jrprice [msl] Polyfill unpack2x16float builtin 2024-06-12 jrprice [msl] Generate E2E expectations for new tests 2024-06-12 dawn-autoroll Roll ANGLE from 544b108a1f77 to e1ecc0f1fe4b (5 revisions) 2024-06-12 dsinclair [hlsl] Stub out emitting lets and vars 2024-06-12 ynovikov Suppress Pixel 6 Android 14 failures already suppressed on Android T 2024-06-12 dawn-autoroll Roll DirectX Shader Compiler from 0b9acdb75e17 to a44c88e2b803 (4 revisions) 2024-06-12 dawn-autoroll Roll Depot Tools from e30d8fac3437 to fd8560139886 (6 revisions) 2024-06-12 dsinclair [hlsl] Start emitting types and constants. 2024-06-12 jrprice [tint] Remove clamping for textureStore 2024-06-12 jrprice [msl] Emit `abs()` builtin 2024-06-12 jrprice [msl] Add polyfill for textureStore() 2024-06-12 jrprice [msl] Add polyfill for textureLoad() 2024-06-12 hao.x.li Add Intel Arrowlake and Battlemage device IDs 2024-06-12 jiawei.shao Disallow using `@blend_src` on a non-struct fragment output 2024-06-12 dneto .gitignore: Ignore local files written by pyenv 2024-06-12 amaiorano dawn/dxc: disable DXC pass 'structurize-loop-exits-for-unroll' 2024-06-12 enga Remove obsolete TODO about future tracking 2024-06-11 senorblanco CTS: widen some expectations on Linux. 2024-06-11 dsinclair Cleanup clang-tidy issues in src/tint/api 2024-06-11 dawn-autoroll Roll ANGLE from 81452425d73f to 544b108a1f77 (12 revisions) 2024-06-11 dsinclair Update name of the disassembler 2024-06-11 jaswant.panchumarti Add struct keyword before structures in new callback function pointers 2024-06-11 senorblanco OpenGLES: enable or suppress Buffer and Texture end2end tests. 2024-06-11 chrome-branch-day Activate dawn M127 2024-06-11 jrprice [msl] Emit read_write access for storage textures 2024-06-11 jrprice [msl] Add polyfill for textureDimensions() 2024-06-11 jrprice [msl] Add member function call validation tests (...) 2024-06-06 jimblackler Fix for Kotlin method parameters. 2024-06-06 jimblackler Allow Kotlin coroutines 2024-06-06 dsinclair [hlsl] Fold PixelLocal options into HLSL options 2024-06-06 dsinclair [msl] Pass pixel local attachment information directly. 2024-06-06 dsinclair Fold the depth_range_offsets into the writer options. 2024-06-06 dsinclair Revert "GL: Rework the EGL loader to support future expansion." 2024-06-06 dawn-autoroll Roll vulkan-deps from c90d01122f40 to 2811d8f38f4c (12 revisions) 2024-06-06 dawn-autoroll Roll DirectX Shader Compiler from 978d36221dae to 8408ae8829c9 (1 revision) 2024-06-06 dawn-autoroll Roll Depot Tools from c069eff3f46d to ad3ad021d938 (1 revision) 2024-06-06 dawn-autoroll Roll SwiftShader from b8cf5b3d2bce to c344e2837bbe (1 revision) 2024-06-06 jrprice [msl] Use the output of FlattenBindings 2024-06-06 dsinclair Remove the Multiplanar and BindingRemapper API options 2024-06-06 jiawei.shao Remove WGSL extension `chromium_internal_dual_source_blending` 2024-06-06 jiawei.shao Tint: Rename the attribute `index` to `blend_src` 2024-06-06 jiawei.shao Tint: Require all the fragment outputs with `@blend_src` have same type 2024-06-06 dsinclair [glsl] Update GLSL binding information. 2024-06-05 enga Remove suppressions for crbug.com/dawn/2489 2024-06-05 bclayton [tint][ir] Land prototype fuzzer 2024-06-05 lehoangquyen Implement LoadResolveTexture in vulkan. 2024-06-05 dawn-autoroll Roll ANGLE from 657c8c0a8c92 to b0eff1966ca0 (6 revisions) 2024-06-05 cwallez GL: Rework the EGL loader to support future expansion. 2024-06-05 dawn-autoroll Roll Depot Tools from ada921199978 to c069eff3f46d (1 revision) 2024-06-05 dsinclair Add some notes on CTS rolls 2024-06-05 dawn-autoroll Roll vulkan-deps from a58be9cfb9b6 to c90d01122f40 (1 revision) 2024-06-05 senorblanco OpenGLES: remove texture copy workaround. 2024-06-05 cwallez Add deprecation warning to Surface::GetPreferredFormat. 2024-06-05 christophe.dehais Update dependencies in python fetch script 2024-06-05 jrprice [msl] Add polyfill for atomicCompareExchangeWeak 2024-06-05 jrprice [msl] Add support for most atomic builtins 2024-06-05 jrprice [ir] Validate construct for structure types 2024-06-05 jrprice [ir] Fix ValueToLet for store-before-load 2024-06-05 dawn-autoroll Roll ANGLE from aa1abba2ba5e to 657c8c0a8c92 (6 revisions) 2024-06-05 lokokung [wgpu-header] Clean up for 2nd userdata for mapAsync and workDone. 2024-06-05 lokokung [wgpu-headers] Updates mapAsync callback to match wgpu-header. 2024-06-05 lokokung [dawn][tests] Updates operation waiting in general. 2024-06-05 sunnyps d3d: Map Depth24PlusStencil8 to DXGI_FORMAT_D24_UNORM_S8_UINT 2024-06-05 dawn-autoroll Roll Depot Tools from 2a18f6d32454 to ada921199978 (1 revision) 2024-06-05 dsinclair Triage mac function_param limit expectation 2024-06-05 jiawei.shao D3D12: Only keep buffer bounds checks when robustness is enabled 2024-06-05 dsinclair Add external texture test. 2024-06-04 dawn-autoroll Roll SwiftShader from 2719cdf350f4 to b8cf5b3d2bce (2 revisions) 2024-06-04 rharrison Reject OOB index access that are being washed through a ref 2024-06-04 senorblanco Remove suppressions for now-passing test. 2024-06-04 dawn-autoroll Roll vulkan-deps from bdf2b85a2504 to a58be9cfb9b6 (9 revisions) 2024-06-04 dawn-autoroll Roll ANGLE from d8c7c4be7320 to aa1abba2ba5e (7 revisions) 2024-06-04 hitawala [YCbCr Samplers] Add wgpu::TextureFormat::External 2024-06-04 cwallez Add an egl_platform.h to undef xlib/windows.h macros 2024-06-04 dawn-autoroll Roll SwiftShader from 4bb94d6c235c to 2719cdf350f4 (1 revision) 2024-06-04 dawn-autoroll Roll vulkan-deps from a27561991332 to bdf2b85a2504 (11 revisions) 2024-06-04 patrto d3d: Change D3D references to PhysicalDevice to WeakRef instead of Ref Created with: roll-dep third_party/dawn Bug: angleproject:341220050 Change-Id: I7b59fc50c2052fbf8e6d9b1e235b0f8d4f1fc372 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5629111 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 53fdd3b1 2024-06-11T08:53:55 Vulkan: Remove suppression for fixed syncval error VVL bug fixed upstream. Bug: angleproject:344031874 Change-Id: I2521744439b93531ef9bab66a37cd71884a74cf1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5621970 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e34a6b31 2024-06-13T10:01:52 Roll vulkan-deps from 9a693759186a to 7db4057407f4 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9a693759186a..7db4057407f4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/eb49bb7b1136298b77945c52b4bbbc433f7885de..2acb319af38d43be3ea76bfabf3998e5281d8d12 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/65d30c31508e47d34f7698f511aea4800e3d44fe..bc28ac7c195f59b14535edec8472d97fd32a91ad https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/15ba84ba94ff2ed473474deba2b4f2af4705b1fb..e130d5bd2cea031409a9481e3c85c4cd3ddc39fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I29c9531bc8e463003a96404f16881b6c75feb517 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5627322 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b150bcb8 2024-06-13T08:01:47 Roll VK-GL-CTS from 2329d7c1259e to 1c5f78753fd9 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2329d7c1259e..1c5f78753fd9 2024-06-12 lordalcol@users.noreply.github.com Create vulkan-cts-withdrawal-2024-06.txt If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I5c1fa2423f264b6b5afbc88a781b89b374986b47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5627321 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 058e033b 2024-06-13T07:01:02 Roll Chromium from 62114f568675 to d9c3e9b06f65 (613 revisions) https://chromium.googlesource.com/chromium/src.git/+log/62114f568675..d9c3e9b06f65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d589326c99..8f637e82fe * testing: https://chromium.googlesource.com/chromium/src/testing/+log/74a176ae95..a57eb07c61 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/bfe59c2726..c704d99cc2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7d78c6d786..3abd368265 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6f180c0a23..43c6415bce * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8ea570d64e..af75fc97e7 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/95f8f0ed55..e3bb26a9a8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ebf8bfe8a1..0b67d23ab4 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I10a5ba597831cf182654fd1211dda0774a1572f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5627320 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 65f8dc8e 2024-06-12T17:01:54 Vulkan: Remove traces of VK_MSRTSS_GOOGLEX Devices that shipped this unreleased extension should have long been updated to VK_MSRTSS_EXT Bug: angleproject:4836 Change-Id: I23736ebf28afd4a6f3b5b0d5a6417b3e7564c293 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5627575 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Amirali Abdolrashidi a4e3c3c1 2024-06-11T20:12:52 Skip tessellation shader PrimitiveID test for S22 * Skipped the following KHR-GLES31 test: * ~.gl_InvocationID_PatchVerticesIn_PrimitiveID Bug: b/267953710 Change-Id: I5f8e76b0993ab6c367cef7ffbf2faa4f057a01e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5620740 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 75625e6b 2024-06-11T11:10:24 Vulkan: Clean up ImageHelper::flushSingleSubresourceStagedUpdates This CL changed some logic to use helper function to make logic more clear. Bug: angleproject:42263375 Change-Id: I5d0ec0f6b0a315f9e755939420a655976a2fef5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5620736 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll f4fac69b 2024-06-12T10:01:26 Roll SwiftShader from 2ff3212615da to 085997ddb08b (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/2ff3212615da..085997ddb08b 2024-06-11 swiftshader.regress@gmail.com Regres: Update test lists @ 2ff32126 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I3af07969196bbd5c7b70d966ee4349c114733a3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5625311 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e1ecc0f1 2024-06-12T10:01:43 Roll vulkan-deps from efa3591618f5 to 9a693759186a (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/efa3591618f5..9a693759186a Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/68821c4da8189262228bbd51e56ed75971b2d2c9..a92c61f8456fa9731c0b000a2c6fc52a740c2be7 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/c3178da8eac9bc7d1788e95f8d555918ba483c23..65d30c31508e47d34f7698f511aea4800e3d44fe https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/0da27800f9aa80159688644cf02af1a4f4dafd9e..15ba84ba94ff2ed473474deba2b4f2af4705b1fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: If7a8140c6454cdccfd7f04b489a46f5556bb947f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5625136 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ff6b1ef1 2024-06-12T07:00:22 Roll Chromium from ccd430f1bf10 to 62114f568675 (506 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ccd430f1bf10..62114f568675 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0eb093566a..d589326c99 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3c5fe075fe..74a176ae95 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c63cfff73e..7d78c6d786 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e30d8fac34..6f180c0a23 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/209717dd69..887bb57a1b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/c1d18115ba..e8ef2fe83c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/686f88cb9f..8ea570d64e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3e8a67d085..95f8f0ed55 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/c5b623b3ba..4ac80c5c63 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/54a575f14b..ebf8bfe8a1 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Icb32b3172a16275392719935f7a4ff7d08b67e73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5620741 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 37a93190 2024-06-11T17:08:58 Skip OES_geometry_shader GLES test on Pixel4 After adding a test to compile and attach a geometry shader using the related OES extension, it was seen that the test fails on Pixel4 while using OpenGLES. * Skipped the related test on Pixel4. Bug: b/346650202 Change-Id: I25b97603cad6c83875d57fda98c9a779b8fdef07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5622987 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuxin Hu dc8c924b 2024-06-11T15:22:49 Remove test suppression that is no longer failing Bug: angleproject:7327 Change-Id: Iefb0316ec4838a5e7371cebe661f305e06db0ecb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5623850 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Roman Lavrov 15c182f9 2024-06-11T09:47:07 Vulkan: remove deferFlushUntilEndRenderPass feature, always on This only applies to Qualcomm chipsets, the feature was already enabled for all other devices. It was previously causing a manhattan 3.0 perf regression on some Qualcomm devices, but my tests on S24 both with ANGLE trace manhattan_31 and running gfxbench manually do not show any obvious regression. It was also not expected that this would result in a regression. As we do not aim to improve perf on older devices, removing the feature altogether so that defers are always enabled. This change resulted in a change in gold images on these traces on pixel 4 bots: pokemon_masters_ex - text was missing and now is rendered street_fighter_iv_ce_frame86 - shadow was missing and now is rendered So it looks like the feature may have been working incorrectly. Bug: b/346378481 Change-Id: I2b0d15b89e11c67dea7c316a42bc807441c43b0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5622115 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi 544b108a 2024-06-07T16:26:29 Add unit tests for geometry shader OES and ES32 * GeometryShaderTest is now the base for ~ES32. * Added "Core" to APIExtensionVersion. * Added unit test for compiling and attaching a geometry shader for the OES version and core ES 3.2. Bug: angleproject:42262233 Change-Id: I035a2dddfe5e91d8ba4426c6d10e76cf2a32b1b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5610272 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 6554cd32 2024-06-07T16:26:10 Add validation for FramebufferTexture FramebufferTexture() was added as part of the geometry shader extension. However, it has become core in GLES 3.2. * Added validation for glFramebufferTexture(). * Added unit tests to check for validation errors for the OES and 3.2 core versions. Bug: angleproject:42262233 Change-Id: I2696d37bb54a26f0fe455107dca472cc05063fa6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5605108 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Charlie Lao b4f3824e 2024-05-31T11:36:32 Reland "Vulkan: Defer texture data flush until data provided for all levels" This is a reland of commit 490c056a88a33870cb4ba2a7906b0a9688d96262 Original change's description: > Vulkan: Defer texture data flush until data provided for all levels > > One of the major overhead with VkEvent is seeing with first frame where > all textures are being specified. The immutable textures, we always > immediately flush out the update as data provided for each level. This > means one VkEvent is created and SetEvent is called per level. This CL > delays the flush until data for all levels are provided, thus there is > only one flush per texture instead of per level. With this CL asphalt_9 > is no longer timeout on bots when VkEvent is enabled. > > There is also another benefit comes with this CL. On all desktop GPUs, > ASTC format texture are falling back to RGBA8. We always stage a clear > for the emulated format. That staged clear are able to be removed if > data is provided later. Because of we flush out staged update when first > level data is provided, all staged clear for the subsequent levels are > also gets flushed out, losing the chance to be removed. This CL will > allow all staged clears being removed. > > Bug: b/343976993 > Bug: b/336844257 > Change-Id: Ica731ea57db771b16966f4da92ccdc551ae93d81 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588816 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: b/343976993 Bug: b/336844257 Change-Id: Iabcc1b4ebca7d6f34a0e7f109795392fc00e7eda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5606146 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Yuxin Hu 9c391154 2024-06-06T18:24:18 Vulkan: Do not apply advanced blend emulation when blend is disabled The emulateAdvancedBlendEquations code path does not check if GL_BLEND is disabled. This CL adds the check so that the blend is not applied when we disable the GL_BLEND. This CL also adds an updateAdvancedBlendEquations() when DIRTY_BIT_BLEND_ENABLED bit is set. This ensures DIRTY_BIT_DRIVER_UNIFORMS bit is set when GL_BLEND state changes, meaning we will regenerate the uniforms if GL_BLEND state changes: GL_BLEND is enabled: pass the advanced blend equations to the uniforms; GL_BLEND is disabled: do not pass the advanced blend equations to the unforms Bug: b/345581214 Change-Id: I5708a4051647bc29b5b38a027e836f5bf717d1d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5605109 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Charlie Lao 5b8e380c 2024-06-10T17:54:25 Vulkan: Fix bug in ImageHelper::flushSingleSubresourceStagedUpdates There is another bug in ImageHelper flush staged update code path that exposed by a new test I added in crrev.com/c/5606145. When we render to a multi-layered texture and that layer we are trying to render to has a staged clear and followed by an buffer update, and if the buffer update overlaps with layer we try to render to but not exact match, we will incorrectly think that the glClear call can override the buffer update. The bug here is that ImageHelper::flushSingleSubresourceStagedUpdates is using ImageHelper::SubresourceUpdate::isUpdateToLayers() call to decide if buffer update will be overriden. That isUpdateToLayers is only looking exact layer range match. So in this case because the buffer update's layer range is bigger than glClear, it returns false. This causes the flushSingleSubresourceStagedUpdates think it is outside the layer range we try to render, and causes rendering bug. This CL renames isUpdateToLayers to isLayerRangeExactMatch to reflect the actual behavior of the function. This CL also adds new API isWithinLayerRange and called by flushSingleSubresourceStagedUpdates to decide if the updates can implement using renderPass loadOp. Bug: angleproject:345532371 Bug: angleproject:42263375 Change-Id: Ia604ed1a61b56d7bde05f12a03baef8f00af2b17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5619730 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
ericali 6164ee69 2024-06-11T15:28:06 Assertion during validateAST for mutli variables struct. When ForceInitShaderVariables is enabled, the init output variable will be rewritten based on symbol table. While SeparateDeclarations will replace the struct declaration from AST and create a new one beforehand. This proposed fix is to find output variable by loop through AST instead of symbol table to fix assertion during validateAST that the mType is different. Skipping this new added test for vulkan pixel 4 due to driver issue. Bug: angleproject:42267047 Change-Id: Id5c6ef8c4ed7bd5fcc6174ebbdd32e0605ac5cd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5613231 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Erica Li <lerica@apple.com>
angle-autoroll f103f3af 2024-06-11T12:39:43 Manual roll Chromium from a4fc928704ae to ccd430f1bf10 (87 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/a4fc928704ae..ccd430f1bf10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1d0fbad529..0eb093566a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8ad9f82c95..3c5fe075fe * third_party/r8: 4Bvfp_cCjeULmPkfvkxfFZbH9xB8l5ctPnHCcpH_U8gC..HVi_TeCysuvnKkdCInnPmFTts90iSXAZ0aAkDruiV6oC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ad038c65fa..3e8a67d085 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/160a3ae6c7..54a575f14b * tools/skia_goldctl/linux: FInOjoKFumG08L2ebBAsdfg4qwh1gYJZUc9pap-n6xsC..IGcekW-Y5Evcutsv6I7Tal5OlOyjNRyxe62iXHbbP10C * tools/skia_goldctl/mac_amd64: 0l-LH3gvKogXZwC20bT0BBAQWhdfoL25JiEUL-6E_UUC..MqOxhrM2nGBzXkfCss1bhSsiN6jZlkWmAeq2G3XQrG8C * tools/skia_goldctl/mac_arm64: Cp4Qw2MXJonjzOYTjnnxkuYfzUaDJb7S2QaR3_-Ky6kC..bU3Sxcveyro3coe6Qg54JY9rrA2wyyJEEkV0vqz7CuAC * tools/skia_goldctl/win: u0dlrkRpMzR6yqRbcwNgFWbdJW1Dzu6oZ47ZJoYgCPoC..oBGPc0UHTbpEZR58WGRQR5k92GvKfdnbVD24GGAqOtsC No update to Clang. Bug: None Tbr: geofflang@google.com,ynovikov@google.com Change-Id: I50d43f2baa9fdd9e4e6ad2ec040088cdc0b033f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5621258 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a6f9459e 2024-06-11T10:01:09 Roll vulkan-deps from 62eb765e42dd to efa3591618f5 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/62eb765e42dd..efa3591618f5 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/73eccd4b67985d344578cade8958214cee0a3f6e..68821c4da8189262228bbd51e56ed75971b2d2c9 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/ce46482db7ab3ea9c52fce832d27ca40b14f8e87..c3178da8eac9bc7d1788e95f8d555918ba483c23 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/1bae807cd919890f7174fa14228b6e672e8d296e..03c0920555fc900b741f6eab0089cb6b52f9f506 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/741921e408442b0370047b5eaf16cbc2b5d381e5..07759f04791dc3fbb390174f0d24d4a792e0d357 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/082e5ac6ccdf5f8e71707414b90f323b1233b80b..0da27800f9aa80159688644cf02af1a4f4dafd9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I8d4b537001bf0728093c8561b9205623b02e2852 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5620729 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b3258049 2024-06-11T07:01:26 Roll Chromium from 2105b88a027e to a4fc928704ae (622 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2105b88a027e..a4fc928704ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d587a4ee3e..1d0fbad529 * buildtools/linux64: git_revision:b3a0bff47dd81073bfe67a402971bad92e4f2423..git_revision:b2afae122eeb6ce09c52d63f67dc53fc517dbdc8 * buildtools/mac: git_revision:b3a0bff47dd81073bfe67a402971bad92e4f2423..git_revision:b2afae122eeb6ce09c52d63f67dc53fc517dbdc8 * buildtools/win: git_revision:b3a0bff47dd81073bfe67a402971bad92e4f2423..git_revision:b2afae122eeb6ce09c52d63f67dc53fc517dbdc8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/464d0500ba..8ad9f82c95 * third_party/android_build_tools/lint: UTwAxkXgodrL9GZEkxLVNaKg7p14YVDh8SrgP4TnOXcC.._oR7ebBg7HOz8losirWwVBzIiJ9AtS3Xv34pUNKrkNQC * third_party/android_build_tools/manifest_merger: NhxjXSeTx7oy0a_3ilG0QjFMO8YItXf67EW20A_stP8C..8yUA9fKPOvtc2p3lVEA3l885a1V4-CXZuKt6xAbdR4AC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0c5efc38bd..1edbffbd91 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0a2c28ef7c..c63cfff73e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/954a8d7713..e30d8fac34 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/ab43b1d3c9..c8f1d81998 * third_party/r8: NCxNylYCpeF52DT5ju1xvvVnuEh3CFBKweSUhjn-IjcC..4Bvfp_cCjeULmPkfvkxfFZbH9xB8l5ctPnHCcpH_U8gC * third_party/turbine: elwEJQJc0yejdGqKWdrPxMt4P7dQ-cC4UB0UdGYRllsC..1kLxPxWBXSIEOzQ1Zzi1M9XXu6pwfDbKCzQrNyGcCCEC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/989902ba2b..686f88cb9f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/921ca3282e..160a3ae6c7 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ie171e66be1061f4f55ad111b5b643dee9cac10c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5619731 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Scott Marcy 46db3d73 2024-05-31T12:21:39 Enable limitExpressionComplexity in translator_fuzzer.cpp Turns on `limitExpressionComplexity` in the translator fuzzer. Bug: angleproject:343889868 Change-Id: Ibbb3db6c2572abf43362ae59fbe8e9a4a30f5345 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588812 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Scott M <mscott@apple.com> Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Amirali Abdolrashidi ebb56cee 2024-05-31T15:10:37 Implement OES_tessellation_shader Based on the specs, there are no functional differences between OES and EXT. * Added validation for glPatchParameteriOES() and the core glPatchParameteri(). * Added the extension support for GLSL. * EXT_shader_io_blocks is implicitly enabled for the EXT geometry and tessellation shader extensions. * OES_shader_io_blocks is implicitly enabled for the OES versions of said extensions. * Added a test to make sure using this extension works instead of EXT. * Turned the repeated test code into a function: * testTessellationTextureBufferAccess * Skipped the tests that fail on various platforms. * It seems that these tests were being skipped before enabling this extension ("Not supported"). Bug: b/344030760 Bug: angleproject:345306326 Bug: angleproject:345304850 Bug: angleproject:345312771 Change-Id: I905da0132bf6525cb453dcaa613e4deb3155c4dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5595611 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi 8042ebdc 2024-05-31T17:06:56 Add OES_tessellation_shader Bug: b/344030760 Change-Id: I49c5dd870a09cd6b43beea13c70b8c1a4266875b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5595610 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Charlie Lao 81452425 2024-06-07T11:49:28 Vulkan: Fix keeping overlapped updates in flushStagedUpdatesImpl() There is an existing bug in ImageHelper::flushStagedUpdatesImpl() that caused webGPU test to fail when my CL crrev.com/c/5588816 landed. The bug is that when we flush out an update, we walk through the vector updates and if the update is outside the range of requested layer range, we stash away the update to updatesToKeep list. We only flush out the updates that are intersects with the requested layer range. The bug here is that if one of the update has bigger layer range than the requested layer range, and there is an update that intersects with that update's layer range but not overlap with requested layer range, now that update may incorrectly gets moved to updatesToKeep list. Later on when that updatesToKeep list gets flushed out, you end up overwriting the image content. This CL adds a new function adjustLayerRange() that first walk the updates and calculate the actual layer range that will be flushed and then use that adjusted layer range to determine if an update should be kept or flushed. Bug: angleproject:345532371 Change-Id: I59ef4ec935354766d35e4cfbb6ce4b13d9a2e868 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5607276 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi c519a4a6 2024-06-10T15:56:36 Vulkan: Add dynamic rendering features Bug: angleproject:42267038 Change-Id: Ic2cdc277f6bb1bb3ce273a866bdb2ce6f5930355 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5617653 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov cc4fe098 2024-06-10T15:11:02 Tests: InRenderpassFlushShouldNotBreakRenderpass feature skip Flush is only deferred when deferFlushUntilEndRenderPass feature is enabled. It was intentionally disabled for Qualcomm devices due to perf: https://crrev.com/c/2441667 Bug: angleproject:42265681 Change-Id: I15d580c334a20e9ea58aec418a608f0b07bda2d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5617650 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 2c3e5f23 2024-06-06T14:49:06 Vulkan: Add Texture3DTestES3.ClearThenTexSubImageWithOverlapp This CL added two tests: Texture3DTestES3.ClearThenTexSubImageWithOverlappingLayersThenRead to expose a vulkan backend bug that we may incorrectly keep an overlapping update. Then on top of the first test, another test is added to do the darw call after texSubImage call to test the flush call originated from FBO works correctly. Bug: angleproject:345532371 Change-Id: I6014d6f0f1f0ed3a4813b9a78ec7e7ef1dfb2e66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5606145 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov 442d66e3 2024-06-10T14:48:31 Tests: add "AHB" to ImageTest.UpdatedExternalTexture test name Other tests using AndroidHardwareBuffer have AHB in the name Bug: b/338429767 Change-Id: Ief9c6e5401baed54bc85696957ddc77b71dfe06b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5617330 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 57524dc9 2024-06-06T00:00:00 Fix shader image level rebinding Added a test that interleaves two draw calls with rebinding the texture level of a shader image; fixed surface init. Vulkan: Fixed subresource serial generation. D3D11: Fixed dirty bit setting. Fixed: angleproject:7647 Bug: angleproject:8124 Change-Id: I4b5d095a1714f31a4f7b63f96dedb366faa17a03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5611298 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Yuxin Hu 2b0c0236 2024-06-06T15:28:24 Suppress KHR-GLES3.clip_distance*/cull_distance* tests on AMD These tests also failed on AMD. Bug: b/341780527 Change-Id: Ice12f8d5340217827f9db38c271e8b3251c52c8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5606483 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev 18bb6e54 2024-06-06T00:00:00 Metal: Support non-layered 2D array shader images Fixed: angleproject:8125 Change-Id: Id148c09d948487bb677c4a3af746e6ea151d84a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5604225 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 5b4eae44 2024-06-06T00:00:00 GL: Do not set layer params for non-layered image bindings Some drivers do not ignore them and image access behaves incorrectly. Bug: angleproject:344950165 Change-Id: I4e369d093bc61f7ebef8fb1058bf2475605c729c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5610693 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 706fa5d8 2024-06-10T10:01:07 Roll vulkan-deps from f629315dfd72 to 62eb765e42dd (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f629315dfd72..62eb765e42dd Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/192d051db3382e213f8bd9d8048fc9eaa78ed6ab..d192041a2fc9c9fd8ae67d8ae3f32c5511541f04 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/377016eea5ebd4f6d6689c1e7a7ca2a2207c3fb4..1bae807cd919890f7174fa14228b6e672e8d296e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/0ed7d9d71588f46e972f7fdc9d41ac888b2fa5f6..a9a1bcd709e185700847268eb4310f6484b027bc https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/252879e8958afc0c250ed460dbecf43c206fca04..741921e408442b0370047b5eaf16cbc2b5d381e5 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/10693af7a6e409fafee9a7cc988e9719692beb6c..082e5ac6ccdf5f8e71707414b90f323b1233b80b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ie91ef33a33b4afe78ecf09e91cb9cf799aaab2d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5613611 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll aa75d2f1 2024-06-10T08:25:18 Roll Chromium from 87095b772157 to 2105b88a027e (849 revisions) https://chromium.googlesource.com/chromium/src.git/+log/87095b772157..2105b88a027e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5127cf2fa7..d587a4ee3e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8e2102749d..464d0500ba * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/eeb2d566f9..6337c445f9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6d8f67fae..954a8d7713 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c5d2b1886c..43dd5b4bf6 * third_party/siso: git_revision:14cdeef66cab719c7c63c95894ce443288d020f4..git_revision:188a286bc04cc0276ce8dfecd64f04785b6f038c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a4e8bf1222..989902ba2b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a74571d054..921ca3282e No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I06c57652bafc255733779d3026eaa3b386a7203e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5610846 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bb908741 2024-06-10T08:01:45 Roll VK-GL-CTS from d2d6aa656073 to 2329d7c1259e (14 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/d2d6aa656073..2329d7c1259e 2024-06-07 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-06-07 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-06-07 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-06-07 dleone@nvidia.com Fix swapchain extent for non scaled resize tests 2024-06-07 ziga@lunarg.com Test image usage with format features 2024-06-07 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-06-06 rgarcia@igalia.com Add option to enable/disable duplicate case name check 2024-06-06 syoussefi@google.com Remove DE_NULL from C files 2024-06-06 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-06-06 michal.jakubek@mobica.com Expand dual_blend tests for secondary fragment outputs 2024-06-06 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-06-05 kamil.goras@mobica.com Split KHR-Single-GL4x.enhanced_layouts* tests 2024-05-31 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-05-31 kamil.goras@mobica.com Split tests ARB_sparse_buffer and ARB_sparse_texture(2|_clamp) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I6bf0be070f91a43789867957084d14c420aaa3c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5612665 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 3a3b55f7 2024-06-07T16:26:05 Tests: Disable modern_combat_5 on Pixel 6 + Android 13 Test uses an engine we haven't tested before and is triggering thermal throttling crashes only on Pixel 6 with Android 13(T). Throttling code improved by the Android 14(U) release. Test: angle_trace_tests --gtest_filter="*modern_combat_5*" Bug: b/42267261 Change-Id: Iffaf5c4d25e928c4914c2d7ec3223141929a961a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5609832 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov a76432f0 2024-06-07T15:00:18 Android perf tests: increase custom-throttling-temp to 38C (applies to pixel6 perf bots only) Multiple bots running hotter than expected: b/345514719#comment10 Bug: b/345514719 Change-Id: I4e4a20cf2872a73ff7594b8a1edabdb1b4cfd153 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5607830 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Charlie Lao f5d6112b 2024-06-05T17:20:45 Vulkan: Remove EventStage::BottomOfPipe and AllCommands These two StageFlags never being used in VkCmdSetEvent, and should not be used given that these are very strong synchronization. They are removed in this CL. Bug: b/336844257 Change-Id: I68a47a5459dadf56ad5c269ebb3af55887110cc7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5601811 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Roman Lavrov b4cd3a68 2024-06-07T13:53:01 Perf tests: trials 4->3, samples 6->3. Currently we're running each test for 6*4*10 seconds, which is a LOT. This CL reduces to 3*3*10, which is still a lot, but less so :) I think the reasoning for getting more samples was to reduce variability, but 1) thermals need to be taken into account and 2) we shouldn't be spending that much time per test. 9 data points results in 1 outlier dropped on each side: """ Truncation: Removing the 1 highest and lowest times from wall_times. """ Bug: b/345514719 Change-Id: I15b31c9d4ff94965e1bf7932571f97cd392f2006 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5606164 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Charlie Lao 295ff607 2024-06-05T14:49:33 Vulkan: Precompute stageMask of kImageMemoryBarrierData Right now every time we need a pipelineStage in kImageMemoryBarrierData, we are doing a bitwise AND with mSupportedVulkanPipelineStageMask. This get called multiple times from barrier call. This CL adds mImageLayoutAndMemoryBarrierDataMap that has already precomputed all stageMask, thus avoid run time bitwise OR. This CL also precomputes the bufferWritePipelineStageMask so that flushImpl can be use it without construct every time. Bug: b/345279810 Change-Id: I878bd31c967cd217477061976f07df13b043fa7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5601073 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll df2cdd73 2024-06-07T14:43:41 Manual roll vulkan-deps from a58be9cfb9b6 to f629315dfd72 (16 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/a58be9cfb9b6..f629315dfd72 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4da479aa6afa43e5a2ce4c4148c572a03123faf3..73eccd4b67985d344578cade8958214cee0a3f6e https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/ff2afc3afc48dff4eec2a10f0212402a80708e38..eb49bb7b1136298b77945c52b4bbbc433f7885de https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/6a2bdeee75eb35e5349c6993d33c9afe30237d79..ce46482db7ab3ea9c52fce832d27ca40b14f8e87 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/d67a9d3a394e11c1c4c0f480124f5b7925cb1b4d..0ed7d9d71588f46e972f7fdc9d41ac888b2fa5f6 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/f1bf2fadb0d599c9bd5516aefa9f8a10d7a377cf..10693af7a6e409fafee9a7cc988e9719692beb6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: I2b5323462e9c1821e9f63ecfcf5a0120710c25e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5605106 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov da0b30f0 2024-06-07T10:00:37 Android perf tests: add temp-based throttling to pixel6 bots. Seems like we don't have sufficient airflow to run heavy tests at full throttle. Some shards start >10C hotter, so add custom throttling to avoid aggressive throttling by the phone itself skewing perf results. This might noticeably increase shard runtime on bots with poor airflow. Implementation is similar to https://crrev.com/c/5288455 but relies on data available on current bot OS build (no IThermal) and does _not_ disable phone throttling. Bug: b/345514719 Change-Id: I582838c2448c9b014381a4f8ba847343b68e4d3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5608312 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll e5a99974 2024-06-07T10:01:15 Roll SwiftShader from c344e2837bbe to 2ff3212615da (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/c344e2837bbe..2ff3212615da 2024-06-06 dcheng@chromium.org Disable MSan in Swiftshader JIT 2024-06-06 swiftshader.regress@gmail.com Regres: Update test lists @ 5bbc20ed 2024-06-06 syoussefi@google.com Update CTS patch according to new CTS format 2024-06-06 syoussefi@google.com Implement VK_KHR_dynamic_rendering_local_read If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:42267038 Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I513f5f615ba0567203cfce8d6ececf16f449afff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5607485 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a39e70f7 2024-06-07T07:01:22 Roll Chromium from 263a51c32801 to 87095b772157 (678 revisions) https://chromium.googlesource.com/chromium/src.git/+log/263a51c32801..87095b772157 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8fede9ade6..5127cf2fa7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ee2736d561..8e2102749d * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/2888a739e9..0c5efc38bd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/eda440d333..0a2c28ef7c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ad3ad021d9..e6d8f67fae * third_party/fuchsia-sdk/sdk: version:20.20240529.4.1..version:21.20240606.0.1 * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/c9c77525ea..2f6f2ff5e4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1c5ff31f9f..a4e8bf1222 * tools/luci-go: git_revision:0e7802b85394ee2b790423aa212a53ffe2b828a8..git_revision:6fb4d5d26773ebddeac2c57506324493e4220007 * tools/luci-go: git_revision:0e7802b85394ee2b790423aa212a53ffe2b828a8..git_revision:6fb4d5d26773ebddeac2c57506324493e4220007 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fe9a5bb276..ad038c65fa * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/74137f12c1..a74571d054 * tools/skia_goldctl/linux: oKjaaaIuivr1YVLozgi7-TQ_3L8gqePnlb73gNTqm9sC..FInOjoKFumG08L2ebBAsdfg4qwh1gYJZUc9pap-n6xsC * tools/skia_goldctl/mac_amd64: v3bqiNn3bOVnhlAPzxLrUe8TQu3c6g-tn486WqLLDGwC..0l-LH3gvKogXZwC20bT0BBAQWhdfoL25JiEUL-6E_UUC * tools/skia_goldctl/mac_arm64: D18xFIj1nfH7hzyRPZ-RwRkUi2mkd78IR2vxt2o3yTUC..Cp4Qw2MXJonjzOYTjnnxkuYfzUaDJb7S2QaR3_-Ky6kC * tools/skia_goldctl/win: eEmE3_xLsZUdGeEycq_UviwCJC4BbKqbiTsNrRALpjwC..u0dlrkRpMzR6yqRbcwNgFWbdJW1Dzu6oZ47ZJoYgCPoC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I7df870dd5490024c11870eba68d116c15e5ed9ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5606148 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 4d47c73a 2024-06-04T15:43:36 Vulkan: Enable SyncVal for VkEvent based barriers Previously SyncVal is disabled due to some tests time out when VkEvent is enabled. Now with earlier CLs that reduces number of VkEvents being used, we are able to enable SyncVal again when event based barriers are enabled. Bug: b/336844257 Change-Id: Idb4f8646495cd087d79f2d09cd12fccfa9062792 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5597733 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao 87bbeaee 2024-06-03T15:04:25 Vulkan: Reduce VkEvent counts by using EventStage enums Right now we are using too many VkCmdSetEvents and causes some of the deqp tests timeout on CI bots (because of VVL is very slow along with the number of events being used). RefCountedEvents are per ImageLayout. But some of ImageLayous have the same VkPipelineStageFlags, for example TransferSrc and TransferDst. This CL changes RefCountedEvent to per unique VkPipelineStageFlags instead of per ImageLayout, thus allows TransferSrc and TransferDst to share one VkEvent. To do that, EventStage enum and kEventStageAndPipelineStageFlagsMap table are added to define the predefined VkPielineStageFlags that ANGLE uses. RefCountedEvent now keeps EventStage instead of ImageLayout. To further reduce the CPU overhead, a customized mPipelineStageMaskAndEventMap table is precomputed in renderer with supported vulkan pipeline stages. With this CL, previously timed out tests such as KHR-GLES3.copy_tex_image_conversions.forbidden.renderbuffer_cubemap* now passing. Bug: b/336844257 Change-Id: I021a8f1d6112d5cf96c61652c9af5f679b1172eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5597732 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 25374c90 2024-05-31T16:08:58 Implement OES_gpu_shader5 Based on the specs, there is no difference between the OES version and the EXT version. * Added support for use in shaders * Added test to make sure the OES extension works. * Turned the repeated test code into a function: * testArrayOfArrayOfSamplerDynamicIndex() Bug: b/344031022 Change-Id: Ifda4fa5495983d254f598940a95d0797e8a9ce67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5595609 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi edaaacd9 2024-05-31T17:30:34 Add OES_gpu_shader5 Bug: b/344031022 Change-Id: Ib11b5835b566e299ce6a7a47a4e4a46bcfd670ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5595608 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 72c94302 2024-06-04T17:24:24 Vulkan: Enable OES_copy_image Based on the spec, OES_copy_image is functionally identical to EXT_copy_image. In addition, they have both been implemented. However, OES_copy_image remained disabled before this change. * Enabled copyImageOES in vk_caps_utils. * Updated the validation for glCopyImageSubDataOES() so it will check for OES_copy_image instead of EXT_copy_image. * Added the enum class APIExtensionVersion to simplify testing multiple versions of the same API (e.g., EXT, OES) * Added tests using CopyImageSubDataOES(). * Turned the repeated test code into functions: * testCopyImage() * testCopyImageDepthStencil() Bug: b/345013929 Change-Id: Ica36882630dac98775626699a170bffe9404273c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5597736 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Charlie Lao 92f198f6 2024-06-06T21:42:35 Revert "Reland "Vulkan: Defer texture data flush until data provided for all levels"" This reverts commit b93af07ac1ddb9f2e262d611d155f4b63f18999f. Reason for revert: b/345532371 Original change's description: > Reland "Vulkan: Defer texture data flush until data provided for all levels" > > This is a reland of commit 490c056a88a33870cb4ba2a7906b0a9688d96262 > > Original change's description: > > Vulkan: Defer texture data flush until data provided for all levels > > > > One of the major overhead with VkEvent is seeing with first frame where > > all textures are being specified. The immutable textures, we always > > immediately flush out the update as data provided for each level. This > > means one VkEvent is created and SetEvent is called per level. This CL > > delays the flush until data for all levels are provided, thus there is > > only one flush per texture instead of per level. With this CL asphalt_9 > > is no longer timeout on bots when VkEvent is enabled. > > > > There is also another benefit comes with this CL. On all desktop GPUs, > > ASTC format texture are falling back to RGBA8. We always stage a clear > > for the emulated format. That staged clear are able to be removed if > > data is provided later. Because of we flush out staged update when first > > level data is provided, all staged clear for the subsequent levels are > > also gets flushed out, losing the chance to be removed. This CL will > > allow all staged clears being removed. > > > > Bug: b/343976993 > > Bug: b/336844257 > > Change-Id: Ica731ea57db771b16966f4da92ccdc551ae93d81 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588816 > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > > Commit-Queue: Charlie Lao <cclao@google.com> > > Bug: b/343976993 > Bug: b/336844257 > Change-Id: Ie987582a44e0d73abd38ce8f6813ff8995e907e2 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5597810 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: b/343976993 Bug: b/336844257 Change-Id: I9356da6b4cdb21dba47758d6e937d1ae02f0ae34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5606144 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Roman Lavrov 3ab0cbfd 2024-06-06T15:41:51 Perf tests: log /dev/thermal temps on Android Bug: b/345514719 Change-Id: Id72bcffc17454ec0d9c3043a2f1e0b51cbf4b4a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5606162 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 2cbac2cf 2024-05-30T00:00:00 Disallow TEXTURE_3D for PLS Using 3D texture slices as PLS planes would require inefficient emulation on some backends. Bug: angleproject:8124 Bug: angleproject:8125 Change-Id: I8fcd4e686bf607deef27a8c091486a9012732f24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594092 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Amirali Abdolrashidi 6a3b2bd3 2024-06-05T16:46:45 Remove tes31Context_override.cpp This override file was originally added to prevent the creation of a GLES 3.2 context. However, it was later removed from the build configs. It should now be possible to remove this file completely. * Removed the file from deqp_support. Bug: angleproject:42262344 Change-Id: Ib60fbf609b92cd03c10056d6bba4e253fc19b96c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5602269 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov c60e247e 2024-06-04T17:40:26 Make LinkedUniform.getElementComponents() fully inline-able Before this CL, getElementComponents() calls into GetUniformTypeInfoFromIndex() which cannot be inlined as it uses kInfoTable from uniform_type_info_autogen.cpp. That table is fairly large however, so this CL adds the elementComponents part of that structure to an inlinle GetUniformElementComponents() function. This allows to fully inline LinkedUniform.getElementComponents() which significantly simplifies clampUniformCount() assembly code, to the point where this leads to a (small but) measurable performance improvement in driver_overhead_2 trace despite getElementComponents _never actually getting called_ (because count is always == 1 and clampUniformCount returns early). This appears to be caused by a side effect of the function call, where clang generates prologue and epilogue instructions that are still executed on the fast path when the function is not getting called (even if ANGLE_LIKELY is added or code rearranged). Bug: b/335295728 Change-Id: If8f2068b098576246ab90ffbacd5a520cc843f49 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5597885 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 7d65c945 2024-06-06T09:01:40 Vulkan: Limit SSBO max size to 256MB on older Mali GPUs Bug: angleproject:345244067 Change-Id: I18ff10198fc3db3a82a0897319fba5fb200a2a05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5603109 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 305bdec9 2024-06-06T00:00:00 Add TextureTestES31.Texture2DLayered test Bug: angleproject:344950165 Change-Id: I4d59c12fd7dbe214e52eea498c93171fade82096 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5600864 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 147ba459 2024-05-30T00:00:00 Allow polygonMode* commands with active PLS Drive-by: * Test that polygonOffsetClampEXT is allowed when PLS is active. Fixed: angleproject:345253437 Change-Id: I5d9f60b3e70eaf8da19017a8b9d6c2592cb4f4f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5601849 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 3c92002a 2024-06-06T10:01:35 Roll SwiftShader from b8cf5b3d2bce to c344e2837bbe (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/b8cf5b3d2bce..c344e2837bbe 2024-06-06 chrisforbes@google.com Only offer KHR_swapchain_mutable_format on non-android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I7f920b309b0bef8db7ead7ef2087b4f83ac56ea7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5597915 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6fffe695 2024-06-06T07:15:42 Roll Chromium from b1a657048264 to 263a51c32801 (599 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b1a657048264..263a51c32801 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/038161e394..8fede9ade6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/bf0c265e19..2bd8dea61c * buildtools/linux64: git_revision:4fb095d3f70f624c73bfdd156c5179fad535287d..git_revision:b3a0bff47dd81073bfe67a402971bad92e4f2423 * buildtools/mac: git_revision:4fb095d3f70f624c73bfdd156c5179fad535287d..git_revision:b3a0bff47dd81073bfe67a402971bad92e4f2423 * buildtools/reclient: re_client_version:0.146.0.0c7ca4be-gomaip..re_client_version:0.143.0.518e369-gomaip * buildtools/win: git_revision:4fb095d3f70f624c73bfdd156c5179fad535287d..git_revision:b3a0bff47dd81073bfe67a402971bad92e4f2423 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a18d081cd4..ee2736d561 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/30d4d21846..bfe59c2726 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/c55fe19074..ca4cddf94a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/01b3d1cd47..eda440d333 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c069eff3f4..ad3ad021d9 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/ba56d9bb6a..c1d18115ba * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b4ab4fad33..1c5ff31f9f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cececb2a6b..fe9a5bb276 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/13496db704..74137f12c1 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Iba42d18678bb72e9f676eb54b1fcf32460cfd948 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5601083 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao b93af07a 2024-05-31T11:36:32 Reland "Vulkan: Defer texture data flush until data provided for all levels" This is a reland of commit 490c056a88a33870cb4ba2a7906b0a9688d96262 Original change's description: > Vulkan: Defer texture data flush until data provided for all levels > > One of the major overhead with VkEvent is seeing with first frame where > all textures are being specified. The immutable textures, we always > immediately flush out the update as data provided for each level. This > means one VkEvent is created and SetEvent is called per level. This CL > delays the flush until data for all levels are provided, thus there is > only one flush per texture instead of per level. With this CL asphalt_9 > is no longer timeout on bots when VkEvent is enabled. > > There is also another benefit comes with this CL. On all desktop GPUs, > ASTC format texture are falling back to RGBA8. We always stage a clear > for the emulated format. That staged clear are able to be removed if > data is provided later. Because of we flush out staged update when first > level data is provided, all staged clear for the subsequent levels are > also gets flushed out, losing the chance to be removed. This CL will > allow all staged clears being removed. > > Bug: b/343976993 > Bug: b/336844257 > Change-Id: Ica731ea57db771b16966f4da92ccdc551ae93d81 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588816 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: b/343976993 Bug: b/336844257 Change-Id: Ie987582a44e0d73abd38ce8f6813ff8995e907e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5597810 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Cody Northrop b0eff196 2024-06-04T20:03:40 capture_replay_tests: Skip forceRobustResourceInit failures These tests fail when forceRobustResourceInit is enabled, regardless of capture status. They were previously skipped: https://chromium-review.googlesource.com/c/angle/angle/+/3118549 and then were removed (perhaps inadvertently): https://chromium-review.googlesource.com/c/angle/angle/+/3291643 They started failing again after a CL that affects the timing of texture updates (http://crrev/c/5588816), were likely just getting lucky, so lets return them to SKIP. Bug: b/345024038 Bug: angleproject:6314 Change-Id: I370502bf9f293a29f7535b04741e47843bffb937 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5599918 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 6968848e 2024-05-30T00:00:00 Remove PLS checks from GLES 1.x entry points Fixed: angleproject:345125742 Change-Id: If845ddb654221cfb88c3f69bb98e07dbee8b6b39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5598770 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 17cd1f5f 2024-06-05T09:56:14 Roll Chromium from f75226a669d5 to b1a657048264 (679 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f75226a669d5..b1a657048264 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1cb0cd5333..038161e394 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f15f314b78..bf0c265e19 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/aeb067e838..a18d081cd4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d822bffbe0..01b3d1cd47 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2a18f6d324..c069eff3f4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/74672d33b4..b4ab4fad33 * tools/luci-go: git_revision:3c691526411b6ba25a7582ad8aff1f5a8848b7be..git_revision:0e7802b85394ee2b790423aa212a53ffe2b828a8 * tools/luci-go: git_revision:3c691526411b6ba25a7582ad8aff1f5a8848b7be..git_revision:0e7802b85394ee2b790423aa212a53ffe2b828a8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/dbc92d80e7..13496db704 * tools/skia_goldctl/linux: DwebaDF4oPSZMck-atrwghRPzS584hU4SE0VMntP4sEC..oKjaaaIuivr1YVLozgi7-TQ_3L8gqePnlb73gNTqm9sC * tools/skia_goldctl/mac_amd64: K1iF08dyALEazf18lHRmK7k-tvRErDRGAVS3JHxHcbsC..v3bqiNn3bOVnhlAPzxLrUe8TQu3c6g-tn486WqLLDGwC * tools/skia_goldctl/mac_arm64: ms8v9LYso2x5_PGXcrV6Jf6ZW_9JYX0yFyJnqB0VrkMC..D18xFIj1nfH7hzyRPZ-RwRkUi2mkd78IR2vxt2o3yTUC * tools/skia_goldctl/win: -t8nUSs-QQ1RnwaD9oWH-_3W-avC2ugb8y29Og6Sq1YC..eEmE3_xLsZUdGeEycq_UviwCJC4BbKqbiTsNrRALpjwC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I4bef28fb737506e014eefee77c2a1c6374b6adcd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5601069 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll d809b7ab 2024-06-05T10:01:27 Roll SwiftShader from 4bb94d6c235c to b8cf5b3d2bce (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/4bb94d6c235c..b8cf5b3d2bce 2024-06-04 syoussefi@google.com Update Vulkan headers to version 1.3.286 2024-06-04 syoussefi@google.com Update Vulkan headers to version 1.3.281 2024-06-04 vvitczak.dominik@gmail.com Fix issues seen when vkCmdSetViewportWithCountEXT() is used. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8605 Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ie63b64737c1dd3a9c52a983eaeceefde36827050 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5600488 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 60c64db1 2024-06-05T10:01:25 Roll vulkan-deps from 162f2ec871cc to a58be9cfb9b6 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/162f2ec871cc..a58be9cfb9b6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/4a2e0c9b3663d1bacc91821ae5699965bff4e5e9..6a2bdeee75eb35e5349c6993d33c9afe30237d79 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/5b71c4be018cfd7951f3618defeb3c4cbf9603e9..f1bf2fadb0d599c9bd5516aefa9f8a10d7a377cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I280617f35f368747dcb7f6e01738244fab7f2283 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5599926 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 6aad8a89 2024-05-31T14:46:28 Vulkan: Remove combineAllShadersInPipelineLibrary If we have VK_NULL_HANDLE as the descriptor set layout handle for both pre-rasterization and fragment shader subset pipelines we run into VVL - VUID-VkGraphicsPipelineCreateInfo-pLibraries-06681 Need to work around this by having the renderer store a placeholder descriptor set layout handle for an empty DescriptorSetLayoutDesc that can be reused across all contexts Bug: angleproject:8677 Tests: EGLMultiContextTest.NonSharedContextsReuseDescritorSetLayoutHandle* Change-Id: I22e7f39c497d7f668afe7cb26690f6a9de49831b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5587990 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Liza Burakova 657c8c0a 2024-06-04T15:16:20 Add optimization to defer clear calls. This change adds a new SubresourceUpdate struct that will hold either an update for a clear call or a texture upload in an ImageHelper's update queue. It also adds logic to defer clear calls similar to Vulkan's, where clears are deferred if there is not an active render pass. Draw based clears are not yet supported, so the optimization does not handle those yet. Bug: angleproject:8582 Change-Id: I3ee010fa64745871835d53ce0ccb56e3fdd74550 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5554984 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Amirali Abdolrashidi 1ecb9ba3 2024-06-03T18:04:34 Vulkan: Make logging GLES32 ext conditional * Added the following flag: * kEnableLogMissingExtensionsForGLES32 * Only if enabled will LogMissingExtensionsForGLES32() log missing extensions required for GLES 3.2. Bug: b/344455232 Bug: b/336860504 Change-Id: I1b10212b0b67e61a0884b1d8af1bb395e693323c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5595319 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 68a899c2 2024-06-04T12:02:06 Vulkan: Remove shaderProgramOut from initGraphicsShaderPrograms - Remove `shaderProgramOut` from `ProgramExecutableVk` `initGraphicsShaderPrograms()` method, because in all instances argument was `nullptr` (unused). - Update `ProgramInfo::getShaderProgram()` to return reference instead of pointer. This removes confusion, causing unnecessary ASSERTs that checked result for `nullptr`. Note: CL that removed last use of `shaderProgramOut`: https://chromium-review.googlesource.com/c/angle/angle/+/5408796 Bug: angleproject:8297 Change-Id: Idf9fb1c3fd42e90dd385f48a5714ea2751f0c7db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5596549 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov d0280f09 2024-06-03T13:21:06 Cleanup Program Executable post link task wait Frontend changes: - Add `ASSERT` into `ProgramExecutable::waitForPostLinkTasks()` to check that `mPostLinkSubTasks` must be empty after backend wait. - Add `UNIMPLEMENTED` into `ProgramExecutableImpl` `waitForPostLinkTasks()`, because this method is only required if backend fills `postLinkSubTasksOut` in `LinkTask`, and frontend must not call this method if `mPostLinkSubTasks` are empty. Vulkan backend changes: - Add public `ProgramExecutableVk::waitForComputePostLinkTasks()` with ASSERT to only allow usage with Compute executable. This change avoids confusion calling `waitForPostLinkTasksIfNecessary()` with `nullptr` in case of the Compute pipelines, which will always wait. - Rename `waitForPostLinkTasksIfNecessary()` to `waitForGraphicsPostLinkTasks()`, add ASSERT to only allow usage with Graphics executable, and change optional pointer to the `GraphicsPipelineDesc` to the reference. - Add `WaitableEvent::AllReady()` check into `ProgramExecutableVk` `waitForGraphicsPostLinkTasks()` when going to skip waiting, in order to process tasks (by calling wait) when all tasks are ready. Without this change, post link task may never be processed, causing repeated `GraphicsPipelineDesc` comparisons. - Replace `GraphicsPipelineDesc` hash comparison in `waitForGraphicsPostLinkTasks()` with `keyEqual()` call. This method is around 7 times faster, however effect on the overall performance will likely be unmeasurable. Changed for clarity. - Remove unnecessary `mWarmUpGraphicsPipelineDesc` reset from: `ProgramExecutableVk` initializer list (has default constructor), Compute warmup (already clean after constructor), wait post link tasks (not used when no tasks). - Other minor changes. Bug: angleproject:8297 Change-Id: I7d790da6712be013243083e314af75f82e73886d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5592474 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Shahbaz Youssefi 25ebddb2 2024-06-04T09:47:53 Mark recently added test as flaky timeout Bug: angleproject:332383430 Change-Id: I67fd00b2735362a9298152e6d23f903ba76a2ba0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5593280 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll b52390b0 2024-06-04T09:14:24 Roll Chromium from bf81256137c8 to f75226a669d5 (634 revisions) Manual update to flatbuffers/BUILD.gn https://chromium.googlesource.com/chromium/src.git/+log/bf81256137c8..f75226a669d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8b9a3d06ef..1cb0cd5333 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/efa920ce14..f15f314b78 * buildtools/reclient: re_client_version:0.143.0.518e369-gomaip..re_client_version:0.146.0.0c7ca4be-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d228592459..aeb067e838 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7adb32fd7a..d822bffbe0 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/840e538154..2a18f6d324 * third_party/flatbuffers/src: https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/150644d7f4..6ede1ccc9e * third_party/turbine: JA8o86DtHkYnsW4v8F9pdcvi7uqN1WB-L1XFLggZdtAC..elwEJQJc0yejdGqKWdrPxMt4P7dQ-cC4UB0UdGYRllsC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/34192533e1..ba56d9bb6a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/586ee04637..74672d33b4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f10c7204c8..dbc92d80e7 No update to Clang. Bug: angleproject:5038 Change-Id: I394574efd8599a28c842d562eb83b0da4c201c00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594940 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll aa1abba2 2024-06-04T10:01:12 Roll vulkan-deps from 356a05c8a553 to 162f2ec871cc (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/356a05c8a553..162f2ec871cc Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0e311906b92f8cc74eab258260343074b00a9710..4da479aa6afa43e5a2ce4c4148c572a03123faf3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/21effda93a239cc4d726b37738c27fdc3e20ec3e..377016eea5ebd4f6d6689c1e7a7ca2a2207c3fb4 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/6bc92daa125da7aed037b46513845ebc67bc96e6..252879e8958afc0c250ed460dbecf43c206fca04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Idb814bcb8a27b0b471ff0a62e303943488b2c634 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594942 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov c41cbb3d 2024-06-03T18:59:27 Fix binary is not cached after isBinaryReady() is true Backend may wait and clear `mPostLinkSubTasks`. The `isBinaryReady()` will check, that there are no tasks, and will skip the caching. This change renamed `cacheProgramBinaryIfNotAlready()` to more general `cacheProgramBinaryIfNecessary()`, because it skips caching if there are post link tasks. The `cacheProgramBinary()` renamed to `cacheProgramBinaryIfNotAlready()`, to better reflect it's behavior. Call `cacheProgramBinaryIfNotAlready()` from `isBinaryReady()` if there no post link tasks to ensure binary is cached. Removed check for empty `mPostLinkSubTasks` before calling executable's wait, because same check already performed internally. The `waitForPostLinkTasks()` is not on hot path and does not require avoiding no-op method call. Bug: angleproject:8297 Change-Id: I2bd78c15231805cda4b62a9889287d8cf780cd1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5593928 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Takuto Ikuta 8a246e12 2024-06-04T10:11:07 Roll third_party/dawn/ 9a3d29c78..ff26bfbd4 (88 commits; 2 trivial rolls) https://dawn.googlesource.com/dawn.git/+log/9a3d29c786c6..ff26bfbd4920 $ git log 9a3d29c78..ff26bfbd4 --date=short --no-merges --format='%ad %ae %s' 2024-06-04 dawn-autoroll Roll ANGLE from 166858014f8c to d8c7c4be7320 (11 revisions) 2024-06-04 beaufort.francois dawn.node: Replace GPUAdapter requestAdapterInfo() with info 2024-06-03 penghuang d3d11: use D3D11_COPY_DISCARD for uploading content to textures 2024-06-03 jrprice [msl] Emit continuing inside a new block 2024-06-03 jrprice [msl] Move RenameConflicts to core and use it 2024-06-03 dawn-autoroll Roll Depot Tools from 840e538154a9 to 2a18f6d32454 (1 revision) 2024-06-03 cwallez Use windows_with_undefs.h everywhere in Dawn. 2024-06-03 dsinclair Update some OWNERS files. 2024-06-03 bsheedy Suppress CTS codecs failures 2024-06-03 lehoangquyen Dawn/vk: Implement input attachments in BindGroup. 2024-06-03 ynovikov Suppress Pixel 6 Android 14 failures already suppressed on Android T 2024-06-03 dawn-autoroll Roll vulkan-deps from 975bd14542a4 to a27561991332 (1 revision) 2024-06-03 jimblackler Kotlin versions of objects are AutoCloseable and Dawn *Release methods are called on close. 2024-06-03 jimblackler Add initial version of the Kotlin JNI conversion 2024-06-03 dawn-autoroll Roll ANGLE from 42a61f6e70c9 to 166858014f8c (1 revision) 2024-06-03 dsinclair Run the code formatter. 2024-06-02 dawn-autoroll Roll ANGLE from 1fa6c0208216 to 42a61f6e70c9 (1 revision) 2024-06-01 dawn-autoroll Roll Depot Tools from 3963cc6399e4 to 840e538154a9 (1 revision) 2024-06-01 dawn-autoroll Roll ANGLE from e3cba40e9a67 to 1fa6c0208216 (10 revisions) 2024-06-01 lokokung Roll reclient to 0.143.0.518e369 2024-05-31 dawn-autoroll Roll vulkan-deps from 4a0e77c7168d to 975bd14542a4 (2 revisions) 2024-05-31 dawn-autoroll Roll Depot Tools from 6427b94bc227 to 3963cc6399e4 (2 revisions) 2024-05-31 dawn-autoroll Roll ANGLE from 7b2c62128d44 to e3cba40e9a67 (9 revisions) 2024-05-31 lokokung [dawn][mock] Update ObjectBase::GetInstance to use device override. 2024-05-31 dsinclair Convert std::endl to newlines. 2024-05-31 jimblackler Complete the Kotlin bindings for ART Android Apps 2024-05-31 wong.kl.matthew dawn/node: Add documentation for ASan CMake builds. 2024-05-31 bclayton [tint][fuzz] Use renamer transform if running HLSL output through DXC 2024-05-31 jrprice [ir] Fix consecutive calls in dependency scanner 2024-05-31 arthursonzogni Roll partition_alloc and build dependencies. 2024-05-31 ynovikov Suppress Pixel 6 Android 14 failures already suppressed on Android T 2024-05-31 blundell [Tests] Add validation test of Device::GetAHardwareBufferProperties() 2024-05-31 dawn-autoroll Roll DirectX Shader Compiler from 3a78b6784928 to 978d36221dae (1 revision) 2024-05-31 dawn-autoroll Roll vulkan-deps from f666a6e01c85 to 4a0e77c7168d (4 revisions) 2024-05-31 lokokung [wgpu-headers] Introduce 2nd userdata to get compilation info callback. 2024-05-31 sokcevic [DEPS] Rely on buildtools recursedep to fetch clang-format 2024-05-31 dawn-autoroll Roll ANGLE from 9876d2ce1f0f to 7b2c62128d44 (5 revisions) 2024-05-31 bsheedy [tools][cts] Add results test coverage 2024-05-31 lehoangquyen Update DawnLoadResolveTexture's render pass compatibility spec 2024-05-31 dawn-autoroll Roll Depot Tools from da5e2f948a0e to 6427b94bc227 (3 revisions) 2024-05-31 dsinclair Update ir::builder includes. 2024-05-31 dawn-autoroll Roll SwiftShader from ec5dbd2dfb46 to 4bb94d6c235c (1 revision) 2024-05-30 dsinclair Cleanup some includes 2024-05-30 rharrison Add check for option to tint::glsl::writer::ASTFuzzer 2024-05-30 dsinclair Remove unused inferred template default parameter. 2024-05-30 jrprice [spirv] Fix terminator creation in MergeReturn 2024-05-30 jrprice Revert "[tools] Improvements to 'fuzz'" 2024-05-30 chouinard Remove passing matrix mul overflow expectations 2024-05-30 bclayton [tools] Improvements to 'fuzz' 2024-05-30 bclayton [tint][wgsl][fuzz] Add more to dictionary.txt 2024-05-30 kylechar Add trace events for Vulkan recording/submit 2024-05-30 dawn-autoroll Roll DirectX Shader Compiler from 128e6ce2be8f to 3a78b6784928 (1 revision) 2024-05-30 dawn-autoroll Roll vulkan-deps from 8f291de2f5be to f666a6e01c85 (2 revisions) 2024-05-30 ynovikov Suppress DrawIndexedTest.NegativeBaseVertex on ARM GLES 2024-05-30 jrprice [ir] Fix store target validation highlight 2024-05-30 jrprice [ir] Add RemoveTerminatorArgs transform 2024-05-30 dawn-autoroll Roll ANGLE from c82d910db718 to 9876d2ce1f0f (2 revisions) 2024-05-30 jrprice [tintd] Allow all extensions and features 2024-05-30 dawn-autoroll Roll Depot Tools from 84ef52b4df40 to da5e2f948a0e (8 revisions) 2024-05-30 sunnyps d3d: Delete unused ValidateTextureCanBeWrapped code 2024-05-30 bsheedy Add tools/src format check 2024-05-30 bsheedy Exclude Go dependencies from builders 2024-05-30 dawn-autoroll Roll vulkan-deps from 9fbe42f1f959 to 8f291de2f5be (6 revisions) 2024-05-30 kainino Make sure adapter info/properties tests actually test for UAF 2024-05-29 dawn-autoroll Roll ANGLE from 018188c73303 to c82d910db718 (4 revisions) 2024-05-29 bclayton [tint][resolver] Mark all short-circuited RHS expressions as not-evaluated 2024-05-29 dsinclair [glsl] Reorder GLSL transforms. 2024-05-29 hitawala [YCbCr Samplers] Add SampleTypeBit::External 2024-05-29 dneto Add 'fuzzer' option to build Tint fuzzers in CMake builds 2024-05-29 dawn-autoroll Roll Depot Tools from a85dcffff40e to 84ef52b4df40 (4 revisions) 2024-05-29 jrprice [ir] Fix Disassembly::EmitOperandList() with count 2024-05-29 jrprice [ir] Track BreakIf as a loop exit 2024-05-29 jrprice [ir] Validate loop body with params has initializer 2024-05-29 jrprice [spirv] Do not add exit phi for loop initializer 2024-05-29 jrprice [msl] Implement ShaderIO transform 2024-05-29 bclayton [tint][ir][spirv] Deduplicate storage textures with different accesses 2024-05-29 lehoangquyen Tint: Add support for input_attachment_index in inspector. 2024-05-29 cwallez Add wgpu::SurfaceCapabilities::usages 2024-05-29 senorblanco OpenGLES: baseVertex, baseInstance workaround. 2024-05-29 bclayton Revert "Remove stale WebGPU CTS expectations" 2024-05-29 blundell [Android] Add Device::GetAHardwareBufferProperties() 2024-05-29 beaufort.francois Add wgpuAdapterGetInfo 2024-05-29 dawn-autoroll Roll ANGLE from 0c87d0edb767 to 018188c73303 (12 revisions) 2024-05-29 dawn-autoroll Roll vulkan-deps from 9486d04e3ac1 to 9fbe42f1f959 (1 revision) 2024-05-29 rharrison Add missing bits of build support for libprotobuf-mutator 2024-05-29 dawn-autoroll Roll Depot Tools from 97246c4f73e6 to a85dcffff40e (1 revision) Created with: roll-dep third_party/dawn Bug: angleproject:341220050 Change-Id: I38cf4321d69879596bb9405da30c7f8e8f6669b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5595369 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Yuly Novikov 170851ff 2024-06-04T09:01:11 Revert "Vulkan: Defer texture data flush until data provided for all levels" This reverts commit 490c056a88a33870cb4ba2a7906b0a9688d96262. Reason for revert: breaks win-trace https://ci.chromium.org/ui/p/angle/builders/ci/win-trace/6014/overview Original change's description: > Vulkan: Defer texture data flush until data provided for all levels > > One of the major overhead with VkEvent is seeing with first frame where > all textures are being specified. The immutable textures, we always > immediately flush out the update as data provided for each level. This > means one VkEvent is created and SetEvent is called per level. This CL > delays the flush until data for all levels are provided, thus there is > only one flush per texture instead of per level. With this CL asphalt_9 > is no longer timeout on bots when VkEvent is enabled. > > There is also another benefit comes with this CL. On all desktop GPUs, > ASTC format texture are falling back to RGBA8. We always stage a clear > for the emulated format. That staged clear are able to be removed if > data is provided later. Because of we flush out staged update when first > level data is provided, all staged clear for the subsequent levels are > also gets flushed out, losing the chance to be removed. This CL will > allow all staged clears being removed. > > Bug: b/343976993 > Bug: b/336844257 > Change-Id: Ica731ea57db771b16966f4da92ccdc551ae93d81 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588816 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Commit-Queue: Charlie Lao <cclao@google.com> Bug: b/343976993 Bug: b/336844257 Change-Id: I25854b855334c4cac1c2b40467d8e2ecb7661b8f No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5593935 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Matthew Denton af72bf7f 2024-05-24T15:00:44 ESSL -> WGSL: emit basic types This emits dimensionless types (no vectors, matrices, arrays). Function signatures will emit their return type (assuming it is dimensionless). Bug: angleproject:42267100 Change-Id: I0d2479f71408eb20b9c329a99c70a6bf6426a72f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5590384 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll cb118080 2024-06-03T21:50:11 Manual roll vulkan-deps from 6e8f93674ed4 to 356a05c8a553 (1 revision) Manual roll requested by cnorthrop@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/6e8f93674ed4..356a05c8a553 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8623 Tbr: syoussefi@google.com,cnorthrop@google.com Change-Id: Ifda8f2e5b0f45b6d00fdc925f82dcc39b71bd239 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594284 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 490c056a 2024-05-31T11:36:32 Vulkan: Defer texture data flush until data provided for all levels One of the major overhead with VkEvent is seeing with first frame where all textures are being specified. The immutable textures, we always immediately flush out the update as data provided for each level. This means one VkEvent is created and SetEvent is called per level. This CL delays the flush until data for all levels are provided, thus there is only one flush per texture instead of per level. With this CL asphalt_9 is no longer timeout on bots when VkEvent is enabled. There is also another benefit comes with this CL. On all desktop GPUs, ASTC format texture are falling back to RGBA8. We always stage a clear for the emulated format. That staged clear are able to be removed if data is provided later. Because of we flush out staged update when first level data is provided, all staged clear for the subsequent levels are also gets flushed out, losing the chance to be removed. This CL will allow all staged clears being removed. Bug: b/343976993 Bug: b/336844257 Change-Id: Ica731ea57db771b16966f4da92ccdc551ae93d81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588816 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll d8c7c4be 2024-06-03T20:16:36 Manual roll VK-GL-CTS from fd5cc7b1e075 to d2d6aa656073 (30 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fd5cc7b1e075..d2d6aa656073 2024-05-31 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-31 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-31 javed@igalia.com Add coverage for image load/store of depth formats 2024-05-31 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-30 marcin.zajac@mobica.com Video capabilities EXT to KHR 2024-05-30 michal.jakubek@mobica.com Coverage for Ldexp, Frexp and Atan2 with subnormal floats 2024-05-30 spatibandlla@nvidia.com Components: Framework - Add native support for QNX Screen 2024-05-30 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (transform_feedback2_states), PART 7 2024-05-30 kamil.goras@mobica.com Split KHR-GL4x.texture_swizzle.smoke and KHR-GL4x.texture_swizzle.functional test 2024-05-30 kamil.goras@mobica.com Split KHR-GL4x.copy_image.functional test 2024-05-30 piotr.byszewski@mobica.com Add self-dependency to resolve_image tests 2024-05-30 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-29 yuxinhu@google.com Fix missing Android build dependencies 2024-05-29 yuxinhu@google.com Fix a wrong class type in tcuTestLogParserJNI 2024-05-29 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-29 erik.faye-lund@collabora.com Update tests to cover BGRA8 formats 2024-05-24 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-24 boris.zanin@amd.com Additional testing for fp16 immediate/inline arguments 2024-05-24 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-24 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-24 david.heidelberg@collabora.com Correct EGL_EXT_config_select_group extension query 2024-05-24 cturner@igalia.com Check transfer queue image granularity requirements 2024-05-24 c.hambacher@samsung.com Fix bind_buffers_2 tests using out-of-bounds vertices for non-maint5 2024-05-24 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.10 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-05-17 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-05-17 syoussefi@google.com main: Run clang-format + remove de* types If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ib728f0df93a6cc8bf16bba4f24312bed5cc184a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594575 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7113795e 2024-06-03T20:26:15 Manual roll vulkan-deps from d4f7e6e954db to 6e8f93674ed4 (19 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/d4f7e6e954db..6e8f93674ed4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2b19bf7e1bc0b60cf2fe9d33e5ba6b37dfc1cc83..0e311906b92f8cc74eab258260343074b00a9710 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/49a1fceb9b1d087f3c25ad5ec077bb0e46231297..ff2afc3afc48dff4eec2a10f0212402a80708e38 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/77c40bece1b8b441eee432fc9d74efbf985f777f..4a2e0c9b3663d1bacc91821ae5699965bff4e5e9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/5677bafb820e476441e9e1f745371b72133407d3..192d051db3382e213f8bd9d8048fc9eaa78ed6ab https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/e15fdd01eff029f2bf15e63970f2a7cebf2999b0..5b71c4be018cfd7951f3618defeb3c4cbf9603e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I403fdea8d5582d7fd5c862a7daab9c5774df0977 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5594279 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao f1f277fc 2024-06-03T10:26:30 Test: Fix crash in MultithreadingTestES3.SimultaneousBufferBind The bug here is that thread0 stopped between nextStep(Step::Thread0Ready) and waitForStep(Step::Thread1Ready)), and then the thread 1 could run all the way to finish. Now when thread 0 wake up and resumes again, waitForStep will hit assertion. This CL let thread 1 wait for thread 0 to finish to avoid getting into this situation. Bug: b/344053420 Change-Id: Ib75e6652feff55e7bb561cc284cdcb86a4852881 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5587993 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Solti 62cdd74a 2024-05-29T19:27:02 Prepare deqp_support files for the removal of de* types - The de* types were removed by the change: https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+/1a09796462f70cfe2a6117f9bc6af6e3ef74e6ff - This CL updates ANGLE accordingly. The change is generated by: https://paste.googleplex.com/4847290045169664 - Reference: https://github.com/KhronosGroup/VK-GL-CTS/blob/aefd5c09cacdb5a3320da717af6ec646d96c2379/format_all.sh#L17-L41 Notes: - starting in patchset #10, the CL de-coulples the deqp_support updates from the VK-GL-CTS DEPS advance. Test: presubmit, and the problematic files mentioned in http://b/343202259#comment3 are updated. Bug: b/343202259 Change-Id: Idc374fa0873e9ddaafe4c9f861995952f2f5e7e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5580985 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Solti Ho <solti@google.com>
Solti 9ca4c0df 2024-05-31T23:08:26 Manual roll vulkan-deps from f7e762742da9 to d4f7e6e954db (1 revision) Manual roll requested by solti@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/f7e762742da9..d4f7e6e954db Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/ff56cf67d3494eec1243cc4225d1667e9b3f90cd..e15fdd01eff029f2bf15e63970f2a7cebf2999b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Note: - in addition to the DEPS, this CL suppresses the VVL error. Bug: angleproject:344031874 Bug: b/343202259 Change-Id: I145d09821ba1ae4adbefcf151d3a852f00c3f950 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5587991 Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Charlie Lao a87ca02c 2024-05-31T11:18:52 Vulkan: change shouldUpdateBeStaged to shouldUpdateBeFlushed All usage of shouldUpdateBeStaged() is actually a negate if(!shouldUpdateBeStaged(...)) {doFlush();}. This CL changes shouldUpdateBeStaged to shouldUpdateBeFlushed to make it easier to read. The other change is that there is a distinction of a texture update must be flushed and update prefer to be flushed. So shouldUpdateBeStaged() logic has been split into two functions updateMustBeStaged and updateMustBeFlushed. shouldUpdateBeFlushed simply because it is either must be flushed or not mustBeStaged (proactively flush for performance reason). This CL is also a preparation for next CL. No actual behavior change is expected here. Bug: b/343976993 Change-Id: Icd9f57f43b6fb5761e9845cc6f27f9458073f905 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588815 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Yuly Novikov 63ae42fc 2024-06-03T16:15:16 Skip end2end test on Linux Intel Vulkan GLSLTest_ES31.TernaryOnStructsInDifferentBlockStorages new test added in http://crrev.com/c/5570154 fails on Mesa 23.2.1 Bug: angleproject:342316794 Change-Id: I73ab54837643bf4b51c68b747439b85e887c2bc8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5593929 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Roman Lavrov c8db5292 2024-05-31T19:35:32 Remove locks from most glUniform* calls Note: only the Vulkan backend claims to be thread safe. glUniform1i and glUniform1iv are kept locked as they might set samplers, which is more complicated. glUniformBlockBinding is a more complex state change with notifications. Other glUniform functions simply call setUniformImpl() or setUniformMatrixfv() in the vulkan backend, which as https://crrev.com/c/5588853 and https://crrev.com/c/5592968 show only update mDefaultUniformBlocks and mDefaultUniformBlocksDirty. This should be thread-safe as long as the application is not creating race conditions itself such as by changing the same object in parallel. This should yield a significant improvement in the driver_overhead_2 benchmark which is heavy on such calls. Bug: angleproject:8666 Bug: b/335295728 Change-Id: Iad1577b9ab2eb57b6a4599ec6d70fa90eb518e8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5588385 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov ce2bc8e8 2024-05-31T17:29:24 Docs: Add a little guide for repro'ing failures on bots Bug: angleproject:344019996 Change-Id: I89168b1ebdd62d2ac5775c300faeda6a8c06a0a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5587906 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
kmx.io     mail     discord kmxgit v0.4.0