scripts


Log

Author Commit Date CI Message
Manh Nguyen 634d1718 2020-08-14T12:34:11 Add unittests of ANGLE commit message format check Mocks depot_tool input_api and output_api for ANGLE presubmit checks' unittests. Adds unittests of ANGLE commit message format check Bug: angleproject:4961 Change-Id: I2a8bc2c3703d9a07b26f7609490dbd80369c73b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2356287 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 5c8c6b42 2020-08-13T15:45:04 Roll VK-GL-CTS from b2be8f165978 to fb86cfb19849 (4 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b2be8f165978..fb86cfb19849 2020-08-12 rgarcia@igalia.com Try alternative DS formats in extended dynamic state tests 2020-08-07 piotr.byszewski@mobica.com Revert workaround for SNORM linear filtering 2020-08-07 rgarcia@igalia.com More extended dynamic state variants 2020-08-06 pawel.ksiezopolski@mobica.com Add tests for VK_EXT_full_screen_exclusive extension If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com Change-Id: Ic8d1b4611e6c7e3a0d5aa90f1015e7b6fadbb238 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2354358 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop d667ad2f 2020-08-11T16:09:36 Tests: Add Mobile Legends trace Test: angle_perftests --gtest_filter=TracePerfTest.Run/*mobile* Bug: b/163619545 Bug: angleproject:4048 Change-Id: I8ed176afe10b758a22b539d526bf02a9fe35ab92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2350582 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuly Novikov 398a874c 2020-08-11T14:19:32 Add tools/clang/dsymutil to roll_chromium_deps.py New DEPS entry added in https://chromium-review.googlesource.com/c/angle/angle/+/1926387 We should sync it together with other DEPS coming from Chromium. Bug: angleproject:4149 Change-Id: I3b10b5568bace2b55c07b664702ae8a82ccc2289 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2349528 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Le Hoang Quyen 9385eb35 2020-08-02T23:21:54 Metal: Generate default shaders to separate files. Generate default shaders' OS specific versions to separate files to avoid mtl_default_shaders_autogen.inc becoming too big. Bug: angleproject:2634 Change-Id: Ie2a39971ec46c36ce13bf5cb72f998f2cbc0ab64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2332145 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 4ac12af4 2020-08-11T07:01:49 Roll Vulkan-Headers from 8446db62f194 to 6eaf979e7366 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/8446db62f194..6eaf979e7366 2020-08-10 oddhack@sonic.net Update for Vulkan-Docs 1.2.150 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: Ib5610bf1d44fae79fd759d56d42e24950f714472 Bug: None Tbr: ynovikov@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2348254 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Le Hoang Quyen f37f1dcb 2020-08-02T19:38:54 Metal: Init format table using Metal-Feature-Set-Tables.pdf - Format table is now initialized using informations from https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf. Previously, it was setup using gl::GenerateMinimumTextureCaps(). - This CL also adds InitializeTextureDataFunction and LoadFunctionMap to mtl::Format. They are needed to properly initialize/convert textures with non-normalized formats. - This CL is prerequisite for integer & floating point format supports. - New test: DXT1CompressedTextureTest.DXT1Alpha (this test was added in the past but was reverted for some reasons). Bug: angleproject:2634 Change-Id: I5eaad812909a49c4c138d0f65fd21a6a199fcb22 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2332144 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov f9e98fd4 2020-08-10T21:48:10 Fix clang revision regexp in chromium autoroller to match new format Sample revision: llvmorg-12-init-1771-g1bd7046e Was git hash before Bug: chromium:1104516 Change-Id: I5373dc6dbe9bb0960dcea7d151898a60f92e3d84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2348112 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Manh Nguyen bbfbea9d 2020-08-10T10:55:58 Invalid calls' pointer params are no longer captured Changes call capture methods generation so that invalid calls no longer capture pointer params. Bug: angleproject:4817 Change-Id: I2d83d4d3334da8ba34925f80aed2de859a10fae5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2346749 Commit-Queue: Manh Nguyen <nguyenmh@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 063d754b 2020-08-07T12:02:13 Tests: Update NBA2K20 trace Significantly reduce setup for this trace. First frame drops from ~430K lines to ~150K lines of code. Compile/link times should be bearable. TBR: ianelliott@google.com,jmadill@chromium.org Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*" Bug: b/160014453 Change-Id: Ia33941012e02ec5488d039501f592dc48e9acfe4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2343454 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop fc8866cf 2020-08-07T10:31:35 Tests: Update Angry Birds 2 trace Primarily fix the width/height of the drawing surface, but also pull in changes from July 2020 update. TBR: courtneygo@google.com,jmadill@chromium.org Test: angle_perftests --gtest_filter="*Trace*" Bug: b/157672184 Change-Id: Ia6e16f6d695954f50b3d2a4e8aaaa88514b461d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2343453 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll ea952ff3 2020-08-06T18:38:04 Roll VK-GL-CTS from 4b40207be32d to b2be8f165978 (32 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/4b40207be32d..b2be8f165978 2020-08-06 Alexander.Galazin@arm.com Merge "Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master" 2020-08-06 karolina.palka@mobica.com Add tests for VK_EXT_global_priority 2020-08-06 Alexander.Galazin@arm.com Merge "Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master" 2020-08-06 rgarcia@igalia.com Check per-sample copy results in multisample copy tests 2020-08-06 toni.salmivalli@siru.fi Add a batch of GraphicsFuzz tests 2020-08-06 alexander.galazin@arm.com Update KC CTS 2020-08-06 airlied@redhat.com Fix pixel pack/unpack in nearest edge tests 2020-08-06 airlied@redhat.com fix 1d depth component 16 sizing in layout locations tests. 2020-08-06 paulthomson@google.com Convert GraphicsFuzz vkscript to AmberScript 2020-08-05 toni.salmivalli@siru.fi dEQP-VK.graphicsfuzz.stable-rects-vec4-clamp-conditional-min-mix 2020-08-05 lionel.g.landwerlin@intel.com Test imported signaled sync fd 2020-08-05 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master 2020-08-04 alexander.galazin@arm.com Restore dual source blending tests 2020-08-03 alexander.galazin@arm.com Update Vulkan headers 2020-08-03 paulthomson@google.com Delete excluded graphicsfuzz test 2020-08-03 wojciechx.zoltowski@intel.com Throw an error on missing cmake in build config 2020-07-31 itoral@igalia.com Fix shaderCullDistance limit checks 2020-07-31 rgarcia@igalia.com Test mipmaps with linear tiling 2020-07-30 rgarcia@igalia.com Enable random descriptor writes for storage buffers 2020-07-30 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master 2020-07-29 rgarcia@igalia.com 1D and 3D image copy and blitting tests 2020-07-29 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master 2020-07-29 james.glanville@imgtec.com Stop 10bit formats requiring GL_SRGB encoding 2020-07-29 ruiling.song@amd.com Disable a test that access uninitialized variable 2020-07-29 paulthomson@google.com Update Amber to fix regression 2020-07-24 michal.m.pawlowski@mobica.com Support for VkPhysicalDeviceVulkan1{1,2}Properties in framework 2020-07-24 zzyiwei@google.com Let requireDeviceFunctionality support Android AHB extension 2020-07-24 lionel.g.landwerlin@intel.com Add timeline semaphore polling tests 2020-07-24 ari.suonpaa@siru.fi Test 3D image blit with differing depth 2020-07-23 alexander.galazin@arm.com Update the date in the notice of withdrawal 2020-07-23 alexander.galazin@arm.com Notice of withdrawal of Vulkan CTS 1.1.5.x 2020-07-22 rgarcia@igalia.com Allow Bresenham for single-sample non-strict lines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,geofflang@google.com Change-Id: Ie9c01a3c47d77bd9f896194c30750b5bffc4eef2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2338820 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 277ad4e0 2020-08-05T17:31:08 Make roll_chromium_deps executable Bug: chromium:1104516 Change-Id: I595fe7b47d92cecf2d645bc5d626ef559bf5aa4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2338999 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 91bbd01a 2020-08-05T15:43:10 Rename roll_deps to roll_chromium_deps To emphasize that this script rolls pinned Chromium revision, in addition to other Chromium sub-repos. Bug: chromium:1104516 Change-Id: Idfd80af6f450b8eab255eaa0445f07742400d907 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2339547 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 6b97463d 2020-08-04T19:10:30 Add back glslang include check The issue was fixed upstream by https://github.com/KhronosGroup/glslang/pull/2362 Bug: angleproject:4763 Change-Id: Icc9af01097b1d97653eb15b640eed6bd72365fd1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2337349 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e4e2a847 2020-08-03T14:09:49 Entry points for ANGLE_external_objects_flags Bug: angleproject:4912 Bug: fuchsia:52759 Change-Id: If339f096a74cc87d16a6494562711d718a7738ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2335019 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 26d2e046 2020-08-04T07:01:49 Roll Vulkan-Headers from a0f1f5149d91 to a6d08c75d219 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/a0f1f5149d91..a6d08c75d219 2020-08-03 oddhack@sonic.net Update for Vulkan-Docs 1.2.149 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: If21f9c5c44fe24d22037a40a33c98c8a7ec81087 Bug: None Tbr: geofflang@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336212 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 11207393 2020-08-01T19:47:21 Vulkan: Add an overlay counter for descriptor writes. Note: currently the trace test shows about 1000 descriptor set writes per frame in NBA2k20. Bug: angleproject:4911 Change-Id: Id50d05fe405249c80a38dbbe3c96e7bd8c66cbc4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2333398 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Le Hoang Quyen 69ca1025 2020-07-31T02:08:09 Metal: Implement EGL_ANGLE_iosurface_client_buffer. GL_R16UI format is not supported yet. It will be implemented once integer textures are implemented in metal back-end. Bug: angleproject:4847 Bug: angleproject:2634 Change-Id: I60a52c0ce327a524c74e80b18bb15978ac52065b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2329091 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis 4f7f4387 2020-07-24T11:44:02 Add entry points for OES/EXT_texture_buffer This extension is core in 3.2 Bug: angleproject:3573 Change-Id: If08736759da2fdc680cfa396d354dbfa97d1a60f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2317040 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 41442cce 2020-07-31T11:44:38 Autogenerated changes for GL_EXT_multisampled_render_to_texture2 Bug: angleproject:4836 Change-Id: I86143c6b21ecdbc666ce316b6e4a4b402257f01c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2332957 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi 9b1cab0d 2020-07-31T11:40:05 Fix validation of glFramebufferTexture2DMultisampleEXT In preparation for GL_EXT_multisampled_render_to_texture2. This makes the validation reuse what's there for glFramebufferTexture2D in addition to what GL_EXT_multisampled_render_to_texture requires. Additionally, it uses packed enums for texture target and id. Bug: angleproject:4836 Change-Id: Ie778c84e1ff5a0cb6615257f2aff9e04395dd5aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2332956 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill f3a38d97 2020-07-23T19:00:34 Add a custom trace tests loader. This custom loader will disambiguate the trace tests gl layer from the util GL/EGL loader. Bug: angleproject:4845 Change-Id: I5e8340eb50f736d931302f71f15f556fd9e52081 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315627 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Cody Northrop aed3d65b 2020-07-29T22:23:00 Tests: Add NBA2K20 trace Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*" Bug: b/160014453 Bug: angleproject:4048 Change-Id: I4899af05d48ad2900e6d5e44adc5f5e0bdba157e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2326911 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Peng Huang 4cf2501c 2020-07-27T13:19:27 Add extension EGL_ANGLE_display_semaphore_share_group For sharing semaphores globally. Bug: angleproject:4877 Change-Id: I472e0902fd04ca8350d74e6c0ae6925ee930ccf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319370 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 5f6f47f6 2020-07-29T14:26:37 Tests: Update gfxbench traces Use new capture calls to support offscreen mode. Test: run_angle_perftests --gtest_filter="*Trace*" Bug: angleproject:4845 Change-Id: I6d9ea79bd8339b7d5398e34b0407425e80ce1d32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2327699 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 8adc5469 2020-07-02T10:15:17 Vulkan: Generate mipmap in compute An initial implementation based on AMD's FFX SPD (Single Pass Downsampler). Apart from requiring STORAGE_IMAGE support for the image format, the following limitations are in place due to FFX SPD: - Image must be 2D or 2D array (including cube maps) - Image must be single-sampled The following _can_ be supported, but not yet implemented: - sRGB formats - Integer formats - depth/stencil formats Bug: angleproject:4551 Change-Id: Ibc4d5cea701cca31e55e3d651540872bbd3b473f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2278713 Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Tim Van Patten 43b951c8 2020-07-21T17:36:06 Remove third_party/angle/ from generate_android_bp.py Android builds are failing due to .git/HEAD being listed in the Android.bp, which generate_android_bp.py is supposed to remove. The problem is that the blacklist contains '//third_party/angle/.git/HEAD' rather than '//.git/HEAD', due to generating the GN files from chromium/src/ rather than angle/. This CL cleans this up. Bug: b/160727922 Test: Manual script execution and building in AOSP Change-Id: Ia1682605097791d20b28686f3043ddc08d49ca52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310960 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Cody Northrop ca8f856a 2020-07-22T13:56:40 Tests: Update gfxbench traces Migrate from traces recorded on desktop to traces recorded on a Pixel 4 XL. This impacts the resolution and framebuffer config used for the tests. They now more accurately reflect the numbers seen from running the benchmark directly. Test: angle_perftests --gtest_filter=TracePerfTest.Run/* Bug: angleproject:4048 Change-Id: Ib013dfb35c32c6f97bcae76a74cc16d9a5d1a369 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314896 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill a4535c18 2020-07-22T14:52:26 Fix trace tests auto-generation. This moves the trace header inclusion to the cpp file so that the test itself doesn't need to look at the individual trace headers. This fixes an include directory dependency. Also removes the FBO change callback from the generated traces. Bug: angleproject:4845 Change-Id: I019f0d347a62a81b92bf32110572911111212689 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314217 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6ca2c116 2020-07-17T13:07:24 Make trace tests a shared library. This will facilitate intercepting the GL calls and implementing emulation paths for offscreen redering. Or other EGL/GL features. It does not yet override the GLES loader and uses the shared 'angle_util' loader as it did before. Bug: angleproject:4845 Change-Id: I68806c307f59e1852999299e88dc358781817f12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305042 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Manh Nguyen <nguyenmh@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 4fa75b5c 2020-07-17T12:58:50 Move restricted trace functions to cpp file. This is a refactoring change only. It will facilitate moving these functions to a shared library. A shared library will allow us to more easily override GL functions with an interception layer. The intercept layer will allow us to do emulation for features like offscreen tests. Bug: angleproject:4845 Change-Id: I0e00c0c22a26f1bb8faec30a825c71953033f8a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305039 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 23211585 2020-07-21T10:08:03 Roll chromium_revision b0410bba02..fb6cbaf6e5 (763000:790363) Also updates a Vulkan back-end file to not return error. Change log: https://chromium.googlesource.com/chromium/src/+log/b0410bba02..fb6cbaf6e5 Full diff: https://chromium.googlesource.com/chromium/src/+/b0410bba02..fb6cbaf6e5 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/45ab3c89af..1ee11394cf * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/204a35a2a6..9e121212d4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3993ef1f52..f126fc6578 * third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/36657c103c..9c8566e047 * third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/217407c478..defbf92951 * third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/{chromium_..ec647b85b6 * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/4fa54ca5f7..19f3fad68d * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/ae385786ed..89bddfee9c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/04b99e7bf9..6412135b39 * tools/md_browser: https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/aae45d8d82..be8cf5a17d DEPS diff: https://chromium.googlesource.com/chromium/src/+/b0410bba02..fb6cbaf6e5/DEPS Clang version changed 4e0d9925d6a3561449bdd8def27fd3f3f1b3fb9f:04b9a46c842f793a2baedcad64de35fcbd3e93b7 Details: https://chromium.googlesource.com/chromium/src/+/b0410bba02..fb6cbaf6e5/tools/clang/scripts/update.py Bug: angleproject:4867 Change-Id: I184945ad4d1fc39f4ad9b37cbf411b2c2b74a3ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309223 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 7c79945a 2020-07-21T11:30:01 Roll VK-GL-CTS from 30aa06f22718 to 4b40207be32d (6 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/30aa06f22718..4b40207be32d 2020-07-21 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master 2020-07-21 alexander.galazin@arm.com Remove Amber example test 2020-07-20 slawomir.cygan@intel.com Reintroduce excluded dEQP-VK.binding_model.descriptorset_random tests 2020-07-20 alexander.galazin@arm.com Update Vulkan headers 2020-07-20 gary.sweet@broadcom.com VK_EXT_image_robustness tests 2020-07-20 alexander.galazin@arm.com Update glslang, SPIR-V Headers and tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,timvp@google.com Change-Id: Ie3adac45f59f362fefc67f759356d26924e84d1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309638 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 20eb9be5 2020-07-07T16:24:55 Generate Android.bp from multiple gn descriptions With the introduction of ABI-specific build targets (zlib), the script generate_android_bp.py needs to be updated to consume ABI-specific gn descriptions and generate ABI-specific build rules for each target. The roll_aosp.sh script was updated to generate ABI-specific gn descriptions for each: arm arm64 x86 x64 Bug: b/160727922 Test: Manual script execution and building in AOSP Change-Id: I459b388176f8fcc010f9f5668535d941b931cdd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2285272 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang 49108a12 2020-06-30T11:53:23 Support BGRA_1010102 IOSurfaces in CGL and Vulkan. Bug: chromium:1100599 Change-Id: I7bc2c2e35490e28e9f6fe8f2e0c26cdea50650b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2275731 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll b9411968 2020-07-20T08:20:41 Roll Vulkan-Headers from 858b13a1220a to 83825d55c7d5 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/858b13a1220a..83825d55c7d5 2020-07-20 oddhack@sonic.net Update for Vulkan-Docs 1.2.148 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: I8963f84e3fac3b06974e23843617c9014ba0f39f Bug: None Tbr: timvp@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307169 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c754c02a 2020-07-17T13:16:01 Roll VK-GL-CTS from 8726fda3f865 to 30aa06f22718 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/8726fda3f865..30aa06f22718 2020-07-17 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master 2020-07-17 rgarcia@igalia.com Test pipeline layout lifetime after ending cmd buffer 2020-07-17 dcastagna@google.com Add export/import drm modifier test 2020-07-17 rgarcia@igalia.com Test frag shader side effects are not removed by optimizations 2020-07-17 jbolz@nvidia.com VK_EXT_robustness2 tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jonahr@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com,angle-bots+autoroll-info@google.com Change-Id: Id48ef26916cdd755b73512b15c6fca921c59a1fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304442 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Le Hoang Quyen 3e0b61a9 2020-07-06T01:18:22 Metal: Compile default shader source files separately. - Previously all default shader files were included in one file named master_source.metal. - Now they will be compiled separately and link together to generate binary shader. - Also generate a debug binary variant that will be used in debug build. Bug: angleproject:2634 Change-Id: Ic040835c4a729666e73afeba52f5be839b632396 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281784 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Le Hoang Quyen 9277ee74 2020-07-06T12:40:58 Metal: Implement MSAA default framebuffer. GL_SAMPLE_COVERAGE_VALUE is implemented by inserting gl_SampleMask writing logic to fragment shader. New test added: MultisampleTest.ContentPresevedAfterInterruption. - Skip on D3D11 (Bug: angleproject:4609) Bug: angleproject:2634 Change-Id: Ib44daf0baccc36ea320596d81713156047da059c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281783 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 249db6da 2020-07-14T07:01:36 Roll Vulkan-Headers from 2a164e9680a5 to 858b13a1220a (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/2a164e9680a5..858b13a1220a 2020-07-13 oddhack@sonic.net Update for Vulkan-Docs 1.2.147 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: I63fdb76434d1dc6091c69032687bf28ca098c95c Bug: None Tbr: jonahr@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2296843 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 95bfb3e5 2020-07-08T23:07:48 Vulkan: Fix resolve draw path If the draw path is taken for resolve, the internal shader previously calculated (1+sum(sample.a))/sampleCount instead of sum(sample.a)/sampleCount. Additionally, due to a typo, the result was rounded. This change also fixes a number of off-by-one errors when calculating src/dst offsets in blit/resolve path. Tests are added to resolve from default to FBO and vice versa to exercise the draw path which was otherwise never invoked for color buffers. Bug: angleproject:4746 BUg: angleproject:4092 Change-Id: I4b9c181339b89af44b27d61d27a6b3d88cde2eea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2288224 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
angle-autoroll 5263d5e1 2020-07-13T13:15:07 Roll VK-GL-CTS from 44ef9e08c459 to 8726fda3f865 (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/44ef9e08c459..8726fda3f865 2020-07-13 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master 2020-07-12 ilkka.saarelainen@siru.fi Add support for comments in amber index files 2020-07-12 ari.suonpaa@siru.fi Test texelfetch on uniform texel buffer with packed format 2020-07-08 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master 2020-07-06 piotr.byszewski@mobica.com Test transitions between command buffer states 2020-07-04 alexander.galazin@arm.com Update SPIR-V Tools/Headers and glslang 2020-07-04 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master 2020-07-04 alexander.galazin@arm.com Update Vulkan headers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jonahr@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com,angle-bots+autoroll-info@google.com Change-Id: I48bc03267af2f66bb3794f31b060d74f4d4e1343 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2294915 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Courtney Goeltzenleuchter f61272fb 2020-06-17T11:38:37 Add support for VK_KHR_sampler_ycbcr_conversion This adds ability for applications to import Android Hardware Buffers (AHBs) as OpenGL images which in turn can be sampled from and/or written. This was specifically tested with the common use case of importing a buffer created by an media decoder and using that as a texture source to include that video content on the screen. Tested with: - Angry Birds 2 video player (for ads) requires YUV conversion. - Basic Media Decoder example: https://github.com/android/media-samples/tree/master/BasicMediaDecoder Bug: b/155487768 Change-Id: I9255450f81aa4daa2aace7205d4f6c3f225abcca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2175103 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll dcd57068 2020-07-07T07:01:38 Roll Vulkan-Headers from 8188e3fbbc10 to db06fce926b0 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/8188e3fbbc10..db06fce926b0 2020-07-04 oddhack@sonic.net Update for Vulkan-Docs 1.2.146 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: I399b1bccafada63ed83d384501747ba63aa80544 Bug: None Tbr: syoussefi@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2284423 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi b291ad09 2020-07-03T23:53:10 Build specialized version of glslang Bug: angleproject:4763 Change-Id: Ibb98c872a1283b9d6acde958a7c5212cf79e72df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281618 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 36a97db1 2020-07-02T23:29:45 Vulkan: Compress internal shaders Shaves ~200KB in binary size. The compressed SPIR-V blobs are in most cases a little smaller than 1/3 of the original size. The internal shader blobs at this point take ~100KB. Bug: angleproject:2022 Change-Id: I1a2cec073cb1f330632c8dce7a550a0cca1e373d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2280945 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Dirk Pranke ba584cf7 2020-07-06T11:05:25 Fix import paths for //scripts/run_gtest_angle_test.py. We added run_gtest_angle_test.py in a86c854, but didn't actually check that it worked :(. This CL adds the missing sys.path imports needed to find the rest of the Chromium test script modules. Bug: chromium:816629, angleproject:3162 Change-Id: I4c381bda334df4d2e648aab65ca4cc0310d840bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2283694 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
angle-autoroll 07193df6 2020-07-04T11:46:26 Roll VK-GL-CTS from 2e189d3854db to 44ef9e08c459 (27 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2e189d3854db..44ef9e08c459 2020-07-04 jbolz@nvidia.com Add tests for VK_EXT_private_data 2020-07-03 alexander.galazin@arm.com Uncomment gen_framework.py 2020-07-03 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master 2020-07-03 rgarcia@igalia.com Test atomic operations with VK_KHR_buffer_device_address 2020-07-03 rgarcia@igalia.com Tests for global atomic operations 2020-07-03 piotr.byszewski@mobica.com Update VK_EXT_fragment_density_map2 names 2020-07-03 ari.suonpaa@siru.fi Add atomic operation tests for multisample storage images 2020-07-02 rgarcia@igalia.com Add core feature bit checks for Vulkan 1.1 2020-07-02 ashafer@nvidia.com Prevent leaking extra fences 2020-07-02 rgarcia@igalia.com Ensure swizzle identities work with their equivalent mappings 2020-07-02 rgarcia@igalia.com Fix VK_AMD_shader_trinary_minmax feature checks 2020-07-02 ari.suonpaa@siru.fi Add test for writing to an SSBO array 2020-06-26 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master 2020-06-26 rgarcia@igalia.com Add missing mandatory features 2020-06-26 venni.ihanakangas@siru.fi Remove handwritten array from the driver properties test 2020-06-26 pdaniell@nvidia.com Fix framework device properties generated code 2020-06-26 marcin.kantoch@amd.com Robustness2 features are enabled by default 2020-06-26 pawel.ksiezopolski@mobica.com Move texture parameter checking to checkSupport() 2020-06-26 rgarcia@igalia.com Separate types and cases in random descriptor set tests 2020-06-25 rgarcia@igalia.com Add ModfStruct and FrexpStruct to GLSL precision tests 2020-06-19 ari.suonpaa@siru.fi Add tests for SNORM clamping 2020-06-19 rgarcia@igalia.com Add tests for VK_AMD_texture_gather_bias_lod 2020-06-19 rgarcia@igalia.com Test vkQueueBindSparse with timeline semaphores 2020-06-19 rgarcia@igalia.com Test vertex buffer accesses with stride zero 2020-06-19 rgarcia@igalia.com Test maximum compute work group sizes 2020-06-19 mika.vainola@siru.fi Add modfStruct comparison tests 2020-06-19 piotr.byszewski@mobica.com Add tests for VK_EXT_fragment_density_map2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ianelliott@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com,angle-bots+autoroll-info@google.com Change-Id: I6d13d94fbc5f3931e7ab7a8beb4cca2767085061 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281477 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi d38c75c5 2020-07-02T22:12:19 Vulkan: Remove BufferUtils shader This was the first internal shader written for prototyping UtilsVk. It ended up never having a user. Bug: angleproject:2022 Change-Id: I846dcc216c4c018f5bda16ad67463f698b8e1c56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2280944 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Dirk Pranke a86c8547 2020-07-02T12:57:52 Add missing data deps to angle test executables. Currently the Chromium build defines some wrapper test targets for ANGLE (//chrome/test:angle_perftests and //chrome/test:standalone_angle_unittests) that seem to exist only to specify some extra data dependencies. By moving those data dependencies into angle, this removes a couple of targets in Chromium that are otherwise problematic for my planned changes for crbug.com/816629. Bug: chromium:816629 Change-Id: Ic0d50132f102f39749c92b062eec38a529db2c1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2280255 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
Ian Elliott da3e6451 2020-06-25T23:49:22 Vulkan: Fix fbo_invalidate tests for pre-rotation The BlitFramebuffer path wasn't properly supporting stencil and MSAA paths for pre-rotation: 1) The stencil path on Android isn't going through UtilsVk::blitResolveImpl, but requires changing UtilsVk::stencilBlitResolveNoShaderExport for rotation. 2) MSAA resolves requires rotating clippedSourceArea. Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_\* Bug: b/158337857 Change-Id: I092cab302c247ff9b2e262b12de3d1a56a257f8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2269499 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Ian Elliott b067db75 2020-06-25T23:47:09 Vulkan: Fix copySubImageImplWithDraw() for pre-rotation This involves cases of copying from a rotated default framebuffer. Various adjustments are needed for where the source is and its relationship to gl_FragCoord in the custom ImageCopy fragment shaders. Various tests are affected, including the following: Test: angle_deqp_gles2_tests --gtest_filter=dEQP.GLES2/functional_texture_specification_basic_copy*teximage2d_* Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_texture_specification_basic_copy*teximage2d_* Bug: b/158245571 Bug: b/157933235 Change-Id: Id9ec56d849cd2268954dd82623a7632a10fb8e8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2248204 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 6ee18c2d 2020-06-17T12:54:52 Vulkan: Remove debug symbols from internal shaders Shaves ~47KB on binary size. Bug: angleproject:2022 Change-Id: Ifc861c4308a806d17f499bf2126009a59125b9f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2249566 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Ian Elliott 70e706f4 2020-06-22T18:14:44 Vulkan: Fix glBlitFramebuffer() for pre-rotation This involves cases of blitting to/from a rotated default framebuffer, potentially with scaling in one or both dimensions. Various adjustments are needed at different times in the stack, including in the custom BlitResolve fragment shaders. Various tests are affected, including the following: Test: angle_end2end_tests --gtest_filter=*EGLPreRotationLargeSurfaceTest.OrientedWindowWithBlitFramebuffer Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_\* Bug: b/158337857 Change-Id: Ibb176e4215784e85c0f34e6e1c22ba662517fed2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2242359 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Ben Pastene 1496de21 2020-06-11T22:32:55 Remove implied CIPD packages from scripts/trigger.py All of chromium's test pools should have these packages automatically added via task templates. So there's no need to add them ourselves in this script. Bug: chromium:812428 Change-Id: I283ad5963cdf237220545c5ed1f21892f6ade18e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2241901 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Jamie Madill 60672e7b 2020-06-23T12:42:14 Update glslang_validator binary for Windows. This binary was updated using update_glslang_binary.py. Please see instructions in tools/glslang/README.md. Bug: None Change-Id: Idf76f16d7f05ce1642c27f087e40575806aa5d00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2261232 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi ce3d3413 2020-06-23T09:29:05 Update glslang_validator binary for Linux. This binary was updated using update_glslang_binary.py. Please see instructions in tools/glslang/README.md. Bug: None Change-Id: Ib1c3ae292a90ec6aabc79b9396ca2e35007edc16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2260573 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 94e8a3d9 2020-06-22T08:52:31 Roll zlib and cpufeatures from the ndk into Android. zlib is required to compress program binaries. It also pulls in the ndk for cpufeatures. Since the ndk is so large, only pull roll in the required sub-folders. BUG=angleproject:4776 Change-Id: I4967a06fd8bfb27040ad0c2f60fec265d555488a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2255507 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll d11c61f6 2020-06-22T07:01:02 Roll Vulkan-Headers from f31524575668 to 8188e3fbbc10 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/f31524575668..8188e3fbbc10 2020-06-21 oddhack@sonic.net Update for Vulkan-Docs 1.2.145 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: I17d845ae9852bec65a04d1b186b17b9f31e3a67a Bug: None Tbr: courtneygo@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2256862 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop c028fc73 2020-06-19T09:06:03 Tests: Update traces to include draw surface width/height The traces now contain the original resolution they ran with, so we can set that based on testID. This fixes correctness problems on Android, where only a fraction of the screen could be seen during replay. Bug: b/159238311 Test: angle_perftests --gtest_filter="*Trace*" Change-Id: I47b92ee31681998260bad059cde0856a25ae0fc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2250863 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Manh Nguyen <nguyenmh@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi e7ae237e 2020-06-12T23:52:09 Vulkan: ANGLE_copy_texture_3d support Bug: angleproject:4748 Test: CopyTexImage*Vulkan:Texture3DCopy*Vulkan:Texture2DArrayCopy*Vulkan Test: dEQP.KHR_GLES3/copy_tex_image_conversions_required_cubemap*cubemap* Change-Id: Ifdc3d455ca8c9e732d0adf4afa9e2809d780ae18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2246320 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop c81f0b7b 2020-06-18T15:32:48 Tests: Update trace timestamps Move all timestamps forward to get CQ working again. TBR=courtneygo@google.com,jmadill@chromium.org Test: angle_perftests --gtest_filter="*Trace*" Bug: angleproject:4762 Change-Id: I1aff31a705d9a014d4ec3463d3d7b4bf6f3208a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2252542 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 90e6fad9 2020-06-17T15:56:02 Roll Vulkan-Headers from 9d2dfca53b75 to f31524575668 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/9d2dfca53b75..f31524575668 2020-06-15 oddhack@sonic.net Update for Vulkan-Docs 1.2.144 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC courtneygo@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: I3b46b86fc163edc7cf57fb9c99d9231e35b57224 Bug: None Tbr: courtneygo@google.com,jmadill@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2249939 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi b900f4e2 2020-06-12T16:01:58 Vulkan: Use GPU path for copy to sRGB textures To avoid creating aliasing views for sRGB textures, the ImageCopy texture will do/undo sRGB transformation such that the final result is as-if both source and destination views were linear. Possible future optimizations: - If either of source or destination has already been created with the MUTABLE flag, i.e. has a linear view already available, that can be used. - If destination is sRGB but not renderable while its corresponding linear format is, and if the image is already created with the MUTABLE flag, using the linear view would allow the copy to go through the GPU instead of the CPU. Bug: b/157934810 Bug: angleproject:4092 Change-Id: I43aaf882c90e1c60d0d9eb04636c203fc04090a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2241622 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7f7d046b 2020-06-15T18:10:25 Roll VK-GL-CTS from a60f89ffcba2 to bfa95c7ad8b7 (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/a60f89ffcba2..bfa95c7ad8b7 2020-06-12 rgarcia@igalia.com Test isinf() and isnan() with 64-bit floats 2020-06-11 mikel.garai@arm.com Fix maxMipMap calculation for images 2020-06-11 rgarcia@igalia.com Test secondary command buffer with no framebuffer 2020-06-09 hauxwell@broadcom.com Fix --deqp-runmode=txt-caselist option for ES2.0 devices 2020-06-09 jianle.wang@arm.com Fix the sorting order in eglChooseConfig test 2020-06-09 s.fricke@samsung.com Add storageBuffer16BitAccess to mandatory features 2020-06-09 rgarcia@igalia.com VK_EXT_extended_dynamic_state tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC courtneygo@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com,angle-bots+autoroll-info@google.com Change-Id: I787e1af698782bb6015c7a407e60e5c548cd5ac6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2246328 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kenneth Russell af727792 2020-06-10T21:55:43 Improve EGL_ANGLE_power_preference on dual-GPU MacBook Pros. Add the ability to release and reacquire the high-power GPU, and to respond to changes in the active GPU. In Chromium, the GPU process can not access the WindowServer. An external process must inform ANGLE that the active GPU has changed, and that ANGLE should switch its internal context to the new GPU. Incorporates a couple of functions from WebKit, used with permission, to effect this GPU switch. A follow-on change in Chromium which uses these new APIs will make the existing dual-GPU tests pass with ANGLE and the passthrough command decoder. Carry forward Chromium's workaround of disabling GPU switching on older MacBook Pros to ensure stability. Document the process of adding new EGL extensions to ANGLE. Bug: chromium:1091824 Change-Id: I499739156e851b493555d4d6e4aef87d8b97fa31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2240638 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tim Van Patten b55f0f78 2020-06-02T18:01:24 Compress Program binaries saved in blob cache The Android blob cache has a limit of 2MB, so ANGLE should compress the Program binaries that are saved into it to maximize its effectiveness. ANGLE will gzip the program binaries before being stored in the blob cache and then uncompress them when retrieved. Using gzip, the binaries are compressed to ~25% of their size when running the T-Rex benchmark. Some examples (in bytes): Uncompressed: 20193, Compressed: 4455 Uncompressed: 8767, Compressed: 2369 Uncompressed: 11144, Compressed: 2927 This doesn't appear to affect the T-Rex benchmark since all of the programs are loaded/decompressed as part of the benchmark initialization, and the programs are small enough to all fit in the blob cache without compression. Bug: b/155184635 Test: T-Rex, CQ Change-Id: Ie6a101c32ab5fd49baae1cb7aecdd26a934e15af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2227529 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi ac44f8c5 2020-06-05T23:30:53 Vulkan: Apply SPIR-V optimization to internal shaders Shaves about 40KB from binary size. Bug: angleproject:2022 Bug: angleproject:3432 Change-Id: I008c18e0040b1bafe022087113681e2ace6eb7b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1616963 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi da980b40 2020-06-10T23:19:40 Vulkan: Reduce ConvertVertex.comp variations Handling RGB10A2 and A2BGR10 formats are made through dynamic flags. One or two `if` checks (based on format) is not worth doubling the number of shaders. Shaves about 50KB from binary size. Bug: angleproject:2022 Bug: chromium:1084580 Change-Id: Ia603a935b66d002dbacdee9342950ceed4042f86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2240672 Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d8074714 2020-06-08T13:41:40 Vulkan: add autogen dependency to shader variations files Bug: angleproject:3432 Change-Id: If16e5264d539c6a3944a60f4d28f4e6aa5420fe3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2235353 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 53c3ea8f 2020-06-05T17:21:44 Perf: Add a trace of Angry Birds 2 Test: angle_perftests --gtest_filter="*Trace*" Bug: b/157672184 Change-Id: If4885398aff73ce774987fbeefb63d140f7fab1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2233367 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill f56e7227 2020-06-09T14:19:31 Update glslang_validator binary for Windows. This binary was updated using update_glslang_binary.py. Please see instructions in tools/glslang/README.md. Bug: None Change-Id: I5949749ed704f55ecc8ef65789d665b1e8cf7af6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2238388 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll c4004a93 2020-06-09T07:01:02 Roll Vulkan-Headers from db1a98c6cc43 to 9d2dfca53b75 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/db1a98c6cc43..9d2dfca53b75 2020-06-08 oddhack@sonic.net Update for Vulkan-Docs 1.2.143 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: I8255d01829fba9fab643a76693503e5a0242de20 Bug: None Tbr: cnorthrop@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2237188 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 8a7b3d61 2020-06-08T23:23:56 Update glslang_validator binary for Linux. This binary was updated using update_glslang_binary.py. Please see instructions in tools/glslang/README.md. Bug: None Change-Id: I1aed97de25baa3cb47ae81b63a70339a962d957d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2235361 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll eef10995 2020-06-05T10:45:22 Roll VK-GL-CTS from 80dc8399b063 to a60f89ffcba2 (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/80dc8399b063..a60f89ffcba2 2020-06-04 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/master 2020-06-04 ari.suonpaa@siru.fi Test multiple fragment output locations 2020-06-04 rgarcia@igalia.com Try spec constants with more sizes and packing 2020-06-04 pawel.ksiezopolski@mobica.com Add tests for VK_EXT_filter_cubic 2020-06-04 pdaniell@nvidia.com Fix VkPhysicalDeviceMemoryBudgetPropertiesEXT 2020-06-04 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/master 2020-06-04 dcastagna@google.com Fix compilation on clang 11 2020-06-04 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com Change-Id: I882e93a2b23ad3d42e7684f484bf9c30a5585805 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2232182 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 0df92012 2020-06-03T17:08:43 Rename Platform.h to PlatformMethods.h. "platform.h" is too common a name and causes headers to be included incorrectly. Disambiguate the header using a more specific name. Solves a problem that came up with the GLES 1 tests and the standalone test harness. Bug: angleproject:3162 Change-Id: I88229a2c9407e0db57f5beee44daa11a4075f700 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2229065 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Kenneth Russell 3ecaa283 2020-05-22T13:52:41 Fix validation of PVRTC compressed texture sizes. The PVRTC format, as pointed out by Le Hoang Quyen and Geoff Lang, uses 4x4 or 8x4 blocks, but due to sampling from adjacent blocks, requires a minimum size of 2x2 blocks per the OpenGL extension: https://www.khronos.org/registry/OpenGL/extensions/IMG/IMG_texture_compression_pvrtc.txt . Thanks to Quyen and Geoff for pointing out the intricacies. Add a helper function to formatutils.cpp which returns the minimum number of blocks (width and height) for a given compressed texture format, and incorporate this into the compressed texture size computation. This patch makes WebKit on ANGLE pass WebGL's PVRTC compressed texture test on iOS hardware. Bug: angleproject:4652 No-Presubmit: True Change-Id: I1046a091321b7948d712d16686ee0cb8795b8c99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2213676 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov fcd3140a 2020-06-02T14:52:34 Roll third_party/VK-GL-CTS/src/ 60972ed7f..80dc8399b (67 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS/+log/60972ed7fa8f..80dc8399b063 $ git log 60972ed7f..80dc8399b --date=short --no-merges --format='%ad %ae %s' 2018-03-16 capn Add texture specification test for GL_OES_texture_half_float. 2020-06-01 alexander.galazin Update KC CTS 2020-05-15 rgarcia Add SampleMask write tests 2020-05-29 ynovikov Fix Windows build 2019-03-08 lionel.g.landwerlin Add drm format modifiers tests 2020-05-21 piotr.byszewski Correct few pipeline_barrier tests 2020-05-22 slawomir.cygan Do not use 2D array d/s attachment created from 3D texture 2019-04-03 mika.vainola Update Android API levels and grant permissions 2020-05-18 basni Fix overflow in VK_EXT_subgroup_size_control tests. 2019-11-21 courtneygo Fix uninitialized index array 2020-02-24 jdrouan Add conformance tests for new buffer offset rules 2020-03-03 tomek.bury Improve Wayland protocol version selection. 2020-04-30 tarceri Fix broken layout binding tests 2020-05-06 gleese Remove non-compute variants of common function tests 2020-04-17 Kyle.Griffiths Allow RTZ rounding in spv_assembly*writes_two_buffers* tests 2020-05-04 alexander.galazin Update glslang 2020-05-24 alexander.galazin Force Popen to text mode 2020-05-07 alexander.galazin Ensure alphabetical order of xml attributes 2020-05-24 alexander.galazin Force Popen to text mode 2020-05-06 james.glanville Limit dimensionality of arrays-of-arrays in random SSBO tests 2020-05-07 alexander.galazin Fix Fedora 32 gcc/clang warnings 2020-05-07 alexander.galazin Fix Fedora 32 gcc/clang warnings 2019-11-18 mike.byrne Split spirv_assembly tests workload 2020-05-12 rgarcia Add --deqp-print-validation-errors cmd line option 2020-04-29 rgarcia Test using ViewportIndex from frag shaders only 2020-05-07 ari.suonpaa Test OpArrayLength with stride larger than element size 2020-05-08 bwatling Add an Amber test which uses textureOffset() 2020-05-09 ari.suonpaa Test negative value conversion to b10g11r11 float format. 2020-05-03 tarceri Fix some egl robustness tests 2020-04-28 aleksy.sokolowski Fix epsilon calculation for RGB10_A2 pixel format 2020-05-14 piotr.byszewski Fix warnings found by compiling with MS VC++ 2019 2020-05-13 piotr.byszewski Correct few tests from indirect_dispatch group 2020-05-12 piotr.byszewski Correct sparse_image_format_properties2 tests 2020-05-12 piotr.byszewski Clarify integer formats conversions in blit_image tests 2020-05-11 piotr.byszewski Correct external_memory_host tests 2020-05-11 piotr.byszewski Correct opatomic_storage_buffer_volatile tests 2020-05-15 alexander.galazin Update Vulkan headers 2020-05-13 alexander.galazin Whitelist Vulkan CTS 1.2.2.1 2020-05-07 slawomir.cygan Add missing barrier to HOST in memory_barrier test 2020-05-04 quic_mnetsch Fix wide line rasterization tests 2019-12-04 courtneygo GLES 3.1 negative framebuffer texture2D test fails 2019-12-17 courtneygo OpenGL ES: Use shader storage alignment 2019-07-31 courtneygo Remove illegal parameter use in fbo.completeness 2019-09-11 courtneygo Fix use of invalid HALF_FLOAT enum 2018-08-28 james.hauxwell Fix invalid combinations for texture/copy on ES2 driver 2019-08-28 timvp Use unsized internal format in KHR-GLES2.texture_3d.[copy_sub_image|framebuffer_texture].rgba8 2019-07-30 courtneygo Fix invalid parameter for GLES 2.0 2018-07-13 james.hauxwell Fix invalid combinations for texture/copy on ES2 driver 2019-12-20 courtneygo Migrate deRoundUp32 to deInt32.h 2020-04-22 alex.walters Non-strict line interpolation and rasterization 2020-05-01 zzyiwei Suppress -Werror=array-bounds for latest GCC 2020-03-13 rosen.zhelev Extend Android Hardware Buffer external memory format tests 2020-05-07 alexander.galazin Ensure alphabetical order of xml attributes 2020-05-07 alexander.galazin Ensure alphabetical order of xml attributes 2020-05-04 cwabbott0 fix input dependency for renderpass depth/stencil format tests 2020-04-27 slawomir.cygan Avoid exceeding maxPerStageResources in descriptor_indexing tests 2020-04-27 ari.suonpaa Split subgroupBroadcast tests 2020-04-03 rgarcia Test variableMultisampleRate with non-empty framebuffer 2020-04-29 ari.suonpaa Added a fourth batch of coverage tests found by GraphicsFuzz 2020-04-17 joshua Make ImageSamplingInstance loop over pNexts 2020-02-26 yevhenii.kolesnikov Add tests for usage of pixel storage modes 2020-04-29 luwang Fix of a build failure on QNX 2020-05-05 alexander.galazin Update SPIR-V Tools 2019-08-28 quic_mnetsch Adds geometry shader check for test 2020-04-17 james.glanville Stop 10bit formats requiring GL_SRGB encoding 2017-12-21 mnetsch Fixes pixelformat utils for RGB10_A2 2018-08-31 yabin.zheng Add specific RGB10A2 data for BlendHSLHue and BlendHSLSaturation Created with: roll-dep third_party/VK-GL-CTS/src Bug: angleproject:4675 Change-Id: Id9b92e3ce400bf2c4669be845d3f6b5a12b5886f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2227039 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll b194892f 2020-06-02T07:01:02 Roll Vulkan-Headers from 09531f27933b to db1a98c6cc43 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/09531f27933b..db1a98c6cc43 2020-06-01 oddhack@sonic.net Update for Vulkan-Docs 1.2.142 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: I2856b05ceecc2f233869621e243b4b11e72acccb Bug: None Tbr: ynovikov@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2226131 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jiajie Hu 77e5316a 2020-05-28T02:00:29 Pull in Android-only dependencies behind a condition In crrev.com/c/1866080, catapult and android_ndk were added for supporting standalone Android builds, which increased ANGLE's fresh checkout time and disk occupation a lot. For ANGLE embedders, this can be mitigated by putting them behind a condition, where checkout_android is a builtin variable controlled by target_os in the .gclient file. For standalone builds on Linux, Android will be added to target_os by default for compatibility with previous behavior. Bug: None Change-Id: I0b258c6fc7f62ca65e705b8c31c9ace5dffd4030 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2216709 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jiajie Hu <jiajie.hu@intel.com>
Cody Northrop 48102b2b 2020-05-29T10:28:18 Perf: Add Candy Crush trace TBR: jmadill@chromium.org,nguyenmh@google.com,tobine@google.com Test: angle_perftest --gtest_filter="*candy*" Bug: b/150458396 Change-Id: I79c86b8d111ef55528da2ec5f0ac3a39428a1667 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2223658 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop b59db10a 2020-05-28T16:24:11 Perf: Add Subway Surfer trace TBR: jmadill@chromium.org,nguyenmh@google.com,tobine@google.com Test: angle_perftests --gtest_filter="*Trace*" Bug: b/150458446 Change-Id: Ie47dfa7208db0fb1f2449b758df9d2b73bbfe974 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2220766 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Le Hoang Quyen c0c938af 2020-05-11T00:50:00 Metal: draw 1 triangle instead of 2 for fullscreen shaders. Reference article in favour of one big triangle instead of 2: https://michaldrobot.com/2014/04/01/gcn-execution-patterns-in-full-screen-passes/ According to this article, the performance could be increased by ~10% for fullscreen shaders. Bug: angleproject:2634 Change-Id: Ia5b04c40f0587e3cb8680c0f30f7b68d9d7a3efe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2193192 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Maksim Sisov 56a4cc12 2020-05-21T13:17:21 Rename DisplayOzone to DisplayGbm. DisplayOzone doesn't really have anything related to Ozone. Instead, it's the gbm platform that is used there. Thus, rename it to DisplayGbm. Bug: chromium:1084458 Change-Id: I4d974f6afbf0daa28fc3e83943b35814dca203fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2211763 Reviewed-by: Michael Spang <spang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Antonio Maiorano 98496cab 2020-05-28T15:02:43 Fix float to int copy in VK backend This fixes WebGL tests on Vulkan (e.g. SwiftShaderVK) that copy from the canvas (GL_RGBA8) to an integer format target texture, such as: conformance2/textures/canvas_sub_rectangle/tex-2d-rg8ui-rg_integer-unsigned_byte.html The sampled normalized value needs to be scaled up by 255. Also fixes angle_end2end test CopyTextureTestES3.ES3UintFormats on Vulkan. Bug: b/156399229 Bug: angleproject:4092 Change-Id: I18d46bc4453fdc500caca96ca3a12fe93290b10c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2219142 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Yuly Novikov 33004b09 2020-05-28T17:22:39 Roll VVL and Headers to v1.2.141 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/424cdd54fe80..afe55126be2d 2020-05-27 shannon@lunarg.com build: Update known-good files for 1.2.141 header 2020-05-27 s.fricke@samsung.com layers: Label 01720 and 01721 2020-05-27 s.fricke@samsung.com layers: Remove CB device tracking 2020-05-27 tony@lunarg.com layers: Temp removal of check for border color feature 2020-05-27 s.fricke@samsung.com layers: Label BindMemory2 VUIDs https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/4c19ae6b95e4..09531f27933b 2020-05-15 oddhack@sonic.net Update for Vulkan-Docs 1.2.141 2020-05-04 devrel@oddhack.org Remove advanced notice of header change 2020-05-04 oddhack@sonic.net Update for Vulkan-Docs 1.2.140 Bug: None Change-Id: I1fa6b821c2b704457a92b0c744a97e546fc5ef81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2220527 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 0652d0d6 2020-05-27T12:59:20 Fix non-existent required dependency TARGET module ANGLE has non-existent required: privapp_whitelist_com.android.angle Bug: b/7456955 Test: TH presubmit Change-Id: I828f154d2ff8126de8383ef56216436c29677729 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2218687 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jonah Ryan-Davis eadc387c 2020-04-01T16:53:31 GL: Support GL_OES_texture_cube_map_array in shader translator GL_OES_texture_cube_map_array is core in 3.2. This CL adds support for this extension in the shader translator. Now passes dEQP.KHR_GLES31/core_texture_cube_map_array.*, dEQP.GLES31/functional_fbo_color_texcubearray_*, and dEQP.GLES31/functional_opaque_type_indexing*samplercubearray* with GL backend. Bug: angleproject:3584 Change-Id: I1a8485c7d9d3fffb9b5109d292b35b0c56a3c665 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2133086 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jonah Ryan-Davis 7fde3673 2020-05-25T15:48:06 GL: Support GL_OES_texture_cube_map_array in frontend/GL backend GL_OES_texture_cube_map_array is core in 3.2. This CL adds the necessary validation for the frontend, as well as support for this extension on the GL backend. The next step is to add the changes to the translator. Bug: angleproject:3584 Change-Id: I751a9c9f71a553b05fdf6673250290806d8cfbff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2215306 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
George Burgess IV 9dac86c9 2020-05-26T08:58:40 gen_proc_table: generate `const` tables We never mutate these tables; marking them const allows the loader to shuffle them to a place that makes them readonly after they're init'ed. This isn't intended to be a functional change. Bug: chromium:1084580 Change-Id: If3356f6082945ef1109bf08aab94f7bfb606b951 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2216295 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis 31fbf981 2020-05-25T15:33:44 GL: Entry points for GL_OES_texture_cube_map_array This extension is made core in GLES3.2. This CL adds the necessary entry points to the frontend. Bug: angleproject:3584 Change-Id: Icaaa0b298898f3360819966a7f67b5feaf05124b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2215305 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 8add7dbf 2020-05-20T15:00:09 Tests: Add trace of Egypt to TracePerfTest Test: angle_perftest --gtest_filter="*Trace*egypt*" Bug: b/157158456 Change-Id: I9c076f247cb8a2743beae8377830c15269794f9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2209689 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop ce925b4c 2020-05-12T11:52:42 Perf: Add Temple Run trace Test: angle_perftests --gtest_filter="*Trace*" Bug: b/152512564 Bug: angleproject:4048 Change-Id: Ifca698a9c294e77bf90900781c1495ef6b559d63 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2197285 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Cody Northrop 3a909841 2020-05-12T14:19:06 Perf: Add Reset call to trace tests The traces are already updated to contain the Reset calls, now actually call them from TracePerfTests. Test: angle_perftests --gtest_filter="*Trace*" Bug: b/152512564 Bug: angleproject:4599 Change-Id: I18b6726bc98b96f132c3245c51420cbfed1b84d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2197284 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 544a80ef 2020-05-12T11:46:15 Perf: Detect context used by trace Capturing supports multiple contexts, which are hard coded into the function and file names. On desktop, they've typically been "1", but on Android we've seen context "2" or "3". This CL adds the ability to detect the context number used by the trace, and programmatically adds it to generated files. Test: angle_perftests --gtest_filter="*Trace*" Bug: b/152512564 Bug: angleproject:4036 Change-Id: I64616b93a704446b08cb614b2a74ab1932ef1f40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2197283 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 93ec0ca5 2020-05-06T11:57:42 Capture/Replay: Regenerate glue if captures change. This ensures if we re-capture with different parameters that we regenerate traces. It uses the sha1 so that it can be run correctly from an open-source checkout. Bug: angleproject:4590 Change-Id: I01a2eef037924c5acaaf124308315364e6f1d723 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2185157 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 9f323042 2020-05-08T14:01:29 Vulkan: Update VMA directory. Bug: chromium:1074162 Change-Id: I6aa545e20f64dda0a1716cf8d0df9ad62fc1a890 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2190624 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang 312e65e1 2020-04-30T12:38:01 Make sure all target names are unique in the generate Android.bp generate_android_bp.py prepends "angle_" to target names to avoid conflicts with other Android projects. This can sometimes generate conflicts when there are two targets such as "angle_vulkan_headers" and "vulkan_headers". This patch turns the gn path+target into the blueprint target name. BUG= b/155396154 Change-Id: I7a709013969ae8e312a781a2fd3c1ec530fca430 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2173833 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill bcd2c592 2020-05-06T15:49:41 Revert "Capture/Replay: Update traces to include Reset" This reverts commit 968bb06d94369b782eacb9b7c6a3f1f2171b5f85. Reason for revert: Broke angle_perftests on the P2 bots: https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%2064%20Perf%20(Pixel%202)/30223 Original change's description: > Capture/Replay: Update traces to include Reset > > Now that our traces can reset state back to how it started with MEC: > > * Update the code generation to include that call. > * Update existing traces to include that call. > * Add a capture of Temple Run. > > Test: angle_perftests.exe --gtest_filter="Trace*" > Bug: b/152512564 > Bug: angleproject:3662 > Bug: angleproject:4599 > Change-Id: I4062271b75b5c6fc9122b301d1af443d79770edc > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2182911 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> > Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> TBR=cnorthrop@google.com,courtneygo@google.com,jmadill@chromium.org Change-Id: Icea86c2fbfbabe4a1e7738954cecc176b5574a16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/152512564, angleproject:3662, angleproject:4599 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2184705 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>