|
66ebd014
|
2012-05-30T22:18:11
|
|
Add the SH_TIMING_RESTRICTIONS compile flag and dependency graph implementation.
Description of the algorithm:
http://code.google.com/p/mvujovic/wiki/ShaderControlFlowAnalysis
This flag is one potential solution to timing attacks on textures containing cross-domain content
or user agent data.
This kind of analysis could be useful for both WebGL and CSS Shaders.
The SH_TIMING_RESTRICTIONS flag will reject a shader if it uses texture dependent data to affect
control flow.
Other ways of affecting shader timing such as using NaNs in basic arithmetic operations or using
built-in functions (e.g. atan) with different inputs are still under investigation.
Issue=329
Review URL: http://codereview.appspot.com/6195062/
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1101 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
51b96855
|
2012-05-30T20:25:05
|
|
Fixed compile errors on linux.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1099 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
e5dfefad
|
2012-05-24T19:29:37
|
|
Renamed UNEXPECTED_TOKEN_IN_DIRECTIVE to UNEXPECTED_TOKEN.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1096 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
7c884540
|
2012-05-24T19:13:03
|
|
Implemented #extension and #version directives.
Review URL: https://codereview.appspot.com/6242045
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1095 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
36124de8
|
2012-05-24T02:17:43
|
|
Implemented #error and #pragma directives. Added new tests and updated old ones for the new preprocessor API.
Review URL: https://codereview.appspot.com/6213066
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1094 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
07d921de
|
2012-05-22T20:22:08
|
|
Token::value now contains text for all types of tokens - not just CONST_INT, CONST_FLOAT, and IDENTIFIER. This makes it easier to report diagnostics and various preprocessor directives.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1093 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
98d04ec8
|
2012-05-21T22:47:20
|
|
Implemented #define and #undef directives.
Review URL: https://codereview.appspot.com/6215072
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1092 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
0eb51ac3
|
2012-05-21T21:43:57
|
|
Deleted old unused files.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1091 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
964b7194
|
2012-05-17T21:12:27
|
|
Fixed compile error in lexer_glue.cpp.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1089 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
99b5c0c9
|
2012-05-17T20:44:52
|
|
Fixed compile errors and warnings on linux.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1088 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
2c958eef
|
2012-05-17T20:35:42
|
|
Moved error-handling to a separate class - Diagnostics. We were earlier returning errors as tokens which did not work very well when error occured while parsing a preprocessor directive. Now all returned tokens are valid. Errors are reported via an abstract Diagnostics interface. Updated unit-tests with the new scheme.
Review URL: https://codereview.appspot.com/6203089
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1087 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
04d7d22b
|
2012-05-16T19:24:07
|
|
Reafactored Lexer class to allow chaining. The full chain when parsing #if directive looks like this: Preprocessor -> MacroExpander -> DirectiveHandler -> MacroExpander -> DefinedFilter -> Tokenizer. This chain dynamically changes depending on the current context.
Also added an incomplete implementation of #if handling and ExpressionParser to illustrate how this design is supposed to work.
Review URL: https://codereview.appspot.com/6203060
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1084 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
355989bc
|
2012-05-09T15:49:29
|
|
Remove duplicate error checks from Texture subImage and subImageCompressed.
Issue=306
Signed-of-by: Nicolas Capens
These errors are validated by validateSubImageParams* now, no need to do it twice.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1083 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
4df88e8a
|
2012-05-09T15:49:24
|
|
Make TextureCubeMap size/format/compressed checks explicit about the level and face they are checking
Issue=306
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1082 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
92f49929
|
2012-05-09T15:49:19
|
|
Make Texture2D format and compression checks be explicit about the level they are checking
Issue=306
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1081 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
4327cff3
|
2012-05-09T15:49:16
|
|
Remove unused base class Texture methods and make them non-virtual in derived classes
Issue=306
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1080 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
eb3c01a8
|
2012-05-09T15:49:12
|
|
make sure all texture->isCompressed calls are type-specific
Issue=306
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1079 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
46f2d0a9
|
2012-05-09T15:49:06
|
|
Split RenderbufferTexture into 2D and CubeMap specific variants
Issue=306
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1078 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
bf6e5d4d
|
2012-05-09T15:49:03
|
|
Remove the unused Texture::getType method
Issue=306
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1077 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
2ccbbef1
|
2012-05-09T15:49:00
|
|
Split validateSubImageParams into a texture type-specific check
Issue=306
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1076 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
28eb3921
|
2012-05-09T15:48:57
|
|
Move the internal format check for compressed subImage commands to the API layer
Issue=306
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1075 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
2d669fce
|
2012-05-09T15:42:48
|
|
Texture: Avoid attempting to create 0 sized D3D textures
Issue=301
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1074 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
56c62636
|
2012-05-09T15:42:45
|
|
Optimize Context::applyTextures by avoiding repeated getTextureSerial calls
Issue=301
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1073 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
ac5d7f39
|
2012-05-09T15:37:04
|
|
Memory associated with allTokens is never freed due to early return in "case -1" in CPPpragma(yystypepp*) in cpp.c
ISSUE=328
Signed-off-by: Daniel Koch
Author: David Kilzer
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1072 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
b45306b7
|
2012-05-07T02:12:34
|
|
Ensure that strings produced by getVariableInfo are always null-terminated
Issue 326
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1070 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
30a487c7
|
2012-05-02T17:30:46
|
|
Minor refactoring for Input class. Chnaged a raw array to std::vector.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1068 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
519c32ba
|
2012-05-01T15:24:05
|
|
Implement SSE2 version of loadAlphaData
http://codereview.appspot.com/6050054/
Signed-off-by: Nicolas Capens
Signed-off-by: Daniel Koch
Authored-by: Jin Yang
With this patch, my HTML5 2D canvas benchmark with Chromium on Windows7 with GPU
acceleration can boost about 4% though the most execution time is in GPU.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1067 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
98eec912
|
2012-05-01T10:04:08
|
|
Using yy_scan_string, which flushes the old buffer does not work. GLSL requires that each input string is concatenated, but yy_scan_string treats each string individually. Added a custom YY_INPUT which maintains the continuity between each string.
Review URL: https://codereview.appspot.com/6130045
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1066 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
8b47903c
|
2012-04-29T19:50:09
|
|
Added missing files from the renaming of UnfoldSelect to UnfoldShortCircuit.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1064 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
11399d5d
|
2012-04-28T00:35:14
|
|
Make sure the internal DX uniforms get updated after re-linking.
TRAC #20659
Issue=321
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1063 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
f8f8f362
|
2012-04-28T00:35:00
|
|
Renamed UnfoldSelect to UnfoldShortCircuit.
TRAC #11866
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1062 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
8915eba8
|
2012-04-28T00:34:44
|
|
Implemented short-circuiting for logical OR and AND operators.
TRAC #11866
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1061 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
44fffeef
|
2012-04-28T00:34:20
|
|
Ensure that non-sequence single-statement conditional blocks and loop bodies get unfolding of short-circuiting operators.
TRAC #11866
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1060 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
a11a6ab8
|
2012-04-27T10:00:38
|
|
Changes to handle comments properly and associated tests.
Review URL: https://codereview.appspot.com/6111059
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1059 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
128d9199
|
2012-04-26T22:39:21
|
|
Added tests for token location.
Review URL: https://codereview.appspot.com/6118062
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1058 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
79fb1019
|
2012-04-26T21:07:39
|
|
Ugly hack to fix compile error on windows. VC++ does not support C99 and hence snprintf.
BUG=308
Review URL: https://codereview.appspot.com/6120055
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1057 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
ef1eaa04
|
2012-04-26T18:02:42
|
|
Changed Token::Location::string to Token::Location::file to keep it consistent with __FILE__ inbult macro.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1055 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
85f2b2c5
|
2012-04-25T06:06:33
|
|
Added rules for ignoring comments.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1053 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
ddb6e8e3
|
2012-04-25T00:48:13
|
|
Stop using unsafe sprintf method.
ISSUE=308
Signed-off-by: Kenneth Russell
Author: David Kilzer
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1052 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
28182485
|
2012-04-24T23:07:34
|
|
Drastically simplified Input class. Now most of the heavy lifting is done by in-built yy_scan_string and yy_scan_bytes. Comment handling will be done by the lexer.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1051 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
d08bb0cc
|
2012-04-23T19:27:13
|
|
The default implementation in flex only handles LF characters. GLSL supports all three newline characters - LF, CR, and CR+LF. Use a custom newline handler.
Review URL: https://codereview.appspot.com/6105045
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1049 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
036a7356
|
2012-04-20T22:34:53
|
|
Do not return newline and number sign. They are for internal purposes only.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1048 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
78a35198
|
2012-04-19T17:16:26
|
|
Added a catch-rule for invalid numbers.
Note that we do not need such a rule for identifiers because they will always be either terminated by a space, a punctuator, or an invalid character. Space and punctuator are both valid cases. The invalid character will be caught by another rule specifically for invalid characters. I will cover this case when I add tests for valid character set.
Review URL: https://codereview.appspot.com/5978048
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1047 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
aeba7b89
|
2012-04-17T23:25:10
|
|
Build fix for chromeos.
BUG=
TEST=chromeos bots compile when we roll ANGLE
TBR=alokp
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1046 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
1f1b0d5d
|
2012-04-17T19:44:15
|
|
Fix signed 16.16 fixed-point conversion.
TRAC #20561
ISSUE=320
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1045 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
571fe348
|
2012-04-17T17:40:29
|
|
Don't append '_' to the end of prefix in long name mapping if the original name starts with '_'
Otherwise we will have '__' which is illegal.
Review URL: https://codereview.appspot.com/5978058
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1044 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
e63436b9
|
2012-04-13T22:51:42
|
|
Handle hex int constant in preprocessor
The patch is provided by jdashg and committed by zmo.
(see angle issue 178)
ANGLEBUG=178
TEST=shader-with-hex-int-constant-macro.html
TBR=zmo
Review URL: https://codereview.appspot.com/6037044
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1041 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
320c5d7f
|
2012-04-13T21:32:35
|
|
Minor formatting change in pp.l.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1039 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
763d0fb9
|
2012-04-13T21:27:06
|
|
Fixed compile error in lexer_glue.cpp.
TBR=zmo@chromium.org
Review URL: https://codereview.appspot.com/6035044
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1038 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
d089d118
|
2012-04-13T17:05:12
|
|
Removed unnecessary includion of Token.h in various files.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1037 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
5e75f344
|
2012-04-12T23:47:10
|
|
Mac/Linux build fix.
BUG=
TEST=compile fine
TBR=alokp
Review URL: https://codereview.appspot.com/6013048
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1035 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
57442b11
|
2012-04-12T23:09:59
|
|
Update emulated functions.
It turns out there are bugs in our tests, so kbr fixed them a while ago. Now we had another look at the tests, and it turned out some functions we don't have emulate, and some functions we need to also emulate in fragment shaders.
BUG=
TEST=
R=kbr
Review URL: https://codereview.appspot.com/6011056
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1034 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
14e966b2
|
2012-04-12T20:57:53
|
|
Modified the interface of Preprocessor. Added it to the build file. Lexer changes to record leading space.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1033 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
40da4c53
|
2012-04-12T05:23:19
|
|
Added HAS_LEADING_SPACE flag to pp::Token. Split the new preprocessor into a separate target.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1032 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
beadd5d2
|
2012-04-12T02:35:31
|
|
Update reserved keywords.
TRAC #20514
ISSUE=317
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1031 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
b7ad052f
|
2012-04-11T20:55:01
|
|
Fix a few compilation warning/errors on Linux/Mac.
Review URL: https://codereview.appspot.com/6009045
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1030 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
2e793f0f
|
2012-04-11T19:41:35
|
|
Decorate (and undecorate) struct fields too (when not built-in).
Trac #20510
Issue=316,317
Authored-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1027 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
fc74c375
|
2012-04-11T17:53:24
|
|
Guard against null surface in Image::updateSurface.
Review URL: https://codereview.appspot.com/5985051
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1026 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
bac1aa1c
|
2012-04-05T17:06:55
|
|
Removed the unnecessary usage of InputSrc::getch and InputSrc::ungetch when handling pragma. These functions are not supported by the new lexer.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1020 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
408c45e7
|
2012-04-05T15:54:43
|
|
Added an alternate lexer for the existing preprocessor. It is still behind a compile-time flag.
Review URL: https://codereview.appspot.com/5976072
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1019 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
88d91fbb
|
2012-04-04T22:54:37
|
|
Increase Vertex Decl cache size to 32 entries.
This should reduce the risk of running out of cache entries inside a frame, while being small enough that iterating through it to find the correct entry shouldn't be too expensive.
BUG=310
TEST=
Review URL: https://codereview.appspot.com/5969077
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1018 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
807d8c33
|
2012-04-04T15:06:04
|
|
Fixed info log regressions.
TRAC #20443
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1017 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
978702d8
|
2012-04-04T15:05:58
|
|
Return a sequence when optimizing constant conditions so that brackets will be added to the HLSL output.
TRAC #20052
ISSUE=252
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1016 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
ff6a0a5c
|
2012-04-03T21:03:02
|
|
Fixed line number reporting. Each newline was being counted twice.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1015 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
3f990c4a
|
2012-04-03T19:50:35
|
|
Added lexer rules for operators.
Review URL: https://codereview.appspot.com/5966072
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1014 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
3b130253
|
2012-04-03T18:20:18
|
|
Make Image::lock and unlock private and call them from Image::loadData.
This is because I want loadData to be able to decide whether to use LockRect/UnlockRect or UpdateSurface as the method to load the data, depending on whether the Images are backed by textures in the default pool or not.
I think it actually cleans up the code a bit.
Also, fixed a bug in subImageCompressed. The associated WebGL conformance test now passes.
Review URL: https://codereview.appspot.com/5948043
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1013 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
4b2a522a
|
2012-04-03T17:19:42
|
|
Punted on bison parser. It was turning out to be more complicated than necessary. Manual parsing combined with a flex lexer is easier.
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1012 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
01fd431c
|
2012-03-30T21:33:30
|
|
More prep work for macro expansion. Off-loaded lexing from Context class to a new Lexer class.
Review URL: https://codereview.appspot.com/5059048
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1011 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
43affc5e
|
2012-03-28T14:55:39
|
|
Selection nodes are temporaries.
Issue=156
TRAC #16816
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1010 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
ed2180dc
|
2012-03-26T17:08:54
|
|
Fix comma operator precedence.
TRAC #20059
ISSUE=290
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1009 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
563c0a53
|
2012-03-23T21:18:42
|
|
Fence has pointer to the associated egl::Display.
I think the assumption that getDisplay() returns a valid display in the Fence destructor is wrong.
I'm trying to fix a crash in the field that looks like this:
Thread 0 *CRASHED* ( EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000000 )
0x69582e38 [libglesv2.dll - fence.cpp:27 gl::Fence::~Fence()
0x69582f29 [libglesv2.dll + 0x00022f29] gl::Fence::`scalar deleting destructor'(unsigned int)
0x6958077d [libglesv2.dll - context.cpp:1020 gl::Context::deleteFence(unsigned int)
0x69582b9b [libglesv2.dll - context.cpp:195 gl::Context::~Context()
0x69582dcb [libglesv2.dll + 0x00022dcb] gl::Context::`scalar deleting destructor'(unsigned int)
0x69582df2 [libglesv2.dll - context.cpp:4259 glDestroyContext
0x73166ab8 [libegl.dll - display.cpp:768 egl::Display::destroyContext(gl::Context *)
0x73168393 [libegl.dll - libegl.cpp:861 eglDestroyContext
0x6e18f1db [chrome.dll - gl_context_egl.cc:76 gfx::GLContextEGL::Destroy()
0x6e18f40d [chrome.dll - gl_context_egl.cc:43 gfx::GLContextEGL::~GLContextEGL()
Here's the disassembly:
69582E21 push esi
69582E22 mov esi,ecx
69582E24 cmp dword ptr [esi+4],0
69582E28 mov dword ptr [esi],695CBBE0h
69582E2E je 69582E3F
69582E30 call 695743F5 // this is getDisplay()
69582E35 push dword ptr [esi+4]
69582E38 mov edx,dword ptr [eax] // crashes here because EAX is zero
69582E3A mov ecx,eax
69582E3C call dword ptr [edx+24h] // this is freeEventQuery()
69582E3F pop esi
69582E40 ret
It looks like getDisplay() returns null.
http://code.google.com/p/chromium/issues/detail?id=117817
Review URL: https://codereview.appspot.com/5875044
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1008 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
73536984
|
2012-03-21T20:45:49
|
|
Fixed missing semicolon for do-while.
TRAC #20055
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1007 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
43eecdc1
|
2012-03-20T20:10:33
|
|
Avoid adding duplicate struct constructors.
TRAC #20057
ISSUE=285
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1006 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
5dd6d09f
|
2012-03-20T20:10:28
|
|
The function parameters and function body belong to the same scope.
TRAC #20056
ISSUE=256
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1005 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
ab8ca191
|
2012-03-20T20:10:24
|
|
Define constructors for structures defined in argument lists.
TRAC #20056
ISSUE=256
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1004 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
eec8efc3
|
2012-03-09T21:57:49
|
|
Detect when declaring previously undeclared variables as invariant, and avoid using an uninitialized type.
TRAC #20042
ISSUE=241
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1002 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
83dc5a78
|
2012-03-09T21:57:07
|
|
Start a new scope for conditional statements even when there are no curly brackets. Also fix the DO WHILE grammar.
TRAC #20052
ISSUE=252,255
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1001 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
05bc204e
|
2012-03-09T21:56:58
|
|
Regenerate the parser using Bison 2.4.2.
TRAC #20052
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@1000 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
2a073de7
|
2012-03-09T21:56:43
|
|
Limit HLSL loop scope to match that of GLSL.
TRAC #19197
ISSUE=260
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@999 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
0f328a7a
|
2012-03-05T15:07:50
|
|
Revert "Fixed test for 16-bit index range".
TRAC #19988
Issue=304
Signed-off-by: Daniel Koch
git-svn-id: https://angleproject.googlecode.com/svn/trunk@998 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
4e13a77e
|
2012-03-02T23:44:57
|
|
Make essl_to_glsl target windows only.
This is a quick fix for gclient runhooks error on Mac/Linux.
BUG=
TEST=gclient runhooks --force on Mac/Linux
Review URL: https://codereview.appspot.com/5732047
git-svn-id: https://angleproject.googlecode.com/svn/trunk@997 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
35342dc4
|
2012-02-28T02:01:22
|
|
Provide multi-dimensional atan intrinsics.
TRAC #19989
Issue=302
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@996 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
1e04e46b
|
2012-02-28T02:01:17
|
|
Fixed test for 16-bit index range.
TRAC #19988
Issue=304
Signed-off-by: Daniel Koch
git-svn-id: https://angleproject.googlecode.com/svn/trunk@995 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
51b2685b
|
2012-02-21T23:53:23
|
|
Don't use strlen inside of loop
This could hurt performance quite a bit.
BUG=296
TEST=
Review URL: https://codereview.appspot.com/5675086
git-svn-id: https://angleproject.googlecode.com/svn/trunk@993 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
0725e7df
|
2012-02-17T18:02:20
|
|
Support reloading the shader compiler
Trac #19900
Issue=291
- Move compiler initialization to a separate function
- all this function to ensure the compiler is loaded when a compile is attempted
(previously if the compiler was released, you'd have to create a new shader object
to get it reloaded).
Signed-off-by: Shannon Woods
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@992 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
938009cf
|
2012-02-17T18:02:15
|
|
Add ability to recompile shader source
Trac# 19900
Issue=291
- add an 'uncompile' function to clear all results from any previous compile attempts
- allow compiling to be done multiple times on the same shader
- allow a shader to be compiled with no source specified (to produce an appropriate error).
Signed-off-by: Shannon Woods
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@991 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
cde6a610
|
2012-02-17T18:01:10
|
|
Rename the Shader 'varyings' member to 'mVaryings' to follow coding standard
Trac #19900
Issue=291
Signed-off-by: Shannon Woods
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@990 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
2cdf833c
|
2012-02-17T18:00:50
|
|
Provide better encapsulation for Shader member variables
Trac 19900
Issue=291
Moved a bunch of member variables from 'protected' to 'private'
Signed-off-by: Shannon Woods
Signed-off-by: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@989 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
b474de34
|
2012-02-08T18:55:41
|
|
Move translator_hlsl target into Windows specific section of build_angle.gyp.
Review URL: https://codereview.appspot.com/5639055
git-svn-id: https://angleproject.googlecode.com/svn/trunk@985 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
90f1eb81
|
2012-02-08T02:00:33
|
|
Remove 'chromium_code' from build_angle.gyp.
This is because the ninja build system, unlike make, builds translator_hlsl and fails on the clang warnings.
Review URL: https://codereview.appspot.com/5647048
git-svn-id: https://angleproject.googlecode.com/svn/trunk@984 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
cca2b70b
|
2012-02-08T00:59:46
|
|
Create D3D device when eglInitialize is called.
This is because some GPUs / drivers are unable to create the device once the Chromium GPU process sandbox has been locked down and waiting for the first context / surface to be created is too late.
Review URL: https://codereview.appspot.com/5647046
git-svn-id: https://angleproject.googlecode.com/svn/trunk@983 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
6c762d08
|
2012-02-03T23:31:53
|
|
Disable getting share handles when PIX is enabled.
PIX doesn't seem to work with share handles, so disable them when we detect that pix is enabled.
BUG=
TEST=
Review URL: https://codereview.appspot.com/5625048
git-svn-id: https://angleproject.googlecode.com/svn/trunk@982 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
cb37afdb
|
2012-02-01T18:10:40
|
|
The normalized argument of vertexAttribPointer should not affect float and fixed.
Issue=155
Signed-off-by: Nicolas Capens
Author: Pierre Leveille
git-svn-id: https://angleproject.googlecode.com/svn/trunk@981 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
9c3a393d
|
2012-01-30T20:03:32
|
|
Enabled MSVC warning 4389 : signed/unsigned mismatch.
I also fixed Config.cpp so it compiles without the warning.
This is because this is now a warning as error in Chromium.
Review URL: https://codereview.appspot.com/5600047
git-svn-id: https://angleproject.googlecode.com/svn/trunk@980 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
26f6e5d8
|
2012-01-27T22:57:16
|
|
Added missing printf format type.
%z was actually just a modifier.
Review URL: https://codereview.appspot.com/5569082
git-svn-id: https://angleproject.googlecode.com/svn/trunk@979 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
e4319635
|
2012-01-27T22:13:17
|
|
Fix printf format specifier in PoolAlloc.cpp.
%Iu is used for size_t printf arguments in MSVC. The GCC equivalent is %z. MSVC does not support %z though.
Review URL: https://codereview.appspot.com/5578050
git-svn-id: https://angleproject.googlecode.com/svn/trunk@977 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
c6f7f9d5
|
2012-01-27T15:40:00
|
|
Centralize detection of instancing support.
TRAC #19489
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@976 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
dce02fda
|
2012-01-27T15:39:51
|
|
Expose the ANGLE_instanced_arrays extension.
TRAC #19489
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@975 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
d644931c
|
2012-01-27T15:39:32
|
|
Work around a bug observed with ATI graphics cards where instanced draw calls fail when all attributes are non-instanced, by repeating the draw call.
TRAC #19489
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@974 736b8ea6-26fd-11df-bfd4-992fa37f6226
|
|
|
6c4b5e00
|
2012-01-27T15:39:12
|
|
Re-implement line loops by constructing a 'looping' index buffer, so it is compatible with instanced draws.
TRAC #19489
Signed-off-by: Daniel Koch
Author: Nicolas Capens
git-svn-id: https://angleproject.googlecode.com/svn/trunk@973 736b8ea6-26fd-11df-bfd4-992fa37f6226
|