kc3-lang/angle

Log

Author Commit Date CI Message
Cody Northrop 775caee1 2021-03-24T08:42:54 Scripts: Ignore robin_hood headers in VVL Needed to unblock vulkan-deps roll. Example bad roll: https://chromium-review.googlesource.com/c/angle/angle/+/2784701 Fallout from upstream changes: https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/2639 TBR: jmadill@google.com Bug: angleproject:5791 Change-Id: Idf4a0f6b4a7ef04e48d84110cd9d30887ebff9cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2784712 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 0c9f22d3 2021-03-24T07:01:56 Roll Chromium from f1617b736428 to bda1e3894abc (469 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f1617b736428..bda1e3894abc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b43166a3d1..cb055e229d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/4e078437d0..731dd85349 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a9cb74b2b5..ada28b558f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..25699ba498 * tools/luci-go: git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2 * tools/luci-go: git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2 * tools/luci-go: git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c94714a14b..772ad67f2e * tools/skia_goldctl/linux: PgXVrZeDk45E9Zzaj8KYvPhJb728_zgB29afUe44XnUC..siMs1o8b-ON1wWPwvSA4NKhGMBXPWhkMQ3HHr7-yDqQC * tools/skia_goldctl/mac: rhgkxpA8BkPWwXXCTUidbcE5xtFpN2UVjTfya2r4YJAC..77UQ9Zx-irz8MxBwN3CtYielGQtPthCIaWzlOONC8_MC * tools/skia_goldctl/win: bMHjBq4De--lL7_Tr4K31mN6LR7hkSStHG_W34ogifYC..rLRz9NhcZkVWiGMr_kp9C1L_1QOynKyxdh-eu6REt4MC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: If48fd51ba96e71909d3be086667bfc73fdd32a0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2782377 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amy Liu 1fb7f648 2021-03-18T16:17:25 Compression of the data from vkGetPipelineCacheData. The size of pipelineCacheData sometimes is greater than 64k which cannot be saved because of the Android blob cache limitation (single cache data size should be < 64k). Implement the compression to store more cache data. Re-land this patch before fixing the performance regression of big pipeline cache. Bug: angleproject:4722 Change-Id: I4bc05a88334c3e7e9e945d1a0877429db1750422 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2771840 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Xiaoxuan Liu 9f796506 2021-03-23T10:58:12 Vulkan: Fix gl_SamplePosition XY-flip and rotation. In multi sample scenario, gl_SamplePosition is not handled with XY-flip and rotation, add codes for flip and rotation. Bug: angleproject:5637 Test: dEQP-GLES31.functional.shaders.multisample_interpolation. interpolate_at_offset.at_sample_position.default_framebuffer --deqp-gl-config-name=rgba8888d24s8ms4 Test: dEQP-GLES31.functional.shaders.sample_variables.sample_pos. correctness.default_framebuffer --deqp-gl-config-name=rgba8888d24s8ms4 Change-Id: I7ba2227e85c62d2ca7bf534a841a1c3a5c9beb5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2781124 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
David Reveman 3fd439c2 2021-03-23T21:40:11 [Fuchsia] Add ifndefs to vulkan_fuchsia_ext.h This allows chromium to build with upstream headers that include these extension. The old TEMP enums and structure types are used until drivers have been updated to support upstream header values. Bug: chromium:1191605 Change-Id: I25d2991204ca34956298013138af8f48e0aaefaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2782765 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d1462228 2021-03-09T11:25:36 Vulkan: Use VK_EXT_multisampled_render_to_single_sampled Additionally, makes the emulation path not require independentResolveNone. This was only used to select the NONE resolve mode when the attachment format doesn't have either of depth or stencil aspects, but it's ok to specify the same resolve mode for both aspects even if one aspect is missing. Bug: chromium:1088005 Change-Id: Ifc37cbf5331145179c5927853b996a0d62b871ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743666 Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott c4da42e1 2021-03-22T12:29:34 Update ANGLEWrangling.md with Hotlist-Wrangler Bug: angleproject:5782 Change-Id: I6f808e6ece97dbc0166ba8f60b0cc31e783165a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779393 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Rafael Cintron d809147f 2021-03-22T18:00:00 Enable D3D11 debug names in ANGLE release builds Previously, D3D11 debug names were only output in debug builds. This change enables them in release builds so we can debug GPU memory consumption given traces or full memory dumps. Where it made sense, existing names were shortened for brevity. A future CL can shorten the names further by removing the words texture, SRV, DSV, etc since D3D already outputs this type information. Bug: chromium:1164111 Change-Id: Iadd6222c29dd945115e844ec28ee395ce16c139f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780564 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Peng Huang 90e3d86c 2021-03-22T12:49:26 Disable timestamp queries for Mali-G31 and older GPUs Bug: chromium:1178333 Change-Id: I8f21cd1c8f815a5cd7344778d2d1b28710dc6763 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779211 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Jamie Madill 2a43f43a 2021-03-23T15:35:30 Revert "Save/Load missing members" This reverts commit b2e76cf58fc012b068aab4716a432bb8951e93e3. Reason for revert: Causing MSan failures on Linux. See bug. Bug: chromium:1191344 Original change's description: > Save/Load missing members > > There are several class/struct members that are missing when a program > is serialized/deserialized. This leads to errors when attempting to link > programs that have been deserialized. For example, when drawing with a > PPO that contains programs which were created with glProgramBinary(). > > This CL adds saving/loading the missing members. > > Bug: b/182409935 > Change-Id: I637c6cd8c174acd6da8d51433893323a32e5d7c0 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770683 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: b/182409935 Change-Id: I1209257ed6bb55ba2d01d92bd3305d5e3ad6ee28 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780015 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 572fd801 2021-03-22T16:14:34 Vulkan: Rename Uniforms/XFB descriptor desc. The new name is more consistent with the other names. Refactoring change only. Bug: angleproject:5736 Change-Id: Idc47fef29040e3a422267795c4536163a6f8eb4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779953 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll e6ca472b 2021-03-23T07:01:03 Roll Chromium from 3eced2421f5a to f1617b736428 (473 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3eced2421f5a..f1617b736428 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/120a8d610c..b43166a3d1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f13f2e366c..a9cb74b2b5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..de74236cf7 * tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e * tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e * tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e * tools/skia_goldctl/linux: PFAC9ipfkYe6ZljRb8758leyPy7Jw6Dhl2dtHp0IsMYC..PgXVrZeDk45E9Zzaj8KYvPhJb728_zgB29afUe44XnUC * tools/skia_goldctl/mac: Ht0L_bool7JJxm1K8Y4MzgKRlPhoIYiVaHruwzqROMEC..rhgkxpA8BkPWwXXCTUidbcE5xtFpN2UVjTfya2r4YJAC * tools/skia_goldctl/win: 3Z3zEAwtATXaw6OCunrkLRtBDiMoKW34b_yeMZ82eocC..bMHjBq4De--lL7_Tr4K31mN6LR7hkSStHG_W34ogifYC No update to Clang. Bug: angleproject:5768 Tbr: cnorthrop@google.com Change-Id: I82f74de7812ba075f6c3cd9fa0b4d724df876669 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779806 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 48560f67 2021-03-19T16:56:44 Tests: Add Real Cricket 20 trace Test: angle_perftests --gtest_filter="*real_cricket_20*" Bug: b/183165790 Bug: angleproject:5777 Change-Id: I1f350e3ea458a599396412e2c5ca80d6c7887d73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776554 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Ian Elliott c4b1f366 2021-03-22T17:56:54 Fix copyright dates of new test files per Shabi Bug: b/181711029 Change-Id: Ie619ba90f699dd8234cf185198cb6eeac9142758 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780560 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Charlie Lao ef17c650 2021-03-08T18:50:53 Vulkan: Add test for filament gltf usage case filament gltf sample code is rendering to a level that is excluded from [base_level, max_level]. This is allowed by OpenGL spec. We are crashing right not. This CL adds tests for the exact usage pattern for filament. Bug: b/181800403 Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBeyondMaxLevel Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithSubImageWithBeyondMaxLevel Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBellowBaseLevelLOD Change-Id: I69bab8bc3961bbc2dcc78ba2db3c8759f277416b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752897 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Tim Van Patten b2e76cf5 2021-03-17T17:43:03 Save/Load missing members There are several class/struct members that are missing when a program is serialized/deserialized. This leads to errors when attempting to link programs that have been deserialized. For example, when drawing with a PPO that contains programs which were created with glProgramBinary(). This CL adds saving/loading the missing members. Bug: b/182409935 Change-Id: I637c6cd8c174acd6da8d51433893323a32e5d7c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770683 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 4386840c 2021-03-19T16:54:41 Tests: Add android log library to traces This is required in order to call __android_log_print, which can be sprinkled into the trace for debugging. Bug: b/183165790 Change-Id: I717f2ac7809172f22b7badee6f1096394a02bc14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776553 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tim Van Patten 34e28778 2021-03-17T17:38:19 Reorder ShaderVariable functions and members ShaderVariable's functions and members are all mixed up. This CL reorders things to move the functions before the members, to better match ANGLE's coding style. This also adds a note that any new members that are added need to be added to gl::WriteShaderVar() and gl::LoadShaderVar(), which are actually implemented in Program.cpp, since ShaderVars.h/cpp can't include libANGLE/BinaryStream.h. There are currently several members that are missing, leading to save/load errors, which are fixed in a follow-on CL in this chain. Bug: b/182409935 Change-Id: I1381a5efffb56c0989961bbcfd405b95d59d6396 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770682 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mohan Maiya 2be71410 2021-03-19T14:07:02 Handle inactive structure type varyings correctly Correctly handle inactive varyings of structure type when collecting transform feedback varyings. Previously, all varyings of structure type were marked as active by mistake. Bug: angleproject:5557 Test: TransformFeedbackTest.InactiveStructureVarying* Change-Id: Ica1cbce5c551cdbb97999eeac59d09a961937615 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770680 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 570970f9 2021-03-19T13:43:35 Vulkan: Handle compilation error involving gl_InvocationID We need to generate a compiler error only when the vertex index of an output variable as an l-value, in a tessellation control shader, is not the indentifier gl_InvocationID. Bug: angleproject:5557 Tests: dEQP-GLES31.functional.tessellation.shader_input_output.barrier Change-Id: Ica075b8d85916caa228f057b203ae81b27f65e2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2758915 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Charlie Lao 81432c24 2021-03-19T14:03:02 Vulkan: Rename onImageHelperRelease to finalizeImageLayout Make the API name reflect what it does. With recent changes, this get called from places that are not releasing ImageHelper object, but is try to reference the current layout. This new name makes more sense than onImageHelperRelease (at that time when this API was introduced, it was only called when ImageHelper is being released). Bug: b/175584609 Change-Id: Ie5f5fcdbd97436724d7eb016374d8b4178e7ba1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776261 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 02acc5ee 2021-03-18T16:08:59 Vulkan: More cleanups to perf counters. This refactors the pipeline type in the ContextVk class to also use a packed enum map. It also expands the object perf counters to store both a specific and cumulative version for use in different cases. Bug: angleproject:5736 Change-Id: I6ff78e38065eb577f2b95b1d9c4f9cc31d7f325f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774184 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop ecbd870f 2021-03-21T22:54:24 Tests: Add Avakin Life - 3D Virtual World trace Test: angle_perftest --gtest_filter="*avakin_life*" TBR: jmadill@google.com,timvp@google.com Bug: b/183344915 Bug: angleproject:5779 Change-Id: Iaf2d8341055d5b7c6f3c8a7a7a1fb3d1399fabc5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776746 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cheryl Wei 0380f115 2021-03-18T09:56:14 Skip ResizeWindow test on Linux. ARM Linux doesn't support window surface resize. Bug: angleproject:4453 Change-Id: Ia8631f5191c2b3ebd822766cc7f92275aa62dff3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2777578 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 7fe44a53 2021-03-20T09:39:09 Vulkan: Don't acquire new BufferHelper for external buffers EXT_external_buffer spec - This extension allows the data store for an immutable buffer to be sourced from an external EGLClientBuffer, allowing sharing of EGL client buffers across APIs, across processes, and across different processing cores such as the GPU, CPU, and DSP. The intent is for a single backing memory to be reused across various processes and processors. Ensure that a glBuffer backed by external memory does not orphan the memory when glBuffer APIs like glBufferSubData or glMapBufferRangeEXT modify the glBuffer. Bug: angleproject:4380 Bug: angleproject:5073 Tests: ExternalBufferTestES31.*DoesNotCauseOrphaning*Vulkan Change-Id: I4e88f80d93ee1ba1208378121412926351d10af8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776192 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 7e9b497c 2021-03-22T08:19:11 Roll Chromium from c33e21cce932 to 3eced2421f5a (477 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c33e21cce932..3eced2421f5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ba8be7fd2f..120a8d610c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/55b74c093b..f13f2e366c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..999f35f30e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9629038820..24cecabb89 * tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb * tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb * tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df4e23350e..c94714a14b * tools/skia_goldctl/linux: GNchtrcB6qbKJwI4p-GTx1VGkCUsAWxKyn2kIXkyMZcC..PFAC9ipfkYe6ZljRb8758leyPy7Jw6Dhl2dtHp0IsMYC * tools/skia_goldctl/mac: 0r4l0jSQ08UrxS6-MUtgrn6DegnbVTPg-1I_HWxO3JsC..Ht0L_bool7JJxm1K8Y4MzgKRlPhoIYiVaHruwzqROMEC * tools/skia_goldctl/win: _LtAsLqSVwpOUShHDIbQWgtPXUO4xbpf1MDMcloIAdQC..3Z3zEAwtATXaw6OCunrkLRtBDiMoKW34b_yeMZ82eocC No update to Clang. Bug: None Tbr: timvp@google.com Change-Id: Ia49b1a9a909ceea201b65fd2f8d823e967a90ffa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776747 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott 90cf278c 2021-03-19T16:17:43 Add multi-thread/context test for compute shaders The "Ragnarok M: Eternal Love" game uncovered a bug where 2 contexts shared a VkCommandBuffer. The one context was used by one thread for rendering, and the other context/thread dispatched compute shaders. When the rendering thread destroyed a VkCommandBuffer, future compute dispatches crashed because the new VkCommandBuffer didn't have a compute pipeline bound. Bug: b/181711029 Change-Id: I8bc85150c1c6202e02feb84a7ccc0ad7b9c39258 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770681 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Nicolas Capens 135385a1 2021-03-19T00:09:31 Disable EGL_EXT_buffer_age for SwiftShader Vulkan Cuttlefish with SwANGLE failed to pass the android.graphics.cts. BitmapTest#testDrawingHardwareBitmapNotLeaking test, due to a timeout in dequeueBuffer (error = -110) during an EGL_BUFFER_AGE_EXT surface query. This change conservatively works around the issue by leaving EGL_EXT_buffer_age support disabled for SwiftShader. Further investigation is required to check whether this timeout can also occur with other Vulkan drivers, and if it can be addressed robustly. Bug: b/182521420 Bug: angleproject:3529 Change-Id: I54e3767e74bf922f273d8860f9f4cfc8b6589536 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774030 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Charlie Lao d5bc8a27 2021-03-17T18:21:35 Vulkan: Add VUID-vkCmdDraw-None-04584 validation error to ignore list Aztec ruins is using the same texture (but different level controlled by a uniform variable) for textureLod and rendering. This triggers vulkan validation error. This CL put it in the ignore list so that it can pass. Bug: b/175584609 Change-Id: I7623e7b448514b3c12268aa5fe154f4c2f59b059 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770686 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Charlie Lao 867411a4 2021-03-08T19:08:14 Vulkan: Track images used for both attachment and sampler This CL adds a new layout ImageLayout::ColorAttachmentAndShaderRead. We detect that the same ImageHelper object is used for both sampler and attachment and will pick this new layout instead of ColorAttachment. Bug: b/175584609 Change-Id: I2089f59d4dc1ad4de7edab0e067797adcfa9b020 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749479 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 5163cd0c 2021-03-18T18:17:11 Add isYUV to angle::Format In preparation for adding support for more YUV formats add an 'isYUV' field that tracks whether a format is a YUV format. For now it is set if the format string contains the substring 'PLANE'. This is not the case for all known YUV formats but the condition can be expanded when required. Bug: angleproject:5773 Change-Id: Icb574037dc8105584931835dab0b60e8bafa3262 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774762 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Charlie Lao da437f26 2021-03-08T19:08:14 Vulkan: Defer color image layout changes at endRenderPass time Right now color render target's image's layout change are done at beginRenderPass time. The problem is that the layout also depends on whether texture is also being used as a sampler or not. That information is not known when renderpass starts. We did some special treatment for depth stencil attachment so that its layout determination is deferred until endRenderPass time. This CL expands that same mechanism to color attachment as well. Right now the color attachment will still pick the same ImageLayout::ColorAttachment layout since the logic to detect it is also used for texture sampling is not there yet. Bug: b/175584609 Change-Id: Id7486174d475f894461578b31d0d40fdd90e808a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2744121 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Geoff Lang 0a80f2e1 2021-03-15T16:56:08 D3D: Mark images dirty after recovering from storage When images are recovered from storage due to resizing storage, they were marked as clean and not always re-copied to the new storage. Bug: angleproject:5757 Bug: chromium:1188854 Change-Id: Idd11025820433ab74ff769cd9508efcec4575c32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2763282 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 5067fccf 2021-03-19T10:02:33 Roll vulkan-deps from 6ea3512e6349 to 91a2a0b15f23 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6ea3512e6349..91a2a0b15f23 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/d18bcd64fa..979319b9b1 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4f498774db..a732e4c03c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d5bf0be344..309d9bea09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ifb1845a82a8ae3c3cd19e7023bb20048a6486ff3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774761 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 15a1e735 2021-03-19T07:00:28 Roll Chromium from e7ef5f7d0368 to c33e21cce932 (451 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e7ef5f7d0368..c33e21cce932 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/17a38f4bb2..ba8be7fd2f * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c93be42a40..4e078437d0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3b69bfd940..55b74c093b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8e820e32d0..74cb518d98 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c730daef75 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/168ccba7af..9629038820 * tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6 * tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6 * tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c98db359fc..df4e23350e * tools/skia_goldctl/linux: NQmBkXHpEXJthTy0c6iuXDk1UgYDyQ7Fm649E7P38bAC..GNchtrcB6qbKJwI4p-GTx1VGkCUsAWxKyn2kIXkyMZcC * tools/skia_goldctl/mac: Rbel_7KQuxv_-SIkB3oT43MBYgKlr3AUwFystGNHKJ8C..0r4l0jSQ08UrxS6-MUtgrn6DegnbVTPg-1I_HWxO3JsC * tools/skia_goldctl/win: 3sDKbIeT1dc4BYnE_uMfW71xbKa-b75KWLUwVEIJF-QC.._LtAsLqSVwpOUShHDIbQWgtPXUO4xbpf1MDMcloIAdQC No update to Clang. Bug: None Tbr: timvp@google.com Change-Id: I36906d996c7474ebf61c329ad7622f32c00ec960 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774452 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 9b3b5733 2021-03-17T15:38:42 Tests: Add Ragnarok M: Eternal Love trace Test: angle_perftests --gtest_filter="*ragnarok_m_eternal_love*" TBR: timvp@google.com,jmadill@google.com Bug: b/181800519 Bug: angleproject:5772 Change-Id: I1dcde486e909f7c2b5d59132e5f673c7e8ab1d01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774264 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Qin Jiajia ba0bd785 2021-03-15T16:00:33 Fix the assert error and inbalence parens for SSBO This PR strengthens below two cases: 1. Support calculate unsized array size for any type. Previously, it reported error when the type was a structure. 2. Correctly add the right paren for store function when any load/length functions are nested in it. Bug: angleproject:5734 Change-Id: I3428fa35f1481275e1d193094ceddb011f747cf1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762655 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Jamie Madill b717952e 2021-03-18T10:39:34 Vulkan: Use packed enum map for descriptor set index. This simplifies a lot of the data structure indexing in the program executable class. Also renames the "DriverUniforms" and "InternalShader" index into a single "Internal" index. Bug: angleproject:5736 Change-Id: I2a51d8b14d5b16b438dbe636f77b11bbc045ba9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773321 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 1b08cfcb 2021-03-18T10:01:54 Vulkan: Clean up shader buffer DS allocation. We were using repeated code patterns in several places. Bug: angleproject:5736 Change-Id: I206783dd792c3b0f9d38027235445ec600a60d88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773320 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Charlie Lao 378b3261 2021-03-08T18:50:53 Vulkan: Move CommandBufferHelper::reset() closer to constructor This is a mechanical change. Similar to constructor, the reset() function is doing initialization of data members. Move them next to each other helps adding a new data members which requires modifications to both functions. Bug: b/175584609 Change-Id: I11386677bc5c9838104025d6a4ecf6f2b58fa92c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745842 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 1f1b4ffe 2021-03-08T11:44:28 Vulkan: Test render and sample the same texture but with different LOD This simulates aztec ruin's usage. This works properly on native OpenGL but generates validation error on vulkan backend and renders incorrect as well. Bug: b/175584609 Test: FramebufferTest_ES3.SampleFromAttachedTextureWithDifferentLOD Change-Id: I402c205a1b625669cae29ee201dddd144e0dfbde Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743797 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Gert Wollny f201c9d2 2021-03-17T13:48:16 scripts: Ignore "rapidsjon/..." when checking includes These include stubs are given in the comments within rapidjson.h and are preported as error by the presubmission check. Bug: angleproject:5765 Change-Id: Ic200a860de7337aefcd3bb0f82686d62a1349d89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2765648 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll 57d8b3e1 2021-03-18T07:01:20 Roll Chromium from 60fea25f23e6 to e7ef5f7d0368 (472 revisions) https://chromium.googlesource.com/chromium/src.git/+log/60fea25f23e6..e7ef5f7d0368 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/37b76d6fba..17a38f4bb2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2408fca90b..3b69bfd940 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c730daef75 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/752611e5f2..168ccba7af * tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d * tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d * tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/67f01522b1..c98db359fc * tools/skia_goldctl/linux: 3T-SUsozYAVsudk5nd48kjHvfpos6egORLB8s7ElE8oC..NQmBkXHpEXJthTy0c6iuXDk1UgYDyQ7Fm649E7P38bAC * tools/skia_goldctl/mac: TPtcrf_XH3mB9pdK4W3N0QPZunsqJ08T7U7fWPvMnRAC..Rbel_7KQuxv_-SIkB3oT43MBYgKlr3AUwFystGNHKJ8C * tools/skia_goldctl/win: wr5p_MyXcHVxA-eHznijCeFaqR2HUo02Hw70e0CWCIoC..3sDKbIeT1dc4BYnE_uMfW71xbKa-b75KWLUwVEIJF-QC No update to Clang. Bug: angleproject:2424,angleproject:2880,angleproject:2994,angleproject:3033,angleproject:3753,angleproject:4377,angleproject:5014 Tbr: timvp@google.com Change-Id: Ib964474c19e613fedb9ab3ac0d474fc1829289ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770687 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 39296f39 2021-03-18T00:47:34 Roll vulkan-deps from 105af117f053 to 6ea3512e6349 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/105af117f053..6ea3512e6349 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b2e5b5c559..d18bcd64fa * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/faa570afbc..bcf55210f1 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/478754c005..4f498774db * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/053e2bf22d..d5bf0be344 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I190a577538fb3a2178c1e82f1c9fc4e52749a322 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770144 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
James Darpinian bb7c1442 2021-03-17T10:17:31 Fix immutable texture base level validation Jeff's new rendering feedback loop test (https://github.com/KhronosGroup/WebGL/pull/3221) found a couple of issues with texture base level validation. For immutable textures the base level is clamped to the valid range, so setting an out of range base level does not make an immutable texture sampler incomplete, and we need to use the clamped value when checking for rendering feedback loops. Bug: angleproject:5768 Change-Id: Ie065709efd736f2cf75d4f980e8ac27999f80142 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2767901 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cody Northrop f6eccc20 2021-03-12T09:17:27 Tests: Add June's Journey trace Test: angle_perftests --gtest_filter="*junes_journey*" TBR: jmadill@google.com,timvp@google.com Bug: b/182566407 Bug: angleproject:5752 Change-Id: I083507949c9bc16bf701028a678540df9a3531dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2755840 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 716b2cba 2021-03-12T14:46:53 Use bitset masks for active shader buffers. This switches the tracking for the uniform, shader storage, and atomic counter buffers to use bitset masks to determine where there are active buffers. This will make iterating these buffer sets faster. Also renames the limit for atomic counter buffers to be consistent with the other buffer types. Also applies the implementation limit to atomic counter buffer bindings. This fixes out-of-bounds access on some Linux platforms that expose a large number of bindings. Bug: angleproject:5736 Change-Id: Ice801645697592d1dda6aebf0cb69767594cc0c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757509 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Mohan Maiya 81dcf078 2021-03-08T11:21:31 Reland "Vulkan: Support EXT_sRGB_write_control" This is a reland of 6073af536cf627742696823edc82c9b0a481a8bc with 2 changes - 1. Don't enable the extension even in nonConformant mode 2. Don't enable VK_KHR_image_format_list for swiftshader Original change's description: > Vulkan: Support EXT_sRGB_write_control > > Implement support for EXT_sRGB_write_control. This extension > requires VK_KHR_image_format_list to be supported. > > The spec requires this functionality to work with glBlitFramebuffer > as well but support for that will be added in a follow up change. > As such, this extension is only exposed in non-conformant mode. > > Bug: angleproject:5075 > Tests: SRGBFramebufferTest.*Vulkan* > Change-Id: I59b38f6cd810a3d0d67ec29f4f19c25f65f70862 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617243 > Commit-Queue: Mohan Maiya <m.maiya@samsung.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:5075 Change-Id: I8e149d196a39c3c4769bfa8690792f3c53831299 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762647 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Shahbaz Youssefi 629f66ce 2021-03-16T00:34:16 Vulkan: Fix missing dirty bits for compute In the following scenario: - Dispatch - Flush outside render pass commands - Dispatch The second dispatch doesn't rebind the pipeline because it assumes it's recording to the same primary command buffer. This assumption is broken if another thread causes a submission before the second dispatch. It's also broken if using Vulkan secondary command buffers. Bug: b/181711029 Change-Id: I5335be95208f41724cf8e9c60ae5322ad91840fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2763143 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 3eace05c 2021-03-17T10:01:28 Roll SwiftShader from 69b79eec6533 to a98fb3f8380a (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/69b79eec6533..a98fb3f8380a 2021-03-17 swiftshader.regress@gmail.com Regres: Update test lists @ a0aeb64e 2021-03-16 capn@google.com Fix multiview renderpass queries If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I51bac967310d157a97f02dae659afd156973e565 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2766413 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Xiaoxuan Liu 9a839732 2021-03-03T17:56:07 Reland "Add support for Linux GPU info with Vulkan backend" This is a reland of 5c09c1f882f15e1a77577f1a62d861355aac90a4 Extra change: Add new ANGLE_HAS_VULKAN_SYSTEM_INFO compile variable for GetSystemInfoVulkan() in linux platform. Original change's description: > Add support for Linux GPU info with Vulkan backend > > 1. Add support for Linux GPU info with vulkan backend: for > dev board without PCI support, try vulkan backend to get > GPU info. > 2. Fix getVulkanInstance() issue when loading non-exist lib: > return NULL instance if open lib failed. > > Bug: angleproject:5717 > Change-Id: I03c11da25a8787496d098f6c9d6b4c53701383e4 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734375 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5717 Change-Id: Iaaab8f512b6ec1d524d7ebb3b4252fec3cfe7dc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739097 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll b3394db3 2021-03-17T07:56:11 Roll Chromium from cffad6044951 to 60fea25f23e6 (481 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cffad6044951..60fea25f23e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/03e56ea015..37b76d6fba * testing: https://chromium.googlesource.com/chromium/src/testing/+log/962db0501f..2408fca90b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..629e117d9b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/91db20bec2..752611e5f2 * tools/luci-go: git_revision:fd10124659e991321df2f8a5d3749687b54ceb0a..git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e * tools/luci-go: git_revision:fd10124659e991321df2f8a5d3749687b54ceb0a..git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e * tools/luci-go: git_revision:fd10124659e991321df2f8a5d3749687b54ceb0a..git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e2946cfb97..67f01522b1 * tools/skia_goldctl/linux: jstGnw4Pyb9uiuH75QNEy3f6hJN7ET2TFiOVOUiMokcC..3T-SUsozYAVsudk5nd48kjHvfpos6egORLB8s7ElE8oC * tools/skia_goldctl/mac: F9PFp7kNc3dn_X7b1PYmPsEb3VMHDY-8pXiZ7WNi09MC..TPtcrf_XH3mB9pdK4W3N0QPZunsqJ08T7U7fWPvMnRAC * tools/skia_goldctl/win: 5QaZrGtCcd9HFM-qeg4vP-CrEpvhqlZtkfwAtVBee2oC..wr5p_MyXcHVxA-eHznijCeFaqR2HUo02Hw70e0CWCIoC No update to Clang. Bug: None Tbr: timvp@google.com Change-Id: I40046beb257703d83285249e3bd82d76e990b491 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2766582 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 27e12398 2021-03-12T18:08:48 Remove usages of obsolete Mac bots Bug: angleproject:4483 Change-Id: I9d4d94d42ddab26b40e780ad04479ac470af7a52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757517 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
John Plate 65586746 2021-03-10T19:02:12 add cl entry points loader Bug: angleproject:5743 Change-Id: I61791f412e8dbc54878cd3791519ad1c4ee33399 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749595 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
Tim Van Patten 522d609b 2021-03-16T11:30:32 Fix download_restricted_traces.py :: run_command() run_command() was using the undefined variable 'cmd', rather than the pass in parameter 'command'. Bug: angleproject:5210 Change-Id: I5e80869b18b717835217ad14a562bb4d223d52c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2765005 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Peng Huang c99e405c 2021-03-12T12:39:27 Disable timestamp queries for some GPUs on Android Copy some workaround from chromium. Bug: chromium:702980,chromium:477514,chromium:462553,chromium:1178333 Change-Id: I9acb6ef49c91193a9e6bb03c6fc5eabf336cba9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756728 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 79e39478 2021-03-16T10:01:28 Roll SwiftShader from 5cdf55ff2084 to 69b79eec6533 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/5cdf55ff2084..69b79eec6533 2021-03-15 adelva@google.com Disable named mmap usage for host/ndk Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ibdc669fee9d1bc6651d4afb234acbeda062c8ec2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762686 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a56d794f 2021-03-16T10:01:33 Roll vulkan-deps from d70f9e670332 to 105af117f053 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d70f9e670332..105af117f053 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a36d91e5ac..b2e5b5c559 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d1cd265394..27c2124822 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f648a59e1c..053e2bf22d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I59823bbe7db496bc83f54ce6c3dfc939f3b49e18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2763789 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6936ee80 2021-03-16T07:30:55 Roll Chromium from 1572b5ac9572 to cffad6044951 (442 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1572b5ac9572..cffad6044951 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5f2e66e38e..03e56ea015 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c6aca9251c..962db0501f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8efb1d91dd * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cfcc45286b..e2946cfb97 * tools/skia_goldctl/mac: VUCuq1sveo1hxWfABmHwe-nXmh0OuWy4y9PhS3ykvykC..F9PFp7kNc3dn_X7b1PYmPsEb3VMHDY-8pXiZ7WNi09MC * tools/skia_goldctl/win: j4rOmbVNLoVaUWWPvzH9y8NIrbGae5OxIInpCD89q0QC..5QaZrGtCcd9HFM-qeg4vP-CrEpvhqlZtkfwAtVBee2oC No update to Clang. Bug: None Tbr: timvp@google.com Change-Id: Ia5b632c384b8eaf2cca10e846d932c8a4e8858b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2763787 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 687d3153 2021-03-15T16:55:26 Skip plants_vs_zombies_2 on Windows+AMD Step "angle_restricted_trace_gold_tests on ATI GPU on Windows on Windows-10" failing on builder "Win10 FYI x64 Release (AMD RX 5500 XT)" Bug: chromium:1187752 Change-Id: Ia48dd06c3e3aca66ff3194fc945e3c235fde85df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762645 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
James Clarke 06d194e2 2021-01-10T14:29:44 Reland "Add support for building in Flutter Windows UWP configuration" This is a reland of 68ac4e43aa67c4bac9df639d80079648ea86dbe9 Original change's description: > Add support for building in Flutter Windows UWP configuration > > Bug: angleproject:5527 > Change-Id: Idf5a4cbb6f84b24fa2448157cab1b6a3bce4d8be > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2620580 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5527 Change-Id: I3d5c3a35d73e3946ae40c779e76e0343039bf660 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2693639 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org>
angle-autoroll a11d65a1 2021-03-15T10:01:33 Roll vulkan-deps from ea8c29e1ee20 to d70f9e670332 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ea8c29e1ee20..d70f9e670332 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/60aa24566e..84d1f8aa2a * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5d8c40399e..478754c005 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I919d629ed344528dce501fc3880147fb7640f808 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2760357 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8edee520 2021-03-15T10:01:28 Roll SwiftShader from 3c4fd15fb075 to 5cdf55ff2084 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/3c4fd15fb075..5cdf55ff2084 2021-03-13 capn@google.com Remove vkGetInstanceProcAddr from exported symbols on Fuchsia 2021-03-12 capn@google.com Remove vkGetInstanceProcAddr from exported symbols on Android 2021-03-12 natsu@google.com Handle semaphore update in vkAcquireImageANDROID 2021-03-12 natsu@google.com Update AHB default YUV range to NARROW 2021-03-12 capn@google.com Regres: Roll dEQP to 1.2.5.2-dev revision 288b9dd 2021-03-12 swiftshader.regress@gmail.com Regres: Update test lists @ 3c4fd15f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ic2eec9679101fe9890fa4d0571f39c28f4cef04f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2760258 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 45ce8d1e 2021-03-15T08:07:12 Roll Chromium from e90a7a4d378a to 1572b5ac9572 (403 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e90a7a4d378a..1572b5ac9572 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8b3a30a92c..5f2e66e38e * buildtools/linux64: git_revision:e0358b49272c8b354eda0a595e1d7887343fab27..git_revision:64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8 * buildtools/mac: git_revision:e0358b49272c8b354eda0a595e1d7887343fab27..git_revision:64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8 * buildtools/win: git_revision:e0358b49272c8b354eda0a595e1d7887343fab27..git_revision:64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/09e6844f48..c6aca9251c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6e87bddf1b * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/84a6931d87..5243354177 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e645571320..91db20bec2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3164db0bf1..cfcc45286b * tools/skia_goldctl/linux: B61Q7uQOsOlRtaowXXUUrD_eSjWCpiKEcrtjT3VFg-cC..jstGnw4Pyb9uiuH75QNEy3f6hJN7ET2TFiOVOUiMokcC * tools/skia_goldctl/mac: RY1cs6o9Gi3j3iBE9XxPDZcR1n4Xvo27QvF_F3wL2r4C..VUCuq1sveo1hxWfABmHwe-nXmh0OuWy4y9PhS3ykvykC No update to Clang. Bug: angleproject:4483 Tbr: ianelliott@google.com Change-Id: Ib54ef0294caddbd741ffe77f9d5259887292f648 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2759740 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott cd881848 2021-03-12T15:26:36 Actually skip a flaky/timeout test Also, create SwANGLE KHR 3.1 expectations section Bug: angleproject:5755 Change-Id: I902b3d3de0c3c4dd190d36c6b5f2def33420efc7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757125 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Tim Van Patten bbed8813 2021-03-05T17:40:27 Create GN arg to enable non-conformant features The GN arg angle_expose_non_conformant_extensions_and_versions is being added to control exposeNonConformantExtensionsAndVersions, which enables non-conformant features and extensions. In particular, this is being done to enable EXT_texture_buffer on devices that don't support all of the necessary formats since many Android games rely on this extension, such as "Special Forces Group 2", "Fortnite", and "PUBG". # Enables non-conformant extensions and features angle_expose_non_conformant_extensions_and_versions = false Users/vendors can now toggle the value with a GN arg, rather than a code change, to make it easier to test the conformant version of ANGLE with CTS, dEQP, etc. and/or app-compatibility. Bug: angleproject:5592 Change-Id: Icbf18b48a2751c03e277ae964e1ec278a43324cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2740643 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Ian Elliott 191bee56 2021-03-12T13:44:19 Suppress flaky test on win-swangle This test times out. It takes a while on my underpowered Windows laptop. Bug: angleproject:5755 Change-Id: Id112c170a5e57c8e765dd94277ce0cf2801fae6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757118 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Pujun Lun ca5dbef0 2021-03-11T00:40:39 Micro-optimization for loading 3-channel images. This reduced the total time spent in LoadToNative3To4 by 10% in our micro-benchmark. Test: passed the CQ dry run. Bug: b/182513949 Change-Id: I5d1b1975f64e5b08bd0e65abc8f94fe62ef54321 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752347 Commit-Queue: Pujun Lun <lunpujun@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott 4f6d4d6f 2021-03-12T10:32:57 Suppress flaky EGL resize failure on Linux Bug: angleproject:5753 Change-Id: I0bf716b09d329e9881bf5ca146ef6839d898a1b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757107 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 89d2a96a 2021-03-09T18:37:57 Vulkan: Add test for UBO descriptor allocations. This performance counter test verifies that re-binding the same two buffers repeatedly doesn't allocate new descriptor sets. Currently the test fails because we don't cache descriptor sets for UBOs. Covers equivalent code patterns in Asphalt 9. Reorganizes the perf counters collected for the program objects. Now they are per-frame reset instead of cumulative. This tracking is now consistent for the different counter types. In the future we can add cumulative tracking for all per-object and global perf counters. Bug: angleproject:5736 Change-Id: I23d04b6453e38af1cf4af7274d24382d136efad3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746176 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 4d7ea943 2021-03-11T21:05:29 Remove old Mac bot from CQ mac-angle-chromium-try + mac-angle-try replace mac-angle-rel, adding dEQP testing on top of it Bug: angleproject:4483 Change-Id: I477b3ef884e4e92c9ab11a55d7a8a3f4f4e0c02b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753491 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jason Macnak 41a2672f 2020-09-03T11:05:54 Vulkan: Use optimal tiling for AHB When running Android on certain GPUs, there are problems creating Vulkan image siblings of AHardwareBuffers because it's currently assumed that the underlying driver can create linear tiling images that have input attachment usage, which isn't supported on NVIDIA for example, resulting in failure to create the image siblings. Yet, we don't currently take advantage of linear elsewhere in ANGLE. To maintain maximum compatibility on Android for such drivers, use optimal tiling for image siblings. Note that while we have switched to optimal unconditionally in this path versus linear, it's possible that previously compatible linear usages might become uncompatible after switching to optimal. However, from what we've seen on NVIDIA/AMD/Intel/Samsung GPUs so far, formats generally have more possible usages in optimal tiling versus linear tiling: http://vulkan.gpuinfo.org/displayreport.php?id=10804#formats_linear http://vulkan.gpuinfo.org/displayreport.php?id=10804#formats_optimal http://vulkan.gpuinfo.org/displayreport.php?id=10807#formats_linear http://vulkan.gpuinfo.org/displayreport.php?id=10807#formats_optimal http://vulkan.gpuinfo.org/displayreport.php?id=10809#formats_linear http://vulkan.gpuinfo.org/displayreport.php?id=10809#formats_optimal http://vulkan.gpuinfo.org/displayreport.php?id=10787#formats_linear http://vulkan.gpuinfo.org/displayreport.php?id=10787#formats_optimal Also, as an aside, in terms of what's generally expected from the Vulkan ICD in Android when determining AHB compatibility, if the vendor wants to declare a particular combinatino of format/tiling/usage/etc as not supported AHB-wise, it's up to the ICD vendor to zero out bits in supportedHandleTypes in the vkGetPhysicalDeviceImageFormatProperties2 query: ``` * [VUID-VkImageCreateInfo-pNext-00990](https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-VkImageCreateInfo-pNext-00990) If the pNext chain includes a VkExternalMemoryImageCreateInfo structure, its handleTypes member must only contain bits that are also in VkExternalImageFormatProperties::externalMemoryProperties.compatibleHandleTypes, as returned by vkGetPhysicalDeviceImageFormatProperties2 with format, imageType, tiling, usage, and flags equal to those in this structure, and with a VkPhysicalDeviceExternalImageFormatInfo structure included in the pNext chain, with a handleType equal to any one of the handle types specified in VkExternalMemoryImageCreateInfo::handleTypes ``` Bug: angleproject:5709 Change-Id: I67b65ab830505a9df4665ccea8e2ba1ca409e0b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729243 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lingfeng Yang <lfy@google.com>
Jeff Vigil cef5b717 2021-03-11T09:22:33 EGL: Add attribute check in ValidateQueryContext Implementation of EGL_IMG_context_priority was missing attribute check in ValidateQueryContext Add test case. Test: angle_end2end_test --gtest_filter=EGLCreateContextAttribsTest Bug: angleproject:5746 Change-Id: Idf5df29fcb343d969a031675b6c5985a9be0a705 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752891 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 5cc32fc9 2021-03-12T10:01:28 Roll SwiftShader from a2fe8e1b2111 to 3c4fd15fb075 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/a2fe8e1b2111..3c4fd15fb075 2021-03-11 capn@google.com Implement timestamp query support 2021-03-11 srisser@google.com Expose Vulkan 1.2 support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ib6b2cce9056177b7b490d650c3344351a010d3d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756348 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bb034e05 2021-03-12T10:01:33 Roll vulkan-deps from a4e10bfde719 to ea8c29e1ee20 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a4e10bfde719..ea8c29e1ee20 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/77eb2b608e..5d8c40399e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/be60dd27b1..f648a59e1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ic58ad0ced49c9ba102605bd14d24dd5466d2ed4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756088 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b775012c 2021-03-12T08:08:11 Roll Chromium from 9e42f9e4abc6 to e90a7a4d378a (458 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9e42f9e4abc6..e90a7a4d378a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cb067b2df4..8b3a30a92c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/368c7dd2c9..69cc9b8a3a * buildtools/linux64: git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3..git_revision:e0358b49272c8b354eda0a595e1d7887343fab27 * buildtools/mac: git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3..git_revision:e0358b49272c8b354eda0a595e1d7887343fab27 * buildtools/win: git_revision:dfcbc6fed0a8352696f92d67ccad54048ad182b3..git_revision:e0358b49272c8b354eda0a595e1d7887343fab27 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/32c9b4b55a..09e6844f48 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cf138ce6bf * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/348acca950..09490503d0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e65f1a7cc3..e645571320 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4bd62b06a2..3164db0bf1 * tools/skia_goldctl/linux: X8zqgmHchz43Cvw6xwn3VRL5keLdpA3cD_DqweHLRqMC..B61Q7uQOsOlRtaowXXUUrD_eSjWCpiKEcrtjT3VFg-cC * tools/skia_goldctl/mac: 9B5ePukmYbotGUjJuMV-DdjKGW5K0MtKrz8eOpXftu8C..RY1cs6o9Gi3j3iBE9XxPDZcR1n4Xvo27QvF_F3wL2r4C * tools/skia_goldctl/win: tC_p4_R9hLfNMczJQbjawF5kzgXRVNF-XVcN7bJxrEYC..j4rOmbVNLoVaUWWPvzH9y8NIrbGae5OxIInpCD89q0QC No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I740c584e817bf2208aaf3f70211e101d8aa6f826 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756087 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 225e1952 2021-03-11T17:05:43 Tests: Add Plants vs. Zombies 2 trace Test: angle_perftests --gtest_filter="*plants_vs_zombies_2*" TBR: jmadill@google.com,timvp@google.com Bug: b/182512556 Bug: angleproject:5749 Change-Id: Ib6c279f49ac95964f34e430d311a49600928166b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752898 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
James Darpinian efbb5667 2021-03-11T22:41:06 Revert "Update DEP actions for Python 3" This reverts commit e44595f2297d849115a8fcb52428420dd5756ea3. Reason for revert: build/mac_toolchain.py still fails with my local Python 3.9. Let's not make this change until the top level Chromium DEPS file does. Original change's description: > Update DEP actions for Python 3 > > build/mac_toolchain.py was fixed for Python 3 in > https://crrev.com/c/2727724 > > Bug: angleproject:5707 > Change-Id: I2f233157bedc3cc298250b8efc9bd68ac45cdc28 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2731707 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5707 Change-Id: Ib955a6343d886d273d7e949815fba5366b169386 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753335 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cody Northrop d98e436a 2021-03-11T13:32:07 Tests: Add Lineage M trace Test: angle_perftests --gtest_filter="*lineage_m*" TBR: jmadill@google.com,timvp@google.com Bug: b/182491024 Bug: angleproject:5748 Change-Id: I901b68eef1ddac98ce6e1a4640e2b034d1027a45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752894 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi cb5441ed 2021-03-11T16:15:01 Vulkan: Don't let glslang link shaders The translator outputs intermediate shaders for Vulkan that are later to be modified by the SPIR-V transformer. glslang has no business trying to link them. Bug: angleproject:5740 Change-Id: I9ae418f54b91312b5fd0ef794acbc46a40261a0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753096 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 50f411e1 2021-03-09T17:20:29 Capture/Replay: Support DrawElementsBaseVertex Test: Genshin Impact MEC Bug: b/182307835 Bug: b/181794064 Change-Id: Iedaecb6aa7ab7af189534f620549727f60b69ee8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746657 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Ian Elliott c5a7da47 2021-03-11T13:12:04 Suppress flaky MultithreadingTest on Win/Swangle MultithreadingTest.MultiContextDrawWithSwapBuffers/ES3_Vulkan_SwiftShader_NoVirtual Bug: angleproject:5099 Change-Id: I12ab4a6fb7fff8d6bc7358e6017cb10e46362b88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752893 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Yuly Novikov 7c7cf3e5 2021-03-11T14:27:51 Skip dEQP tests flakily timing out on SwANGLE Bug: chromium:1173237 Change-Id: I93810cb7cbaae847848eae0dc050c2c00df956af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753144 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
John Plate 8507b105 2021-03-11T11:30:39 Fix CL_EVENT macro Bug: angleproject:5745 Change-Id: Icbfab0d0bd4b1510b98d5ed746f4d3ddfa5ec36e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752746 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev 7c02cfee 2021-03-11T19:01:13 Avoid undefined behavior in BPTCCompressedTextureTest Bug: angleproject:5360, angleproject:5731 Change-Id: Ia883d2d319d7ce4659f4e1e99b5eccf0e01a45e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752747 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
John Plate 8650381e 2021-03-10T20:08:10 Avoid implication that adding the issue number is optional Bug: angleproject:1944 Change-Id: I89867c20c724c8db4d8edeb15fa4e32769f2a578 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749596 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev b7fc9518 2021-03-08T03:55:36 Do not expose emulated ETC1 textures to WebGL Add a new "emulatedEtc1" limitation. Bug: chromium:1048244 Change-Id: Ia04746773db3ad75781a8adfda988d36bd2c57f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2718865 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev fcd7affb 2021-03-07T17:23:33 Remove unused code from ValidateES2CopyTexImageParameters Compressed formats are rejected earlier with ValidateCopyTexImageParametersBase Bug: angleproject:5731 Change-Id: I7809140af84f2c565008e211adf0f998a0e57e91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2741580 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Ian Elliott 92db3c68 2021-03-10T15:09:15 Vulkan: Disable rotating damage rectangles on Android This fixes visual problems with Android games that use eglSwapBuffersWithDamageKHR(). In 90/270-degree cases, the damage rectangles are being double-rotated, leaving them 90-degrees out of alignment with the window. On Android, VK_KHR_incremental_present is built on top of the same platform code as eglSwapBuffersWithDamageKHR(). The platform code rotates all damage rectangles (assuming they are application-provided). Therefore, ANGLE should not also pre-rotate damage rectangles. Test: Black Desert Mobile Test: Grand Theft Auto: San Andreas Test: Extreme Car Driving Simulator Bug: b/181796746 Change-Id: I6510e7540bb00afc75863e8ae8a9ea3841d1641d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2744984 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Lubosz Sarnecki 36770173 2021-03-10T15:23:03 capture_replay_tests: Don't shadow subprocess import. Rename local variable, so using subprocess.Timeout does not result in an exception. This patch fixes the test timeout counter. Bug: angleproject:5742 Change-Id: Ib6991bc58df6ea653f765dfe9f6117add75b85db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2748339 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 6f74a12b 2021-03-11T10:01:28 Roll SwiftShader from 023914a27b63 to a2fe8e1b2111 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/023914a27b63..a2fe8e1b2111 2021-03-10 srisser@google.com Add Vulkan 1.2 entry points If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ia8aba9350c1c0476441da7f9c5eb20a22dfbfe54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752214 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2cf0729a 2021-03-11T10:03:33 Roll vulkan-deps from 6691fcec0bce to a4e10bfde719 (24 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6691fcec0bce..a4e10bfde719 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/159b057080..a36d91e5ac * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d57ab68a21..60aa24566e * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7d514cf1c7..77eb2b608e * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/4fe5828a02..89d366355e * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/237d3dcb5c..1353e80d87 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/461b33cfa2..d1cd265394 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0ec2c7a693..be60dd27b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I65c8200a79763bdcbc0e32d60d7cac0f89ca786b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752528 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 9265d1e2 2021-03-05T17:54:59 frame_capture_utils: Do not serialize 0 bindings. Since we are only interested in the difference to non-default states, bindings with a zero ID should not be serialized. This resolves the comparision error in the GetTexLevelParameterTest.* tests. The test now do not need to be skipped. Bug: angleproject:5645 Change-Id: I887bc22b52a201c467c00c42f6ddb3b38895a7c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739726 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll ff16821c 2021-03-11T07:01:13 Roll Chromium from 075d29b4983b to 9e42f9e4abc6 (425 revisions) https://chromium.googlesource.com/chromium/src.git/+log/075d29b4983b..9e42f9e4abc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/389d3f34d2..cb067b2df4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fb41d7ef20..32c9b4b55a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/357278b25a..8e820e32d0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7a3a7363a7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fc54e6b87c..e65f1a7cc3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d850327d94..4bd62b06a2 * tools/skia_goldctl/linux: fRRnk-3C4PCCGCwZ4hZCeqm9_BnqznTyThRH4XqRVIIC..X8zqgmHchz43Cvw6xwn3VRL5keLdpA3cD_DqweHLRqMC * tools/skia_goldctl/mac: OLq_hZKAgzddlvSP4YR1TK0_2hzZipwLepMP3lOfS28C..9B5ePukmYbotGUjJuMV-DdjKGW5K0MtKrz8eOpXftu8C * tools/skia_goldctl/win: 5CX5n_psRKwMH74v7aAH4AHynDeTitubHLzeWYyCKv8C..tC_p4_R9hLfNMczJQbjawF5kzgXRVNF-XVcN7bJxrEYC No update to Clang. Bug: angleproject:5739 Tbr: ianelliott@google.com Change-Id: Ia21d911e770be49fd98c757feeb87d58bc5d5a1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2750565 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 44b9579c 2021-03-10T08:10:33 Vulkan: Treat varyings in a separable program as active When separable programs are linked, varyings at the separable program's boundary need to be treated as active. Bug: angleproject:5557 Test: ProgramPipelineTest31.VaryingIOBlockSeparableProgram* Change-Id: I28af2bdf6478a408b3a7155ab4376ed6a19192f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2742659 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Ian Elliott 43271b34 2021-03-10T16:26:50 Revert "Roll vulkan-deps from 6691fcec0bce to 32692e5de307 (12 revisions)" This reverts commit 2aed567fb387ba4775fcb08e7b188e20600a76ed. Reason for revert: Per https://bugs.chromium.org/p/angleproject/issues/detail?id=5741, the glslang change causes tests to fail with internal-linker errors. Original change's description: > Roll vulkan-deps from 6691fcec0bce to 32692e5de307 (12 revisions) > > https://chromium.googlesource.com/vulkan-deps.git/+log/6691fcec0bce..32692e5de307 > > Changed dependencies: > * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/159b057080..84e11a858c > * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d57ab68a21..fb1f295aaf > * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7d514cf1c7..c6da5e343c > * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/4fe5828a02..89d366355e > * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0ec2c7a693..d1de19fea5 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/vulkan-deps-angle-autoroll > Please CC ianelliott@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: ianelliott@google.com > Change-Id: I2bf77ebe46a52a285da0e8911a09f3e22067351a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745003 > Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> > Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bug: None Change-Id: I17f29c93e3a778395c02831740684f0e4aeb342f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746842 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Jonah Ryan-Davis bb6e512e 2021-03-09T16:17:54 Mtl: Add Apple vendor ID On M1 Macs we need to extract Apple's vendor ID. Bug: chromium:1131248 Change-Id: Ie0e4006c3005e0a252d7a27a069a3be47ef4a7d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745703 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Ian Elliott 7c9cb3eb 2021-03-10T10:09:15 Revert "Roll vulkan-deps from 32692e5de307 to 28d8c3478e4c (6 revisions)" This reverts commit b2f547f4f423f492c4483d901d1b3ad5f3ad8798. Reason for revert: Reverting this CL so that I can revert another CL that is causing tests to crash (see: http://anglebug.com/5741). A glslang change causes tests to fail with internal-linker errors. The upstream bug is: https://github.com/KhronosGroup/glslang/issues/2567 Bug: angleproject:5740 Change-Id: I8cde0d6c7004b03c130114af67b791e2871b8459 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2748966 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Mohan Maiya 331640e5 2021-03-09T14:36:19 Vulkan: Pass in the correct size to acquireBufferHelper When BufferVk::acquireAndUpdate calls into acquireBufferHelper to allocate a new buffer helper we were passing in the update size instead of the full buffer size. Modified acquireAndUpdate's parameter to better reflect intent. Bug: angleproject:5689 Change-Id: Ic4fbc015651491ec028d747da5d45670264b93fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746066 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
angle-autoroll b2f547f4 2021-03-10T10:01:33 Roll vulkan-deps from 32692e5de307 to 28d8c3478e4c (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/32692e5de307..28d8c3478e4c Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/fb1f295aaf..60aa24566e * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c6da5e343c..4a59fd4763 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d1de19fea5..be60dd27b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I68384f61f4d3290089441645ee456b9bffa808f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2748474 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0