|
d193d51b
|
2024-06-17T22:46:08
|
|
Replace issue ids post migration to new issue tracker
This change replaces anglebug.com/NNNN links.
Bug: None
Change-Id: I8ac3aec8d2a8a844b3d7b99fc0a6b2be8da31761
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5637912
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
f507fe05
|
2023-04-06T12:27:00
|
|
Rename PLATFORM_IOS to PLATFORM_IOS_FAMILY
The current define ANGLE_PLATFORM_IOS actually means
"iOS or tvOS or WatchOS or MacCatalyst".
The current define ANGLE_PLATFORM_WATCHOS means nothing.
The current define ANGLE_PLATFORM_APPLETV means nothing.
Replace PLATFORM_IOS and its uses with PLATFORM_IOS_FAMILY, so that
then PLATFORM_IOS can be reintroduced and others can be fixed.
Replace PLATFORM_IOS_SIMULATOR and its uses with
PLATFORM_IOS_FAMILY_SIMULATOR for consistency.
Use consistent `#if X` notation instead of `#if defined(X)`.
Bug: angleproject:8121
Change-Id: Ibe668c2ae9bb801d15e036fcf1dfd53f22c30787
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4404161
Reviewed-by: Dan Glastonbury <djg@apple.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
|
cfc21f23
|
2023-04-06T18:39:26
|
|
Fix GetCurrentThreadUniqueId on Release APPLE
Fix GetCurrentThreadUniqueId on Release builds of
ANGLE_PLATFORM_APPLE.
Code inside ASSERT() is discarded when compiling on Release.
Instead, create the pthread per-thread keys outside ASSERTs and
just assert the results.
Bug: angleproject:8122
Change-Id: I89b7bd66f4346a94ec5c67eedda637f012ba7ff6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4406215
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Dan Glastonbury <djg@apple.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
37d6a9db
|
2022-11-18T17:42:21
|
|
Support versioned library names
Previously ANGLE_GLESV2_LIBRARY_NAME was expected to be the library name
without extension, and on Linux .so would be appended. This didn't allow
for building ANGLE as libEGL.so.1 and libGLESv2.so.2 as is common.
This change checks if the library name already contains a dot, and if so
doesn't append the platform specific extension suffix.
Bug: b/259282560
Change-Id: I81cda218180ae7fe6321e1ac7e4eff7257bf1493
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4038450
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Nicolas Capens <nicolascapens@google.com>
|
|
2c373771
|
2022-08-30T10:08:44
|
|
Add include atomic, missing in Skia builds.
Bug: angleproject:7602
Change-Id: I024981c880ed073c3a603f47b538d2375a911e1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3863161
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
f18b6335
|
2022-08-29T11:53:01
|
|
Replace std::this_thread::get_id() use with a unique thread id.
std::this_thread::get_id() gets recycled. It's pthread_self()
under the hood on Linux and Android which gets recycled, for
example when one thread terminates and another one starts
it is likely to return the same value.
Bug: angleproject:7602
Change-Id: I83d818bc17ead5cce8bce7f7d88fc1c7c0fa860c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3855041
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
f0b4e8b2
|
2022-08-23T17:12:44
|
|
Fix loading ANGLE libraries on iOS
Previously end2end tests would try to load
libEGL.framework/libEGL.framework instead of libEGL.framework/libEGL
Bug: angleproject:5417
Change-Id: Iccb9ad20df980dfd460219dbcaf9b273aef9c7dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3851164
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
|
|
b968b6c9
|
2022-07-26T14:34:41
|
|
Test Utils: Get executable path from command line.
This simplifies the process fork test and will allow the test to
work on Fuchsia.
Bug: angleproject:3161
Change-Id: I5bb5424c44957f2faef1970b3cbc5e52b8aff630
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3788297
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
916a35dd
|
2022-06-28T14:40:53
|
|
Merge getTempPath and CreateTemporaryFile
Also includes moving these two (and some helpers) to
common/system_utils.h
Bug: angleproject:5095
Change-Id: I7d2fcbd27a67dc13215265ac5b5e8391b15a980b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3733519
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
2d3ce72d
|
2022-01-20T10:13:06
|
|
Refactor shared library load to avoid allocations.
Fixes a leak of an angle::Library detected in the EGL loader.
Bug: angleproject:6937
Change-Id: I623aa6172b98a35465e1d2641b92f67bdc5d24e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3403060
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
2ebd583e
|
2021-12-22T11:24:43
|
|
Android: Remove setenv from common path
In Android production stress testing, the setenv call was causing a
race condition. To fix, only use setenv in the paths that need it
as a performance optimization. Specifically, FrameCapture makes
use of it every frame.
Bug: angleproject:6822
Change-Id: I452f1ef8607ca9baf15d69246932c47454a3ce46
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3353893
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
56aee5d6
|
2021-12-10T12:32:58
|
|
Reland "system_utils: Add memory protection functionality."
This is a reland of b1c703e5f5e44514e8db958a5fb39ff16e514fd8
that was reverted in 663831aa676c59829cc3d822340812f016bf77f6.
Skip PageFaultHandlerProtect and PageFaultHandlerDefaultHandler on macOS
and Fuchsia.
Original change's description:
> Reland "system_utils: Add memory protection functionality."
>
> This is a reland of ab75a90ff4ecb9d99b5c72bde92222b07c285401
> that was reverted in b007e667a8f94b47788a5ba0b2e61c9ac2d1285f.
>
> Implement PageFaultHandler and memory protection functions.
> Uses mprotect and sigaction on POSIX and equivalent Win API functions on
> win32.
>
> Add tests to system_utils_unittests.
>
> Add stubs for winuwp.
>
> Replace ASSERT with ASSERT_TRUE in the PageFaultHandlerDefaultHandler
> test to make it succeed on release builds, as the code was optimized
> out. Furthermore the test did not correctly remove protection from the
> whole area it protected, which caused a hang after deinitialization on
> some build configurations, since the custom page fault handler was also
> still in place. The test now correclty removes protection from the whole
> area and sets back the original page fault handler.
>
> Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*"
> Bug: angleproject:5857
> Change-Id: Ibb0acfefd9a09c3360c04c812a2a8346b951e1da
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322992
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*"
Bug: angleproject:5857
Change-Id: Ifaa966a7c569aa9ff0112897a02fa8f873cd52dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3329610
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
663831aa
|
2021-12-09T18:08:28
|
|
Revert "Reland "system_utils: Add memory protection functionality.""
This reverts commit b1c703e5f5e44514e8db958a5fb39ff16e514fd8.
Reason for revert: Fails on fuchsia bots:
https://ci.chromium.org/ui/p/chromium/builders/try/fuchsia_arm64/1020498/overview
mprotect failed: Not supported
Original change's description:
> Reland "system_utils: Add memory protection functionality."
>
> This is a reland of ab75a90ff4ecb9d99b5c72bde92222b07c285401
> that was reverted in b007e667a8f94b47788a5ba0b2e61c9ac2d1285f.
>
> Implement PageFaultHandler and memory protection functions.
> Uses mprotect and sigaction on POSIX and equivalent Win API functions on
> win32.
>
> Add tests to system_utils_unittests.
>
> Add stubs for winuwp.
>
> Replace ASSERT with ASSERT_TRUE in the PageFaultHandlerDefaultHandler
> test to make it succeed on release builds, as the code was optimized
> out. Furthermore the test did not correctly remove protection from the
> whole area it protected, which caused a hang after deinitialization on
> some build configurations, since the custom page fault handler was also
> still in place. The test now correclty removes protection from the whole
> area and sets back the original page fault handler.
>
> Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*"
> Bug: angleproject:5857
> Change-Id: Ibb0acfefd9a09c3360c04c812a2a8346b951e1da
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322992
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Bug: angleproject:5857
Change-Id: Iaab4067a7ec9240bb6c64b810ac6d3ea7bd86fe1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3327743
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b1c703e5
|
2021-12-08T14:53:46
|
|
Reland "system_utils: Add memory protection functionality."
This is a reland of ab75a90ff4ecb9d99b5c72bde92222b07c285401
that was reverted in b007e667a8f94b47788a5ba0b2e61c9ac2d1285f.
Implement PageFaultHandler and memory protection functions.
Uses mprotect and sigaction on POSIX and equivalent Win API functions on
win32.
Add tests to system_utils_unittests.
Add stubs for winuwp.
Replace ASSERT with ASSERT_TRUE in the PageFaultHandlerDefaultHandler
test to make it succeed on release builds, as the code was optimized
out. Furthermore the test did not correctly remove protection from the
whole area it protected, which caused a hang after deinitialization on
some build configurations, since the custom page fault handler was also
still in place. The test now correclty removes protection from the whole
area and sets back the original page fault handler.
Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*"
Bug: angleproject:5857
Change-Id: Ibb0acfefd9a09c3360c04c812a2a8346b951e1da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322992
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
b007e667
|
2021-12-08T01:00:54
|
|
Revert "system_utils: Add memory protection functionality."
This reverts commit ab75a90ff4ecb9d99b5c72bde92222b07c285401.
Reason for revert: Causes angle_unittests to hang on many Linux FYI bots and likely Android. First known failures on Linux:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20Release%20(AMD%20RX%205500%20XT)/7318/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20Release%20(Intel%20HD%20630)/30297/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20Experimental%20Release%20(Intel%20HD%20630)/43446/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20Release%20(Intel%20UHD%20630)/4720/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20Release%20(NVIDIA)/29040/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20Experimental%20Release%20(NVIDIA)/45374/overview
And Android:
https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Nexus%209)/35989/overview
https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(NVIDIA%20Shield%20TV)/33490/overview
Original change's description:
> system_utils: Add memory protection functionality.
>
> Implement PageFaultHandler and memory protection functions.
> Uses mprotect and sigaction on POSIX and equivalent Win API functions on
> win32.
>
> Add tests to system_utils_unittests.
>
> Add stubs for winuwp.
>
> Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*"
> Bug: angleproject:5857
> Change-Id: Ia6d2e87c409e6139ccaebc8c7186cd4cd844fd28
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3236998
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Cody Northrop <cnorthrop@google.com>
> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Bug: angleproject:5857
Change-Id: I7df73a3ee3f5fa87f002045dfa87d8ca2747f60f
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322104
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
ab75a90f
|
2021-10-21T20:20:07
|
|
system_utils: Add memory protection functionality.
Implement PageFaultHandler and memory protection functions.
Uses mprotect and sigaction on POSIX and equivalent Win API functions on
win32.
Add tests to system_utils_unittests.
Add stubs for winuwp.
Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*"
Bug: angleproject:5857
Change-Id: Ia6d2e87c409e6139ccaebc8c7186cd4cd844fd28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3236998
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
6e2e36cc
|
2021-11-19T00:57:29
|
|
[Fuchsia] Fix SwiftShader ICD discovery
ANGLE needs to set VK_ICD_FILENAMES for the Vulkan loader to discover
SwiftShader's ICD. Enable this logic on Fuchsia.
Also updated ConcatenatePath() to handle absolute paths correctly.
Bug: chromium:1225002
Change-Id: Ib69be0d7dcaef09f1da9d411023e90a3b7b4fca2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292347
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
d4d6c23c
|
2021-07-31T11:41:29
|
|
Fix a recently-introduced case of -Wunreachable-code-aggressive.
Also enable this and -Wunused-but-set-variable to avoid regressing them.
Bug: chromium:1066980
Change-Id: I1fd7a57c2bf14513d657b69b70e35ad727c75ffd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3065355
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
d33a2222
|
2021-04-26T16:56:15
|
|
Upstream Apple's direct-to-Metal backend: compile libANGLE.
This change is meant to merge the metal backend changes from Apple's
direct-to-Metal backend. Taken from Kyle Piddington's CL:
https://chromium-review.googlesource.com/c/angle/angle/+/2857366/
The goal of this CL is to merge the metal backend code in a state
that compiles, but not to switch the Metal backend over to using
the direct-to-metal backend yet.
Bug: angleproject:5505
Bug: angleproject:6127
Change-Id: If6783e06e0086b3a1dd25c6f53caca5cfc96cb86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950067
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
e2fc818a
|
2021-05-05T11:51:00
|
|
Reland Change to module directory when loading swiftshader ICD.
This is a reland of commit 3b10dda6a479612a07673b5c87d3560e0941d41b.
Extra changes:
Be explicit about calling GetModuleHandleA
Do not use the general GetModuleHandle, which may use wide strings
Refactored ConcatenatePath and add tests
GetModuleDirectory should return the full path, not relative.
ANGLE wasn't able to locate the vulkan ICD file because it was
searching down an invalid relative path. This can be fixed by
ensuring the module directory is always the full path.
on some platforms.
Original change's description:
> When loading vulkan, we can be running from any directory. We need
> to change to the module directory to ensure the swiftshader ICD is
> loaded properly. For example, in some Chrome releases, libGLESv2.dll
> and libvk_swiftshader.dll are in a subdirectory relative to chrome.exe
>
> Bug: chromium:1198567
> Change-Id: I9e68927e512b239728fb2903d1a04702508a4948
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873452
> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Bug: chromium:1198567
Bug: angleproject:5949
Change-Id: I63fbe93f8492b7f23566f8193b1b8fe784a34f71
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2904586
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
d820ec7b
|
2021-02-05T10:39:25
|
|
Use __system_property* to read Android props
... instead of popen to avoid needing shell_exec permission.
Bug: b/179041465
Test: roll_aosp.sh && m && launch Cuttlefish w/ SwANGLE
Test: aosp/1574848 presubmit
Change-Id: Ie64d2730fd2ea00a1b5089459297ef7ffe98bc59
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676271
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Jason Macnak <natsu@google.com>
|
|
a481bee2
|
2020-11-04T18:20:24
|
|
Add GetEnvironmentVarOrUnCachedAndroidProperty
GetEnvironmentVarOrAndroidProperty will first return the given
variableName from the processes enviroment if defined. If not defined
and running on Android, will look up the corresponding property and
store it in the environment.
The framecapture code wants to see when the Android property changes so
add an uncached version of GetEnvironmentVarOrAndroidProperty that
always does the getprop command (which can be time consuming).
Bug: b/170328907
Change-Id: I0624c0646889435cb6f6eb20a6d3cceb6ae3eb48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520107
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
3980b1f8
|
2020-10-27T10:01:05
|
|
Refactor FrameCapture.cpp to use common utility
The frame-capture-specific AndroidGetEnvFromProp() function has been
ported to the general utility, GetEnvironmentVarFromAndroidProperty().
Bug: b/170249632
Change-Id: I97de8205ceef140dfd8fab8e6f2d52b90cd996cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2502772
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
45881ab3
|
2020-10-26T16:15:16
|
|
Enable debug-util markers with an env var/property
Enable the Vulkan debug-util markers by setting the
ANGLE_ENABLE_DEBUG_MARKERS" environment variable to any 1+-character
value. On Android, this is set with the "debug.angle.markers" Android
property.
Bug: b/170249632
Change-Id: I66503fac71397c59cc641dd903faad152e0ec449
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2500186
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
3e57e349
|
2020-08-12T12:48:34
|
|
Vulkan: Query application name from the system
While populating VkApplicationInfo::pApplicationName
we are hardcoding the value to "ANGLE", instead query
the value from the sytem.
Bug: angleproject:4955
Change-Id: I222d5d1c0f497bf708389caa048d8b180c1bdecc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2352625
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
eb63016d
|
2020-02-04T16:15:41
|
|
Add environment overrides for ANGLE features.
Allows the application to override ANGLE behaviour without having to
modify the code or use the ANGLE extension. Useful for testing with the
command graph refactor.
Adds a new string utility for parsing lists of strings from environment
variables.
Bug: angleproject:4029
Change-Id: Ibae93b743c0c385392cd259d9604ce2f2ed988dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2037784
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
95a736bd
|
2019-10-09T10:26:25
|
|
Reland "Add more test_utils functions."
This is a reland of 5fcfcea4a9379633a83a67fc1d94938cb31f2a9c
Re-land uses static linking with angle_util. The root cause
of the CFI error wasn't solved. Static linking works around
the problem by not using any export rules.
Second re-land fixes missing imports for libEGL and libGLESv2
static varieties.
Original change's description:
> Add more test_utils functions.
>
> Includes methods for creating temporary files, deleting files, and
> reading files into a string. Also renames GetPathSeparator to mention
> it's only used for environment variables. Includes a new virtual type
> angle::Process that will be used to implement cross-platform async
> Process launching for tests. Also includes a way to specify a custom
> crash handler callback.
>
> Also adds a few unit tests for the new functionality. They are disabled
> on Android because the functions are not needed by the new test runner.
>
> Bug: angleproject:3162
> Change-Id: I3e2c2e9837608884c98379fa0f78c9ffbe158d73
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1821940
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Bug: chromium:1015810
Bug: angleproject:3162
Change-Id: I2a18b819b0f91df610ad12ffedea2b38349fe7cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879859
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
f939cb63
|
2019-10-20T21:44:36
|
|
Revert "Reland "Add more test_utils functions.""
This reverts commit 7923e234bc458eda5936b8cb4f09fa19e28c0452.
Reason for revert: Fails compilation on rollers:
[2097/6048] SOLINK ./lib_angle_unittests__library.cr.so
FAILED: lib_angle_unittests__library.cr.so lib_angle_unittests__library.cr.so.TOC lib.unstripped/lib_angle_unittests__library.cr.so
python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="../../third_party/android_ndk/toolch...(too long)
ld.lld: error: undefined symbol: glCreateShader
>>> referenced by shader_utils.cpp
>>> angle_util_static/shader_utils.o:(CompileShader(unsigned int, char const*)) in archive obj/third_party/angle/libangle_util_static.a
ld.lld: error: undefined symbol: glShaderSource
Original change's description:
> Reland "Add more test_utils functions."
>
> This is a reland of 5fcfcea4a9379633a83a67fc1d94938cb31f2a9c
>
> Re-land uses static linking with angle_util. The root cause
> of the CFI error wasn't solved. Static linking works around
> the problem by not using any export rules.
>
> Original change's description:
> > Add more test_utils functions.
> >
> > Includes methods for creating temporary files, deleting files, and
> > reading files into a string. Also renames GetPathSeparator to mention
> > it's only used for environment variables. Includes a new virtual type
> > angle::Process that will be used to implement cross-platform async
> > Process launching for tests. Also includes a way to specify a custom
> > crash handler callback.
> >
> > Also adds a few unit tests for the new functionality. They are disabled
> > on Android because the functions are not needed by the new test runner.
> >
> > Bug: angleproject:3162
> > Change-Id: I3e2c2e9837608884c98379fa0f78c9ffbe158d73
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1821940
> > Commit-Queue: Jamie Madill <jmadill@chromium.org>
> > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
>
> Bug: chromium:1015810
> Bug: angleproject:3162
> Change-Id: I6a2c1e7b585a13ca846759f32da0777c00d7f7e6
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1869541
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
TBR=ynovikov@chromium.org,jonahr@google.com,jmadill@chromium.org
Change-Id: I975b2214411906cb981bffa04fa50e0a65ff8b4e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1015810, angleproject:3162
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1870811
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
7923e234
|
2019-10-09T10:26:25
|
|
Reland "Add more test_utils functions."
This is a reland of 5fcfcea4a9379633a83a67fc1d94938cb31f2a9c
Re-land uses static linking with angle_util. The root cause
of the CFI error wasn't solved. Static linking works around
the problem by not using any export rules.
Original change's description:
> Add more test_utils functions.
>
> Includes methods for creating temporary files, deleting files, and
> reading files into a string. Also renames GetPathSeparator to mention
> it's only used for environment variables. Includes a new virtual type
> angle::Process that will be used to implement cross-platform async
> Process launching for tests. Also includes a way to specify a custom
> crash handler callback.
>
> Also adds a few unit tests for the new functionality. They are disabled
> on Android because the functions are not needed by the new test runner.
>
> Bug: angleproject:3162
> Change-Id: I3e2c2e9837608884c98379fa0f78c9ffbe158d73
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1821940
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Bug: chromium:1015810
Bug: angleproject:3162
Change-Id: I6a2c1e7b585a13ca846759f32da0777c00d7f7e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1869541
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
0cb09633
|
2019-10-18T15:50:10
|
|
Revert "Add more test_utils functions."
This reverts commit 5fcfcea4a9379633a83a67fc1d94938cb31f2a9c.
Reason for revert:
1 Test Suite(s) failed. angle_unittests failed because of:
TestUtils.RunApp on Linux CFI
https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI
Original change's description:
> Add more test_utils functions.
>
> Includes methods for creating temporary files, deleting files, and
> reading files into a string. Also renames GetPathSeparator to mention
> it's only used for environment variables. Includes a new virtual type
> angle::Process that will be used to implement cross-platform async
> Process launching for tests. Also includes a way to specify a custom
> crash handler callback.
>
> Also adds a few unit tests for the new functionality. They are disabled
> on Android because the functions are not needed by the new test runner.
>
> Bug: angleproject:3162
> Change-Id: I3e2c2e9837608884c98379fa0f78c9ffbe158d73
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1821940
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
TBR=ynovikov@chromium.org,jonahr@google.com,jmadill@chromium.org
Change-Id: I1441bfbae31712f72b4aebeeea9cd711c3975a5d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:3162
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1869254
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
5fcfcea4
|
2019-10-09T10:26:25
|
|
Add more test_utils functions.
Includes methods for creating temporary files, deleting files, and
reading files into a string. Also renames GetPathSeparator to mention
it's only used for environment variables. Includes a new virtual type
angle::Process that will be used to implement cross-platform async
Process launching for tests. Also includes a way to specify a custom
crash handler callback.
Also adds a few unit tests for the new functionality. They are disabled
on Android because the functions are not needed by the new test runner.
Bug: angleproject:3162
Change-Id: I3e2c2e9837608884c98379fa0f78c9ffbe158d73
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1821940
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
b4ca09ac
|
2019-05-15T15:23:12
|
|
Add IsDirectory helper function to system_utils.
This was previously a method in dEQP only. Cleanup change only.
Bug: angleproject:3353
Change-Id: I9ac58ab52516f75efbb08bddb39466a40c07cbb8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1613892
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
046fa0ef
|
2018-02-02T14:51:36
|
|
Vulkan: Prepend layer path to VK_LAYER_PATH
Directly setting this variable overwrites old value, as might be
unexpected. Instead the path can be prepended to it, so that old
value can still work.
This is needed in order to use additional debugging layers, like
the "api_dump" layer. See https://github.com/LunarG/VulkanTools
for more.
BUG=angleproject:2333
Change-Id: I5338a5b928ffa792cc9b6db5b69713320b5b0842
Reviewed-on: https://chromium-review.googlesource.com/898591
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|