kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll 92a0efdf 2022-11-10T19:54:16 Roll vulkan-deps from 41d238c218e5 to c29c532c92db (19 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/41d238c218e5..c29c532c92db Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/525bc38062..68e8327f29 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/6898219141..29c0457cc1 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5b054b4333..0df63661a5 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/6e5bd86b76..3a729c0a9d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8a253a6c5b..f276f028ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Id5545e98d6c7afbfe9e456a3cd85a7a1d4512b59 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4021125 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 3bbc5335 2022-11-03T00:00:00 Adjust copied dylibs in update_chrome_angle.py Bug: angleproject:1944 Change-Id: Idaf4d559262cc87eab2bb251e6ef41fabffcc466 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4013701 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 7f42f858 2022-11-10T16:30:11 Roll Chromium from 37ccb4df2296 to 39ad79434d5e (789 revisions) https://chromium.googlesource.com/chromium/src.git/+log/37ccb4df2296..39ad79434d5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/57e795cf32..646db6f22e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/85968248e1..49ac7cf34a * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6e93fd3d6e..4218f3525a * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/d08f7f8a9a..86213b7902 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/07fb4cc957..23d79d96ee * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8fb5a04597..f091e9c497 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f0b11967c9 * third_party/fuchsia-sdk/sdk: version:10.20221108.1.1..version:10.20221110.0.1 * third_party/r8: 4u_h3wavvDpQ89UVxr4y-TqKXpJQyYX8ih-DH5Dutm4C..2rVb5rDMAwVnV9ra0CSpHAjMqBI4eDQNz_EQ9XFf_60C * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1e3d07407d..85ce7208ae * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/06d80e1d51..4a3820026f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2487dcf252..3e5483c53d No update to Clang. Bug: angleproject:6430,angleproject:7824 Tbr: ynovikov@google.com Change-Id: Ibbbe26901dca64ebe8487d51948836de72ee4bdd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4021124 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 518209e8 2022-11-10T16:37:20 Fix Mac build sprintf was deprecated Bug: angleproject:7824 Change-Id: If261426f1bf4e8d7997f051b87ea4817d1e3a264 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4020418 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll a74159cd 2022-11-10T10:01:51 Roll SwiftShader from a113fba5d946 to dd7bb92b9a7a (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/a113fba5d946..dd7bb92b9a7a 2022-11-09 sugoi@google.com glslang update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I7e032f3af11660c6853e24572ab64a97524e20ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4019325 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bb95fce0 2022-11-09T12:18:57 Roll vulkan-deps from 2758721a15a3 to 41d238c218e5 (27 revisions) Ignore spirv/unified1/spirv.hpp11 in export_targets.py https://chromium.googlesource.com/vulkan-deps.git/+log/2758721a15a3..41d238c218e5 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/5e08deae05..2b2523fb95 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/abc31207bf..edd66a2fc9 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c8e1588cfa..525bc38062 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/52b7c620a5..6898219141 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/256a5e3b6d..5b054b4333 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/226b595aee..8a253a6c5b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I7bb358f8457189656d41a309d30cfbefcd65521a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4015371 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll e50e4535 2022-11-09T07:01:10 Roll Chromium from dbedf281d165 to 37ccb4df2296 (492 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dbedf281d165..37ccb4df2296 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dff033c8c1..57e795cf32 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/737c5727e5..85968248e1 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/023270786d..6e93fd3d6e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/53253f33bd..07fb4cc957 * third_party/android_build_tools/lint: QchUp_CPEekuo_inqr_aTnbotGejxQt4FGgFbQT0qBMC..PwX3e0EPv-j0ip-tcNNfhy3YcFHle4vxKVo-IbTCtZYC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..36d603a00b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6f3d66bae..ae1a708917 * third_party/fuchsia-sdk/sdk: version:10.20221107.3.1..version:10.20221108.1.1 * third_party/r8: szXK3tCGU7smsNs4r2mGqxme7d9KWLaOk0_ghbCJxUQC..4u_h3wavvDpQ89UVxr4y-TqKXpJQyYX8ih-DH5Dutm4C * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1aa169abda..1e3d07407d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/822843c07b..2487dcf252 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ib004f8d6f5d009137f44f8f1def76955deada27e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4015368 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop fbf2d2f3 2022-11-05T23:00:51 Tests: Add Hungry Shark Evolution trace Test: angle_trace_tests --gtest_filter=TraceTest.hungry_shark_evolution Bug: angleproject:7820 Change-Id: I6e83efbb566d512c8e60bd27f00144c8c28593e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4007226 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 9c019cb3 2022-11-08T13:29:08 Vulkan: Features for graphics pipeline library Bug: angleproject:7369 Change-Id: I561cc095dcf2d4c71d24de8a6ca08d45567ad937 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4014519 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 5459baf9 2022-11-05T21:47:12 Tests: Add 1945 Air Force trace Test: angle_trace_tests --gtest_filter=TraceTest.1945_air_force Bug: angleproject:7819 Change-Id: I90ed9e74e206bd6e2d2b1ca0071d8526f582b353 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4007225 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Lubosz Sarnecki e99e40c9 2022-10-11T12:27:18 FrameCapture: Implement shadow memory for coherent buffers. On certain devices like the Pixel 6 it is not possible to mprotect Vulkan allocated memory required for coherent buffer tracking. To overcome this limitation implement a shadow memory for coherent buffers when running FrameCapture that is exposed to the app and syncronized with the Vulkan memory and can be mprotected for coherent buffer tracking. Add a test to determine whether memory protection can be used directly or will require shadow memory. Run this test only on build configurations with assertions enabled. Determine the requirement of shadow memory through a deny list of device manufacturers and models, which is checked against ANGLE's SystemInfo. Add ANGLE_CAPTURE_FORCE_SHADOW environment setting and Android equivalent to force enable shadow memory. Test: angle_end2end_tests --gtest_filter="BufferStorageTestES3.*/ES3_Vulkan" Bug: angleproject:7402 Change-Id: I74b7930259d3bc1846ef96fffa782f8bc553b043 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3945018 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 5a89387b 2022-11-01T10:50:26 Vulkan: Remove the best-practices layer It doesn't produce anything actionable in ANGLE (any more), but is regularly a source of false positives. Bug: angleproject:5336 Bug: angleproject:7470 Bug: angleproject:7795 Bug: b/166641492 Bug: b/166793850 Change-Id: I7fb322386e779c8c1f9a7805eb522926d8780446 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996803 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6402fe70 2022-11-08T14:49:57 Roll vulkan-deps from a7a3fb39310c to 2758721a15a3 (25 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a7a3fb39310c..2758721a15a3 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1a8869e4d1..5e08deae05 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/744279ec78..abc31207bf * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/85a1ed200d..47f2465ee3 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a52de681dd..c8e1588cfa * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e12a8f8cde..52b7c620a5 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3f29209dd6..256a5e3b6d * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/292e6ed021..6e5bd86b76 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/18a0e59294..226b595aee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com,syoussefi@google.com Change-Id: Ibc3c263d09ff2d602ed55cb9b61c501d15696774 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4011232 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 7fefd230 2022-10-20T00:00:00 GL: Adjust APPLE_clip_distance exposure Partial revert of I458cad29c10b9d9193c5233e24bac53361ba104e APPLE_clip_distance cannot be implemented on top of EXT_clip_cull_distance because the former is defined both for ES 2.0 and ES 3.0 while the latter is defined only for ES 3.0. Although some ES 3.0+ drivers allow gl_ClipDistance built-in in ESSL 1.00 shaders, this behavior is not specified so ANGLE should not allow it. Added independent ESSL 3.00 gl_ClipDistance and gl_MaxClipDistances definitions. Adjusted translator unit tests. Bug: angleproject:4452 Change-Id: Ib582ce0ac7ccb65f0200ef1d17eaab0c83b228cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3963745 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 78e28cb8 2022-11-03T11:05:48 Vulkan: Remove glslang fallback ANGLE's SPIR-V generator is battle tested by now. Bug: angleproject:6210 Change-Id: I2ed88642e3ede435e3f906fbd701133be6873fb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4002868 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll f06382aa 2022-11-08T07:02:06 Roll Chromium from 2d52bc63cf90 to dbedf281d165 (524 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2d52bc63cf90..dbedf281d165 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/07e7b8e672..dff033c8c1 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a89eb5a1d4..1a32724f72 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/aabcd87536..d08f7f8a9a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1667ace0e2..53253f33bd * third_party/android_build_tools/manifest_merger: 10z1KegIoj_7T--lXulnk4MUKHMHEo_onhwh_4FvyMQC..1_tPfyswsXgfbNegip6nTy55E2ASlhsRqA2sKhUo01YC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f139a527bc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03b187d9c8..e6f3d66bae * third_party/fuchsia-sdk/sdk: version:10.20221106.3.1..version:10.20221107.3.1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b65f30f26c..d3df9cc536 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cb4b18121b..1aa169abda * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/8581381d92..06d80e1d51 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I904a298aeb121de50ddbbaef13112e56b42e41f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4012344 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 5b218196 2022-11-06T11:39:23 Metal: Remove compilation through SPIR-V Direct metal generation is stable. Bug: angleproject:6081 Change-Id: If9e76f61ad38f2fc9963f0181dfd03c99ffa3e2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4003675 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Alan Zhao e87a62fb 2022-11-07T10:08:35 Explicitly #include <errno> in WaylandWindow.cpp This file refers to the symbols 'errno' and 'EAGAIN' via a transitive include that will be removed in an upcoming libc++ roll. Bug: chromium:1382076 Change-Id: Ife4e65ecffe9b2e526a2b7dce7f48fe836ca742a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4010158 Auto-Submit: Alan Zhao <ayzhao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov 6b3e4d8b 2022-11-07T09:32:33 Ensure replay is at the first frame on startTest(). Currently trials continue from the next frame after warmup, so the frame that they start from fluctuate depending on how the warmup went. This was supposed to be tackled by aligning to frameCount() but the first warmup trial wasn't aligned as it would stop after a condition was reached. Only stop on mTrialNumStepsPerformed % stepAlignment == 0 Bug: angleproject:7671 Change-Id: I0da74d89547eda6e78762ee7745204d0da6fe73a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4008998 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Gert Wollny 98469694 2022-11-02T12:13:35 retrace: better error reporting For a resonable error reporting the output must be captured. Print the output on error only, if it is not written anyway. Bug: angleproject:7800 Change-Id: Ie0ca819b7e269317073f8f1c79819e35a33a4325 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4003220 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Roman Lavrov 67300089 2022-11-07T09:52:14 Improve error messages when failing to load a library. https://groups.google.com/g/angleproject/c/SE6zIKU9LzY/m/WvyFvPW1DQAJ Bug: None Change-Id: Id44d96e14f8cc6607c40c746d51719753f3904dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4008999 Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com>
Yuly Novikov ea86e8a2 2022-11-07T14:33:57 Skip PixelLocalStorageTest.DrawStateReset on Pixel 6 Fails similarly to existing suppressions on Pixel 4 Bug: angleproject:7771 Change-Id: I4b73728827408be71de3f9e9cc2b1808c2cb0597 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4009018 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Stephan Hartmann e64c4493 2022-11-07T15:34:38 IWYU: add unistd.h for access in rx::DeviceVkLinux Bug: chromium:957519 Change-Id: Ie23c3ceb6757ac48f2aca97c8c212103c81d4fda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4009019 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny 335b5aba 2022-11-07T09:28:10 Capture/Replay: Make CaptureMidExecutionSetup param constant There is no need for for the context parameter to be non-constant. Bug: angleproject:7805 Change-Id: I1d998cf40f61a977ebce6d1160a859e082d99688 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4008198 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 109604b8 2022-11-07T09:26:05 Capture/Replay: remove unused context param from scanSetupCalls Bug: angleproject:7805 Change-Id: I4e00876ad6174c15aaa9503cf9eeaa6ea041c2a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4004416 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Kimmo Kinnunen c47e7711 2022-11-04T10:32:14 Metal: remove duplicate code in RenderPassDesc conversion Remove duplicate code that was due to a rebase error in "Metal: Remove use of ANGLE_MTL_AUTORELEASE from mtl_state_cache" 415ff51b8005ab462c3bd883dff75d31499132dc Bug: angleproject:7813 Bug: angleproject:6833 Change-Id: If4af7a49033f31dfa1e10571388e8ad9922939e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4003223 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll 9586397e 2022-11-07T07:00:17 Roll Chromium from 1deca0664729 to 2d52bc63cf90 (559 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1deca0664729..2d52bc63cf90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0933725ae1..07e7b8e672 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/404e2d0fd7..737c5727e5 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/08ea445fb5..023270786d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8dd405113a..a89eb5a1d4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c35cc644af..1667ace0e2 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ec71abc88f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8fbdc51e88..03b187d9c8 * third_party/fuchsia-sdk/sdk: version:10.20221103.1.1..version:10.20221106.3.1 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/74a5a82d3c..8bbd6c3129 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e95c0f2f1f..b65f30f26c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9e98d9528f..822843c07b Clang version changed llvmorg-16-init-9369-g87a20868:llvmorg-16-init-8697-g60809cd2 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/e95c0f2f1fcc9283d39ea67bc31e7c8fffd9a7ec..b65f30f26caa72a66eb1ffe6d87d5b158c492b28/scripts/update.py Bug: None Tbr: syoussefi@google.com Change-Id: Id01d54cdcdaa09c20de8a74d05f9f53fe3fc2c0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4007863 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 9bda9a79 2022-10-22T22:05:11 Add Store Ops to pixel local storage Browsers will need the ability to pre-empt pixel local storage, which means every plane will need a backing store to dump to. Store Ops allow the app to still avoid memory transactions at the end of PLS even if their plane has a backing texture. Bug: angleproject:7279 Change-Id: I3a3efa21773f87c03cd346a996e3c638028c68ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3974652 Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Chris Dalton 54f29c4a 2022-11-04T09:57:36 Suppress PixelLocalStorageTest.ClearState on iOS (simulator) Update the suppression after a rename of the test. Bug: angleproject:7756 Change-Id: Ia389b87d9ca2356b0a76c1a2d389bc8f5e1eed7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4006413 Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jason Macnak a032bd10 2022-11-04T10:36:07 Vulkan: Handle extension enumeration returning less than requested Speculative fix for b/249457381 where we have previously seen extensions enabled/disabled based on settings which may be loaded/changed between vkEnumerate*() calls. Bug: b/249457381 Change-Id: I36aa8aec38037ff3d8c9a036d27289e1abb930fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4006713 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki 7fa69511 2022-11-04T10:10:05 FrameCapture: Skip glGetActiveUniformBlockName calls. Since moving to plain C traces removed references to uniform block indices, this call should also be part of the related skip list. This fixes capturing traces using the call an not hitting UNREACHABLE when handling TUniformBlockIndex. Bug: angleproject:7731 Bug: angleproject:7402 Change-Id: I510aceaa0965c2469367212784b504ea251a2541 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4003222 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 076eb661 2022-11-04T07:00:13 Roll Chromium from 1d02faaf3aaa to 1deca0664729 (253 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1d02faaf3aaa..1deca0664729 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/18e9d3c3ad..0933725ae1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3af95eaf05..c35cc644af * third_party/android_build_tools/bundletool: JUxLsQLBkNG0ylmbHz6FGBtYyK1PNDZ04pMCii90Bd4C..nrReBqFfE2B7DUv3RveTRIE4K9O3MJft7pP-iRhoRQ4C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..904b902a75 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b52683fa2e..8fbdc51e88 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/cff720848d..74a5a82d3c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b147cbb71c..e95c0f2f1f * tools/luci-go: git_revision:765f51c332c38e9b8d7981f23640b9df59371cd5..git_revision:f8f64a8c560d2bf68a3ad1137979d17cffb36d30 * tools/luci-go: git_revision:765f51c332c38e9b8d7981f23640b9df59371cd5..git_revision:f8f64a8c560d2bf68a3ad1137979d17cffb36d30 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8d38ebbb90..cb4b18121b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3ab161438c..9e98d9528f * tools/skia_goldctl/linux: 96rKSNFMICaC-zy3dzFRxE3xkMm8mIPbR6pxbfHXZysC..VJBQvPCDWNHadBXHtx4iViP5ju0oF2ZlEK5Zle80ZVUC * tools/skia_goldctl/mac_amd64: BTXwaBdnwpgPkzCAT5gTk0xV0_vzeR2q_icN_le7NBIC..1EpS2K-VevNOMzNiw1LmYktlqKVv1SyqDm2q4DRQtNkC * tools/skia_goldctl/mac_arm64: r0TJJDCO6SDuVGZoUBvAzDe7hACLXwX3fWH6tvNkYAAC..SXjqn6JoFOUmIaVPnyQWa19dyUeEb00rdwMuL9feyvoC * tools/skia_goldctl/win: IffTHOl24SBx-1fnxVM5kaNaOA8mS_3urxANjmbsZWUC..GXa5gfPznAu49j4sXrqFvYWFSD0LTIB_TVal2oqGlAIC No update to Clang. Bug: angleproject:6430 Tbr: syoussefi@google.com Change-Id: Ib46cf1b0ff2465fecc44e4cf204757e81342fe5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4004811 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 3605b399 2022-10-20T17:00:02 Move PLS clear values back into context state The API that required packing raw data into a buffer was un-ergonomic for developers and difficult to implement for WebGL vendors. Bug: angleproject:7279 Change-Id: If7c98908c285462c5775e8e2d8811883be139f64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3972376 Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kenneth Russell 3226cce3 2022-11-02T16:02:46 Update EGL_ANGLE_metal_shared_event_sync implementation. Rename the extension's .txt file to match the current name of the extension. Update function signatures to take EGLSync rather than EGLSyncKHR. The two types are conceptually incompatible. This extension requires the use of eglCreateSync rather than eglCreateSyncKHR because the latter takes an array of EGLInt, but EGLAttrib is needed to express pointers (to MTLSharedEvents) in the attribute list. Revise ContextMtl::flush to use WaitUntilScheduled on older operating systems not supporting MTLSharedEvent. Bug: angleproject:7809 Change-Id: I39197616dc3e1e7ec6dc68dd83b4fde05184debf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4000941 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
angle-autoroll e449439e 2022-11-03T19:31:27 Roll Chromium from 35e93669b8f2 to 1d02faaf3aaa (59 revisions) https://chromium.googlesource.com/chromium/src.git/+log/35e93669b8f2..1d02faaf3aaa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/33b52eafd5..404e2d0fd7 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/fc6bbc5eb0..08ea445fb5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/aedf4723b9..3af95eaf05 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..67ccd32ad3 * third_party/fuchsia-sdk/sdk: version:10.20221103.0.1..version:10.20221103.1.1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/458fbce5e4..3ab161438c No update to Clang. Bug: None Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: Ic465ac476f41e0288fb394560ee779430a2e1b70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4004438 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Robert Mader dd560015 2022-09-28T14:40:01 Reland "Vulkan: Implement EGL_EXT_device_drm[_render_node]" This is a reland of commit 8900cbf96a3127880b1667d2242dc13a98cfe029 Original change's description: > Vulkan: Implement EGL_EXT_device_drm[_render_node] > > These extensions are needed by Exo for zwp_linux_dmabuf v4 support. > > Unfortunately `VkPhysicalDeviceDrmPropertiesEXT` doesn't give us the > information about the filesystem layout, needed by the EGL version. > As ChromeOS is currently the only user, implement the extension only for > Linux where we can reasonably assume `/dev/dri/...` file paths. > > We do not, however, limit us to the GBM backend - having the extension > working in e.g. a nested X11 or Wayland environment is quite helpful. > > Bug: angleproject:7686 > Change-Id: I6de14e68ffbc479450bd22a182bc138365efb516 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996703 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7686 Change-Id: I66dfd7aa51f76cb9668dbfbd0f3e1f32123bff7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4003941 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 378dc05d 2022-11-03T18:24:44 Roll Chromium from 5da1d1188b33 to 35e93669b8f2 (226 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5da1d1188b33..35e93669b8f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/28d5cfef0c..18e9d3c3ad * testing: https://chromium.googlesource.com/chromium/src/testing/+log/bb14009be1..aedf4723b9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3ffa6b2228 * third_party/fuchsia-sdk/sdk: version:10.20221102.0.1..version:10.20221103.0.1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a6e8570835..458fbce5e4 No update to Clang. Bug: None Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: I856029108fe5a0353d52132b5777ecc6ae9b7ce3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4004437 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 71d28a9b 2022-11-02T13:19:20 Vulkan: Remove unused ShaderAndSerial The serial in the ShaderAndSerial is unused. This CL removed ShaderAndSerial and replaced with ShaderModule directly. Bug: b/257116399 Change-Id: I50d42af7818a12888309a80423531d75135e0bfd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3998747 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 9340f01d 2022-11-03T00:00:00 Metal: Restore load actions after attachment updates Framebuffer invalidation sets attachment load actions to MTLLoadActionDontCare. Restore them to MTLLoadActionLoad after content changes, which may be caused by texSubImage uploads. Fixes: * SimpleStateChangeTestES3.InvalidateThenSubUploadThenBlend * conformance2/renderbuffers/invalidate-framebuffer.html Bug: angleproject:7397 Change-Id: I8a1b223c92b1fd082f4961161efafaf6b60f8698 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4001808 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi 319f8228 2022-11-03T16:58:07 Revert "Vulkan: Implement EGL_EXT_device_drm[_render_node]" This reverts commit 8900cbf96a3127880b1667d2242dc13a98cfe029. Reason for revert: anglebug.com/7811 Original change's description: > Vulkan: Implement EGL_EXT_device_drm[_render_node] > > These extensions are needed by Exo for zwp_linux_dmabuf v4 support. > > Unfortunately `VkPhysicalDeviceDrmPropertiesEXT` doesn't give us the > information about the filesystem layout, needed by the EGL version. > As ChromeOS is currently the only user, implement the extension only for > Linux where we can reasonably assume `/dev/dri/...` file paths. > > We do not, however, limit us to the GBM backend - having the extension > working in e.g. a nested X11 or Wayland environment is quite helpful. > > Bug: angleproject:7686 > Change-Id: I6de14e68ffbc479450bd22a182bc138365efb516 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996703 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7686 Change-Id: I703351e93c4befbd3415b9ba04730066ee9c6afd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4003857 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Brian Sheedy f98eecda 2022-11-02T13:05:40 Migrate ANGLE regexp filters Migrates the ANGLE trybot location filter regular expressions to use the newer lucicfg format. The old version was automatically translated to the new version under the hood so this is functionally a no-op change, but this brings the non-generated code in line with now new filters should be added. Bug: chromium:1380568 Change-Id: I5f0c8ece5015d2fc3bdb456fbe2499a335663d79 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4000546 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Robert Mader 8900cbf9 2022-09-28T14:40:01 Vulkan: Implement EGL_EXT_device_drm[_render_node] These extensions are needed by Exo for zwp_linux_dmabuf v4 support. Unfortunately `VkPhysicalDeviceDrmPropertiesEXT` doesn't give us the information about the filesystem layout, needed by the EGL version. As ChromeOS is currently the only user, implement the extension only for Linux where we can reasonably assume `/dev/dri/...` file paths. We do not, however, limit us to the GBM backend - having the extension working in e.g. a nested X11 or Wayland environment is quite helpful. Bug: angleproject:7686 Change-Id: I6de14e68ffbc479450bd22a182bc138365efb516 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996703 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Chris Dalton 5e95a4d9 2022-10-07T00:52:38 Add an EXT_shader_pixel_local_storage impl of PLS Translates ANGLE_shader_pixel_local_storage shaders directly to EXT_shader_pixel_local_storage. Polyfills load/store operations using internal fullscreen draws. Since the ANGLE extension needs the ability to preserve all active PLS planes to textures, we can only support this extension when the backend context also has access to ES 3.1 shader images. Bug: angleproject:7279 Bug: angleproject:7771 Change-Id: Id348bde412efcc081ff29ee05ec59ad652f77569 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3966075 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 9a6d7f89 2022-11-03T10:01:58 Roll SwiftShader from da2edceb04a8 to a113fba5d946 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/da2edceb04a8..a113fba5d946 2022-11-02 nicolascapens@google.com Revert "Increase subPixelPrecisionBits from 4 to 8" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I88387bdd4fec617631b0e3c819abe6423f3c2f7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4000654 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ece066f9 2022-11-03T07:00:32 Roll Chromium from 2c98c5af6539 to 5da1d1188b33 (352 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2c98c5af6539..5da1d1188b33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f75f7c9503..28d5cfef0c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1a1a839b38..bb14009be1 * third_party/android_build_tools/aapt2: nSnWUNu6ssPA-kPMvFQj4JjDXRWj2iubvvjfT1F6HCMC..-QrdsGmvVhHeoRc5wKCnU2LXEjk1s0ocheitXWf5dhYC * third_party/android_build_tools/lint: oJIo5mCU1gyxTf-EnMPZXg_GG2-3YOE_xUWXtmwO96IC..QchUp_CPEekuo_inqr_aTnbotGejxQt4FGgFbQT0qBMC * third_party/android_build_tools/manifest_merger: xd-wXGBtd-G1FJXc_owo3j_wxWs4YxgOfQ-tKWHwN5AC..10z1KegIoj_7T--lXulnk4MUKHMHEo_onhwh_4FvyMQC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3ffa6b2228 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1adbbff2c0..b52683fa2e * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/fc8e0bd892..0873b2bae6 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/88b5767779..8d38ebbb90 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/fe7aa52821..a6e8570835 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Iceb84e88d9ddcdaa456c0ce8dcba753e4b7b7ae4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4000298 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny a55c5315 2022-11-02T10:43:08 translator: handle tesselation shaders when force-init outputs Bug: angleproject:7804 Change-Id: Ie3565c1fa1a3563192eb2faf3830883f2788b77a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3998632 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll a48a2c7a 2022-11-02T18:04:35 Roll Chromium from c8d10c0b09ab to 2c98c5af6539 (5653 revisions) Manually copying third_party/flatbuffers from Chromium, with one small modification: libs = [ "log" ] in "flatbuffers_unittests" BUILD.gn Also, forcing MSVC builds to use C++17 instead of C++20. https://chromium.googlesource.com/chromium/src.git/+log/c8d10c0b09ab..2c98c5af6539 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ef3d15e613..f75f7c9503 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5c1eeb8715..33b52eafd5 * buildtools/linux64: git_revision:57c352b2b03461c24b19c678c61d7aeacc6981f4..git_revision:a4d67be044b42963de801001e7146f9657c7fad4 * buildtools/mac: git_revision:57c352b2b03461c24b19c678c61d7aeacc6981f4..git_revision:a4d67be044b42963de801001e7146f9657c7fad4 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/888eff8ec2..fc6bbc5eb0 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/685c4ad257..8dd405113a * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/1f633d41a0..aabcd87536 * buildtools/win: git_revision:57c352b2b03461c24b19c678c61d7aeacc6981f4..git_revision:a4d67be044b42963de801001e7146f9657c7fad4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/50f814ce03..1a1a839b38 * third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/872ba9e68a..4838827d12 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3027824279..8fb5a04597 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/4f07dd5cca..216373bd26 * third_party/android_build_tools/bundletool: sSBNyeRs5Px7nKXDLyQpz24T_OV9_rUkzqgXRNEaH0kC..JUxLsQLBkNG0ylmbHz6FGBtYyK1PNDZ04pMCii90Bd4C * third_party/android_build_tools/lint: PgXTfxO_ExRhHwuAVaMUh48zDVj5bqVPSjecGWZ8TQIC..oJIo5mCU1gyxTf-EnMPZXg_GG2-3YOE_xUWXtmwO96IC * third_party/android_build_tools/manifest_merger: lgqr-qkYSNJxPdYaRg1beYU6to-4LBuHBw3WVO7_ancC..xd-wXGBtd-G1FJXc_owo3j_wxWs4YxgOfQ-tKWHwN5AC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/94f1169192..e8b385d860 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3ffa6b2228 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/64b6175557..1adbbff2c0 * third_party/fuchsia-sdk/sdk: version:10.20221018.0.1..version:10.20221102.0.1 * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/ee69aa00ee..4633bf4311 * third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/1b882ef637..13f4e8c9e2 * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/5fd9246276..fc8e0bd892 * third_party/r8/d8: 9PJITrOEIl2U8mvr44d5e9XjOdvzRPuF774VA3jWOsYC..qGtBu6TtxyR5XNy4cmsslb7c946YtkZF5_QCjVP-wc8C * third_party/turbine: rrpgWQ-uylo8c5IPgUVP464LwcVOmt29MqwsR59O_zkC..HqLybI_r3dCgRJywsqJ3xkp2D6vQAI4-8D7zdqNiyxcC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d689fca54d..cff720848d * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2619cde247..b147cbb71c * tools/luci-go: git_revision:0b4ca85948120a9e07c81e06386c031a693724c4..git_revision:765f51c332c38e9b8d7981f23640b9df59371cd5 * tools/luci-go: git_revision:0b4ca85948120a9e07c81e06386c031a693724c4..git_revision:765f51c332c38e9b8d7981f23640b9df59371cd5 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cac69ccc90..88b5767779 * tools/md_browser: https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/7ff27244f2..de79b55b74 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/98140a6948..8581381d92 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7ab82e1fdc..fe7aa52821 * tools/skia_goldctl/linux: t3TPrZYHYFYj-Uycz4891UuvI29G25cnOuAXx4YKTJEC..96rKSNFMICaC-zy3dzFRxE3xkMm8mIPbR6pxbfHXZysC * tools/skia_goldctl/mac_amd64: pkodJRDmOHJK-oKhKr3YyRBH-aZDOifqq2f39tyYYkwC..BTXwaBdnwpgPkzCAT5gTk0xV0_vzeR2q_icN_le7NBIC * tools/skia_goldctl/mac_arm64: MGH9P0-cwU4UFOV-4rkxKLBFEVtXIE8vtynMsKM4O4UC..r0TJJDCO6SDuVGZoUBvAzDe7hACLXwX3fWH6tvNkYAAC * tools/skia_goldctl/win: -y4QQFDzRbkTKhmiP7CqEhagCHKtWFdfxwAK6anUvfAC..IffTHOl24SBx-1fnxVM5kaNaOA8mS_3urxANjmbsZWUC Clang version changed llvmorg-16-init-7184-gdeb82d4a:llvmorg-16-init-9369-g87a20868 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/2619cde247bf037c2afa19b0913cccddac12ccbd..b147cbb71c13c6fec5da3d91b99f3a408c5eb07c/scripts/update.py Bug: angleproject:4242,angleproject:4417,angleproject:4846,angleproject:5505,angleproject:6430 Bug: angleproject:7788, chromium:1380553 Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: Ia1f563f1dc5227b2cbb42ac05f5f7f40e47a4168 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4000540 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Solti 809a4ff2 2022-11-01T16:16:45 add tips in ANGLE wrangling doc Bug: angleproject:1944 Change-Id: I9b5b7968453d55aab000608a44c2790eea4496b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3995491 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 1b88c41f 2022-10-31T10:58:09 Vulkan: Remove the disableFifoPresentMode feature Workaround was added for old Intel bots, no longer applicable. Bug: angleproject:3153 Change-Id: Ib248927fbb1be33d8bd89a0c8185761f7f1ed6fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3993361 Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yiwei Zhang 8f420fd0 2022-11-01T18:51:41 Repurpose enableCompressingPipelineCacheInThreadPool For platforms with a higher blob cache limit, say 32MB, compressing the bigger pipeline cache data is better delegated to a background thread. This change repurposes this default disabled workaround as a feature for such platforms. This change also enables enableCompressingPipelineCacheInThreadPool for mesa venus driver. Bug: b/246683126 Test: apps runs normally and cts passing Change-Id: Ied1d9b3ee351f71abedeed04d21c700c1ad7cd18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3997592 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ace3c97f 2022-11-02T10:01:48 Roll SwiftShader from e6504a2a091c to da2edceb04a8 (12 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/e6504a2a091c..da2edceb04a8 2022-11-01 capn@google.com Guard against pSparseMemoryRequirements == NULL 2022-11-01 swiftshader.regress@gmail.com Regres: Update test lists @ dc3b53ab 2022-11-01 capn@google.com Increase subPixelPrecisionBits from 4 to 8 2022-11-01 capn@google.com infra: Update lucicfg generated files 2022-11-01 capn@google.com infra: Make tryjobs run on change upload 2022-11-01 capn@google.com Move state variables from Spirv to SpirvShader 2022-11-01 capn@google.com Rename SpirvShader to Spirv 2022-11-01 jbauman@google.com Remove libz.so from llvm dependencies 2022-11-01 sugoi@google.com VK_KHR_global_priority implementation 2022-11-01 capn@google.com Default to masking stores in helper invocations 2022-11-01 swiftshader.regress@gmail.com Regres: Update test lists @ b3efa1fb 2022-11-01 sugoi@google.com Manual dEQP update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I559f6514f3d9caaffca25401fdf002a9be5be1f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3999031 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 86d9d876 2022-11-01T22:21:52 Finish renaming GL_PIXEL_LOCAL_STORAGE_ACTIVE_PLANES_ANGLE Fix a couple spots that missed the rename. Bug: angleproject:7797 Change-Id: Iee44b525f70e00e631e07ec2e984c7a41c3b616a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996109 Reviewed-by: Steven Noonan <steven@valvesoftware.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Calvin Watford 71e13e19 2022-11-01T16:08:23 Update Mesa build variable usage `angle_mesa` was changed to `checkout_angle_mesa` in https://crrev.com/04cf49bc56af06d60ae236bc4fc747ff384970ef This change updates the usage of that variable as well. Bug: angleproject:7689 Change-Id: I6e3cead558f285c29f968f5289de07e8b811d525 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996186 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll a12c00a1 2022-11-02T11:01:46 Roll vulkan-deps from 66e533688e2a to a7a3fb39310c (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/66e533688e2a..a7a3fb39310c Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/677299cc56..744279ec78 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a17d7fc737..3f29209dd6 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/918d534ffd..18a0e59294 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I8a36482fcecbaa022b0f8854c0361a1be99088ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3999052 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny e3d0bee6 2022-11-01T13:54:16 retrace: Check for the output json file after upgrade To check the success of writing a new trace we have to look in the output directory, otherwise even skipped traces will report success. Bug: angleproject:7800 Change-Id: Icd2d79c3ebe55cd02f55635b1ccf48d19f46acea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996704 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Cody Northrop bae82cfa 2022-10-31T17:11:45 TraceTest: Route eglGetError through WGL eglGetError is not implemented, but shouldn't crash on Windows. Bug: angleproject:7799 Change-Id: I61158ab21b86539020b5d492486333a56908ab69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3995984 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Sean Risser f3e047b5 2022-10-12T16:28:32 Add new retrace command get_min_reqs `retrace_restricted_traces.py get_min_reqs` finds the minimum required GLES version and extensions and record them to a trace's json file. TracePerfTest has also been modified to use the new "RequiredExtensions" json field to determine if it should run a test or not. This allows several lines to be removed from TracePerfTest's constructor. get_min_reqs uses a divide-and-conquer strategy to find the extensions. This approach should be faster for traces where the number of required extensions is less than 20. This adds a new command to retrace_restricted_traces.py called get_min_reqs. This runs an existing trace multiple times to find what the minimum required GLES version is, then records that version to the trace's json file. Bug: angleproject:7639 Change-Id: I42530e438054efec1ad79ababebe06d221d5c695 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3884175 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Sean Risser <srisser@google.com>
Akihiko Odaki 31a090ca 2022-11-01T22:09:44 Debug: Handle LOG_EVENT on Apple platform Trace() lacked the code path to handle LOG_EVENT for Apple platform, leading to the "unreachable" code path. Fix the problem by logging the message as info-level with the OS interface, as done for Android. Bug: angleproject:7802 Change-Id: I45811102c07c9f65c5a828f71c37bd8d0cd672e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996521 Auto-Submit: 小田喜陽彦 <akihiko.odaki@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Chris Dalton 9f693aa3 2022-10-22T14:45:59 Implement an allow list for PLS In order to guarantee no data is lost while using the EXT_shader_pixel_local_storage extension, we need to restrict applications to a small subset of commands while pixel local storage is active. This CL implements the allow list for GL entrypoints using wildcard matching inside the code generator, and adds custom validation for the more specific restrictions that go into effect when PLS is active. Bug: angleproject:7279 Change-Id: I5dd48bd93c10e8775f32be32a4fcf17855eb2f0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3932552 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
angle-autoroll 1acf7572 2022-11-01T10:01:17 Roll vulkan-deps from af6c033bca19 to 66e533688e2a (81 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/af6c033bca19..66e533688e2a Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/5755de46b0..1a8869e4d1 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/f09ba27777..677299cc56 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b53d3a6be3..a52de681dd * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/98f440ce68..e12a8f8cde * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/61187c4084..a17d7fc737 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e52fa1cf2d..292e6ed021 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/273665ad0d..918d534ffd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Iece8a131dc487c5c610217b2bdc20cc45b451cd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996464 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fbf54cd6 2022-11-01T10:01:27 Roll SwiftShader from cd9da0fefcef to e6504a2a091c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/cd9da0fefcef..e6504a2a091c 2022-10-31 brunopitrus@hotmail.com Use sw::bit_cast<> for type punning If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I1e058a1c4846113fe0b869b315d0bb7f0ef2a855 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996308 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 9737c632 2022-10-24T11:34:51 retrace: Add --show-test-stdout arg to validation This argument is checked when running validation, so we have to define it. Bug: angleproject:7800 Change-Id: Ia24a8c8a82a8bdcefcf707bd9c9183ead4ee095d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3990622 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 7ea302b6 2022-10-31T09:21:18 Capture/Replay: Special-case EGL image attribute pointer write If we don't special case this, the taken code path may end up writing "(nil)" if we have a null pointer, and compilation of the test will fail. Bug: angleproject:7793 Change-Id: Ic9fe9ccca0304069adbbb996666bc643e7d29278 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3990758 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Gert Wollny 822471f0 2022-10-24T08:08:03 retrace: Add a catch-all clause to report all errors With that running the a batch of tests from an external script can bail out early when a trace fails. Bug: angleproject:7800 Change-Id: I5041e863a8cdc212b7057b88e3f0fd68a5115470 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3990621 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 27561f04 2022-10-30T09:38:00 Capture/Replay: Emit always gContextMap2 when capturing traces Bug: angleproject:7800 Change-Id: I12fc39d709527865a9b248a00c95d281c4e4d743 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3993317 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexey Knyazev adcda453 2022-11-01T00:00:00 Suppress new clip distance tests on iOS Bug: angleproject:7768 Change-Id: Ib61efbb97dd9d6b238d4a59fc50983515f9d89fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3996442 Auto-Submit: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Shahbaz Youssefi 67ee4976 2022-10-31T15:34:19 Vulkan: Skip BestPractices-ImageBarrierAccessLayout Bug: angleproject:7795 Change-Id: I98f6840f9cd2956f7e73d0496a26f504516c48e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3993364 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev 805e00b8 2022-10-27T00:00:00 D3D11: Add clip and cull distance support Added gl_ClipDistance and gl_CullDistance support to HLSL translator. Added enabled clip distance GL state emulation. Added limitSimultaneousClipAndCullDistanceUsage limitation. Expanded and optimized related end2end tests. Bug: angleproject:4452 Change-Id: Id66312505254ceff43d5258d486ddcdb0462db47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3990944 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi 7b102c18 2022-10-31T10:29:45 Vulkan: Disable logicOp dynamic state on Intel/Mesa Hits a stack overflow inside the driver. Bug: chromium:1379201 Change-Id: I52e5254b37688a027cbcf5ee5752de36b9b2a3aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3993360 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 9d9b8b07 2022-10-24T15:56:42 Docs: Fix up trace replay options The restricted_traces README was missed in prior update. Bug: angleproject:7755 Change-Id: I65380ef902d3b8a39cec16829c3e0e8170e2667b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3975599 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 1d6f100b 2022-10-31T14:26:55 Roll VK-GL-CTS from bfc5b6f54270 to acb25bf242c3 (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/bfc5b6f54270..acb25bf242c3 2022-10-28 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkansc-cts-1.0.1 into vk-gl-cts/main 2022-10-28 ziga@lunarg.com Fix compile error 2022-10-28 ziga@lunarg.com Add more VK_EXT_depth_clip_control tests 2022-10-28 piotr.byszewski@mobica.com Add MSAA tests for fragment_shader_barycentric 2022-10-28 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.4 into vk-gl-cts/main 2022-10-26 piotr.byszewski@mobica.com Update vulkan-docs version 2022-10-18 gleese@broadcom.com Update to the latest glslang If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I20dfde0ca47e1736c3247d5d16827d99dd06bfb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3994282 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 70132045 2022-10-31T10:01:27 Roll SwiftShader from e8d4f9f4d703 to cd9da0fefcef (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/e8d4f9f4d703..cd9da0fefcef 2022-10-28 swiftshader.regress@gmail.com Regres: Update test lists @ e8d4f9f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ic929b45d4dd51f95e68dd1a2ea8fee15afa7369c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3992894 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chia-I Wu 32fb3be6 2022-10-27T16:05:30 Vulkan: disable rasterization order feature if isQualcomm It is simpler to just disable it for Qualcomm. Bug: b/255837430 Change-Id: I884a9635ed2c6049fa4f79e10613f87f3f40f199 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3989644 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Chia-I Wu <olv@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Chia-I Wu 5fc46a22 2022-10-27T16:02:31 Vulkan: Specify rasterization order only when there is fb fetch The original change had a performance impact on Qualcomm open source driver on some traces trex_200 22ms -> 39ms car_chase 80ms -> 190ms because it is expensive to make fb fetch coherent on Qualcomm hardware. This fixes the regression by making sure we specify the rasterization order only when there are indeed fb fetches. But we believe other workloads can still be hit by the issue even after this fix. We will disable rasterization order for Qualcomm driver in the next commit. Bug: b/255837430 Change-Id: If240dcbfd73112a72dc1e537821636ca16290eaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3989166 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Chia-I Wu <olv@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Chris Dalton <chris@rive.app>
Jamie Madill 04cf49bc 2022-10-28T00:16:08 Update Mesa build variables. For gclient: angle_mesa -> checkout_angle_mesa For BUILD.gn: build_angle_mesa gets set automatically. Bug: angleproject:7689 Change-Id: I89ff8a54fc87d9fb28ac998331ffbd0d8eb246ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3989923 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu ce62d52f 2022-10-27T18:41:11 Fix Mid Execution Capture for External Texture How we capture eglCreateImage and eglCreateImageKHR have changed recently. Fix the code that recreate eglCreateImageKHR calls for external texture type in Mid Execution Capture. Bug: angleproject:7758 Change-Id: I2bd35ec3349f1d4f1aef1bf7f76ac50d4abca53d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3989645 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Tiago Vignatti 4abae6f9 2022-10-28T11:09:15 Metal: Fix 8-bit type name This fixes a probable typo for the 8-bit unsigned integer value type. Test: build ANGLE with Metal renderer enabled on iOS. Bug: None Change-Id: I2a332d996633fd81d01eece75817efb5683a5b31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3989426 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Yiwei Zhang fd3bfb77 2022-10-27T23:18:46 EGLWindow: workaround eglQueryString behavior before Android 10 EGL_NO_DISPLAY + EGL_EXTENSIONS returns NULL before angle support introduced in Android 10. See aosp/760681 for the reference. Bug: b/255844932 Test: build and run angle trace on Android Pie Change-Id: I23a8236cbd220ce34ebbcc602d6ced351fc76619 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3988422 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev ac5a9c53 2022-10-26T00:00:00 Metal: Optimize ReplaceClipCullDistanceVariable The intermediate ANGLEClipDistance variable is not needed when generating MSL output directly. Bug: angleproject:6291 Change-Id: Ie3d32a903645be002f21c44a6233f9cd0155605a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3981716 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Jamie Madill a9868110 2022-09-15T17:29:04 Add support for testing with Mesa + Zink. To run a trace test with zink, use --use-gl=zink. Bug: angleproject:7689 Change-Id: I70073756f903db1c224fe6175d55be4cad637aca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3899382 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill d19f8725 2022-10-27T18:08:34 Disable more options in libdrm. Disables man page building and valgrind, for more compatibility. Bug: angleproject:7689 Change-Id: I6249164fa39f3c6dae3b80b4f63c365cb87ddaf5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3988104 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 41184c21 2022-09-29T10:50:39 Add support for building Mesa + Zink. Uses a conditional gclient variable "angle_mesa". You must set this to True in your .gclient to download and configure Mesa. After that you must also set angle_build_mesa=true in your GN args. We call through to meson in order to setup and build. Mesa sources and targets are written into an auto-generated GNI file. We must update this file on the same cadence as Mesa rolls. Because the version of libdrm we use in our sysroot is older than Mesa requires, this CL also includes a custom libdrm build. Also in order to run bison and flex on the old sysroot that Chrome infra runs with, this CL includes a new version of flex and bison that run without newer versions of GLIBC. Bug: angleproject:7689 Change-Id: I1aeeda1e6f3cf1d5f878aeab5209afa7e1fb5324 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3933062 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll f9071973 2022-10-27T10:01:51 Roll SwiftShader from 5634e136d794 to e8d4f9f4d703 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/5634e136d794..e8d4f9f4d703 2022-10-27 capn@google.com Assert VkInstanceCreateInfo::flags is 0 2022-10-26 sugoi@google.com Handle all Vulkan 1.2 promoted structures 2022-10-26 capn@google.com Regres: default to 100 tests per process 2022-10-26 rjodin@chromium.org libVulkan.cpp: add missing struct in vkCreateDevice 2022-10-26 sugoi@google.com Update go tools to go 1.18+ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I8ecacac96bc9c1ce12813e82bf485b34a35c19ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3985688 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 2bc9f1f4 2022-10-26T10:38:02 Lazily create threads in the thread pool The Vulkan backend doesn't use thread pools normally, so creating threads is a waste of CPU time. Additionally, creating threads early causes issues with some sandboxing strategies. Bug: b/250688943 Change-Id: I33f1b73bdc62f6a0c0b2277ce99ba78a87464486 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3982174 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 6bef0630 2022-10-24T10:46:09 Exit on nullptr returned from decompress callback. Decompression failures appear to happen (very) occasionally, resulting in a weird stack trace later down the road. Bug: None Change-Id: I12780f462c7d1a141d0841e1e07acb2d282077e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3970768 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Sean Risser 9b9d8032 2022-10-19T14:57:03 Avoid mExtensions for initializing mExtensions tracks the currently enabled extensions, while nativeExtensions tracks which extensions are available on a platform. This makes nativeExtensions more suitable for initializing data, as extensions may be disabled at initialization and enabled later. Bug: angleproject:7769 Change-Id: I9ee821a931045fc89091473f35e2b306ee653613 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3965610 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Sean Risser <srisser@google.com>
Roman Lavrov a77a80a1 2022-10-25T13:54:33 Wait for DestroyNotify and ConfigureNotify events. There appears to be a race condition where XDestroyWindow+XCreateWindow ignores the new size (the same window normally gets reused but this only happens sometimes on some X11 versions). Wait until we get the destroy notification which should avoid races between termination and initialization. However, it turns out just doing that breaks things because tests get to termination before even giving the window a chance to set up fully (e.g. ConfigureNotify) which only happens after making the window visible.. so additionally block in setVisible until we get ConfigureNotify. aaand turns out RobustBufferAccessBehaviorTest requires setVisible(true) - tests fail when running on my local Linux and pass now that I added setWindowVisible! Bug: angleproject:7620 Change-Id: I93f2f05cb9d1c62776636bec976d94ead4cf0fd1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3979168 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll e8a1e409 2022-10-26T10:01:11 Roll SwiftShader from ea3fc74f3d69 to 5634e136d794 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/ea3fc74f3d69..5634e136d794 2022-10-26 capn@google.com Move format support checks to vk::PhysicalDevice 2022-10-25 swiftshader.regress@gmail.com Regres: Update test lists @ 8aff0c1f 2022-10-25 sugoi@google.com Propagate error to AnalyzeOutput 2022-10-25 sugoi@google.com Temporarily fix dEQP pipeline depth stencil tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Iedaf6936d133b6389a4dd0d87542120d5f4c2a4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3980003 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 53abcf15 2022-10-25T15:26:44 Vulkan: Bug fix in supportsTimestampSurfaceAttribute Move the initialization of "vkGetPastPresentationTimingGOOGLE" and the assert check to after vkDevice creation. Bug: angleproject:7489 Change-Id: I1ef50d64af3bea44a182be95dd182532b2c60d36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3979994 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Greg Schlomoff 81a244de 2022-10-10T15:32:25 Adding a class to perform ASTC texture decompression on the CPU This significantly improves performance by caching and re-using the ASTC decoder context, and using multi-threaded decompression. This code was originally written for gfxstream. Bug: b/250688943 Change-Id: I1727447907f2e25cf9b854ffcc9ccfc04db2fb91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3929008 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 1c197e06 2022-10-24T16:53:01 Remove dEQP suppression for tests that already passed Bug: b/224537784 Bug: angleproject:6898 Bug: angleproject:6910 Bug: angleproject:6918 Change-Id: I25f1d0d6fb3147d11cdf352290a683beed5082f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3976789 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Geoff Lang 0c711639 2022-10-25T11:56:12 Add flatbuffers to the tracked chromium deps. Bug: angleproject:7788 Change-Id: Ic126178722a8d58247819af0e4ee83f8be7faca2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3977250 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Constantine Shablya ef8350a6 2022-10-21T06:30:51 GLES1Renderer: Handle GL_BGRA the same way we handle GL_RGBA Fixes minetest Bug: angleproject:7774 Change-Id: Iacbe8cb9aa434ec624bfaf056092b77bda468b3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3970417 Commit-Queue: Constantine Shablya <constantine.shablya@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Constantine Shablya <constantine.shablya@collabora.com>
Alexey Knyazev c97edf51 2022-10-24T00:00:00 Metal: Enable APPLE_clip_distance Adjusted direct-to-Metal shader translator to support gl_ClipDistance built-in. Bug: angleproject:6291 Change-Id: Ice4cc3e4d7c131cbaac9726e845a5c1e59787e69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3976428 Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll a9001d17 2022-10-25T10:01:20 Roll SwiftShader from 1ab775a9492b to ea3fc74f3d69 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/1ab775a9492b..ea3fc74f3d69 2022-10-25 syoussefi@google.com Support VK_KHR_get_surface_capabilities2 2022-10-24 capn@google.com Update README for Vulkan 1.3 2022-10-24 swiftshader.regress@gmail.com Regres: Update test lists @ 1ab775a9 2022-10-24 sugoi@google.com Allow running multiple dEQP tests per process If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I6a02f4264edba206b21f8c23ff3d09366167dfac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3975927 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 30439960 2022-10-24T17:30:18 Unbreak run_angle_android_test. Broken by ListTests removed in https://crrev.com/c/3963651 Move helper to angle_test_util. Bug: angleproject:7755 Change-Id: I1eec442cf3e2bf6c24335d4c294a68e7e868b814 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3975353 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Geoff Lang 966f3bae 2022-10-24T13:27:48 Replace sprintf by snprintf in trace_interpreter.cpp sprintf has been deprecated and generates warnings. Bug: angleproject:7752 Change-Id: Id1483585397edba44e03f7e5e925d398882af2f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3975351 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 11a3e06b 2022-10-24T11:26:05 Android: Fix restricted_trace_perf.py Test: restricted_trace_perf.py --fixedtime 10 --power --loop-count 5 Bug: angleproject:7755 Change-Id: Idbd2ccc73bd7409e2538346897b254403c1fd5d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3975592 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Geoff Lang 6c53a562 2022-10-24T10:24:10 Add missing cstring include in gl_enum_utils. Bug: angleproject:7752 Change-Id: I44ac0996673065b9633b35e4b07c5150a1ae3dcd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3970767 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 81fcf70e 2022-10-24T09:53:17 Reduce angle_preftests samples from 10 (new default) to 6. Taking too long on Windows, this should bring it close to other test suites. Bug: angleproject:7782 Change-Id: Ie1e76fffda790c3b5c2e73a22dee92763fa56abb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3970765 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Trevor Black <vantablack@google.com>
kmx.io     mail     discord kmxgit v0.4.0