kc3-lang/angle

Log

Author Commit Date CI Message
Alexis Hetu 9819e9ed 2020-01-15T17:13:32 GL_EXT_read_format_bgra support Implemented DetermineBGRAReadFormatSupport in order to allow enabling readFormat when possible with the Vulkan backend. While reading the spec, I realized that ANGLE only seems to care about BGRA8888 and not the new types mentioned in the extension. Logged a new issue (http://anglebug.com/4302) to track this. Bug: angleproject:4294 Change-Id: I071ed89574de9b4088df2301c317d3769cb31ce6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003237 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexis Hetu eb06bc24 2020-01-14T10:35:01 GL_EXT_float_blend support DetermineFloatBlendSupport was added to be able to set floatBlend to true if requirements are met. Essentially GL_EXT_float_blend complements GL_EXT_color_buffer_float by making any non-blendable formats blendable. Bug: angleproject:4291 Change-Id: I40d6bb7a93b8847a63de2d25c6a8dc411d6d8fbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001479 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexis Hetu 41f6150e 2020-01-14T16:18:56 Stubs for new required extensions Added stubs for these soon to be added extensions: - GL_OES_depth_texture_cube_map - GL_EXT_read_format_bgra - GL_NV_depth_buffer_float2 - GL_NV_read_depth - GL_NV_read_stencil Bug: angleproject:4293 Bug: angleproject:4294 Bug: angleproject:4295 Change-Id: I56cf1fda377e48521f30bd11f5776409bfb88701 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001480 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexis Hetu e0a28ba4 2020-01-14T09:44:27 Add blendable checks to GL_EXT_color_buffer_float The GL_EXT_color_buffer_float spec https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_color_buffer_float.txt mentions that some of the formats must be blendable: "Blending applies only if the color buffer has a fixed-point or floating-point format. If the color buffer has an integer format, proceed to the next operation. Furthermore, an INVALID_OPERATION error is generated by DrawArrays and the other drawing commands defined in section 2.8.3 (10.5 in ES 3.1) if blending is enabled and any draw buffer has 32-bit floating-point format components." So any non 32-bit floating-point must be blendable. Bug: angleproject:4291 Change-Id: I850fb13b71e4ad03fd07e2a265896c9106bc0ce1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001478 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Rafael Cintron 920ef28a 2020-01-15T15:26:17 Fix FL10_0 multisampling The last render-to-texture commit broke FL10_0 multisampling by unconditionally asking for D3D11_STANDARD_MULTISAMPLE_PATTERN quality setting. Per the documentation on https://docs.microsoft.com/en-us/windows/win32/api/d3d11/ne-d3d11-d3d11_standard_multisample_quality_levels applications can only request the standard multisample pattern on feature levels 10_1 and above. For feature levels 10_0 and below, we'll stick with asking for a quality level of 0 like the code previous did. Bug: chromium:1036367 Change-Id: I0dd7704cf144ebce952e1f7d5e148d3382891aed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003238 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis d9689725 2020-01-16T14:46:46 Suppress UniformsBenchmark perftest on Win/NVIDIA/Vulkan Started failing on Jan 11, 2020 Bug: chromium:1041672 Change-Id: Ie51c0d363b49025c607c32a1858cdaf8c38ebf87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003013 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Mohan Maiya df0203a9 2020-01-15T14:05:33 EGL: Add support for EGL_EXT_pixel_format_float extension Add support for floating point configs. On backends that support rendering to floating point formats, add them to EGL's frambuffer config list Bug: angleproject:3958 Tests: dEQP-EGL.functional.wide_color.*fp16* angle_end2end_tests --gtest_filter=EGLFloatSurfaceTest* Change-Id: Ie65f63013483267985c2b308567bf5025acf750e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993686 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Alexis Hetu d151b459 2020-01-14T09:44:27 Blendable check - Added a blendable check to InternalFormat - Set the blendable check to the same as the Renderbuffer check for most formats, except true integer formats and 32F formats - True integer formats never support blending - 32F formats support blending based on the GL_EXT_float_blend Bug: angleproject:4291 Change-Id: Icffdd3e6d8791303bdfdad9ec01cfd9a1d511af0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1999495 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Jamie Madill 441b72f0 2020-01-16T14:48:39 Vulkan: Make ContextVk own ResourceUseList. This moves the resource use tracking functionality out of CommandGraph. Making the list a separate class helps the implementation avoid tricky circular include problems. Bug: angleproject:4029 Change-Id: I3288fc685b21e949f12b0796109a2b7bb117c249 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2002931 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
James Darpinian 82f2cf31 2020-01-09T15:12:35 Require DEBUG_TRACE to enable expensive state validation ANGLE_STATE_VALIDATION_ENABLED is expensive, adding a lot of overhead to draw calls in debug mode. It's causing some of WebKit's layout tests to time out. Instead of enabling it for all debug builds, let's only enable it when ANGLE_ENABLE_DEBUG_TRACE is specified. Bug: angleproject:3900 Change-Id: I9866d7afbb5666f35c56539820d591953bdf7650 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1994440 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
James Darpinian 51179335 2020-01-15T15:47:14 Remove literal tab characters from generate_parser_tools.py WebKit's tools don't like literal tab characters in their repo. Bug: angleproject:3439 Change-Id: Ifd26e0bbcfaa604ed26f6a42dd7d2248e94dfeaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003929 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Jamie Madill 4ff1651e 2020-01-16T12:42:27 Vulkan: Add ResourceUseList helper. This abstracts away the ResourceUse tracking from CommandGraph. Pulling it out will allow us to more easily swap resource use tracking into ContextVk. The command graph is eventually going away so we need to move functionality out of CommandGraph. Bug: angleproject:4029 Change-Id: Icc3bcc824510b03e91f8ff010a82751a81516bfa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2002930 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll bdb0f8a5 2020-01-16T07:01:14 Roll third_party/vulkan-tools/src 2c436960d2c0..4792a6854238 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/2c436960d2c0..4792a6854238 git log 2c436960d2c0..4792a6854238 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 charles@lunarg.com vulkaninfo: handle previous driver versions 2020-01-15 charles@lunarg.com build: Update known good for 1.2.131 Vulkan Header and Loader 2020-01-15 mikes@lunarg.com scripts: Tweak extension detection Created with: gclient setdep -r third_party/vulkan-tools/src@4792a6854238 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I21a0c7f08ed37f247e11de9d42a67beee6681825 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003122 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexis Hetu ddb99f21 2020-01-14T09:44:27 Support blendable capability Vulkan distinguishes between a texture format that can be used as a render target (VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT) and one that supports blending (VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT). This cl adds a blendable capability and sets it based on the appropriate bit. It also adds the check in GetFormatSupportBase(), but all uses of it are currently set to false. In terms of behavior, this cl should be noop. Bug: angleproject:4291 Change-Id: Ib151ac8ab7b69311b7fdef15ad87186d13e3ed78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1999494 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 50a69a14 2020-01-16T07:01:37 Roll third_party/vulkan-headers/src f63dd5c9d874..881bbb347a08 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/f63dd5c9d874..881bbb347a08 git log f63dd5c9d874..881bbb347a08 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 oddhack@sonic.net Update for Vulkan-Docs 1.2.131 Created with: gclient setdep -r third_party/vulkan-headers/src@881bbb347a08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=jonahr@google.com Bug: None Change-Id: I2f78b6d68988172304e50fb17ed882b117faa77c Tbr: jonahr@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2004368 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jonah Ryan-Davis df0683b1 2020-01-15T14:00:47 Expose GL_ANGLE_framebuffer_blit in NULL backend The passthrough ASAN fuzzer was hitting a null-dereference trying to call glBlitFramebuffer when ANGLE was not exposing it. The fuzzer uses the NULL backend so we can just expose it. Bug: chromium:1029829 Change-Id: I0f65c65284756fa21821155559a6404d95e25647 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003230 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Mohan Maiya 01c0d6bd 2020-01-12T13:41:31 Vulkan: Use dynamic buffers for staged updates Dynamic buffers are used to perform staged updates to BufferVk objects instead of recreating staging buffers for each update. Bug: angleproject:4292 Change-Id: I0f64c821c97e0e6014e9df1d4f99e2f495838025 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001461 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Corentin Wallez 0d2c75f4 2020-01-14T19:35:16 DisplayGLX::isValidNativeWindow, avoid X11 exiting the program The previous implementation of the function had an incorrect comment that implied XQueryTree was a great way to check if a Window is valid. Any X11 function taking a Window is a good candidate, what we need to be careful about is X11 exiting the program on any error. Replace it with a call to XGetWindowAttributes while ignoring X11 errors. This fix was found while implementing similar functionality in Dawn. Bug: dawn:269 Change-Id: I777e59cddbe94baf63286d11887b58c63ac2b66c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001301 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
angle-autoroll 0c6c9a0d 2020-01-16T07:56:47 Roll third_party/glslang/src d203754bc116..3ed344dd784e (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d203754bc116..3ed344dd784e Created with: gclient setdep -r third_party/glslang/src@3ed344dd784e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Idd8bccd67ffcda6115477f0e9fb3bcac97ea7dff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003821 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 991e510e 2020-01-16T07:01:43 Roll third_party/vulkan-validation-layers/src 834baaf8b227..ab883b9d257e (5 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/834baaf8b227..ab883b9d257e git log 834baaf8b227..ab883b9d257e --date=short --first-parent --format='%ad %ae %s' 2020-01-15 mark@lunarg.com tests: Added tests for ycbcr sampler validation check 2020-01-15 mark@lunarg.com stateless: Added YCBCR sampler checks 2020-01-14 mark@lunarg.com tests: Add destroy null handle tests to best practices 2020-01-14 mark@lunarg.com bestpractices: Check for null handle when freeing memory 2020-01-14 petr_kraus@email.cz layers: Fix the logic in VUID links generation Created with: gclient setdep -r third_party/vulkan-validation-layers/src@ab883b9d257e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I58971f69536be68f387694c357d9e9d77c318074 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003125 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 44aebd91 2020-01-16T07:01:18 Roll third_party/spirv-tools/src 8013d477aeac..323a81fc5e30 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8013d477aeac..323a81fc5e30 Created with: gclient setdep -r third_party/spirv-tools/src@323a81fc5e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I7edd382098175d998315e8b4d9665aa09124330a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003123 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8aac6a59 2020-01-16T07:01:42 Roll third_party/SwiftShader 488d35ac0b1c..5fc197dc7669 (13 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/488d35ac0b1c..5fc197dc7669 git log 488d35ac0b1c..5fc197dc7669 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 jonahr@google.com Disable MSVC warning 4065 2020-01-15 bclayton@google.com Vulkan: Disable SPIR-V preprocessing when debugging 2020-01-15 capn@google.com Produce less debug info in Kokoro builds 2020-01-15 capn@google.com Refactor binary group operations 2020-01-15 capn@google.com Replace positive/negative_inf() with infinity() 2020-01-15 bclayton@google.com SpirvShader: Stub OpenCL.DebugInfo.100 2020-01-15 bclayton@google.com System/Types.hpp: Make vec(T replicate) constexpr 2020-01-15 bclayton@google.com SpirvShaderDebugger: Add flag for printing opcodes 2020-01-15 bclayton@google.com SpirvShader: 2-way imported extensions lookup 2020-01-15 bclayton@google.com .vscode: Add spirv-tools-ext to include path 2020-01-14 bclayton@google.com C++14: Use enum class builtin hashing 2020-01-14 bclayton@google.com C++14: Use std::enable_if_t instead of our own 2020-01-14 chrisforbes@google.com Add initial stub implementation of AHB Created with: gclient setdep -r third_party/SwiftShader@5fc197dc7669 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: angleproject:4299 Tbr: jonahr@google.com Change-Id: I0badcf80f1be1ca17654a1d2f09f420e313dd540 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003124 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott a7b91502 2020-01-15T13:35:08 Vulkan: Updated expectations after recent fixes Bug: angleproject:3569 Bug: angleproject:3596 Bug: angleproject:4106 Bug: angleproject:4108 Bug: angleproject:4300 Change-Id: Iab88bf5db19af802ad41ef8bf68f643420857989 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003233 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Artem Bolgar ffdd58f5 2019-12-28T15:34:41 Fixing OVR_multiview and OVR_multiview2 issues Found two issues when native OVR_multiview and OVR_multiview2 extensions are generated. 1. OVR_multiview got replaced by the OVR_multiview2 in the translated shader (ESSL & GLSL) 2. Duplicate #extension OVR_multiview2 (for Fragment & Vertex) and 'layout (num_views=x)' (for Vertex) got generated into the translated shader. Bug: angleproject:4247 Change-Id: I9a550883eeb326d95af4557578f8202a9493f4ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1983802 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Kenneth Russell 86f73097 2020-01-10T16:19:02 Upstream support for iOS Simulator. Originally authored in the WebKit repository: https://bugs.webkit.org/show_bug.cgi?id=205618 Has been tested with WebKit's WebGL backend on top of ANGLE inside the iOS Simulator. TODOs will be addressed in forthcoming CLs. Bug: angleproject:4263 Change-Id: Ic879866aaee5f933599d956b0646d0c01db55d0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1995824 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 2e1beb40 2020-01-14T12:08:02 Add a test to expose translator bug w.r.t short circuiting Bug: angleproject:3829 Change-Id: I872118f145886eecaed1680268e95419385b9d9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001237 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi feb3b6cc 2020-01-13T22:58:59 Vulkan: Remove row->col major shader transformation This was done based on the incorrect assumption that Vulkan GLSL doesn't allow layout qualifiers on interface block fields. This was due to glslang compile failures in some shaders that included mixed row- and column-major fields in interface blocks. However, the failures were only in the case the interface block is inactive, in which case glslang wrapper previously replaced the layout/qualifier of the interface block with |struct|, which left the shader with an unused struct definition with fields that have layout qualifiers; an invalid shader. The change introduced in https://chromium-review.googlesource.com/c/angle/angle/+/1951523 removes inactive shader interface declarations. The above scenario thus never occurs, rendering the row- to column-major transformation unnecessary. Bug: angleproject:3443 Change-Id: Ice34a0fc6e047b79a4d44f04b730ec59bdfafe33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961098 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
jchen10 b09d46cc 2020-01-13T10:56:46 Add P010 stream test Makes sure P010 stream can work correctly. Bug: chromium:1033416 Change-Id: I1b49568cd667697337335a0eca74504bd0e36f5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1996912 Reviewed-by: Jie A Chen <jie.a.chen@intel.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 740c4ea7 2020-01-13T17:21:54 Invoke the standalone test harness runner. Previously we were still calling GoogleTest directly. This change switches the test main funtions to call the standalone harness. Only affects standalone and shouldn't affect the tests in Chromium or on the current test setup. Bug: angleproject:3162 Change-Id: Ia5a5a73d47c0b47b4df8f54cd6df71da2d878847 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1998661 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill 238adb7a 2020-01-13T17:21:53 Fix test harness running disabled tests. Adds special handling for the DISABLED_ GTest test name. Fixes the test for the test suite harness itself when run with the new "--bot-mode" flag. Bug: angleproject:3162 Change-Id: Idf34098d2d6bcb78263773be7b01c55df9ec624b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1998660 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 5eadaf85 2020-01-13T17:21:53 Fix and improve UWP build. Reorganizes the build files to work with a more divided setup. It is unclear if we'll ever be able to run tests in a UWP config. This at least sets up the organization so it would at some point be possible. Bug: angleproject:4182 Change-Id: I49dddfcdc0118b11466fe171f949c28d101ac6a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953484 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 680a7d3b 2019-12-09T16:07:43 Vulkan: Add test that exposes sampler refactor bug Bug: angleproject:4211 Change-Id: I9e9cdacd4f24131101029d17932625e2e3c7d7e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957836 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill 683dd1d6 2020-01-13T17:21:52 GN: Move util build code into util/BUILD.gn. Prepratory clean up for WinUWP support. Bug: angleproject:4182 Change-Id: I97cc6cb42a50c6b57ca7d375d1e0a6b3da7aa9d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1998673 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 54d0d539 2020-01-14T07:01:43 Roll third_party/vulkan-validation-layers/src b96d6528883e..834baaf8b227 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b96d6528883e..834baaf8b227 git log b96d6528883e..834baaf8b227 --date=short --first-parent --format='%ad %ae %s' 2020-01-13 petr_kraus@email.cz layers: Default vuid links to spec repo search Created with: gclient setdep -r third_party/vulkan-validation-layers/src@834baaf8b227 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Id4efc3fd3e1d19026e52bcbb27ef7c0e260f2797 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1999621 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f26c8195 2020-01-14T07:01:55 Roll third_party/SwiftShader b0ca2a89e255..488d35ac0b1c (9 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/b0ca2a89e255..488d35ac0b1c git log b0ca2a89e255..488d35ac0b1c --date=short --first-parent --format='%ad %ae %s' 2020-01-13 bclayton@google.com Vulkan/Debug: Fix `DAP_LOG` macro 2020-01-13 bclayton@google.com CMakeLists.txt: Copy OpenCLDebugInfo100.h to new dir 2020-01-13 bclayton@google.com .vscode: Define ENABLE_VK_DEBUGGER 2020-01-13 bclayton@google.com Regres: Roll dEQP 1.1.6 forward 2020-01-13 capn@google.com Rename NonNormalized to Unnormalized 2020-01-13 capn@google.com Disable the GL_NV_framebuffer_blit extension 2020-01-13 capn@google.com Disable the GL_APPLE_texture_format_BGRA8888 extension 2020-01-13 capn@google.com Allow verbal bug IDs 2020-01-13 capn@google.com Validate the bug ID format in Kokoro presubmit Created with: gclient setdep -r third_party/SwiftShader@488d35ac0b1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I7ee074ac9e4fa93dfc71ec5248e5e67668984ada Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2000043 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9805f027 2020-01-14T07:01:53 Roll third_party/spirv-tools/src 18b3b94567a9..8013d477aeac (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/18b3b94567a9..8013d477aeac Created with: gclient setdep -r third_party/spirv-tools/src@8013d477aeac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ic2d9f5ab6e006d389604537be974a94eb050017e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1999622 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott 8b3a0fa8 2020-01-13T15:57:27 Vulkan: Update expectations SwS change fixes 2 tests Changing SwiftShader to return: VK_SAMPLE_COUNT_1_BIT | VK_SAMPLE_COUNT_4_BIT for for VkPhysicalDeviceLimits::sampledImageIntegerSampleCounts fixes two tests that were failing with SwS. This also fixes the expectations file for another test. Bug: angleproject:4260 Bug: angleproject:4259 Bug: angleproject:3565 Change-Id: I698468ff8421b1c8556c8671b173e1cfde6b7f6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1999484 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Kenneth Russell 11c35d0e 2020-01-10T18:19:05 Fix uninitialized variable in driver bug workaround. Bug: angleproject:4267 No-Try: True Change-Id: I5d9846779e4ac27313ec57b6ded935dbb40e1970 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1995829 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll c6ff255b 2020-01-13T07:01:47 Roll third_party/glslang/src 51813670627c..d203754bc116 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/51813670627c..d203754bc116 Created with: gclient setdep -r third_party/glslang/src@d203754bc116 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I83c4c132afd6203fe09fe709721faca0c03614c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993888 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9da223b3 2020-01-13T07:01:41 Roll third_party/SwiftShader 110236f3ce70..b0ca2a89e255 (7 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/110236f3ce70..b0ca2a89e255 git log 110236f3ce70..b0ca2a89e255 --date=short --first-parent --format='%ad %ae %s' 2020-01-11 bclayton@google.com Pipeline: Implement the SpirvShader debugger. 2020-01-11 swiftshader.regress@gmail.com Regres: Update test lists @ 0f8f361a 2020-01-10 swiftshader.regress@gmail.com Regres: Update test lists @ 110236f3 2020-01-10 sugoi@google.com Removed a few parentheses for slightly better clang formatting 2020-01-10 sugoi@google.com A2R10G10B10 Support 2020-01-10 ianelliott@google.com Change sampledImageIntegerSampleCounts to sampleCounts 2020-01-10 srisser@google.com Add the PowerVR SDK as a git submodule Created with: gclient setdep -r third_party/SwiftShader@b0ca2a89e255 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I598844bc14cd0c3654a6ace7f17bd2040cc80a36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993886 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6a727424 2020-01-13T07:01:43 Roll third_party/vulkan-validation-layers/src c17344df6cca..b96d6528883e (14 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c17344df6cca..b96d6528883e git log c17344df6cca..b96d6528883e --date=short --first-parent --format='%ad %ae %s' 2020-01-10 mark@lunarg.com tests: Fix YCbCr sampler test 2020-01-10 pdaniell@nvidia.com corechecks: Fix issues with separate depth/stencil layouts 2020-01-10 petr_kraus@email.cz layers: Report valid spec links on error 2020-01-10 petr_kraus@email.cz tests: Test vkCmdExecuteCommands into a Secondary 2020-01-10 s.fricke@samsung.com tests: Added test for VUID 01618 2020-01-10 s.fricke@samsung.com tests: Added test for VUID 01608 2020-01-10 s.fricke@samsung.com tests: Added test for VUID 01588 2020-01-10 s.fricke@samsung.com layers: Added VK_IMAGE_CREATE_DISJOINT_BIT validation 2020-01-10 s.fricke@samsung.com tests: Added 01564 test to DSAspectBitsErrors 2020-01-10 s.fricke@samsung.com layers: Added support for VUID 01564 2020-01-10 s.fricke@samsung.com tests: Added test for VUID 01648 2020-01-10 s.fricke@samsung.com layers: Added support for VUID 01648 2020-01-10 s.fricke@samsung.com tests: Added 01560 test to ImageBufferCopyTests 2020-01-10 s.fricke@samsung.com layers: Added support for VUID 01560 Created with: gclient setdep -r third_party/vulkan-validation-layers/src@b96d6528883e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I7b9edbae8b42a41042e8adec7a5c3b12dd8be724 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993887 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 97f831fc 2020-01-13T07:01:53 Roll third_party/spirv-tools/src fb2e819819ef..18b3b94567a9 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fb2e819819ef..18b3b94567a9 Created with: gclient setdep -r third_party/spirv-tools/src@18b3b94567a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ied4595d3d1b2ea5d7352f719c441c9b2d8baa75f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993889 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yan, Shaobo 52cb2a1a 2020-01-07T14:06:25 Allow SamplerVideoWEBGL can sampler compatible texture type For current WEBGL_video_image implementation, VideoImage texture type translates to its native texture type in blink layer. A refactory for this implementation is required but is complicated and need much time. Currently, we need a workaround in ANGLE to support this extension. Current end2end tests can monitor this workaround well. BUG=chromium:776222, angleproject:3889 Change-Id: I864bc2734cfffc8c5aea6166466767e3fb31c1c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989864 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c4053a9e 2020-01-03T15:03:32 Vulkan: Reduce the frequency of driver uniform binds Bind the driver uniforms set only when actually updating them. Bug: angleproject:4261 Change-Id: Ie1f1ab61eef58c5e0c713d285050c79c4cfccb32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986928 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Shahbaz Youssefi ed074852 2020-01-07T13:26:27 Add a perf test for drawing with alternating programs The programs have a different shader interface, to force rebinding descriptor sets in the Vulkan backend. Bug: angleproject:4261 Change-Id: I7a18a441483dfe34bd40b5a30ca34b7fd0dc3219 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990085 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi f0be7c81 2019-12-02T15:42:33 Fix GLSLTest_ES3.MixedRowAndColumnMajorMatrices_ReadSideEffect The test had two array sizes swapped, causing failure on vendors that statically verified index-out-of-bound accesses. Bug: angleproject:3831 Change-Id: I8ec32e9c11b38b69f03b1a22e60dfb6c6e82c2a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947123 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 5e33e647 2020-01-09T14:20:09 Vulkan: Optimize getIndexRange This function was unconditionally calling finishImpl(). This is changed to finishToSerial() to only wait until the serial that actually used the buffer. Bug: angleproject:3072 Change-Id: Ida89bb119b4ba6420f12404b911af0e3b4583a51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993407 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 6b275406 2020-01-09T11:14:47 Vulkan: Workaround vertex attributes vs stride issue on AMD Under robustBufferAccess, Vulkan states that: Vertex input attributes are considered out of bounds if the offset of the attribute in the bound vertex buffer range plus the size of the attribute is greater than either: - vertexBufferRangeSize, if bindingStride == 0; or - (vertexBufferRangeSize - (vertexBufferRangeSize % bindingStride)) The latter implies that if the buffer size is not a multiple of the vertex attribute stride, what lies beyond the last multiple of stride is considered out of bounds. It also says: Out-of-bounds buffer loads will return any of the following values: - Values from anywhere within the memory range(s) bound to the buffer (possibly including bytes of memory past the end of the buffer, up to the end of the bound range). - Zero values, or (0,0,0,x) vectors for vector reads where x is a valid value represented in the type of the vector components and may be any of ... The first bullet point indicates that the driver is allowed to load the attribute values from the buffer if its range still lies within the buffer size. Take the following example: - Buffer size = 12 - Attribute stride = 8 - Attribute offset = 0 - Attribute size = 4 Basically the buffer is thus laid out as follows: attr stride _________/\_________ / \ +----------+----------+----------+ | vertex 0 | padding | vertex 1 | +----------+----------+----------+ \___ ____/ V attr size In the above example, the attribute for vertex 1 is considered out of bounds, but the driver is allowed to either read it correctly, or return (0, 0, 0, 1) for it. Most drivers implement the former, while AMD implements the latter. This change introduces a workaround for AMD where GL_MAX_VERTEX_ATTRIB_STRIDE is limited to 2048 (the common value for it according to gpuinfo.org) and conservatively rounds up every buffer allocation to that size. While technically, this workaround should be applied on any device with the robustBufferAccess feature enabled, it is currently limited to AMD to avoid the inefficiency. A possible future revision of Vulkan may relax the above restrictions. Bug: angleproject:2848 Change-Id: Ida5ae5d777da10f22ce8be5a09a7644b5bbd778e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1991709 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 8fde1151 2020-01-09T14:22:35 Vulkan: fix default uniform descriptor rebind on program change When the program binding changes, we set the descriptor sets binding dirty bit if the program had any textures, UBOs, SSBOs, images or atomic counters. The check for default uniforms was missing. So if the two programs had no resources and were only using default uniforms, then drawing with one after the other didn't update the descriptor set binding of the default uniforms for the second draw. Bug: angleproject:4277 Change-Id: I631a1619658ee713484cfaee99fe1e39987e16e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993408 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Eric Binet 5aed7c74 2020-01-08T17:42:21 Narrow point size range clamping to affected versions Bug: angleproject:2970 Change-Id: Ie14725b0cf30738d394320c24a72bc947135f5cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993204 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Eric Binet 23b8857b 2020-01-08T14:07:53 Fix RendererVk::getMaxSupportedESVersion() to truly downgrade max version Added a small helper function (LimitVersionTo) to prevent future mistakes. Bug: angleproject:4168 Change-Id: Ia19312459540adbc2788ad0a5cb3d19ef1ff784f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1992185 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Eric Binet 4ffc254e 2020-01-08T09:58:24 Only initialize the timestamp query pools if the extension is available. Also added a few assertions to ensure that timestamp queries aren't attempted when support is missing. Bug: angleproject:4114 Change-Id: Ie6d7d5face59f9bc137aebd86c9d0e965773e6e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1992184 Commit-Queue: Eric Binet <ericbinet@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Courtney Goeltzenleuchter f567bac0 2019-12-20T09:29:35 Vulkan: Add fallback for D32_UNORM for Swiftshader Swiftshader does not have support for D24_S8 (typical fallback for 32bit DEPTH_COMPONENTS) but does have D32_FLOAT, so add fallback to that format. This then allows ANGLE to support OES_depth_texture extension when using Swiftshader which is needed to allow Vulkan swiftshader to replace GL swiftshader. Bug: angleproject:4232 Change-Id: Iaf04fcf0bea8d9cca0b9e7a18e3351ce8c704355 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986413 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 0253940d 2020-01-09T15:30:22 Add UWP bots winuwp-x64-dbg and winuwp-x64-rel CI and Try bots. Bug: angleproject:3928 Change-Id: Ifc54f6daae1090f9c68be6edcd8b1a069f0c5fc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993691 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll c792a6ba 2020-01-10T07:01:43 Roll third_party/vulkan-validation-layers/src ac72777ef763..c17344df6cca (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ac72777ef763..c17344df6cca git log ac72777ef763..c17344df6cca --date=short --first-parent --format='%ad %ae %s' 2020-01-09 petr_kraus@email.cz scripts: Report unassigned VUIDs in stats 2020-01-09 petr_kraus@email.cz scripts: Add best practices tests to stats Created with: gclient setdep -r third_party/vulkan-validation-layers/src@c17344df6cca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I670cc25dee3714a451636bfa1e66145d8f77181f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1994252 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll dcc57015 2020-01-10T07:01:41 Roll third_party/SwiftShader 77c89ff847b6..110236f3ce70 (5 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/77c89ff847b6..110236f3ce70 git log 77c89ff847b6..110236f3ce70 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 sugoi@google.com Enable filtering depth+stencil formats 2020-01-09 bclayton@google.com Kokoro: Disable ASAN for debug mac builds 2020-01-09 bclayton@google.com SpirvShader: Move extension list out of for loop. 2020-01-09 bclayton@google.com C++14: Use std::make_unique where possible. 2020-01-09 swiftshader.regress@gmail.com Regres: Update test lists @ 77c89ff8 Created with: gclient setdep -r third_party/SwiftShader@110236f3ce70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ibe4bccbad9c9f306953164aa7c0faf8c778ba68c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1994251 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kenneth Russell 12ce8f68 2020-01-03T16:40:06 Upstream WebKit's iOS port of ANGLE. Added the EAGL backend authored by Dean Jackson from Apple, and the refactoring changes needed to support it side-by-side with the macOS backend. Ran "git cl format" against these diffs. Defined the EGL_ANGLE_device_eagl extension and allocated an enum out of ANGLE's reserved range. The iOS backend is not yet included in any of the GN files. Bug: angleproject:4263 Change-Id: I631c32930433c03bb16a242955ffedf55174bb29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987278 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Kenneth Russell 7a37d3ac 2020-01-05T13:52:03 Work around Intel driver bug with CopyTex{Sub}Image2D/DeleteTextures. Dependencies seem to be incorrectly tracked in some Intel OpenGL drivers (on macOS specifically), causing crashes in glDeleteTextures if a GL command buffer is being constructed where those textures are destinations of CopyTexImage2D/CopyTexSubImage2D. Work around this bug by flushing before texture deletion if CopyTex{Sub}Image have been called recently. The tracking is only done on a per-context rather than a per-device basis, but seems sufficient to work around the problem as identified. Tested both with new ANGLE test on affected hardware, and in WebKit's ANGLE backend for WebGL. Works around the crash reported in https://bugs.webkit.org/show_bug.cgi?id=205707 . Bug: angleproject:4267 Change-Id: I2266a5590759f6a3f19080def08710ef4b66d463 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987932 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tobin Ehlis 697b2241 2020-01-09T12:19:07 Vulkan:Clarify volk license file name Need to explicitly specifly volk LICENSE.md filename in README.chromium file. Bug: angleproject:4225 Change-Id: I5d71ef0c28063f6e036f94ddb7d2c9e289fe79d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993397 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
James Darpinian 27db2458 2019-10-03T13:46:28 Optimize disabling ARB_texture_rectangle In https://crrev.com/c/1838418 I added the ability to disable ARB_texture_rectangle so that we can use it in the WebGL implementation but disable it when compiling user shaders. Unfortunately disabling and re-enabling the extension causes the shader translator to be reinitialized which turns out to be more expensive than the actual work of shader translation, at least for small shaders. It's slow enough to cause timeouts in WebKit's WebGL conformance test runs. This introduces an alternate method of disabling ARB_texture_rectangle in the translator which is much faster because it avoids reinitializing the translator. Bug: angleproject:3956 Change-Id: I5d31b683ff19a59bdfd289cfd3c609f64ef5e25b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1991969 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
angle-autoroll bf8bd805 2020-01-09T15:00:53 Roll third_party/spirv-tools/src e70b009b0f1e..fb2e819819ef (14 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e70b009b0f1e..fb2e819819ef Created with: gclient setdep -r third_party/spirv-tools/src@fb2e819819ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cwallez@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com,jmadill@google.com Change-Id: Ife103b6f2c902c3ec357ab5058c1afe0c5648119 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993380 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1c40e03a 2020-01-09T07:01:41 Roll third_party/SwiftShader 45a4d0f36bd6..77c89ff847b6 (13 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/45a4d0f36bd6..77c89ff847b6 git log 45a4d0f36bd6..77c89ff847b6 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 bclayton@google.com Build: Verify that we're compiling with C++14. 2020-01-08 bclayton@google.com Build: Move from using C++11 to C++14. 2020-01-08 bclayton@google.com Kokoro: Update from GCC 4.8 to GCC 7. 2020-01-08 bclayton@google.com Pipeline/SpirvShader: Move setActiveLaneMask() 2020-01-08 bclayton@google.com Pipeline/SpirvShader: Support more OpExtInsts 2020-01-08 bclayton@google.com Pipeline/SpirvShader: Process OpString instructions 2020-01-08 bclayton@google.com Pipeline/SpirvShader: Add Impl struct 2020-01-08 bclayton@google.com Vulkan/Debug: Expose Frames from Thread 2020-01-08 sugoi@google.com Enable B10G11R11_UFLOAT blending 2020-01-08 bclayton@google.com Vulkan/Debug: Add Reference value type. 2020-01-08 chrisforbes@google.com Add storage image support for R16G16_{UINT,SINT,SFLOAT} 2020-01-08 bclayton@google.com Vulkan: Plumb the debug context down to SpirvShader 2020-01-08 bclayton@google.com Vulkan: Add debugging of the command buffer. Created with: gclient setdep -r third_party/SwiftShader@77c89ff847b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I9f7014f2de23f3f9411f07a4b95c0cc48ab5e6ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993043 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0561d46e 2020-01-09T07:01:43 Roll third_party/vulkan-validation-layers/src 258b887827ab..ac72777ef763 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/258b887827ab..ac72777ef763 git log 258b887827ab..ac72777ef763 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 mark@lunarg.com corechecks: Fix immutable sampler write fall-through case Created with: gclient setdep -r third_party/vulkan-validation-layers/src@ac72777ef763 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Id7c2391bdd232852542eb65a5d8372f73cf6d4d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993044 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f6228fdf 2020-01-09T07:01:47 Roll third_party/glslang/src 1642ca11282a..51813670627c (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1642ca11282a..51813670627c Created with: gclient setdep -r third_party/glslang/src@51813670627c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Id259094225cc9d58472153114d5836bddb4b6aaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993045 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill c431d596 2019-12-16T10:59:44 Add Serial to all GL resources. The Serial will help track active resources for filtering out inactive setup calls in capture/replay. Bug: angleproject:4223 Change-Id: I64ba50f27d656c12d45155dc735e9b6f9c04528f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969062 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tobin Ehlis 99c274ba 2020-01-08T09:39:03 Vulkan:Roll volk All ANGLE volk changes have been upstreamed to volk repo so rolling volk to sync with latest. Going forward we can just roll when/if we need newer versions of Vulkan Header supported by volk. Bug: angleproject:4225 Change-Id: I6132a94010bbc5f3356ebb0b7e2b2b661ecc68b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1991722 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
Eric Binet b84cdffe 2020-01-06T14:59:44 Fix colored indexed point tests not using color in vertex buffer. In the previous version, the IndexedPointsTestUInt tests named VertexWithColorUnsignedIntOffset* were redundant with UnsignedIntOffset*. Bug: angleproject:3923 Change-Id: I6b9b8f2bd78882bcac7c3b89e798291ee94eea70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1988998 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e5d3c659 2020-01-08T07:01:43 Roll third_party/vulkan-validation-layers/src b416ed86e4b2..258b887827ab (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b416ed86e4b2..258b887827ab git log b416ed86e4b2..258b887827ab --date=short --first-parent --format='%ad %ae %s' 2020-01-07 mark@lunarg.com tests: Add test for a write update to an immutable sampler 2020-01-07 mark@lunarg.com tests: Add test for copying to immutable samplers 2020-01-07 mark@lunarg.com corechecks: Add validation for writing to immutable samplers Created with: gclient setdep -r third_party/vulkan-validation-layers/src@258b887827ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I4fdaffd02584138c7d4e9d6f0c69221d628cf8ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990983 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 20ed6bcb 2020-01-08T07:01:41 Roll third_party/SwiftShader 068dd89cab31..45a4d0f36bd6 (5 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/068dd89cab31..45a4d0f36bd6 git log 068dd89cab31..45a4d0f36bd6 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 capn@google.com Disable unused function warning 2020-01-07 bclayton@google.com Regres: Apply fix for invalid SPIR-V in 12 tests. 2020-01-07 capn@google.com Disable LLVM & Subzero stack traces and crash handling 2020-01-07 digit@google.com vulkan: use a marl::Event in the VkSemaphore implementation. 2020-01-07 digit@google.com [vulkan] Simplify vk::Semaphore implementation. Created with: gclient setdep -r third_party/SwiftShader@45a4d0f36bd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I5b338a33ea57117912e019075c52f09351badea7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990982 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 90bf5bec 2020-01-08T07:01:47 Roll third_party/glslang/src 1d258ac34698..1642ca11282a (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1d258ac34698..1642ca11282a Created with: gclient setdep -r third_party/glslang/src@1642ca11282a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I6a686ddc411f6e2087b146fbd146c6a63675bf34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990984 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d0788509 2020-01-08T07:01:14 Roll third_party/vulkan-tools/src 55333361f9a1..2c436960d2c0 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/55333361f9a1..2c436960d2c0 git log 55333361f9a1..2c436960d2c0 --date=short --first-parent --format='%ad %ae %s' 2020-01-07 charles@lunarg.com vulkaninfo: Make presentation surface names a set Created with: gclient setdep -r third_party/vulkan-tools/src@2c436960d2c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: If653af60cbc98b72138c4e1768ec7ccae4f6543c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990981 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tobin Ehlis db49bc7d 2020-01-07T09:18:43 Vulkan:Roll volk Roll volk to the latest version which supports Vulkan 1.1.130. I'm attempting to upstream our customizations to that version so this roll is in preparation of those changes hopefully landing. Bug: angleproject:4225 Change-Id: I02f3bd3808f812c0ec8196b6c815a781e7ab5eeb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989479 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>
Ian Elliott c8d7f047 2020-01-07T10:06:07 Vulkan: Update number of samples when changing draw framebuffer This fixes a crash (preceeded by Vulkan validation errors) when running the following test: --gtest_filter=dEQP.KHR_GLES31/core_texture_storage_multisample_FunctionalTests_blitting_multisampled_depth_attachment* --use-angle=vulkan The problem is that GraphicsPipelineDesc::updateRasterizationSamples() is rarely called (e.g. glBindFramebuffer). The above dEQP test changes between draw attachments that do and don't have multisampling enabled. The number of samples is set (the first time) to have multisampling enabled, and never changed, even though other attachments don't have multisampling. FramebufferVk::syncState() now calls updateRasterizationSamples(). That fix uncovered a latent problem: when an application destroys all framebuffers (including the draw framebuffer), the ContextVk still points at the old draw framebuffer's FramebufferVk (now freed). This is fixed with new plubming to clean-up ContextVk::mDrawFramebuffer. Bug: angleproject:4240 Change-Id: I151ec40ab821efc07c26323c34275c9165ad2ed5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1983393 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Tobin Ehlis 2c63b83c 2020-01-03T15:44:30 Vulkan:Enable DebugUtils extension for Android Enable DebugUtils Vulkan extension for Android. This rolls VK Validation Layer dep forward to include a fix that allows this extension to work correctly with Android loader. Here's the Validation layer fix: https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/1464 Bug: angleproject:3852 Change-Id: I74c55c0a66a7ee4db3b623221c8fb6c4433a39af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1985175 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Corentin Wallez cbbb3aaf 2020-01-07T15:03:20 Suppress VertexAttributeTest.DrawArraysWithBufferOffset on Mac NVIDIA The test fails with the following at a very low flake rate: ../../third_party/angle/src/tests/gl_tests/VertexAttributeTest.cpp:230: Failure Expected equality of these values: angle::MakeGLColor(255, 255, 255, 255) Which is: White angle::ReadColor((midPixelX + viewportSize[2]) / 2, midPixelY) Which is: Transparent Black TBR=jmadill@chromium.org Bug: angleproject:4269 Change-Id: I82752acfbcb2a067ccb35a7a456def03299c359f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987258 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
angle-autoroll ce396c03 2020-01-07T07:01:43 Roll third_party/SwiftShader 10a900e5ffaf..068dd89cab31 (7 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/10a900e5ffaf..068dd89cab31 git log 10a900e5ffaf..068dd89cab31 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 bclayton@google.com SPIRV-Tools: Update Android.bp to fix build. 2020-01-06 capn@google.com Limit Vulkan memory allocation size to 1 GiB 2020-01-06 bclayton@google.com IDs: Move inline impls below class. 2020-01-06 bclayton@google.com Pipeline: Store builtins on SpirvRoutine... 2020-01-06 bclayton@google.com Style: clang-format the tests source too 2020-01-06 bclayton@google.com Merge changes Id1120acb,Ifc6afcda,I8b5da04a,I9389ad9e,I35d60f68 2020-01-06 sugoi@google.com Improve 1010102 blend precision Created with: gclient setdep -r third_party/SwiftShader@068dd89cab31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I9df3cbc0059453193adfbee90f767d06c0149fa2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989339 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 806b06a2 2020-01-07T07:01:41 Roll third_party/glslang/src 6334d594f68c..1d258ac34698 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6334d594f68c..1d258ac34698 Created with: gclient setdep -r third_party/glslang/src@1d258ac34698 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: If27787415b62ecdeee7192fdb6663e8b80cdec79 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989337 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0d467595 2020-01-07T07:01:41 Roll third_party/vulkan-validation-layers/src 2be3fe0f8471..b416ed86e4b2 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2be3fe0f8471..b416ed86e4b2 git log 2be3fe0f8471..b416ed86e4b2 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 mark@lunarg.com layers: Added stub functions for instance exts and funcs Created with: gclient setdep -r third_party/vulkan-validation-layers/src@b416ed86e4b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I1b8ae6d289e25c34c731c4acd42c30dead3ea6d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989338 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 806d812e 2020-01-03T13:48:30 Vulkan: Reorder descriptor sets This change moves driver uniforms to a set with a lower id than the one that includes (emulation) transform feedback buffers. Imagine the following: - Program 1 with xfb: UniformsSet: 1 VS uniforms buffer, 1 FS uniforms buffer, 1 xfb buffer - Program 2 without xfb: UniformsSet: 1 VS uniforms bufer, 1 FS uniforms buffer. Previously, UniformsSet was index 0, and DriverUniformsSet was index 3. When switching from Program 1 to Program 2, the layout of UniformsSet changes, which means every subsequent set needs to be rebound. This is a Vulkan pipeline layout compatibility rule. This is done with invalidateCurrentTextures() and invalidateCurrentShaderResources() already when handling gl::State::DIRTY_BIT_PROGRAM_EXECUTABLE. The bug is that the driver uniforms are not invalidated. This is normally not an issue, because usually when switching from Program 1 to Program 2, transform feedback is paused, and this state change does invalidate driver uniforms. However, the following scenario doesn't do this: - Begin Xfb - Pause Xfb - Use Program 1 - Draw - Use Program 2 - Draw - End Xfb There is no driver state change between the two draw calls, which means the second draw will attempt to draw using the driver uniforms bound for the first draw call. There is a Vulkan validation error here due to the above pipeline layout validation rule. The issue manifests itself only when the second draw call actually uses driver uniforms, as otherwise that set is inactive and not validated; i.e. when line raster emulation is used. In summary, the validation error manifests itself when: - Transform feedback and line raster both use emulation - Transform feedback is paused - A draw with an xfb program is followed by a non-xfb program - The second draw is a line draw A test is added for this. The solution is to reorder the sets so that DriverUniformsSet is placed before UniformsSet. This way, changes to the layout of UniformsSet don't invalidate DriverUniformsSet. In fact, based on the above, any change in the layout of the program should have required an invalidation of the driver uniforms. This bug is probably masked by the fact that ContextVk::handleDirtyDescriptorSetsImpl() always rebinds the graphics driver every time any descriptor set needs rebinding. That should be removed in a follow up change. Bug: angleproject:4261 Change-Id: I21ad4152b454a1fe70554be02e18a9c94fb3e7a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986927 Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
shrekshao 51e653f0 2020-01-02T13:53:03 Suppress flaky failure with MacOS/NVIDIA/OPENGL Seeing intermittent failure on this test only on MacOS/NVIDIA/OPENGL. Suppress for now. Bug: angleproject:4258 Change-Id: Ibda30954019410e3b6d069986b2cd0ad26533c00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984850 Reviewed-by: Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com>
Jeff Vigil 8c0bbfbb 2019-11-25T14:48:11 EGL: Implement EGL_ANDROID_framebuffer_target Add attribute to configs. Add attribute matching logic. Does not set attribute in Vulkan configs, need solution to query Android for which formats are valid. anglebug.com/4208 New end2end test. Bug: angleproject:3961 Test: angle_end2end_tests --gtest_filter=EGLAndroidFramebufferTargetTest* Change-Id: I7e14c47b39e9539f6181c3c1d75c76fe63ca0f8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1960508 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Courtney Goeltzenleuchter 7dfc99e5 2019-12-18T16:37:20 Vulkan: Update dEQP source for test fixes Also fix scripts/gen_vk_gl_cts_build.py to always use '/' as file separator. Otherwise, running the script on Windows uses '\' which Linux doesn't like. Test: angle_deqp_gles31_tests --use-angle=swiftshader --gtest_filter=dEQP.GLES31/functional_debug_negative_coverage_get_error_vertex_array_draw_range_elements Bug: angleproject:2324 Bug: angleproject:4234 Change-Id: I3b212e0d0ba97996f1d86f7fc81e58c3b03a9cbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1975020 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 0721cc8b 2020-01-03T23:26:08 Vulkan: No line raster emulation code if extension A flag is added to the translator to disable generation of Bresenham line raster emulation code when the Bresenham line raster Vulkan extension is present. This is primarily for the sake of conversion of line raster emulation condition to specialization constant: - Avoid dead SPIR-V code in every shader - Avoid ANGLEUniforms being active in every shader stage even if it's not used anywhere but in line raster emulation. - Optimize SPIR-V transformations by both having fewer instructions to iterate through, and to avoid generating line raster patches. - Reduce the severity of anglebug.com/4251 where the location assignment of ANGLEPosition can incorrectly overlap a varying array or struct, by making only platforms without Bresenham extension afflicted by the bug. Bug: angleproject:3394 Change-Id: Ic0ae6ce0392b4eae0cc79cb94bbcd0805b276a31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986379 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi f8ae5dc6 2019-12-20T16:32:09 GL: Enable EXT_gpu_shader5 Bug: angleproject:3569 Change-Id: I08666bde75ac158e051817e689e2c0b82d6b6f70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1978579 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ethan Lee d36780ba 2020-01-02T12:28:26 Fix UWP build Bug: angleproject:4246 Change-Id: Ifcbb6fe51ee2df6baf86a308de74bab640ded834 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982632 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Eric Binet f64ddcfd 2020-01-06T13:27:30 Add missing steps in DevSetup Bug: angleproject:4268 Change-Id: Ib7f58ba241c24acb35d8705d994c57422d9b73e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987908 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Ethan Lee 56fd2bce 2019-12-17T10:00:55 Fix GGP build Bug: angleproject:4246 Change-Id: I80906196ebc3c904e75516e8c53b05dd81c5fa5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982633 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Le Hoang Quyen ab42afa6 2019-11-21T10:13:44 Metal: fix vertex attribute's conversion lost after changing buffer binding. After vertex buffer's attribute is converted and stored in conversion buffer. Binding the same attribute to another buffer, then binding it back to previous buffer will result in previous conversion information lost. The conversion method would skip the conversion due to buffer's content hadn't been changed, however it didn't reuse the old conversion result. This CL also changed the way binding offset is used in Metal backend. - Previous, the offset would be assigned to the offset field of MTLVertexAttributeDescriptor, then the buffer would simply be bound to the command encoder with offset=0 i.e. setVertexBuffer(buffer, index, 0) - However this approach has several disadvantages. Since Metal doesn't allow MTLVertexAttributeDescriptor's offset to be larger than the vertex attribute's stride, the old approach would force the back-end to convert the attribute and store in conversion buffer. New approach: - MTLVertexAttributeDescriptor's offset will be zero. The offset will be used to bind the buffer itself to the render command encoder. i.e. setVertexBuffer(buffer, index, offset) This way the "offset <= stride" restriction no longer exists. The only restriction is the offset must be multiple of attribute's size. Added 3 new tests: - SimpleStateChangeTest.RebindTranslatedAttribute - VertexAttributeTest.DrawWithLargeBufferOffset - VertexAttributeTest.DrawWithLargeBufferOffsetAndLessComponents Bug: angleproject:2634 Change-Id: I6c2fa8091436e4a24405d791f86d17d97df02d64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940009 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Jeff Vigil 3311ef65 2020-01-03T11:52:15 update date comments to 2020 run_code_generation.py updated comments with 2019 to 2020. Put all date updates into this one CL. This also updated hashes. Bug: angleproject:4262 Change-Id: Ia213dd5e47f155986cbb4161d777724355878af0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986994 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Kenneth Russell 1031d2c6 2020-01-03T14:28:26 Upstream Mac logging changes from WebKit. Use os_log_with_type in ANGLE's logging facility rather than fprintf. Bug: angleproject:4263 Change-Id: I0c418fc5544001bf4f47ff511d05de2f0ebaa1de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987145 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
shrekshao 81ee4d29 2019-12-04T17:05:11 Workaround EXT_texture_norm16 for OpenGL ES drivers Implement a workaround for widespread bugs calling glReadPixels with RGBA/UNSIGNED_SHORT against R16/RG16 color attachments. Read back the data using the GL_IMPLEMENTATION_COLOR_READ_FORMAT, and then rearrange the read back pixels to fit the RGBA layout. Also skip RGB16/RGB16_SNORM texture sample test on Nexus 5X/Nexus 6P due to a another driver bug. Bug: chromium:1000354, angleproject:4214, angleproject:4215, angleproject:4245 Change-Id: Iedea6f4136878cac5ad0dec3757c77b73502e1cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1952166 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com>
angle-autoroll de97fb4a 2020-01-03T07:01:41 Roll third_party/vulkan-validation-layers/src e4a2b7f22782..2be3fe0f8471 (7 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e4a2b7f22782..2be3fe0f8471 git log e4a2b7f22782..2be3fe0f8471 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 jzulauf@lunarg.com layers: Record initial layout on release barriers 2020-01-02 mark@lunarg.com corechecks: Plumb VtxIndex VUIDs through to helper func 2020-01-02 mark@lunarg.com corechecks: Remove obsolete perf warning 2020-01-02 mark@lunarg.com tests: Removed PerfWarning test from VkLayerTest harness 2020-01-02 mark@lunarg.com bestpractices: Use BP VUID in place of corechecks one 2020-01-02 mark@lunarg.com tests: Added test for missing vtx buffers to BP harness 2020-01-02 mark@lunarg.com bestpractices: Added perf warning for missing vtx buffers Created with: gclient setdep -r third_party/vulkan-validation-layers/src@2be3fe0f8471 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I80a335bf862d776bc1533f366316f5b899fbfb09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986605 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 93061d4e 2019-12-30T23:45:08 Vulkan: Support vertex-only line emulation draw with xfb The code that patches the line raster emulation directive assumed both vertex and fragment shaders would be present. This is invalid if only a vertex shader is present. This change adds the directive to any stage that's available. This includes the possibility of a missing vertex shader also, which can be useful for separable shaders and program pipeline objects. Bug: angleproject:3394 Change-Id: I84555db81b59c318300003f7108a01f330e4259f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982782 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 35e6050f 2019-12-30T23:47:51 Vulkan: Correct error message for VK_ERROR_INVALID_SHADER_NV If an invalid shader is generated, generate the appropriate message instead of "Unknown error". Bug: angleproject:3394 Change-Id: I586c99e95cd72daeaf74b4d1eff352942e01d8b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982783 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Xinghua Cao 1fdf6ca5 2019-12-31T14:25:35 D3D11: Restrict to translate uniform block to StructuredBuffer Only translate uniform block to StructuredBuffer when system is Windows 10 and later. Bug: angleproject:3682 Change-Id: I27e3f4503392791883a44e1d486ffe9512e04bd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984863 Commit-Queue: Xinghua Cao <xinghua.cao@intel.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll cbbfa2f2 2019-12-31T07:01:43 Roll third_party/SwiftShader 59465799210b..10a900e5ffaf (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/59465799210b..10a900e5ffaf git log 59465799210b..10a900e5ffaf --date=short --first-parent --format='%ad %ae %s' 2019-12-30 chrisforbes@google.com Add assert in GenericValue constant access Created with: gclient setdep -r third_party/SwiftShader@10a900e5ffaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Id7ec364a7df7c8389d3bab78761f4b1061d93e10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984961 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 942d9152 2019-12-23T15:31:52 EGL: Add support for EGL_KHR_gl_colorspace extension If the Vulkan backend supports VK_EXT_swapchain_colorspace extension, enable the option for applications to create surfaces with non-linear formats. Not all formats have non-linear versions and is platform specific. Tests: dEQP-EGL.functional.wide_color.* angle_deqp_egl_tests --use-angle=vulkan --deqp-gl-context-type=egl --deqp-case=dEQP-EGL.functional.wide_color.* Bug: angleproject:2514 Change-Id: I441ee797cceef92c84473bfa18605c4fd8180de1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1951963 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll c1fc6de8 2019-12-30T07:02:09 Roll third_party/vulkan-headers/src 0e57fc1cfa56..f63dd5c9d874 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/0e57fc1cfa56..f63dd5c9d874 git log 0e57fc1cfa56..f63dd5c9d874 --date=short --first-parent --format='%ad %ae %s' 2019-12-28 flibitijibibo@gmail.com GN: Make PLATFORM_XCB optional, based on a user-defined variable. Created with: gclient setdep -r third_party/vulkan-headers/src@f63dd5c9d874 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=ynovikov@chromium.org Bug: None Change-Id: I57e5f53b741fce8a14d27af4445fcc31ea860c70 Tbr: ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984191 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi f02490d1 2019-12-23T14:06:12 Vulkan: clean up arguments to glslang wrapper Some flags were sent as parameters while an Options parameter was added. This change moves those flags to the GlslangSourceOptions struct. Bug: angleproject:3394 Change-Id: Iff5c1c83dd564d7bcfcbd84e6df244b7356d669d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984108 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 7fad424e 2019-12-30T00:07:09 Avoid vector copy in BinaryOutputStream::writeIntVector Also adds a unit test to make sure readIntVector and writeIntVector match. It was not immediately clear that writing the vector size in writeIntVector is writing an int instead of a size_t. Bug: angleproject:3394 Change-Id: I09a003c169dbc47e40c0cd3e4da6f1d7a905c6da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1983162 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0