|
7a85d114
|
2022-03-25T15:01:17
|
|
Use [[nodiscard]] on RAII classes
Scoped* classes provide an RAII way of adding cleanup/restore state/etc
in a robust way. Unfortunatley, it's very easy to mistakenly leave the
variable name, leading to the destructor being called immediately
instead of at the end of the scope:
{
ScopedX(parameters); // instead of ScopedX x(parameters);
// Code here is run after destructor
}
The [[nodiscard]] attribute, if specified on the ScopedX class would
lead to a warning (turned to error with -Werror). This change does
that for classes named *Scoped* in ANGLE.
Bug: chromium:1103817
Change-Id: I65c9922c9b4eba1f9c033e093fe8fe534648ab62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3552092
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
3e493db2
|
2021-11-19T10:47:04
|
|
tests/AndroidManifest: Disable allowNativeHeapPointerTagging.
In order for the mprotect tests to pass on Android, tagged pointers need
to be disabled.
Bug: angleproject:5857
Change-Id: I2a9703b98443a96b486581c5c5d57e40c3365555
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3291655
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
d84d1288
|
2021-07-16T12:08:03
|
|
android: Explicitly specify exported activities.
Android 12 requires all components with an <intent-filter> to explicitly
specify whether they are exported, instead of being exported by default.
Update various remaining cases in our tests/sample code/tools.
Bug: chromium:1223110
Change-Id: Iab37881d947da25d771bf757d2f7581ad782c73f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035442
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
2a713d92
|
2021-07-15T14:58:54
|
|
Avoid recreating activity when rotating the display.
Reference:
https://developer.android.com/guide/topics/resources/runtime-changes#HandlingTheChange
Bug: b/193828422
Change-Id: I4caa80941e4d32bdf5c830985a19536efd041069
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3032150
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
bc9d5223
|
2021-06-02T18:19:08
|
|
Experimental fix for stdout freopen race.
Bug: chromium:1213184
Change-Id: I2e2741f4100b2a5516210f2250dc82511fafd05b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2933602
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
74177f31
|
2021-05-09T21:15:09
|
|
Tests: Run Android tests fullscreen
In order to hide the status bar and hopefully prevent any layers from
rendering on top of our traces, make all Android tests run fullscreen.
Test: angle_perftests
Bug: angleproject:5937
Change-Id: I649104a7d95b7f056b411e180632524a85b7c4f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880335
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
bf0c6ae1
|
2021-03-09T13:21:58
|
|
Improve Angle Android gtest support
This CL makes angle_test() use an angle-specific gtest launcher -
AngleUnitTestActivity.java. This enables building standalone Android
angle without //base
Chromium-Bug: 1149922
Bug: None
Change-Id: Id84f3e2bd84c5017ed1988ca07534f424ebfa596
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745535
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|