kc3-lang/angle

Log

Author Commit Date CI Message
Jamie Madill 9907f22d 2022-04-19T13:22:26 gold tests: Add command-line arg for gold instance. This will allow other users of the script to override the ANGLE Skia Gold instance with their own. Bug: angleproject:6854 Change-Id: Id6a0966d4db4fd0265d427d684f07dc1e4c610e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3594619 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Geoff Lang e18240d1 2022-01-28T13:46:41 Mark contexts as shared when importing EGL images. Once a context references an EGL image, it can share resources with contexts in other share groups. Marking the context as shared ensures that locks are held by all contexts referencing EGL images for GL functions. Bug: angleproject:6957 Change-Id: Ic3901c458f388306c59f6bb01560a7c66d0574c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3424659 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill bddb944b 2022-04-14T05:04:09 Vulkan: Prep variable info map to remove hashing. The removes all the string-based query APIs from the program executable descriptor set init. The new APIs still use string-keyed maps but will be switched out with non-hashed maps in a future CL. Bug: angleproject:4524 Change-Id: I427efb3ebcf22d5fbdf6d20679bbdaa23cd2dc94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3573077 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 242f0d81 2022-04-19T10:40:50 Revert "Infra: Enable Skia Gold tests on Pixel 6" This reverts commit 3636d129ee9c6c970e9b31883fcc88c539382434. Reason for revert: Causing test timeouts on Pixel 6: https://bugs.chromium.org/p/angleproject/issues/detail?id=7216 Original change's description: > Infra: Enable Skia Gold tests on Pixel 6 > > We have our first trace that can't run on any existing > bots, so we need to expand to Pixel 6. > > Test: TracePerfTest.Run/vulkan_car_chase > Bug: angleproject:7125 > Bug: chromium:1280418 > Change-Id: I7a81d42bc336c7df398b1d1712cf25c0eb9d72d3 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3561490 > Auto-Submit: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Cody Northrop <cnorthrop@google.com> Bug: angleproject:7216 Bug: angleproject:7125 Bug: chromium:1280418 Change-Id: Ieca910fa11f81a3f526e9ccff49fa636fd3b7d13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3594112 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Cody Northrop acdec48a 2022-04-15T11:48:14 Tests: Add Monster Strike trace Test: angle_perftests --gtest_filter="*monster_strike*" Bug: angleproject:7210 Change-Id: I3184059a73f9d21474931633eb381a3cd12831f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587542 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill e77be663 2022-04-14T05:04:13 Use ProgramExecutable directly in GlslangWrapper. Using the ProgramExecutable instead of the state means we can deal with merged samplers and images immediately. This will make it easier to use linear maps when indexing program resources for descriptor sets. Bug: angleproject:3570 Bug: angleproject:4524 Change-Id: Icd8ee9fe61730b81fafa2bdc59a2788a0d92ad12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3580882 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill c82513af 2022-04-14T05:04:11 Add FastMap class. We can use this class in a few cases where we can know that the integer key index won't exceed a fixed small boundary. Bug: angleproject:4524 Bug: angleproject:6776 Change-Id: Ic380e1ce8f4dc591504603ade376d9b1e8a3c1c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3579865 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 4cd15cb3 2022-04-19T09:32:05 Skip a Vulkan test due to a threading flake. VulkanImageTest.PreInitializedOnGLImport/ES3_Vulkan_SwiftShader_AsyncCommandQueue Bug: angleproject:7204 Change-Id: I1aeb16d1e0bdaecefc0776236f55c46d307fdaad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3593363 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Jamie Madill 64fa1e80 2022-04-19T13:18:23 Revert "vulkan: Call glFinish in VulkanHelper destructor" This reverts commit aefb2a99ebb598c7b3530056ef3d030b5c4f0115. Reason for revert: Still flakes: https://ci.chromium.org/ui/p/angle/builders/try/linux-test/4382/overview Original change's description: > vulkan: Call glFinish in VulkanHelper destructor > > In async queue mode, GL commands are submitted asynchronously to the > VkQueue on a separate thread. VulkanHelper destructor uses the VkQueue > when it calls vkDeviceWaitIdle(), and that's a data race when the queue > is being used to run GL commands on the other thread. Calling glFinish() > before any Vulkan commands ensures that the queue isn't being used on > another thread. > > Bug: angleproject:7204 > Change-Id: I509bcf55edf430e39805a9d43c07a902942d33ca > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587366 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Bug: angleproject:7204 Change-Id: I60e6fc519b21d53619309247fdea32f23375f975 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3594099 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Brandon Schade 9cc459c9 2022-04-14T13:55:09 Add check for GL_ANDROID_extension_pack_es31a support Expose Android Extension Pack if we meet the following conditions - 1. GLES version >= 3.1 2. All required AEP extensions are supported Bug: angleproject:3608 Change-Id: I41eaf458b0a8fe7a53cd0fbec818411196ce21ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587535 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll dbe5b755 2022-04-19T10:01:08 Roll vulkan-deps from 1a408eb154d7 to 00e1ddd4230c (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1a408eb154d7..00e1ddd4230c Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/6a67891418..779138f39f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/dbf1e87e6b..8a6fe16b4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I9478b2be264000ea7dba13d097b701a62b60acc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3592348 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 834ca686 2022-04-19T07:00:52 Roll Chromium from e9b55eb91cb1 to e1b5a693bbfe (303 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e9b55eb91cb1..e1b5a693bbfe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9ccdb5a294..7aeed11a9e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/677dce96c9..e895c544f6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..28b8ede735 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ab2e7f8f2e..7d2693ad8d * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/a6d209ab93..be2c3787c0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6e7a0235bb..36b318c388 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c1ed910ca0..25916f0211 No update to Clang. Bug: angleproject:7003,angleproject:7200 Tbr: ianelliott@google.com Change-Id: I6dfc2b986794eec1a1b5c7d40f1173e11368ef74 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3592339 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 19710088 2022-04-08T15:33:13 Vulkan: Call into vulkan directly for big size allocation. When size is big, if we go down suballocation path, we end up with big size allocation and stuck with it (because some other allocation also suballocate from it). This CL force it down to vulkan driver to allocate VkBuffer and VkDeviceMemory directly for big size allocations, bypassing suballocator. Bug: b/223428306 Change-Id: Idd9f551322331f899036f73bab0489f8249eaadf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3550039 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi bdb52cb8 2022-04-08T13:20:54 Vulkan: Remove retains before acquireBufferHelper * Removed the retainReadOnly() functions in BufferVk, since the BufferHelper object is now moved to a temporary buffer and retaining it is no longer necessary. Bug: angleproject:7103 Change-Id: Id5da88d7cfa4d7a8532eb596f552c70a9ff1d358 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3579862 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev 866210ad 2022-04-17T00:29:28 Metal: Fix bytesPerRow computation for compressed formats The value represents the row size in bytes, not pixels. Bug: angleproject:7209 Change-Id: Ib7fade31f13ffd3ae78c5df313120c8e0201936c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3588416 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
angle-autoroll 33c8a2d0 2022-04-18T10:01:27 Roll vulkan-deps from 7f875b15c6a3 to 1a408eb154d7 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7f875b15c6a3..1a408eb154d7 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/48fd6c82b3..06ac141412 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/027f567463..dbf1e87e6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I83dae87e4423d508460b696f642ad50ac6f3b854 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3589487 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d903818a 2022-04-18T08:34:35 Roll Chromium from 573f2ec89cb9 to e9b55eb91cb1 (411 revisions) https://chromium.googlesource.com/chromium/src.git/+log/573f2ec89cb9..e9b55eb91cb1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4dc9039a2d..9ccdb5a294 * buildtools/linux64: git_revision:fd9f2036f26d83f9fcfe93042fb952e5a7fe2167..git_revision:1cdd270be9803dbfcdd0343f6104ad4dc30c38ce * buildtools/mac: git_revision:fd9f2036f26d83f9fcfe93042fb952e5a7fe2167..git_revision:1cdd270be9803dbfcdd0343f6104ad4dc30c38ce * buildtools/win: git_revision:fd9f2036f26d83f9fcfe93042fb952e5a7fe2167..git_revision:1cdd270be9803dbfcdd0343f6104ad4dc30c38ce * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b69ae9bf53..677dce96c9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b3baa6a042 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4b2e0bd8a4..ab2e7f8f2e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f3fcc8eac8..7d4922aa87 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1cba756954..6e7a0235bb No update to Clang. Bug: angleproject:7209 Tbr: jonahr@google.com Change-Id: I58410e5547138f8cbb54a2918146fb0105bbd2c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3590366 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 3636d129 2022-03-30T15:23:18 Infra: Enable Skia Gold tests on Pixel 6 We have our first trace that can't run on any existing bots, so we need to expand to Pixel 6. Test: TracePerfTest.Run/vulkan_car_chase Bug: angleproject:7125 Bug: chromium:1280418 Change-Id: I7a81d42bc336c7df398b1d1712cf25c0eb9d72d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3561490 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll d18e9e84 2022-04-15T10:01:28 Roll vulkan-deps from c9be322642fb to 7f875b15c6a3 (16 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c9be322642fb..7f875b15c6a3 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/9c3fd01c8a..82becc8a8a * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/92c17edde7..cb96abbf7a * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f503824ff8..71bd6240af * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/5f3ce24e7a..ef20059aea * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5501a60aa6..027f567463 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I3f182fa688dc8924d8c6336472d604bae8f35923 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587540 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll dfde9f40 2022-04-15T10:01:20 Roll SwiftShader from 1d450ae99a0f to 103a69bd6c82 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/1d450ae99a0f..103a69bd6c82 2022-04-14 capn@google.com Delete GLESUnitTests 2022-04-14 capn@google.com Detect <xcb/shm.h> for building XCB surface support 2022-04-14 capn@google.com Remove the extensions directory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I4be6cec3e8d07a59bd7b6871768e68c128fcc72d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3588325 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ff084b28 2022-04-15T08:31:36 Roll Chromium from e6765ea8299f to 573f2ec89cb9 (443 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e6765ea8299f..573f2ec89cb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bb1c23c67d..4dc9039a2d * buildtools/linux64: git_revision:c114b7e0b3a327e854cae6b560902230436f1ac7..git_revision:fd9f2036f26d83f9fcfe93042fb952e5a7fe2167 * buildtools/mac: git_revision:c114b7e0b3a327e854cae6b560902230436f1ac7..git_revision:fd9f2036f26d83f9fcfe93042fb952e5a7fe2167 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/bbcbce9968..1acfbbb474 * buildtools/win: git_revision:c114b7e0b3a327e854cae6b560902230436f1ac7..git_revision:fd9f2036f26d83f9fcfe93042fb952e5a7fe2167 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/533b4e6461..b69ae9bf53 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1f41b4fc8f..b0f34841af * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5bb29764b0 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3c6f0eb95f..4b2e0bd8a4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d82302711f..f3fcc8eac8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f70aa510c4..1cba756954 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7b9534832c..c1ed910ca0 Clang version changed llvmorg-15-init-7040-g50de659a:llvmorg-15-init-7570-gba4537b2 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/d82302711f8b44cb5a4adffa044343342a08118d..f3fcc8eac8f12c989993f9a05dc3a9985e551d85/scripts/update.py Bug: None Tbr: jonahr@google.com Change-Id: I455a2b6628ba87f6e818456739f411f027dc2370 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587539 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 5f7db775 2022-04-11T11:35:32 Vulkan: updateUniforms when commandbuffer is valid In order to change the resource use list from contextVk into that from one of its command buffers, we have to ensure the render pass command buffer is valid before potentially using its resource use list. * Added the dirty bit `DIRTY_BIT_UNIFORMS`. * Moved updateUniforms() and related functions in setupDraw() to the dirty bit handler where we have ensured that the render pass command buffer is valid. * Moved updateUniforms() and related functions in setupDispatch() to the dirty bit handler. Bug: angleproject:7103 Change-Id: I5435d16df543aa5a4c4be2b82586cb557ab53738 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3582979 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 3587e217 2022-04-13T16:52:38 Remove copyResourceUseList from ShareGroupVk * Removed copyResourceUseList() and the copy() functions in them, as they are no longer used in submitting commands. Bug: angleproject:7103 Change-Id: Ic62b21817aa2843f90695a8f50b79d254ec89929 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587531 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov 956fb16e 2022-04-14T20:54:26 Remove Win NVIDIA dEQP suppressions Switching from Quadro P400 to GTX 1660 Bug: angleproject:2222 Change-Id: I7f12878a0ccf31fe5ca319251ab3f4bc60d66b61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587372 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 5e48e5b8 2022-04-14T21:12:21 Roll VK-GL-CTS from 2748d45ebbb4 to a22069b4e3b7 (10 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/2748d45ebbb4..a22069b4e3b7 2022-04-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/github-main into vk-gl-cts/main 2022-04-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main 2022-04-14 onion0709@gmail.com explicitly provides ssh urls to GitRepo declarations 2022-04-14 toni.merilehti@siru.fi Fix support check in transform feedback tests 2022-04-14 ari.suonpaa@siru.fi Fix framebuffer size for some GraphicsFuzz tests 2022-04-14 michal.jakubek@mobica.com Ray query helper invocations 2022-04-14 marcin.zajac@mobica.com Modified ray tracing inactive triangle definition 2022-04-14 boris.zanin@mobica.com Add robustness2 limits validation test 2022-04-14 ari.suonpaa@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-04-14 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-es-cts-3.2.8 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,jonahr@google.com Change-Id: I1bf98d351a4b46a8898ddd92ebd8529a98d8565f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587530 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Sunny Sachanandani aefb2a99 2022-04-14T13:45:42 vulkan: Call glFinish in VulkanHelper destructor In async queue mode, GL commands are submitted asynchronously to the VkQueue on a separate thread. VulkanHelper destructor uses the VkQueue when it calls vkDeviceWaitIdle(), and that's a data race when the queue is being used to run GL commands on the other thread. Calling glFinish() before any Vulkan commands ensures that the queue isn't being used on another thread. Bug: angleproject:7204 Change-Id: I509bcf55edf430e39805a9d43c07a902942d33ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587366 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
angle-autoroll 4a33204c 2022-04-14T15:39:21 Roll VK-GL-CTS from 20a474e64382 to 2748d45ebbb4 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/20a474e64382..2748d45ebbb4 2022-04-14 quic_mnetsch@quicinc.com Merge pull request #312 from lfrb/windows-flush If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,jonahr@google.com Change-Id: I78beb41148488763fc7adf77887dc8c97cd6f239 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3586178 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 039660a0 2022-04-14T13:32:33 Translator: Drop const from opaque parameter types `const` is ineffective on opaque types like sampler2D. That qualifier is now dropped as it was tripping SPIR-V gen up. New validation is added to make sure such parameters are not reintroduced. Test credit of Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Test: angle_end2end_tests --gtest_filter="GLSLTest.ConstSamplerParameter*/*_Vulkan" Bug: angleproject:7201 Bug: angleproject:7205 Change-Id: I310a47a8eb162ddafb2ab44682520f546f8a5512 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3587345 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jonah Ryan-Davis 0360248c 2022-04-14T10:06:56 Suppress flaky end2end failures on Mac/NVIDIA/OpenGL These test recently started flaking: CopyTextureTest.CubeMapTarget/ES2_OpenGL CopyTextureTest.CubeMapTargetRGB/ES2_OpenGL CopyTextureTest.CubeMapTargetRGBA/ES2_OpenGL CopyTextureTest.CopyToMipmap/ES2_OpenGL BlitFramebufferTest.ScissoredMultisampleStencil/ES3_OpenGL BlitFramebufferTest.NonZeroBaseDestinationStencil/ES3_OpenGL BlendIntegerTest.MRTUnsigned/ES3_OpenGL BlendIntegerTest.MRTSigned/ES3_OpenGL DrawBuffersTest.BlendWithGaps/ES3_OpenGL Bug: angleproject:7206 Change-Id: I75563601f9f828d5c5fc2e8da6af66d21a2f6d30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3585891 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Lubosz Sarnecki 03b3bc3f 2022-04-08T13:36:50 Tests: Add Special Forces Group 2 trace. Ignore a SYNC-HAZARD-WRITE_AFTER_READ VVL error in RendererVk. Add GL_EXT_texture_buffer prerequisite. Test: angle_perftests --gtest_filter="*special_forces_group_2*" Bug: angleproject:5592 Change-Id: I63350a0bdbdffbc6951fd650753d900b5ff0bade Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3578764 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Peng Huang c3f15962 2022-04-14T10:11:56 Fix OOB problem in validationES.{h,cpp} maxVertexAttributes may less than the gl::MAX_VERTEX_ATTRIBS for some GLES2 devices, so using gl::MAX_VERTEX_ATTRIBS may cause OOB problem. Bug: chromium:1258869 Change-Id: I09609db35143fbf17b4228c7fe5f38a987e4f1d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3584637 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lubosz Sarnecki fef34a6e 2022-04-07T17:31:05 doc/DevSetup: Add Visual Studio Installer hint. Visual Studio Installer lists Windows 10 SDK versions in it's "Installation details", when modifiying the installation. The list might not contain the latest version of the SDK, which can be found under "Individual components" instead. Bug: angleproject:7018 Change-Id: I6a28afe4690a3c41667e4acb7cac4fe25495f779 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3571964 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 27b01dd4 2022-04-14T10:01:20 Roll SwiftShader from 011bba68c819 to 1d450ae99a0f (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/011bba68c819..1d450ae99a0f 2022-04-14 sugoi@google.com Stop building legacy SwiftShader GL in Chromium 2022-04-13 capn@google.com Alert about Legacy SwiftShader debug build usage 2022-04-13 swiftshader.regress@gmail.com Regres: Update test lists @ d621b4de 2022-04-13 capn@google.com Temporarily ignore unsupported feature struct If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I75ff94ceafcc463943c3bb2bc190dfb7ae4a637a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3586160 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Antonio Caggiano fcd6e260 2022-04-13T15:39:21 GN: Fix util target when X11 not enabled Include ozone util sources when both X11 and Wayland are not enabled. Bug: angleproject:6902 Change-Id: I88664bf2da7ce9094ed3168b765d4043aa5e16e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3583984 Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov b5d34da0 2022-04-11T18:17:03 Add src/tests/py_utils/ for utils, angle_path_util for imports. Detect if angle or chromium checkout when adding deps paths, so that random paths from above angle_root don't get added to sys.path when imported from an angle checkout. Bug: angleproject:6854 Change-Id: I4cd3334a2313d921f8651de7056f4f3798b8e072 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3582978 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 7e61e176 2022-04-14T07:44:36 Roll Chromium from 61150a1970a3 to e6765ea8299f (515 revisions) https://chromium.googlesource.com/chromium/src.git/+log/61150a1970a3..e6765ea8299f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cd7f6f6581..bb1c23c67d * buildtools/linux64: git_revision:ae110f8b525009255ba1f9ae96982176d3bfad3d..git_revision:c114b7e0b3a327e854cae6b560902230436f1ac7 * buildtools/mac: git_revision:ae110f8b525009255ba1f9ae96982176d3bfad3d..git_revision:c114b7e0b3a327e854cae6b560902230436f1ac7 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c39fea8873..bbcbce9968 * buildtools/win: git_revision:ae110f8b525009255ba1f9ae96982176d3bfad3d..git_revision:c114b7e0b3a327e854cae6b560902230436f1ac7 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6d2fe2e477..533b4e6461 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ef6cda3463..1f41b4fc8f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e9e999a4a8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3b97fa826e..3c6f0eb95f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b5e2f7c16b..d82302711f * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/6efd4ff844..087c7630a3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ff11f6105c..7b9534832c No update to Clang. Bug: angleproject:7003 Tbr: jonahr@google.com Change-Id: I55af9fd3487eca3f4fdd6e8ba908142366b33e12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3586175 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gregg Tavares 87187835 2022-04-07T13:51:10 Metal: For readPixels copy IOSurface to non-IOSurface texture For intel GPU/Drivers, it's faster to copy an IOSurface texture to a non-IOSurface texture and read from the copy than it is to read directly from the IOSurface texture. Bug: angleproject:7117 Change-Id: I786009444480f75be6feb05f09f87fb45a3186b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3573078 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com> Commit-Queue: Gregg Tavares <gman@chromium.org>
Gregg Tavares 52237c32 2022-04-13T18:32:29 Suppress CopyTextureTest.CopyToMipmap on Intel Mac OpenGL Bug: angleproject:7203 Change-Id: Ie30bea83f947ba56c0d75b32a910e305fa712b85 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3586170 Commit-Queue: Gregg Tavares <gman@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi d2fd28ca 2022-04-07T01:38:35 Vulkan: Relax advanced blend on VK extension requirement The GL spec actually requires that advanced blend be used on color output 0, so the check for advancedBlendMaxColorAttachments >= 8 was actually unnecessary. Bug: angleproject:3586 Change-Id: I32ce2a5912390d1a9a5d742ef0ca7cacc636e064 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3575739 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c5271e8e 2022-04-04T23:28:35 Vulkan: Emulate GL_KHR_blend_equation_advanced Based on a change by Brandon Schade <b.schade@samsung.com> In the translator, when advanced blend is enabled, an input attachment is added. Based on the listed advanced blend equations, emulation code is added that performs those equations' functions. The blend equation itself is passed through a driver uniform. Note that the advanced blend extension only allows a single output to use advanced blend, and that should be at location 0. In the Vulkan backend, when advanced blend is used, the driver uniform to select the equation is updated and normal blending is disabled. Bug: angleproject:3586 Change-Id: Icc42e8be238d34fca149087eb9cfe616a7643a6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3575738 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jonah Ryan-Davis 01c0bc21 2022-04-13T17:56:13 Revert "Vulkan: Support Wayland" This reverts commit 510351f2006e32ffc6da722f1fc9ea5666e9c0da. Reason for revert: Breaking ANGLE roll: https://bugs.chromium.org/p/angleproject/issues/detail?id=7202 Original change's description: > Vulkan: Support Wayland > > Implement DisplayVkWayland and WindowSurfaceVkWayland. Get window size > from native window and check egl config is just empty. > > Then add an EGL wayland test for testing rendering and buffers swapping. > > Bug: angleproject:6902 > Change-Id: I8204a5cc99f26330b74caba241bebf14c5650c2d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3395898 > Reviewed-by: mohan maiya <m.maiya@samsung.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:6902 Change-Id: Idd0cb78c84baeb1b2ab6910173160206901799f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3584921 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Shahbaz Youssefi af51a287 2022-04-12T11:04:30 Vulkan: Enum class instead of bool didRespecify Bug: angleproject:6909 Change-Id: I1e90df54f89717a419e6b647e5f2ee6972d9a904 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3583607 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e9d695b5 2022-04-13T12:42:27 Roll vulkan-deps from 345e2a278e69 to c9be322642fb (74 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/345e2a278e69..c9be322642fb Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/abbe466451..48fd6c82b3 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/0d4ce028bf..6a67891418 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/4995a2f272..9c3fd01c8a * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b0ce31fd2d..92c17edde7 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/0c5928795a..76f00ef6cb * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f8c97eea2f..f503824ff8 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/e494de740e..5f3ce24e7a * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/41eacec7dd..5501a60aa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Icccc8d3fcda61391c1d72111f61c08f29b4d3c0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3584976 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f00d827e 2022-04-13T10:01:20 Roll SwiftShader from 620982155d55 to 011bba68c819 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/620982155d55..011bba68c819 2022-04-12 capn@google.com Optimize sRGB conversion using FMA 2022-04-12 capn@google.com Fix storage image write of VK_FORMAT_B8G8R8A8_SRGB 2022-04-12 capn@google.com Refactor sRGB color space conversions 2022-04-12 swiftshader.regress@gmail.com Regres: Update test lists @ 62098215 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I225c3a15b18bdeeb671f7f93b66dc696d2cbc34a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3585254 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4b8e5db6 2022-04-13T07:19:36 Roll Chromium from f961a0d4732b to 61150a1970a3 (431 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f961a0d4732b..61150a1970a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8ad9c1c830..cd7f6f6581 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/936a348f0a..6d2fe2e477 * third_party/android_build_tools/aapt2: wicn5Ce1ay6ivbZ1GNFF0gRSS3NYv_7hJTPtVga3O-QC..u2Cw4baoLfvlEDMwcJjq9iOJRF0_2BjsgMFl7UhJxGAC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/a41aab7742..7876d5194b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..22aa2610ec * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/78263e3102..f70aa510c4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b92a448a92..ff11f6105c No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I76777246db00177571fdea0b2e2dc29364a0c0bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3584969 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gregg Tavares 985d4293 2022-04-08T11:47:34 Metal:Speed up BGRA8 to RGBA8 copy for readPixels On a 2048x2048 texture on Intel this goes from 26-27ms to 17-18ms Bug: angleproject:7117 Change-Id: I4f48521b64e54669d180f0d2d8fdda78f83f89b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3579510 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Shahbaz Youssefi 8074061d 2022-04-09T01:03:53 Remove feature override platform methods Instead, the tests now use the enable() functions to override the feature at platform level. This fixes the forceFallbackFormat feature mistakenly not having been tested. Bug: angleproject:6435 Change-Id: I605e4133407282bd52232887b595af0d2c13575d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3577369 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi a0b5299b 2022-04-12T00:38:50 Vulkan: Fix resolve with subpass into smaller framebuffer The condition to optimize resolve with subpass did not take into account that the resolve area must match the render pass are, neither did it disallow flipping and rotation. Bug: angleproject:7196 Bug: chromium:1314383 Change-Id: I57e50da4d6e04dfebcce3c0a5061015e5ee8773b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3581055 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 6768aff7 2022-04-07T23:25:08 Fix Geometry Shader Conformance Test Failure on Pixel6 Add code in shader linker stage to check the number of AtomicCounterBuffers against these values: GL_MAX_VERTEX_ATOMIC_COUNTER_BUFFERS GL_MAX_FRAGMENT_ATOMIC_COUNTER_BUFFERS GL_MAX_COMPUTE_ATOMIC_COUNTER_BUFFERS GL_MAX_GEOMETRY_ATOMIC_COUNTER_BUFFERS_EXT GL_MAX_COMBINED_ATOMIC_COUNTER_BUFFERS GL_MAX_TESS_CONTROL_ATOMIC_COUNTER_BUFFERS GL_MAX_TESS_EVALUATION_ATOMIC_COUNTER_BUFFERS Bug: angleproject:6918 Change-Id: If1c1d0dc2452f5aafc72d81f4f5523608810bba9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3576629 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Peng Huang 445bf9bd 2022-04-09T08:42:12 Use the real max vertex attrib index instead of MAX_VERTEX_ATTRIBS Bug: chromium:1258869 Change-Id: I7de23353fc6922be9b3201c87d33e0cfdc427569 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3580578 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Sunny Sachanandani d4cbd9bf 2022-04-11T16:55:39 vulkan: Mark external memory textures as preinitialized Textures initialized from external memory objects should be considered preinitialized so that they're not cleared on first access with robust resource init. This is essential for Vulkan-GL (WebGPU-WebGL) interop on Linux where Skia or Dawn could be first used to render into a VkImage backed by an external memory object, and a GL texture is created lazily on first GL access. This CL also includes an end-to-end test for such interop, and changes to support that test: 1) Add writePixels() to VulkanHelper to upload pixels to a VkImage 2) Detect external memory / semaphore extensions when VulkanHelper is initialized from ANGLE. 3) Allow importing external memory object that's larger than VkImage size requirements. Bug: angleproject:7188 Change-Id: I60c250b64df1766a179edd1cc67c3f0765e8aa0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3582954 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Yuly Novikov 291be0b7 2022-04-12T14:31:35 Suppress multisample_interpolation dEQP failures on Pixel 6 Vulkan 16 tests started failing after upgrading phones to Android 13 DP2 Bug: angleproject:6876 Change-Id: I9b965bf6a835cda7fad82c27110cdf38b88c6cb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3584386 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Stephen White 9442b7a8 2022-04-12T12:07:47 D3D: Remove a pass-through function. Bug: angleproject:7199 Change-Id: I6d10cb74640eb3be301209f510a52111ce88d5da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3583608 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Charlie Lao 957f8297 2022-04-08T15:44:55 Vulkan: Change ContextVk to Context for BufferPool APIs These APIs only needs information from Context, not ContextVk. This CL changes to Context for better encapsulation. Bug: b/223428306 Change-Id: I4f50aaa4065eff62ca32e9049f5a891d8814e511 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3578587 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Antonio Caggiano 510351f2 2021-12-09T16:52:35 Vulkan: Support Wayland Implement DisplayVkWayland and WindowSurfaceVkWayland. Get window size from native window and check egl config is just empty. Then add an EGL wayland test for testing rendering and buffers swapping. Bug: angleproject:6902 Change-Id: I8204a5cc99f26330b74caba241bebf14c5650c2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3395898 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Antonio Caggiano <antonio.caggiano@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov ea86cfd2 2022-04-12T09:06:17 Roll chromium_revision f89964bd5b..f961a0d473 (990903:991486) Switch Pixel 6 from Android 12 (S) to Android 13 (T). Change log: https://chromium.googlesource.com/chromium/src/+log/f89964bd5b..f961a0d473 Full diff: https://chromium.googlesource.com/chromium/src/+/f89964bd5b..f961a0d473 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2c3758a417..8ad9c1c830 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/75cd8f7f15..936a348f0a * third_party/android_ndk: https://chromium.googlesource.com/android_ndk.git/+log/9644104c8c..8388a2be54 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0e3c38595b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e222245128..3b97fa826e * third_party/turbine: CJm6IViplElcjFYLJc0XtAjZ97BOVjQIwigcJN6C9gsC..y4x80kUnDOxC5QyG48MlVoiRIEn09eaHcIJQFavlqgMC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c61f267866..a6d209ab93 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3eacd6cee1..b5e2f7c16b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6de0b20e70..78263e3102 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6abc0266d4..b92a448a92 DEPS diff: https://chromium.googlesource.com/chromium/src/+/f89964bd5b..f961a0d473/DEPS No update to Clang. Bug: angleproject:6819 Change-Id: I93514068385887ad2bfc63184474fa9bc7a0d060 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3583150 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Steven Noonan fb093278 2022-04-11T14:48:17 egl_angle_ext: add more missing extension enum values I was going to do this bit-by-bit, but there are just too many of them, so I'm lumping as many of these enums into one commit as I can. I basically went through all the extensions/EGL_* files and found all the enum definitions there and added them to the xml. Bug: angleproject:7193 Change-Id: Idaffd283e9118abf84bdff9c4e140334a1f8ee06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3582939 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 93ccde91 2022-04-06T19:55:23 Update ANGLE's docs regarding Windows 10 SDK version to use Bug: chromium:1292528 Change-Id: I5ccfcc477a96f1e84814106c47e2a359b312633d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3573391 Reviewed-by: Stephen White <senorblanco@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Steven Noonan 19582d12 2022-04-11T14:28:35 gl_angle_ext.xml: treat glProvokingVertexANGLE as alias This allows an OpenGL loader to alias glProvokingVertex and glProvokingVertexANGLE function pointers. In my case, it helps with the GLAD loader when using the --alias option. Bug: angleproject:7193 Change-Id: Id7e6318a5ee1f1b172f0499fc01dd080442471b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3582519 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll fec9c918 2022-04-12T10:01:19 Roll SwiftShader from d15c42482560 to 620982155d55 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/d15c42482560..620982155d55 2022-04-11 capn@google.com Work around MSan false positives for Reactor routine parameters 2022-04-11 capn@google.com Pass RoutineT::operator() parameters by value If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Id52509651ebbf8a04cca5f27cf22a01395ae1f4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3579460 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi aed5951e 2022-03-29T16:29:58 Reland "Vulkan: Fix texture-after-framebuffer sync issues" This is a reland of commit 535cd538f3585b44855647339f04bae1c1acf63a Original change's description: > Vulkan: Fix texture-after-framebuffer sync issues > > In TextureVk::syncState, for various reasons, the underlying image may > need to be respecified. For example because base/max level changed, > usage/create flags have changed, the format needs modification to become > renderable, generate mipmap is adding levels, etc. > > Currently, ANGLE syncs FramebufferVk before TextureVk for the sake of > the deferred clear optimization. This means that if the texture needs > to recreate its underlying image, it needs to do so earlier than its own > syncState, and do so in FramebufferVk::syncState through the > TextureVk::getAttachmentRenderTarget function. > > Over time, TextureVk::getAttachmentRenderTarget was modified to do parts > of what TextureVk::syncState did for this matter as bugs were > discovered, and more continue to be discovered. The bug that prompted > this change is missing image recreation when usage/create flags change. > > In this change, the relevant code in TextureVk::syncState is refactored > in a helper that's called by TextureVk::getAttachmentRenderTarget. This > way, the two functions should always be in agreement, avoiding > TextureVk::syncState recreating the image after > FramebufferVk::syncState, leading to use-after-free bugs. > > Bug: angleproject:4418 > Bug: angleproject:6909 > Bug: chromium:1266094 > Bug: chromium:1296866 > Change-Id: I856a34ca5cf573578c771f5adbeb9208420a3f62 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3557817 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:4418 Bug: angleproject:6909 Bug: chromium:1266094 Bug: chromium:1296866 Change-Id: I0110eab88eb9d8f77e204b84a6e90308e2384fd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3572715 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 797e627e 2022-04-08T22:49:51 Autogenerate list of features as enum The WithX() and WithNoX() helpers are removed and replaced with enable() and disable() member functions that take the name of the feature (as a Feature::X enum constant). This has two benefits: - Adding tests that override a feature no longer requires additional helper functions to be written. - There's no mistaking the feature name. This change doesn't yet fix the main issue in anglebug.com/6435, but does fix the following helpers using an old feature name (so they were ineffective): - WithMetalForcedBufferGPUStorage - WithNoVulkanViewportFlip A follow up would remove the old way of overriding features in tests and replaces them with the new way. Bug: angleproject:6435 Change-Id: Ida02b26ec72bc40d7a8938c76a93815bb903ca05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3580982 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi eeb39653 2022-04-08T16:09:48 Autogenerate features Features are now specified in a json file and autogenerated. This is in preparation for more autogeneration to support feature override in tests. This change doesn't yet fix the issues in anglebug.com/6435 and should be a no-op. Bug: angleproject:6435 Change-Id: Icdb63a94dc37b5fef0a356e0fc0b49937e083c8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3579941 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gregg Tavares 9237272f 2022-03-31T14:15:43 Metal:remove TextureMtl::mIsPow2 Bug: angleproject:7147 Change-Id: I60876d719989311de07ad97f1be5daecb83c3801 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3564276 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com> Commit-Queue: Gregg Tavares <gman@chromium.org>
Kimmo Kinnunen e08476cf 2022-04-05T14:48:52 Metal: Avoid leaking MTLDevice lists in DisplayMtl Hold the lists via ObjCObj<>. Patch by David Kilzer <ddkilzer@apple.com> Bug: angleproject:6920 Change-Id: Ia25cd59b0dd2e81367d8bf5ca50a22ca02547940 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3568381 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Kimmo Kinnunen 1b2adb40 2022-04-05T15:14:55 Metal: Avoid leaking MTLFunctionConstantValues in ProgramMtl Hold with ObjCObj<>. Patch by David Kilzer <ddkilzer@apple.com> Bug: angleproject:6920 Change-Id: I635097100b1e004e9276490ff8574870e1c5f33f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3568379 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Steven Noonan a201bbc9 2022-04-11T13:59:36 egl_angle_ext.xml: add missing enums and typedefs This is necessary for a loader like GLAD to generate a correct egl.h header with ANGLE extensions. Bug: angleproject:7193 Change-Id: Id3f07ffee216890418b202520fccff7ccfcaa6dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3582273 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 5c85fd4e 2022-04-11T12:29:00 Add error check on resuming XFB with deleted buffer. Bug: chromium:1305190 Change-Id: I22c6f6400b05ca32c922fba9a3b9d4b5841ca8b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3578378 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis a947c5f5 2022-04-11T14:19:08 Skip BlitFramebufferTest.ScissoredMultisampleStencil This test started flaking recently on Mac/NVIDIA. Suppress the failures for now. Also update existing suppression to be in the main test expectations file. Bug: angleproject:7191 Bug: angleproject:3496 Change-Id: I54c4def7382bee4784dcfe8ffdc3c51db1cc91d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3582638 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Steven Noonan fb91e27c 2022-04-03T17:18:44 add GL_ANGLE_robust_resource_initialization extension to xml Bug: angleproject:7165 Change-Id: I17a566714bc3e1a0e19dee4bdea10c7360050172 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3567539 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Stephen White 6803a2d0 2022-04-01T16:52:49 D3D11: implement SSBOs in pixel and vertex shaders. Since the 'u' register space for UAVs in pixel shaders is shared with render targets, and the number of render targets may vary depending on GL state, this required deferring register allocation until draw-time output in DynamicHLSL. Since non-compute shaders aren't able to immediately output the SSBO declaration, initial register allocation was broken out from ResourcesHLSL::shaderStorageBlocksHeader() into ResourcesHLSL::allocateShaderStorageBlockRegisters() with the former only called for compute shaders. These initial allocations are offset by the number of RTs at draw time. Since Raw UAVs may now be created at draw time for non-compute shaders, call markRawBufferUsage() from the Renderer11::draw*() entry points as it is from dispatchCompute*(). Bug: angleproject:7156 Change-Id: I6ab65af1ff36df0313e3c1f8f79661b1547ab9a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3565562 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Geoff Lang c458b5ad 2022-04-01T11:38:17 Fix CheckedNumeric using the wrong type. Validation for glBufferSubData checks that the buffer is large enough for size+offset but verifies they fit in a size_t which is a different type than the deduced type for size+offset on 32-bit systems. Use decltype to ensure that we always verify there is no overflow on the correct type. Bug: chromium:1298867 Change-Id: I82f534b2d227d3273a763e626ebeae068dc918dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3563515 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Peng Huang 04782d86 2022-04-09T08:26:52 Validate vertex attrib index against caps.maxVertexAttributes Bug: chromium:1258869 Change-Id: I2d2c45b11177b0f6f4785a894c15357515b33e9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3580577 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 767b6593 2022-04-11T14:51:21 Roll VK-GL-CTS from 6f8a7182bd26 to 20a474e64382 (14 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/6f8a7182bd26..20a474e64382 2022-04-08 ari.suonpaa@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-04-08 ari.suonpaa@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-04-08 ari.suonpaa@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-04-08 ari.suonpaa@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-04-08 ari.suonpaa@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-04-08 r.potter@samsung.com Add vkGetDeviceQueue2 tests for Protected memory feature 2022-04-08 rgarcia@igalia.com Check conditional rendering with non-zero memory offset 2022-04-08 juha.heiskanen@siru.fi Add coverage for IsHelperInvocationEXT 2022-04-08 quic_mnetsch@quicinc.com Add notice of withdrawal for 1.2.6.x 2022-04-08 juha.heiskanen@siru.fi InterpolateAt{Offset, Sample} with linear interpolation tests 2022-04-08 martin.freebody@arm.com Image extended usage should include VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT 2022-04-08 ari.suonpaa@siru.fi Add a batch of GraphicsFuzz coverage tests 2022-04-08 rgarcia@igalia.com Fix freeing custom device in dynamic state tests 2022-04-08 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,jonahr@google.com Change-Id: I7e4b8db46e6c6e13605244db339fc9abb4fb57d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3582259 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b120ab6d 2022-04-11T07:28:35 Roll Chromium from a01c0c749d0a to f89964bd5b42 (617 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a01c0c749d0a..f89964bd5b42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5fcf2fff1d..2c3758a417 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ed21e7f5cc..e025ba5dc8 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/cb96c63d05..c39fea8873 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/88a842a58b..75cd8f7f15 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4326c47b24 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e121d14b12..e222245128 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4cc1d5fe48..3eacd6cee1 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/d8c2279558..6efd4ff844 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/eb5f7b55cf..6abc0266d4 Clang version changed llvmorg-15-init-6778-g3e8c4366:llvmorg-15-init-7040-g50de659a Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/4cc1d5fe48c190668e377c123c2066f3a9ea95ba..3eacd6cee13a8e9a86a74fcaa5532eeb3aec676c/scripts/update.py Bug: None Tbr: ynovikov@google.com Change-Id: Ic0e084bac64f0dad718e4ae8991d32990a45a6ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3579998 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 1b94c585 2022-04-10T15:09:38 Revert "Vulkan: Switch loader to new driver files env var." This reverts commit 1f6123d55467c2af7c67405c0101a6f327b76225. Reason for revert: Seems to break ANGLE on fuchsia loader: https://ci.chromium.org/ui/p/chromium/builders/try/fuchsia_arm64/1123629/overview Original change's description: > Vulkan: Switch loader to new driver files env var. > > VK_DRIVER_FILES replaces VK_ICD_FILENAMES. > > Bug: angleproject:7095 > Change-Id: I949ac9a8f375240b6c6068825eccc645f81b0185 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3522821 > Reviewed-by: Ian Elliott <ianelliott@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:7095 Change-Id: I5b7e094b08d76b9c14adb4acb3b59e4cfb7a28fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3580980 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Brian Sheedy 727cd8ef 2022-04-08T16:36:22 Fix pointer sscanf for ChromeOS Fixes several sscanf calls in crash_handler_posix.cpp failing to compile when compiling for ChromeOS kevin (arm-based) devices due to trying to format an unsigned int as an unsigned long. This is fixed by switching to SCNxPTR/PRIXPTR for the format strings instead of hard coding %lX. Bug: chromium:1314515 Change-Id: I012a1a74312ba653e34145883955f2d0e1ef031f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3579867 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Peng Huang 92e99653 2022-04-08T16:33:42 Fix crashes in gl::VertexArray::detachBuffer() and onDestory() The crashes is because gl::MAX_VERTEX_ATTRIB_BINDINGS(16) is used for iterating mState.mVertexBindings. However it's size is not always 16. It can be 8 for some PowerVR GPU with GLES 2 driver. Bug: chromium:1258869 Change-Id: I3b572d153cb16fb46920483612e3cdbc6ee57577 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3577813 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Jamie Madill 4b381f41 2022-04-08T09:20:45 Vulkan: Fix descriptorSet perf counter values. Some counters were getting reset in multiple places, which could result in queries returning zero counts. Fix this by consolidating per-frame counter resets. Also updates how we compute cache hit/miss counters. This results in correct and consistent counts for cache accesses. Also includes a fix to not update the overlay when there are no enabled widgets. Also does away with some of the object- specific perf counters that were made to track descriptor set allocations. Bug: angleproject:6776 Change-Id: I769c715986defc50f0cfd0d997c338d34174e9f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3573389 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 09a24f3d 2022-04-08T10:01:20 Roll SwiftShader from d09282e5c609 to d15c42482560 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/d09282e5c609..d15c42482560 2022-04-07 cwallez@google.com VkImage::copy remove the isEntireRow/Slice optimizations 2022-04-07 swiftshader.regress@gmail.com Regres: Update test lists @ d09282e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I0a1809ab05fcb394be0869a5c223ca1669472d6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3578623 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5a16a1f9 2022-04-08T07:01:48 Roll Chromium from 64472fba3112 to a01c0c749d0a (448 revisions) https://chromium.googlesource.com/chromium/src.git/+log/64472fba3112..a01c0c749d0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e3c8941627..5fcf2fff1d * buildtools/linux64: git_revision:04a2891d554d2325f04631bac356c29ffcdebf2a..git_revision:ae110f8b525009255ba1f9ae96982176d3bfad3d * buildtools/mac: git_revision:04a2891d554d2325f04631bac356c29ffcdebf2a..git_revision:ae110f8b525009255ba1f9ae96982176d3bfad3d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ac492da4a7..ed21e7f5cc * buildtools/win: git_revision:04a2891d554d2325f04631bac356c29ffcdebf2a..git_revision:ae110f8b525009255ba1f9ae96982176d3bfad3d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f62b3f1eef..88a842a58b * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/be0731f39e..a41aab7742 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5af479bbf8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0a6b544e20..e121d14b12 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/1d207dc895..b3054f7a3a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3436376526..4cc1d5fe48 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/70c55c2905..6de0b20e70 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/7b0a74688f..d8c2279558 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4bab7689e8..eb5f7b55cf Clang version changed llvmorg-15-init-5937-g23b3df56:llvmorg-15-init-6778-g3e8c4366 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/3436376526a513d23861b1bf0c3c0c07f68ff2c5..4cc1d5fe48c190668e377c123c2066f3a9ea95ba/scripts/update.py Bug: None Tbr: jmadill@google.com Change-Id: I94fe31e2a06ef2080ac0c9aa0050dd1c3f4f7c35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3578572 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 3cea7fcc 2022-03-16T16:33:43 Split Context ResourceUseList to RP Commandbuffers * Added mResourceUseList to each command buffer helper in an effort to move mResourceUseList away from ContextVk. * submitFrameImpl() renamed to submitCommands() * Moved the functions acquireResourceUseList() and onRenderPassFinished() in submitCommands() to the submitFrame functions calling it. Bug: angleproject:7103 Change-Id: I2487d5b86ea0a4d504f283aa7128501651317fe0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3531368 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Gregg Tavares ac130106 2022-04-04T13:46:01 Metal: Remove Unused IOSurface code Bug: angleproject:7171 Change-Id: I6eaf9c1194a26c96f4566f5bcc386330df66b870 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3569588 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Jamie Madill 1f6123d5 2022-03-14T11:40:05 Vulkan: Switch loader to new driver files env var. VK_DRIVER_FILES replaces VK_ICD_FILENAMES. Bug: angleproject:7095 Change-Id: I949ac9a8f375240b6c6068825eccc645f81b0185 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3522821 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi a16491d9 2022-04-05T16:47:32 Vulkan: Fix invalidation of non-existing aspects If the app uses a stencil-only attachment but invalidates depth, UNREACHABLE was hit. If the app uses a depth-only attachment but invalidates stencil, ANGLE was proceeding with an attempt to invalidate it (with no side effect). Bug: angleproject:7178 Change-Id: Idc177bdb66b2d0b3b3c2d36f5cadc7b9126a42c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3573383 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll d6ff967e 2022-04-07T10:01:20 Roll SwiftShader from d3cc7d7ac0c3 to d09282e5c609 (6 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/d3cc7d7ac0c3..d09282e5c609 2022-04-07 sugoi@google.com Temporarily fix failing dEQP tests 2022-04-06 sugoi@google.com Update Vulkan headers to version 1.3.211 2022-04-06 sugoi@google.com Fix reading 0 sized scissor array 2022-04-06 capn@google.com Only build WSI support for XCB surfaces when xcb.h is found 2022-04-06 capn@google.com Use 'discard' to denote terminated or demoted invocations 2022-04-06 swiftshader.regress@gmail.com Regres: Update test lists @ d3cc7d7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I875d468f81014b27a8f0428e2275448fb331d13a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3575851 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b7e8ab48 2022-04-07T08:57:36 Roll Chromium from 6f6eb80eab19 to 64472fba3112 (509 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6f6eb80eab19..64472fba3112 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8565c54a97..e3c8941627 * buildtools/linux64: git_revision:5eb3845ec2d8296b4f41da4eca85302eb111fe69..git_revision:04a2891d554d2325f04631bac356c29ffcdebf2a * buildtools/mac: git_revision:5eb3845ec2d8296b4f41da4eca85302eb111fe69..git_revision:04a2891d554d2325f04631bac356c29ffcdebf2a * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/185051038f..ac492da4a7 * buildtools/win: git_revision:5eb3845ec2d8296b4f41da4eca85302eb111fe69..git_revision:04a2891d554d2325f04631bac356c29ffcdebf2a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/770c3c28e6..f62b3f1eef * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/02654402b1..ef6cda3463 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5ff11ff500 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ffeef9001e..0a6b544e20 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/3b1df9d41c..c61f267866 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bd06a4fb2e..3436376526 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/475858f8ee..70c55c2905 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/821dbcc2a3..7b0a74688f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b6753091d7..4bab7689e8 No update to Clang. Bug: angleproject:6430 Tbr: jmadill@google.com Change-Id: Ifb3cca2a56301126b180a08de35e7c7c5a0340d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3575599 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen ba04fcfd 2022-03-11T13:58:52 Support ANGLE_PREFERRED_DEVICE on CGL Add the possibility to test both integrated and discrete GPU with ANGLE tests. Previously it was using only discrete. The binaries need the NSSupportsAutomaticGraphicsSwitching bundle property. This is needed to test ANGLE_power_preference. Changes the behavior of test apps: Previously, ./angle_end2end_tests would use discrete GPU. After, ./angle_end2end_tests or ANGLE_PREFERRED_DEVICE=intel ./angle_end2end_tests will use integrated GPU. ANGLE_PREFERRED_DEVICE=amd ./angle_end2end_tests will use discrete GPU. Bug: angleproject:7093 Change-Id: Ia64f6024e3215e69c2a1bde3ba4f67c3ca595476 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516114 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 23558369 2022-04-06T15:41:59 Update perf tests arguments. Bug: angleproject:6776 Change-Id: I3cf51cdf9ad05dc792126354c84e717574638408 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3566219 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Stephen White f36dde31 2022-03-31T10:33:41 D3D: remove NV GetDimensions() workaround for image load/store. RWTexture2D only has the 2-param version of GetDimensions(), since it already refers to a single mip and layer. So this workaround just causes compile failures. Bug: angleproject:7121 Change-Id: I675eaf9ffadd75e186423a55bc9822e00432f89e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3566218 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 7a9856f6 2022-04-05T19:25:26 Report durations of all flaky retries in JSON test output Bug: angleproject:7184 Change-Id: I19295daed7b13919a2b528a43ebe8d9cbac9d0a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3572713 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Nathan Zabriskie 9d486a85 2022-04-01T11:48:58 GL: Unbind textures from FBO after calls to frameBufferTexture2D OOPR canvas uncovered an Nvidia driver bug in which binding a texture level > 0 to a framebuffer and then later binding a renderbuffer to the same FBO causes the FBO to be marked as having an incomplete attachment. This CL expands UnbindResources() in BlitGL.cpp to unbind textures in addition to RBOs and adds new calls to unbind in functions that call framebufferTexture2D. Also adds a GL workaround--alwaysUnbindFramebufferTexture2D-- that forces FramebufferGL to first unbind any existing attachments using framebufferTexture2D before attaching a new render buffer. Bug: angleproject:5536 Change-Id: I46c115b3895f8fccb251dbf4531d5c1bd4705ebc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3527465 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cody Northrop a1c9ba70 2022-04-04T11:29:13 Update validation of glFramebufferTextureLayer for cube maps The ES 3.2 spec explicitly mentions cube map parameters for the call: For cube map textures, layer is translated into a cube map face as described in table 8.24. For cube map array textures, layer is translated into an array layer and a cube map face as described for layer-face numbers in section 8.5.3 but does not list it when enumerating errors: An INVALID_OPERATION error is generated if texture is non-zero and is not the name of a three-dimensional, two-dimensional array, two-dimensional multisample array or cube map array texture. There is a bug filed about this: https://gitlab.khronos.org/opengl/API/-/issues/134 Per discussion, it should not be an error to use a cube map with glFramebufferTextureLayer. It will be fixed in the spec. Test: DrawBuffersTestES3.CubeMapTextures Test: DrawBuffersTestES3.CubeMapArrayTextures Bug: angleproject:7168 Bug: angleproject:7169 Change-Id: I6ef9af4b2bf05dc2dee841c68fb4f896c30c8c03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3569337 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 152616ee 2022-04-04T19:34:53 Tests: Add Aztec Ruins High trace Test: angle_perftests --gtest_filter="*aztec_ruins_high*" Bug: angleproject:7169 Change-Id: I3d30348f663a4b1c54df1179d471363ca4c244c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3570244 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 06c201f8 2022-04-06T10:01:20 Roll SwiftShader from 1b159f6cdecb to d3cc7d7ac0c3 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/1b159f6cdecb..d3cc7d7ac0c3 2022-04-05 capn@google.com Remove unsupported extension feature enums If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ib85c74de05130bb8e95177f5934d7b0eaaea85fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3574087 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b4eaa3a2 2022-04-06T08:18:36 Roll Chromium from 3c01a5c3bc2f to 6f6eb80eab19 (52 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3c01a5c3bc2f..6f6eb80eab19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e5b74ea1b0..8565c54a97 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/82dc0f8608..770c3c28e6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ec5b008938 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/22ea4f7b4c..475858f8ee * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ecc79735cb..b6753091d7 No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I4ef8413bc4931c45c3ff1c4af978b20f5139ebca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3574249 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ff9bd35d 2022-04-06T04:49:54 Roll Chromium from c32f123be7eb to 3c01a5c3bc2f (107 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c32f123be7eb..3c01a5c3bc2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e9d82df111..e5b74ea1b0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e14b3c2330..82dc0f8608 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ec5b008938 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2ca0f52443..ffeef9001e No update to Clang. Bug: None Tbr: jmadill@google.com,ynovikov@google.com Change-Id: I1da447ea3d78ceef7ea7c599dd0c47be6333a732 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3572978 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bac8915c 2022-04-05T22:08:55 Roll Chromium from f39b4372b8a8 to c32f123be7eb (777 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f39b4372b8a8..c32f123be7eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d162691495..e9d82df111 * buildtools/linux64: git_revision:859dde4a7f34a4383179522f8e1061dcffac8691..git_revision:5eb3845ec2d8296b4f41da4eca85302eb111fe69 * buildtools/mac: git_revision:859dde4a7f34a4383179522f8e1061dcffac8691..git_revision:5eb3845ec2d8296b4f41da4eca85302eb111fe69 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e9c9bdf975..185051038f * buildtools/win: git_revision:859dde4a7f34a4383179522f8e1061dcffac8691..git_revision:5eb3845ec2d8296b4f41da4eca85302eb111fe69 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2575976cb8..e14b3c2330 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3d369206ad * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a9c548efd6..2ca0f52443 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d1aa7af3b0..3b1df9d41c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c8e9f238ae..bd06a4fb2e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8e9cb9f939..22ea4f7b4c * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/ff56ec6dea..821dbcc2a3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5445d7abdf..ecc79735cb Clang version changed llvmorg-15-init-3677-g8133778d:llvmorg-15-init-5937-g23b3df56 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/c8e9f238ae062be7183109c794791150597847d3..bd06a4fb2e86c181ed0506c32293fb0459e72bb0/scripts/update.py Bug: None Tbr: jmadill@google.com,ynovikov@google.com Change-Id: Ib5d718e9cdfa65b499c891fe4401443cd7698859 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3572972 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 366f6011 2022-04-05T22:35:26 Roll vulkan-deps from 6d732e01d9ea to 345e2a278e69 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6d732e01d9ea..345e2a278e69 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bd325d2984..b0ce31fd2d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/fbc48cff34..41eacec7dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jmadill@google.com,ynovikov@google.com Change-Id: I134e412208a7a9dcdcda1af3aece33a5abc94ce9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3572974 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Amirali Abdolrashidi 607d398e 2022-03-14T16:32:21 Vulkan: Optimize resolve of multisample swapchains * Resolves the multisampled image if the last render pass draws into the default framebuffer. * Added test to check the number of resolves in the optimization subpass (credit: Xinyi He) * Added test to check the number of resolves outside the subpass. * Added disabled test to see if the subpass resolve works. Bug: angleproject:6762 Change-Id: I86a8db3387851ab97d5f7a3d8a0ff26961254c14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3523062 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
kmx.io     mail     discord kmxgit v0.4.0